GNU bug report logs - #56366
29.0.50; eww: Exclude radio links when suggesting URIs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56366 in the body.
You can then email your comments to 56366 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; eww: Exclude radio links when suggesting URIs 
Date: Sun, 03 Jul 2022 13:09:21 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

If the point is over a radio button in *eww*, and you press M-s M-w,
then an error is raised with the following backtrace

    Debugger entered--Lisp error: (wrong-type-argument stringp (input ((type . "radio") (name . "type") (id . "filter-type-show") (value . "show"))))
      intern-soft((input ((type . "radio") (name . "type") (id . "filter-type-show") (value . "show"))) [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0])
      eww-suggested-uris()
      byte-code("\301 \302\303\304\3\205\13\0\3@\"\305\306\4$\10D\207" [current-prefix-arg eww-suggested-uris read-string format-prompt "Enter URL or keywords" nil eww-prompt-history] 6)
      call-interactively(eww)
      eww-search-words()
      funcall-interactively(eww-search-words)
      call-interactively(eww-search-words nil nil)
      command-execute(eww-search-words)

This is easy to reproduce:

    1. M-s M-w yewtu.be/search?q=test RET
    2. Move the point to one of the radio buttons.
    3. Say M-s M-w.

The attached patch fixes the error but maybe the right place to fix it
is in eww-links-at-point?

[0001-Exclude-radio-buttons-when-suggesting-URI-in-eww.patch (text/x-diff, attachment)]

Message #8 received at 56366 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56366 <at> debbugs.gnu.org
Subject: Re: bug#56366: 29.0.50; eww: Exclude radio links when suggesting URIs 
Date: Sun, 03 Jul 2022 14:33:18 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> The attached patch fixes the error but maybe the right place to fix it
> is in eww-links-at-point?

Yes, I think that would be better.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 56366 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56366 <at> debbugs.gnu.org
Subject: Re: bug#56366: 29.0.50; eww: Exclude radio links when suggesting URIs
Date: Sun, 03 Jul 2022 18:53:08 +0530

[Message part 1 (text/plain, inline)]

[ஞாயிறு ஜூலை 03, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> The attached patch fixes the error but maybe the right place to fix it
>> is in eww-links-at-point?
>
> Yes, I think that would be better.

How about the attached patch?

[0001-Exclude-radio-buttons-when-suggesting-URI-in-eww.patch (text/x-diff, attachment)]

Message #14 received at 56366 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56366 <at> debbugs.gnu.org
Subject: Re: bug#56366: 29.0.50; eww: Exclude radio links when suggesting URIs
Date: Sun, 03 Jul 2022 15:29:54 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> How about the attached patch?

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 56366 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56366 <at> debbugs.gnu.org
Subject: Re: bug#56366: 29.0.50; eww: Exclude radio links when suggesting URIs
Date: Sun, 03 Jul 2022 19:09:13 +0530

[ஞாயிறு ஜூலை 03, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> How about the attached patch?
>
> Thanks; pushed to Emacs 29.
Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.