From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] gnu: srt: Update to 1.4.4 (fix test failure on AArch64) Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16567888666250 (code B ref -1); Sat, 02 Jul 2022 19:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jul 2022 19:07:46 +0000 Received: from localhost ([127.0.0.1]:42864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT4-0001ci-45 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:37518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT1-0001cX-7q for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iT1-0001OV-3s for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iSy-0003L5-R1 for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:42 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 155546190C for ; Sat, 2 Jul 2022 19:07:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCe7RZHwF_9i for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id A5721617F0 for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:07:29 -0400 Message-Id: X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Here's a patch series that - Updates SRT, the "Secure Reliable Transport" for audio/video streams, to 1.4.4, fixing a test failure on AArch64 and likely other non-Intel/AMD platforms[0]; - Updates the srt package itself to remove input labels; - Updates the vlc package to use the now-current version of SRT instead of an older version[1]; - Removes that older (and now unnecessary) version of srt from the package repository; and - Updates the vlc package to remove input labels and to add "bash-minimal" to its inputs, silencing a warning from "guix lint". I'm aware SRT 1.5.0 is also available, but - Version 1.4.4 is the latest version supported by VLC; - Version 1.5.0 introduces API/ABI changes that are likely to cause problems elsewhere; and - I just need to get my systems updating again. (I can look at submitting another patchset later.) I've tested these patches on x86-64 and AArch64 and in general, everything looks fine. With regards to SRT's immediate dependents, ffmpeg@4.4.2, ffmpeg@5.0.1, gst-plugins-bad and and vlc: - All four dependents build without issue on x86-64. - On AArch64, VLC and the two FFmpeg packages build just fine. Building gst-plugins-bad means building the entire Rust toolchain and potentially other packages that are infeasible to build on garden-variety AArch64 hardware, so I haven't been able to test this. - Nonetheless I've verified that on both architectures, VLC built with these patches connects to and plays a SRT video stream just fine.[2] On x86-64 I've tested building all of SRT's 299 dependent packages and this completes without any _new_ build failures: ams-lv2, dvdstyler, lv2-mda-piano and lv2-mda-epiano are all currently broken on x86-64, and it appears my system is unable to build curl 7.84.0 for i686-linux either with or without these patches applied. [0] The failure involves an unnecessarily-short timeout period in the "SyncEvent.WaitForTwoNotifyOne" unit test, which was adjusted in upstream commit e2a00aa: https://github.com/Haivision/srt/commit/e2a00aa03a36e153ab8cfe2c0790f7bf43747d8d It's unlikely this affects only AArch64. A Debian developer notes in this GitHub issue that SRT test failures are common on other, older and mostly non-Intel/AMD architectures as well: https://github.com/Haivision/srt/issues/2267 [1] VLC was updated to build with SRT version 1.4.4 by default in upstream commit 9a28929 this past February, making the comment above the srt-1.4.1 package (in gnu/packages/networking.scm) obsolete. Since neither of the other packages mentioned still use this older version of SRT, nor does any other, the package is no longer needed. https://code.videolan.org/videolan/vlc/-/commit/9a289291d01a393294c62ee7406487f59e25f4ed [2] I'd also like to verify that VLC can _output_ a video stream using SRT but despite an "SRT" output-access module appearing in the configuration settings I can't see how this is meant to work, using either the original or the patched build of VLC. If anyone relies on this functionality and can give me straightforward instructions for testing it I'll be happy to do so before this patch series is committed. --- Simon South (6): gnu: srt: Remove input labels. gnu: srt: Update to 1.4.4. gnu: vlc: Use regular srt. gnu: Remove srt-1.4.1. gnu: vlc: Remove input labels. gnu: vlc: Add bash-minimal as an input. gnu/packages/networking.scm | 26 +----- gnu/packages/video.scm | 155 ++++++++++++++++++------------------ 2 files changed, 79 insertions(+), 102 deletions(-) base-commit: 48ff4bfcd7491c12248b34a82e0b8e8a50a86308 -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 4/6] gnu: Remove srt-1.4.1. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890436709 (code B ref 56361); Sat, 02 Jul 2022 19:11:01 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:43 +0000 Received: from localhost ([127.0.0.1]:42875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVu-0001k7-Pt for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVs-0001jN-AY for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:40 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 196D4E254D for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFmouDY_Wzmp for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id C050FE23C3 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:29 -0400 Message-Id: <40e9f111d35bda2cf7e0ae572fad65b1c83b1752.1656784965.git.simon@simonsouth.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/networking.scm (srt-1.4.1): Delete variable. --- gnu/packages/networking.scm | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index a312e461d5..b26ef100f6 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -499,24 +499,6 @@ (define-public srt (home-page "https://www.srtalliance.org/") (license license:mpl2.0))) -;; FFmpeg, GStreamer, and VLC don't support SRT 1.4.2 yet. -(define-public srt-1.4.1 - (package - (inherit srt) - (name "srt") - (version "1.4.1") - (source - (origin - (method git-fetch) - (uri - (git-reference - (url "https://github.com/Haivision/srt") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "01xaq44j95kbgqfl41pnybvqy0yq6wd4wdw88ckylzf0nzp977xz")))))) - (define-public lksctp-tools (package (name "lksctp-tools") -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 3/6] gnu: vlc: Use regular srt. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890436716 (code B ref 56361); Sat, 02 Jul 2022 19:11:02 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:43 +0000 Received: from localhost ([127.0.0.1]:42877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVv-0001kA-4z for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVs-0001jM-9c for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:40 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id E0EF9E2548 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vgZ_uoa5IAfn for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9F7D2E253C for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:28 -0400 Message-Id: <1de7cac6510317a9ff9be0d2e8747e62419f3455.1656784965.git.simon@simonsouth.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/video.scm (vlc)[inputs]: Use regular srt package, supported since upstream commit 9a28929. --- gnu/packages/video.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 40c31cdaec..91ccbc14ae 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1974,8 +1974,7 @@ (define-public vlc ("sdl-image" ,sdl-image) ("speex" ,speex) ("speexdsp" ,speexdsp) - ;; VLC is not yet compatible with SRT > 1.4.1. - ("srt" ,srt-1.4.1) + ("srt" ,srt) ("taglib" ,taglib) ("twolame" ,twolame) ("unzip" ,unzip) -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 2/6] gnu: srt: Update to 1.4.4. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890446723 (code B ref 56361); Sat, 02 Jul 2022 19:11:02 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:44 +0000 Received: from localhost ([127.0.0.1]:42879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVv-0001kH-EG for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVs-0001jL-Ac for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id C95B3E2543 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lqCpCAVOdNZc for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 86B71E24EA for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:27 -0400 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/networking.scm (srt): Update to 1.4.4. --- gnu/packages/networking.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 82e209b149..a312e461d5 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -469,7 +469,7 @@ (define-public slurm-monitor (define-public srt (package (name "srt") - (version "1.4.3") + (version "1.4.4") (source (origin (method git-fetch) @@ -479,7 +479,7 @@ (define-public srt (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1f60vlfxhh9bhafws82c3301whjlz5gy92jz9a9ymwfg5h53bv1j")))) + (base32 "1zr1l9zkai7rpw9cn5j9h4zrv08hgpfmwscwyscf2j4cgwf0rxrr")))) (build-system cmake-build-system) (arguments `(#:configure-flags -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 1/6] gnu: srt: Remove input labels. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890446731 (code B ref 56361); Sat, 02 Jul 2022 19:11:02 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:44 +0000 Received: from localhost ([127.0.0.1]:42881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVv-0001kO-T0 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:44 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVs-0001jJ-AZ for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id A5652E2542 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vw7S8iDlKEFO for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 67593E23C3 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:26 -0400 Message-Id: <2bd6d5befda130372b596e955ee39685f1bdc3b3.1656784965.git.simon@simonsouth.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/networking.scm (srt)[native-inputs]: Remove input labels. --- gnu/packages/networking.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index ef8c09a777..82e209b149 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -490,9 +490,7 @@ (define-public srt "-DENABLE_STATIC=OFF" "-DENABLE_UNITTESTS=ON"))) (native-inputs - `(("gtest" ,googletest) - ("pkg-config" ,pkg-config) - ("tclsh" ,tcl))) + (list googletest pkg-config tcl)) (propagated-inputs (list openssl)) (synopsis "Secure Reliable Transport") -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 5/6] gnu: vlc: Remove input labels. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890446739 (code B ref 56361); Sat, 02 Jul 2022 19:11:03 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:44 +0000 Received: from localhost ([127.0.0.1]:42883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVw-0001kW-7y for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:44 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVs-0001jO-CK for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 35608E23C3 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yq48iOGlR6WS for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id D9BABE24EA for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:30 -0400 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/video.scm (vlc)[native-inputs]: Remove input labels. [inputs]: Remove input labels and re-sort. --- gnu/packages/video.scm | 153 ++++++++++++++++++++--------------------- 1 file changed, 75 insertions(+), 78 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 91ccbc14ae..ac2c0d986b 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1902,86 +1902,83 @@ (define-public vlc "0cs1vnv91mg7p6253v6wms3zlz91xzphpwaw14dmrd2gibc64nlc")))) (build-system gnu-build-system) (native-inputs - `(("flex" ,flex) - ("bison" ,bison) - ("gettext" ,gettext-minimal) - ("pkg-config" ,pkg-config))) + (list flex bison gettext-minimal pkg-config)) ;; FIXME: Add optional inputs once available. (inputs - `(("alsa-lib" ,alsa-lib) - ("avahi" ,avahi) - ("dav1d" ,dav1d) - ("dbus" ,dbus) - ("eudev" ,eudev) - ("flac" ,flac) - ("ffmpeg" ,ffmpeg) - ("fontconfig" ,fontconfig) - ("freetype" ,freetype) - ("fribidi" ,fribidi) - ("gnutls" ,gnutls) - ("liba52" ,liba52) - ("libarchive" ,libarchive) - ("libass" ,libass) - ("libavc1394" ,libavc1394) - ("libbluray" ,libbluray) - ("libcaca" ,libcaca) - ("libcddb" ,libcddb) - ("libdca" ,libdca) - ("libdvbpsi" ,libdvbpsi) - ("libdvdnav" ,libdvdnav) - ("libdvdread" ,libdvdread) - ("libebml" ,libebml) - ("libgcrypt" ,libgcrypt) - ("libidn" ,libidn) - ("libkate" ,libkate) - ("libmad" ,libmad) - ("libmatroska" ,libmatroska) - ("libmicrodns" ,libmicrodns) - ("libmodplug" ,libmodplug) - ("libmpeg2" ,libmpeg2) - ("libogg" ,libogg) - ("libpng" ,libpng) - ("libraw1394" ,libraw1394) - ("librsvg" ,(librsvg-for-system)) - ("libsamplerate" ,libsamplerate) - ("libsecret" ,libsecret) - ("libssh2" ,libssh2) - ("libupnp" ,libupnp) - ("libva" ,libva) - ("libvdpau" ,libvdpau) - ("libvorbis" ,libvorbis) - ("libvpx" ,libvpx) - ("libtheora" ,libtheora) - ("libx264" ,libx264) - ("libxext" ,libxext) - ("libxi" ,libxi) - ("libxinerama" ,libxinerama) - ("libxml2" ,libxml2) - ("libxpm" ,libxpm) - ("livemedia-utils" ,livemedia-utils) - ("lua" ,lua-5.2) - ("mesa" ,mesa) - ("opus" ,opus) - ("perl" ,perl) - ("pulseaudio" ,pulseaudio) - ("protobuf" ,protobuf) - ("python" ,python-wrapper) - ("qtbase" ,qtbase-5) - ("qtsvg" ,qtsvg) - ("qtx11extras" ,qtx11extras) - ("samba" ,samba) - ("sdl" ,sdl) - ("sdl-image" ,sdl-image) - ("speex" ,speex) - ("speexdsp" ,speexdsp) - ("srt" ,srt) - ("taglib" ,taglib) - ("twolame" ,twolame) - ("unzip" ,unzip) - ("wayland" ,wayland) - ("wayland-protocols" ,wayland-protocols) - ("x265" ,x265) - ("xcb-util-keysyms" ,xcb-util-keysyms))) + (list alsa-lib + avahi + dav1d + dbus + eudev + ffmpeg + flac + fontconfig + freetype + fribidi + gnutls + liba52 + libarchive + libass + libavc1394 + libbluray + libcaca + libcddb + libdca + libdvbpsi + libdvdnav + libdvdread + libebml + libgcrypt + libidn + libkate + libmad + libmatroska + libmicrodns + libmodplug + libmpeg2 + libogg + libpng + libraw1394 + (librsvg-for-system) + libsamplerate + libsecret + libssh2 + libtheora + libupnp + libva + libvdpau + libvorbis + libvpx + libx264 + libxext + libxi + libxinerama + libxml2 + libxpm + livemedia-utils + lua-5.2 + mesa + opus + perl + protobuf + pulseaudio + python-wrapper + qtbase-5 + qtsvg + qtx11extras + samba + sdl + sdl-image + speex + speexdsp + srt + taglib + twolame + unzip + wayland + wayland-protocols + x265 + xcb-util-keysyms)) (arguments `(#:configure-flags `("BUILDCC=gcc" -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] [PATCH 6/6] gnu: vlc: Add bash-minimal as an input. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org Received: via spool by 56361-submit@debbugs.gnu.org id=B56361.16567890476756 (code B ref 56361); Sat, 02 Jul 2022 19:11:03 +0000 Received: (at 56361) by debbugs.gnu.org; 2 Jul 2022 19:10:47 +0000 Received: from localhost ([127.0.0.1]:42886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVy-0001ku-N5 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:46 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:54882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iVx-0001jc-RJ for 56361@debbugs.gnu.org; Sat, 02 Jul 2022 15:10:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 7503DE24EA for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eO0gLIdhHApm for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:37 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id F12D4E2538 for <56361@debbugs.gnu.org>; Sat, 2 Jul 2022 19:10:34 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:10:31 -0400 Message-Id: <5f6432f67a5324b1fc1ce18108482e7bd4132ae5.1656784965.git.simon@simonsouth.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/video.scm (vlc)[inputs]: Add bash-minimal, silencing a warning from "guix lint vlc" as "wrap-program" is used in the package definition. --- gnu/packages/video.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index ac2c0d986b..69886581d8 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1907,6 +1907,7 @@ (define-public vlc (inputs (list alsa-lib avahi + bash-minimal dav1d dbus eudev -- 2.36.1 From unknown Sat Sep 06 04:31:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simon South Subject: bug#56361: closed (Re: [bug#56361] gnu: srt: Update to 1.4.4 (fix test failure on AArch64)) Message-ID: References: <87let4jydu.fsf@cbaines.net> X-Gnu-PR-Message: they-closed 56361 X-Gnu-PR-Package: guix-patches Reply-To: 56361@debbugs.gnu.org Date: Thu, 07 Jul 2022 23:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1657236542-18773-1" This is a multi-part message in MIME format... ------------=_1657236542-18773-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56361: gnu: srt: Update to 1.4.4 (fix test failure on AArch64) which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56361@debbugs.gnu.org. --=20 56361: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56361 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1657236542-18773-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56361-done) by debbugs.gnu.org; 7 Jul 2022 23:28:55 +0000 Received: from localhost ([127.0.0.1]:58281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9avX-0004sT-1F for submit@debbugs.gnu.org; Thu, 07 Jul 2022 19:28:55 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9avR-0004sH-2j for 56361-done@debbugs.gnu.org; Thu, 07 Jul 2022 19:28:53 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 692C627BBE9; Fri, 8 Jul 2022 00:28:48 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 724cc5ce; Thu, 7 Jul 2022 23:28:48 +0000 (UTC) References: User-agent: mu4e 1.6.10; emacs 28.1 From: Christopher Baines To: Simon South Subject: Re: [bug#56361] gnu: srt: Update to 1.4.4 (fix test failure on AArch64) Date: Fri, 08 Jul 2022 00:20:14 +0100 In-reply-to: Message-ID: <87let4jydu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56361-done Cc: 56361-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Simon South writes: > Here's a patch series that > > - Updates SRT, the "Secure Reliable Transport" for audio/video streams, to > 1.4.4, fixing a test failure on AArch64 and likely other non-Intel/AMD > platforms[0]; > > - Updates the srt package itself to remove input labels; > > - Updates the vlc package to use the now-current version of SRT instead of an > older version[1]; > > - Removes that older (and now unnecessary) version of srt from the package > repository; and > > - Updates the vlc package to remove input labels and to add "bash-minimal" to > its inputs, silencing a warning from "guix lint". > > I'm aware SRT 1.5.0 is also available, but > > - Version 1.4.4 is the latest version supported by VLC; > > - Version 1.5.0 introduces API/ABI changes that are likely to cause problems > elsewhere; and > > - I just need to get my systems updating again. (I can look at submitting > another patchset later.) > > I've tested these patches on x86-64 and AArch64 and in general, everything > looks fine. > > With regards to SRT's immediate dependents, ffmpeg@4.4.2, ffmpeg@5.0.1, > gst-plugins-bad and and vlc: > > - All four dependents build without issue on x86-64. > > - On AArch64, VLC and the two FFmpeg packages build just fine. Building > gst-plugins-bad means building the entire Rust toolchain and potentially > other packages that are infeasible to build on garden-variety AArch64 > hardware, so I haven't been able to test this. > > - Nonetheless I've verified that on both architectures, VLC built with these > patches connects to and plays a SRT video stream just fine.[2] > > On x86-64 I've tested building all of SRT's 299 dependent packages and this > completes without any _new_ build failures: ams-lv2, dvdstyler, lv2-mda-piano > and lv2-mda-epiano are all currently broken on x86-64, and it appears my > system is unable to build curl 7.84.0 for i686-linux either with or without > these patches applied. > > [0] The failure involves an unnecessarily-short timeout period in the > "SyncEvent.WaitForTwoNotifyOne" unit test, which was adjusted in upstream > commit e2a00aa: > > https://github.com/Haivision/srt/commit/e2a00aa03a36e153ab8cfe2c0790f7bf43747d8d > > It's unlikely this affects only AArch64. A Debian developer notes in this > GitHub issue that SRT test failures are common on other, older and mostly > non-Intel/AMD architectures as well: > > https://github.com/Haivision/srt/issues/2267 > > [1] VLC was updated to build with SRT version 1.4.4 by default in upstream > commit 9a28929 this past February, making the comment above the srt-1.4.1 > package (in gnu/packages/networking.scm) obsolete. Since neither of the > other packages mentioned still use this older version of SRT, nor does any > other, the package is no longer needed. > > https://code.videolan.org/videolan/vlc/-/commit/9a289291d01a393294c62ee7406487f59e25f4ed > > [2] I'd also like to verify that VLC can _output_ a video stream using SRT but > despite an "SRT" output-access module appearing in the configuration > settings I can't see how this is meant to work, using either the original > or the patched build of VLC. If anyone relies on this functionality and > can give me straightforward instructions for testing it I'll be happy to > do so before this patch series is committed. > > --- > > Simon South (6): > gnu: srt: Remove input labels. > gnu: srt: Update to 1.4.4. > gnu: vlc: Use regular srt. > gnu: Remove srt-1.4.1. > gnu: vlc: Remove input labels. > gnu: vlc: Add bash-minimal as an input. > > gnu/packages/networking.scm | 26 +----- > gnu/packages/video.scm | 155 ++++++++++++++++++------------------ > 2 files changed, 79 insertions(+), 102 deletions(-) > > > base-commit: 48ff4bfcd7491c12248b34a82e0b8e8a50a86308 Thanks for the really comprehensive testing and notes Simon, the patches look good too. I've gone ahead and pushed these in the following commits: 7dfb8dc4c1 * gnu: vlc: Add bash-minimal as an input. f53e14be33 * gnu: vlc: Remove input labels. 07986d0fad * gnu: Remove srt-1.4.1. 6b9d373083 * gnu: vlc: Use regular srt. 5feeb51f1b * gnu: srt: Update to 1.4.4. 70f3914c24 * gnu: srt: Remove input labels. Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmLHbC1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfTVw/+OZc2c+3KcRWzjiItu2lidj2yeMLGHAtN N7DCVu4Z24qKkaYFapCTjwfygyMstRqkqsKEnDpvS77cHVyahK93QsQ+9MzVJDSX 7MaPCq/y9efuSDJ9zK+D10VDGbpnYkUqLKkky+PEI6xRpQcTmqS7Aey/OCJE/0h5 hgginIfpeVrHB79QVZn3FajZ6Kkq6VJAQX8q7PHmBMXgVz3RXpJKRn8eejd2cD/l aW+U/pPqj8eH+aqnd5itg3lzhHzC9r5u0+AcosGs6l1h+Bz4xBz8yyQbPym3MxRA gvchCs6CyGnl5A+FwPNcuwpsvmxa33FPKmX1iXVn5ZBYR6tnlNP7gzed4TRWod1p GBjAPFibAm3F0soLzljLD7NYDQU59u7Jdl577QYaeJWRapo9HXFER/sCMaW6CvUD 8WFmYL8wwcyCnKTuR+584kgMg5iaT2kgeWrbE1i9+MTvo5bCVT2D2txSZwepWHSr en2IBvf/ZEAyaZGLqKRU+OJE5bBHOm8qL+SKMnbbcjxvgoZGoTwf9JOM35sfitnm snbj7pgt7J/2RWIlj/JJgisOdtCxDGBi7Q5ya/XggE7VaSFxOvvNpEYZppclqshg ax/nAXhhncF01FK/y5Eyr5JmizcqR0F4ctvIZjsw/rlSb8eelMLxkh4Nd96ecs8/ ENnnk6cw1n0= =v12r -----END PGP SIGNATURE----- --=-=-=-- ------------=_1657236542-18773-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jul 2022 19:07:46 +0000 Received: from localhost ([127.0.0.1]:42864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT4-0001ci-45 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:37518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT1-0001cX-7q for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iT1-0001OV-3s for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iSy-0003L5-R1 for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:42 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 155546190C for ; Sat, 2 Jul 2022 19:07:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCe7RZHwF_9i for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id A5721617F0 for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: gnu: srt: Update to 1.4.4 (fix test failure on AArch64) Date: Sat, 2 Jul 2022 15:07:29 -0400 Message-Id: X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Here's a patch series that - Updates SRT, the "Secure Reliable Transport" for audio/video streams, to 1.4.4, fixing a test failure on AArch64 and likely other non-Intel/AMD platforms[0]; - Updates the srt package itself to remove input labels; - Updates the vlc package to use the now-current version of SRT instead of an older version[1]; - Removes that older (and now unnecessary) version of srt from the package repository; and - Updates the vlc package to remove input labels and to add "bash-minimal" to its inputs, silencing a warning from "guix lint". I'm aware SRT 1.5.0 is also available, but - Version 1.4.4 is the latest version supported by VLC; - Version 1.5.0 introduces API/ABI changes that are likely to cause problems elsewhere; and - I just need to get my systems updating again. (I can look at submitting another patchset later.) I've tested these patches on x86-64 and AArch64 and in general, everything looks fine. With regards to SRT's immediate dependents, ffmpeg@4.4.2, ffmpeg@5.0.1, gst-plugins-bad and and vlc: - All four dependents build without issue on x86-64. - On AArch64, VLC and the two FFmpeg packages build just fine. Building gst-plugins-bad means building the entire Rust toolchain and potentially other packages that are infeasible to build on garden-variety AArch64 hardware, so I haven't been able to test this. - Nonetheless I've verified that on both architectures, VLC built with these patches connects to and plays a SRT video stream just fine.[2] On x86-64 I've tested building all of SRT's 299 dependent packages and this completes without any _new_ build failures: ams-lv2, dvdstyler, lv2-mda-piano and lv2-mda-epiano are all currently broken on x86-64, and it appears my system is unable to build curl 7.84.0 for i686-linux either with or without these patches applied. [0] The failure involves an unnecessarily-short timeout period in the "SyncEvent.WaitForTwoNotifyOne" unit test, which was adjusted in upstream commit e2a00aa: https://github.com/Haivision/srt/commit/e2a00aa03a36e153ab8cfe2c0790f7bf43747d8d It's unlikely this affects only AArch64. A Debian developer notes in this GitHub issue that SRT test failures are common on other, older and mostly non-Intel/AMD architectures as well: https://github.com/Haivision/srt/issues/2267 [1] VLC was updated to build with SRT version 1.4.4 by default in upstream commit 9a28929 this past February, making the comment above the srt-1.4.1 package (in gnu/packages/networking.scm) obsolete. Since neither of the other packages mentioned still use this older version of SRT, nor does any other, the package is no longer needed. https://code.videolan.org/videolan/vlc/-/commit/9a289291d01a393294c62ee7406487f59e25f4ed [2] I'd also like to verify that VLC can _output_ a video stream using SRT but despite an "SRT" output-access module appearing in the configuration settings I can't see how this is meant to work, using either the original or the patched build of VLC. If anyone relies on this functionality and can give me straightforward instructions for testing it I'll be happy to do so before this patch series is committed. --- Simon South (6): gnu: srt: Remove input labels. gnu: srt: Update to 1.4.4. gnu: vlc: Use regular srt. gnu: Remove srt-1.4.1. gnu: vlc: Remove input labels. gnu: vlc: Add bash-minimal as an input. gnu/packages/networking.scm | 26 +----- gnu/packages/video.scm | 155 ++++++++++++++++++------------------ 2 files changed, 79 insertions(+), 102 deletions(-) base-commit: 48ff4bfcd7491c12248b34a82e0b8e8a50a86308 -- 2.36.1 ------------=_1657236542-18773-1--