GNU bug report logs - #56360
[PATCH] Improve navigation keybindings in emacs-news-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56360 in the body.
You can then email your comments to 56360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve navigation keybindings in emacs-news-mode
Date: Sat, 2 Jul 2022 21:07:31 +0200

[Message part 1 (text/plain, inline)]

Severity: wishlist

I think the navigation commands in `emacs-news-mode' and
'emacs-news-view-mode-map' should be similar to `org-mode' and
`outline-mode'.  IMO, the parts where they agree is the closest we have
anything resembling a "standard" for navigating an outline in Emacs.
See the attached patch.

It is worth comparing to:

    (describe-keymap 'outline-mode-prefix-map)
    (describe-keymap 'outline-navigation-repeat-map)
    (describe-keymap 'org-mode-map)

[0001-Improve-navigation-keybindings-in-emacs-news-mode.patch (text/x-diff, attachment)]

Message #8 received at 56360 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56360 <at> debbugs.gnu.org
Subject: Re: bug#56360: [PATCH] Improve navigation keybindings in
 emacs-news-mode
Date: Sun, 03 Jul 2022 14:34:57 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> I think the navigation commands in `emacs-news-mode' and
> 'emacs-news-view-mode-map' should be similar to `org-mode' and
> `outline-mode'.  IMO, the parts where they agree is the closest we have
> anything resembling a "standard" for navigating an outline in Emacs.
> See the attached patch.

Makes sense to me; go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 56360 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56360 <at> debbugs.gnu.org
Subject: Re: bug#56360: [PATCH] Improve navigation keybindings in
 emacs-news-mode
Date: Sun, 03 Jul 2022 14:41:33 +0200

But leads to these warnings:

In end of data:
textmodes/emacs-news-mode.el:48:15: Warning: the function `outline-up-heading' is not known to be defined.
textmodes/emacs-news-mode.el:47:15: Warning: the function `outline-previous-visible-heading' is not known to be defined.
textmodes/emacs-news-mode.el:46:15: Warning: the function `outline-next-visible-heading' is not known to be defined.
textmodes/emacs-news-mode.el:45:15: Warning: the function `outline-backward-same-level' is not known to be defined.
textmodes/emacs-news-mode.el:44:15: Warning: the function `outline-forward-same-level' is not known to be defined.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 56360-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56360-done <at> debbugs.gnu.org
Subject: Re: bug#56360: [PATCH] Improve navigation keybindings in
 emacs-news-mode
Date: Sun, 3 Jul 2022 14:42:10 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Makes sense to me; go ahead and push.

Thanks, pushed as commit d68ecda05c.

Message #19 received at 56360 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56360 <at> debbugs.gnu.org
Subject: Re: bug#56360: [PATCH] Improve navigation keybindings in
 emacs-news-mode
Date: Sun, 3 Jul 2022 14:48:13 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> In end of data:
> textmodes/emacs-news-mode.el:48:15: Warning: the function `outline-up-heading' is not known to be defined.
> textmodes/emacs-news-mode.el:47:15: Warning: the function `outline-previous-visible-heading' is not known to be defined.
> textmodes/emacs-news-mode.el:46:15: Warning: the function `outline-next-visible-heading' is not known to be defined.
> textmodes/emacs-news-mode.el:45:15: Warning: the function `outline-backward-same-level' is not known to be defined.
> textmodes/emacs-news-mode.el:44:15: Warning: the function `outline-forward-same-level' is not known to be defined.

Thanks, should be fixed now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.