From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 07:06:11 2022 Received: (at submit) by debbugs.gnu.org; 2 Jul 2022 11:06:11 +0000 Received: from localhost ([127.0.0.1]:39930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7ax0-0004nM-W6 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 07:06:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:50194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7awy-0004n4-NY for submit@debbugs.gnu.org; Sat, 02 Jul 2022 07:06:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7awy-0004fg-Il for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 07:06:08 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:34332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7aww-00087v-SN for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 07:06:08 -0400 Received: by mail-pg1-x52c.google.com with SMTP id g4so4673146pgc.1 for ; Sat, 02 Jul 2022 04:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:to:subject:content-language :from; bh=cXcScFJdq2Lys3TMRi+mL6Cre6PluJFKbc8Hfd4pQ78=; b=doNqRjaK8FVjDRI5z4YYOkLYOdI5ZY9uCEnoNUuTE25xax9HVvga6IzSYMML6n0ca8 f3vBnf6mxxIgYvP0VPuwHoR3mLio+tDiUUkPb1Lwgs+g5evqytOCO0qKgGpa8JlviRfd 9BrlJzXn91z2fFKlDIjGnJRr7fvGfjmcctmwtiiT+joSGvln/fRykO+sEvHgqyI1fqzs aMdiMqVfmVA/XnOE48KpO5pfMDEmQ9oLV0Mi/7rkrieNtdqLPFGh1+cVLKyCc2TV3sJo y/7F+jiND4bfVYjuSJrbtdd1Ii6iBX8j6bOWKDU1G1c48iwPKEyX/HY2Mb57P3e+GfBU 57bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:to :subject:content-language:from; bh=cXcScFJdq2Lys3TMRi+mL6Cre6PluJFKbc8Hfd4pQ78=; b=EQ4Q2EERlO++Q9E2hplxYmd7u7G2mE2SIsY/S76qs4Iz7sgv93n/DulEeYiXJLx1ah FCMx1xOtHmnb1eWDcI80ZvSI09Xgm/9UJrfGq/193KF3d80ZP34rsdvY7jz82dTyj/M4 0EZJOd0XT1aw1kC+SPcYF5HI/9auCDz7XvzD+Oi6+Rhfs7ark/bNkQDbdsz2xNqY135C fpoE+xWqRpx1XqXvaOlpzJHbBmJMFzuXDpbYsZ/TMqttrBoxC8BtXQrPJn/RQ1gcRvHI FCOQgIXGDqMVkEifT6LR2TDWSGjYTRHiPA+smVSkBGHCoBwBLR2IZPLijwHQD0Ul0Te1 ZH1g== X-Gm-Message-State: AJIora8u/S6tgo9tjoileYB+o6xEkBJ8/wqzNWQkoiHIb47Bg2zjuCTc qNhvuu2/Sl7V7RCP6t39YFMrvaAclCU= X-Google-Smtp-Source: AGRyM1s9AeIHZOZRwm35wTYDouzFh1Yqdvi/GfKO17P6rDpXlw9Lpkhe1QTyNV2alZjBly1OhtKAIw== X-Received: by 2002:a05:6a00:1c94:b0:527:c49a:3249 with SMTP id y20-20020a056a001c9400b00527c49a3249mr25157812pfw.18.1656759964642; Sat, 02 Jul 2022 04:06:04 -0700 (PDT) Received: from ?IPV6:2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802? ([2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802]) by smtp.gmail.com with ESMTPSA id jh19-20020a170903329300b0015e8d4eb2c0sm17168546plb.266.2022.07.02.04.06.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 04:06:04 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------S8j3ESHr5aszMXnOVTkn17pE" Message-ID: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> Date: Sat, 2 Jul 2022 18:06:01 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Implement file-parent-directory Content-Language: en-US From: daanturo Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=daanturo@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------S8j3ESHr5aszMXnOVTkn17pE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit A way to get the parent directory of a file. This is inspired by f.el's f-dirname, but only returns the absolute path, also doesn't ignore `file-name-handler-alist`, doesn't strip the final "/". -- Daanturo. --------------S8j3ESHr5aszMXnOVTkn17pE Content-Type: text/x-patch; charset=UTF-8; name="0001-Define-file-parent-directory.patch" Content-Disposition: attachment; filename="0001-Define-file-parent-directory.patch" Content-Transfer-Encoding: base64 RnJvbSA2OWU3ODYzZDk1ZmNhOGZiOTc5YjAxODI1NjBmMDJiMjQzZWRmMTcyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYWFudHVybyA8ZGFhbnR1cm9AZ21haWwuY29tPgpE YXRlOiBTYXQsIDIgSnVsIDIwMjIgMTc6NTU6NTcgKzA3MDAKU3ViamVjdDogW1BBVENIXSBE ZWZpbmUgZmlsZS1wYXJlbnQtZGlyZWN0b3J5CgpHZXQgcGFyZW50IGRpcmVjdG9yeSBvZiBh IGZpbGUuCiogZG9jL2xpc3ByZWYvZmlsZXMudGV4aTogRG9jdW1lbnQgdGhlIGZ1bmN0aW9u LgoqIGV0Yy9ORVdTOiBBZGQgaXRzIGVudHJ5LgoqIGxpc3AvZW1hY3MtbGlzcC9zaG9ydGRv Yy5lbDogQWRkIGl0IHRvICdmaWxlLW5hbWUnIGdyb3VwLgoqIGxpc3AvZmlsZXMuZWw6IGlt cGxlbWVudGF0aW9uCi0tLQogZG9jL2xpc3ByZWYvZmlsZXMudGV4aSAgICAgIHwgIDYgKysr KysrCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAgfCAgMyArKysKIGxpc3AvZW1hY3Mt bGlzcC9zaG9ydGRvYy5lbCB8ICA0ICsrKysKIGxpc3AvZmlsZXMuZWwgICAgICAgICAgICAg ICB8IDEwICsrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2ZpbGVzLnRleGkgYi9kb2MvbGlzcHJlZi9maWxl cy50ZXhpCmluZGV4IGVhODY4M2E2ZDguLmUxMTgyZGMxOTEgMTAwNjQ0Ci0tLSBhL2RvYy9s aXNwcmVmL2ZpbGVzLnRleGkKKysrIGIvZG9jL2xpc3ByZWYvZmlsZXMudGV4aQpAQCAtMjQ0 NSw2ICsyNDQ1LDEyIEBAIERpcmVjdG9yeSBOYW1lcwogYmVjYXVzZSBpdCByZWNvZ25pemVz IGFiYnJldmlhdGlvbnMgZXZlbiBhcyBwYXJ0IG9mIHRoZSBuYW1lLgogQGVuZCBkZWZ1bgog CitAZGVmdW4gZmlsZS1wYXJlbnQtZGlyZWN0b3J5IGZpbGVuYW1lCitUaGlzIGZ1bmN0aW9u IHJldHVybnMgdGhlIHBhcmVudCBkaXJlY3Rvcnkgb2YgQHZhcntmaWxlbmFtZX0uICBJZgor QHZhcntmaWxlbmFtZX0gaXMgYXQgdGhlIHRvcC1sZXZlbDogcmV0dXJuIG5pbC4gIEB2YXJ7 ZmlsZW5hbWV9IGNhbiBiZQorcmVsYXRpdmUgdG8gYGRlZmF1bHQtZGlyZWN0b3J5Jy4KK0Bl bmQgZGVmdW4KKwogQG5vZGUgRmlsZSBOYW1lIEV4cGFuc2lvbgogQHN1YnNlY3Rpb24gRnVu Y3Rpb25zIHRoYXQgRXhwYW5kIEZpbGVuYW1lcwogQGNpbmRleCBleHBhbnNpb24gb2YgZmls ZSBuYW1lcwpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCAzMDQwNGNj MTNjLi4zYmZlYmQ2YmI3IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpA QCAtMzE3LDYgKzMxNyw5IEBAIHN0YXJ0dXAuICBQcmV2aW91c2x5LCB0aGVzZSBmdW5jdGlv bnMgaWdub3JlZAogDAogKiBDaGFuZ2VzIGluIEVtYWNzIDI5LjEKIAorKiogTmV3IGZ1bmN0 aW9uICdmaWxlLXBhcmVudC1kaXJlY3RvcnknCitHZXQgdGhlIHBhcmVudCBkaXJlY3Rvcnkg b2YgYSBmaWxlLgorCiAqKiBOZXcgY29uZmlnIHZhcmlhYmxlICdzeW50YXgtd2hvbGVsaW5l LW1heCcgdG8gcmVkdWNlIHRoZSBjb3N0IG9mIGxvbmcgbGluZXMuCiBUaGlzIHZhcmlhYmxl IGlzIHVzZWQgYnkgc29tZSBvcGVyYXRpb25zIChtb3N0bHkgc3ludGF4LXByb3BlcnRpemF0 aW9uCiBhbmQgZm9udC1sb2NraW5nKSB0byB0cmVhdCBsaW5lcyBsb25nZXIgdGhhbiB0aGlz IHZhcmlhYmxlIGFzIGlmIHRoZXkKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9zaG9y dGRvYy5lbCBiL2xpc3AvZW1hY3MtbGlzcC9zaG9ydGRvYy5lbAppbmRleCBjODJhYTMzNjVj Li42ODUwMGM0M2QzIDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwK KysrIGIvbGlzcC9lbWFjcy1saXNwL3Nob3J0ZG9jLmVsCkBAIC0zNTMsNiArMzUzLDEwIEBA IGZpbGUtbmFtZQogICAoYWJicmV2aWF0ZS1maWxlLW5hbWUKICAgIDpuby1ldmFsIChhYmJy ZXZpYXRlLWZpbGUtbmFtZSAiL2hvbWUvc29tZS11c2VyIikKICAgIDplZy1yZXN1bHQgIn5z b21lLXVzZXIiKQorICAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5CisgICA6ZXZhbCAoZmlsZS1w YXJlbnQtZGlyZWN0b3J5ICJ+IikKKyAgIDpldmFsIChmaWxlLXBhcmVudC1kaXJlY3Rvcnkg ImZvbyIpCisgICA6ZXZhbCAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5ICIvIikpCiAgICJRdW90 ZWQgRmlsZSBOYW1lcyIKICAgKGZpbGUtbmFtZS1xdW90ZQogICAgOmFyZ3MgKG5hbWUpCmRp ZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCAxMjk1YzI0 YzkzLi4yODlkOTJhOWRjIDEwMDY0NAotLS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xpc3Av ZmlsZXMuZWwKQEAgLTUxNDUsNiArNTE0NSwxNiBAQCBmaWxlLW5hbWUtc3BsaXQKICAgICAg ICAgICAoc2V0cSBmaWxlbmFtZSBuaWwpKSkpCiAgICAgY29tcG9uZW50cykpCiAKKyhkZWZ1 biBmaWxlLXBhcmVudC1kaXJlY3RvcnkgKGZpbGVuYW1lKQorICAiUmV0dXJuIHRoZSBwYXJl bnQgZGlyZWN0b3J5IG9mIEZJTEVOQU1FLgorSWYgRklMRU5BTUUgaXMgYXQgdGhlIHRvcC1s ZXZlbDogcmV0dXJuIG5pbC4gIEZJTEVOQU1FIGNhbiBiZQorcmVsYXRpdmUgdG8gYGRlZmF1 bHQtZGlyZWN0b3J5Jy4iCisgIChsZXQqICgocGFyZW50IChmaWxlLW5hbWUtZGlyZWN0b3J5 CisgICAgICAgICAgICAgICAgICAoZGlyZWN0b3J5LWZpbGUtbmFtZSAoZXhwYW5kLWZpbGUt bmFtZSBmaWxlbmFtZSkpKSkpCisgICAgKGlmIChmaWxlLWVxdWFsLXAgcGFyZW50IGZpbGVu YW1lKQorICAgICAgICBuaWwKKyAgICAgIHBhcmVudCkpKQorCiAoZGVmY3VzdG9tIG1ha2Ut YmFja3VwLWZpbGUtbmFtZS1mdW5jdGlvbgogICAjJ21ha2UtYmFja3VwLWZpbGUtbmFtZS0t ZGVmYXVsdC1mdW5jdGlvbgogICAiQSBmdW5jdGlvbiB0aGF0IGBtYWtlLWJhY2t1cC1maWxl LW5hbWUnIHVzZXMgdG8gY3JlYXRlIGJhY2t1cCBmaWxlIG5hbWVzLgotLSAKMi4zNy4wCgo= --------------S8j3ESHr5aszMXnOVTkn17pE-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 07:54:25 2022 Received: (at 56355) by debbugs.gnu.org; 2 Jul 2022 11:54:25 +0000 Received: from localhost ([127.0.0.1]:40041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bhh-00048y-DY for submit@debbugs.gnu.org; Sat, 02 Jul 2022 07:54:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bhd-00048X-Mm for 56355@debbugs.gnu.org; Sat, 02 Jul 2022 07:54:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7bhX-0006E3-6r; Sat, 02 Jul 2022 07:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MB71V8WtWaxiRguBXll1Yv5ZTzNlyDFYWFfUXxOvF8Y=; b=anEcF66SYKVD +Bh3q3JH+G66nOidY9YdvbZZvGq1B494ZQntUtkSGvEED7H6IcVvnMoSsvhID3PJPlVaSc0rpGdon KFuvirkNGDTmGzrc2vtoPGmVfFQqW1PRHaEekIlsCXm+obCAJfZAuKfF6uuueHCAkAhSEXT/Hu/E4 K8S0Bk6n3ZGFoWb4vX1Ww3cFUqBTySOxpvXywK40PdctkTqEMBkLMn1PxoO5nE0QEonTUgLtStVqq f0kN50Bzbuqw30kk906wtQpAX9oZQPy8Ey1nHkzGPa+lckzd0FTZV4Qa0ffrKjUjPnWr4tG1+PqWX /rfzCD7YptRtuGnNlEVOBg==; Received: from [87.69.77.57] (port=2020 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7bhV-0005BR-PA; Sat, 02 Jul 2022 07:54:15 -0400 Date: Sat, 02 Jul 2022 14:54:06 +0300 Message-Id: <83wncvbuht.fsf@gnu.org> From: Eli Zaretskii To: daanturo In-Reply-To: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> (message from daanturo on Sat, 2 Jul 2022 18:06:01 +0700) Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56355 Cc: 56355@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 2 Jul 2022 18:06:01 +0700 > From: daanturo > > A way to get the parent directory of a file. > > This is inspired by f.el's f-dirname, but only returns the absolute > path, also doesn't ignore `file-name-handler-alist`, doesn't strip the > final "/". Thanks, but it looks as a very thin wrapper around file-name-directory, so I wonder whether we really need a separate function fir this. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 08:02:55 2022 Received: (at 56355) by debbugs.gnu.org; 2 Jul 2022 12:02:55 +0000 Received: from localhost ([127.0.0.1]:40061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bpv-0004O2-0y for submit@debbugs.gnu.org; Sat, 02 Jul 2022 08:02:55 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:39646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bpr-0004Nj-BJ for 56355@debbugs.gnu.org; Sat, 02 Jul 2022 08:02:53 -0400 Received: by mail-pj1-f47.google.com with SMTP id b12-20020a17090a6acc00b001ec2b181c98so8935298pjm.4 for <56355@debbugs.gnu.org>; Sat, 02 Jul 2022 05:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=g1dQjXZL4PDWkiC3OZrJBseYD8HRhdBUdFhTvpI4xJ0=; b=j7oz9gWlUUIUn5a8VMbrUmNTm92v+4klgBn5zKxISw918qU6brF6wykliZk5i33b8G lIt5X27WKCsXZ6I3aIryYWs8JWkWyGOYArrH8m7qKgw05ZHqSj1/eDf/aY+XwSTMNUMc UUHDHx91dZvPFkG8m6bds6He7AQLlNfX2hA7feI/X00S6CMR+P7U8kFCQjPeEvGZa9m6 3CPYgXcYr5oPmFDXXTRejVCnkDQNmGfYvz13yAp4ogP11GZMnZHvaqjMPh5hJWTijVPY 0NrwnOK941YKgIT0EP33FToQeZUhmxqTBMdTfdYVzttFPZN/fvulep58/zxjcH+9w+ek 8aHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g1dQjXZL4PDWkiC3OZrJBseYD8HRhdBUdFhTvpI4xJ0=; b=Qy5D32COeXv4dOe6bbK19FZ9xj9Od+uhHV3dXbf0eMVEwKeNgSxo7J/SeBMA3jyffi tt1qv84PSS2lCC+QeBiYkGXBWcxs8cT1Fn0yNQVJLfy6is6X93Rpk61BwIYo3rnzan4q 0UX/0dLIL0kKyMONp9srUx97bqcsSGg9IFifvgrPH1Y1/Z6epmpyb7FYBH3M6hsobSn9 GJycK/EiJrtxIgu3K7odnuehLQEV+b0vQKpQPmRLd3yaHCcoeme6gd9+pUhEM3NZo73B WP7fmuTQMXPZ/z0lxmtc3+/UfcFQRZ7U5rCcPywE8/XVBph+Kev8cbik2ytsSyVmyFs5 dtqg== X-Gm-Message-State: AJIora/YW5LjQHinbqyVdn4MjYY8FvsQVg4gz6mFXg+sB8YZYBqi+asK usWYdiCrMtLQVh2rRmGsnXJrI2ranxw= X-Google-Smtp-Source: AGRyM1uIBzOPLysGZWgSq/wMWi77wjFS49us3LGzceXuaA5bXeqOKxvwv74X7SYLdKAwzNkTbvisVg== X-Received: by 2002:a17:902:e849:b0:16a:35ed:6e10 with SMTP id t9-20020a170902e84900b0016a35ed6e10mr26179163plg.125.1656763365408; Sat, 02 Jul 2022 05:02:45 -0700 (PDT) Received: from ?IPV6:2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802? ([2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802]) by smtp.gmail.com with ESMTPSA id u4-20020a170902714400b0015e8d4eb28fsm17361233plm.217.2022.07.02.05.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 05:02:45 -0700 (PDT) Message-ID: Date: Sat, 2 Jul 2022 19:02:42 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory Content-Language: en-US To: Eli Zaretskii References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> From: daanturo In-Reply-To: <83wncvbuht.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56355 Cc: 56355@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7/2/22 18:54, Eli Zaretskii wrote: > Thanks, but it looks as a very thin wrapper around > file-name-directory, so I wonder whether we really need a separate > function fir this. file-name-directory doesn't work when the input has a trailing "/", such as "/home/" when we expect "/" as the return value. Also this one handles "~" => "/home/". -- Daanturo. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 08:11:59 2022 Received: (at 56355) by debbugs.gnu.org; 2 Jul 2022 12:11:59 +0000 Received: from localhost ([127.0.0.1]:40079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7byh-0004c1-FZ for submit@debbugs.gnu.org; Sat, 02 Jul 2022 08:11:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7byg-0004bo-6L for 56355@debbugs.gnu.org; Sat, 02 Jul 2022 08:11:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V9XvUccX+9MtNWgFssSKAFJho4mYtYm1LLnZqKPaonA=; b=MGM1NZhTGdyEd0t3ftPBlBpehQ t0/Z4/TLmYVhw80ybhiY/ZpEqfcRphcmaFBDtKsg+yRnZGLwQrS00xydCfHYeMugXHrtgeSYg4l5J THQO+/bk82O+QqXuvws48iKZ9nc2ZYpvXlk8LkxrOvLeWM+pGyIblrJ/wlI8+y59ACKo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7byX-0001so-3J; Sat, 02 Jul 2022 14:11:51 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory In-Reply-To: <83wncvbuht.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jul 2022 14:54:06 +0300") References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXHvq9gW1ZSJywb FhWPV1v///9jtUDFAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YHAgs7B7pj094AAAG0SURBVDjLdZSB jesgDIadewyAORbAdICL6QA2x/4znQkkoVKepbYSX39s/xgA/hsBn8IDFCpcKDNxJotceuQfAKZM WV+VXlWkEr0k5FJ/usL+mV+RqEEjqm8lOhRdSeQrvQEUG+Gx2QSccNNeiQKGsABDfha55VVRmOJZ /vapILLiQ+otrIpjuR0Ch9RX3h3kAWaEfAO2jqM2ca21IZhgR7lyQyt0grKrtAu4kq/ku/pNnkF0 zwpEuUHmFdzJR8cD8NndYcknwEewhxSdZbGPE1284jAtiVEN5BVQoETJJibq0fkE5lWwLzTbIxKt ihAoh05gQ7y9MrMLJUjfHMBFq4snaBhYvbRvqgDe3QpQ3UUQopoDsl3AMsHuAeHXO4aegxfQu/7n NSneVZ3A2bzp19L57rxtLzahLtXf1SuMDVUQ1QZ0jMnpbpQgiuJw65Z9WDLCRLSeR7dwDuiqsIHr a7FFRW1N9eMEA1q141D046AmmEWtyZPd7Ova2h2Uqyq/4X2fH8Bdbr8Fdr9brP0n10w8H4BSuS9Z sWefXEfy/lq88ljrrwEfWw0rknkRrgzjJJ7jD7BVjujBIt4hAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIyLTA3LTAyVDExOjU5OjA3KzAwOjAw5y6ArwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNy0w MlQxMTo1OTowNyswMDowMJZzOBMAAAAASUVORK5CYII= X-Now-Playing: The Clash's _Sandinista!_: "Junco Partner" Date: Sat, 02 Jul 2022 14:11:48 +0200 Message-ID: <8735fj3e9n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Thanks, but it looks as a very thin wrapper around > file-name-directory, so I wonder whether we really need a separate > function fir this. I think it looks like a handy utility function -- we have quite a few instances of Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56355 Cc: daanturo , 56355@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Thanks, but it looks as a very thin wrapper around > file-name-directory, so I wonder whether we really need a separate > function fir this. I think it looks like a handy utility function -- we have quite a few instances of (file-name-directory (directory-file-name filename)) (possibly with an expand-file-name in there, too) and using `file-parent-directory' would both express the intention of the code better, and be less error prone (because many people forget the `directory-file-name' in the first attempt). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 11:29:27 2022 Received: (at 56355) by debbugs.gnu.org; 2 Jul 2022 15:29:27 +0000 Received: from localhost ([127.0.0.1]:42566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7f3m-0006HD-RO for submit@debbugs.gnu.org; Sat, 02 Jul 2022 11:29:27 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:14772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7f3j-0006H0-Ua for 56355@debbugs.gnu.org; Sat, 02 Jul 2022 11:29:25 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 262DXBwa026803; Sat, 2 Jul 2022 15:29:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=wI8IYIs/i9lyMBPic8daXDrb9ISE7YrqHFX1XxEwZkQ=; b=OrXSFwjsn/TckhCZ9MNShsLc1Tbn47uPthrF+Ls1ugH/G161FyuzBsX1F0nYxrLYAdst zVotBpg7gnRTJ6RMWSWshY2Z9c9VLpqPgi2+oL3H8nYBh25KvLoYpYkuVxF6Fwsjupln llzxfoFZl69JERhBaXuoRmhofavAUHYy9Z3NBdKP25hZHPj5g6xrmdr+Me8PrOvcg6Sx bmqtyysGffv7yygtWhXraMKOCl1drJ4jyYHXBCGm2Los//+vIp10yPjl7/avhizk5TYd Q05Am+Ku38N1mqUzBsHJD8Ld/q3SAjTuXwj4BZAwHk6Hm0xwLwmpMDSid0Oa7HOFEIPy kw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h2dwagmkd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 02 Jul 2022 15:29:21 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 262FAtrV027742; Sat, 2 Jul 2022 15:29:20 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h2cf6ryua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 02 Jul 2022 15:29:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XlupxGp276LOfVnh9tRR7j9zo4JjJvaTZ7qxSP7Kw9NQmCw0vJKp/j8ye17Dx5swtG8j9wKP76PS86zwH4t9PmdzeLp43jHJxiv59UEU1sWClMwHxEZky6NWg4NNk5RigP2t9NiAtXCllQZqokXS4RJnt5bjUUy964so3tONFPscd/msLOcO+pmAryL/3QATP91uPfpvytS+EmdJBg5kfvXBYqeYNsPbX+kbtPsrmbuB4Q0uz1JFKHpyGIalxa+Hk34jrhRHMSpQATOeTkOI/P1Mc7AAWyhL1vRY5DATyCdPkef3CzUCbWDadLaAsToZHLqNkRRTAz3N/exJTKwZLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wI8IYIs/i9lyMBPic8daXDrb9ISE7YrqHFX1XxEwZkQ=; b=CNc8Q8M7ObzgZMdrtGWL8bOTawjSNNIt8slbkuTyH3ZSIfFNY5cGjkHd8UItmUJORCjVD5TBkE5u7XRPL2N5TYE7Q9GPsGqr4M8ZFBhFsWFmDUcqo0B272IlW6xlExoYO9domNu/lV8RSUvLeHbqZR371wPxqRahw/CSyVZwJ9AIaJOQk+08/mnXopymwcY8cu48iFnq3CBERqrkSFzVT6XzbbOj2jrjTJsPVCC0eoL1VTe6Rh2rr0Txg4M7NHSQ+yLsYsxiqhS/w6WHVR1AiNTJeOYfGVn6qH5orWqz9jjLXEm0asLVrCmaSE6VP1jwScoIdB0g+LWSqW7SCod/bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wI8IYIs/i9lyMBPic8daXDrb9ISE7YrqHFX1XxEwZkQ=; b=uWtJ9FKsqn6ikzQc/VQbLvZNQ8XnP3Q2IYZOQmlcVqlOejf6J+d92gZhd5xzTQ7o/UxNoZtlmjdCHJ4hXfkJy2TrHS7E/SvSP2s8l/pK4ebnH4VVUDJ4G/XRNPt3GGKsR16ch2MxGCheb83gu8ZZvxs+WsEFq6Vso8ixxe4KgMo= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SA1PR10MB5784.namprd10.prod.outlook.com (2603:10b6:806:23f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Sat, 2 Jul 2022 15:29:18 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::581b:ae2f:16b9:80fb]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::581b:ae2f:16b9:80fb%7]) with mapi id 15.20.5395.018; Sat, 2 Jul 2022 15:29:18 +0000 From: Drew Adams To: Lars Ingebrigtsen , Eli Zaretskii Subject: RE: [External] : bug#56355: 29.0.50; Implement file-parent-directory Thread-Topic: [External] : bug#56355: 29.0.50; Implement file-parent-directory Thread-Index: AQHYjgz0f/cuK6cdBUyoqgPcHOPxiK1rMvzg Date: Sat, 2 Jul 2022 15:29:18 +0000 Message-ID: References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> <8735fj3e9n.fsf@gnus.org> In-Reply-To: <8735fj3e9n.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3399fd70-1187-4ae6-9fac-08da5c3fa128 x-ms-traffictypediagnostic: SA1PR10MB5784:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O77TsMGBTvaB4+FGjucTiXNC/BgYH4bX0mkRtPg0Yp9MVz9TOCnboRmoyQs7NgIxuZ6HRBEha8EHC0oYZEXerGpSiI9rgITjLupOaO5uPuchS3s752LDHixnSGGluYfg59ERtokO/UOYuAnAFd6vJLRGrO4meFfB58OBx6hwqM3SpyPMKjQ3agNp06++lEnmAX1ePSc+sxR09BZgBUxrbMycsJlT3FdihRSY6LDv1x6ZmcPx+HUGq/hVEZBG6/9yOOenCPxsKKPqZd4MTEkKkud1hAvNZ4eh6mUR6l1D7HM5YtzooB0QGXvk2DfZZ0/+o2ww2kgnNXWce/Y7egCFCjtYcaH1xNQgpODUYVqLMeSr9TuA2WDO+IadsLGM5NZdY84gA5J+M2Cwmh4uuYr0+0mo+7cuIFQxOUhWkp3udmdvbVSuIcHS1JmTAu5vQgR16VLbE3cvWow7pZpmkU7BALIVivJwgyr8UrEm2xApWT6zW9a7zkW8SXVXT+Sy6DuUxszqEElk9KlwTvRdmdSCLrIbxQO17HnsHAE4BFk/kx3I//jOQMsKZjTSAp6ytBLPqBRI//EnmcmerK/QTIZ0YKqALZw4ZUwipwrXKArRd95QovvQbpUuDJ7pswiB/3kahAiKww+aYpcS6rflUisT3D4S9natuny+41wVq1MQJHJi0J9E6BaxICZ8y2xuHOBm/okile1ePQzDBqwZuJ0oZVgK9/mJ0mqIrHkTRuGEppSCFUMJkLDHBabSoWjXHvP0fRE3Qes/hdG7yLEsjsg0pF0PaBUlCpRH6s4eDz7oamXsvbdDGD5mjVBCzAEm/9g05rRcPj8NMKiURpE7h4ZQl/T0h2h6nZk68NhtWpTYCME= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(396003)(346002)(376002)(366004)(316002)(122000001)(110136005)(54906003)(86362001)(52536014)(8936002)(44832011)(5660300002)(55016003)(38070700005)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(4326008)(8676002)(9686003)(7696005)(6506007)(26005)(186003)(71200400001)(478600001)(966005)(38100700002)(41300700001)(2906002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rvk6rzffr1/iBg4MJa0TU+RqM7qCB3I7DUNOH4Y0Q75LqkvrcAo3epqVnj3w?= =?us-ascii?Q?3/A3Kvk3RTTrl/A1Xh3hXSvAF/6pXuQ7zNo+uOPCyq9CRjrfRL9Io5KHR99l?= =?us-ascii?Q?om65pxaiO9NXB3+toIDuyi7YuxLYDYsTejSGg2LvsNRrI0oFrEuU7rjrTM1i?= =?us-ascii?Q?o5lbXv6FcU/PIO9N6SQJ7cD6f2cwELvKQd2TVejJEboyc90dEChKXpUnbmlP?= =?us-ascii?Q?e3jUXoDMI4KKIkTpEVC1ZAudjJpY7+RC4AD+R2spnD1eP6VMhUkgRg/HvqL7?= =?us-ascii?Q?Es8TT6wkiaa5P1CbKUWr0noyX4o4qD9AzvwS3D++Zsub6ptZY1qxmDK9rlED?= =?us-ascii?Q?kLesvEIiK2XTSsiANPIWvMBWD0IAtfc+ojBR2VOfKiuLSUUcWSnXOaJYh4cZ?= =?us-ascii?Q?R3ksiabQTHIW2U+Y2DHhyvci7HIe/6UcpQp18hY4fKni/mNJwI+2FwiYHUBz?= =?us-ascii?Q?lgPIhcpvqqk34hC1JARlXfXUom97nkmrxqCEAFsaztSEcBLCRHcQjsG6bDEg?= =?us-ascii?Q?fZJhMtBty7GBVHHJwCGPRiCYW2spWeFQfaquR3OSx8IkupQZnrCCaLlpmCTZ?= =?us-ascii?Q?dnM8u/VVbbzuFIWDQKC7/42ezrv0X2M06oLyJyjPuK4U2mMfPUssAGEGqbDE?= =?us-ascii?Q?HsqNEIJ96HXRD2f/BqAU9jAtY4p5GzVJukzHGoX0Wp7bGhQhnf7lVf99pTw0?= =?us-ascii?Q?SIwKZPVk3B2ID/F28xnaeLUdoK56XBDjofIBYNNNYxHu112IejBGf/1K+REN?= =?us-ascii?Q?7t/Remj+Tah2Kt8rt485JBhitA2VxV2JaWtHcN+lwv71+AKV5E/vKjQb2XYO?= =?us-ascii?Q?P/PxNzXmLVAcpkDcaW/TPMqMkKE9X9jphQjtWzP+Ver/tG9xpCZJ8z8fXciR?= =?us-ascii?Q?WlVppFN2t6RRfcztzytkdCm3ZOBulrUGyjIHckk60Hw8NsvOJnfZ20KhXXll?= =?us-ascii?Q?rs3RPyjE+pdS/kd7KQxoswsHniELmNRPzpBpeCqKduLWcCi78oFmrZEHqJUy?= =?us-ascii?Q?FBezCEkqnE50lNaLPpIQ3E0m29+1Qhycpz0EKup2kXX8TK5GDLwv78aXX2lt?= =?us-ascii?Q?UpbRDoxFwBZab/mP3QVPxHMirYukuKybZrUeAE7gU6j+z3/2DivvhmT26ad5?= =?us-ascii?Q?GuysocV43In2r86lEQQQ5k/0FXBFH3SXIfQRssbeN66kAgx2Iu2bl1/pZ7dY?= =?us-ascii?Q?YC5lWWh/kAs7AZ2fxwnpt3WBdYenXdGuA5GZE3D9jrisX5nLiTYk/XFzAfs9?= =?us-ascii?Q?HcEPKm16WC6dKkyb+APTzUBAbYiEnEaEH38NKGXMHm6ZToYvUVLEl+458H7s?= =?us-ascii?Q?YEh5RQD/t+0/QaAFl/ujXwhmcH3s1nDi8a6gk8+YUPwia9JxdzEmp/jixDiw?= =?us-ascii?Q?N9v1zizB93tA50d4fDE7EgKgIJlFPJCUS218ky8cjFJt1W+NLtNxurCevOY+?= =?us-ascii?Q?LrDO0xxfHBgar0OKAcxM7Dm//HW63PpOIgDywaE2ySGbICqBOxfT6TQzBzXr?= =?us-ascii?Q?GQFlqnxAV496Hp/2udZFRvG6ZuGfA2D9+XT8lao6/he9PGhho+6YSHWL7wC8?= =?us-ascii?Q?fGRP7SyPu+8YfMDDWqV5MpN3XWx72zqKlmDkkttx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3399fd70-1187-4ae6-9fac-08da5c3fa128 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2022 15:29:18.2210 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I4K2LuT1QjpWo30+si7GuSdOObPb6ahnWdPLN+YTfOWhsRVGYe0W9iYcTOQZzJFI4iFiDomQxAUKz+nKv5uYdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5784 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-07-02_11:2022-06-28, 2022-07-02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=777 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207020067 X-Proofpoint-ORIG-GUID: _mvRPxl2EHOaIbyenq8t5Wt76nX5s-Mh X-Proofpoint-GUID: _mvRPxl2EHOaIbyenq8t5Wt76nX5s-Mh X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56355 Cc: daanturo , "56355@debbugs.gnu.org" <56355@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > Thanks, but it looks as a very thin wrapper around > > file-name-directory, so I wonder whether we really=20 > > need a separate function fir this. Need? How easy is it for a user to find and figure out that a combination of `file-name-directory', `directory-file-name', and `expand-file-name' can give you the parent directory name? Maybe your "we" is focused mainly on Emacs developers? Such a function is helpful for users more generally, even if not for those with greater familiarity with the available set of functions. And yes, how to do this has been asked multiple times by users. Here's one such: https://emacs.stackexchange.com/q/9554/105 > I think it looks like a handy utility function -- we have quite a few > instances of (file-name-directory (directory-file-name filename)) >=20 > (possibly with an expand-file-name in there, too) and using > `file-parent-directory' would both express the intention of the code > better, and be less error prone (because many people forget the > `directory-file-name' in the first attempt). I proposed it long, long ago. This version, from Dired+, allows an optional argument to return the relative name, i.e., just the parent component. (defun diredp-parent-dir (file &optional relativep) "Return the parent directory of FILE, or nil if none. Optional arg RELATIVEP non-nil means return a relative name, that is, just the parent component." (let ((parent (file-name-directory (directory-file-name (expand-file-name file)))) relparent) (when relativep (setq relparent (file-name-nondirectory (directory-file-name parent)))) (and (not (equal parent file)) (or relparent parent)))) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 14:24:26 2022 Received: (at 56355) by debbugs.gnu.org; 2 Jul 2022 18:24:26 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7hn8-0000Vy-BP for submit@debbugs.gnu.org; Sat, 02 Jul 2022 14:24:26 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:42728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7hn3-0000Vi-Nd for 56355@debbugs.gnu.org; Sat, 02 Jul 2022 14:24:25 -0400 Received: by mail-pl1-f176.google.com with SMTP id jb13so5136136plb.9 for <56355@debbugs.gnu.org>; Sat, 02 Jul 2022 11:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to; bh=7NdZzRCBMHiMW1U6SOd3nK+7rnA+9YdXpirdXevLQOc=; b=Ma98tMtu3/xufu819Kg6q7g3uGBdnqqguhpjah+5C3AiEr3QfBSmQO8Yb83Q3aXbrG zeSQ28eHGo9ik+e3lSCzAytweJOe8pkxZnzv9XTS5O5S9Be1+LTLNSlxyXAJXUVh8ri4 dmhzTsAt46hgg1uo6usNI+xChEgS54k73dOSbBl7rSSgvseWT/jyf/k8lemUV9Nqg6kO P1wai5yNeM14om0GwcelEowJKq/iRczvv+TlhcIkiGw22A6hcP2MUC8EEOqUe3ybfaYI J/JFWUqA13Cdh//gBt5A0+YGcniG1RZxJWz1Rz/5XT5zAICWsBpUY9sx2LjNv82W6isV Es1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to; bh=7NdZzRCBMHiMW1U6SOd3nK+7rnA+9YdXpirdXevLQOc=; b=ZK0QxVYioCgiK0d4LdQh03ignI8YBacPKXH2mOVT16En8OfkWmAV1WCQiJ1DIBKyL4 S0xJhrezAHPtaoZiuSUOAkP7oij9MY7WLT+mfcBQB0t0WiHAjKwKAmWEmjXusf7Y/lmg NI7jOLK3QJE1sucViMQXF/OcuaX5h/LpQ3kYSuuPzU959zXGB/EbRheMFFKBvjxsCYDc rP41/8HRRxej2t/NITLdlxJChzLrBQEkh8Xwn7ENMHlgTq1E/pbbiqVItlEEL0ZtQr35 v4ROJxOH55vCZN1NBcv4E+XuSd2CLOMfpkUEdo6j3AiUUTFNt/wsGtoEwcxuXU/BThKQ deEA== X-Gm-Message-State: AJIora/5BSSDcQ+NI7y+zKXiz6FFHdSqHyk9o7W4CW8TTCIqf6G5Mrlz BKJR3WPoY/Ev6hYm+osNN0Cb+Kn2OCw= X-Google-Smtp-Source: AGRyM1v8h3U1o53Xx0ogbf9ssrXXMm5RFQJjbPazBqCW1OV9WhQonk9pOzvC0QyeQe+SKt4o+1hSPA== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr23585712pjb.213.1656786255718; Sat, 02 Jul 2022 11:24:15 -0700 (PDT) Received: from ?IPV6:2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802? ([2001:ee0:4fcc:47b0:39d0:f27b:59a8:5802]) by smtp.gmail.com with ESMTPSA id ch9-20020a056a00288900b0051b9e224623sm18409154pfb.141.2022.07.02.11.24.14 for <56355@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 11:24:15 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------3ddgDSNWk2kTdvHR4LfiJtEi" Message-ID: Date: Sun, 3 Jul 2022 01:24:12 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [External] : bug#56355: 29.0.50; Implement file-parent-directory Content-Language: en-US To: "56355@debbugs.gnu.org" <56355@debbugs.gnu.org> References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> <8735fj3e9n.fsf@gnus.org> From: daanturo In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56355 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------3ddgDSNWk2kTdvHR4LfiJtEi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Another revision: this time I check if the found parent is null before comparing with the expanded file name by `file-equal-p` (haven't come to this case, though). And return the relative parent when input is relative. Current cases as in shortdoc.el:     (file-parent-directory "/foo/bar")     ⇒ "/foo/"     (file-parent-directory "~")     ⇒ "/home/"     (file-parent-directory "/tmp/")     ⇒ "/"     (file-parent-directory "foo/bar")     ⇒ "foo/"     (file-parent-directory "foo")     ⇒ "./"     (file-parent-directory "/")     ⇒ nil Also, about the comparator to check if the input is already at top-level; `file-equal-p` looks like the most comprehensive one, but it makes use of `file-truename` which is reported to be slow; on the other hand for `f.el`, `dired+.el`, just comparing two strings with `equal` is sufficient. So I wonder in this case, with both FILENAME and the found parent's names expanded, we can opt to use `equal`/`string=` instead of `file-equal-p` for better performance? -- Daanturo. --------------3ddgDSNWk2kTdvHR4LfiJtEi Content-Type: text/x-patch; charset=UTF-8; name="0001-Define-file-parent-directory.patch" Content-Disposition: attachment; filename="0001-Define-file-parent-directory.patch" Content-Transfer-Encoding: base64 RnJvbSAxOWJlMTMyODcxZDRlYjZlMTJlNjMyNDU0ZDAxNjcyNmQwYjQ4ZDhiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYWFudHVybyA8ZGFhbnR1cm9AZ21haWwuY29tPgpE YXRlOiBTYXQsIDIgSnVsIDIwMjIgMTc6NTU6NTcgKzA3MDAKU3ViamVjdDogW1BBVENIXSBE ZWZpbmUgZmlsZS1wYXJlbnQtZGlyZWN0b3J5CgpHZXQgcGFyZW50IGRpcmVjdG9yeSBvZiBh IGZpbGUuCiogZG9jL2xpc3ByZWYvZmlsZXMudGV4aTogRG9jdW1lbnQgdGhlIGZ1bmN0aW9u LgoqIGV0Yy9ORVdTOiBBZGQgaXRzIGVudHJ5LgoqIGxpc3AvZW1hY3MtbGlzcC9zaG9ydGRv Yy5lbDogQWRkIGl0IHRvICdmaWxlLW5hbWUnIGdyb3VwLgoqIGxpc3AvZmlsZXMuZWw6IGlt cGxlbWVudGF0aW9uCi0tLQogZG9jL2xpc3ByZWYvZmlsZXMudGV4aSAgICAgIHwgIDYgKysr KysrCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAgfCAgMyArKysKIGxpc3AvZW1hY3Mt bGlzcC9zaG9ydGRvYy5lbCB8ICA3ICsrKysrKysKIGxpc3AvZmlsZXMuZWwgICAgICAgICAg ICAgICB8IDE3ICsrKysrKysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDMzIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9maWxlcy50ZXhpIGIvZG9jL2xp c3ByZWYvZmlsZXMudGV4aQppbmRleCBlYTg2ODNhNmQ4Li40MzdhMzAwMWQzIDEwMDY0NAot LS0gYS9kb2MvbGlzcHJlZi9maWxlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL2ZpbGVzLnRl eGkKQEAgLTI0NDUsNiArMjQ0NSwxMiBAQCBEaXJlY3RvcnkgTmFtZXMKIGJlY2F1c2UgaXQg cmVjb2duaXplcyBhYmJyZXZpYXRpb25zIGV2ZW4gYXMgcGFydCBvZiB0aGUgbmFtZS4KIEBl bmQgZGVmdW4KIAorQGRlZnVuIGZpbGUtcGFyZW50LWRpcmVjdG9yeSBmaWxlbmFtZQorVGhp cyBmdW5jdGlvbiByZXR1cm5zIHRoZSBwYXJlbnQgZGlyZWN0b3J5IG9mIEB2YXJ7ZmlsZW5h bWV9LiAgSWYKK0B2YXJ7ZmlsZW5hbWV9IGlzIGF0IHRoZSB0b3AtbGV2ZWwsIHJldHVybiBu aWwuICBAdmFye2ZpbGVuYW1lfSBjYW4gYmUKK3JlbGF0aXZlIHRvIGBkZWZhdWx0LWRpcmVj dG9yeScuCitAZW5kIGRlZnVuCisKIEBub2RlIEZpbGUgTmFtZSBFeHBhbnNpb24KIEBzdWJz ZWN0aW9uIEZ1bmN0aW9ucyB0aGF0IEV4cGFuZCBGaWxlbmFtZXMKIEBjaW5kZXggZXhwYW5z aW9uIG9mIGZpbGUgbmFtZXMKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5k ZXggMzA0MDRjYzEzYy4uM2JmZWJkNmJiNyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIv ZXRjL05FV1MKQEAgLTMxNyw2ICszMTcsOSBAQCBzdGFydHVwLiAgUHJldmlvdXNseSwgdGhl c2UgZnVuY3Rpb25zIGlnbm9yZWQKIAwKICogQ2hhbmdlcyBpbiBFbWFjcyAyOS4xCiAKKyoq IE5ldyBmdW5jdGlvbiAnZmlsZS1wYXJlbnQtZGlyZWN0b3J5JworR2V0IHRoZSBwYXJlbnQg ZGlyZWN0b3J5IG9mIGEgZmlsZS4KKwogKiogTmV3IGNvbmZpZyB2YXJpYWJsZSAnc3ludGF4 LXdob2xlbGluZS1tYXgnIHRvIHJlZHVjZSB0aGUgY29zdCBvZiBsb25nIGxpbmVzLgogVGhp cyB2YXJpYWJsZSBpcyB1c2VkIGJ5IHNvbWUgb3BlcmF0aW9ucyAobW9zdGx5IHN5bnRheC1w cm9wZXJ0aXphdGlvbgogYW5kIGZvbnQtbG9ja2luZykgdG8gdHJlYXQgbGluZXMgbG9uZ2Vy IHRoYW4gdGhpcyB2YXJpYWJsZSBhcyBpZiB0aGV5CmRpZmYgLS1naXQgYS9saXNwL2VtYWNz LWxpc3Avc2hvcnRkb2MuZWwgYi9saXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwKaW5kZXgg YzgyYWEzMzY1Yy4uYTQxMGQ2YzJmYiAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL3No b3J0ZG9jLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9zaG9ydGRvYy5lbApAQCAtMzUzLDYg KzM1MywxMyBAQCBmaWxlLW5hbWUKICAgKGFiYnJldmlhdGUtZmlsZS1uYW1lCiAgICA6bm8t ZXZhbCAoYWJicmV2aWF0ZS1maWxlLW5hbWUgIi9ob21lL3NvbWUtdXNlciIpCiAgICA6ZWct cmVzdWx0ICJ+c29tZS11c2VyIikKKyAgKGZpbGUtcGFyZW50LWRpcmVjdG9yeQorICAgOmV2 YWwgKGZpbGUtcGFyZW50LWRpcmVjdG9yeSAiL2Zvby9iYXIiKQorICAgOmV2YWwgKGZpbGUt cGFyZW50LWRpcmVjdG9yeSAifiIpCisgICA6ZXZhbCAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5 ICIvdG1wLyIpCisgICA6ZXZhbCAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5ICJmb28vYmFyIikK KyAgIDpldmFsIChmaWxlLXBhcmVudC1kaXJlY3RvcnkgImZvbyIpCisgICA6ZXZhbCAoZmls ZS1wYXJlbnQtZGlyZWN0b3J5ICIvIikpCiAgICJRdW90ZWQgRmlsZSBOYW1lcyIKICAgKGZp bGUtbmFtZS1xdW90ZQogICAgOmFyZ3MgKG5hbWUpCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVz LmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCAxMjk1YzI0YzkzLi5jY2IzNTIwZDhjIDEwMDY0 NAotLS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xpc3AvZmlsZXMuZWwKQEAgLTUxNDUsNiAr NTE0NSwyMyBAQCBmaWxlLW5hbWUtc3BsaXQKICAgICAgICAgICAoc2V0cSBmaWxlbmFtZSBu aWwpKSkpCiAgICAgY29tcG9uZW50cykpCiAKKyhkZWZ1biBmaWxlLXBhcmVudC1kaXJlY3Rv cnkgKGZpbGVuYW1lKQorICAiUmV0dXJuIHRoZSBwYXJlbnQgZGlyZWN0b3J5IG9mIEZJTEVO QU1FLgorSWYgRklMRU5BTUUgaXMgYXQgdGhlIHRvcC1sZXZlbCwgcmV0dXJuIG5pbC4gIEZJ TEVOQU1FIGNhbiBiZQorcmVsYXRpdmUgdG8gYGRlZmF1bHQtZGlyZWN0b3J5Jy4iCisgIChs ZXQqICgoZXhwYW5kZWQtZmlsZW5hbWUgKGV4cGFuZC1maWxlLW5hbWUgZmlsZW5hbWUpKQor ICAgICAgICAgKHBhcmVudCAoZmlsZS1uYW1lLWRpcmVjdG9yeSAoZGlyZWN0b3J5LWZpbGUt bmFtZSBleHBhbmRlZC1maWxlbmFtZSkpKSkKKyAgICAoY29uZAorICAgICA7OyBmaWxlbmFt ZSBpcyBhdCB0b3AtbGV2ZWwsIHRoZXJlZm9yZSBubyBwYXJlbnQKKyAgICAgKChvciAobnVs bCBwYXJlbnQpCisgICAgICAgICAgKGZpbGUtZXF1YWwtcCBwYXJlbnQgZXhwYW5kZWQtZmls ZW5hbWUpKQorICAgICAgbmlsKQorICAgICA7OyBmaWxlbmFtZSBpcyByZWxhdGl2ZSwgcmV0 dXJuIHJlbGF0aXZlIHBhcmVudAorICAgICAoKG5vdCAoZmlsZS1uYW1lLWFic29sdXRlLXAg ZmlsZW5hbWUpKQorICAgICAgKGZpbGUtcmVsYXRpdmUtbmFtZSBwYXJlbnQpKQorICAgICAo dAorICAgICAgcGFyZW50KSkpKQorCiAoZGVmY3VzdG9tIG1ha2UtYmFja3VwLWZpbGUtbmFt ZS1mdW5jdGlvbgogICAjJ21ha2UtYmFja3VwLWZpbGUtbmFtZS0tZGVmYXVsdC1mdW5jdGlv bgogICAiQSBmdW5jdGlvbiB0aGF0IGBtYWtlLWJhY2t1cC1maWxlLW5hbWUnIHVzZXMgdG8g Y3JlYXRlIGJhY2t1cCBmaWxlIG5hbWVzLgotLSAKMi4zNy4wCgo= --------------3ddgDSNWk2kTdvHR4LfiJtEi-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 07:08:38 2022 Received: (at 56355) by debbugs.gnu.org; 4 Jul 2022 11:08:38 +0000 Received: from localhost ([127.0.0.1]:46280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwU-0003uM-H0 for submit@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwP-0003u1-0d for 56355@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GqVdCrmtKDBf/1de6i+toYNlPsKr6hk/fozacBrclhM=; b=PromdIKAE7npC1EXg8q6YAIjUL rS+y8xlZarj9S61kyxcqyVyjdy4Qsbgvwz1JLTa9/mYwLNjLt0wWb1NirvsCBuqJlIn9P7C0nbNpi GRjgTKmkpo/VniTAr4WW6be+Yg0V10TKob8d1/Y/+aedGftePV02gcpAstdA7NPLO9zo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8JwF-0006aQ-Vc; Mon, 04 Jul 2022 13:08:26 +0200 From: Lars Ingebrigtsen To: daanturo Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory In-Reply-To: (daanturo@gmail.com's message of "Sun, 3 Jul 2022 01:24:12 +0700") References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> <8735fj3e9n.fsf@gnus.org> X-Now-Playing: Joe Jackson's _Body and Soul_: "The Verdict" Date: Mon, 04 Jul 2022 13:08:22 +0200 Message-ID: <87tu7x6spl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: daanturo writes: > So I wonder in this case, with both FILENAME and the found parent's names > expanded, we can opt to use `equal`/`string=` instead of `file-equal-p` for > better performance? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56355 Cc: "56355@debbugs.gnu.org" <56355@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) daanturo writes: > So I wonder in this case, with both FILENAME and the found parent's names > expanded, we can opt to use `equal`/`string=` instead of `file-equal-p` for > better performance? I think file-equal-p is safer here, so I've pushed your patch to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 07:08:41 2022 Received: (at control) by debbugs.gnu.org; 4 Jul 2022 11:08:41 +0000 Received: from localhost ([127.0.0.1]:46282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwW-0003ua-Oa for submit@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwS-0003u9-Ng for control@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yWLuwYSos5ablrUae9OSo6nAkNCpZl9pEZZnJ0Pk/wo=; b=Qu5BVj9QdPE4cUlkIr8Ojoo6GT zGT3lwmF+ORQyYA6gU1sgTXYcwLV0lLiU/KZq1bbGyTngBoMtj7fo7OUhispIueLdh8FuCM1ns2HQ 5mcjG1iYVwP+6hqSK57SC2FYSS3BGqaRU38mL9PrfBGBCYOoZloZkIwnBBNw+ipTg3QU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8JwK-0006cj-M5 for control@debbugs.gnu.org; Mon, 04 Jul 2022 13:08:30 +0200 Date: Mon, 04 Jul 2022 13:08:28 +0200 Message-Id: <87sfnh6spf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56355 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56355 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56355 29.1 quit From unknown Fri Aug 15 22:18:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Aug 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 06:24:22 2022 Received: (at control) by debbugs.gnu.org; 31 Aug 2022 10:24:22 +0000 Received: from localhost ([127.0.0.1]:38288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTKtS-0003ky-Bi for submit@debbugs.gnu.org; Wed, 31 Aug 2022 06:24:22 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:42618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTKtQ-0003kl-B4 for control@debbugs.gnu.org; Wed, 31 Aug 2022 06:24:20 -0400 Received: by mail-pg1-f181.google.com with SMTP id q63so13112065pga.9 for ; Wed, 31 Aug 2022 03:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:to:from:user-agent :mime-version:date:message-id:from:to:cc; bh=eLpPxGFCkZH3TaCqXkAaBP0E90VqM3AA5R7N43yyVs4=; b=YcD5Y5m2jcsYTeCopkZOFKAzPc7jTaBF1yGmC4bwFuwkzqBfMLR0LY7qzICdFlVW99 DnNgUhFugKeIolJ6v4/s3Ogli50IaVyxYCltnFIY1ZqMOqFi6wVKBf5nmIhc/6u8lCB6 NNWyf5oUiLGbHabq8B6Wp7srmt1yNfyrQ4mOA8v9yzTIukppZKbYrNSejkF09NT11WHC LFlVv21APIjlWASouKfTPovWi0XNsdWNHxr6gHKIArD/EmcnxCwXTtjbO2n7p5LhJKfH VtsCkCTEAVpN0vkMoFBNpiIgJKyS+MORIn5NC2zfJGAx/YdxzXVXoH/2eB76x2v874jQ sgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc; bh=eLpPxGFCkZH3TaCqXkAaBP0E90VqM3AA5R7N43yyVs4=; b=eqlDPLImfAIcHmz/y/Ch0SEIs0xmn+oOXRRtigP2FflM6I4nu7wcSP49bkfQHtCLOR i0xjpIwwAtLDkr7BHcdfS6AkcmrZkvVRND0aR9Z1hkPG+YhV8ot3kEkHH25d2gTfAm0S pkdPaaeQlrq/dVDtHz2On3o0vLP5PkO21a2RnFAXwSxhV/F8fBGGiBKQl4bz544qQiIM FhNVm0aswtSRiD6n1UzpYMHRGwoj/RCDQX+qy5NGW99TOXghLqmed7IcmhP0nKDv5bLf ib2IzCQDzHhX2TS9iLxhmH6HIaHLl2sQclrNw9LgLE/D4E+Yk9ZfR9CEPyhfeGkUgTFs s74A== X-Gm-Message-State: ACgBeo3nW0B/c6ZOnvXYkzmoLSNOhJbq2BiwXVB3AfcLjKyL24WacbWl CF5KRXbv/5Zj4GZ+nvelPBas/TzPHjQ= X-Google-Smtp-Source: AA6agR5E4DEjJVXlQbFz2z7dKi7KV3zS934P4iNIgF+PdFWkYEvTAK9/YXNEXyryU5H92AJ7i1jbVw== X-Received: by 2002:a63:90c7:0:b0:42b:6b68:3655 with SMTP id a190-20020a6390c7000000b0042b6b683655mr21026105pge.335.1661941454118; Wed, 31 Aug 2022 03:24:14 -0700 (PDT) Received: from [192.168.1.3] ([123.20.211.253]) by smtp.gmail.com with ESMTPSA id n12-20020a170902d2cc00b001750b31faabsm3876698plc.262.2022.08.31.03.24.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 03:24:13 -0700 (PDT) Message-ID: <1a9466b9-afb1-109d-e275-6c84ed62dd1b@gmail.com> Date: Wed, 31 Aug 2022 17:21:50 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 From: daanturo To: control@debbugs.gnu.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 56355 -- Daanturo. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (daanturo[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.181 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.181 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 TVD_SPACE_RATIO No description available. X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 56355 -- Daanturo. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 06:26:47 2022 Received: (at 56355) by debbugs.gnu.org; 31 Aug 2022 10:26:47 +0000 Received: from localhost ([127.0.0.1]:38295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTKvn-0003xx-38 for submit@debbugs.gnu.org; Wed, 31 Aug 2022 06:26:47 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTKvk-0003xi-La for 56355@debbugs.gnu.org; Wed, 31 Aug 2022 06:26:45 -0400 Received: by mail-pl1-f171.google.com with SMTP id x23so13715204pll.7 for <56355@debbugs.gnu.org>; Wed, 31 Aug 2022 03:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc; bh=sJbmKkzrI7uBQHE9HD5yQL7SY3iwlctBl1Re/rOSuy0=; b=RZm5xhtghTvuImQdJy+NmV15TkNGpJXJwkyfI2iwRK/qhW8LLLChiObkrhSY0lT5qV 39JQUVL3pFicpATfLp91M7HYesc104N9+Z5XIhv5QZo382JT4nH3kwApQN9fs6Hcv+RT qULeirOBDsRMHb8NRCtjdFO1Y4K7J6TZsq1/b1oZAS+hjeAnKtoTozTjfW8LRNMF64tW OUWxQMppwVqgxSzsXFV7Lza/H57+pdIZkbG7mKfw2vNvz2hNPeN47qpkjcgjjvtYdihx wXsIjfbwDITNnTv68NqXlCKXiPQ/nQaySk2KnS4mbKMF2cSEESeTBvgFMlBj7k5+yfGG O3/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc; bh=sJbmKkzrI7uBQHE9HD5yQL7SY3iwlctBl1Re/rOSuy0=; b=rt30yzpqbCiOHVUt+sa0VYiEINJWLjCkn2lzdouKAHdiUFX/efmRRJ22nw2rTXeZYj xMQhO+/X5colYHx8h32HYmNfYZBbosi7SEJL3dDo/hHvVojSUF71XR+qEsxuQ/d7UXtQ MrIMoX9ynZpLKUpPCEx3eKl/L4c1GfyTvB0UOJzKfBX4hMo6GM6G3YpEs53yfl9XglOr cN0Y2yzi/nm6p3TPg9i1RlQ+KfGhjRh3GphM5jyT7SaL+/AXhE25JpnUSjxiobVps4YM sWKYpeJtaPeBmd6Rco0YIIdjoJ52w3A+YZpi67izAUwH11Cl/ErTbZCxKtjQdd9cHmro Uxrw== X-Gm-Message-State: ACgBeo35fM4QOfwfqL3Y8AH9ADZzWzsToGom2AaCSaDWG6cP+H439zgd mF+tyTG7PQYwnB13Aai7LXxm36oDIcM= X-Google-Smtp-Source: AA6agR7dI4aHvwFxH6qeAWn0aMwhY/yI43tIqQokG0+yyj2w/i/yhWdAJ54f+ES+5bT9MjzINeBJww== X-Received: by 2002:a17:90b:1a88:b0:1f7:3daa:f2f6 with SMTP id ng8-20020a17090b1a8800b001f73daaf2f6mr2576794pjb.245.1661941598450; Wed, 31 Aug 2022 03:26:38 -0700 (PDT) Received: from [192.168.1.3] ([123.20.211.253]) by smtp.gmail.com with ESMTPSA id j13-20020a17090ae60d00b001fb0fc33d72sm1003664pjy.47.2022.08.31.03.26.37 for <56355@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 03:26:37 -0700 (PDT) Message-ID: Date: Wed, 31 Aug 2022 17:26:24 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Content-Language: en-US To: 56355@debbugs.gnu.org From: daanturo Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56355 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) About the comparator again, I hope that we use equal instead of file-equal-p. The former gives far better performance. Let my-parent-directory be a version of file-parent-directory with file-equal-p replaced by equal, both are natively compiled. ``` (length recentf-list) => 659 (benchmark 1 '(mapcar 'my-parent-directory recentf-list)) => "Elapsed time: 0.006954s" (benchmark 1 '(mapcar 'file-parent-directory recentf-list)) => "Elapsed time: 0.230073s" ``` That's about a 33-time difference in speed. Also it's not like that (file-name-directory (directory-file-name <>)) is supposed to resolve symbolic/hard links anyway. -- Daanturo. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 00:14:09 2022 Received: (at submit) by debbugs.gnu.org; 1 Sep 2022 04:14:09 +0000 Received: from localhost ([127.0.0.1]:40843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTbaj-0006vh-6f for submit@debbugs.gnu.org; Thu, 01 Sep 2022 00:14:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:40678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTbad-0006vU-FA for submit@debbugs.gnu.org; Thu, 01 Sep 2022 00:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTbad-0005D7-4P for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:14:03 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTbab-0006BS-0H for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:14:02 -0400 Received: by mail-pg1-x533.google.com with SMTP id 73so6906455pga.1 for ; Wed, 31 Aug 2022 21:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc; bh=tR0m9rfeAnweVjHgDRud5LYoM9tpoR1tMKik8HodMJE=; b=P8nrOMv94qqVbgM4WrFMob92lKBSEJcy66eWficnFjHq5G+N7EEX+NYpCBVYhuMmW/ /f4SezshtClFq1ZELtevCOGYmrZsuNJhynul2aDRwhkO5qQQVuyFa7UUSlzR5rEihl4u m77roIALCwhlwXMaK6vEZ1LcxvkYVYPN5wSY+/NLBYOqBNwvcC69FgOEfiZnSV6GukJ4 VdMqlkMprHQLe5+gWm5ZEjGO6/2lGyaRTHn8e7j1OpYJOP2CEem6wZwk2kTDMSM9EWz3 Sn/O8nH0y04I6K2CVV2VeIXQvML1yYt5Oshg3yWfYPIjI1ciw82pQwYmS3vGyrA9Cse/ 1puw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc; bh=tR0m9rfeAnweVjHgDRud5LYoM9tpoR1tMKik8HodMJE=; b=vsnLqNLVXqWKRfNIUz5Dzv2BbjPX8MDMFAC6uwBwcpt04Qd39/SaBWhZwTCqRFj3hF wP+dlB/iByTObJIrAzQCD/dpVLoB7UiXdK0QXuW/3ClmaCY9fkoG7s9dn/D39bnNOlV9 81snNys7o2+7Dm89z50XpOD+LlPVcB9nweuWhaCgDGfFL6ZTeiKs3eFmKGLTh/ATfuhy hzgDU18BDXgeGCekmnmcRf1hdocr5ZmMX5AZDTcNqUqDPhY3OgjuxCBygA/F76RO7y98 gdt9j+g/pJEFLH3Gqb1hede0IjwtTQ2kSQAjM6qizIlinOtgK5nGyNGFfrw6epf0dFPK 5iOw== X-Gm-Message-State: ACgBeo0k141ncdzEvYOw4wHmhNODMzcaZgIA9nvrDw+N8U01Pg1xJyTW ie2+IJ2Spog/tb79826TWLoIgtoe1zs= X-Google-Smtp-Source: AA6agR7psKvWaAuj5aDgl0q4Wn9ZlJT2dhBcJ6t77qGVPWEak92ZQLUV+k2zgTxSVGsZkmR0/WLdeQ== X-Received: by 2002:a63:d84e:0:b0:42b:5834:fd73 with SMTP id k14-20020a63d84e000000b0042b5834fd73mr24039794pgj.506.1662005638493; Wed, 31 Aug 2022 21:13:58 -0700 (PDT) Received: from [192.168.1.3] ([123.20.211.253]) by smtp.gmail.com with ESMTPSA id h15-20020a170902f7cf00b00174de2bb5f3sm6802440plw.132.2022.08.31.21.13.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 21:13:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------NTKTv6uB9KZEeCQDSgQtPZDV" Message-ID: <226bfba3-d76d-9b32-9527-c8ec8c556a15@gmail.com> Date: Thu, 1 Sep 2022 11:11:31 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory Content-Language: en-US From: daanturo To: bug-gnu-emacs@gnu.org References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> In-Reply-To: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=daanturo@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------NTKTv6uB9KZEeCQDSgQtPZDV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the case of a circular symlink, technically it's still correct to return non-nil. ``` ls -l /tmp/foo total 0 lrwxrwxrwx 1 me me 9 Sep  1 10:59 foo -> /tmp/foo/ ``` In this case: ``` ;;; because (file-equal-p "/tmp/foo/foo/" "/tmp/foo/") => t ;;; therefore (my-parent-directory "/tmp/foo/foo/") ; (the equal version) => "/tmp/foo/" (file-parent-directory "/tmp/foo/foo/") => nil ``` Obviously, the `equal` version fits our expectation better, although that's a mistake at the time of link creation, "/tmp/foo/foo"'s parent still exists and not a nil value. Not to mention `file-equal-p` needs an active TRAMP connection for remote files. -- Daanturo. --------------NTKTv6uB9KZEeCQDSgQtPZDV Content-Type: text/x-patch; charset=UTF-8; name="0001-Change-file-parent-directory-s-behavior.patch" Content-Disposition: attachment; filename="0001-Change-file-parent-directory-s-behavior.patch" Content-Transfer-Encoding: base64 RnJvbSA3NmRjZDE4MTRhZmQyYWU1YjgzYjQzNzkwZDU0ZTM1MTU3N2Q2MjQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYWFudHVybyA8ZGFhbnR1cm9AZ21haWwuY29tPgpE YXRlOiBUaHUsIDEgU2VwIDIwMjIgMDk6NDI6MDUgKzA3MDAKU3ViamVjdDogW1BBVENIXSBD aGFuZ2UgZmlsZS1wYXJlbnQtZGlyZWN0b3J5J3MgYmVoYXZpb3IKCiogbGlzcC9maWxlcy5l bCAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5KTogdXNlIGVxdWFsIGluc3RlYWQgb2YKZmlsZS1l cXVhbC1wIHRvIGNvbXBhcmUgdGhlIGZvdW5kIHBhcmVudCBhbmQgdGhlIGNoaWxkCi0tLQog bGlzcC9maWxlcy5lbCB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXMuZWwgYi9saXNwL2Zp bGVzLmVsCmluZGV4IDc0MGUwOTA1NWIuLmIwODRkY2E4YjcgMTAwNjQ0Ci0tLSBhL2xpc3Av ZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtNTE5Niw3ICs1MTk2LDkgQEAgdG8g YGRlZmF1bHQtZGlyZWN0b3J5JywgYW5kIHRoZSByZXN1bHQgd2lsbCBhbHNvIGJlIHJlbGF0 aXZlLiIKICAgICAoY29uZAogICAgICA7OyBmaWxlbmFtZSBpcyBhdCB0b3AtbGV2ZWwsIHRo ZXJlZm9yZSBubyBwYXJlbnQKICAgICAgKChvciAobnVsbCBwYXJlbnQpCi0gICAgICAgICAg KGZpbGUtZXF1YWwtcCBwYXJlbnQgZXhwYW5kZWQtZmlsZW5hbWUpKQorICAgICAgICAgIDs7 IGBlcXVhbCcgaXMgZW5vdWdoLCB3ZSBkb24ndCBuZWVkIHRvIHJlc29sdmUgc3ltbGlua3Mg aGVyZQorICAgICAgICAgIDs7IHdpdGggYGZpbGUtZXF1YWwtcCcsIGFsc28gZm9yIHBlcmZv cm1hbmNlCisgICAgICAgICAgKGVxdWFsIHBhcmVudCBleHBhbmRlZC1maWxlbmFtZSkpCiAg ICAgICBuaWwpCiAgICAgIDs7IGZpbGVuYW1lIGlzIHJlbGF0aXZlLCByZXR1cm4gcmVsYXRp dmUgcGFyZW50CiAgICAgICgobm90IChmaWxlLW5hbWUtYWJzb2x1dGUtcCBmaWxlbmFtZSkp Ci0tIAoyLjM3LjMKCg== --------------NTKTv6uB9KZEeCQDSgQtPZDV-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 06:08:43 2022 Received: (at 56355) by debbugs.gnu.org; 1 Sep 2022 10:08:43 +0000 Received: from localhost ([127.0.0.1]:41304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTh7r-0001f1-H0 for submit@debbugs.gnu.org; Thu, 01 Sep 2022 06:08:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTh7o-0001em-Ec for 56355@debbugs.gnu.org; Thu, 01 Sep 2022 06:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i9sCUemWCr/0+K4QS7jb+vKJCqL6hRRmFS3zFTDsZAQ=; b=JmoO1cpzRENmiaVIN1zQNHwMZm qz0TFYEdrdb9T0ryJ1mXUz9ktxXAXqXhu2uenq8FcSdz45nJxO/35PHyaXbHyihqYj4/Dd6nIj6JL plVDYW7ptfwbDUvV7UWVZhYC1Z0FKclmi0z4gM21NChS9B2jdH3z//uPqnzn/rKMi0t0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTh7f-0001p7-P1; Thu, 01 Sep 2022 12:08:33 +0200 From: Lars Ingebrigtsen To: daanturo Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory In-Reply-To: (daanturo@gmail.com's message of "Wed, 31 Aug 2022 17:26:24 +0700") References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> X-Now-Playing: Gong Splat's _Gong Splat_: "Cultivated Graves" Date: Thu, 01 Sep 2022 12:08:30 +0200 Message-ID: <87sflbz9sx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: daanturo writes: > About the comparator again, I hope that we use equal instead of file-equal-p. OK; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56355 Cc: 56355@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) daanturo writes: > About the comparator again, I hope that we use equal instead of file-equal-p. OK; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 10:38:55 2022 Received: (at 56355) by debbugs.gnu.org; 4 Sep 2022 14:38:55 +0000 Received: from localhost ([127.0.0.1]:45390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUqlz-0002oJ-5P for submit@debbugs.gnu.org; Sun, 04 Sep 2022 10:38:55 -0400 Received: from mout.gmx.net ([212.227.15.15]:50357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUqlx-0002o5-FX for 56355@debbugs.gnu.org; Sun, 04 Sep 2022 10:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1662302326; bh=eeGNhyFVi5xrqUygyTagh31DWlnFAWCKOUDJkBwB6Go=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XRt3S+bn1vvy+h6/TLNoIJ7C9XVMHxnKOBkhwvn1Va8MzSWY3P4vtL0jk4rtO13S8 EQi4qb2nWoVH6seQI90Y44t63CuXFLYeE1ygqeotsv/bt8eeV+8JDO7pIArQWkSg6Z V45d/NE0hH0TG0ta7LelVo6cE98/lDMS++VG2EKg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.149.173]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McY8d-1p5HaN0h3d-00cujG; Sun, 04 Sep 2022 16:38:46 +0200 From: Michael Albinus To: daanturo Subject: Re: bug#56355: 29.0.50; Implement file-parent-directory In-Reply-To: <226bfba3-d76d-9b32-9527-c8ec8c556a15@gmail.com> (daanturo@gmail.com's message of "Thu, 1 Sep 2022 11:11:31 +0700") References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <226bfba3-d76d-9b32-9527-c8ec8c556a15@gmail.com> Date: Sun, 04 Sep 2022 16:38:45 +0200 Message-ID: <874jxnb3wq.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:jPg6acLnEUmhParhLjkGmGIBYAKaBuKyMQjLlwwanCQ0PxRvRWU bh4y6EO1Z3K4Uj89lqyTAcFjhlsv6ZsR7HUPCwXtJ4ApLQnS8lN1S8GdDm42XMV5Ec9Zgjz Gqs4EwOyhWKwP5oRsjmnsJTjakICWplgTQ6GOj+Jju1zqK3xMxkdIQwJbfdgmOotTReOAfx KlEAGW0sjCUwy7Wj9CIRQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:LhrydcDSAn4=:WrmI3TOOQjUEOurgljv7qo 9Rz6Aa4XDgTEHqmzsOSWAid54jS1LMj3q6NOvoVAUMhMmnn3wmKkTZ0v1A3GzoRUPdjZioSvS DQR9ScxrSt20PitQDezGWYLBeg9Ba5HuVVrwd2G2YlObtGuC0z2QIXINuwyLv/HfIUiooej1S shxS8lfNSlCwG2nWq1xe8Qy3MQVWkA9OEHLiUev0uk3e7p7VT4geIhAQapJp921zEHt0gB9uq ZldMckQRhiDJEAEzWDiVoT/WTiHc4sKw9VO816FPLMqUgpNdJ25vx1l1SdAV/egLDWHiDit8D 0mjOhhnp0BTzeXnci2NVOvu44eSztUAhx8it+SaEO3kC0yUDq9LaKvVhzupCrkPcJhmDQasNc xMGbZ+DTGEUjHd7oDKzxYatpaTYQ779RHllRdkEHC3kdUNjjLbRZKRkJKxbsMIqSSvLOeTFaa G54bohoaX6JU8QYPHnBZ6x5k9w51YBfOZpV1TJx75SEAR5y3GFOlH9l7dcoFfkLlg272zLeco iZsX45aH7e/bjAE02s4Dyirnqn205tPHKeusUFQDGqb08t8cH60MuO7NjXcGEw+h8EzElViwt oO3neP36dH8YQjgoujWLfpZAlwP0MKLiiYDGA81oK29m1pJjJo2WSrgppKDO4NC7NNeEqaRqA aTLGIA8otGPwjs3vESU57nTJGlQ4h4R5NawXcUSK47c2adZ8Tau0Px4NOjbp+t8LYyJvaMBz2 4tIrSb3Uh1KX34A9Ryb0W8PHhjm11P1jym/570IwbtGRSzaTE/sHHX6DpZ1J5JIcqtfVWIVBu n3mCmCRLfMl9rQksebqbcOc4I6HQTkTZyLHX9G1d8JaOTpbbPvQ+BGsK9USLfiyBRxxlyXa9X AU2ozO2L6kewuNP8uf+bT4SENvJsKA07E8LCfOtH5U1wE/KeXl3BVY4SbPg0hLMj2AsQbXplR Ji8sXStl2kiQQLVn6S9xXwcOs3uH4Td26+Mbm2bOWw16+QwuQrMjXgfklK9Z8MLJDFaLqgSWI 4O+wBK8ARdrmgv948GiX0j4olf8jNrWn6Y6rFBplCc2UAN33fb77cHhD5jwdUeUayUABUl0o0 hjplhokUQyrBAWhjjZr1u8L2XgVfPuIrAvuKRwdCdHtu5E2Tkt2PC8OvyO1ODEOh/Vdi+ygRF dhrW86N7LgTgc1uI036yIHfGD3 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56355 Cc: 56355@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) daanturo writes: Hi, > Not to mention `file-equal-p` needs an active TRAMP connection for remote files. Not necessarily. If you let-bind non-essential to t, Tramp tolerates inactive connections. > Daanturo. Best regards, Michael. From unknown Fri Aug 15 22:18:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Oct 2022 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator