GNU bug report logs - #56354
[PATCH] gnu: engineering: Add candle.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: bug#56354: closed (Re: bug#56354: [PATCH] gnu: engineering: Add
 candle.)
Date: Tue, 12 Jul 2022 22:00:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56354: [PATCH] gnu: engineering: Add candle.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56354 <at> debbugs.gnu.org.

-- 
56354: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56354
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>,
 "56354 <at> debbugs.gnu.org" <56354-done <at> debbugs.gnu.org>
Subject: Re: bug#56354: [PATCH] gnu: engineering: Add candle.
Date: Tue, 12 Jul 2022 23:59:50 +0200

[Message part 3 (text/plain, inline)]

Hi,

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:

> From 7aac50730febeb95d0f7a4ab1cbb6e7dfb632553 Mon Sep 17 00:00:00 2001
> From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
> Date: Thu, 23 Jun 2022 23:02:40 +0300
> Subject: [PATCH] gnu: engineering: Add candle.
>
> * gnu/packages/engineering.scm (candle): New variable.

Applied with the changes below.  Note that the license is GPLv3+ because
nothing says it’s “version 3 only”.  I tweaked the description as per
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>.

Thank you, and thanks Jean-Pierre for reviewing!

Ludo’.

[Message part 4 (text/x-patch, inline)]

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index e1297c0f85..dd594af7f8 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -3721,7 +3721,8 @@ (define-public candle
                           (add-after 'unpack 'fix-application-settings-path
                             (lambda _
                               (substitute* "src/frmmain.cpp"
-                                (("qApp->applicationDirPath\\(\\) \\+ \"\\/settings\\.ini\"")
+                                (("\
+qApp->applicationDirPath\\(\\) \\+ \"\\/settings\\.ini\"")
                                  "QDir::homePath() + \"/.config/candle.ini\""))))
                           (replace 'configure
                             (lambda _
@@ -3736,9 +3737,10 @@ (define-public candle
       (home-page "https://github.com/Denvi/Candle")
       (synopsis "GRBL controller with G-Code visualizer")
       (description
-       "GRBL controller application with G-Code visualizer written in Qt.
+       "Candle is a GRBL controller application with a visualizer for G-Code,
+the @acronym{CNC, computer numerical control} programming language.
 
-Supported functions:
+Supported functions include:
 
 @itemize
 @item Controlling GRBL-based cnc-machine via console commands, buttons on
@@ -3747,5 +3749,4 @@ (define-public candle
 @item Loading, editing, saving and sending of G-code files to CNC-machine.
 @item Visualizing G-code files.
 @end itemize")
-      (license license:gpl3))))
-
+      (license license:gpl3+))))

[Message part 5 (message/rfc822, inline)]

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: engineering: Add candle.
Date: Sat, 02 Jul 2022 12:47:39 +0300

[Message part 6 (text/plain, inline)]

Hello,

this patch adds Candle[1] CNC controller.

[0001-gnu-engineering-Add-candle.patch (text/x-diff, attachment)]

[Message part 8 (text/plain, inline)]

Thanks,

- Artyom

References:
1. https://github.com/Denvi/Candle

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.