GNU bug report logs - #56343
‘tests/services/telephony.scm’ fails to run

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56343 in the body.
You can then email your comments to 56343 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: ‘tests/services/telephony.scm’
 fails to run
Date: Fri, 01 Jul 2022 23:34:37 +0200

Hi,

The ‘tests/services/telephony.scm’ file exercises procedures that were
removed from (gnu build jami-service) in
85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
from proceeding:

--8<---------------cut here---------------start------------->8---
$ make check -j5

[...]

PASS: tests/services/file-sharing.scm
PASS: tests/services.scm
PASS: tests/services/linux.scm
make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
make[4]: *** Waiting for unfinished jobs....
PASS: tests/sets.scm
PASS: tests/packages.scm
PASS: tests/pack.scm
PASS: tests/lint.scm
make[4]: Leaving directory '/home/ludo/src/guix'
make[3]: *** [Makefile:6061: check-TESTS] Error 2
--8<---------------cut here---------------end--------------->8---

Should we keep some of the tests in this file, or has it become obsolete
entirely?

Thanks,
Ludo’.

Message #8 received at 56343 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: debbugs-submit <at> debbugs.gnu.org,
 Ludovic Courtès <ludo <at> gnu.org>, 56343 <at> debbugs.gnu.org
Subject: Re: bug#56343: ‘tests/services/telephony.scm’ fails to run
Date: Sat, 02 Jul 2022 03:35:58 -0400

On July 1, 2022 5:34:37 PM EDT, "Ludovic Courtès" <ludo <at> gnu.org> wrote:
>Hi,
>
>The ‘tests/services/telephony.scm’ file exercises procedures that were
>removed from (gnu build jami-service) in
>85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
>from proceeding:
>
>--8<---------------cut here---------------start------------->8---
>$ make check -j5
>
>[...]
>
>PASS: tests/services/file-sharing.scm
>PASS: tests/services.scm
>PASS: tests/services/linux.scm
>make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
>make[4]: *** Waiting for unfinished jobs....
>PASS: tests/sets.scm
>PASS: tests/packages.scm
>PASS: tests/pack.scm
>PASS: tests/lint.scm
>make[4]: Leaving directory '/home/ludo/src/guix'
>make[3]: *** [Makefile:6061: check-TESTS] Error 2
>--8<---------------cut here---------------end--------------->8---
>
>Should we keep some of the tests in this file, or has it become obsolete
>entirely?

It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.

Cheers,

Maxim




Hi,

Message #11 received at 56343 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 56343 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#56343: ‘tests/services/telephony.scm’ fails to run
Date: Tue, 5 Jul 2022 11:27:39 +0200

Hi Maxim,

> It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.
I had to remove tests/services/telephony.scm from Makefile.am, so
we could update the guix package to fix other issues. Please revert
c23e0aa65d511a29f31da876f905594c0f8bce00 once you’ve fixed the tests.

Thanks,
Lars

Message #16 received at 56343-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 56343-done <at> debbugs.gnu.org
Subject: Re: bug#56343: ‘tests/services/telephony.scm’ fails to run
Date: Thu, 07 Jul 2022 10:45:24 -0400

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> The ‘tests/services/telephony.scm’ file exercises procedures that were
> removed from (gnu build jami-service) in
> 85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
> from proceeding:
>
> $ make check -j5
>
> [...]
>
> PASS: tests/services/file-sharing.scm
> PASS: tests/services.scm
> PASS: tests/services/linux.scm
> make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
> make[4]: *** Waiting for unfinished jobs....
> PASS: tests/sets.scm
> PASS: tests/packages.scm
> PASS: tests/pack.scm
> PASS: tests/lint.scm
> make[4]: Leaving directory '/home/ludo/src/guix'
> make[3]: *** [Makefile:6061: check-TESTS] Error 2
>
> Should we keep some of the tests in this file, or has it become obsolete
> entirely?

I've remove all the parsing tests and kept the others; see
258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Thanks for the heads-up!

Closing.

Maxim

Message #19 received at 56343-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 56343-done <at> debbugs.gnu.org
Subject: Re: bug#56343: ‘tests/services/telephony.scm’ fails to run
Date: Fri, 08 Jul 2022 10:38:02 +0200

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> I've remove all the parsing tests and kept the others; see
> 258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Great, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.