GNU bug report logs - #56331
[PATCH] gnu: Graft tzdata to install leap-seconds.list.

Previous Next

To reply to this bug, email your comments to 56331 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <antero <at> mailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Graft tzdata to install leap-seconds.list.
Date: Fri,  1 Jul 2022 01:53:14 +0000

* gnu/packages/base.scm (tzdata)[replacement]: New field.
(tzdata-leap-seconds-list): New private variable.
---
 gnu/packages/base.scm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 4bdc3e7792..b265b429d5 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -1305,6 +1305,7 @@ (define-public tzdata
     ;; This package should be kept in sync with python-pytz in (gnu packages
     ;; time).
     (version "2022a")
+    (replacement tzdata-leap-seconds-list)
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -1390,6 +1391,19 @@ (define-public tzdata
 and daylight-saving rules.")
     (license public-domain)))
 
+(define tzdata-leap-seconds-list
+  (package
+    (inherit tzdata)
+    (arguments
+     (substitute-keyword-arguments (package-arguments tzdata)
+       ((#:phases phases)
+        #~(modify-phases #$phases
+            (add-after 'install 'copy-leap-seconds-list
+              (lambda _
+                (copy-file "leap-seconds.list"
+                           (string-append
+                            #$output "/share/zoneinfo/leap-seconds.list"))))))))))
+
 ;;; A "fixed" version of tzdata, which is used in the test suites of glib and R
 ;;; and a few other places. We can update this whenever we are able to rebuild
 ;;; thousands of packages (for example, in a core-updates rebuild). This package
-- 
2.36.1

Message #8 received at 56331 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <antero <at> mailbox.org>
To: 56331 <at> debbugs.gnu.org
Subject: Re: bug#56331: Acknowledgement ([PATCH] gnu: Graft tzdata to
 install leap-seconds.list.)
Date: Fri, 01 Jul 2022 02:08:50 +0000

leap-seconds.list is required by the hare programming language (which is
currently being packaged) for accurate datetime calculations.

It is optionally used by ntpd with the "leapfile" directive in ntpd.conf.

Message #11 received at 56331 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Antero Mejr" <antero <at> mailbox.org>, <56331 <at> debbugs.gnu.org>
Subject: Re: [bug#56331] [PATCH] gnu: Graft tzdata to install
 leap-seconds.list.
Date: Fri, 01 Jul 2022 10:43:21 +0100

On Fri Jul 1, 2022 at 2:53 AM BST, Antero Mejr via Guix-patches via wrote:
> @@ -1305,6 +1305,7 @@ (define-public tzdata
>      ;; This package should be kept in sync with python-pytz in (gnu packages
>      ;; time).
>      (version "2022a")
> +    (replacement tzdata-leap-seconds-list)
>      (source (origin
>               (method url-fetch)
>               (uri (string-append
> @@ -1390,6 +1391,19 @@ (define-public tzdata
>  and daylight-saving rules.")
>      (license public-domain)))

There's no need to graft it, as long as you make sure tzdata-for-tests
isn't rebuilt.

Message #14 received at 56331 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <antero <at> mailbox.org>
To: 56331 <at> debbugs.gnu.org
Cc: paren <at> disroot.org
Subject: [PATCH] gnu: Update tzdata-for-tests.
Date: Fri,  1 Jul 2022 13:03:14 +0000

* gnu/packages/base.scm (tzdata-for-tests): Install leap-seconds.list.
---
 gnu/packages/base.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 4bdc3e7792..a1d57611ee 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -1398,7 +1398,20 @@ (define-public tzdata
 ;;;
 ;;; Please make this a hidden-package if it is different from the primary tzdata
 ;;; package.
-(define-public tzdata-for-tests tzdata)
+(define-public tzdata-for-tests
+  (hidden-package
+   (package
+     (inherit tzdata)
+     (arguments
+      (substitute-keyword-arguments (package-arguments tzdata)
+        ((#:phases phases)
+         #~(modify-phases #$phases
+             (add-after 'install 'copy-leap-seconds-list
+               (lambda _
+                 (copy-file "leap-seconds.list"
+                            (string-append
+                             #$output
+                             "/share/zoneinfo/leap-seconds.list")))))))))))
 
 (define-public libiconv
   (package
-- 
2.36.1

Message #17 received at 56331 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Antero Mejr <antero <at> mailbox.org>, 56331 <at> debbugs.gnu.org
Cc: paren <at> disroot.org
Subject: Re: [PATCH] gnu: Update tzdata-for-tests.
Date: Fri, 01 Jul 2022 21:49:09 +0200

Am Freitag, dem 01.07.2022 um 13:03 +0000 schrieb Antero Mejr:
> * gnu/packages/base.scm (tzdata-for-tests): Install leap-
> seconds.list.
> ---
>  gnu/packages/base.scm | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
> index 4bdc3e7792..a1d57611ee 100644
> --- a/gnu/packages/base.scm
> +++ b/gnu/packages/base.scm
> @@ -1398,7 +1398,20 @@ (define-public tzdata
>  ;;;
>  ;;; Please make this a hidden-package if it is different from the
> primary tzdata
>  ;;; package.
> -(define-public tzdata-for-tests tzdata)
> +(define-public tzdata-for-tests
> +  (hidden-package
> +   (package
> +     (inherit tzdata)
> +     (arguments
> +      (substitute-keyword-arguments (package-arguments tzdata)
> +        ((#:phases phases)
> +         #~(modify-phases #$phases
> +             (add-after 'install 'copy-leap-seconds-list
> +               (lambda _
> +                 (copy-file "leap-seconds.list"
> +                            (string-append
> +                             #$output
> +                             "/share/zoneinfo/leap-
> seconds.list")))))))))))
That's exactly the patch you weren't supposed to write.  It bumps
tzdata-for-tests, thus causing mass rebuilds, but doesn't bump tzdata.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.