GNU bug report logs - #56329
29.0.50; RET at EOB of *Server* (gnus)

Previous Next

Package: emacs;

Reported by: dick.r.chiang <at> gmail.com

Date: Thu, 30 Jun 2022 22:11:02 UTC

Severity: normal

Found in version 29.0.50

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: dick.r.chiang <at> gmail.com
Cc: 56329 <at> debbugs.gnu.org
Subject: bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus)
Date: Fri, 01 Jul 2022 12:48:22 +0200
dick.r.chiang <at> gmail.com writes:

> +(defsubst gnus-server--server-name (which)
> +  (when-let ((server
> +              (save-excursion
> +                (let (prop)
> +                  (while (and (null (setq prop (get-text-property (point-at-bol) which)))
> +                              (zerop (forward-line -1))))
> +                  prop))))
> +    (symbol-name server)))
> +
>  (defun gnus-server-server-name ()
> -  (let ((server (get-text-property (point-at-bol) 'gnus-server)))
> -    (and server (symbol-name server))))
> +  (gnus-server--server-name 'gnus-server))

This will make commands like `gnus-server-yank-server' fail (you can't
yank a server after the final server), I think?

So this has to be fixed the hard way, like gnus-group-mode does it --
i.e., sprinkle (when (eobp) ...) into the commands where an action on
the final line also makes sense to select the final server.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 161 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.