GNU bug report logs - #56318
[PATCH] import: github: Fix updater.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: bug#56318: closed (Re: bug#56318: [PATCH] import: github: Fix
 updater.)
Date: Mon, 11 Jul 2022 13:38:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56318: [PATCH] import: github: Fix updater.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56318 <at> debbugs.gnu.org.

-- 
56318: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56318
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 56318-close <at> debbugs.gnu.org
Subject: Re: bug#56318: [PATCH] import: github: Fix updater.
Date: Mon, 11 Jul 2022 15:36:39 +0200

Thanks for the review. I amended the commit-message an pushed as 
e8cd9e3d12c8c24b7c81e8787207f21e277da540

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[Message part 3 (message/rfc822, inline)]

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: github: Fix updater.
Date: Thu, 30 Jun 2022 09:42:21 +0200

* guix/import/github.scm(updated-url): For one one of the
  cases add missing 'prefix' and set new version.
---
 guix/import/github.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index 51118d1d39..e1a1af7133 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2019 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2022 Maxime Devos <maximedevos <at> telenet.be>
+;;; Copyright © 2022 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -95,8 +96,8 @@ false if none is recognized"
            ((string-suffix? (string-append "/releases/download/" repo "-"
                                            version "/" repo "-" version ext)
                             url)
-            (string-append "/releases/download/" repo "-" version "/" repo "-"
-                           version ext))
+            (string-append prefix "/releases/download/" repo "-" new-version "/"
+                           repo "-" new-version ext))
            (#t #f))) ; Some URLs are not recognised.
         #f))
 

base-commit: d7449142f56cb0b34860f4ac90fc322aee32d177
-- 
2.30.4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.