From unknown Tue Jun 17 01:47:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56318 <56318@debbugs.gnu.org> To: bug#56318 <56318@debbugs.gnu.org> Subject: Status: [PATCH] import: github: Fix updater. Reply-To: bug#56318 <56318@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:47:27 +0000 retitle 56318 [PATCH] import: github: Fix updater. reassign 56318 guix-patches submitter 56318 Hartmut Goebel severity 56318 normal tag 56318 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 03:42:35 2022 Received: (at submit) by debbugs.gnu.org; 30 Jun 2022 07:42:35 +0000 Received: from localhost ([127.0.0.1]:60874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6oos-0006qF-UJ for submit@debbugs.gnu.org; Thu, 30 Jun 2022 03:42:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:58692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6ooo-0006q4-HW for submit@debbugs.gnu.org; Thu, 30 Jun 2022 03:42:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6ooo-0000VG-6S for guix-patches@gnu.org; Thu, 30 Jun 2022 03:42:30 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:38881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6oom-0001VS-9f for guix-patches@gnu.org; Thu, 30 Jun 2022 03:42:29 -0400 Received: from hermia.goebel-consult.de ([79.211.185.211]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MTR6K-1oCIRQ14MG-00Tom7 for ; Thu, 30 Jun 2022 09:42:24 +0200 Received: from lenashee.fritz.box (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id EF3385F535; Thu, 30 Jun 2022 09:42:23 +0200 (CEST) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH] import: github: Fix updater. Date: Thu, 30 Jun 2022 09:42:21 +0200 Message-Id: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.30.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:beGlotxOzJV+CxVqfCJfal2htpB8+B/8/S5b5Ic4QPOnWXoD6wR aNfMlZ5OdF+TtVu4l2NOO3NBZquvBIk/3aEUU/1kP37tqwnNanJEfLt8PVZVYtNKo6+5otQ 2B6VcwTQMXzGf1cg56Q5XyO13qkns6QVhX5BJRcMfzi8Hlor0Zh3lBby24TiCngmKnNoMyu /89mjAUcsQwRqNf8flPlA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fOygmNoWT9w=:ua7s7vwPq86AASXjeb0btj sV2OOuw4m3PtGS8l8lqqQfoVXL3OgmLGLE76Exq6VtihQdBVTg+KAssjeD6HYSsj2FldeVPMw AWhZ/vc5k39+w26EYjqGEU/p4gfjvAwbiNUUGU8Db8LvR2SAUEdHEDSz0YVrHdVAjO3K7Hm3H zFWgXnQI29qe+y63g9495jV0odPX6dQr2PRuJWeFnjzbWwGG0VFyoe4aD1WWQvfm3oOYKI8gs lHB+ILZ8L6KF+KWupCz2vPgI/1P/9L19eECWljZEWIJ7pt2961VEwElPd60k9cMgtf0OIUgw8 mnMTYLHuv0t3iK88zngA7l5WdyE0Tr5BW8hPHiPL+8+L9tWenEKNcZ+rlMDTJ1LHR0Tk27GUO znviX9B+lGC4VcUhObVeXCnJ9u/SlJRzizruZhRDjRNze0oiKJvpn4gtmfV9IBrP+jD5V+K5f 2eugk61ztzQfWgBr+7TQ1ogxk/GTs6SkTbABmFMEqQlPONvxJKl0oINYfdhtpLjHA/PrhHqTi Goyys6F4nyik/kJqlP6vBlSKBTqMy/1WfXBPeK05cLu3kRZn1UcKYZeN5w5WguWesjyMau4wK Tr5vL9rmyMAeHlFq/UxIYRbcegnzchSWvlogwqjnaZEe/AztTQ2zbl9Kno/RMHffAEOGEYTki mNLqEc2vcd21CSDhZWWqOagMQU3yjQafkW3RC/oOh7K52ephlIJC2uR2Xfbrnea2v/3yvQgs0 3evem7/z77gSt2Jv1RfzFMlsC79AXcZVem/1nAcy2WVC+PYL3tKgutwemfY= Received-SPF: none client-ip=212.227.126.135; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/import/github.scm(updated-url): For one one of the cases add missing 'prefix' and set new version. --- guix/import/github.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/import/github.scm b/guix/import/github.scm index 51118d1d39..e1a1af7133 100644 --- a/guix/import/github.scm +++ b/guix/import/github.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2019 Arun Isaac ;;; Copyright © 2019 Efraim Flashner ;;; Copyright © 2022 Maxime Devos +;;; Copyright © 2022 Hartmut Goebel ;;; ;;; This file is part of GNU Guix. ;;; @@ -95,8 +96,8 @@ false if none is recognized" ((string-suffix? (string-append "/releases/download/" repo "-" version "/" repo "-" version ext) url) - (string-append "/releases/download/" repo "-" version "/" repo "-" - version ext)) + (string-append prefix "/releases/download/" repo "-" new-version "/" + repo "-" new-version ext)) (#t #f))) ; Some URLs are not recognised. #f)) base-commit: d7449142f56cb0b34860f4ac90fc322aee32d177 -- 2.30.4 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 08 17:45:11 2022 Received: (at 56318) by debbugs.gnu.org; 8 Jul 2022 21:45:11 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9vmg-0006Gs-S8 for submit@debbugs.gnu.org; Fri, 08 Jul 2022 17:45:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9vmf-0006GU-2U for 56318@debbugs.gnu.org; Fri, 08 Jul 2022 17:45:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9vmW-0005yB-H6; Fri, 08 Jul 2022 17:45:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pTdxGUCNYLIeCTYan1s0I4YOBEDprZJxfUUeSprkmpE=; b=nDAWV69RvsqQ0jeLmPAJ QBwEIRCc1hE0pYMfohobHrHkikZMQotFNQGGyZ7JKsYKo3XqEhdnifoZXDcqo3+D6DhJrQTNZNaef seYdrovMw1oulphO9Tdsq6RlMSUMWZ2PCMeDqGrTaUDX+FaHtjchPv2WJ8+l6Ai5U8SOFde5lZH00 vHw/1CHWcSJuvxQdyLhQWz6w8W4ZIjVc1r5/3TR8BA01ppTNSOuA2N5bSETeAx7Ie6ZsOJj/Jzue6 9R84VmsxV0Ey2lNQ7W40yY/sDaqntfdyLPluaKvblI4RRp7OZ9TUjebdnsADteFpBxDMI4LAAgNlg I9sZ6aPoUrVA2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62404 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9vmW-0007Gf-5O; Fri, 08 Jul 2022 17:45:00 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hartmut Goebel Subject: Re: bug#56318: [PATCH] import: github: Fix updater. References: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> Date: Fri, 08 Jul 2022 23:44:58 +0200 In-Reply-To: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Thu, 30 Jun 2022 09:42:21 +0200") Message-ID: <87k08ns2hx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56318 Cc: 56318@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Hartmut Goebel skribis: > * guix/import/github.scm(updated-url): For one one of the > cases add missing 'prefix' and set new version. Could you add an example of a case that is fixed by this change in the commit log? (Like =E2=80=9C=E2=80=98guix refresh foo=E2=80=99 would fail t= o find the new release of =E2=80=98foo=E2=80=99 before this change.=E2=80=9D) Also in the commit log: I=E2=80=99d suggest something like =E2=80=9CUse cor= rect URL scheme=E2=80=9D instead of =E2=80=9CFix updater=E2=80=9D, for clarity. Otherwise LGTM (assuming the URL scheme is correct), thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 09:37:05 2022 Received: (at 56318-close) by debbugs.gnu.org; 11 Jul 2022 13:37:05 +0000 Received: from localhost ([127.0.0.1]:38892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAtak-00024s-NB for submit@debbugs.gnu.org; Mon, 11 Jul 2022 09:37:05 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:37801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAtai-00024e-VQ for 56318-close@debbugs.gnu.org; Mon, 11 Jul 2022 09:36:49 -0400 Received: from hermia.goebel-consult.de ([79.211.181.253]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MOzGc-1nuUEg2uR2-00PMj0; Mon, 11 Jul 2022 15:36:42 +0200 Received: from [127.0.0.1] (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id EBF7F665DB; Mon, 11 Jul 2022 15:36:39 +0200 (CEST) Message-ID: <60446b39-4500-68c0-5882-e1db815df977@crazy-compilers.com> Date: Mon, 11 Jul 2022 15:36:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: bug#56318: [PATCH] import: github: Fix updater. Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> <87k08ns2hx.fsf@gnu.org> From: Hartmut Goebel Organization: crazy-compilers.com In-Reply-To: <87k08ns2hx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:hMfnXuhQyO6Y1CZrV3Ex5fU9SDJU1Gp5Mm9GHmJMbEPv0xAzTcx J7jK0vqvw1LKH4P7UbCa3/fhusfTvU6efqJ0cA05WnBMOkms/g3SHEv/BUzrJT+LoYPCqxx aqICKH7mEsL0SSNQWTCpZ9DLZ4fG4SKwoy9HjUTQolHkR3OhDIu+lcBCMHxg/ZnfBcF5vJj qohDkZ3/L4Ev61wVz7LHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:q14WjIrk95o=:4+LKz9Y9ddK68HQ3CZkpT/ BmN+942KDpJhRpr6lKnOOHlOPnLukYppilzgF+lRnBdCW36LfFUbLJO0ReFSw/dPGZaHqBvFG vreaiinvPYcyevXXIlAPvwKifLdF2+3cxQp+jvYtkLKCdEZ7OjX7OP0ogMe177nrnGk+hf5RB wY/FXboVfwV/T8D/KxsZdO/XKBY2UZpnEhHIyJGcsJD4MKmg2hyJ66k/3JauwN6YJjDcnVZ8N AVZtaRLLzR4NDVIhzxXuDRceOsNZXG+z+B4eJ/70Xrrhxay+IURiocIkmNPnd3FGa+NugMzKd xsI4ims2kimuR+wpTEWdwptagrTUEUQqzn84sqVGWoL1NJOvr6MfPJH5u/zf2nC5yD93bADJ0 jHZB4nUk3DRn133rGJj5YdYoOCCC0ImZKdFooH3oXnZoaorfCKE5VdPHavT2k5HbpInmsjPL1 fphjD+bwZ1D6zKF/R9ps3n3ZJ5upLe+L/5d1+m5RuUPQWeT3JZCfu6qDDouc6HWj1KKNnxhJu OPPrLJIfIcSaeKcO4pLsaUUe0tMgZLCv7zdBxYXyv+Mygfe3d04A53Box5viowa/mwWyzsUqa /MiGmgZXZ0l/2b58a2w+YIcQHvyHlWZLKfGSviqS7MEKpP5ILylpokfV1sFPIj80x1dGw2Vpg j8Fd+kX7f23A0ZNDMUZHRU4Y8LT0QGql/JrjTRjV5/hQ1ILHxclBTnLB8F9VVfkQK0d1Zj9hc l+abCrbfywLIofpEgXlFssTLK6T/kXQVAnsIP43wKB6gvul/DsBT+5BDZJA= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56318-close Cc: 56318-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the review. I amended the commit-message an pushed as e8cd9e3d12c8c24b7c81e8787207f21e277da540 -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From unknown Tue Jun 17 01:47:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Aug 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator