From unknown Tue Jun 17 22:18:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 00:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 56309@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16565476218666 (code B ref -1); Thu, 30 Jun 2022 00:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jun 2022 00:07:01 +0000 Received: from localhost ([127.0.0.1]:60447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hi0-0002Fg-EX for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:07:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:58436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hhu-0002FT-PJ for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:06:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhu-00039A-7U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:54 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhr-0001wR-2U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:52 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 467D55C0156 for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 29 Jun 2022 20:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1656547610; x=1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkd bN7NOC84=; b=rafVSOX7K6AijvJQ0KOgtJMbQU9b21OHTUAITXItiNy3vLDVK7m 1l6644b+SO0lvnR/kv9vDEsj6rajUW9xeeVJCe3pH3yK5w+Imui78c/zdtXEFN0k b9cjuwEbPRfWqY/NwdBZXroltunaGKWfVXI/A7HkG9GnTmZnfY9Nh78h2lprLcQs 7OCmSE0UGFSRXDUH4AVdHVX38wQRkBUhjxh0x1RS0b+9qAIk1fhsmUVJFJeWKYs5 r6A9AoW1u7AgEI/ha9PE+4B4njtvl+BM97Ub2PKc6rBdglUkRDzsaNmU0bLPP8HR dXbpEUT5VlBKwrOE+kVUJuU8cT7dpz4mA4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656547610; x= 1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkdbN7NOC84=; b=L gvG0hHqYoJzZjBVapQ7zc2wQ/NzbcNaQEdQqVJGwZpmVCipF2ENFAd4/2lF/juZ6 wn7sD0L8EsVui3Gd4A51XrNxw8APETHJY7t0xX17mqeq7mnbnfAHOrc7nKOGdT9N 9f5uNXnBLxWeiGknKHbvNZd4ud1VEdgwFAuWzM8CXplcsxw46vTiWWH0Y7IenwoG naGcQ+sPQORaTnxcCrG+jqY4vaRHipn0IJ/cThkV1gehsw59D0ttkJx6Jd3u5JnN j0aFXP7V91v5KO3HxDdOlTNTntkFzVpABQuuDwOhjTy4yDKhv1qdBiRO8XozZEIx i4BpoZv0bCs9/XSBEFAvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehtddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufgffkfggtgesthdttddttd ertdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeekffevgeeftedvteduhf etffeffeehheekjeefheeiffdvjeelleettdeuiedvieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhith htohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 583CA7E5600; Wed, 29 Jun 2022 17:06:48 -0700 (MST) From: Sean Whitton User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Wed, 29 Jun 2022 17:06:48 -0700 Message-ID: <87bkubm2uf.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) When server-process-filter calls server-create-dumb-terminal-frame and server-create-window-system-frame it passes along frame parameters supplied on the emacsclient command line, but it doesn't pass these to server-create-tty-frame. I'd like to suggest: diff --git a/lisp/server.el b/lisp/server.el index 8f47a99a31..a06f2f952f 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1314,7 +1314,8 @@ server-process-filter frame-parameters)) ;; When resuming on a tty, tty-name is nil. (tty-name - (server-create-tty-frame tty-name tty-type proc)) + (server-create-tty-frame tty-name tty-type proc + frame-parameters)) ;; If there won't be a current frame to use, fall ;; back to trying to create a new one. -- Sean Whitton From unknown Tue Jun 17 22:18:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton , Lars Ingebrigtsen Cc: 56309@debbugs.gnu.org Received: via spool by 56309-submit@debbugs.gnu.org id=B56309.165656840914735 (code B ref 56309); Thu, 30 Jun 2022 05:54:01 +0000 Received: (at 56309) by debbugs.gnu.org; 30 Jun 2022 05:53:29 +0000 Received: from localhost ([127.0.0.1]:60802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6n7I-0003pb-Ja for submit@debbugs.gnu.org; Thu, 30 Jun 2022 01:53:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6n7A-0003pD-Lj for 56309@debbugs.gnu.org; Thu, 30 Jun 2022 01:53:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6n75-0000Dt-49; Thu, 30 Jun 2022 01:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JsUPpnmEeM1PdmDUjSrs6EEGWAGBo0hgBoqZ1M1rSVw=; b=HUbZscvQ04Ir 5xNQz6HWBz192M8u+l8aqdmab4TCzjCQfH44nvFXbHtm+o41UzRVzcqKCCmAj14jZUHrH98/NNNoz h1BTNm0YVlQCvUzphtRUrA05oNaledNoWVt/If+/X6eCcogzlxXmyvWU3oIE2DkEd/fELhbFOzGUi g63DhJJEI4/3f8+pP5MNkD2Z5nW5dO6B3BpOWsgGG0yYr92XkUiSmnkcGGBnen9QGTMznqpeWoWT5 JsVqcw0dRpBnx1LPtVjqtZF8s4iN1AIBoUIRwpBVX7JqPgX++BzPg/NjFBlJ/GXVs6NuWrjapYm+g YZsvphIUYY89GS/Y+H9Hhg==; Received: from [87.69.77.57] (port=1440 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6n74-0003H7-JB; Thu, 30 Jun 2022 01:53:14 -0400 Date: Thu, 30 Jun 2022 08:53:22 +0300 Message-Id: <83iloi66jx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87bkubm2uf.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 29 Jun 2022 17:06:48 -0700) References: <87bkubm2uf.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Date: Wed, 29 Jun 2022 17:06:48 -0700 > > When server-process-filter calls server-create-dumb-terminal-frame and > server-create-window-system-frame it passes along frame parameters > supplied on the emacsclient command line, but it doesn't pass these to > server-create-tty-frame. > > I'd like to suggest: > > diff --git a/lisp/server.el b/lisp/server.el > index 8f47a99a31..a06f2f952f 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1314,7 +1314,8 @@ server-process-filter > frame-parameters)) > ;; When resuming on a tty, tty-name is nil. > (tty-name > - (server-create-tty-frame tty-name tty-type proc)) > + (server-create-tty-frame tty-name tty-type proc > + frame-parameters)) > > ;; If there won't be a current frame to use, fall > ;; back to trying to create a new one. > That rang a bell, so I looked in the Git history. It turns out this was already part of the patch proposed in bug#24147, which introduced the PARAMETERS argument for server-create-tty-frame, but it was somehow left out of the changes which were actually applied back then, see commit 14fc8a1. From unknown Tue Jun 17 22:18:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 10:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 56309@debbugs.gnu.org, Sean Whitton Received: via spool by 56309-submit@debbugs.gnu.org id=B56309.165658391419638 (code B ref 56309); Thu, 30 Jun 2022 10:12:02 +0000 Received: (at 56309) by debbugs.gnu.org; 30 Jun 2022 10:11:54 +0000 Received: from localhost ([127.0.0.1]:32948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6r9O-00056g-KZ for submit@debbugs.gnu.org; Thu, 30 Jun 2022 06:11:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6r9N-00056S-65 for 56309@debbugs.gnu.org; Thu, 30 Jun 2022 06:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tz/jDgXO79rv+M18clL0nLcBSc3UnuP0awsZcy5fHRU=; b=cipeJpWR3+v72prqGc33G8Jffv fat59fXxNThA13/+lJ67y/Xln9M0heaxtOd4xm3hTxDd+ykwd+Xswfpxdx0x05yjWUrXEuKfrIbGt wYzzre6uoHyU9iPXiX6I96uZhYz/GcycGJj9D1dT0pgzw+O865u3ctd1TC6nSv8rCgu0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6r9D-00029R-PK; Thu, 30 Jun 2022 12:11:46 +0200 From: Lars Ingebrigtsen In-Reply-To: <83iloi66jx.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Jun 2022 08:53:22 +0300") References: <87bkubm2uf.fsf@melete.silentflame.com> <83iloi66jx.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEX9/f3g39tVU1Rs aWnIx8W3tra/vr2mpaaYl5jp6Ojv7++fn59gXl/Z2NjCwb47ODj///845fSbAAAAAWJLR0QQlbIN LAAAAAd0SU1FB+YGHgoKL2/m1zYAAAEgSURBVEjHzZbhkoMgDIQDbIAE077/217gzjv1flTaaccd dUD8SALrKNGsQpxSIkRw5nMqXCMhiZ6W8ADO56/NgWUGKNMRlssB5XopvQCoEKsaTGHEIjBRAtT6 DUOAygDSClilUn2MuRatoq1molqKgZt7Dsxj2roCag3KDDAqO0Bc2Yc9BtDIn0bZA+RO1M4piWj4 KSv4IX71IZUDcLLoZ4Dbe4E2mRLNAtMROvDeGo4R9CGw3zj3jfuCRSWIN0jcqe7a0f4Dbul3XhOw iVvQTdhbgM9h2Z0aNkBO/xIZN0TWDLsjdxGu5aXn7P1w9T9dwyeKvhyQZwFOcn7nvgHtr8tO46O/ 7cvaZ1/W+9IV+xnjclDq2nTviRRD+eQPin0BwOoTrh9dqJQAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjItMDYtMzBUMTA6MTA6NDcrMDA6MDDx5vEnAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA2LTMw VDEwOjEwOjQ3KzAwOjAwgLtJmwAAAABJRU5ErkJggg== X-Now-Playing: Andrew Poppy's _The Beating of Wings_: "Listening in" Date: Thu, 30 Jun 2022 12:11:43 +0200 Message-ID: <87czeqcvfk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > That rang a bell, so I looked in the Git history. It turns out this > was already part of the patch proposed in bug#24147, which introduced > the PARAMETERS argument for server-create-tty-frame, but [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > That rang a bell, so I looked in the Git history. It turns out this > was already part of the patch proposed in bug#24147, which introduced > the PARAMETERS argument for server-create-tty-frame, but it was > somehow left out of the changes which were actually applied back then, > see commit 14fc8a1. Ah, I must have just missed a merge conflict or something when applying the patch. I've pushed the parts that were missing to Emacs 29. Sean, can you check whether this fixes the problem here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 16:53:05 2022 Received: (at control) by debbugs.gnu.org; 30 Jun 2022 20:53:05 +0000 Received: from localhost ([127.0.0.1]:35742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o719t-0001Nj-Hw for submit@debbugs.gnu.org; Thu, 30 Jun 2022 16:53:05 -0400 Received: from mail-pl1-f178.google.com ([209.85.214.178]:45616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o719s-0001MW-9L for control@debbugs.gnu.org; Thu, 30 Jun 2022 16:53:04 -0400 Received: by mail-pl1-f178.google.com with SMTP id d5so421850plo.12 for ; Thu, 30 Jun 2022 13:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=oVZ4uHtmBO1eJtCnBPUWT2LwNwKIqbGSSvclcHd7ggM=; b=ZhlgzpxfUbKTanHa+1L5oHT6JndrAF75thqV+y7G2BsvDKlZbdfZ6uxnhgX9lQn93J ruWIuaLO4JkXej1cfLHYzwktE3NzWkbHqjtqkyByRXqeBU/TL/+UgpTE38p1gpyTqIuo piCFTbRJbbi4eY5oAyfAwxyVYsu3sviyX//Vmp452hO+mTVamJHT/Q/cA6Hz1vtcq1JN v5OEZ80kKaqEu/xQmXpkaIGS2MvxD0QBJm89vo/p2UeIpq0U5h0p2p7J8nEUn5DpcBRw RLnrcHbesXMNcdBaU5+UlbSWf+V/+QAnlyOhRu47I5ul3uvzySJImhaiY01r43nUBAHi bWuw== X-Gm-Message-State: AJIora9m+t5RGb0D7ygQDbDoxH3bXU9hXqMcnfpA2aTS2lu19pTkuEgT q6noJhmSCGcCEKdAm9H9Q3kHvlWr323BbiaL5RupNnzV X-Google-Smtp-Source: AGRyM1ssjlyRTZpku1xnoza2cGFw10+P75bznw+6RJBpnQHGKpXGDoNzhjYasXFYV6cWCz/ibIt9zSZuoElWodeAgls= X-Received: by 2002:a17:902:cecc:b0:16a:416c:3d14 with SMTP id d12-20020a170902cecc00b0016a416c3d14mr16070419plg.73.1656622378634; Thu, 30 Jun 2022 13:52:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 30 Jun 2022 13:52:58 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 30 Jun 2022 13:52:58 -0700 Message-ID: Subject: control message for bug #56309 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 56309 + moreinfo quit From unknown Tue Jun 17 22:18:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sean Whitton Subject: bug#56309: closed (Re: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t) Message-ID: References: <87czepg0it.fsf@melete.silentflame.com> <87bkubm2uf.fsf@melete.silentflame.com> X-Gnu-PR-Message: they-closed 56309 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: moreinfo Reply-To: 56309@debbugs.gnu.org Date: Fri, 01 Jul 2022 00:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1656633962-9140-1" This is a multi-part message in MIME format... ------------=_1656633962-9140-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56309@debbugs.gnu.org. --=20 56309: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56309 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1656633962-9140-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56309-done) by debbugs.gnu.org; 1 Jul 2022 00:05:59 +0000 Received: from localhost ([127.0.0.1]:35947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o74AZ-0002NC-AT for submit@debbugs.gnu.org; Thu, 30 Jun 2022 20:05:59 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o74AV-0002Mu-2g for 56309-done@debbugs.gnu.org; Thu, 30 Jun 2022 20:05:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 38BDF3200A30; Thu, 30 Jun 2022 20:05:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1656633948; x=1656720348; bh=AEKbS7eqgI MBQJifuA4+e8+l37RVCT7nrViVG5Jtm00=; b=UtPI0OA/QJHmzw5h7W7cvA+CtN Ysva5LbYl+rh90Y5zoaY6qulGmndsORgRh1otLLdsrg5cMaoEX12sF5FQfiu71OK P6h5XAy9yjljrbgMToZG1EbdjJj+zdr6JhIiU++/1v4ZE0efxlPyc0JoYxxJDyXs Fgt+QlvwHsPBwaNTE+noeeysuU4j5dw8h3AhOK0N0vpEgvrf+GAMBEQtkfSdkjeo i1KXc1Mzn+v/xzkZFdS3p7N/+eF1z/+sNBnNTd0Besd9haaQqHDBFoGi1vecJs6M sIT5Ifsag8mbVlCEcw4+pHDGb2EGW/xqppVGmxo3mY9EbvGycA31deAqD40Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656633948; x=1656720348; bh=AEKbS7eqgIMBQJifuA4+e8+l37RV CT7nrViVG5Jtm00=; b=vQ/JXagpFh5DydjpjedGen4C7/C48pJ8xh3phnakPLoN r0ZfRBTmPEumpUDXWJ8uk0TojDCGnyA4+yaJTEvXlex9Kl5ZQrZ/hk1SktJVjtrO 77Iu7MfgNMr8qtwCUHaniTGBvvPHztb77P97kso1E8e9qAD93MLfPkrH9w1tmsJE Q700cYys0uFcn9jTbscgg0fjGRE+XZiZtQkJM+UysV67QnjD6lrw0r4r6IgB9dpi Yvnq4lz+eCmLOaZu2bSnqkg6xsu8W1GC+9IIB/wYulScepNR5mQbF+A7rBQNIeP2 4RQqMLqdx9zEwxjafcWV2u3BHugh1Eam/QUj9Ba+Sw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:05:48 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 330997E4DDC; Thu, 30 Jun 2022 17:05:47 -0700 (MST) From: Sean Whitton To: Lars Ingebrigtsen , Eli Zaretskii , 56309-done@debbugs.gnu.org Subject: Re: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t In-Reply-To: <87czeqcvfk.fsf@gnus.org> References: <87bkubm2uf.fsf@melete.silentflame.com> <83iloi66jx.fsf@gnu.org> <87czeqcvfk.fsf@gnus.org> User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Thu, 30 Jun 2022 17:05:46 -0700 Message-ID: <87czepg0it.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56309-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 30 Jun 2022 at 12:11PM +02, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> That rang a bell, so I looked in the Git history. It turns out this >> was already part of the patch proposed in bug#24147, which introduced >> the PARAMETERS argument for server-create-tty-frame, but it was >> somehow left out of the changes which were actually applied back then, >> see commit 14fc8a1. > > Ah, I must have just missed a merge conflict or something when applying > the patch. I've pushed the parts that were missing to Emacs 29. > > Sean, can you check whether this fixes the problem here? It does indeed, thank you both. -- Sean Whitton ------------=_1656633962-9140-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Jun 2022 00:07:01 +0000 Received: from localhost ([127.0.0.1]:60447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hi0-0002Fg-EX for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:07:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:58436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hhu-0002FT-PJ for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:06:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhu-00039A-7U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:54 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhr-0001wR-2U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:52 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 467D55C0156 for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 29 Jun 2022 20:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1656547610; x=1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkd bN7NOC84=; b=rafVSOX7K6AijvJQ0KOgtJMbQU9b21OHTUAITXItiNy3vLDVK7m 1l6644b+SO0lvnR/kv9vDEsj6rajUW9xeeVJCe3pH3yK5w+Imui78c/zdtXEFN0k b9cjuwEbPRfWqY/NwdBZXroltunaGKWfVXI/A7HkG9GnTmZnfY9Nh78h2lprLcQs 7OCmSE0UGFSRXDUH4AVdHVX38wQRkBUhjxh0x1RS0b+9qAIk1fhsmUVJFJeWKYs5 r6A9AoW1u7AgEI/ha9PE+4B4njtvl+BM97Ub2PKc6rBdglUkRDzsaNmU0bLPP8HR dXbpEUT5VlBKwrOE+kVUJuU8cT7dpz4mA4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656547610; x= 1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkdbN7NOC84=; b=L gvG0hHqYoJzZjBVapQ7zc2wQ/NzbcNaQEdQqVJGwZpmVCipF2ENFAd4/2lF/juZ6 wn7sD0L8EsVui3Gd4A51XrNxw8APETHJY7t0xX17mqeq7mnbnfAHOrc7nKOGdT9N 9f5uNXnBLxWeiGknKHbvNZd4ud1VEdgwFAuWzM8CXplcsxw46vTiWWH0Y7IenwoG naGcQ+sPQORaTnxcCrG+jqY4vaRHipn0IJ/cThkV1gehsw59D0ttkJx6Jd3u5JnN j0aFXP7V91v5KO3HxDdOlTNTntkFzVpABQuuDwOhjTy4yDKhv1qdBiRO8XozZEIx i4BpoZv0bCs9/XSBEFAvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehtddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufgffkfggtgesthdttddttd ertdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeekffevgeeftedvteduhf etffeffeehheekjeefheeiffdvjeelleettdeuiedvieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhith htohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 583CA7E5600; Wed, 29 Jun 2022 17:06:48 -0700 (MST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 29.0.50; emacsclient's --frame-parameters option ignored when -t User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Wed, 29 Jun 2022 17:06:48 -0700 Message-ID: <87bkubm2uf.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) When server-process-filter calls server-create-dumb-terminal-frame and server-create-window-system-frame it passes along frame parameters supplied on the emacsclient command line, but it doesn't pass these to server-create-tty-frame. I'd like to suggest: diff --git a/lisp/server.el b/lisp/server.el index 8f47a99a31..a06f2f952f 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1314,7 +1314,8 @@ server-process-filter frame-parameters)) ;; When resuming on a tty, tty-name is nil. (tty-name - (server-create-tty-frame tty-name tty-type proc)) + (server-create-tty-frame tty-name tty-type proc + frame-parameters)) ;; If there won't be a current frame to use, fall ;; back to trying to create a new one. -- Sean Whitton ------------=_1656633962-9140-1--