GNU bug report logs - #56309
29.0.50; emacsclient's --frame-parameters option ignored when -t

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56309 in the body.
You can then email your comments to 56309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; emacsclient's --frame-parameters option ignored when -t
Date: Wed, 29 Jun 2022 17:06:48 -0700

When server-process-filter calls server-create-dumb-terminal-frame and
server-create-window-system-frame it passes along frame parameters
supplied on the emacsclient command line, but it doesn't pass these to
server-create-tty-frame.

I'd like to suggest:

diff --git a/lisp/server.el b/lisp/server.el
index 8f47a99a31..a06f2f952f 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1314,7 +1314,8 @@ server-process-filter
 						       frame-parameters))
 		   ;; When resuming on a tty, tty-name is nil.
 		   (tty-name
-		    (server-create-tty-frame tty-name tty-type proc))
+		    (server-create-tty-frame tty-name tty-type proc
+                                             frame-parameters))
 
                    ;; If there won't be a current frame to use, fall
                    ;; back to trying to create a new one.


-- 
Sean Whitton

Message #8 received at 56309 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56309 <at> debbugs.gnu.org
Subject: Re: bug#56309: 29.0.50;
 emacsclient's --frame-parameters option ignored when -t
Date: Thu, 30 Jun 2022 08:53:22 +0300

> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Date: Wed, 29 Jun 2022 17:06:48 -0700
> 
> When server-process-filter calls server-create-dumb-terminal-frame and
> server-create-window-system-frame it passes along frame parameters
> supplied on the emacsclient command line, but it doesn't pass these to
> server-create-tty-frame.
> 
> I'd like to suggest:
> 
> diff --git a/lisp/server.el b/lisp/server.el
> index 8f47a99a31..a06f2f952f 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1314,7 +1314,8 @@ server-process-filter
>  						       frame-parameters))
>  		   ;; When resuming on a tty, tty-name is nil.
>  		   (tty-name
> -		    (server-create-tty-frame tty-name tty-type proc))
> +		    (server-create-tty-frame tty-name tty-type proc
> +                                             frame-parameters))
>  
>                     ;; If there won't be a current frame to use, fall
>                     ;; back to trying to create a new one.
> 

That rang a bell, so I looked in the Git history.  It turns out this
was already part of the patch proposed in bug#24147, which introduced
the PARAMETERS argument for server-create-tty-frame, but it was
somehow left out of the changes which were actually applied back then,
see commit 14fc8a1.

Message #11 received at 56309 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56309 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#56309: 29.0.50; emacsclient's --frame-parameters option
 ignored when -t
Date: Thu, 30 Jun 2022 12:11:43 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> That rang a bell, so I looked in the Git history.  It turns out this
> was already part of the patch proposed in bug#24147, which introduced
> the PARAMETERS argument for server-create-tty-frame, but it was
> somehow left out of the changes which were actually applied back then,
> see commit 14fc8a1.

Ah, I must have just missed a merge conflict or something when applying
the patch.  I've pushed the parts that were missing to Emacs 29.

Sean, can you check whether this fixes the problem here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 56309-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>,
 56309-done <at> debbugs.gnu.org
Subject: Re: bug#56309: 29.0.50; emacsclient's --frame-parameters option
 ignored when -t
Date: Thu, 30 Jun 2022 17:05:46 -0700

Hello,

On Thu 30 Jun 2022 at 12:11PM +02, Lars Ingebrigtsen wrote:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> That rang a bell, so I looked in the Git history.  It turns out this
>> was already part of the patch proposed in bug#24147, which introduced
>> the PARAMETERS argument for server-create-tty-frame, but it was
>> somehow left out of the changes which were actually applied back then,
>> see commit 14fc8a1.
>
> Ah, I must have just missed a merge conflict or something when applying
> the patch.  I've pushed the parts that were missing to Emacs 29.
>
> Sean, can you check whether this fixes the problem here?

It does indeed, thank you both.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.