From unknown Sat Jun 14 19:11:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56297 <56297@debbugs.gnu.org> To: bug#56297 <56297@debbugs.gnu.org> Subject: Status: Guix style imperfections Reply-To: bug#56297 <56297@debbugs.gnu.org> Date: Sun, 15 Jun 2025 02:11:41 +0000 retitle 56297 Guix style imperfections reassign 56297 guix submitter 56297 Maxime Devos severity 56297 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 05:33:24 2022 Received: (at submit) by debbugs.gnu.org; 29 Jun 2022 09:33:24 +0000 Received: from localhost ([127.0.0.1]:57438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6U4Z-00045W-P5 for submit@debbugs.gnu.org; Wed, 29 Jun 2022 05:33:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:37714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6U4X-00045N-1A for submit@debbugs.gnu.org; Wed, 29 Jun 2022 05:33:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6U4W-0005Sb-QN for bug-guix@gnu.org; Wed, 29 Jun 2022 05:33:20 -0400 Received: from michel.telenet-ops.be ([2a02:1800:110:4::f00:18]:39314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6U4U-0008W2-Cp for bug-guix@gnu.org; Wed, 29 Jun 2022 05:33:20 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id oxZB270034UW6Th06xZBX5; Wed, 29 Jun 2022 11:33:11 +0200 Message-ID: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> Subject: Guix style imperfections From: Maxime Devos To: bug-guix@gnu.org Date: Wed, 29 Jun 2022 11:33:05 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Eo50Gz7S8HCjnRg6uFzR" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656495191; bh=/VLN/hd/oX7gtRpEAOLqp6lS2VEcBsJhmqdAmRPgrtQ=; h=Subject:From:To:Date; b=duRSLMnwUpkspzwCyWeqnWAHDzhDFNrHxHQLZiz5ZLrGA3IrACUPW5ElyKCVoLVxJ M2K7OgbhQX95vNgxQk9xLR1jVzi2D8WHNgJc85tq5mqmMYBpEi5QNq4DUJ4HxxsU7w vUV1X2kWbaT6RCg4Ow+NM+yDizX2DQ/rVzdXOeK19Jo6vbkOPLyE2aZpgYoEqUD76I 5eJAj/c8DeKEOSJAUP/IOTD/wbZnuXwB6R6b2u5XR7dOwPB7DXdvj6XK+mjXBOL5tp M3CychfkKWnC7YdjXYzOibqbD175WUHyKvYfPXQWp18r/Db4box8Qg9B7lMYdgUmNW yItdjD1nOAV4g== Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-Eo50Gz7S8HCjnRg6uFzR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, "guix style" occasionally makes some decision that seem a bit questionable to me. More concretely, copy the definition of guile- next, put it in a .scm and rename it, and run "guix style -L . guile-next-styleme". I get: > (define-module (test)) > (use-modules (guix packages) (guix git-download) (gnu packages autotools)= (gnu packages guile) (guix utils) > (define-public guile-next > (let ((version "3.0.7") (revision "0") > (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) Conventionally 'revision' is put on another line -- for these kind of let b= indings, (maybe all?), I would recommend to put all of them on separate lines. > (package > (inherit guile-3.0) > (name "guile-next-styleme") > (version (git-version version revision commit)) > (source [snip, LGTM]) > (arguments > (substitute-keyword-arguments (package-arguments guile-3.0) > ((#:phases phases > '%standard-phases) `(modify-phases ,phases Put %standard-phases on the same line ad #:phases phases and `(modify-phase= s ,phases on a new lineg=20 > (add-before 'check 'skip-failing-tests > (lambda _ > (substitute* "test-suite/standalone/t= est-out-of-memory" > (("!#") "!# > >(exit 77) >")) I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if that'= s something 'Guix style' could feasibly do (there might be situations where a newline might be appropriate, how could "guix style" which is the case?). > (delete-file > "test-suite/tests/version.test") #t)= ))))) (Would be nice if "guix style" could be taught to remove those #t, but that= seems more a feature limitation than a bug to me.) > (native-inputs (modify-inputs (package-native-inputs guile-3.0) > (prepend autoconf > automake > libtool > flex > gnu-gettext > texinfo > gperf))) I'd consider it tidier to put (modify-inputs ...) on a new line > (synopsis "Development version of GNU Guile")))) Question: do people agree with these style choices? Greetings, Maxime. --=-Eo50Gz7S8HCjnRg6uFzR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrwcURccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oJFAP4hReQBKh4e79ZjH4zlWDSf0wxF fIxX69bkVPNSJJIyAQEAlwFXbrhB8Fk0IRrOgnGHf7qfLhintGcnSxfbthuyQgI= =yODs -----END PGP SIGNATURE----- --=-Eo50Gz7S8HCjnRg6uFzR-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 06:15:09 2022 Received: (at 56297) by debbugs.gnu.org; 29 Jun 2022 10:15:09 +0000 Received: from localhost ([127.0.0.1]:57544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Uiy-0007LP-Ie for submit@debbugs.gnu.org; Wed, 29 Jun 2022 06:15:08 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:41839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Uiw-0007LG-Hy for 56297@debbugs.gnu.org; Wed, 29 Jun 2022 06:15:07 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LXy526NM0z1LLyW; Wed, 29 Jun 2022 12:15:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LXy526NM0z1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1656497703; bh=8kGbGjDEYPAsqPbRXMLDTxhWnFXg5pmrodsxqx8+WN4=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Pq5oSHEfWXwiVBYNIJjb3PrwOuvbzLwZClkaw1ftF+Lv8/ZAQQpZULymPFfkmOYKX uEvKn6b0RR7PpBnXQQ4jvdui4G7lEjpL4QgVIcjQoubiIrBFZ8KMYw5TttpjaUY9cc Cemh7RH5cR3pTvBMgUYeoMLGaJ2tMvYhn7NTXV3Y= Message-ID: <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> Subject: Re: Guix style imperfections From: Liliana Marie Prikler To: Maxime Devos , 56297@debbugs.gnu.org Date: Wed, 29 Jun 2022 12:15:02 +0200 In-Reply-To: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, dem 29.06.2022 um 11:33 +0200 schrieb Maxime Devos: > Hi, > > "guix style" occasionally makes some decision that seem a bit > questionable to me.  More concretely, copy the definition of guile- > next, put it in a .scm and rename it, and run > "guix style -L . guile-next-styleme".  I get: Before commenting on the individual points, I do think in general guix style needs to have a "lax" mode and a "strict" mode where the latter is enabled via "--strict" and keeps certain snippets as-is. All elements that save vertical space at the cost of horizontal space should be disabled in strict mode, whereas they might be acceptable in lax mode. > > (define-module (test)) > > (use-modules (guix packages) (guix git-download) (gnu packages > > autotools) (gnu packages guile) (guix utils) > > (define-public guile-next > >  (let ((version "3.0.7") (revision "0") > >        (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) > > Conventionally 'revision' is put on another line -- for these kind of > let bindings, (maybe all?), I would recommend to put all of them on > separate lines. Agree. > >    (package > >      (inherit guile-3.0) > >      (name "guile-next-styleme") > >      (version (git-version version revision commit)) > >      (source [snip, LGTM]) > >      (arguments > >       (substitute-keyword-arguments (package-arguments guile-3.0) > >         ((#:phases phases > >           '%standard-phases) `(modify-phases ,phases > > Put %standard-phases on the same line ad #:phases phases and `(modify- > phases ,phases on a new line Agree. What's even the point the current style tries to make? > >                                 (add-before 'check 'skip-failing- > > tests > >                                   (lambda _ > >                                     (substitute* "test- > > suite/standalone/test-out-of-memory" > >                                       (("!#") "!# > > > > (exit 77) > > ")) > > I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if > that's something 'Guix style' could feasibly do (there might be > situations where a newline might be appropriate, how could "guix style" > which is the case?). I'd prefer if strict mode typed those out, but we can keep strings "as- is" in lax mode, supposing they don't grow beyond the horizontal limit. > >                                     (delete-file > >                                      "test-suite/tests/version.test") > > #t)))))) > > (Would be nice if "guix style" could be taught to remove those #t, but > that seems more a feature limitation than a bug to me.) It can still do better by not contracting them imho. > >      (native-inputs (modify-inputs (package-native-inputs guile-3.0) > >                       (prepend autoconf > >                                automake > >                                libtool > >                                flex > >                                gnu-gettext > >                                texinfo > >                                gperf))) > > I'd consider it tidier to put (modify-inputs ...) on a new line Here, it depends. I think I'd write this as (native-inputs  (modify-inputs (package-native-inputs guile-3.0) (prepend autoconf automake libtool flex gperf gnu-gettext texinfo))) > >     (synopsis "Development version of GNU Guile")))) > > Question: do people agree with these style choices? I think some people might actually be okay with a few or even all of them (juding by how many submit collapsed lets), but I'd like to point out that they break with Lisp coding guidelines for no good reason. Regarding the optimization of vertical space, I do think that guix lacks semantic information to make meaningful choices and thus ought to either step back when an "informed" user invokes the tool or strictly take the "least optimal, but correct" approach in strict mode. Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 06:18:17 2022 Received: (at 56297) by debbugs.gnu.org; 29 Jun 2022 10:18:17 +0000 Received: from localhost ([127.0.0.1]:57576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Um1-0007Rp-8x for submit@debbugs.gnu.org; Wed, 29 Jun 2022 06:18:17 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:58702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Uly-0007Re-JX for 56297@debbugs.gnu.org; Wed, 29 Jun 2022 06:18:15 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id oyJC2700A4UW6Th01yJCu8; Wed, 29 Jun 2022 12:18:12 +0200 Message-ID: <754b54482ba7e443c587230b33ac56416f2b1eb9.camel@telenet.be> Subject: Re: Guix style imperfections From: Maxime Devos To: Liliana Marie Prikler , 56297@debbugs.gnu.org Date: Wed, 29 Jun 2022 12:18:07 +0200 In-Reply-To: <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-d061YPtVLST8y7WiMTQZ" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656497892; bh=uh5DDwWmBiTnrvbYYtGcQFalqwEA26EoDYlP5HH6sB4=; h=Subject:From:To:Date:In-Reply-To:References; b=nyfnymibeWFH5gBwAPiSQZUhIUNc5ey5J/qo/kyllVg7sqhGvJpIYIMD7ggUGZuaL DLvITrDn30T4YZzQvgww/mBclRoxg/5MGt97UQhRWKu4wcFDXpWCBYo+fArsBXqald 0z8mIl21tBNQoj66RkzRnqXqZl1VhYk1GdulQv4vSocwBMV2iV2Q2QZYxuWdAPWggT sDqECPrXy14yjz7fJ7OJF9MBI9gD4+Lr7c3N1mY621PoUoqoFlx44d5mctRwvpUHV7 kzlwVwkFdT5GKURticsL7vqD0L1H/KkGxZgTgpus+FqjNhfdJ1V3Ir1PParkM0BwAv IJMf4cQc6u8/Q== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56297 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-d061YPtVLST8y7WiMTQZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > Here, it depends.=C2=A0 I think I'd write this as=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0 (native-inputs=C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modify-inputs (package-native-input= s guile-3.0) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (prepend autoconf automa= ke libtool > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 flex gperf > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gnu-gettext texinfo))) FWIW, I was thinking of (native-inputs (modify-inputs [...] (prepend autoconf automake libtool flex gperf gnu-gettext texinfo))) , I haven't really thought about putting multiple inputs on a single line myself. Greetings, Maxime. --=-d061YPtVLST8y7WiMTQZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrwm3xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kY8AP49dfhT3GaF6Uv4wpLEGxnN176/ gMDgCmUe4z1ECruagwEA8/qD8dO3djB5Mv9QRYK0LOXESpkHqgI2e0ADYEDCfQo= =Mqbt -----END PGP SIGNATURE----- --=-d061YPtVLST8y7WiMTQZ-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 06:19:13 2022 Received: (at 56297) by debbugs.gnu.org; 29 Jun 2022 10:19:13 +0000 Received: from localhost ([127.0.0.1]:57589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Umv-0007Up-9b for submit@debbugs.gnu.org; Wed, 29 Jun 2022 06:19:13 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:58702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Umt-0007Re-RI for 56297@debbugs.gnu.org; Wed, 29 Jun 2022 06:19:12 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id oyKB2700C4UW6Th01yKB2z; Wed, 29 Jun 2022 12:19:11 +0200 Message-ID: <473413ef0e01f1dcc7d62602a5b660230b216282.camel@telenet.be> Subject: Re: Guix style imperfections From: Maxime Devos To: Liliana Marie Prikler , 56297@debbugs.gnu.org Date: Wed, 29 Jun 2022 12:19:11 +0200 In-Reply-To: <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-FvP8eZ5bQslQe7MPOs6G" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656497951; bh=0upPPBp7u/wGYUCjDLDSpLzzAXm0ozZp1SRhdvI2efE=; h=Subject:From:To:Date:In-Reply-To:References; b=lQxnHL+5+O7JUGsXiZ5UewBPTOAqiAx6FFd9170s3Kb+Si2kVSPh/iVtzFH2w8g5t fqopQZYtw/g5a6lOd/QFM40MvSeMiiDyxJ9oRFVAzHtFIofd0PeVxvOo51pFfomIku ftBLhp70o0yvtPFyV/SAWNZvXINn4N99W2TQH0HhGgjHN2waPWFSWFB1M9sy57Ljl4 DVsMVkD3+QHxG35n8EeDjL6n6/WXBXkwzbUdhB02hM19YcZvapxx1q7mNSXpYB24OX Eao/dLBFrBhAtB6sTXHlXjsrPdACVh3KRff3T0gPilVTxZbIVzFRxZ6mros9fq1Iu8 ntkF85XMpSyTA== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56297 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-FvP8eZ5bQslQe7MPOs6G Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 TGlsaWFuYSBNYXJpZSBQcmlrbGVyIHNjaHJlZWYgb3Agd28gMjktMDYtMjAyMiBvbSAxMjoxNSBb KzAyMDBdOgo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChkZWxldGUtZmlsZQo+ID4gPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgInRlc3QtCj4gPiA+IHN1aXRlL3Rlc3RzL3ZlcnNpb24udGVzdCIpCj4gPiA+ICN0KSkp KSkpCj4gPiAKPiA+IChXb3VsZCBiZSBuaWNlIGlmICJndWl4IHN0eWxlIiBjb3VsZCBiZSB0YXVn aHQgdG8gcmVtb3ZlIHRob3NlICN0LAo+ID4gYnV0Cj4gPiB0aGF0IHNlZW1zIG1vcmUgYSBmZWF0 dXJlIGxpbWl0YXRpb24gdGhhbiBhIGJ1ZyB0byBtZS4pCj4gSXQgY2FuIHN0aWxsIGRvIGJldHRl ciBieSBub3QgY29udHJhY3RpbmcgdGhlbSBpbWhvLgoKVEJDLCBkbyB5b3UgbWVhbiBkb2luZyAj dCAtPiAjdHJ1ZSwgI2YgLT4gI2ZhbHNlPwoKR3JlZXRpbmdzLApNYXhpbWUuCg== --=-FvP8eZ5bQslQe7MPOs6G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrwnHxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ht6AQD9TBZLgIz00TM9lBpxzw/Q5Q7o Qj/27rcKfohwC2UMjQEA3HE8webHnUqijggjnp1mJv1wh1gvhhOk6Bqu0w1mIQw= =U76J -----END PGP SIGNATURE----- --=-FvP8eZ5bQslQe7MPOs6G-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 06:20:21 2022 Received: (at 56297) by debbugs.gnu.org; 29 Jun 2022 10:20:21 +0000 Received: from localhost ([127.0.0.1]:57593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Uo1-0007Ws-IZ for submit@debbugs.gnu.org; Wed, 29 Jun 2022 06:20:21 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:57579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Unz-0007Wk-GT for 56297@debbugs.gnu.org; Wed, 29 Jun 2022 06:20:19 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LXyC42kh1z1LLyW; Wed, 29 Jun 2022 12:20:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LXyC42kh1z1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1656498016; bh=iBiWfkhrXV9uZLiKyDTuNeFq9lw79T/gaxInc011lco=; h=Subject:From:To:Date:In-Reply-To:References:From; b=ZpSlUYAAgMNzjySleY4W4I2pdmLXwFlSzd4CpHjjYWVrOABBxxRu8DSHHRjW7Q2qB U7yvZNzHHJHvGrgV1d64w8R+L/YwZqIq2VkJVq3spVTky2DPFKp8jZ5g47/+ahbXnJ tRSHYIhY4wehbsGqXgPydGI4fkPpB/4HWXdmJKBU= Message-ID: <4de77339747298c76370c2a78ee7e0944a39078b.camel@ist.tugraz.at> Subject: Re: Guix style imperfections From: Liliana Marie Prikler To: Maxime Devos , 56297@debbugs.gnu.org Date: Wed, 29 Jun 2022 12:20:15 +0200 In-Reply-To: <754b54482ba7e443c587230b33ac56416f2b1eb9.camel@telenet.be> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> <754b54482ba7e443c587230b33ac56416f2b1eb9.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, dem 29.06.2022 um 12:18 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > > Here, it depends.  I think I'd write this as > > > >      (native-inputs  > >        (modify-inputs (package-native-inputs guile-3.0) > >          (prepend autoconf automake libtool > >                   flex gperf > >                   gnu-gettext texinfo))) > > FWIW, I was thinking of > >    (native-inputs >      (modify-inputs [...] >        (prepend autoconf >                 automake >                 libtool >                 flex gperf >                 gnu-gettext >                 texinfo))) > > , I haven't really thought about putting multiple inputs on a single > line myself. That ought to be the strict suggestion; the variant I posted above should simply be seen as "acceptable" in lax mode for not breaking the horizontal space limit. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 06:25:09 2022 Received: (at 56297) by debbugs.gnu.org; 29 Jun 2022 10:25:10 +0000 Received: from localhost ([127.0.0.1]:57675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Usf-0007ke-MG for submit@debbugs.gnu.org; Wed, 29 Jun 2022 06:25:09 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:12994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Use-0007jY-8X for 56297@debbugs.gnu.org; Wed, 29 Jun 2022 06:25:09 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LXyJc5N5fz1LLyW; Wed, 29 Jun 2022 12:25:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LXyJc5N5fz1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1656498304; bh=Apa+7kS0QVQnJlf69JZW9iQrYoQbbumrmOjUGwrgxLM=; h=Subject:From:To:Date:In-Reply-To:References:From; b=mrnH3FhrOzn/UhgI4O6C+k9EGw9He9WUfq4w1p1+CSASgwyCvv+WBN43sICweezbz R/uPj35YtXOI3Y2i7R6z+BReMxrErecGLKiyU/LmYbIUWh0KLeJlJgTgqO0HsAeJAg FYwdeF4xYbq7MAMSMtXQpOyJjaSwlwzchQRFxiNk= Message-ID: <2a8343542ee2301f3effe1cdb04a121c180c119f.camel@ist.tugraz.at> Subject: Re: Guix style imperfections From: Liliana Marie Prikler To: Maxime Devos , 56297@debbugs.gnu.org Date: Wed, 29 Jun 2022 12:25:04 +0200 In-Reply-To: <473413ef0e01f1dcc7d62602a5b660230b216282.camel@telenet.be> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <1d570330e9811ec9327ec4f99e2baed4fd922194.camel@ist.tugraz.at> <473413ef0e01f1dcc7d62602a5b660230b216282.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, dem 29.06.2022 um 12:19 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > > > >                                     (delete-file > > > >                                      "test- > > > > suite/tests/version.test") > > > > #t)))))) > > > > > > (Would be nice if "guix style" could be taught to remove those > > > #t, > > > but > > > that seems more a feature limitation than a bug to me.) > > It can still do better by not contracting them imho. > > TBC, do you mean doing #t -> #true, #f -> #false? I mean leaving them on an extra line. The current style tool mostly errs when contracting multiple lines, which imho should not be its task. The problem that is solved here, is that people sometimes (particularly in the uri field of the source) make these contractions for style reasons. Guix style, having been taught that, tries to extrapolate this to all fields. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 06:11:31 2022 Received: (at 56297) by debbugs.gnu.org; 2 Jul 2022 10:11:31 +0000 Received: from localhost ([127.0.0.1]:39828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7a67-0003BT-Em for submit@debbugs.gnu.org; Sat, 02 Jul 2022 06:11:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7a65-0003BH-T2 for 56297@debbugs.gnu.org; Sat, 02 Jul 2022 06:11:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7a60-000803-30; Sat, 02 Jul 2022 06:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DY+vRrpajUeOumjSv2P49H2MYh8pxyrpUcjYcifttAI=; b=r5/YrYMNKhdME8zUnBuU pJreqUctbIFLY6TmTf/patUQouUsdmRk3D8+DDVIMmAPetPd2RysCZOSrem5PKL8f0vko4AkBBSOQ 1Mq05M9S8bGXDnCWsOiEKvwILiHQ7oW5W1CEz/IHSC/ks/9bv8M8KfM5x7w2GOaU4odJQ3E3qsHnI gXVEtaXtNjbsDDH/0/dUrM4coeBpb1KygLUYvb6vDWQgeUc27hwVDxWsqdi+RRbT+QiQmez0YqcMK iN0YsyCG83wzOgRbaW3xEz6L5I1bxcQ18wdI/KUsH0PIDHZFDjNh/Ce4F/GSHr1TyD28ITBrS7jsF TCkG1hs0UvqOxw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52066 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7a5z-0006zX-L4; Sat, 02 Jul 2022 06:11:23 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#56297: Guix style imperfections References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> Date: Sat, 02 Jul 2022 12:11:21 +0200 In-Reply-To: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> (Maxime Devos's message of "Wed, 29 Jun 2022 11:33:05 +0200") Message-ID: <87sfnj259y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 Cc: 56297@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxime Devos skribis: > "guix style" occasionally makes some decision that seem a bit > questionable to me. Let=E2=80=99s keep in mind that some are bugs/limitations that can be fixed, while others cannot really be addressed because our tastes vary depending on context and the pretty printer could hardly be made smart enough to distinguish all the subtleties. >> (define-public guile-next >> (let ((version "3.0.7") (revision "0") >> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) > > Conventionally 'revision' is put on another line -- for these kind of let= bindings, > (maybe all?), I would recommend to put all of them on separate lines. This one is a bug IMO: =E2=80=98let=E2=80=99 bindings should be treated spe= cially, and currently they=E2=80=99re not. >> (substitute-keyword-arguments (package-arguments guile-3.0) >> ((#:phases phases >> '%standard-phases) `(modify-phases ,phases > > Put %standard-phases on the same line ad #:phases phases and `(modify-pha= ses ,phases > on a new lineg=20 OK. >> (add-before 'check 'skip-failing-tests >> (lambda _ >> (substitute* "test-suite/standalone/= test-out-of-memory" >> (("!#") "!# >> >>(exit 77) >>")) > > I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if tha= t's > something 'Guix style' could feasibly do (there might be situations where= a > newline might be appropriate, how could "guix style" which is the case?). Exactly: in synopses/descriptions, we do want to print newlines as-is (see =E2=80=98tests/style.scm=E2=80=99). Perhaps we could come up with heuristics that make different choices depending on context, but that sounds tricky. >> (delete-file >> "test-suite/tests/version.test") #t= )))))) > > (Would be nice if "guix style" could be taught to remove those #t, but th= at seems > more a feature limitation than a bug to me.) That could be the job of a different style rule (the =E2=80=98-S=E2=80=99 o= ption). >> (native-inputs (modify-inputs (package-native-inputs guile-3.0) >> (prepend autoconf >> automake >> libtool >> flex >> gnu-gettext >> texinfo >> gperf))) > > I'd consider it tidier to put (modify-inputs ...) on a new line Dunno it=E2=80=99s a matter of taste. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 17:41:50 2022 Received: (at 56297) by debbugs.gnu.org; 4 Jul 2022 21:41:50 +0000 Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpF-0002a4-Tk for submit@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpE-0002Zq-IT for 56297@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp9-00072B-8W; Mon, 04 Jul 2022 17:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=k/nR/qCRx0ZFNOGKrTNsgXQn+8HRD6XGsJvWOkxPKdY=; b=cupwe1Q+tkDgGZnyIDB0 BRrB6h2Sce/j6wXsGJgUehFxnv8KKEGQXKBmJbcmlDTcl0whO/qp75L4Hvbgy5im6h5ZrmjZCfuRB xmFg81QfhazG6QwGYKiMco42zuJCpXa5+DcDAUH5a784FYA5ZCkRCvy93OSq5zmU7fLDtXtZyi0px wkmDkbo/CenMFrGv5yUvRDQqqC+z/K0Owc2ZVtzsNf+X8LApnJz8xqU3ZJtBMBT6Lb06c+Llz8d3m 8nbuI8KTinmvvwgdZcD2O2bW62LAnIJDdRh2Zg5h5KHiNNz/bdYqUcKLqLTrhGmANNzvq2CNsnJ4b gYhiS/pNhT05bA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54762 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp8-0003hG-S9; Mon, 04 Jul 2022 17:41:43 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#56297: Guix style imperfections References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <87sfnj259y.fsf@gnu.org> Date: Mon, 04 Jul 2022 23:41:40 +0200 In-Reply-To: <87sfnj259y.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 02 Jul 2022 12:11:21 +0200") Message-ID: <87mtdo7dyj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 Cc: 56297@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ludovic Court=C3=A8s skribis: >>> (define-public guile-next >>> (let ((version "3.0.7") (revision "0") >>> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) >> >> Conventionally 'revision' is put on another line -- for these kind of le= t bindings, >> (maybe all?), I would recommend to put all of them on separate lines. > > This one is a bug IMO: =E2=80=98let=E2=80=99 bindings should be treated s= pecially, and > currently they=E2=80=99re not. Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this, and=E2=80=A6 >>> (substitute-keyword-arguments (package-arguments guile-3.0) >>> ((#:phases phases >>> '%standard-phases) `(modify-phases ,phases >> >> Put %standard-phases on the same line ad #:phases phases and `(modify-ph= ases ,phases >> on a new lineg=20 =E2=80=A6 the second part of this one. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 19 09:40:54 2022 Received: (at 56297) by debbugs.gnu.org; 19 Jul 2022 13:40:55 +0000 Received: from localhost ([127.0.0.1]:53143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDnT4-0006eO-HI for submit@debbugs.gnu.org; Tue, 19 Jul 2022 09:40:54 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:45630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDnT0-0006eD-DN for 56297@debbugs.gnu.org; Tue, 19 Jul 2022 09:40:53 -0400 Received: from ptr-bvsjgyig5nh0salm0pi.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id x1gm2700K20ykKC061gnaG; Tue, 19 Jul 2022 15:40:48 +0200 Message-ID: Subject: Re: bug#56297: Guix style imperfections From: Maxime Devos To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Tue, 19 Jul 2022 15:40:46 +0200 In-Reply-To: <87mtdo7dyj.fsf@gnu.org> References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <87sfnj259y.fsf@gnu.org> <87mtdo7dyj.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658238048; bh=VUPOW/DOBNI3b/GKchGYhrwS5xIt99zzDOAj4838uNI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Ce0knUhRij1rRTgOBSY4Y3V2FTNCHp0zmnAmIJtKRZZHG5+p7ArI/OS4P+ssdULf1 SC8/f4qOYJdUfcMz0O8uGZ3Tq/xB3haHVgtNM1Ry1EzndKhZZ6zGAb9bEr56a7PbsW qU6PsvtcQ9Q2TcR+0kuzns68CF/30vJhbifWkROjP0EhzvoQtlDA2uF28mLLU/uoc2 lhVJqubBmQTlqdHkCpyC+0PD6vYqBYdNIxyhRCVXt0VIAl13rqAhCwH+pFnKVIU1XF 7SZUGG0b3Ps/fn/aoVrP+bUU8/a5wMjWpAimal49/I7iHcr8kGxMXUX6sEwu/U9tDz dfktdOsFioc/w== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56297 Cc: 56297@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Courtès schreef op ma 04-07-2022 om 23:41 [+0200]: > > Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this [...] Some issues remain, but nice!