GNU bug report logs - #56257
[PATCH] fenics: Do not use mpirun for tests

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: <Ontje.Luensdorf <at> dlr.de>
Subject: bug#56257: closed (Re: bug#56257: [PATCH] fenics: Do not use
 mpirun for tests)
Date: Wed, 03 Aug 2022 10:05:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56257: [PATCH] fenics: Do not use mpirun for tests

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56257 <at> debbugs.gnu.org.

-- 
56257: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56257
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 56257-done <at> debbugs.gnu.org, Ontje.Luensdorf <at> dlr.de
Subject: Re: bug#56257: [PATCH] fenics: Do not use mpirun for tests
Date: Wed, 03 Aug 2022 12:04:50 +0200

Hi,

(Sorry for the delay.)

"Paul A. Patience" <paul <at> apatience.com> skribis:

> Ludovic Courtès writes:
>> Good question.  Paul, do you remember the reasons for doing so?
>
> If I'm the Paul you're referring to, it would be better to CC me in the
> future, as I'm not subscribed to the list and only intermittently check
> it (which happens more often when I'm submitting patches).

I actually Cc’d Paul Garlick, but maybe Debbugs ate the Cc: field?

> I'm no expert in MPI and pytest, but it does seem that pytest_mpi [1] is
> recommended when combining the two, and there are no instances of
> @pytest.mark.mpi in the fenics repository.
> Further, running pytest tests under MPI is accomplished with [2]:
>
>   mpirun -n 2 python -m pytest --with-mpi
>
> In other words, it seems as if the current tests are repeated in
> parallel, as Ontje discovered.
>
> The patch looks good to me.

Alright, applied.

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: <Ontje.Luensdorf <at> dlr.de>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] fenics: Do not use mpirun for tests
Date: Mon, 27 Jun 2022 11:24:49 +0000

[Message part 4 (text/plain, inline)]

Hi guix,


the fenics package tests fail and it looks like the tests are run 3
times concurrently. Every test name is printed three times in the build
log, for example here:

https://ci.guix.gnu.org/build/1039880/log/raw

This is the maximum number of parallel jobs of the test run and if I
increase it, I get more print outputs.

AFAIK, pytest doesn't support mpi, so I don't see why the tests are
executed this way.

Anyhow, in the attached patch, the tests are executed directly using
pytest. This prevents the tests from getting stuck and subsequently I
discovered a failure in XDMF tests. With this test also disabled, the
package builds fine for me.

Maybe a fenics or mpi expert can tell if this patch makes sense?

Best regards,
Ontje

[0001-gnu-fenics-Do-not-mpirun-tests.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.