GNU bug report logs - #56213
[PATCH] gnu: Add maven-doxia-core

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: bug#56213: closed (Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core)
Date: Sat, 25 Jun 2022 20:27:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56213: [PATCH] gnu: Add maven-doxia-core

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56213 <at> debbugs.gnu.org.

-- 
56213: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56213
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 56213-done <at> debbugs.gnu.org
Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core
Date: Sat, 25 Jun 2022 22:25:59 +0200

[Message part 3 (text/plain, inline)]

Pushed to master as d039f9dc151eed8017a7f54682dbf713221b8005, thank you!

A few answers below:

Le Sat, 25 Jun 2022 15:14:58 +0300,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :

> Hello Julien.
> 
> > Thanks for the patch!  
> 
> Thanks for taking your time for reviewing my patch.  :-)
> 
> > Missing full stop at the end of the subject line.  
> 
> Okay, added a full-stop.
> 
> FWIW, I'm usually following those rules when writing commit messages:
>   https://cbea.ms/git-commit/#end
> 
> The rules explicitly say that a committer should not add a full-stop
> at the end of the first line.

We follow our own rules that mandate a full stop. I thought I could
send you to the manual, but apart a vague mention of the ChangeLog
format, I can't find the rules. Have we always applied such strict
rules without writing them down properly?

> 
> However, 'guix lint' gave me the following warning:
> --8<---------------cut here---------------start------------->8---
> /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2:
> maven-doxia-core <at> 2.0.0-M2: propagated inputs plexus-parent-pom <at> 5.1
> and plexus-parent-pom <at> 4.0 collide --8<---------------cut
> here---------------end--------------->8---
> 
> I don't know yet how to properly fix that; probably the issue is that
> I made all the inputs propagated, but I don't see how to differentiate
> them looking at the Doxia Core 'pom.xml'.

You can ignore these issues about parent poms. There's no real
collision except for the package name. No files in common between the
two packages, so that's fine. Nothing we can do anyway.

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add maven-doxia-core
Date: Sat, 25 Jun 2022 13:26:09 +0300

[Message part 6 (text/plain, inline)]

Hello,

this patch adds "Maven Doxia Core" under the name 'maven-doxia-core'.

[0001-gnu-Add-maven-doxia-core.patch (text/x-diff, attachment)]

[Message part 8 (text/plain, inline)]

Thanks,

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.