From unknown Fri Jun 20 20:12:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56213 <56213@debbugs.gnu.org> To: bug#56213 <56213@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add maven-doxia-core Reply-To: bug#56213 <56213@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:12:52 +0000 retitle 56213 [PATCH] gnu: Add maven-doxia-core reassign 56213 guix-patches submitter 56213 "Artyom V. Poptsov" severity 56213 normal tag 56213 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 06:26:21 2022 Received: (at submit) by debbugs.gnu.org; 25 Jun 2022 10:26:21 +0000 Received: from localhost ([127.0.0.1]:44181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o52zd-00089Y-5X for submit@debbugs.gnu.org; Sat, 25 Jun 2022 06:26:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:42288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o52zb-00089R-F1 for submit@debbugs.gnu.org; Sat, 25 Jun 2022 06:26:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o52zb-0007ik-6Y for guix-patches@gnu.org; Sat, 25 Jun 2022 06:26:19 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:40496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o52zZ-0006VR-DF for guix-patches@gnu.org; Sat, 25 Jun 2022 06:26:18 -0400 Received: by mail-lf1-x12c.google.com with SMTP id t25so8519669lfg.7 for ; Sat, 25 Jun 2022 03:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=mSg6ZOFJ6uDBF73Ns/WFO24WZsGAQ2qMGMreI3Zr2+0=; b=Eir8thX0W/ggUvVRjQ50KJMdfIk5mGsIIWLYH77mTAISsZCn9shmXJ9xR+kBrWq9Pp vQfVr5CsG3TPxTGsAyuxXtaMuE+R3U7BG2cZJr9nWh+xo90w9teGLpnra5e1WB/kp5ts QFSd0q1dU370k0RsPKqm8/SF/Ur29twj4dzdIHDalOYceaqbvLmk/P1sdrpCan6ObZty mUbkDjU+aHzrEHWvLblSn3CiXoJstbafi351jI23K3Jffr9XgfHgswub5V9vZ2pv8Ymq /n2AqdDIJuFq64iZHq/L6v9MTcION7eCF3Gu+JPtQqTxno6wfNLknp9xmyb4XIllRfS2 2urg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=mSg6ZOFJ6uDBF73Ns/WFO24WZsGAQ2qMGMreI3Zr2+0=; b=BC/W3JYSjHx8Tx2sqbIg7qGj1X4aSd6ikCpUt/jF3DhUFrWb19mUHUZ59jXZDjUUlo ZswTJMYeVKF97dH22fphQU9VcCnXqSCMbhxzNvqr33BrOLXzP9f6sZAUDncDt9cGeK3A 9hhH6hdydiY1RMTIcFRdZxt7H7bxDXJ0L6jpTHXZOpNa4VWCehZkRwnXw8nY5r0V6e95 K+EEpp1eZYkUIF5r98iYe3DJt70oBovrM1k+RwCNO4dIcbvfX/6Xyymb296vTO0w5dlC 96bNJhJ6fUDXz27HIWzISEmlu52/UbD2NS+40ZC5O9vO5IBddysxJjPcr7bPA7xVu+at +pLQ== X-Gm-Message-State: AJIora+QDt6/3cGgsT5UAb1yBcNvXy9eckiNR1h+KCZHiXI+iUqvBvlc F3e39yRl3SacZL+S9jmBxFPja6nzuZg= X-Google-Smtp-Source: AGRyM1t+qHUai9XPj71jeMYy2yQIMKux6FW3thdh7nbJ0j3d5JIvR4LP8xBIj9tKASjvtvl/Y0RolQ== X-Received: by 2002:a19:8c5c:0:b0:47f:9bf4:9745 with SMTP id i28-20020a198c5c000000b0047f9bf49745mr2051999lfj.492.1656152773584; Sat, 25 Jun 2022 03:26:13 -0700 (PDT) Received: from elephant ([5.164.222.47]) by smtp.gmail.com with ESMTPSA id m10-20020a056512358a00b0047255d21129sm804825lfr.88.2022.06.25.03.26.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 03:26:13 -0700 (PDT) From: "Artyom V. Poptsov" To: guix-patches@gnu.org Subject: [PATCH] gnu: Add maven-doxia-core Date: Sat, 25 Jun 2022 13:26:09 +0300 Message-ID: <878rplniny.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=poptsov.artyom@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello, this patch adds "Maven Doxia Core" under the name 'maven-doxia-core'. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-gnu-Add-maven-doxia-core.patch Content-Transfer-Encoding: quoted-printable From=204e06642ac47d0b69fb5aeb5e8b21efaacbc7ed67 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Sat, 25 Jun 2022 13:20:02 +0300 Subject: [PATCH] gnu: Add maven-doxia-core * gnu/packages/maven.scm (maven-doxia-core): New variable. =2D-- gnu/packages/maven.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index e5831ee614..95de84e845 100644 =2D-- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -3921,6 +3921,32 @@ encapsulate common text syntax. A start tag is deno= ted by @code{xxxx()} method and a end of tag by @code{xxxx_()} method.") (license license:asl2.0))) =20 +(define-public maven-doxia-core + (package + (inherit maven-doxia-sink-api) + (name "maven-doxia-core") + (arguments + `(#:jar-name "doxia-core.jar" + #:source-dir "doxia-core/src/main/java" + #:tests? #f ;no tests + #:phases (modify-phases %standard-phases + (replace 'install + (install-from-pom "doxia-core/pom.xml"))))) + (inputs (list maven-doxia-sink-api + java-slf4j-api + java-javax-inject + java-plexus-utils + java-eclipse-sisu-plexus + java-commons-text)) + (home-page "https://maven.apache.org/doxia/index.html") + (synopsis "Doxia core classes and interfaces") + (description + "Doxia is a content generation framework that provides powerful +techniques for generating static and dynamic content, supporting a variety= of +markup languages.") + (license license:asl2.0))) + + (define maven-doxia-parent-pom (package (inherit maven-doxia-sink-api) =2D-=20 2.25.1 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks, =2D Artyom =2D-=20 Artyom "avp" Poptsov Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE0MLqwTMQgi2Y3rV86cWi2QiYoC8FAmK24sEACgkQ6cWi2QiY oC85iAgAlMEjaJa43l9MAJsjmB+xl3xgxTgU2kxCGTjhn90vTdYOWbc8p9/SkOzT x4N0epAYyAbxFDBwpxKc7RIm0sTJN4/FBiqrMf6/2mz9mJlW5DymB/Qcsz68ZA6T 2DeqwED0Bfzl4MdfXPJGZE4LzLiJ7rf50rL8tGA+ZCaar2QpV9FUQsPXdC7Ij3lf DJ3DWzOoQfxpSTt/LEI9ByoYIGX+QLM8vJY0AdI9jrvdSft+SOvrYR+aAUVmPLaJ qMZDsmM1QVHKQoxfCofw5EDrBomRICqO5M3b6L/v033cRXLGjeHWwPA1fTBkyQg7 37YAozF+PJhufgl5yotxjlBCopfViQ== =4X+O -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 07:21:27 2022 Received: (at 56213) by debbugs.gnu.org; 25 Jun 2022 11:21:27 +0000 Received: from localhost ([127.0.0.1]:44227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53qw-0003HR-So for submit@debbugs.gnu.org; Sat, 25 Jun 2022 07:21:27 -0400 Received: from lepiller.eu ([89.234.186.109]:41778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53qs-0003HG-3u for 56213@debbugs.gnu.org; Sat, 25 Jun 2022 07:21:25 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 07b55e55; Sat, 25 Jun 2022 11:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=rlwrIj5c2Rf2yJJJ9zGxn8xiYQKLCNLR/GC9eR SKOJs=; b=iibuxj24ajiLlb5g1tqwRvzwE+YMu0XcBwuY3bEs3+WffweZghX85o 99zyGoUR6tbnfff4ubE2/kX1SjrSmZ8CHMEOcoYDHKARK73nlpfQvKDQbfciqq88 r/v3PV44RdRNNoKerKhYfgFSCUw1QZQAY33teetKGV7Y3rAE3P2Qw6hVv+d/65Bx knwGA5sSWI0h/R0A3vtB24DLyqlL2dBuwCj7SDVcCwW06yV6gWYphczw7gyEykjF 0SnTGUnpuuTcIW5VOPosb70wnYpWRiFwgPhIIOEg7F9RYdjaq8mTXTkHi7UUAFHm K9LaqunshphtBukPrCR111KyBluqq8Gg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6218102c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 11:21:19 +0000 (UTC) Date: Sat, 25 Jun 2022 13:21:17 +0200 From: Julien Lepiller To: "Artyom V. Poptsov" Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core Message-ID: <20220625132117.6da69dda@sybil.lepiller.eu> In-Reply-To: <878rplniny.fsf@gmail.com> References: <878rplniny.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/FaL3PV_5jyrggGzJzQsuumc"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56213 Cc: 56213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/FaL3PV_5jyrggGzJzQsuumc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for the patch! A few remarks below :) Le Sat, 25 Jun 2022 13:26:09 +0300, "Artyom V. Poptsov" a =C3=A9crit : > From 4e06642ac47d0b69fb5aeb5e8b21efaacbc7ed67 Mon Sep 17 00:00:00 2001 > From: "Artyom V. Poptsov" > Date: Sat, 25 Jun 2022 13:20:02 +0300 > Subject: [PATCH] gnu: Add maven-doxia-core Missing full stop at the end of the subject line. >=20 > * gnu/packages/maven.scm (maven-doxia-core): New variable. > --- > gnu/packages/maven.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm > index e5831ee614..95de84e845 100644 > --- a/gnu/packages/maven.scm > +++ b/gnu/packages/maven.scm > @@ -3921,6 +3921,32 @@ encapsulate common text syntax. A start tag > is denoted by @code{xxxx()} method and a end of tag by @code{xxxx_()} > method.") (license license:asl2.0))) > =20 > +(define-public maven-doxia-core > + (package > + (inherit maven-doxia-sink-api) > + (name "maven-doxia-core") > + (arguments > + `(#:jar-name "doxia-core.jar" > + #:source-dir "doxia-core/src/main/java" > + #:tests? #f ;no tests This package actually has tests, could you enable them? > + #:phases (modify-phases %standard-phases > + (replace 'install > + (install-from-pom "doxia-core/pom.xml"))))) > + (inputs (list maven-doxia-sink-api > + java-slf4j-api > + java-javax-inject > + java-plexus-utils > + java-eclipse-sisu-plexus > + java-commons-text)) The pom file references most of these as runtime dependencies, so we need to propagate them, so maven can find them. We also need to propagated the parent pom :) > + (home-page "https://maven.apache.org/doxia/index.html") > + (synopsis "Doxia core classes and interfaces") > + (description > + "Doxia is a content generation framework that provides powerful > +techniques for generating static and dynamic content, supporting a > variety of +markup languages.") This feels like a description of the whole Doxia project. Could you add maybe one sentence to explain how this package is related to the whole doxia project? > + (license license:asl2.0))) > + > + > (define maven-doxia-parent-pom > (package > (inherit maven-doxia-sink-api) Lastly, I would put this package just below maven-doxia-parent-pom, but that's mostly aesthetic :) --Sig_/FaL3PV_5jyrggGzJzQsuumc Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK2760ACgkQU9RXstY2 7oLK9BAAh67JwhTBb2zicG3lnhL98lvv9tNyKS3nuzZQTsFWNgYHim5U96bnAVxi drKWUd13enoFCvOt6hCg+AEFk0eZyq+XYBT1rL0aXbzMqXSeg47z1xO2L0yYkQ42 5M/npDu8dpuDSdvRh64rQr0XsSgTpGiR5Tu9UH97DoxHI2eBQkIjQmycsDJz/Llv JVlocCgoiHjXegw9Z4eVXBLh5C7eKEzFFyY0ger25Cj3AeQ5gtZq1vJ61gHWh4kf b8N+7lLFAcxwJyikMfzeDYhS68/ySnjmp1yPS21PTZJZEJ3yjcI/xJZBjKk5zmQO JZ3Ph/PW0VOmNcA3HwP62bcmOeBu0BKz8D8IJiZh506zleIIirCYgf2kHtmi+Sld 1l+xfnjbAdh8SwpbXnkn5lFh+O45HwfS33yzMMqzB5/ZU1JJI9uQH+iCRYt4CheV cb+00fAQ+W4NPxeo+8wd9lowAi7UwStguETypgYNQEEwj/dNeAErx+zdljzXMpIP BtVilynJGH9LgSOU4dw9U5iDRLXraEv3DbTeUyjyhZAjtXll89uV/j1aYU6n+NcK u8vru4jG/OmzmPGJdz43lgXpFkv4qnN8nB7xSn/jNF/FGh3EFm2vt13bstRnrpfa yS4yLr0J1/0Rt3sxJPb32BWmJrNaRZ0AVgZ8fjN+VcA44QmlM28= =w0ok -----END PGP SIGNATURE----- --Sig_/FaL3PV_5jyrggGzJzQsuumc-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 08:15:14 2022 Received: (at 56213) by debbugs.gnu.org; 25 Jun 2022 12:15:14 +0000 Received: from localhost ([127.0.0.1]:44326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54h0-000730-0O for submit@debbugs.gnu.org; Sat, 25 Jun 2022 08:15:14 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54gx-0006tZ-1S for 56213@debbugs.gnu.org; Sat, 25 Jun 2022 08:15:12 -0400 Received: by mail-lf1-f47.google.com with SMTP id t25so8799003lfg.7 for <56213@debbugs.gnu.org>; Sat, 25 Jun 2022 05:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cl5z/xI4HYDmrdselQegONCJByH2b8Ja+ULN25GCNQA=; b=KzWyO9DgyiUdZGmTok8fFdqTcmhXncZhXjlBOZXlXnbRoVBPUO5vNT5rVjAsryFC8B JxpXCwy2eS5gdXzrHpLDhS1wgbezzXXeeq1AaWTjY4IyV/az5GJFcJvo4jO1Nq/WCr+c oM1SwstbXHbyEJapJFhqAtdluwwa10nyviq0/DFAnQyY9kjf/Igq6WI0Bvy6X6AN7UEr uRwkNCbt7qYdt/+jn3WEkRIYHQCP4vAWLfsZs4Nsl/DOh2jFpFs3mAOleFFeP3AaMxlu oUYpIfLR+IrIMKDXA8iMFgiSKY5+lQs+8CvQzenO8JHGRuXCavxxBLFksyibOKWmta/n SnIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cl5z/xI4HYDmrdselQegONCJByH2b8Ja+ULN25GCNQA=; b=VlsNKHLpQhFoPPK0Zl/DCcswEJpRq0UtPpHCGRleAQXGc1iykCq3iN4f5jgZ0ZZySl 2d6ajS0dXJKaG0fFMjrvVVnGFp3qMGIKQ9A0paI7nWOlOFiZX/jBqgYJDS9HaEBy/Trc cmv888Ngjx8FSMyihZxaamuGiJhWppmslzJ8EnlAVXvoahR4kUQGT1pDBFx9qdRl9meS MFDTKfbeuC/oh2FPijEwOCJpXuWW2/jXtpgDlTOGFasOw/jAhZv2SIysVfTWHA9yGQ0S eTVaUP9s76FlOr/SMcgzcpQlFdB72SR8U7RC0wQfqJZ+IP877gEXWod0zvoKVNmaus/y 1wuQ== X-Gm-Message-State: AJIora9HliXjRFY0xcxCJorbyhY8OLHapijxbhEiW7SMpQam7eodjYIe O9TN1LTuXzxjAkE7oWHvjH0XlIsEPoE= X-Google-Smtp-Source: AGRyM1ubKZqLMn+sBP9GvqcuPDrzNTggQ1X13uo7rczAbhK7I7EbE75orB7uqwO45tG/psE0tWG70A== X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr2235418lfa.442.1656159302986; Sat, 25 Jun 2022 05:15:02 -0700 (PDT) Received: from elephant ([5.164.222.47]) by smtp.gmail.com with ESMTPSA id a19-20020ac25e73000000b0047255d21205sm829875lfr.308.2022.06.25.05.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 05:15:02 -0700 (PDT) From: "Artyom V. Poptsov" To: Julien Lepiller Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core References: <878rplniny.fsf@gmail.com> <20220625132117.6da69dda@sybil.lepiller.eu> Date: Sat, 25 Jun 2022 15:14:58 +0300 In-Reply-To: <20220625132117.6da69dda@sybil.lepiller.eu> (Julien Lepiller's message of "Sat, 25 Jun 2022 13:21:17 +0200") Message-ID: <87wnd52b3x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56213 Cc: 56213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello Julien. > Thanks for the patch! Thanks for taking your time for reviewing my patch. :-) > Missing full stop at the end of the subject line. Okay, added a full-stop. FWIW, I'm usually following those rules when writing commit messages: https://cbea.ms/git-commit/#end The rules explicitly say that a committer should not add a full-stop at the end of the first line. > This package actually has tests, could you enable them? Unfortunately tests require JUnit5. :-/ > The pom file references most of these as runtime dependencies, so we > need to propagate them, so maven can find them. > We also need to propagated the parent pom :) Done. However, 'guix lint' gave me the following warning: --8<---------------cut here---------------start------------->8--- /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2: maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 and plexus-parent-pom@4.0 collide --8<---------------cut here---------------end--------------->8--- I don't know yet how to properly fix that; probably the issue is that I made all the inputs propagated, but I don't see how to differentiate them looking at the Doxia Core 'pom.xml'. > This feels like a description of the whole Doxia project. Could you add > maybe one sentence to explain how this package is related to the whole > doxia project? Done. > Lastly, I would put this package just below maven-doxia-parent-pom, but > that's mostly aesthetic :) Done. Please find the updated patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-gnu-Add-maven-doxia-core.patch Content-Transfer-Encoding: quoted-printable From=20749617e6c68d11edea3437cc72dc74013e851463 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Sat, 25 Jun 2022 13:20:02 +0300 Subject: [PATCH] gnu: Add maven-doxia-core. * gnu/packages/maven.scm (maven-doxia-core): New variable. =2D-- gnu/packages/maven.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index e5831ee614..514ba97028 100644 =2D-- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -3938,3 +3938,32 @@ method and a end of tag by @code{xxxx_()} method.") (description "@samp{Doxia} is a content generation framework that prov= ides powerful techniques for generating static and dynamic content, supporting a variety of markup languages."))) + +(define-public maven-doxia-core + (package + (inherit maven-doxia-sink-api) + (name "maven-doxia-core") + (arguments + `(#:jar-name "doxia-core.jar" + #:source-dir "doxia-core/src/main/java" + #:test-dir "doxia-core/src/test/java" + #:tests? #f ; tests require JUnit5 + #:phases (modify-phases %standard-phases + (replace 'install + (install-from-pom "doxia-core/pom.xml"))))) + (propagated-inputs (list maven-doxia-parent-pom + maven-doxia-sink-api + java-slf4j-api + java-javax-inject + java-plexus-utils + java-eclipse-sisu-plexus + java-commons-text)) + (home-page "https://maven.apache.org/doxia/index.html") + (synopsis "Doxia core classes and interfaces") + (description + "Doxia is a content generation framework that provides powerful +techniques for generating static and dynamic content, supporting a variety= of +markup languages. + +This package contains Doxia core classes and interfaces.") + (license license:asl2.0))) =2D-=20 2.25.1 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D Artyom =2D-=20 Artyom "avp" Poptsov Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE0MLqwTMQgi2Y3rV86cWi2QiYoC8FAmK2/EIACgkQ6cWi2QiY oC+sLAf/db+yzh7K53598Sv2LkHUVmWvi4IxROCp7R8THRWGuk0KKFpHBBsIhFMB 6TvnXBbuKJw4giMDmA8gUEvTdMyirFsohsGheUvet5hHl0x+u1e24fTJryNaqcbL DEqDvhWEPOLk3ULW+21NMBMJgiHk9A+TCaa0/mqNkWcsNx9QL5GbB7KzpW2tjggV JVq1tCK4qSyBrfhlnkgDdHGOTttClS8+cdLKY7GKUDIk57EXudYZ6gdCKToVL0Wq OHPVwCYECI12WbtPf8rxP9NP8+JclK7LoKQ4mpjSySPhOH1x3Ao23I8u7TEBv6Rj 1gN8p+Br5oDVcJvapeXPxORkDcgE6A== =KGco -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 16:26:07 2022 Received: (at 56213-done) by debbugs.gnu.org; 25 Jun 2022 20:26:07 +0000 Received: from localhost ([127.0.0.1]:46261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5CM3-0002xD-ES for submit@debbugs.gnu.org; Sat, 25 Jun 2022 16:26:07 -0400 Received: from lepiller.eu ([89.234.186.109]:41816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5CLz-0002x2-5p for 56213-done@debbugs.gnu.org; Sat, 25 Jun 2022 16:26:06 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3da5e5f1; Sat, 25 Jun 2022 20:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=XXNrP/dJhC6/vPjwxhOAkHtUF9pcKtX5uiUEo9 xsYBg=; b=byAu9+QO9o1bNeNT5NCl1qqvuWrr27EsgJ6bsNcg3WkRLQqq86D7Ry woxM+Lmw9tEVTRmfOLeQYz5S07Df08vPF1erOJbRS8igVPRsgxFqEbdczSXxgsfc GKdnU6OAVwwTAA+ddOL4/Sytf+Bio/3pDewV5CYt/gAjhIvQFc4Vpu/23iL6938e INwj6vFly1csApO0Sw+x6HSTKhlIgIHaGovAJ9wcJwWRHNkHeQWETO9WnIO+Acak n1pxj4nTc5TcFuzXxbYy8I8nth21R008UnGOuGNlAVXYPao9U8I/Q3VLuE2lrCH7 jEGslEsALgVOuYnI/O0473YpJtYsXEow== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3e4df399 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 20:26:00 +0000 (UTC) Date: Sat, 25 Jun 2022 22:25:59 +0200 From: Julien Lepiller To: "Artyom V. Poptsov" Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core Message-ID: <20220625222559.5e92b63f@sybil.lepiller.eu> In-Reply-To: <87wnd52b3x.fsf@gmail.com> References: <878rplniny.fsf@gmail.com> <20220625132117.6da69dda@sybil.lepiller.eu> <87wnd52b3x.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=K=/eIdr.eYUB=uEh0O3C3H"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56213-done Cc: 56213-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/=K=/eIdr.eYUB=uEh0O3C3H Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pushed to master as d039f9dc151eed8017a7f54682dbf713221b8005, thank you! A few answers below: Le Sat, 25 Jun 2022 15:14:58 +0300, "Artyom V. Poptsov" a =C3=A9crit : > Hello Julien. >=20 > > Thanks for the patch! =20 >=20 > Thanks for taking your time for reviewing my patch. :-) >=20 > > Missing full stop at the end of the subject line. =20 >=20 > Okay, added a full-stop. >=20 > FWIW, I'm usually following those rules when writing commit messages: > https://cbea.ms/git-commit/#end >=20 > The rules explicitly say that a committer should not add a full-stop > at the end of the first line. We follow our own rules that mandate a full stop. I thought I could send you to the manual, but apart a vague mention of the ChangeLog format, I can't find the rules. Have we always applied such strict rules without writing them down properly? >=20 > However, 'guix lint' gave me the following warning: > --8<---------------cut here---------------start------------->8--- > /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2: > maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 > and plexus-parent-pom@4.0 collide --8<---------------cut > here---------------end--------------->8--- >=20 > I don't know yet how to properly fix that; probably the issue is that > I made all the inputs propagated, but I don't see how to differentiate > them looking at the Doxia Core 'pom.xml'. You can ignore these issues about parent poms. There's no real collision except for the package name. No files in common between the two packages, so that's fine. Nothing we can do anyway. --Sig_/=K=/eIdr.eYUB=uEh0O3C3H Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK3b1cACgkQU9RXstY2 7oKi/Q/8Dhz8akLG818fVqtRoD6u4pqEjqkb+ZJWwmxyIhpm9KfTscqmcn09gGI+ DMjJC6xTPfiZMCaHA3v3ElF8RZISCjapOV/QvoWHxJDrPkjluQ/JUdoTTRMp6F4W IytwPtvil0U6gaH7+2y7L0eMHLCUuiaQFn450Y4MmVIyhRd3hdvCt3gVsaB4Xxt/ UPTbVW2GYrGe1CYUKpst3Rh0OwDr9ezOKt2Dv1w9MDm0rkDOp0/4XXQq6tfpPEXD SBNLH1Ab7pUEof0I53rtXKb7wsvANIn1pjS/fSz3MT7m3WOYfySuot0YT/vrOD9d huR+o9eL8Fwrzj3/pmFDopy5XeMpP0+u1QYcebH+xrRS7EbSCZo+DyzpLIZ2zRt2 HvlY8c1r54vYks1+shPWIm6Lu166z3IXXySFKYsKquQtrmQzps+15nSgk9cfEgmq XhWk9ihYZSs4OlqoKyErUTvVIcvXuVWS27QxcSver2+c4lDspT9+1rc/qWbDm6r7 4GSrB1WlHxWLfjhzL52dwlpBmvaQEN3FIT/oiD3bAPhLq4+LSan4HBBU50AyvIdg eJ5rWjJBWbtCUVWeTvSBStzKBadR8ciuN/8CjLBpBSG4vUfKxppWhBBFu/PTHcrG BJULGKMrdm7H/xnP04CO8XquNffcRMIFZRMtO3oCdiw6ZC4zX1Y= =CebK -----END PGP SIGNATURE----- --Sig_/=K=/eIdr.eYUB=uEh0O3C3H-- From unknown Fri Jun 20 20:12:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Jul 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator