Subject: bug#56213: closed (Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 25 Jun 2022 20:27:01 +0000

Your bug report

#56213: [PATCH] gnu: Add maven-doxia-core

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
56213: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56213
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core
From: Julien Lepiller <[email-masked]>
To: "Artyom V. Poptsov" <[email-masked]>
Cc: [email-masked]
Date: Sat, 25 Jun 2022 22:25:59 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Pushed to master as d039f9dc151eed8017a7f54682dbf713221b8005, thank you!

A few answers below:

Le Sat, 25 Jun 2022 15:14:58 +0300,
"Artyom V. Poptsov" <[email-masked]> a écrit :

> Hello Julien.
> 
> > Thanks for the patch!  
> 
> Thanks for taking your time for reviewing my patch.  :-)
> 
> > Missing full stop at the end of the subject line.  
> 
> Okay, added a full-stop.
> 
> FWIW, I'm usually following those rules when writing commit messages:
>   https://cbea.ms/git-commit/#end
> 
> The rules explicitly say that a committer should not add a full-stop
> at the end of the first line.

We follow our own rules that mandate a full stop. I thought I could
send you to the manual, but apart a vague mention of the ChangeLog
format, I can't find the rules. Have we always applied such strict
rules without writing them down properly?

> 
> However, 'guix lint' gave me the following warning:
> --8<---------------cut here---------------start------------->8---
> /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2:
> [email-masked]: propagated inputs [email-masked]
> and [email-masked] collide --8<---------------cut
> here---------------end--------------->8---
> 
> I don't know yet how to properly fix that; probably the issue is that
> I made all the inputs propagated, but I don't see how to differentiate
> them looking at the Doxia Core 'pom.xml'.

You can ignore these issues about parent poms. There's no real
collision except for the package name. No files in common between the
two packages, so that's fine. Nothing we can do anyway.

Subject: [PATCH] gnu: Add maven-doxia-core
From: "Artyom V. Poptsov" <[email-masked]>
To: [email-masked]
Date: Sat, 25 Jun 2022 13:26:09 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

this patch adds "Maven Doxia Core" under the name 'maven-doxia-core'.

From 4e06642ac47d0b69fb5aeb5e8b21efaacbc7ed67 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <[email-masked]>
Date: Sat, 25 Jun 2022 13:20:02 +0300
Subject: [PATCH] gnu: Add maven-doxia-core

* gnu/packages/maven.scm (maven-doxia-core): New variable.
---
 gnu/packages/maven.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm
index e5831ee614..95de84e845 100644
--- a/gnu/packages/maven.scm
+++ b/gnu/packages/maven.scm
@@ -3921,6 +3921,32 @@ encapsulate common text syntax.  A start tag is denoted by @code{xxxx()}
 method and a end of tag by @code{xxxx_()} method.")
     (license license:asl2.0)))
 
+(define-public maven-doxia-core
+  (package
+    (inherit maven-doxia-sink-api)
+    (name "maven-doxia-core")
+    (arguments
+     `(#:jar-name "doxia-core.jar"
+       #:source-dir "doxia-core/src/main/java"
+       #:tests? #f ;no tests
+       #:phases (modify-phases %standard-phases
+                  (replace 'install
+                    (install-from-pom "doxia-core/pom.xml")))))
+    (inputs (list maven-doxia-sink-api
+                  java-slf4j-api
+                  java-javax-inject
+                  java-plexus-utils
+                  java-eclipse-sisu-plexus
+                  java-commons-text))
+    (home-page "https://maven.apache.org/doxia/index.html")
+    (synopsis "Doxia core classes and interfaces")
+    (description
+     "Doxia is a content generation framework that provides powerful
+techniques for generating static and dynamic content, supporting a variety of
+markup languages.")
+    (license license:asl2.0)))
+
+
 (define maven-doxia-parent-pom
   (package
     (inherit maven-doxia-sink-api)
-- 
2.25.1

Thanks,

- Artyom

-- 
Artyom "avp" Poptsov <[email-masked]>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F