GNU bug report logs - #56210
29.0.50; Keyboard macros do not trigger after-change-functions

Previous Next

Package: emacs;

Reported by: Richard Hansen <rhansen <at> rhansen.org>

Date: Sat, 25 Jun 2022 06:23:02 UTC

Severity: normal

Found in version 29.0.50

Done: Richard Hansen <rhansen <at> rhansen.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56210 <at> debbugs.gnu.org, Richard Hansen <rhansen <at> rhansen.org>
Subject: bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions
Date: Tue, 28 Jun 2022 13:31:23 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> I thought I had a `(should (null inhibit-modification-hooks))` at
>> some point in the past to rule that out, but I must not have had
>> that inside the `with-current-buffer-window'.
>> 
>> Perhaps the documentation should be updated to indicate that the
>> modification hooks are inhibited?  I can cook up a patch.
>
> Is it really a good idea?  In general, all the 'with-SOMETHING' macros
> are likely to inhibit modification hooks, since they erase the
> temporary buffers high and low.

It's really surprising that with-current-buffer-window does this -- it
sounds like a general variation on with-selected-window, but it's not:
It's meant to be used to pop up help buffers, and this should be
documented.

with-current-buffer/with-selected-window etc do not inhibit any hooks in
the buffers them handle.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 2 years and 329 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.