GNU bug report logs - #56197
lisp-fill-paragraph behavior changed in Emacs 28

Previous Next

Package: emacs;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 24 Jun 2022 16:18:01 UTC

Severity: normal

Tags: patch

Found in version 28.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #143 received at 56197 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: larsi <at> gnus.org, 56197 <at> debbugs.gnu.org, felix.lechner <at> lease-up.com,
 stefankangas <at> gmail.com
Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed'
 variable.
Date: Sun, 26 Jan 2025 17:02:25 +0200
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Cc: Felix Lechner <felix.lechner <at> lease-up.com>,  56197 <at> debbugs.gnu.org,
>   larsi <at> gnus.org,  stefankangas <at> gmail.com
> Date: Sun, 26 Jan 2025 23:40:06 +0900
> 
> Hi Eli,
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Felix Lechner <felix.lechner <at> lease-up.com>
> [...]
> 
> >> Thanks, but the name is terrible.  The name fill-paragraph-as-displayed
> >> is the standard behavior.  It would be better to invert the logic and
> >> call it fill-strings-instead-of-paragraphs.
> >
> > I'm okay with looking for a better name, but
> > fill-strings-instead-of-paragraphs doesn't sound like a better one
> > (and "terrible" is an exaggeration, IMO).  How about
> > fill-paragraph-as-doc-string, by default t?
> 
> That's not a bad name, but my code simply avoids narrowing to strings,
> it preserves the special handling for doc strings such as filling the
> first sentence separately to the second one, so it wouldn't be accurate
> in the current version.  We could also turn this special handling off
> (which would also be welcome in my use case), then your suggested naming
> would make sense.

Sorry, I don't follow.  The behavior introduced in Emacs 28 was to
fill the paragraph as if it were a doc string, treating the first line
specially.  Setting the new variable you added disables that.  That is
why I said the variable should be t by default; disabling the new
behavior would then mean resetting it to nil.

So what am I missing?




This bug report was last modified 158 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.