GNU bug report logs - #56197
lisp-fill-paragraph behavior changed in Emacs 28

Previous Next

Package: emacs;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 24 Jun 2022 16:18:01 UTC

Severity: normal

Tags: patch

Found in version 28.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, 56197 <at> debbugs.gnu.org, felix.lechner <at> lease-up.com, stefankangas <at> gmail.com
Subject: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28
Date: Sun, 19 Jan 2025 21:35:44 +0900
Hello Eli,

Eli Zaretskii <eliz <at> gnu.org> writes:

[...]

>> > Thanks.  But this is not a user-level problem, so the variable to
>> > control this should IMO be a defvar, not a defcustom.  Then Lisp
>> > programs which need to get back old behavior for some reason could
>> > bind the variable around the call.
>> 
>> I'm not sure.  A user (such as myself) may prefer the old behavior, and
>> customize lisp-fill-paragraph-as-displayed (setting it to t) so that
>> this behavior is now the default everywhere.  It also makes it
>> more easily discoverable.  So unless you see a strong reason against
>> using defcustom, it seems preferable to me than defvar.
>
> Users can also set a defvar, if they want this globally.  However, the
> original problem is not a global one, it is specific to some
> situations in some particular major mode.
>
> The important question here is: how common is the situation where a
> user will prefer to set that globally?  I think this could only happen
> if the user uses a major mode of just one variant of Lisp-like
> languages, and especially if that one variant is not Emacs Lisp.

Good point.  The current behavior is probably useful when editing Emacs
Lisp, so I agree that setting this precisely for specific modes (such as
scheme-mode) instead probably makes more sense.

> In addition, making it a defcustom means Lisp programs cannot easily
> bind it to specific values when they need it (overriding user options
> is considered unclean in Emacs).
>
> So my preference is to introduce a defvar, and only promote it to a
> user option if we have enough demand in the future.

OK!  I'll send a reworked version using defvar shortly.  Thanks for the
thoughtful discussion!

-- 
Maxim




This bug report was last modified 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.