From unknown Sat Jun 21 10:42:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56197 <56197@debbugs.gnu.org> To: bug#56197 <56197@debbugs.gnu.org> Subject: Status: lisp-fill-paragraph behavior changed in Emacs 28 Reply-To: bug#56197 <56197@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:42:17 +0000 retitle 56197 lisp-fill-paragraph behavior changed in Emacs 28 reassign 56197 emacs submitter 56197 Maxim Cournoyer severity 56197 normal tag 56197 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 24 12:17:58 2022 Received: (at submit) by debbugs.gnu.org; 24 Jun 2022 16:17:58 +0000 Received: from localhost ([127.0.0.1]:43311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4m0L-0002cb-4m for submit@debbugs.gnu.org; Fri, 24 Jun 2022 12:17:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:42578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4m0I-0002cT-33 for submit@debbugs.gnu.org; Fri, 24 Jun 2022 12:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4m0H-0006bm-FG for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 12:17:53 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]:40734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4m0D-0006OZ-KE for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 12:17:53 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id cu16so5251798qvb.7 for ; Fri, 24 Jun 2022 09:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=8iaK3OfVYA+m/a27JV/Or7b0XxohQ194jyRPI7vxMp4=; b=JLVGpABzUSbc+RuQwjcbW5+urvXjsrwo8chic7ytR2uCeOHCD/xVckmktJlpeXg8tp l32m4ek1dmhHQ9UDH0dn9YO4cjtWN7L6ErcnbxBMo7boTw/o160sUtr5AuBlAmDCP8Uq ukcDqYDw8mamSdm2dIf2HttBEAqEtOISQHY7hCve9PeXECU5lqQzlljyB41gyzPkh0uM KER/LqkiViWiqg2+0D/xinzEy37PT3NKaYRhfMLM6dl6zptaoZmQu8my0BOxd6B+bVxk cKQVN2tgh9vb+Ta3wwagvXqpnZ1Mu4EB+UWa/4FFtpyDM3euSEjFs7B/elTleR2tUopd dzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=8iaK3OfVYA+m/a27JV/Or7b0XxohQ194jyRPI7vxMp4=; b=70DSqSQlGo5/Sbrs9vR/q/7rr5V4yrt86UYCE8PxOeHmUHpd/+0nA7xvrmMddIDKg9 EgNeU1dn+46r0lDKJRsWNrxJisjQI7N4Db+E4jdoXizD9P0KoJH2VwtnxT0/6HsT6xN+ p7RmPyYQwRzRHneqasgOE+WbHliMllQHPyEg7dzdeDLzgHCh91xQM7YPP5wvUznV/bCv NkyQGvmsYbUpygDyVssx+F1g3wGmgsqgpGT4w3H7cjK9U9AIUiqB+Gh2lvLQVy501Vlu 0RHGTlV7QZ9M7KzaEc+2RZ+24V0wN8CZN81xN5n5P6BS/fNDELg8dS/qMPAv0GEBLJi1 4vMQ== X-Gm-Message-State: AJIora81EIBgpkXPo9dTsjH4RMRK12aZZ5APKG3M4p8Y7VUiihpG3e96 i07DI9rFM3nQ337yp6v4tnLtXxm6JcC0cHNigBo= X-Google-Smtp-Source: AGRyM1ta/FC3pJrdmCJSwBnb9Im0UcFVDwlmF5CSKX2mQNBrXVYq3Hmke1YGYfHnDhZg5807xYYjVw== X-Received: by 2002:a05:622a:104c:b0:317:77a8:a74 with SMTP id f12-20020a05622a104c00b0031777a80a74mr8345678qte.209.1656087467062; Fri, 24 Jun 2022 09:17:47 -0700 (PDT) Received: from hurd (dsl-158-129.b2b2c.ca. [66.158.158.129]) by smtp.gmail.com with ESMTPSA id bl5-20020a05620a1a8500b006a6c9e17088sm2116623qkb.65.2022.06.24.09.17.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 09:17:46 -0700 (PDT) From: Maxim Cournoyer To: bug-gnu-emacs@gnu.org Subject: 28.1; lisp-fill-paragraph result regressed with Emacs 28 Date: Fri, 24 Jun 2022 12:17:45 -0400 Message-ID: <87zgi2xcgm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, After updating from Emacs 27 to Emacs 28 via GNU Guix, I noticed the following change in behavior while attempting to indent a blob of text in a Guix package definition (Scheme source): ;; Emacs 27 (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy Japanese language input method to IBus. Because most graphical applications allow text input via IBus, installing this package will enable Japanese language input in most graphical applications.") ;; Emacs 28 (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy Japanese language input method to IBus. Because most graphical applications allow text input via IBus, installing this package will enable Japanese language input in most graphical applications.") I traced it down to commit 9bf367e1848: Improve filling of Emacs Lisp doc strings * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph): When filling a Lisp string, try to avoid filling bits that follow it (bug#28937). Simply commenting out the newly added block, evaluating the defun and running it on my example reverts to the previous correct behavior. Thanks, Maxim --- In GNU Emacs 28.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) Windowing system distributor 'The X.Org Foundation', version 11.0.12101002 System Description: Guix System Configured using: 'configure CONFIG_SHELL=/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash SHELL=/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash --prefix=/gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1 --enable-fast-install --with-modules --with-cairo --disable-build-details' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: /home/maxim/.guix-profile/share/emacs/site-lisp:/gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Debbugs Minor modes in effect: TeX-PDF-mode: t global-git-commit-mode: t magit-auto-revert-mode: t pyvenv-mode: t shell-dirtrack-mode: t yas-global-mode: t yas-minor-mode: t emms-mode-line-mode: t emms-playing-time-display-mode: t emms-playing-time-mode: t ws-butler-global-mode: t ws-butler-mode: t counsel-mode: t ivy-mode: t global-so-long-mode: t recentf-mode: t global-company-mode: t company-mode: t electric-pair-mode: t savehist-mode: t winner-mode: t display-time-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: ~/.emacs.d/elisp/logview hides /gnu/store/bcbypx424n5xa6xlzlgz6zb3p6acpdcw-emacs-logview-0.14/share/emacs/site-lisp/logview-0.14/logview /gnu/store/wy0d51sns5ivqqxrrcrw5ycg4qqdjcza-emacs-transient-0.3.7/share/emacs/site-lisp/transient-0.3.7/transient hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/transient /gnu/store/r8vl0prsvj60c341il66ncavg0mvh9wc-emacs-xref-1.4.1/share/emacs/site-lisp/xref-1.4.1/xref hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/progmodes/xref /gnu/store/3nqi6i7lhwd972y9w3xvswjz01v346gp-emacs-project-0.8.1/share/emacs/site-lisp/project-0.8.1/project hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/progmodes/project /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-texinfo hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-texinfo /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-publish hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-publish /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-org hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-org /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-odt hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-odt /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-md hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-md /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-man hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-man /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-latex hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-latex /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-koma-letter hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-koma-letter /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-icalendar hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-icalendar /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-html hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-html /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-beamer hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-beamer /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ox-ascii hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ox-ascii /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-timer hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-timer /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-table hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-table /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-src hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-src /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-refile hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-refile /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-protocol hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-protocol /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-plot hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-plot /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-pcomplete hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-pcomplete /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-num hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-num /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-mouse hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-mouse /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-mobile hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-mobile /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-macs hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-macs /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-macro hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-macro /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-loaddefs hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-loaddefs /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-list hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-list /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-lint hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-lint /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-keys hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-keys /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-inlinetask hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-inlinetask /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-indent hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-indent /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-id hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-id /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-habit hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-habit /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-footnote hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-footnote /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-goto hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-goto /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-feed hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-feed /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-faces hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-faces /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-entities hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-entities /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-element hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-element /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-duration hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-duration /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-ctags hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-ctags /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-compat hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-compat /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-colview hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-colview /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-clock hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-clock /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-capture hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-capture /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-attach hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-attach /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-archive hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-archive /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-agenda hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-agenda /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-bibtex hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-bibtex /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-bbdb hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-bbdb /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/oc hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/oc /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/oc-csl hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/oc-csl /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/oc-basic hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/oc-basic /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-tangle hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-tangle /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-sql hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-sql /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-shell hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-shell /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-ruby hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-ruby /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-python hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-python /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-octave hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-octave /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-lua hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-lua /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-lilypond hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-lilypond /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-julia hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-julia /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-java hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-java /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-haskell hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-haskell /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-gnuplot hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-gnuplot /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-exp hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-exp /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-core hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-core /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-comint hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-comint /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-R hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-R /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-C hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-C /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-tempo hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-tempo /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-version hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-version /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-install hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-install /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-datetree hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-datetree /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-crypt hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-crypt /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/org-attach-git hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/org-attach-git /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-w3m hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-w3m /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-rmail hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-rmail /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-mhe hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-mhe /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-man hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-man /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-irc hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-irc /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-info hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-info /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-gnus hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-gnus /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-eww hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-eww /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-eshell hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-eshell /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-doi hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-doi /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ol-docview hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ol-docview /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/oc-natbib hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/oc-natbib /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/oc-biblatex hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/oc-biblatex /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-table hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-table /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-sqlite hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-sqlite /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-screen hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-screen /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-sed hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-sed /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-scheme hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-scheme /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-sass hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-sass /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-ref hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-ref /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-processing hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-processing /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-plantuml hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-plantuml /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-perl hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-perl /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-org hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-org /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-ocaml hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-ocaml /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-maxima hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-maxima /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-matlab hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-matlab /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-makefile hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-makefile /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-lob hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-lob /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-lisp hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-lisp /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-latex hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-latex /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-js hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-js /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-groovy hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-groovy /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-fortran hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-fortran /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-forth hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-forth /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-eval hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-eval /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-eshell hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-eshell /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-dot hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-dot /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-emacs-lisp hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-emacs-lisp /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-ditaa hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-ditaa /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-css hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-css /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-clojure hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-clojure /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-calc hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-calc /gnu/store/fw7xksf83zqxpsvpxmq1li3sc1qiwfsq-emacs-org-9.5.3/share/emacs/site-lisp/org-9.5.3/ob-awk hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/org/ob-awk /gnu/store/rpih6axr0g2sv1yz2q7gjby4df82wb47-emacs-soap-client-3.2.1/share/emacs/site-lisp/soap-client-3.2.1/soap-inspect hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/net/soap-inspect /gnu/store/rpih6axr0g2sv1yz2q7gjby4df82wb47-emacs-soap-client-3.2.1/share/emacs/site-lisp/soap-client-3.2.1/soap-client hides /gnu/store/q6x17s6zcgv52sdz3gh69b7g0d9712z8-emacs-28.1/share/emacs/28.1/lisp/net/soap-client Features: (shadow emacsbug whitespace elp edebug backtrace apropos gnus-kill perl-mode tramp-archive tramp-gvfs rst robot-mode align rect json-mode json-snatcher pulse nroff-mode markdown-mode php-mode mode-local cc-langs php-face php php-project projectile lisp-mnt ibuf-ext ibuffer ibuffer-loaddefs find-dired rng-cmpct rng-nxml rng-valid nxml-mode nxml-outln nxml-rap cus-start cl-print shortdoc nix-mode nix-repl nix-shell nix-store nix-instantiate nix-shebang nix-format nix log-view vc-annotate woman man novice font-latex plain-tex tex-buf latex latex-flymake tex-ispell tex-style tex-mode latexenc logview datetime extmap conf-mode time-stamp dabbrev sh-script executable ggtags mhtml-mode css-mode smie js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode facemenu tramp-cache tramp-adb arc-mode archive-mode magit-patch magit-subtree magit-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util guix-build-log guix-scheme tex-info tex texmathp texinfo texinfo-loaddefs nndoc gnus-dup url-cache git-rebase bash-completion magit-gitignore autoconf autoconf-mode cal-move make-mode vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs goto-addr bug-reference vc-git magit-extras copyright face-remap magit-bookmark magit-submodule magit-obsolete magit-popup magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit pcvs-util magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor magit-mode magit-git magit-section magit-utils dired-aux gnus-dired misearch multi-isearch flow-fill guix-devel edit-indirect guix-misc guix-ui guix-ui-messages bui bui-list bui-info bui-entry bui-core bui-history bui-button guix-read guix-help-vars guix-repl guix-profiles guix-external guix-config guix-build-config guix-geiser geiser-mode geiser-xref guix-guile geiser-guile info-look info geiser geiser-repl geiser-compile geiser-debug transient geiser-image geiser-company geiser-doc geiser-menu geiser-edit geiser-completion geiser-autodoc geiser-eval geiser-connection geiser-syntax geiser-impl geiser-log geiser-popup view geiser-custom geiser-base guix-utils guix bui-utils dash scheme ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe ol-docview ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi mule-util smtpmail mailalias sendmail bbdb-com crm bbdb bbdb-site smiley gnus-cite mm-archive mail-extr gnus-async gnus-bcklg qp gnus-ml disp-table nndraft nnmh utf-7 epa-file gnutls network-stream nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig nntp gnus-cache gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs mail-utils bookmark server paredit diff-hl vc-dir ewoc vc vc-dispatcher flyspell ispell company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-cmake company-xcode company-clang company-semantic company-eclim company-template company-bbdb htmlize ox-reveal ox-odt rng-loc rng-uri rng-parse rng-match rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda org-refile ox-html table ox-ascii ox-publish ox org-element avl-tree dired-x w3m doc-view jka-compr image-mode exif timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util highlight-indentation flymake-proc flymake company-capf help-fns radix-tree elpy elpy-rpc pyvenv eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util elpy-shell elpy-profile elpy-django s elpy-refactor diff-mode python tramp-sh tramp tramp-loaddefs trampver tramp-integration tramp-compat shell parse-time ls-lisp ido hideshow files-x etags fileloop generator cus-edit pp yasnippet-snippets yasnippet ffap debbugs-gnu add-log debbugs-compat debbugs soap-client mm-decode mm-bodies mm-encode url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm rmc puny warnings rng-xsd rng-dt rng-util xsd-regexp emms-librefm-stream xml emms-librefm-scrobbler emms-playlist-limit emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-volume emms-volume-sndioctl emms-volume-mixerctl emms-volume-pulse emms-volume-amixer emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-lyrics emms-url emms-streams emms-show-all emms-tag-editor emms-tag-tracktag emms-mode-line emms-cache emms-info-native bindat emms-info-exiftool emms-info-tinytag emms-info-opusinfo emms-info-ogginfo emms-info-mp3info emms-player-vlc emms-player-mpv emms-playing-time emms-player-mplayer emms-player-simple emms-playlist-mode emms-source-playlist emms-source-file thingatpt locate emms-mark emms-setup emms-info-metaflac emms-info emms-later-do emms emms-compat cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs appt diary-lib diary-loaddefs string-inflection org-clock org-tempo org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol org-keys oc org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs tempo ws-butler epa derived epg rfc6068 epg-config grep-a-lot grep counsel xdg advice xref project dired dired-loaddefs compile text-property-search comint ansi-color swiper cl-extra help-mode ivy delsel ivy-faces ivy-overlay colir color easy-mmode robot-log-autoloads robot-log so-long recentf tree-widget wid-edit company edmacro kmacro pcase elec-pair savehist winner ring time cus-load feature-mode-autoloads clang-rename-autoloads clang-format-autoloads markup-faces-autoloads adoc-mode-autoloads yasnippet-snippets-autoloads yaml-mode-autoloads ws-butler-autoloads w3m-load string-inflection-autoloads sr-speedbar-autoloads rust-mode-autoloads rpm-spec-mode-autoloads robot-mode-autoloads loc-changes-autoloads load-relative-autoloads realgud-autoloads realgud-recursive-autoloads qml-mode-autoloads tablist-autoloads pdf-tools-autoloads epl-autoloads pkg-info-autoloads projectile-autoloads php-mode-autoloads paredit-autoloads org-reveal-autoloads org-autoloads mmm-mode-autoloads json-snatcher-autoloads json-mode-autoloads nix-mode-autoloads markdown-mode-autoloads async-autoloads with-editor-autoloads magit-autoloads extmap-autoloads datetime-autoloads logview-autoloads jenkinsfile-mode-autoloads htmlize-autoloads magit-popup-autoloads geiser-guile-autoloads transient-autoloads xref-autoloads project-autoloads geiser-autoloads edit-indirect-autoloads bui-autoloads guix-autoloads rx dash-autoloads groovy-modes-autoloads grep-a-lot-autoloads go-mode-autoloads xpm-autoloads ascii-art-to-unicode-autoloads gnugo-autoloads ggtags-autoloads emms-autoloads s-autoloads pyvenv-autoloads yasnippet-autoloads highlight-indentation-autoloads find-file-in-project-autoloads elpy-autoloads el-mock-autoloads diff-hl-autoloads soap-client-autoloads debbugs-autoloads csv-mode-autoloads counsel-bbdb-autoloads hydra-autoloads ivy-autoloads swiper-autoloads counsel-autoloads pos-tip-autoloads company-quickhelp-autoloads company-autoloads cmake-mode-autoloads bbdb-autoloads bash-completion-autoloads auctex-autoloads tex-site guix-emacs package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 5047295 585780) (symbols 48 76444 4) (strings 32 532649 231222) (string-bytes 1 19695544) (vectors 16 216067) (vector-slots 8 3662568 496790) (floats 8 6626 1776) (intervals 56 446059 14706) (buffers 992 580)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 07:53:55 2022 Received: (at 56197) by debbugs.gnu.org; 25 Jun 2022 11:53:56 +0000 Received: from localhost ([127.0.0.1]:44262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54MN-0006Ga-PH for submit@debbugs.gnu.org; Sat, 25 Jun 2022 07:53:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54MM-0006GO-O5 for 56197@debbugs.gnu.org; Sat, 25 Jun 2022 07:53:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4jd1WSrp3ebMQ3lppbWIKiNQpl93vGG5ycPQr5rthsw=; b=RYpNaErqoDjWM8l5tfntRu7VNT kmskIReXcAWshmO0raI8Xok2ifD1+I2Iz0g/teLxemTz1Ky52jxpszrgArgYW9cq3q3ufGHSDonRH 42WGJv6IvITuIFCRw8ZRnXGzBdXcv+NX/E5Iqt+mn+DDQ1wPQ/PNwDIz98/Odpi7gwqM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o54ME-0005OK-7t; Sat, 25 Jun 2022 13:53:48 +0200 From: Lars Ingebrigtsen To: Maxim Cournoyer Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> X-Now-Playing: RP Boo's _Planet Mu 25_: "Finally Here (ft. Afiya)" Date: Sat, 25 Jun 2022 13:53:44 +0200 In-Reply-To: <87zgi2xcgm.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 24 Jun 2022 12:17:45 -0400") Message-ID: <87y1xlj6wn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Maxim Cournoyer writes: > ; ; Emacs 28 > (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy > Japanese language input method to IBus. Because most graphical applications > allow text input vi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer writes: > ;; Emacs 28 > (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy > Japanese language input method to IBus. Because most graphical applications > allow text input via IBus, installing this package will enable Japanese > language input in most graphical applications.") [...] > Simply commenting out the newly added block, evaluating the defun and > running it on my example reverts to the previous correct behavior. I'm not sure the previous behaviour was any more correct. It's now filling that string as if it, well, is a string, so that if you insert it somewhere, the lines have similar lengths. The previous behaviour was to fill "what you see in the buffer", which is wrong in most contexts. So I don't know. Anybody have an opinion? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 08:43:14 2022 Received: (at 56197) by debbugs.gnu.org; 25 Jun 2022 12:43:14 +0000 Received: from localhost ([127.0.0.1]:44359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5582-0001G7-OK for submit@debbugs.gnu.org; Sat, 25 Jun 2022 08:43:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o557z-0001Ft-VE for 56197@debbugs.gnu.org; Sat, 25 Jun 2022 08:43:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o557u-0007a1-GB; Sat, 25 Jun 2022 08:43:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=foe9qXx3RrlO3DQcGelgjGJi+lvGwX22RLfEGCwM08I=; b=o4ncKDIp2Lk2 UNXKgqfMTEBjR1TQB4cyATmJZHJJTm8dylWq+eHW4efe9g6hfOL5pIHxcdabrmHNk1u6LR9ZeMkrU AyzqvhS5K/KmHu8U7HA4b1Mo4Nx9NiG9Jc0SovSjSClcke2b55jTgiZF29i01jUAWasCUacoId6eI PqIcrKu2XFWvfYYrVbTKIjpQ3Pb/aIewvuWrP/2Wvky40BCAmsCWW2nVbmkvH23O4a1cVx9HyCFw2 Inq41YSZE0snogPeoMSrVWff1J4bNYcHz0kqs2nRd+oHC2DWQ39VLlAGFStUcCeEGBHiKRMEV+GGJ bBTsS0EUBe/S4uPIQEJ/ow==; Received: from [87.69.77.57] (port=1906 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o557t-00057T-Tw; Sat, 25 Jun 2022 08:43:02 -0400 Date: Sat, 25 Jun 2022 15:42:57 +0300 Message-Id: <834k08c3se.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87y1xlj6wn.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 25 Jun 2022 13:53:44 +0200) Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 56197@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Sat, 25 Jun 2022 13:53:44 +0200 > > Maxim Cournoyer writes: > > > ;; Emacs 28 > > (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy > > Japanese language input method to IBus. Because most graphical applications > > allow text input via IBus, installing this package will enable Japanese > > language input in most graphical applications.") > > [...] > > > Simply commenting out the newly added block, evaluating the defun and > > running it on my example reverts to the previous correct behavior. > > I'm not sure the previous behaviour was any more correct. It's now > filling that string as if it, well, is a string, so that if you insert > it somewhere, the lines have similar lengths. The previous behaviour > was to fill "what you see in the buffer", which is wrong in most > contexts. > > So I don't know. Anybody have an opinion? I actually don't understand what kind of "Lisp code" is the above snippet. It doesn't look to me as valid Lisp code. So there's no criteria for judging the correctness here, it seems. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 08:45:35 2022 Received: (at 56197) by debbugs.gnu.org; 25 Jun 2022 12:45:35 +0000 Received: from localhost ([127.0.0.1]:44373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55AN-0001KW-1g for submit@debbugs.gnu.org; Sat, 25 Jun 2022 08:45:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55AK-0001KI-2f for 56197@debbugs.gnu.org; Sat, 25 Jun 2022 08:45:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NNjR4kdjF6TJAuCeQ97ktnfEHgA0CjiYL97MmR9cy1U=; b=sy6Y3doq52qTpAvxo/84Nt3wKr o06MD7HeyhzHtMF1l33RAEiXB8Mih4lH2RxhyYYrXJnDU/kdIwiQ6CG71Zqu1jLGZf0MhTIBBHSIX SYSKA0oyYFC+8HExIm4AOE1IPZVfyrcT1ztJyyWnON1mH2z5dWuH8sI04jMrcYd82DdA=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o55AB-0005rG-30; Sat, 25 Jun 2022 14:45:25 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX09Nb7++Le3sFj Y1SKiXUGBgK4uJ8tLSVHRjt/f23///+3Y8xXAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YGGQwLGrkU Zl8AAAGvSURBVDjLdZRNT8JAEIZnkFSOu0B65kOCV4OaeKPCL6AMcFSM0SMayxk1Gn62M7Nttwvy HnbD+7DztW0BRAbBehlr0aoPXUR7IPVbyZGvAAcMsOqhLgZvkiCHZgGIujElYNdiXDyKO5l20QCc fwwpwdcF/8tkC15aRBsQQERJnxhAk+bGIhvvknrIYEQMAPsMoJ3lQE6w5gbrmawD/jELAPsChgrQ gzijCvAn0h86AGf7PZXi5CVg/ZwCgyqQ0DNjxK+1SrBwYAduuv3CTztazBYU4EV54M2N6ApkViCN 5dpAAViR90NQd97yCIBLPb8UYKoAXl0HvKX3Wu4OKmTeNC8cEALw4nqOeetAw4M8FLQPQJ8CwOXv quWmqIAf1nP61Ak28ua2Cu57vWfadqqAftvlBN4DQNd++iHwkhvsMUjdHL9pNWJNp9MHB1ZrBR8x bSovR6+xeqhlenuRTrdUfQwKrmpxCPgW3YnuwQmpzOWI+LHxpjQJRVXLr3+BxDMBcKGk8xKg2xTc xh4UXwYBvxDprQRgMhrd8vZ0N84j5Z8MyMfA73LRG8IJ2RM+2j+QnMAKWUIZ/wAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMi0wNi0yNVQxMjoxMToyNiswMDowMOOfOzQAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjItMDYtMjVUMTI6MTE6MjYrMDA6MDCSwoOIAAAAAElFTkSuQmCC X-Now-Playing: FARWARMTH's _Planet Mu 25_: "Shadows In The Air" Date: Sat, 25 Jun 2022 14:45:22 +0200 In-Reply-To: <834k08c3se.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jun 2022 15:42:57 +0300") Message-ID: <874k08kj31.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I actually don't understand what kind of "Lisp code" is the above > snippet. It doesn't look to me as valid Lisp code. So there's no > criteria for judging the correctness here, it seems. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I actually don't understand what kind of "Lisp code" is the above > snippet. It doesn't look to me as valid Lisp code. So there's no > criteria for judging the correctness here, it seems. It's just (foo "... very long multiline string"). I was also confused, because the string looked very odd -- it has a ) inside the string, but no (, but that's not really relevant. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 08:49:08 2022 Received: (at 56197) by debbugs.gnu.org; 25 Jun 2022 12:49:08 +0000 Received: from localhost ([127.0.0.1]:44382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55Do-0001SO-LD for submit@debbugs.gnu.org; Sat, 25 Jun 2022 08:49:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55Dm-0001Rr-MC for 56197@debbugs.gnu.org; Sat, 25 Jun 2022 08:49:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gbyrefv8iWzHcfhPgtCZEePVdr6QD3+pjl3unR+lnZA=; b=YrFEStvgk4N8LhNeqYQ5/UqxWm GDECuXzDgV1Cnm6IH4q4p3oYUc96UQnBPX4DDWnaVL1WcJ0AaT4sXjpvFWBnQZYfjF5SRlZ9sXZAw wQMQj/x4ibmIKEFKA/C5r0OlRvxtTLgwgw7B2CibNgtwamOQj/vl1kJnMzb4cUb5QD5A=; Received: from 77.19.134.30.tmi.telenormobil.no ([77.19.134.30] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o55Dd-0005sU-97; Sat, 25 Jun 2022 14:48:59 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <874k08kj31.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 25 Jun 2022 14:45:22 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX09Nb7++Le3sFj Y1SKiXUGBgK4uJ8tLSVHRjt/f23///+3Y8xXAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YGGQwLGrkU Zl8AAAGvSURBVDjLdZRNT8JAEIZnkFSOu0B65kOCV4OaeKPCL6AMcFSM0SMayxk1Gn62M7Nttwvy HnbD+7DztW0BRAbBehlr0aoPXUR7IPVbyZGvAAcMsOqhLgZvkiCHZgGIujElYNdiXDyKO5l20QCc fwwpwdcF/8tkC15aRBsQQERJnxhAk+bGIhvvknrIYEQMAPsMoJ3lQE6w5gbrmawD/jELAPsChgrQ gzijCvAn0h86AGf7PZXi5CVg/ZwCgyqQ0DNjxK+1SrBwYAduuv3CTztazBYU4EV54M2N6ApkViCN 5dpAAViR90NQd97yCIBLPb8UYKoAXl0HvKX3Wu4OKmTeNC8cEALw4nqOeetAw4M8FLQPQJ8CwOXv quWmqIAf1nP61Ak28ua2Cu57vWfadqqAftvlBN4DQNd++iHwkhvsMUjdHL9pNWJNp9MHB1ZrBR8x bSovR6+xeqhlenuRTrdUfQwKrmpxCPgW3YnuwQmpzOWI+LHxpjQJRVXLr3+BxDMBcKGk8xKg2xTc xh4UXwYBvxDprQRgMhrd8vZ0N84j5Z8MyMfA73LRG8IJ2RM+2j+QnMAKWUIZ/wAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMi0wNi0yNVQxMjoxMToyNiswMDowMOOfOzQAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjItMDYtMjVUMTI6MTE6MjYrMDA6MDCSwoOIAAAAAElFTkSuQmCC X-Now-Playing: Meemo Comma's _Planet Mu 25_: "Tif'eret" Date: Sat, 25 Jun 2022 14:48:55 +0200 Message-ID: <87y1xkj4co.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > It's just (foo "... very long multiline string"). I was also confused, > because the string looked very odd -- it has a ) inside the string, but > no (, but that's not really relevant. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > It's just (foo "... very long multiline string"). I was also confused, > because the string looked very odd -- it has a ) inside the string, but > no (, but that's not really relevant. Oh, hang on -- there definitely is a bug here. Here's a better test case: (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very long line This is a very long line This is a very long line. And another long line.") `M-q' in the first line does nothing, and it should. I'll have a look. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 09:00:42 2022 Received: (at 56197) by debbugs.gnu.org; 25 Jun 2022 13:00:42 +0000 Received: from localhost ([127.0.0.1]:44395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55P0-0001kw-8m for submit@debbugs.gnu.org; Sat, 25 Jun 2022 09:00:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o55Oy-0001kg-7E for 56197@debbugs.gnu.org; Sat, 25 Jun 2022 09:00:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4To53F913KdvwCu1NzkYjiZVsXO2EefRzgrCMoiRxb8=; b=R2NunlwKCsJUMj/JTzQBrs/zfK l9HYKKfW5G716gR4GmBuPvpCu17jWkWDPhIBqtPTR5QodxXZu6wFwGQcwDUomuZJQtGMiYMBeLHft gEnTk3KvwlCLMiJBKV2HqeAqHl0u1IbqhLpCkB5fJJygBXZQMmOdLPx95fM9i9cmvSB4=; Received: from [77.19.134.30] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o55On-00060k-PG; Sat, 25 Jun 2022 15:00:32 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> Date: Sat, 25 Jun 2022 15:00:28 +0200 In-Reply-To: <87y1xkj4co.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 25 Jun 2022 14:48:55 +0200") Message-ID: <87tu88j3tf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > `M-q' in the first line does nothing, and it should. I'll have a look. I've now fixed that, but the question still remains -- should Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > `M-q' in the first line does nothing, and it should. I'll have a look. I've now fixed that, but the question still remains -- should (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very long line This") be filled as (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very long line This") (i.e., fill the string using fill-column, or (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very long line This") (i.e., fill the text as is in the buffer). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 21:53:59 2022 Received: (at 56197) by debbugs.gnu.org; 27 Jun 2022 01:53:59 +0000 Received: from localhost ([127.0.0.1]:49335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5dws-0004OM-MX for submit@debbugs.gnu.org; Sun, 26 Jun 2022 21:53:58 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]:42529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5dwp-0004O8-Rc for 56197@debbugs.gnu.org; Sun, 26 Jun 2022 21:53:56 -0400 Received: by mail-qv1-f49.google.com with SMTP id 65so2253642qva.9 for <56197@debbugs.gnu.org>; Sun, 26 Jun 2022 18:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=F2WesjLoxRJzPq2gCaq4Ck3vjcRb3/TSyNbRyA/YuuI=; b=oDTQc5uDdLUNCADHuH5QZsx5VwGz5BU9i0uP+s7qwu0knIwMj+xG4p0uRoyLHeHl1M UIPoIGbScZ0hsKapMjEWi0jMc1jWogi4FTkd+TWvugnPQ5stCO0SfN4vLB5KnprcX12g 9KGdJIAS0qbeofVKv3om9u/e5Nu29ChG0ENK3Kpb2c1X/YeqbX6P8EAc2APwq4zvEJNV v3hYPAeibvnLConbjXFaIkd+VH3ztnMge1meApTV7NNbsvGEXhJfPGGxGLfa+IyFOOsa hEEW6DG+IwHWOWM+I6ByysJ2CrhBRR8Pgnlbec42sByjfHrNDt0WR/yzEIq8bNrqOnOh zlzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=F2WesjLoxRJzPq2gCaq4Ck3vjcRb3/TSyNbRyA/YuuI=; b=mle0vGPRccPpqzfJpvdstB1EsDU8Y38JSrYvW4pgfowTJtS3i+NFln1fCQn7VxN33L Ic2sUV1Zd7iFS+VSHYxKl6Vwm63hY4v2q+Ea8Q2/yHzgAKM1nyg5Mk9GHuw1UgDHVIvN ItztF5N8juJW+BPH/g80hboqmVQvCCQwCSlZqdFrgWbzuiOWb+JdbYnVPlu4b0c7a6fQ PleMiyu8p6dI92yZ1kvaVKKhwWT5eY5qwP1BJsw4eHBg//3ey8udlUM0A7qBq+CXfKoM ok45dcNTO0IzHxNPDCwoEL9CbTfETDXekWDWEEM+fGPEGsoSRX5rljOc46l7x7w0ueyF uS2w== X-Gm-Message-State: AJIora/zPqrL0cEIIEsmMrFRXM9c3Nmahh0XUvgrszOMFMWuwjTIIPyZ 5TjbuhC5lvqvmXfvUqXhr/HwMkUlyI8W6w== X-Google-Smtp-Source: AGRyM1vAUqEC+Tc2M8YscDua1CqOU+vBMJMIjASFJCAIDuzvkRakwnf3xH9kpVmmK/Ersarb3//5tQ== X-Received: by 2002:ac8:5a49:0:b0:317:a417:65b5 with SMTP id o9-20020ac85a49000000b00317a41765b5mr7537714qta.214.1656294829842; Sun, 26 Jun 2022 18:53:49 -0700 (PDT) Received: from hurd (dsl-148-140.b2b2c.ca. [66.158.148.140]) by smtp.gmail.com with ESMTPSA id v15-20020a05620a440f00b006a79aa0c8b1sm7921286qkp.113.2022.06.26.18.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 18:53:49 -0700 (PDT) From: Maxim Cournoyer To: Lars Ingebrigtsen Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> Date: Sun, 26 Jun 2022 21:53:48 -0400 In-Reply-To: <87y1xlj6wn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 25 Jun 2022 13:53:44 +0200") Message-ID: <874k06zxar.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Lars Ingebrigtsen writes: > Maxim Cournoyer writes: > >> ;; Emacs 28 >> (description "IBus-Anthy is an engine for the input bus \"IBus\"). It adds the Anthy >> Japanese language input method to IBus. Because most graphical applications >> allow text input via IBus, installing this package will enable Japanese >> language input in most graphical applications.") > > [...] > >> Simply commenting out the newly added block, evaluating the defun and >> running it on my example reverts to the previous correct behavior. > > I'm not sure the previous behaviour was any more correct. It's now > filling that string as if it, well, is a string, so that if you insert > it somewhere, the lines have similar lengths. The previous behaviour > was to fill "what you see in the buffer", which is wrong in most > contexts. > > So I don't know. Anybody have an opinion? Apologies if my previous example lacked too much context and confused more than helped. Here's another example, where I just experienced the problem after revamping the GNU Guix 'font-abattis-cantarrel' package definition: --8<---------------cut here---------------start------------->8--- (define-public font-abattis-cantarell (package (name "font-abattis-cantarell") (version "0.303") (source (origin (method git-fetch) (uri (git-reference (url "https://gitlab.gnome.org/GNOME/cantarell-fonts") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "1d1ay0fdqchk0wa5yqxis2c98imvzsbbd2kjv0x8sk4fm419847b")))) (build-system meson-build-system) (arguments (list #:configure-flags #~(list "-Dbuildstatics=true"))) (native-inputs (list gettext-minimal psautohint python python-cffsubr python-fontmath python-statmake python-ufo2ft)) (home-page "https://wiki.gnome.org/Projects/CantarellFonts") (synopsis "Cantarell sans-serif typeface") (description "The Cantarell font family is a contemporary Humanist sans-serif designed for on-screen reading. It is used by GNOME@tie{}3. This package contains both the non-variable as well as the variable versions of the font.") (license license:silofl1.1))) --8<---------------cut here---------------end--------------->8--- This is a Scheme sexp extracted from the (gnu packages fonts) Guile module. Hitting `lisp-fill-paragraph' (M-q) causes the above indentation, where the first line of the description extends past the `fill-column' value. I hope that helps, Thanks! Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 14:03:27 2022 Received: (at 56197) by debbugs.gnu.org; 29 Jun 2022 18:03:27 +0000 Received: from localhost ([127.0.0.1]:60167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6c23-0006lY-Fo for submit@debbugs.gnu.org; Wed, 29 Jun 2022 14:03:27 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:42717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6c21-0006lF-9M for 56197@debbugs.gnu.org; Wed, 29 Jun 2022 14:03:17 -0400 Received: by mail-pj1-f49.google.com with SMTP id 73-20020a17090a0fcf00b001eaee69f600so209088pjz.1 for <56197@debbugs.gnu.org>; Wed, 29 Jun 2022 11:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=nB5lyzhFGuBnUs+fK4VxLldkY91ij6fylkZAchLf91A=; b=HycgSP3wD1MtGPsGycH2XUfwewlOFXz2HHqNdlqf6ao8M0ivkXGKxZTFZcMtOpGgma AU4cnHzISoFKlUX2wBEDI6m4T71nVRie5T/Mx6V/jl8U/vTY9RYoWhu9aJLcfvh5W1q/ PL7k0mnX1ZUV8BRm+l9Y2c4fSdTWz8IYNRL/0WuVUeb+z69A3Snzhv1nDrPiN2eW5SMn 5tMdAJnHr/5ph9PejDfSSZvuLFG8PXXJU8cS4lZOQInobtuB0PK8WfmldOGanEgcnvvi ppYVadTmdhXQ4OPmtY6MKiVPZYrw0iqsI1XK8LqromZZoO9SxALRNzP294KCn8uI09Ix Og5g== X-Gm-Message-State: AJIora9qIIYjjDBqtw+b949waR8diosH8knIu8ycHlT80Q9j9EXeo97K SgrEamqRpni7L/cwOv0E5BQ9seMeACyYVNwxPpM= X-Google-Smtp-Source: AGRyM1u1A8UJA7Rb7VjSdVHQxZ4EIcvnOVuKOAKobPSZiBX5XsVa7x1kP6fA5dlPXHbqoEVgoxtFWj/wkLywC8+8Qw0= X-Received: by 2002:a17:90b:4cd0:b0:1ec:b260:db49 with SMTP id nd16-20020a17090b4cd000b001ecb260db49mr5131861pjb.193.1656525791452; Wed, 29 Jun 2022 11:03:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 29 Jun 2022 11:03:11 -0700 From: Stefan Kangas In-Reply-To: <87tu88j3tf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 25 Jun 2022 15:00:28 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 29 Jun 2022 11:03:11 -0700 Message-ID: Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 56197 Cc: Eli Zaretskii , 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > I've now fixed that, but the question still remains -- should > > (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very long line This") > > be filled as > > (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a very long line This is a very long line This is a very > long line This") > > (i.e., fill the string using fill-column, or > > (foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot-foo-bar-zot "This is a > very long line This is a very long line This is a very long line This") > > (i.e., fill the text as is in the buffer). The former sounds more useful, IMO. I don't want to mess up my strings just to have pretty source code; I can make such adjustments manually when I need to. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 05:32:21 2022 Received: (at 56197) by debbugs.gnu.org; 30 Jun 2022 09:32:21 +0000 Received: from localhost ([127.0.0.1]:32876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qX7-0001fa-DN for submit@debbugs.gnu.org; Thu, 30 Jun 2022 05:32:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qX5-0001Zz-Bg for 56197@debbugs.gnu.org; Thu, 30 Jun 2022 05:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a/jH/+PRnukmGa0lNnDKdX21hFSWQTaGJpA3t31CrRo=; b=Is6UHc9xjv2yF974AgyjgQdnQD gVxKalZJnNtdjYwmpHln5ZZQMn8zDUCgeKCr1ZrTO6ti6Z9QWcbxGKhSrPMhVtftHg7w8Ofv/Q5ui /8n11dS5qtSwliyuAMmFVvqOItP4aXnf4Dl4fgZRuz4oyVe2NjYr7b0PXzmH/utk2DqI=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6qWw-0001r3-Hn; Thu, 30 Jun 2022 11:32:13 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: (Stefan Kangas's message of "Wed, 29 Jun 2022 11:03:11 -0700") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXi39X09O9/fXoT FhkfIyYaHSGhop5UWF3////zlsy2AAAAAWJLR0QIht6VegAAAAd0SU1FB+YGHgkNILJe4jkAAAGO SURBVDjLdZO7bcQwDIbJJrV4RSa4CSIbHsDWBJL7MxBkgStu/fAnJflxCQsb0Ce+flJEIkK3YUmL WkrrWh5EJIECvgrclBQ9ZwUCuw1lWd0KgMBDTUOt3QpXQIHD5wWweei3guIA9wnJic4e/wE981B0 zYG7oh4S5BJKq0IBag5yA+rC3uDnaH0XfAa26xUMFaSyoA/EghtCFRdrtuTswMqtQOX1MCalJ8cx 8ls54i0ey+1A//wnaKEQfk0VBE2uzKqK45LieAxF4mDIMUYHPlqfh4LpGWN2DyZfBgfbdwcBwLRS MP3c5wbEgXnMXx+vOZ77sOTzSK/cgSlVq4qPO3JkAMKqoA/NkSeAPVSfIOaBxvMOGB5q0aTKV49m mcmz8BvwCWK7aqh1D6XScnjzEFusQ6g8VsCuSd9Eq7ZXRbjgYHoeQaiSHDx84TDcWlX12Mj2SoJc ADtog9rL3Rg9EMZLHZTRcwTxF9oAXnsDchJRCzure9XKRQzhrJXpTnijZxG3uj/SJfGHkzcL9Qvo IsmzFT370QAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNi0zMFQwOToxMzozMiswMDowMFi2hwQA AAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDYtMzBUMDk6MTM6MzIrMDA6MDAp6z+4AAAAAElFTkSu QmCC X-Now-Playing: Andrew Poppy's _Alphabed_: "Goodbye Mr G" Date: Thu, 30 Jun 2022 11:32:08 +0200 Message-ID: <87r136cx9j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > The former sounds more useful, IMO. I don't want to mess up my strings > just to have pretty source code; I can make such adjustments manually > when I need to. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: Eli Zaretskii , 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > The former sounds more useful, IMO. I don't want to mess up my strings > just to have pretty source code; I can make such adjustments manually > when I need to. So the votes are in, and I guess we'll keep the current behaviour in Emacs 29, and I'm therefore closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 05:33:35 2022 Received: (at 56197) by debbugs.gnu.org; 30 Jun 2022 09:33:35 +0000 Received: from localhost ([127.0.0.1]:32891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qYJ-0001v8-JK for submit@debbugs.gnu.org; Thu, 30 Jun 2022 05:33:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qYH-0001up-EB for 56197@debbugs.gnu.org; Thu, 30 Jun 2022 05:33:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sIfcLn63IH6SYJG1PgUXu1kCliUb2qwGxATJOeLcfwY=; b=elRJyfl4lr6gdy3gHMxUndp97X sCZw97QXCT3X+xgyIS4u+F5YIYlZJBR0FzJ01+qS3yfijt2NMg7HOLmg/DNckF4kAOIozN6evUMUK PC/6a96H2AvwUk8BAEGn3qnv3Zkg9NU60cqxBHG1xHMCCVLE0DaFggEBAypBYivmKTLo=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6qY9-0001rO-1b; Thu, 30 Jun 2022 11:33:27 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <87r136cx9j.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 30 Jun 2022 11:32:08 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXi39X09O9/fXoT FhkfIyYaHSGhop5UWF3////zlsy2AAAAAWJLR0QIht6VegAAAAd0SU1FB+YGHgkNILJe4jkAAAGO SURBVDjLdZO7bcQwDIbJJrV4RSa4CSIbHsDWBJL7MxBkgStu/fAnJflxCQsb0Ce+flJEIkK3YUmL WkrrWh5EJIECvgrclBQ9ZwUCuw1lWd0KgMBDTUOt3QpXQIHD5wWweei3guIA9wnJic4e/wE981B0 zYG7oh4S5BJKq0IBag5yA+rC3uDnaH0XfAa26xUMFaSyoA/EghtCFRdrtuTswMqtQOX1MCalJ8cx 8ls54i0ey+1A//wnaKEQfk0VBE2uzKqK45LieAxF4mDIMUYHPlqfh4LpGWN2DyZfBgfbdwcBwLRS MP3c5wbEgXnMXx+vOZ77sOTzSK/cgSlVq4qPO3JkAMKqoA/NkSeAPVSfIOaBxvMOGB5q0aTKV49m mcmz8BvwCWK7aqh1D6XScnjzEFusQ6g8VsCuSd9Eq7ZXRbjgYHoeQaiSHDx84TDcWlX12Mj2SoJc ADtog9rL3Rg9EMZLHZTRcwTxF9oAXnsDchJRCzure9XKRQzhrJXpTnijZxG3uj/SJfGHkzcL9Qvo IsmzFT370QAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNi0zMFQwOToxMzozMiswMDowMFi2hwQA AAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDYtMzBUMDk6MTM6MzIrMDA6MDAp6z+4AAAAAElFTkSu QmCC X-Now-Playing: Andrew Poppy's _Alphabed_: "Goodbye Mr G" Date: Thu, 30 Jun 2022 11:33:23 +0200 Message-ID: <87mtducx7g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > So the votes are in, and I guess we'll keep the current behaviour in > Emacs 29, and I'm therefore closing this bug report. Or -- perhaps it should be backported to Emacs 28 -- but not right now, since the release is impending. So I'll keep this open until after Emacs 28.2, I think. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: Eli Zaretskii , 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > So the votes are in, and I guess we'll keep the current behaviour in > Emacs 29, and I'm therefore closing this bug report. Or -- perhaps it should be backported to Emacs 28 -- but not right now, since the release is impending. So I'll keep this open until after Emacs 28.2, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 05:33:45 2022 Received: (at control) by debbugs.gnu.org; 30 Jun 2022 09:33:45 +0000 Received: from localhost ([127.0.0.1]:32894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qYS-0001vU-Qv for submit@debbugs.gnu.org; Thu, 30 Jun 2022 05:33:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qYQ-0001vG-BW for control@debbugs.gnu.org; Thu, 30 Jun 2022 05:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R5OtCsydcXe/3l0Rn8lIXcnOiX0pu4B3LPgGA340CTg=; b=RXJtb+I9vI8NIOkYltxCR1q5FZ MkiVTFPLhBmv53slIWFpzGemXNERdSSjmjqXY9VFE3QaadL77OOBIuPstLHnIcKNnl76lHGSZBMCw +D+FeejJFKbpCU4PgOziM+zpRn1LqU8xSEXc/X0BvgrxNw8phjYxhtvfF9KHMrxlcerE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6qYI-0001rc-Kx for control@debbugs.gnu.org; Thu, 30 Jun 2022 11:33:36 +0200 Date: Thu, 30 Jun 2022 11:33:34 +0200 Message-Id: <87letecx75.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56197 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 56197 + pending quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 56197 + pending quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 08:28:22 2022 Received: (at 56197) by debbugs.gnu.org; 30 Jun 2022 12:28:22 +0000 Received: from localhost ([127.0.0.1]:33431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6tHR-0003FS-WD for submit@debbugs.gnu.org; Thu, 30 Jun 2022 08:28:22 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:36633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6tHO-0003FB-AH for 56197@debbugs.gnu.org; Thu, 30 Jun 2022 08:28:20 -0400 Received: by mail-qk1-f176.google.com with SMTP id z12so14258707qki.3 for <56197@debbugs.gnu.org>; Thu, 30 Jun 2022 05:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:user-agent:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=ZroGlhxkuwp5c64rihOqMrN6DtMIR63raK+7OPP+jXU=; b=pwB3+16XvRmXfxAapNYEQsWoTkS+xFw2iNyMiVHZqv2+Swoi3A2VIBXlv2d24P8iPp ZV52sr1meh9Pj60qLUcbuw7/PfHhhXHvcS0ID0hmO6kLguLZBFKQYbKUnDPj+DuLux6U dL3UCSTremO9l5mIpAm5gW/32IaA6KAqWQdap5zr/wGB802ct8JjlqThkTdQScyRIY+S NY6gtkOT527al2y7p+5/BZ0pwh/muZhJS45myFKXAJqW7KcyQSJBt4hbz1Adpe3jllgT 9Y4HvljQHa8psME0vcBFJv5cyO20hhh2+3T4euk0rV5W5JwAZxa+xzlbvxdGxo3/dMaj UTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:user-agent:in-reply-to :references:message-id:mime-version:content-transfer-encoding; bh=ZroGlhxkuwp5c64rihOqMrN6DtMIR63raK+7OPP+jXU=; b=wfLkNr0EfBLixliK46w7rULqenwTTI96SMuJRMwQdOrkFuN5cCO2yeoSmEiHIXFhRK 2LeMNbXA5ugyryQ7MK7si9Po+aIEFhZrSxMtkgi2SSzbR+4DeLGSij2TAkqzZqN64cHR DyEqiysDDC6z4bRgpv6hSND2hyeoUkj/vKEUrovOOM+M0UaqosN3Sy5cz2H/63QdNTZx IXNiIAeJn34Z2XARZJkI1FpkGcrTgwN40eznW+xvZK/8jyi8FLNZk+g3fIcULdSqmpNX zP2kMZi7e0LupP7Z8q4GSYOK8w3mJSNxmH7X9O6iuv6czvGfqB0DR/d+8/mRSgcxdFJe ki6w== X-Gm-Message-State: AJIora94YB47FKZm2Vf42J9u/qfL/rv7Wtb5CLdBy1lGF5NDX9AYP5o7 gw+zRfYuDv+uW+GWHut8agA= X-Google-Smtp-Source: AGRyM1sy+cKSICyAz2XPAuh4eFs/PuD6fdxsB1auCXY3DKFnCk3eCpIFdWsrMDutSQ2nfae9dPF2hg== X-Received: by 2002:a37:2c45:0:b0:6ae:fd6d:5af with SMTP id s66-20020a372c45000000b006aefd6d05afmr5822093qkh.591.1656592092435; Thu, 30 Jun 2022 05:28:12 -0700 (PDT) Received: from [127.0.0.1] (pool-96-255-150-192.washdc.fios.verizon.net. [96.255.150.192]) by smtp.gmail.com with ESMTPSA id s10-20020a05620a0bca00b006af0ce13499sm13790906qki.115.2022.06.30.05.28.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2022 05:28:12 -0700 (PDT) Date: Thu, 30 Jun 2022 07:31:55 -0400 From: Maxim Cournoyer To: Lars Ingebrigtsen , Stefan Kangas Subject: =?US-ASCII?Q?Re=3A_bug=2356197=3A_28=2E1=3B_lisp-fill-para?= =?US-ASCII?Q?graph_result_regressed_with_Emacs_28?= User-Agent: K-9 Mail for Android In-Reply-To: <87r136cx9j.fsf@gnus.org> References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> Message-ID: <5742C214-5A0B-45B7-B9BA-D1E907C79A2B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: Eli Zaretskii , 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On June 30, 2022 5:32:08 AM EDT, Lars Ingebrigtsen wrote= : >Stefan Kangas writes: > >> The former sounds more useful, IMO=2E I don't want to mess up my strin= gs >> just to have pretty source code; I can make such adjustments manually >> when I need to=2E > >So the votes are in, and I guess we'll keep the current behaviour in >Emacs 29, and I'm therefore closing this bug report=2E > Just to make sure, this means the paragraph filling behavior seen in the e= xamples I shared would be unchanged, and different from that in Emacs 27 an= d earlier, correct? To me, the previous behavior was useful; is there a way to configure Emacs= to behave that way with Emacs 28? Thank you! Maxim Hi, From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 01 05:05:50 2022 Received: (at 56197) by debbugs.gnu.org; 1 Jul 2022 09:05:50 +0000 Received: from localhost ([127.0.0.1]:36263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7Cb0-0002Ru-6s for submit@debbugs.gnu.org; Fri, 01 Jul 2022 05:05:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7Caw-0002Rf-SD for 56197@debbugs.gnu.org; Fri, 01 Jul 2022 05:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gGGIxSk50OerezeEQPWGClDEY3yH86ieuPmRfQQ8lyQ=; b=rTlXaHn5pgBoyBFyz/bHCW9nkd aaWcx/8PLiGCCGFO04wJNyzqRTpf95GTdRnZJJZ/Hn3+JXP7o8BqlG3Q1i2oB6QjOvtMEQ7jB6Qrd nQn8aWlkoh/qgzYeHJi1qrfGs86+cM/Mh8mxZulFr/BiPoZBJIwPh+6zQg58ZU5NgMF0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7Can-0005GK-7J; Fri, 01 Jul 2022 11:05:39 +0200 From: Lars Ingebrigtsen To: Maxim Cournoyer Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <5742C214-5A0B-45B7-B9BA-D1E907C79A2B@gmail.com> (Maxim Cournoyer's message of "Thu, 30 Jun 2022 07:31:55 -0400") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <5742C214-5A0B-45B7-B9BA-D1E907C79A2B@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEWdmmnfzYSWVTS0 cUHao1VxSitWNiQmHBf///+3HDEGAAAAAWJLR0QIht6VegAAAAd0SU1FB+YHAQg7MvwjBkoAAAGk SURBVDjLhdTNjoIwEADgotG9QuIDbEbBq7G+gJEH2NQduG5MWq6bTSivv/NT8CfuOiFQ+jEzpRKN +Tey6ZxnGQ8KuaNxnpvc8EXGChkfZgRJy/4tPwOKtbX2ZOu6oKg5TsYs3Ci1QrFiSRkABIf6WEwp E3CKuzhzBS1FKftuGIbojqvUY5kABol4OaaMCnWen/fYxfCZoMWS5yuep+Qmho3CFjEl9MYBYhNc Ao8OS6SEr5IBAx6ugA3BBwo0/izw1tMNtrfgBJbxEaQWvbkAL/Z74XhITTYCw5gRDdzCXICbD/2Y cRZo/QjDJYET2PKywh2A9GBoQie1UFfleHdnJS0rBEn5EfAJQIElBgU4WIZOIdCWB88t0J0EKi/z kU++aTxlMMwB9PlBwIcGca0ZUIm0khK40giS4gViFLAJqtjFnnvTuqg9LSoB0I70NEkHL5i/PmnO Qm+eOkiLCUDWj7yfjltcAfS3YOBKtwDj/PoR1OTDt3Y3fu0aJZbOPoVSC9n9I+i0wHwP97GW87uZ W3gWO/Mqcv1TKLLiCfDFFC9r/BW/lgPrYFdX73cAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDct MDFUMDg6NTk6NTArMDA6MDBZO+8pAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA3LTAxVDA4OjU5 OjUwKzAwOjAwKGZXlQAAAABJRU5ErkJggg== X-Now-Playing: Blaine L. Reininger's _Byzantium_: "Rosebud" Date: Fri, 01 Jul 2022 11:05:34 +0200 Message-ID: <87h741yzhd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Maxim Cournoyer writes: > Just to make sure, this means the paragraph filling behavior seen in > the examples I shared would be unchanged, and different from that in > Emacs 27 and earlier, correct? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: Eli Zaretskii , Stefan Kangas , 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer writes: > Just to make sure, this means the paragraph filling behavior seen in > the examples I shared would be unchanged, and different from that in > Emacs 27 and earlier, correct? Yup. > To me, the previous behavior was useful; is there a way to configure > Emacs to behave that way with Emacs 28? I guess you can set fill-paragraph-function to a function that does what you want? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 15:15:58 2024 Received: (at 56197) by debbugs.gnu.org; 25 Dec 2024 20:15:58 +0000 Received: from localhost ([127.0.0.1]:38949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQXnS-0006f0-FL for submit@debbugs.gnu.org; Wed, 25 Dec 2024 15:15:58 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:57446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQXnP-0006ep-8G for 56197@debbugs.gnu.org; Wed, 25 Dec 2024 15:15:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=b8PqEqlfRbN3xZJ PUW5tweqirhgkWowRotlWVKnu/0k=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=KOY14k+q5OwyWuZrLDlZ5ht+OygLKcR2zV6qh09M pjOwBJ4QdMCsCpiI6bJkp/UVxklfYdaBqeE0E3+YwhzSJnDjm8noQE4QioJ0QzD6zbT4rO tcI39IuTN4cqIa2R/ePm+tTgbeajy1r3bIs9z/1VYWtJpergSHPXeNVtkFqko= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id a6723f43 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 25 Dec 2024 20:15:52 +0000 (UTC) From: Felix Lechner To: 56197@debbugs.gnu.org Subject: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 25 Dec 2024 12:15:44 -0800 Message-ID: <87bjwzr027.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: Lars Ingebrigtsen , Eli Zaretskii , Stefan Kangas , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi everyone, > fill the string using fill-column, or [...] fill the text as is in the > buffer > It's now filling that string as if it, well, is a string, so that if > you insert it somewhere, the lines have similar lengths. The previous > behaviour was to fill "what you see in the buffer" > The former sounds more useful, IMO. I don't want to mess up my strings > just to have pretty source code Filling strings in code would be useful, but isn't that a separate, don't-break-my-strings feature? Historically, the point of text justification is to make text fit on a screen. For example, the documentation for fill-region refers to columns, which are features of buffers: Column beyond which automatic line-wrapping should happen. Auto-fill-mode is consistent: inserting a space at a column beyond current-fill-column automatically breaks the line In a grand sweep, the manual explains what needs to fit where: =E2=80=9CFilling=E2=80=9D text means breaking it up into lines that fit= a specified width. Section 26.6.2 ("Explicit Fill Commands") is even more, well, explicit: The command =E2=80=98M-q=E2=80=99 (=E2=80=98fill-paragraph=E2=80=99) = =E2=80=9Cfills=E2=80=9D the current paragraph. It redistributes the line breaks within the paragraph, and deletes any excess space and tab characters occurring within the paragraph, in such a way that the lines end up fitting within a certain maximum width. How text shows on a screen is clearly a central feature. The manual continues: The maximum line width for filling is specified by the buffer-local variable =E2=80=98fill-column=E2=80=99. The default value (*note Local= s::) is 70. The easiest way to set =E2=80=98fill-column=E2=80=99 in the current buf= fer is to use the command =E2=80=98C-x f=E2=80=99 (=E2=80=98set-fill-column=E2=80=99)= . [...] Note that, by its very nature, =E2=80=98fill-column=E2=80=99 is measured in column units;= the actual position of that column on a graphical display depends on the font being used. In particular, using variable-pitch fonts will cause the =E2=80=98fill-column=E2=80=99 occupy different horizontal positions= on display in different lines. In my view, the string interpretation calls for a different, though related feature. Maybe there could be (setq fill-strings-instead-of-text t) ? Thanks! Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 01:21:52 2024 Received: (at 56197) by debbugs.gnu.org; 26 Dec 2024 06:21:53 +0000 Received: from localhost ([127.0.0.1]:39828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQhFo-0002sZ-Fi for submit@debbugs.gnu.org; Thu, 26 Dec 2024 01:21:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQhFl-0002sF-SL for 56197@debbugs.gnu.org; Thu, 26 Dec 2024 01:21:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQhFf-0004sB-07; Thu, 26 Dec 2024 01:21:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=C/lbmb9IGwXJhZMSL0nv3+0nx6lAe+AFqjIn5YimIx0=; b=CO/+b9z1hs3d1XJ5PQ2u 2rtXAXe7Wq4VSMGQGxNiNt5RR92ibgS/bWFecAQGJvdALuHYe2cF5pyxDk+fegkebXAIz6QOhHMG9 xEtR6MNZHV9LItF0RCHbNexuuLnrdjZTXS/6QHdTy1j5xJop1ILH2/+KgHyW+fV4ZQNiqXzAZt8fV cPPAL8v4EnnDjgenaPg2tgt2gRMx2FQnwipQlENr458o9wL5WcZB0Xh0RCRl7Feli7EJzcPPKlHwo t0e6T+dNfMYn5i+XoYHUGSAn/1hJyFm2rCbwP3OvUR0tR1LiWcEu8RuVnvn6LgViF/udaBVRZhCFq 30FP2u3Nd1HzHQ==; Date: Thu, 26 Dec 2024 08:21:39 +0200 Message-Id: <86v7v7ynf0.fsf@gnu.org> From: Eli Zaretskii To: Felix Lechner In-Reply-To: <87bjwzr027.fsf@lease-up.com> (message from Felix Lechner on Wed, 25 Dec 2024 12:15:44 -0800) Subject: Re: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Felix Lechner > Cc: Maxim Cournoyer , Stefan Kangas > , Eli Zaretskii , Lars Ingebrigtsen > > Date: Wed, 25 Dec 2024 12:15:44 -0800 > > > fill the string using fill-column, or [...] fill the text as is in the > > buffer > > > It's now filling that string as if it, well, is a string, so that if > > you insert it somewhere, the lines have similar lengths. The previous > > behaviour was to fill "what you see in the buffer" > > > The former sounds more useful, IMO. I don't want to mess up my strings > > just to have pretty source code > > Filling strings in code would be useful, but isn't that a separate, > don't-break-my-strings feature? Not necessarily. I frequently fill stuff in my code, and don't want to use a separate command if the region I fill includes strings (or comments, or something other that needs special filling behavior). > Historically, the point of text justification is to make text fit on a > screen. For example, the documentation for fill-region refers to > columns, which are features of buffers: > > Column beyond which automatic line-wrapping should happen. > > Auto-fill-mode is consistent: > > inserting a space at a column beyond current-fill-column > automatically breaks the line > > In a grand sweep, the manual explains what needs to fit where: > > “Filling” text means breaking it up into lines that fit a specified > width. > > Section 26.6.2 ("Explicit Fill Commands") is even more, well, explicit: > > The command ‘M-q’ (‘fill-paragraph’) “fills” the current paragraph. > It redistributes the line breaks within the paragraph, and deletes > any excess space and tab characters occurring within the paragraph, > in such a way that the lines end up fitting within a certain maximum > width. > > How text shows on a screen is clearly a central feature. The manual > continues: > > The maximum line width for filling is specified by the buffer-local > variable ‘fill-column’. The default value (*note Locals::) is 70. > The easiest way to set ‘fill-column’ in the current buffer is to use > the command ‘C-x f’ (‘set-fill-column’). [...] Note that, by its > very nature, ‘fill-column’ is measured in column units; the actual > position of that column on a graphical display depends on the font > being used. In particular, using variable-pitch fonts will cause > the ‘fill-column’ occupy different horizontal positions on display > in different lines. > > In my view, the string interpretation calls for a different, though > related feature. You are quoting text which talks about the _default_ filling. The default filling is tailored to "uniform" text, i.e. really to Text mode and its descendants. However, Emacs lets major modes customize filling as appropriate for the mode, by defining mode-specific filling functions. Which is what happens in this case: lisp-mode.el defines a fill-paragraph function that is specific to Lisp modes. It is completely legitimate for such mode-specific functions to special-case strings inside code and do something special about that. So I don't see how what we do now is against the spirit of filling. (Btw, I think it's high time we closed that bug, since Emacs 28.2 was released long ago.) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 10:17:43 2024 Received: (at 56197-done) by debbugs.gnu.org; 26 Dec 2024 15:17:43 +0000 Received: from localhost ([127.0.0.1]:41889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQpcN-0003IE-Dy for submit@debbugs.gnu.org; Thu, 26 Dec 2024 10:17:43 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:42221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQpcK-0003Hy-QB for 56197-done@debbugs.gnu.org; Thu, 26 Dec 2024 10:17:41 -0500 Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aabfb33aff8so1146247666b.0 for <56197-done@debbugs.gnu.org>; Thu, 26 Dec 2024 07:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735226195; x=1735830995; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=LPQoI0ZVErqp7EDaW+eVqzTXWdXhg/fezaqkBTIkRKc=; b=jGKYF00ePrdvCtCaXoENaHqj7jWSFoCRk9J8xDlwPPYv4oH3jtPdeX3Lk5STUrot85 pdduYYFRo6Hin69FGCBjYxn/7emZeQ+660Q6OL5We/KL460JXWsDDYtWqkGXE5eUfT0g 3hdNgaTzXex+CXHddPTntd17WeW9sXDJGg6rJcvJrC0YirT9WqFoB2v8QTLYidh/J+XG bCix+gONzYVrm8OZgutoFrftiwcQhiJvXUvxZ+oHjSdgJ5DRDajuydl8Xuae1FggZfh6 mv+G1mVLxjsfjzJAXoQP+pK0ccu1V9tNLcVtgC8Mst9+k5EfEUdhElXxKUEkMOy1ZGC9 hcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735226195; x=1735830995; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LPQoI0ZVErqp7EDaW+eVqzTXWdXhg/fezaqkBTIkRKc=; b=LsluadGZF4nnAM4Lx5dnTlw0BlZzCBU/NG+dSQikbT+6pgkPhL7J1yPYRq7eKb4D9V /232tid1apfMxERIOHieBS9v7L2SvmeeN3IP+qW12JwiUzGd8Cf0N6LbYcN8xpuB88ZK 3/qm/DVFq7uDUquix2GNUFqEDhNVLgzFpZ7cIVz7absc5E08yASYGZNV2GB6M5QcvSET aDAluKIFYPsT/YA6arj/3nsq+9WKvEnWLiGZsAnij7Dy38eIMaCSkBpNxXtyrSDw7+pb lcfjanOO5wWtwauwRyTgsGTKMdXYZ7v7C0jv1cywsOG9PW/8GenmXKrCxMB/I48CmVMr 4APQ== X-Forwarded-Encrypted: i=1; AJvYcCUGXafZvAoL+KhSBuwry069o+kUTtmL1Pq6pOkoOabf7/7Ducwl9mj9/XVJYyeuFqD9c8Y76MStmNe6@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz4kwFHRCAWklBgg2yhC7La67CRPuuTatsijeNov5H3yx9S+GFO pAfPRDwFs2S3+ZIIVokn6df9lO9qA4L6Kj1deWxNvWB0fggooMFvWSjR0a+yq6EPEle40YNwQRB MYx4FW5eyd4V+WZTGYTB6uwTU2DA= X-Gm-Gg: ASbGnctOLH3yxRo395CK7/80jASAgyTaWow4a963KBUougoujx5HjeayqDW8Vu561f/ wl7FibGnkzhVDD9DwrQlzKn0jqLoOmGKKap+8kLY= X-Google-Smtp-Source: AGHT+IGIjw9qfOHZ1qZC3SNbdAqdJxIbfQ/KF72+7mg0z3l6WjA/i03pFcqswjNWurM4fXYJZRvIqpyERz7uBTYxqYM= X-Received: by 2002:a17:906:b102:b0:aa6:9d09:b17b with SMTP id a640c23a62f3a-aac0826ed0dmr2219801366b.28.1735226195001; Thu, 26 Dec 2024 07:16:35 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Dec 2024 15:16:34 +0000 From: Stefan Kangas In-Reply-To: <87mtducx7g.fsf@gnus.org> References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <87mtducx7g.fsf@gnus.org> MIME-Version: 1.0 Date: Thu, 26 Dec 2024 15:16:34 +0000 Message-ID: Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197-done Cc: Eli Zaretskii , maxim.cournoyer@gmail.com, 56197-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> So the votes are in, and I guess we'll keep the current behaviour in >> Emacs 29, and I'm therefore closing this bug report. > > Or -- perhaps it should be backported to Emacs 28 -- but not right now, > since the release is impending. So I'll keep this open until after > Emacs 28.2, I think. Emacs 28 was released on 2022-04-04, so I'm closing this bug now. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 00:27:52 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 05:27:52 +0000 Received: from localhost ([127.0.0.1]:48370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRPMe-0007Ok-8Q for submit@debbugs.gnu.org; Sat, 28 Dec 2024 00:27:52 -0500 Received: from mail-pj1-f53.google.com ([209.85.216.53]:51630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRPMb-0007OE-N8 for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 00:27:50 -0500 Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2ee709715d9so7728823a91.3 for <56197@debbugs.gnu.org>; Fri, 27 Dec 2024 21:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735363604; x=1735968404; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=D5SkTVQjCJOMt+WN1DcII+1/Tna+eWyHxcerRF/cNmc=; b=KlbU2/qTVWb2wlA+XpOQbJSTzFLcmb8i81U7zArwTZEIZAXAFAEDTwbSlBAIFct6wC 0sw1fvrjsoEGYZ92ksZpAUKcezj2dDpMEk8uh2jaDltOUnVrtyZb93ghGyU+Z95sRB5q B6Tdvod7TYAb+nNFC2yEJO5gzT9lx/w07/uG5BE4B2Asue+F1SzZ9wncGcJDO4gY1YPu znokyTwnx7L9qFyxZmjnlSW5eecL7L3jlwUfqEeCXNjkRaheodOFKj6kZWZKakkiD9tK T101yprQVXHfolR4dgWdhAWS45NgNqo/QBDMqid1PNzp2Wg6FxZj7YcZGKgoo4TMvQls BkeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735363604; x=1735968404; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D5SkTVQjCJOMt+WN1DcII+1/Tna+eWyHxcerRF/cNmc=; b=kDeWH/8c8bRAiYjVXHcHlHc+e/ThcgHbI9tR8p7NZ+JJeVYFBbVNT/OWbjQ7QaWshV rFCj3A3OWLPg8Xmt0z92v6+Pt/CpStk93d0oIR03QgHr+pMtrSuTWP6MH4D/TGn/O88Z NK6YP3eB43MvTrUluPiv2fALgWBG9JVLPh2edOWyFGgt6BtUr11olL6Z3ttyoypZ+oft iq5LgWiH4CkRpE6f3wr/8Zco88wfMSJo5Iohp80z9oQoCQnfscl9QeXWCariUNEHY7gM LQAt4d54E30U8cvpmfrmTuuXA4fq+CQAZN+DFi5A7XCsuw66slWbZyqVHdIxlljjXVg7 Z92g== X-Forwarded-Encrypted: i=1; AJvYcCWfsbt6RDay6bxSnACroJxnw4aGEIDV8kDTy7BFPzvG6Hj8hZ21Lu1y/l4H7a+t08yhpT3O2A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyvyY2XFcvFvW1XjpuAdb6nGOfawQPy9n2qqkdBku8UB0Wb9qRW N+8CKjX8eTjFtYHzu2NMSW98awaeP/AX8ZRXLQWo6E5qqO7i4icr X-Gm-Gg: ASbGncv2RNTYc8Mx1RLi4FnnX288sDJutzYkhn6rWMkgALgVdTe/1zzHXj7w6o3JRPI 6jG6TEMKfnVVSPFg8fp7my87a5qyGXw3V3o6pb+AIuRi0q9Zdz6mjSjkI1dB//QhUXQh/oXUs7q FZ+byuDvSjP1lpCC+7QK+j0pkoe3DoTAXNHyqYp2Hde7odY0kkQnl6XcpOy7jkZfPVSOzVLXmLq 8t4ENw8qk/X2dxv6eDOKwfS+va4KShxkJ5GB2yGAzwjsas5S1rTTA== X-Google-Smtp-Source: AGHT+IGVfF3ztsXCM9B3WL/auiH6yik0el1L3PCgTt5eJEcxS5H1pwB+c1Xav/yCAVT+GDEE7z41gg== X-Received: by 2002:a17:90b:1b46:b0:2ee:c4f2:a77d with SMTP id 98e67ed59e1d1-2f452e4ce8amr38560858a91.21.1735363603749; Fri, 27 Dec 2024 21:26:43 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed82d27esm18508337a91.31.2024.12.27.21.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 21:26:43 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <86v7v7ynf0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Dec 2024 08:21:39 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> Date: Sat, 28 Dec 2024 14:26:32 +0900 Message-ID: <87seq8tm2f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, Felix Lechner , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli Zaretskii writes: [...] >> Filling strings in code would be useful, but isn't that a separate, >> don't-break-my-strings feature? > > Not necessarily. I frequently fill stuff in my code, and don't want > to use a separate command if the region I fill includes strings (or > comments, or something other that needs special filling behavior). I agree that having a single way to 'fill text/code/whatever' is nice. [...] > You are quoting text which talks about the _default_ filling. The > default filling is tailored to "uniform" text, i.e. really to Text > mode and its descendants. > > However, Emacs lets major modes customize filling as appropriate for > the mode, by defining mode-specific filling functions. Which is what > happens in this case: lisp-mode.el defines a fill-paragraph function > that is specific to Lisp modes. It is completely legitimate for such > mode-specific functions to special-case strings inside code and do > something special about that. > > So I don't see how what we do now is against the spirit of filling. Maybe it doesn't in general, but in the case of Guix packages, it's strikingly odd compared to the past behavior which was respecting the fill-column in a long multi-line string (refer to the original issue I had detailed in this thread for an example). > (Btw, I think it's high time we closed that bug, since Emacs 28.2 was > released long ago.) It's a change of behavior introduced in version 28 that apparently doesn't make unanimity (though perhaps noticed mostly by Guix developers, where the use of the multi-line strings for package descriptions makes this issue very visible and annoying); the GNU Guix project has been carrying this in its .dir-locals.el file, which simply reverts to the old behavior before commit 9bf367e1848: --8<---------------cut here---------------start------------->8--- ;; Emacs 28 changed the behavior of 'lisp-fill-paragraph', which causes the ;; first line of package descriptions to extrude past 'fill-column', and ;; somehow that is deemed more correct upstream (see: ;; https://issues.guix.gnu.org/56197). (eval . (progn (require 'lisp-mode) (defun emacs27-lisp-fill-paragraph (&optional justify) (interactive "P") (or (fill-comment-paragraph justify) (let ((paragraph-start (concat paragraph-start "\\|\\s-*\\([(;\"]\\|\\s-:\\|`(\\|#'(\\)")) (paragraph-separate (concat paragraph-separate "\\|\\s-*\".*[,\\.]$")) (fill-column (if (and (integerp emacs-lisp-docstring-fill-column) (derived-mode-p 'emacs-lisp-mode)) emacs-lisp-docstring-fill-column fill-column))) (fill-paragraph justify)) ;; Never return nil. t)) (setq-local fill-paragraph-function #'emacs27-lisp-fill-paragraph))) --8<---------------cut here---------------end--------------->8--- I can't say it feels very satisfactory; a switch like one imagined by Felix could be a step in the right direction; it'd be at least more concise in the project .dir-locals. Would a patch implementing that be welcome? Happy New Year, -- Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 00:54:05 2024 Received: (at 56197-done) by debbugs.gnu.org; 28 Dec 2024 05:54:05 +0000 Received: from localhost ([127.0.0.1]:48413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRPm1-0000Ek-8r for submit@debbugs.gnu.org; Sat, 28 Dec 2024 00:54:05 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:57606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRPlz-0000Eb-JG for 56197-done@debbugs.gnu.org; Sat, 28 Dec 2024 00:54:04 -0500 Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ee9a780de4so7188257a91.3 for <56197-done@debbugs.gnu.org>; Fri, 27 Dec 2024 21:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735365182; x=1735969982; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1qE+Wg15YyZRt56c1Ty0c6Y3IZkkD92489tv6+0wybI=; b=fAfDdk9vjoGV5c3AfY6QeCyl4FfOmj/auuEpkHfNWKCGe3TiCYF54OB/LWgkVY7Pac Wd4zs/dlyxbhtK4MsLvnJUHmpt7uaEMTaJTeUKeZOybxRjWrNyXN1pPUkhPtgRZMGnS6 dG2g1J/UNEzBFmoRsOZDHbtY6kOvl/klIeBG2zBRJ36F6ns2FDQ5cjvRs3YleArPkgh9 mkxwDRPh/j5ppZmRtt7aZ6z/G4yNtIICbdW2t4qj96PrSGr7JgYLi4+u65lK3LKnVAF2 /BzgWj6sVbEiSc6dN20ic+31USO3ZLFPOcaTnxf8xSwCF/BQmtsWOYn7Nqe9M3U2Odtq gCjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735365182; x=1735969982; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1qE+Wg15YyZRt56c1Ty0c6Y3IZkkD92489tv6+0wybI=; b=U0/FWhd8Dm/xxccuixNng1MQlR+Ry2KkjwvOk5kJYepsToClgEPrfbEJFY9iv29k1n aGD0k6rXMVYS76jzoCnuYunWMvx6gZVcBMin2i7692A6rIgZnX+ncmP8ukXV2RrdzaT3 BRqEp1is/N1iLJKoYbiB3h/3SuMAEYukJprAD5mUJGi/VkQGYL2LGv6X5nozQnVuX6Np 15v7h3QVdwimHFhW2z9A/fNA0SLZQlaNr4rjoi2RyPW6Bs+/eowGBprFqjp0oKKa2MRz pl9Ycq/rRDvjFspoEINX9GaAyyOehzutM016iiWp8P3u84jhG1PMW/WEWLfdJy/weAcg XaBg== X-Forwarded-Encrypted: i=1; AJvYcCWUcAaX+/CTHdjFWdFurXansq0ZjsO4kxv+63EEHUySvpV1/Q5XYQ6DdG2e7Wf0ZT4VTMSgezzO8NNJ@debbugs.gnu.org X-Gm-Message-State: AOJu0YwlqFQNt8q7w2eZsd5q7fBHMrr8ms7f3jlAzf3tvp7hNtv5S39x dvSYyVKWqMEEgo9+B4xt1dPOwSzIhpaxdZ5H5EH6uvsnIcXHAKwrpb+BDPJm X-Gm-Gg: ASbGncvrFzLBPx0o/xiX6cv5oZG9OCNWpSWP72A0pnyK5WEbDnDMVgymS6g9r61O5HL Ni5yckCDgkMS1PDgHql2HcY2nfnPHuc13jiHrCDj5X04zKygRNtKafMgi3JeDVheDEEm7DQHlc7 9vrjonLKOqPSi3ITGN7+h9k468YmTwav+sKQ/ZQDuDVTZtSAvBwATi7Q0DJiFazJXlyWgmEEqkZ hOSepheaHRPUh+IQ3+jBQWHFbvbLNt0OcmKQyafXTT5Hh6Tm9bnHA== X-Google-Smtp-Source: AGHT+IF2ExJRYArofslRqV10jDvH6/WJOaVTDHaE9z+H2jIKo941MYKDpzyGdJs2XtvNKndksh/t4A== X-Received: by 2002:a17:90b:3d50:b0:2ee:cb5c:6c with SMTP id 98e67ed59e1d1-2f452e4c520mr36983912a91.22.1735365182502; Fri, 27 Dec 2024 21:53:02 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9631d1sm144085835ad.42.2024.12.27.21.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 21:53:01 -0800 (PST) From: Maxim Cournoyer To: Stefan Kangas Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: (Stefan Kangas's message of "Thu, 26 Dec 2024 15:16:34 +0000") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <87mtducx7g.fsf@gnus.org> Date: Sat, 28 Dec 2024 14:52:52 +0900 Message-ID: <877c7ktkuj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197-done Cc: Lars Ingebrigtsen , Eli Zaretskii , 56197-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> Lars Ingebrigtsen writes: >> >>> So the votes are in, and I guess we'll keep the current behaviour in >>> Emacs 29, and I'm therefore closing this bug report. >> >> Or -- perhaps it should be backported to Emacs 28 -- but not right now, >> since the release is impending. So I'll keep this open until after >> Emacs 28.2, I think. > > Emacs 28 was released on 2022-04-04, so I'm closing this bug now. The issue says "regressed in", not "affects only", for what it's worth. The regression/change in behavior still applies to the current release of Emacs. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 03:45:59 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 08:45:59 +0000 Received: from localhost ([127.0.0.1]:48690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSSM-0008Jt-Pu for submit@debbugs.gnu.org; Sat, 28 Dec 2024 03:45:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSSK-0008JZ-JK for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 03:45:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRSSE-00020A-NG; Sat, 28 Dec 2024 03:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9fRva5hd9gWy6VZ1R88AL0n5XGzZWKIVeC0h9NNvcrw=; b=T/7woA8kgyrB KjtdLtqfnMJ8pxYNOqk6DPlz7iNYqiWzUbvlNrBGq7sCOmc6w3DSSQ4f3BoxsCrBoNArFp0/0Wn10 Y16q+9FEEkbRekK7jU2bq7PBu79qi9uUtvwayfx/zoaVvbT6rfqkwDHLTxf47mbmpBGecL7Q3fffU HJSjHszR9dZfp/dv82SWFwtBrWC+4aF0PN0xkzBBOBezmMGaC0adfuVw0oqOvgxqTik3QDdgsw4wG /jrB01vTZfnEXsGwhctPZjmuV2aYis/qzxDbM/0w+KTErpLIJhsDVijYAnKtjAykOh7SytiJJ8TEC Vzxu8QvDePWE47kNcfUDEA==; Date: Sat, 28 Dec 2024 10:45:30 +0200 Message-Id: <86o70wurf9.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <87seq8tm2f.fsf@gmail.com> (message from Maxim Cournoyer on Sat, 28 Dec 2024 14:26:32 +0900) Subject: Re: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: Felix Lechner , 56197@debbugs.gnu.org, > stefankangas@gmail.com, larsi@gnus.org > Date: Sat, 28 Dec 2024 14:26:32 +0900 > > I can't say it feels very satisfactory; a switch like one imagined by > Felix could be a step in the right direction; it'd be at least more > concise in the project .dir-locals. Would a patch implementing that be > welcome? I don't see how a user option to control this could be useful, since the preferred behavior is not only buffer-local, but also specific to certain syntactic constructs. But I won't object to having such an option. I also don't see what's wrong with the solution of having a special function in .dir-locals.el. We don't pretend that the default Emacs behavior should necessarily fit all the use cases, and provide ample opportunities for customizing Emacs behavior for that reason. Defining a custom fill-paragraph function is a perfectly valid solution, not very different from having a user option for the same purpose. So I'm not sure I understand why you prefer adding an option, when the Guix project has already solved the problem in a perfectly legitimate and clean way. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 03:47:33 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 08:47:33 +0000 Received: from localhost ([127.0.0.1]:48699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSTt-0008NM-9w for submit@debbugs.gnu.org; Sat, 28 Dec 2024 03:47:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSTs-0008NA-1L for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 03:47:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRSTm-0002DO-LI; Sat, 28 Dec 2024 03:47:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ceTRUnZoR/spoNqwNPpFLA7gIYd3lFCPFseHoVWzHok=; b=d/8FXF4VOicI RomKVU/1UB11ho6dQjiNsT3vKdVrzI88pK2e1rLrkb3LQpSI8FVESX/jDFUJNeYZMOHsmWOZ/mI5q NC1XmSNYAFolJ+/2nxRqLKgnHG+rS491+w3Ya1tC6ZabTtc/DfdKtJZpAaRhsqKgbCmxhQhdgTJII 3DrejK7YWXnttkqTB3I1x5xJ+lC2yDWq2+QWgByXg5nVB2KEJx68WDvwyeK7YC7pd0oHwHpwG6yQ5 iBTF9AD5s3A4gqc25LU+US9A2bsDh15qehtOsdJGgy+jsd9wnnwNJEHXyOSmfuePe6VDVKBqXXAa0 Z7xX9Om7whwc5dKX8ASdHQ==; Date: Sat, 28 Dec 2024 10:47:17 +0200 Message-Id: <86msggurca.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <877c7ktkuj.fsf@gmail.com> (message from Maxim Cournoyer on Sat, 28 Dec 2024 14:52:52 +0900) Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <87mtducx7g.fsf@gnus.org> <877c7ktkuj.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, stefankangas@gmail.com, 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: Lars Ingebrigtsen , Eli Zaretskii , > 56197-done@debbugs.gnu.org > Date: Sat, 28 Dec 2024 14:52:52 +0900 > > Hi Stefan, > > Stefan Kangas writes: > > > Lars Ingebrigtsen writes: > > > >> Lars Ingebrigtsen writes: > >> > >>> So the votes are in, and I guess we'll keep the current behaviour in > >>> Emacs 29, and I'm therefore closing this bug report. > >> > >> Or -- perhaps it should be backported to Emacs 28 -- but not right now, > >> since the release is impending. So I'll keep this open until after > >> Emacs 28.2, I think. > > > > Emacs 28 was released on 2022-04-04, so I'm closing this bug now. > > The issue says "regressed in", not "affects only", for what it's worth. > The regression/change in behavior still applies to the current release > of Emacs. We don't agree it's a regression, as shown in the discussion of this bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 03:53:45 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 08:53:46 +0000 Received: from localhost ([127.0.0.1]:48719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSZt-0000By-Kp for submit@debbugs.gnu.org; Sat, 28 Dec 2024 03:53:45 -0500 Received: from mail-ed1-f42.google.com ([209.85.208.42]:42104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRSZn-0000BY-2x for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 03:53:41 -0500 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso14971516a12.0 for <56197@debbugs.gnu.org>; Sat, 28 Dec 2024 00:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735375958; x=1735980758; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=z/7IXgleFEpYgrp4n9CkVIU8R4ec95uYDIEY2vU0pVQ=; b=Vbl55dcwjpUe+m+zuy1NcIcLC9PpYHBIB011ADb7yDuFlBBkE7vaB42QkeUy8ETuGt FM1qfEegzuafnvmuOWLxCFaiEr6UpSxe5cadZn0TYeQNJ/cQjLA68ZtYOLiA/ZRvkb6t +6uWy65Qruj4bXDuELZyEX/t+gF3shgiJGv4aufOnBp9qcO1+dD8RSAAWTYBxSaBpppe mYVnlK0ee0suthm/ZgUFfJ9z3NhfkXnjcYgAPaScE8s8CPSZ15tU2Uz2BmzwkEIOLtvR hGYeOVFxRjF9TBd5FdnKNYpR2EopUvO9YzidRybdFJjfPzTvu8a/lAJevTirQ61g2gpX Fbmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735375958; x=1735980758; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z/7IXgleFEpYgrp4n9CkVIU8R4ec95uYDIEY2vU0pVQ=; b=DlhITQxCMYj77ROX07RezUc1Tz1EKUp2m3HiJW01VeA2BjqfSq+Azk9AJb1cysA36G C2cy9W1i1QHJvb3eEIlz2qKZ9ldthNodhUtdJTro4Aya8HGLLQDxk+qRVjuQEI2dpUo5 zB4Y7TdP6Ng4gWJB0Tm2p0BOGnbZcqlFnYzG39JHom+hBBnDPp1v8i3FhIl0jroyoEz5 ymhVPdI/x/1D6cFTSUT4P2WiPO9RbAyxCWMkBcCo++vqcU8F8+JJGARgUSF7Y4EJoMgc qL4LINaahokAsD57fC/Sh9DNOF9ZTcfBgCzLHM2NechKYiZTcamRoGA4rMeCAmGD9IDn CBNg== X-Forwarded-Encrypted: i=1; AJvYcCWmGPKaV30HlT7MW62iI320ivvJHckuOyYND0OUC5nqBXB11n3FKjVMVnGcm58l1SdAFOW7mg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzGVvhkzkPlkYS8MTEBe5NYw4UDYWK0FjD9vbtl+FtilUybUxLx WTTUGWkI4JlUJ51+8FjT2AgrpeSKGv3WAwnGVtnuTg0Umm3gPJhG/EcGN76ejMjCHiU2lvj4AlD u9Ph0L1E3hORlIDk3cPpqTrFETfo= X-Gm-Gg: ASbGncu/rG3RJoe7HDkwjVWQEYT1OpVERPRzuPF8t4SWw+35AcJVBtyqimohzvl7acA Gs+rL9IKLY+uRMoZXZLPB8OpIKEDh7qr9g/vx X-Google-Smtp-Source: AGHT+IGDu1ORH7BnQQb4u7oQEutrX2mW5kfYvIDsd66+w2EW0p7IztAfQsQz6Az9SrV5Tg9F5u1XD0TItGYJJgpqeKQ= X-Received: by 2002:a05:6402:42c3:b0:5d4:1c66:d783 with SMTP id 4fb4d7f45d1cf-5d81e335468mr24293713a12.0.1735375958329; Sat, 28 Dec 2024 00:52:38 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 28 Dec 2024 08:52:38 +0000 From: Stefan Kangas In-Reply-To: <877c7ktkuj.fsf@gmail.com> References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <87mtducx7g.fsf@gnus.org> <877c7ktkuj.fsf@gmail.com> MIME-Version: 1.0 Date: Sat, 28 Dec 2024 08:52:38 +0000 Message-ID: Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 To: Maxim Cournoyer Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: Lars Ingebrigtsen , Eli Zaretskii , 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 56197 thanks Maxim Cournoyer writes: > Hi Stefan, > > Stefan Kangas writes: > >> Emacs 28 was released on 2022-04-04, so I'm closing this bug now. > > The issue says "regressed in", not "affects only", for what it's worth. > The regression/change in behavior still applies to the current release > of Emacs. Sorry for misunderstanding. I'm reopening the bug with this message. From unknown Sat Jun 21 10:42:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sat, 28 Dec 2024 08:54:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 09:52:38 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 14:52:38 +0000 Received: from localhost ([127.0.0.1]:49879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYBB-0000Qm-Uk for submit@debbugs.gnu.org; Sat, 28 Dec 2024 09:52:38 -0500 Received: from mail-pl1-f182.google.com ([209.85.214.182]:59511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYB9-0000QT-UX for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 09:52:36 -0500 Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21675fd60feso132250095ad.2 for <56197@debbugs.gnu.org>; Sat, 28 Dec 2024 06:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735397489; x=1736002289; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=c3UgUYvgE4JXydFktyW7WFDCzDTHqvUtelCqAWBvmZI=; b=J0F9Jrg58mcZsGR6eAoDWnaMkGeo7ruMhGOnQseSPM7LO8MNRRSBqddBZk8LVRnxQK gCuuQJWVJG+DikOh+BtZyui2BTzyH54IHZotmgP+nsLRy2WQHm1wzS+g7SfIGLzKiXQ4 /6kJnuzG1NXKS8N14t4LSGDO9/kU0ARlvMZsdJv/dqKibusvb3UptIbH0dgCpvJMjglH hiGIe+7ZFLUw27qBf1p9Mrehttu9DeYBVrlwJfMzV2cFGgmav8Wm8a8+oEnTU8REPfnh X3KgXNBT+19BrIPE648+GLmtef5UPsMG0TEOPrPBWEVGHYOiyss9UZttlsk9gio0V1w0 1PlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735397489; x=1736002289; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c3UgUYvgE4JXydFktyW7WFDCzDTHqvUtelCqAWBvmZI=; b=CJ37btZc2It7w5vgdJ8jqkMs95BG3noN7x1y2CD4yib65LTbFHr8t0+luyqFnTbLoi +3c/F0LKbzN3ABdnCtu4R/R2Tej0ruTYvBNvcFPBZGXWGsMXr/VEVR6AeM+rSnmCdXoc PHPv8p3qKtxOKB6dIU2tisW6ZyvepUqRF671XDxAztvMSpCGIWigVEy29+D1IG+FJrNX 0QstR012hfgPhj3UTj5lnvWh024OXWjwHUreOC3lFfuxMj0aa+CoGPaAYmSKh0tYayBm ECNvXUkgdLWghQXu198KPtGuuCJOfLBX0j6pF4vwib648caAIwB0aTVUc1XJEpTpl3FR GVPw== X-Forwarded-Encrypted: i=1; AJvYcCWuSWF772dHIw9pjplUwcnHusmcHVS3AP2OmlysKxoD4mtHS9WyrdAKAEVE/n5Dv3LhnJD5fQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyeM1A3je8rkhp4aP46tHRmhUK1yXeLDPaSDHyBn/kuopyhyjjf BDTeUtE06rn+6YpjiV5m169Wsc4N+8TCdBnPqR7Io+JXHpMRGGQx/e4qg1ZLsdE= X-Gm-Gg: ASbGncsXuUzLdrNtPwHaN8Y8MjedfBj+TeGBJwHGql/VWv5C9m9f6IjU7vcoZ3Z4mvA HUjoKMZWiY/aN28iEeZDSf8ZlLQDoL1GoPfbD7Fu/KLf3ARyNEGC231VadXKb8jP4fu9GSdNLiI cepNhqhpjdM/39q2qroRPc9JIK6+K0gm9Rmmwc+etZlb+wPLDartI4cK+2lvHvb4cqBQgLPiSd5 J17LdcCOvHpNHfJBPg7mdcIDOfZCMlalPtNcuI1ET4SOlkVM3A2pw== X-Google-Smtp-Source: AGHT+IFWHKz3xw02bgRkgLDT9BaBN5E9iz1GHok6XZmrOn3+2FrCDA+6M5ZBOE1DJyhohMqnbe1n4g== X-Received: by 2002:a17:903:2383:b0:216:4122:925f with SMTP id d9443c01a7336-219e6e9f8d8mr409127735ad.14.1735397489132; Sat, 28 Dec 2024 06:51:29 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962c8csm151730625ad.49.2024.12.28.06.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 06:51:28 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <86msggurca.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Dec 2024 10:47:17 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87r136cx9j.fsf@gnus.org> <87mtducx7g.fsf@gnus.org> <877c7ktkuj.fsf@gmail.com> <86msggurca.fsf@gnu.org> Date: Sat, 28 Dec 2024 23:51:18 +0900 Message-ID: <871pxrsvx5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, stefankangas@gmail.com, 56197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Eli, Eli Zaretskii writes: [...] >> > Emacs 28 was released on 2022-04-04, so I'm closing this bug now. >> >> The issue says "regressed in", not "affects only", for what it's worth. >> The regression/change in behavior still applies to the current release >> of Emacs. > > We don't agree it's a regression, as shown in the discussion of this > bug. We can call it 'change in behavior'; I agree in most cases the new behavior is probably good. I don't see us being in disagreement; I think Felix and I are pointing that the change has impacted negatively at least one use case, and we're exploring ideas for a better solution to that than pasting the previous copy in a project's .dir-locals.el file (I'll explain in your other question why I see this as suboptimal). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 09:54:40 2024 Received: (at control) by debbugs.gnu.org; 28 Dec 2024 14:54:40 +0000 Received: from localhost ([127.0.0.1]:49888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYDA-0000YR-Fo for submit@debbugs.gnu.org; Sat, 28 Dec 2024 09:54:40 -0500 Received: from mail-pl1-f182.google.com ([209.85.214.182]:59587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYD8-0000YF-UC for control@debbugs.gnu.org; Sat, 28 Dec 2024 09:54:39 -0500 Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21675fd60feso132279945ad.2 for ; Sat, 28 Dec 2024 06:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735397613; x=1736002413; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=P4if0NWgyXxQIfTPXQuUK06Ooe166r0Qe1Z4fPC0dQU=; b=hOCHC1XQleTD2y9wC4fWArtox+6dR657qHiZA0AM9lP7oyYmP4+jdgNfvOykdc9ZDX w/BQdz8UegyLL/C6Cc4WNeU3no1G4h7D2jBeDoQjarpbFz8zqRHaNS3ewP3+GeypCjYL u71xwq5lL1tldPuDqKOyxU4jZaoXVAugv63W2rNOlWXaVfxKk5VrA8RWll939o2mk4Z2 vsbsNzpiiz6hXytuKza5dCvzNz3aobvrPCjaTCly34r1Tfv+pc87FUnhttnC1m5ZYp0D dxW2wgO6ko8P+zJhAaCZcxEaha4b3JBrzzYxxlc1TDXvMmnJyO695SBybbjAS334Qf71 GwNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735397613; x=1736002413; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P4if0NWgyXxQIfTPXQuUK06Ooe166r0Qe1Z4fPC0dQU=; b=i646arhCq4t7dnhW+CJF0byu5l7By1sb3JqxDsgqkK01rQ2hTrnyNkaN9NvSrMiAHn st35mDwke7nEIK7t6tnQE8x4ETALDCrU1L+fai/4R2B0qetW1xUKkYc4VoPoOCl/SNOS b5Mkzb3QfaldD/r50BDc82t6IiBhfyBP+FwqOw1HqFAI4/eXNdibO9scAorsvqc3BRZU qZhOqf97eBYU5k86SHfrKi5FjYmPjLqbjhqlzOjKo7NH7n+Agng96H7Ldf8P8psj0Y+r 2MNmO7Jtbdbt3KyMHCgq1krBejcXpVxiOQ15Zh9GZSrUVHgpElcc7c3OmMZz8tvykqeZ ddkA== X-Gm-Message-State: AOJu0Yxnz6xQP0HgOIngszachc43FRIrNxhxHpUXKfBIwXKSI0EhuNZh hGLcyhDrZJgrMKCE0os7txCNGThDD4OXi1phbiJbHijNtk9mzcqgK+JNqSC5 X-Gm-Gg: ASbGnctIqdZ3Avsg75zuaK+oNdaYjteIvey/onzaJQhZlO8kxV7T2ctYYxDV6xcYonY SGbG6MBaPUMzjClksPhvetu7BflYwDxXoabBqMXSCCmQOuOgsC3AOaMwtxWwNpxe1V056IQISJ+ 4z+e4F94ZaUrfbgyNAShohs22ZCDxR32tywE0nRfnAHYzE7L7GfrjxAUXH/SKfQQFVCbqtMcBai XFFg/xt4cj2G23F/JorgZ21UvgngaQ0kVUgIXIYkgwNvJqRSWTCdQ== X-Google-Smtp-Source: AGHT+IEgUiEzIo0lBWImTng4qz4rJhSkPaPLc03BJIC4YaoL4fSMdTkecRiK7TjQ1ustIcZDpXiP1w== X-Received: by 2002:a17:902:d2c6:b0:216:2bd7:1c36 with SMTP id d9443c01a7336-219e6e8bbb6mr428585645ad.1.1735397612964; Sat, 28 Dec 2024 06:53:32 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca031besm147367455ad.281.2024.12.28.06.53.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 06:53:32 -0800 (PST) Date: Sat, 28 Dec 2024 23:53:23 +0900 Message-Id: <87zfkfrh98.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #56197 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 56197 lisp-fill-paragraph behavior changed in Emacs 28 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 10:16:10 2024 Received: (at 56197) by debbugs.gnu.org; 28 Dec 2024 15:16:10 +0000 Received: from localhost ([127.0.0.1]:52294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYXx-0002Cp-Qt for submit@debbugs.gnu.org; Sat, 28 Dec 2024 10:16:10 -0500 Received: from mail-pl1-f173.google.com ([209.85.214.173]:55457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRYXv-0002Cb-Pr for 56197@debbugs.gnu.org; Sat, 28 Dec 2024 10:16:09 -0500 Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21636268e43so38318405ad.2 for <56197@debbugs.gnu.org>; Sat, 28 Dec 2024 07:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735398902; x=1736003702; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sY1WvmByA0/ApcHrDskEBDFjbfkTT0AqmCPgQEe/R/c=; b=fxhwwq90rCyxjTL1jqdUNiHSMmxapSmpujnj99qvhjz/Iq+aQFsNW8swft6biLTV/7 zNw/XT31LgASHdJ38m2TMUi9XAXM6RWdv9N+R5mFywKzVQq9dkn8icpDJJAXdBkKCQtv e+ezjjxCTDHRKodbZf+EdtLB2rhpsFC36EW+7nM5kX9EWLfOHC5Ji+RUV+Ab2MMbwxhM Ub7otUL24z4pLHHqI+q+my0YJA9FTA13uYe8KvkdJX2WRrEQIG9gmkGKBzYb+E4opiQK /r2p5gHZ+V9En18P4COwI7HMiq42mFJjtOVhFbTOp7IHo92zQQe26/Tdr8sDVxs16xll sOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735398902; x=1736003702; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sY1WvmByA0/ApcHrDskEBDFjbfkTT0AqmCPgQEe/R/c=; b=JRFfpJkUkU+stSz6Akd4gIAcdQDDqoiPJbao+JjzE7v5XuIAiXwd7H8TfcSgtv386F +FgR28QuYqVWPdvmU1+5obHFHeF1VR0VCNwO9J/ZshaxOEko+Ofi5S9Wv/XCgZGY9cdV LLKNTHznsRd5QRNanOjgoBFvzDYzVtryQsyvcq6yXtNw3vUl8rTqRVuhuEP0btoPTXs5 oGdMrq+k2lDAy8l3rzqx+DiU8cuJqgKBh54f7CqevjuCVaoYlwjW57BdhxwDyuJDPiB+ FME4vMZv66OAfRJ5xl+DbqM4kfGtDs+jaUYOmUc3DVmzSQGweUr8Mlxj5NUdKbI9L2EF QRSg== X-Forwarded-Encrypted: i=1; AJvYcCV8juCnYEeHakqFuYIQbONj4n/sYK1GywUPMfqHn9WptZSobdeTjVUzX+UsyCIRrin/vCmPxA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyodWUKfei6qjQcayk3B6vr3/24gR8X/HWqR9fFmZ2pldsGProh +KisMbEFieSIxXvNseiSlpoFalx7JTzO5wi5hO0+h8sAVUZgI+G9RMp/eOWAf1k= X-Gm-Gg: ASbGnctZIE/LyJimgl29F+utkMqR6VYRE6aY5BsdtnrthpbEjezrm2ssKCbkpUHaxgv /1496c/2vHhqcGau+GPV4ne6/Ka7MMoHfQ/a6U+jEbXp0Gtj9MAXmCg051/DhHXHm8tVTdzniim iYYuZeZnMF58QkqR/oZtyvXhlz6DSlCuDoRlFEIvjkx5J8GhtXSnrCr30MnCoGY2V1imA9otXjQ GDp3AqGb0wKqGxtkBv2DGFso4vfBCzjhygjJh01a5PT5SDOtMrGxQ== X-Google-Smtp-Source: AGHT+IGP8YaK2jAW1mWzaHrsWnRtNQIC6owjsDYsWRuZ4Ij2pWJ9ZShlTntVGJPnvtX3OK6AQYWfKw== X-Received: by 2002:a17:903:3205:b0:215:b9a7:526d with SMTP id d9443c01a7336-219e6ecfbb4mr448916715ad.32.1735398902116; Sat, 28 Dec 2024 07:15:02 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962c75sm151181015ad.24.2024.12.28.07.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 07:15:01 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: 28.1; lisp-fill-paragraph result regressed with Emacs 28 In-Reply-To: <86o70wurf9.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Dec 2024 10:45:30 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> Date: Sun, 29 Dec 2024 00:14:50 +0900 Message-ID: <87ttanrg9h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli Zaretskii writes: >> From: Maxim Cournoyer >> Cc: Felix Lechner , 56197@debbugs.gnu.org, >> stefankangas@gmail.com, larsi@gnus.org >> Date: Sat, 28 Dec 2024 14:26:32 +0900 >> >> I can't say it feels very satisfactory; a switch like one imagined by >> Felix could be a step in the right direction; it'd be at least more >> concise in the project .dir-locals. Would a patch implementing that be >> welcome? > > I don't see how a user option to control this could be useful, since > the preferred behavior is not only buffer-local, but also specific to > certain syntactic constructs. But I won't object to having such an > option. Having the behavior defined per-project or even globally (reverting to the the pre-Emacs 28 behavior) via a simple option seems like it'd simplify things, and make them discoverable. > I also don't see what's wrong with the solution of having a special > function in .dir-locals.el. We don't pretend that the default Emacs > behavior should necessarily fit all the use cases, and provide ample > opportunities for customizing Emacs behavior for that reason. > Defining a custom fill-paragraph function is a perfectly valid > solution, not very different from having a user option for the same > purpose. So I'm not sure I understand why you prefer adding an > option, when the Guix project has already solved the problem in a > perfectly legitimate and clean way. For one, having to put that largish piece of evaluated code in the .dir-locals.el of the project means each new developer is prompted to trust it, and it makes it more intimidating/pollutes their user conf file (being added to the 'safe-local-variable-values' value). It's also not discoverable; a customizable option would help in this regard. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 05:09:58 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 10:09:58 +0000 Received: from localhost ([127.0.0.1]:53449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU16T-0007DC-9z for submit@debbugs.gnu.org; Sat, 04 Jan 2025 05:09:58 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:44330) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU16R-0007D0-AN for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 05:09:56 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2164b662090so160068035ad.1 for <56197@debbugs.gnu.org>; Sat, 04 Jan 2025 02:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735985394; x=1736590194; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ESEdtEbGkFdsE2+8wue0FTuaanNZj+yfo8zdeUo1lzI=; b=FaU4ruWmuHLMjtY+TkAtZN8e/C0xJLFRqktEade73Q02jLYyAUI+ymlVPVpre/iiTH AB8jcKnGS3lDcliTQlmmP3sdQkY6SUPxvXmkrrxJLIL502ejdvIla5e56A6rcnfOepIz IRCEPq8c3MA/F4droy8b5K3T12LvxF6xZukxKYAk1mFNb7HBfhIXU2gS/tXp3ygvG5+W y1pibn1emfwNVvlfyBQurHJuo8Eit/ZxJvu2UdA3aDWqATy8Raa5xxC1TabpgrmUNxvS FCFmtxnAUuKFeyVLpMJpLe8NoW87YWVRISPUQPmio44ljkBeB47r8Vc7UKGG26MGfP04 9Efw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735985394; x=1736590194; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ESEdtEbGkFdsE2+8wue0FTuaanNZj+yfo8zdeUo1lzI=; b=SZhHPxDPPAD9CigCN6gAEEVyeOSfZgDY9uAu4Inlf6AITt8Tei7812vHvfp+WF8q/w kMuS0zWbuUBgAn9zOZ6yxtDKU8e0LItDVq80XyqFbLFdiBYlQe8MIEL8abfoFsm2VVn3 sDYtj5IS7x+0RV5vbeD1usf7mwWJt6PsfAvvayVhZ2+ffeUNlTutsWAnczIrSyWInGSQ WNpGTtgpNPlptyPkIywdCKeRr+jLsrfyIjVEizTnt3Yxcu8JJDundJ5fpO541MqVu5VI ZKrmlMKSxpbuVGDNFzRsAwsjJk30LTquERHKe8TYPM9PIaR26Ln1rSBB4oc449HAsgvR neiQ== X-Forwarded-Encrypted: i=1; AJvYcCUgwXq5chy4Rh3eSSZTce9GT8fTDG3HLe3S+K9savldljfO7gyZILo21DLaG/1bN8zDimiaaA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxs3JEvBswTWruixppd8bM0NoD9rz5L1AN3HhemLj68T2Sa1ThA xBiGc4hX+6s0VYlZnBCe4Jv4pHq3MWyJSEv/alH9K0ivjHbKyXma5Lo4W4qu1nY= X-Gm-Gg: ASbGncuzysQmg95488oj723FyI7bgvu9pD84EJLYCr2WJBaobRId2P4qL0y+2dtIpYh ytPa56+BdpG0g57GIf5DOsi6Ygn36e7zYJKpsjqfcy1Q3DXMUPCxSVAwKykdMXE/Ly8MVjFxfWT xfj/YL2pB51Ui5fZVEseTcvw/SVC3CDJYX3lCcZrBBP/fwjOxR09qChv4+WgLdTTK5RkAwUxlhq vthB8vbeWVM7m2T+SUSpKhCCyzILpywLw3nmIOdU74p0G/dfEYGbg== X-Google-Smtp-Source: AGHT+IHKHhGCyFRWtFKBSMT5L4ew/c8wixVI2ld0t0cVkRo6mYGud8Dm5i0ZgL69OECg6KqC3VX9BA== X-Received: by 2002:a05:6a20:7350:b0:1e1:cbbf:be0 with SMTP id adf61e73a8af0-1e5e04a2f70mr98832700637.22.1735985393898; Sat, 04 Jan 2025 02:09:53 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8347d1sm28629159b3a.66.2025.01.04.02.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 02:09:52 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 In-Reply-To: <87ttanrg9h.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 29 Dec 2024 00:14:50 +0900") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> <87ttanrg9h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 04 Jan 2025 19:09:42 +0900 Message-ID: <87v7uuevq1.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Eli et al., Maxim Cournoyer writes: [...] >> I don't see how a user option to control this could be useful, since >> the preferred behavior is not only buffer-local, but also specific to >> certain syntactic constructs. But I won't object to having such an >> option. > > Having the behavior defined per-project or even globally (reverting to > the the pre-Emacs 28 behavior) via a simple option seems like it'd > simplify things, and make them discoverable. I tried fixing this generally, as it seems to me that something in lisp-mode should be meet the needs of all lisp-derived languages such as Scheme and not just Elisp. I first added two tests, one of which ensures no regression to the original bug that lead to this current behavioral change (bug#28937) and the other one that should pass once the issue reported here (bug#56197) is resolved. The last patch is a WIP that didn't work; I was hoping that inserting spaces corresponding to the width of the indent in the narrowed string would cause the indent to be preserved only for the first line. I don't have other ideas at the moment; I'd appreciate if someone could tip in. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-test-lisp-Add-new-test-for-filling-behavior-change.patch >From aacf65440070df2ba356af1d118a50993fc8f865 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Mon, 30 Dec 2024 12:02:36 +0900 Subject: [PATCH 1/3] test/lisp: Add new test for filling behavior change. Starting with Emacs 28, filling strings now happens in a narrowed scope, and looses the leading indentation and can cause the string to extend past the fill-column value (see bug#56197). * test/lisp/emacs-lisp/lisp-mode-tests.el (lisp-fill-paragraph-respects-fill-column): New test. --- test/lisp/emacs-lisp/lisp-mode-tests.el | 27 +++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index da02be65d03..9a2b1ea4654 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -308,6 +308,33 @@ lisp-indent-defun (indent-region (point-min) (point-max)) (should (equal (buffer-string) orig))))) + +;;; Filling + +(ert-deftest lisp-fill-paragraph-respects-fill-column () + "Test bug#56197 -- more specifically, validate that a leading indentation +for a string is preserved in the filled string." + (with-temp-buffer + ;; The following is a contrived example that demonstrates the + ;; fill-column problem when the string to fill is indented. + (insert "\ +\(defun test () + \"This is a long string which is indented by a considerable value, +causing it to protrude from the configured `fill-column' since +lisp-fill-paragraph was refactored in version 28.\" + (message \"Hi!\"))") + (emacs-lisp-mode) + (search-backward "This is a long string") + (fill-paragraph) ;function under test + (goto-char (point-min)) + (let ((i 1) + (lines-count (count-lines (point-min) (point-max)))) + (while (< i lines-count) + (beginning-of-line i) + (end-of-line) + (should (<= (current-column) fill-column)) + (setq i (1+ i)))))) + ;;; Fontification base-commit: e32484547d0813665334bfd34b741492dde0d374 -- 2.46.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-test-lisp-Add-a-test-checking-docstring-boundaries-w.patch >From e5685497111ef71e57948f023f8d2a03647c3d69 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Mon, 30 Dec 2024 14:26:46 +0900 Subject: [PATCH 2/3] test/lisp: Add a test checking docstring boundaries when filling. * test/lisp/emacs-lisp/lisp-mode-tests.el (lisp-fill-paragraph-docstring-boundaries): New test. --- test/lisp/emacs-lisp/lisp-mode-tests.el | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index 9a2b1ea4654..eac2763c595 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -311,6 +311,25 @@ lisp-indent-defun ;;; Filling +(ert-deftest lisp-fill-paragraph-docstring-boundaries () + "Test bug#28937, ensuring filling the docstring filled is properly +bounded." + (with-temp-buffer + (insert "\ +(defun test () + \"This is a test docstring. +Here is some more text.\" + 1 + 2 + 3 + 4 + 5)") + (let ((correct (buffer-string))) + (emacs-lisp-mode) + (search-backward "This is a test docstring") + (fill-paragraph) ;function under test + (should (equal (buffer-string) correct))))) + (ert-deftest lisp-fill-paragraph-respects-fill-column () "Test bug#56197 -- more specifically, validate that a leading indentation for a string is preserved in the filled string." -- 2.46.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-wip-work-on-solution.patch >From 5bc5de2fc6f7783b0cd71c5945755fc98431aa60 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Tue, 31 Dec 2024 10:18:30 +0900 Subject: [PATCH 3/3] wip: work on solution --- lisp/emacs-lisp/lisp-mode.el | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index d0c32d238bc..6c6d88f73a5 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1,6 +1,6 @@ ;;; lisp-mode.el --- Lisp mode, and its idiosyncratic commands -*- lexical-binding:t -*- -;; Copyright (C) 1985-1986, 1999-2024 Free Software Foundation, Inc. +;; Copyright (C) 1985-1986, 1999-2025 Free Software Foundation, Inc. ;; Maintainer: emacs-devel@gnu.org ;; Keywords: lisp, languages @@ -1480,30 +1480,34 @@ lisp-fill-paragraph (derived-mode-p 'emacs-lisp-mode)) emacs-lisp-docstring-fill-column fill-column))) - (let ((ppss (syntax-ppss)) - (start (point)) - ;; Avoid recursion if we're being called directly with - ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. - (fill-paragraph-function t)) + (let* ((ppss (syntax-ppss)) + (start (point)) + ;; Avoid recursion if we're being called directly with + ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. + (fill-paragraph-function t) + (string-start (ppss-comment-or-string-start ppss)) + (indent (save-excursion + (goto-char string-start) + (current-column)))) (save-excursion (save-restriction ;; If we're not inside a string, then do very basic ;; filling. This avoids corrupting embedded strings in ;; code. - (if (not (ppss-comment-or-string-start ppss)) + (if (not string-start) (lisp--fill-line-simple) ;; If we're in a string, then narrow (roughly) to that ;; string before filling. This avoids filling Lisp ;; statements that follow the string. (when (ppss-string-terminator ppss) - (goto-char (ppss-comment-or-string-start ppss)) + (goto-char string-start) ;; The string may be unterminated -- in that case, don't ;; narrow. (when (ignore-errors (progn (forward-sexp 1) t)) - (narrow-to-region (1+ (ppss-comment-or-string-start ppss)) + (narrow-to-region (1+ string-start) (1- (point))))) ;; Move back to where we were. (goto-char start) @@ -1516,7 +1520,16 @@ lisp-fill-paragraph (goto-char (point-min)) (forward-line 1) (narrow-to-region (point) (point-max)))) - (fill-paragraph justify))))))) + ;; Insert spaces to reproduce the same leading indent + ;; for the string inside the narrowed region, to avoid + ;; bug#56197. + (save-excursion + (goto-char (point-min)) + (insert (make-string indent ?\s))) + (fill-paragraph justify) + (save-excursion ;clean up + (goto-char (point-min)) + (delete-char indent)))))))) ;; Never return nil. t) -- 2.46.0 --=-=-= Content-Type: text/plain If that's not easily fixable, perhaps I'll submit a patch to the paredit project so that they stop relying on lisp-paragraph-fill [0] and instead use the default (which is fill-paragraph). That's how I came to notice this behavior change in GNU Guix, which is written in Scheme; using scheme-mode doesn't exhibit the issue since it's just using fill-paragraph. [0] https://paredit.org/cgit/paredit/tree/paredit.el#n1066 -- Thanks, Maxim --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 05:14:35 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 10:14:35 +0000 Received: from localhost ([127.0.0.1]:53460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU1Ax-0007Qz-FB for submit@debbugs.gnu.org; Sat, 04 Jan 2025 05:14:35 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:56628) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU1Au-0007Qq-EZ for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 05:14:33 -0500 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2ee786b3277so13590565a91.1 for <56197@debbugs.gnu.org>; Sat, 04 Jan 2025 02:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735985671; x=1736590471; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ENFvYa+LwxjZDDUWugajyV0N20XWLkYTrLSf53WusWw=; b=Mi78K79kurFT6a8gRRd1RttvUzTSS/yokHo8Gom9aPH2eKOAj8NxoaTGby5gT17Ks5 1nc+kNzU0BP3zH02B7hzkjuNHXTee3gnP+foP548jrKni7Nz8j5fmeIUlucWxzeZMPom MQIUhguitM+9BCYe1t3DY18GiaxLWb+FXbEd+ra0Zcu2PcwNDTRIUhtaR+w10IggMolw dgupYGi5VUZnfDVecA3NccMivk8ysEhA8HW+B1a4wsvEoOOFySgDFObxk7KubK4feH4J 2iWPMWJjMGd5LQka1i7d4mrueAive2vaeCk3c9BOjjrnX+/6YOG32tPELSF9gVu1HR6i efJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735985671; x=1736590471; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ENFvYa+LwxjZDDUWugajyV0N20XWLkYTrLSf53WusWw=; b=ZKezHNzvrwIwlQGmfBX52Yn2IaW9c+2Hze2eIvw7wI9I1Kdzw4ohtEEtVDAjAcwIoc 2M/kI5CHwstJjJNltydXoFq7gNGPGbkXzk4JEpvk6XD/5fXH0n7sg2l5ab7wqW21Ukza hSqKmqFG9Rpk8ka25Hkzg0cszYjsy5xqb9e5WE6bUCDmgRQbyLZiIo6RKnLHLC4TRwnB bIC86GbLaqzjj2mveySLXIlH+wZ16cYVfR7/Eg7GRGNjOA8gKZ3N8PT0YXFQ5iwrCbsk HKTFoekhrBkx81weFXtFhCDjO6WBK4o/ygYzv8nHxiE3mYhIGQLti1FMz5LgrNIfzcaE V7gw== X-Forwarded-Encrypted: i=1; AJvYcCVfx2c3lWt9dKwjL5caaGO0q/ZDPgqbV6Q8nkAWnwwDRZSbVhmbS/ERwPQrsH8iLv9ydOiMhQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyTal8DvrblQJtSJCbVkAps6ymQGdC/SsQT73T+JIzp8DugrMDi 9vpQz7vgdFcCzwt6Ko30xSBd/N/ATaeK8nKdqHHzNnCjfMAtb1aO X-Gm-Gg: ASbGncsQrPGg7IGBWKAmreOO5YuZJfHIQ3flcFoZPYOOk/2N8g6p+azHixwORfIotJD lo0oqIFZxNFU5Y3oWKSDHC22yEd4pVvofPfZrSzdhwOdfjOr3eDjymBZMFQt4Zcx2upfHBZgm9o OuR2wLGYY4XNYHDqY5bOlE/RyYXLvLZyONrrYzmt1B22fuW21Pga7gPNRmpf0hO2B123JV++4D4 NkS3i0EyBYuIVsfQB5nOg3Jw3PHJNxbNF21agiX2Co7myqvu266Zw== X-Google-Smtp-Source: AGHT+IGbfA5ry/b6U3wFUzsTxI1aN2Wps84mgtZvbZSVRYLAcGQ0bcqDHBKIDZMA5CDfSZJWbiq21A== X-Received: by 2002:a17:90b:54d0:b0:2ee:c918:cd60 with SMTP id 98e67ed59e1d1-2f452e4a7f6mr79905941a91.20.1735985671229; Sat, 04 Jan 2025 02:14:31 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4477ec9d1sm32798137a91.29.2025.01.04.02.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 02:14:30 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 In-Reply-To: <87v7uuevq1.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sat, 04 Jan 2025 19:09:42 +0900") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> <87ttanrg9h.fsf@gmail.com> <87v7uuevq1.fsf_-_@gmail.com> Date: Sat, 04 Jan 2025 19:14:20 +0900 Message-ID: <87r05ievib.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi again, [...] > If that's not easily fixable, perhaps I'll submit a patch to the paredit > project so that they stop relying on lisp-paragraph-fill [0] and instead > use the default (which is fill-paragraph). That's how I came to notice > this behavior change in GNU Guix, which is written in Scheme; using > scheme-mode doesn't exhibit the issue since it's just using > fill-paragraph. Actually, it seems scheme-mode at least in Emacs 29.4 does make use of lisp-fill-paragraph, so should exhibit the same behavior/problem: c.f. circa line 178 of scheme.el: --8<---------------cut here---------------start------------->8--- (setq-local fill-paragraph-function 'lisp-fill-paragraph) --8<---------------cut here---------------end--------------->8--- -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 08:04:21 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 13:04:21 +0000 Received: from localhost ([127.0.0.1]:53844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU3pE-0006xm-Ib for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:04:21 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:47279) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU3pA-0006xU-9u for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 08:04:19 -0500 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2f43da61ba9so14968818a91.2 for <56197@debbugs.gnu.org>; Sat, 04 Jan 2025 05:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735995849; x=1736600649; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6uOjoPXhOa4hCevD53gRIpDA+qla3Osf5kgF2XePqHI=; b=WECZso2uWS2MXXLZsYcBpCazw87hAemqtgp8SWzcd389sN3Nupa+DtlQeFi/F3Ojii +lZ2NWyX7wVM0mUgBK+6belunpUSRWtOgnI/6+pUesF/RjRnyL+RjMKk2GtrZXTUS3ym mapILMCGK43UGpbQEPp7eQ3ebyLuLrfYgT5SAah1c+KQY8vlbMEwbpSwVKa/Hh8dHKUD NxZv0TeW5MfJDEL4RWCgNC5dKKw0dQSCd9b233Pv8LSL2xSYJHU+sfInMTHgD9ybQVaM hs1OIBR/ws403ph2O1TQfsd/1CPF+1sol872qkSVX9g5gGzbksDMOzdqYDfa5enmEmX3 2HPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735995849; x=1736600649; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6uOjoPXhOa4hCevD53gRIpDA+qla3Osf5kgF2XePqHI=; b=PsOsh4cklnAvQyD1Eu65AG7Yhx5EMoqy9sIB9uBj3h2TVm+iEKuUcmV1Snh4Lml2Ia n164kcz7Rky49R6QUBE2LNr14TFXk+JJ0OsSmExjQ/8ZiCFby9k/lawYY13GE9cpP085 1BzupgSBUBeky8bVWYu9R9aCKffbqZSq/qPJg/Lgm6/nzyM1R3OdtyJCgD0KMsAAKSO7 IY9zbOAkyxAzxgVlGW7Oc4RPCdQ1eK2sCWF75+cvid/fNT43kBvFV/qC4YHMKwgOvprM PgfyHmFLSRlq6NRp6kTLsiA5GFewExjM0X99nL/1ZgicrwDkW9oTCBPisGHs98/93LQc 2ykw== X-Gm-Message-State: AOJu0YwDYyVLYVpKi/GqKsf/ZWyGTuowcAzfuqxwDxbIXRunjCRlUR11 elQEXHapUpcmW1Xb3VoUqPHPsLP7AnZYDY39FYKXQ6fa7XmAvlK1ttXljBtl2XM= X-Gm-Gg: ASbGncs1zy5P93jNvFFFDLC6VEekFsuEL7RZdhJOLGk36JqNccFfZ7nnWhk3scPHaQl pzJwFXtzSZFCQrcIDZmAGsfD5x8sdt37RD+GJkcsecHvnMKM/77bbQeY2j013k0lYt6WEXNa+J2 0fQSsOmqrVvUewuG6+3u2a+CY5AcR6u6/Op/5RX2AhGbbD2TPKjCyrr5SlPWrwLbetoy5MU7WwR rCwqM+t584K9Aiam0v5jZ4BOrWpACBj9+FunDdf+SCEzSW/A6JrcXIsCzYZGLjb2oMYjWPoAbs= X-Google-Smtp-Source: AGHT+IGm4ZZM/9at7bkcQd/V9RvIUO3AGyFSuIANmWEqyK+ZuuzTjaCvSo0SnP9TZiX0nw8N1K0Jtg== X-Received: by 2002:a17:90b:50c7:b0:2ee:c04a:4281 with SMTP id 98e67ed59e1d1-2f452dfb023mr72335598a91.6.1735995848933; Sat, 04 Jan 2025 05:04:08 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4633df7c0sm26306140a91.18.2025.01.04.05.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 05:04:08 -0800 (PST) From: Maxim Cournoyer To: 56197@debbugs.gnu.org Subject: [PATCH] lisp: Introduce lisp-fill-paragraph-as-displayed option. Date: Sat, 4 Jan 2025 22:03:43 +0900 Message-ID: <20250104130343.4801-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Debbugs-CC: eliz@gnu.org, larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Starting with Emacs 28, filling strings now happens in a narrowed scope, and looses the leading indentation and can cause the string to extend past the fill-column value. Introduce lisp-fill-paragraph-as-displayed as a new option allowing users to easily opt out of this new behavior. * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph-as-displayed): New variable. (lisp-fill-paragraph): Honor it, by avoiding the logic narrow to strings before applying fill-paragraph. * test/lisp/emacs-lisp/lisp-mode-tests.el (lisp-fill-paragraph-respects-fill-column): Test it. (lisp-fill-paragraph-docstring-boundaries): New test, as a safeguard to avoid regressions. Fixes: bug#56197 --- lisp/emacs-lisp/lisp-mode.el | 74 ++++++++++++++----------- test/lisp/emacs-lisp/lisp-mode-tests.el | 47 ++++++++++++++++ 2 files changed, 90 insertions(+), 31 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index d0c32d238bc..cc9f6f51cb5 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1,6 +1,6 @@ ;;; lisp-mode.el --- Lisp mode, and its idiosyncratic commands -*- lexical-binding:t -*- -;; Copyright (C) 1985-1986, 1999-2024 Free Software Foundation, Inc. +;; Copyright (C) 1985-1986, 1999-2025 Free Software Foundation, Inc. ;; Maintainer: emacs-devel@gnu.org ;; Keywords: lisp, languages @@ -1431,6 +1431,16 @@ emacs-lisp-docstring-fill-column :group 'lisp :version "30.1") +(defcustom lisp-fill-paragraph-as-displayed nil + "Fill paragraphs as displayed in the buffer, preserving surrounding +context such as the leading indentation. This is useful if respecting +`fill-column' is more important than avoiding surrounding code from +being filled, and makes `lisp-fill-paragraph' behave as it used to in +Emacs 27 and prior versions." + :type 'boolean + :group 'lisp + :version "31.0") + (defun lisp-fill-paragraph (&optional justify) "Like \\[fill-paragraph], but handle Emacs Lisp comments and docstrings. If any of the current line is a comment, fill the comment or the @@ -1480,42 +1490,44 @@ lisp-fill-paragraph (derived-mode-p 'emacs-lisp-mode)) emacs-lisp-docstring-fill-column fill-column))) - (let ((ppss (syntax-ppss)) - (start (point)) - ;; Avoid recursion if we're being called directly with - ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. - (fill-paragraph-function t)) + (let* ((ppss (syntax-ppss)) + (start (point)) + ;; Avoid recursion if we're being called directly with + ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. + (fill-paragraph-function t) + (string-start (ppss-comment-or-string-start ppss))) (save-excursion (save-restriction ;; If we're not inside a string, then do very basic ;; filling. This avoids corrupting embedded strings in ;; code. - (if (not (ppss-comment-or-string-start ppss)) + (if (not string-start) (lisp--fill-line-simple) - ;; If we're in a string, then narrow (roughly) to that - ;; string before filling. This avoids filling Lisp - ;; statements that follow the string. - (when (ppss-string-terminator ppss) - (goto-char (ppss-comment-or-string-start ppss)) - ;; The string may be unterminated -- in that case, don't - ;; narrow. - (when (ignore-errors - (progn - (forward-sexp 1) - t)) - (narrow-to-region (1+ (ppss-comment-or-string-start ppss)) - (1- (point))))) - ;; Move back to where we were. - (goto-char start) - ;; We should fill the first line of a string - ;; separately (since it's usually a doc string). - (if (= (line-number-at-pos) 1) - (narrow-to-region (line-beginning-position) - (line-beginning-position 2)) - (save-excursion - (goto-char (point-min)) - (forward-line 1) - (narrow-to-region (point) (point-max)))) + (unless lisp-fill-paragraph-as-displayed + ;; If we're in a string, then narrow (roughly) to that + ;; string before filling. This avoids filling Lisp + ;; statements that follow the string. + (when (ppss-string-terminator ppss) + (goto-char string-start) + ;; The string may be unterminated -- in that case, don't + ;; narrow. + (when (ignore-errors + (progn + (forward-sexp 1) + t)) + (narrow-to-region (1+ string-start) + (1- (point))))) + ;; Move back to where we were. + (goto-char start) + ;; We should fill the first line of a string + ;; separately (since it's usually a doc string). + (if (= (line-number-at-pos) 1) + (narrow-to-region (line-beginning-position) + (line-beginning-position 2)) + (save-excursion + (goto-char (point-min)) + (forward-line 1) + (narrow-to-region (point) (point-max))))) (fill-paragraph justify))))))) ;; Never return nil. t) diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index da02be65d03..347b3d5b642 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -308,6 +308,53 @@ lisp-indent-defun (indent-region (point-min) (point-max)) (should (equal (buffer-string) orig))))) + +;;; Filling + +(ert-deftest lisp-fill-paragraph-docstring-boundaries () + "Test bug#28937, ensuring filling the docstring filled is properly +bounded." + (with-temp-buffer + (insert "\ +(defun test () + \"This is a test docstring. +Here is some more text.\" + 1 + 2 + 3 + 4 + 5)") + (let ((correct (buffer-string))) + (emacs-lisp-mode) + (search-backward "This is a test docstring") + (fill-paragraph) ;function under test + (should (equal (buffer-string) correct))))) + +(ert-deftest lisp-fill-paragraph-as-displayed () + "Test bug#56197 -- more specifically, validate that a leading indentation +for a string is preserved in the filled string." + (let ((lisp-fill-paragraph-as-displayed t) ;option under test + (source "\ +'(description \"This is a very long string which is indented by a considerable value, causing it to +protrude from the configured `fill-column' since +lisp-fill-paragraph was refactored in version 28.\")")) + (with-temp-buffer + ;; The following is a contrived example that demonstrates the + ;; fill-column problem when the string to fill is indented. + (insert source) + (emacs-lisp-mode) + (search-backward "This is a very long string") + (fill-paragraph) ;function under test + (goto-char (point-min)) + (message "%s" (buffer-substring-no-properties (point-min) (point-max))) + (let ((i 1) + (lines-count (count-lines (point-min) (point-max)))) + (while (< i lines-count) + (beginning-of-line i) + (end-of-line) + (should (<= (current-column) fill-column)) + (setq i (1+ i))))))) + ;;; Fontification -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 08:04:40 2025 Received: (at control) by debbugs.gnu.org; 4 Jan 2025 13:04:40 +0000 Received: from localhost ([127.0.0.1]:53847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU3pX-0006yR-An for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:04:40 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:61657) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU3pU-0006yI-M5 for control@debbugs.gnu.org; Sat, 04 Jan 2025 08:04:37 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2166022c5caso161668265ad.2 for ; Sat, 04 Jan 2025 05:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735995875; x=1736600675; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=hA6+fVEfGF+u0/8VP7+hz6LDvquNi2S/EHq8Owt2Fkk=; b=nV/0hmREI1kYwz2Rz8DWMl+iZxj2oVcEHUshC4kSQ+9/TydINtbUYoxl7WWclO2waW 4dawwtxZgmGs06EyCpg4/viUbKXeezwMPdNSh9JqZ6wLueYt3usodyJpvYVKwLvSKemp qCDVtQxDXrd1hqggVn8dRJ+88y2C7mh1toxnLY0ZjUWLP5UmbJHfaYAbck4hAtWhAJlE A/dPk9oZh/je2pX5bRvgBX/Ga1IKAz/8tRjhAeOd/8IF4At/xnRqF/9s5k7QfCJFT1iB 7jTymvKXuGWd0m/r9VCClM1WPFqllGbofbChh8Vh/DNcJyAdvoK65sNOur0QcP4EzuZa ad3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735995875; x=1736600675; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hA6+fVEfGF+u0/8VP7+hz6LDvquNi2S/EHq8Owt2Fkk=; b=WAbycuMOcJ0rZVIMbWGVImRCXmMxs/HubonA4RvRm6Vkq3dDccrm8Eygqs4kjmvZdb 2L5XWsSGXvpBIamz0xW2+7RATxqFzTPnIjSI+nDr+LU/KPFjd5vea5hev4s8KS+8Q+2d NVk0TUOHVj/bCWRjnOUZ6EZVVSAg+2R5bIchS9+vjs0JQS4cL6c+VL1magPKoTOJjw31 4WQX0xg6nG+VRnORpdf128ka3hV9ZvNqJ2fynX+cMmdkfgXwEVP5sjJYuJhJ2nHnejNM nKvxADJkH+2slrV+XpqfuURGeCn/yjjV3vLQiCsjrVkLMSkpkIIxmTtKI1uR0iGaEMCw 4fNw== X-Gm-Message-State: AOJu0YwcUrfwN5X78Z9CCs+nvM2Wa79IKLbmY9XB7lc3vsKGmGkaK3Ut dgOKMR+gaJ3l2fx3dqyNJdP/znw9ouslW1v2yVEJV7ex5EOcJR31sxEkGjhzHJw= X-Gm-Gg: ASbGncvHB+n4rWnkptglbtIHtX7s1UFk1nrPeEN1SLNpT1HhBX/bbWdkYQN1Mg0nQAG +vxmbYD+WTE5VfafsiXpv89GLlchxsZzEMzrwSm+R/hsQxSnvksIGIPT1A4RAG0DqJ6uGpzUlRw t2bQc0brR3+O85axqyz9vJJQrVkLVO/ibe8JW6+H3ruFj94XGmerT//LBNvSLA3OF8wP+mwxCxt rvU8xatMyytUVUNDmihApYXhLnP53nmlUB6GYolhF8lo7tMf+JMeQ== X-Google-Smtp-Source: AGHT+IGWwaYkn7qazlx4Pb7vl2jZIE0LjY8zmDIe5axvfbXDoqMjKdWnkMIq+YnxMXZ36coicDCBFA== X-Received: by 2002:a05:6a21:999e:b0:1e1:1d7c:4cff with SMTP id adf61e73a8af0-1e5e08184a0mr87700771637.37.1735995874674; Sat, 04 Jan 2025 05:04:34 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad830afasm27945001b3a.49.2025.01.04.05.04.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 05:04:34 -0800 (PST) Date: Sat, 04 Jan 2025 22:04:24 +0900 Message-Id: <87pll2enmv.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #56197 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 56197 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 09:03:00 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 14:03:00 +0000 Received: from localhost ([127.0.0.1]:53973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU4k0-0001DX-2e for submit@debbugs.gnu.org; Sat, 04 Jan 2025 09:03:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37118) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU4jx-0001DJ-CW for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 09:02:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4jr-0004IU-6C; Sat, 04 Jan 2025 09:02:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OFp1boiT5xZL7E2s6ubHlJHu1QhqJSUgpJeL4bbzSRw=; b=rVfmUrntqxKd 30iRN6nM4uHdnRKTEUjvwU0o2AaZZZHMedK1I40GmiB/MDaZATETyf4HHjOHXUhPZ0NMh3W7IqR3k IeH9MsbD765xkPma1bR1rR1egPK1UE0USQOIj8pIFX0grts5hKALneoUVWLdLnee8FCTj3ccwIx3n sI/+NqV4cMIKSl9iupj0sn+goiwAuy+6Cmbn0N2ajsuUxhxP2oV3ymUHYsNy/eKBdlLwlB6MMGV6X URpV6ctqmr2peIzsbhyMD45dwz/oH6uZCXlK3lPvHhJMMY2KIpn7xOW0yLTa1pEVvEgnrvoL77e9M IdNq3HbbKGexTbRya5nzLg==; Date: Sat, 04 Jan 2025 16:02:46 +0200 Message-Id: <86frlyd6d5.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <20250104130343.4801-1-maxim.cournoyer@gmail.com> (message from Maxim Cournoyer on Sat, 4 Jan 2025 22:03:43 +0900) Subject: Re: bug#56197: [PATCH] lisp: Introduce lisp-fill-paragraph-as-displayed option. References: <87zgi2xcgm.fsf@gmail.com> <20250104130343.4801-1-maxim.cournoyer@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, felix.lechner@lease-up.com, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Maxim Cournoyer , eliz@gnu.org, larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com > From: Maxim Cournoyer > Date: Sat, 4 Jan 2025 22:03:43 +0900 > > Starting with Emacs 28, filling strings now happens in a narrowed scope, > and looses the leading indentation and can cause the string to extend > past the fill-column value. Introduce lisp-fill-paragraph-as-displayed > as a new option allowing users to easily opt out of this new behavior. Thanks. But this is not a user-level problem, so the variable to control this should IMO be a defvar, not a defcustom. Then Lisp programs which need to get back old behavior for some reason could bind the variable around the call. P.S. I don't see your copyright assignment on file, so if you want to contribute such large changes, let's please start your legal paperwork of assigning the copyright to the FSF. OK? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 09:04:47 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 14:04:47 +0000 Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU4lj-0001Go-6m for submit@debbugs.gnu.org; Sat, 04 Jan 2025 09:04:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51096) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU4lg-0001GY-Nv for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 09:04:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4lb-0007jR-DS; Sat, 04 Jan 2025 09:04:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fYorwKKVV0PtYXfEDLZhYH8Ydaxfvhv8w9xClwaDCIA=; b=mTXYPLyWAMwI rtGSHnrCPSNcJkhBP6bkrZzULmt9C6dTXmddAJ9C/lFPc5fNfgClshqUeyHcPUvkUurpCrddzBmj6 R9Xvk2VB7EC8RUv00MKo8PasL74m4s2ypDV/r9Mw/3+XU/+KwlJiGnTKRDzgV5QaMzSHrH3+gLzuJ fzX5nSUO/OjYs8rwzVoxrmQopiwK+pnWG/oz9pJ/mV0L+vARTIzlYZ8hEHys0qeIEcc6QLg9MIz8S 6Od2U2kXXZKT9FupwGRhRiyOocCisSO9WcT+/IIMszEh/yUBmtaw8YRW/dUzo30BKxVtrdkJ9dr2J fbD6BXHPo2KZFz0Lbbnt1A==; Date: Sat, 04 Jan 2025 16:04:36 +0200 Message-Id: <86ed1id6a3.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <87v7uuevq1.fsf_-_@gmail.com> (message from Maxim Cournoyer on Sat, 04 Jan 2025 19:09:42 +0900) Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> <87ttanrg9h.fsf@gmail.com> <87v7uuevq1.fsf_-_@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, > stefankangas@gmail.com > Date: Sat, 04 Jan 2025 19:09:42 +0900 > > >> I don't see how a user option to control this could be useful, since > >> the preferred behavior is not only buffer-local, but also specific to > >> certain syntactic constructs. But I won't object to having such an > >> option. > > > > Having the behavior defined per-project or even globally (reverting to > > the the pre-Emacs 28 behavior) via a simple option seems like it'd > > simplify things, and make them discoverable. > > I tried fixing this generally, as it seems to me that something in > lisp-mode should be meet the needs of all lisp-derived languages such as > Scheme and not just Elisp. I first added two tests, one of which > ensures no regression to the original bug that lead to this current > behavioral change (bug#28937) and the other one that should pass once > the issue reported here (bug#56197) is resolved. > > The last patch is a WIP that didn't work; I was hoping that inserting > spaces corresponding to the width of the indent in the narrowed string > would cause the indent to be preserved only for the first line. I don't > have other ideas at the moment; I'd appreciate if someone could tip in. Since you submitted a new bug report about this issue, does that mean these comments and the patches are no longer pertinent? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 09:19:41 2025 Received: (at 56197) by debbugs.gnu.org; 4 Jan 2025 14:19:42 +0000 Received: from localhost ([127.0.0.1]:54037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU508-0001x9-Iz for submit@debbugs.gnu.org; Sat, 04 Jan 2025 09:19:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35254) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU504-0001wt-VC for 56197@debbugs.gnu.org; Sat, 04 Jan 2025 09:19:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4zy-00057b-Vn; Sat, 04 Jan 2025 09:19:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=71SitwnFM98lIcR6LE4GuA081pH+oo6O2rwvyY/K7qc=; b=Li4+AgDOc+Ix Wku70xLQreDja9ucqPkl0Biw2G8xpp0I9hCJ5huG5Y+I1yjYt4eZ+nxIWaSRFQCtivkbQE9yg7dqZ YAHLJs3q2UO+YSxl+Pv1YYHR8tINvZC7E2O/S1mNsVKXHXanRDtyPW1dU6i/fWTGIOJimMYnIieJV 1YAgibzN5DLyqHy2/KKLIIThz9AV4wM3utPThAFhAiI47wQy5yFw6LyCAp9lHXHBS0O6vAmBqGwXO TWRepW6xQ6fI7NntIBdSoEW5PPgsLBdmskQwKWaq2mdp4u21twppLM45arbMhRKLfW+sIgRcv2qx9 JwaCeK33BtyJZ8ZmGobn1w==; Date: Sat, 04 Jan 2025 16:19:27 +0200 Message-Id: <867c7ad5lc.fsf@gnu.org> From: Eli Zaretskii To: maxim.cournoyer@gmail.com In-Reply-To: <86ed1id6a3.fsf@gnu.org> (message from Eli Zaretskii on Sat, 04 Jan 2025 16:04:36 +0200) Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> <87ttanrg9h.fsf@gmail.com> <87v7uuevq1.fsf_-_@gmail.com> <86ed1id6a3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, > stefankangas@gmail.com > Date: Sat, 04 Jan 2025 16:04:36 +0200 > From: Eli Zaretskii > > > From: Maxim Cournoyer > > Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, > > stefankangas@gmail.com > > Date: Sat, 04 Jan 2025 19:09:42 +0900 > > > > >> I don't see how a user option to control this could be useful, since > > >> the preferred behavior is not only buffer-local, but also specific to > > >> certain syntactic constructs. But I won't object to having such an > > >> option. > > > > > > Having the behavior defined per-project or even globally (reverting to > > > the the pre-Emacs 28 behavior) via a simple option seems like it'd > > > simplify things, and make them discoverable. > > > > I tried fixing this generally, as it seems to me that something in > > lisp-mode should be meet the needs of all lisp-derived languages such as > > Scheme and not just Elisp. I first added two tests, one of which > > ensures no regression to the original bug that lead to this current > > behavioral change (bug#28937) and the other one that should pass once > > the issue reported here (bug#56197) is resolved. > > > > The last patch is a WIP that didn't work; I was hoping that inserting > > spaces corresponding to the width of the indent in the narrowed string > > would cause the indent to be preserved only for the first line. I don't > > have other ideas at the moment; I'd appreciate if someone could tip in. > > Since you submitted a new bug report about this issue, does that mean > these comments and the patches are no longer pertinent? Sorry, I should have written "new patch", not "new bug report". From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 23:51:52 2025 Received: (at 56197) by debbugs.gnu.org; 14 Jan 2025 04:51:52 +0000 Received: from localhost ([127.0.0.1]:53580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXYu8-0001nY-Df for submit@debbugs.gnu.org; Mon, 13 Jan 2025 23:51:52 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:55339) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tXYu6-0001nJ-65 for 56197@debbugs.gnu.org; Mon, 13 Jan 2025 23:51:50 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-21636268e43so117736335ad.2 for <56197@debbugs.gnu.org>; Mon, 13 Jan 2025 20:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736830304; x=1737435104; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pi8cbftTt5XVbH5FOafLD/qrb2t29rnFj4nzhKoVHFQ=; b=MVqZuu+UpbAalcMgJIorJWQFvqv/mRmbowtSsx4EXjeiw59P7Zcd1s7Nx+hhZngaL6 mUj5VVzeQbOqar0XiLx/SFt3bDHyK6TJd99AV/4tVOBRzxDkVakz+2onfu0Kkg8AsaJ6 pSQEu5cDvBUBQgj2nJ8wuiq6ycD22xCpC9ksKhpVmJo6+8mGyE/WP0OBHRLT9MtiX3Uk fRioR0/V9ZFZBTqgVZYVY4fQxWC1yAAqpmqflnNYUjPCSV+NUswG6mr+pG33kl8eXH+9 rrYmNFBcEGm1HXHsB+D5unoN0rQsbrP1jDHmExB0DEckv0WcCY1nE87z/rU7Slov6YwZ X6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736830304; x=1737435104; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pi8cbftTt5XVbH5FOafLD/qrb2t29rnFj4nzhKoVHFQ=; b=FWT590L3rzJszF33n160xTJkWd0htTC1eRt71v00MRV/vqbXulw1ut6c80T+FWNkOW Alh+KspVTWCNPr250DXJn3csrPpy3hAkLK1813aNN7eRzZUtY38LabHzmTVispiP0twa aRjP+YNEUQH1UjVIVmZkden/f7WeAAwBz0pobNyTFi52UZWUkubYNX5xG+ZreJummedf KSlw8iKdh9dVmcMo/tHb4tb3Cbije0TzudmUCazipszjhNFXk39+f55YAsX09wdbRZ5A BQPKLXJNaYAZnTMKnoEXscIYqknXcfaLu10fB2Ouf241pGjmbzGWNBg3m3FmUl8flFNm SwQA== X-Forwarded-Encrypted: i=1; AJvYcCUvKo36Ni/bW5CY2MKJBjz2eTNGvWnlxFV9rHhJ/T/iKFv0uEysVOOT/uOe7uN7qnwe9j22xw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxqcZFOtj6KxGglZGQym+cH+0OkQI+1ugSSkGetYF4mdcf5m2x5 Kz4GDaJFHeFNs8HqPMoD0H1iSYfPnovfY/3BeRly0LW8Da3IntEZ X-Gm-Gg: ASbGncvMXr60k+T2ifQmDqCO8Zdp1iaFiysLq+J5N3sLW6puerlh+iuagloThd/q5sc NRCG9Q+4niHMDs8w46nrWKR+UpMVON2XIxt2wL7X7RkE+UdU4plDEBsvxCgFarV341M4eY2zDR5 9RSjft/yEtakjqVXiIs1i3jhVCD7sWI6wX+UGflxzWAukojvYrL3+dxtfc/wRIlLifVCNXZ+J/W LzoscDUYa97EjOVuXaUBFIXOgrtZ6wUHdyanwgjW6RYxjfq+ZGmJw== X-Google-Smtp-Source: AGHT+IEgWjnMp3h4x/HMAsipwXXEploMwMMQ9q8c3T+FcZUk1+HEm512iQU4nFH1iksa8rZDMwISlw== X-Received: by 2002:a17:902:c941:b0:215:7fad:49ab with SMTP id d9443c01a7336-21a83f46a12mr391805625ad.10.1736830304050; Mon, 13 Jan 2025 20:51:44 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f22d134sm60373615ad.187.2025.01.13.20.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 20:51:43 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 In-Reply-To: <867c7ad5lc.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jan 2025 16:19:27 +0200") References: <87zgi2xcgm.fsf@gmail.com> <87y1xlj6wn.fsf@gnus.org> <834k08c3se.fsf@gnu.org> <874k08kj31.fsf@gnus.org> <87y1xkj4co.fsf@gnus.org> <87tu88j3tf.fsf@gnus.org> <87bjwzr027.fsf@lease-up.com> <86v7v7ynf0.fsf@gnu.org> <87seq8tm2f.fsf@gmail.com> <86o70wurf9.fsf@gnu.org> <87ttanrg9h.fsf@gmail.com> <87v7uuevq1.fsf_-_@gmail.com> <86ed1id6a3.fsf@gnu.org> <867c7ad5lc.fsf@gnu.org> Date: Tue, 14 Jan 2025 13:51:32 +0900 Message-ID: <87h662dmln.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: [...] >> Since you submitted a new bug report about this issue, does that mean >> these comments and the patches are no longer pertinent? > > Sorry, I should have written "new patch", not "new bug report". Yes, the last patch I've sent is no longer a WIP and addresses the issue for me (while improving the coverage of the test suite). Please have a look when time allows! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 00:05:17 2025 Received: (at 56197) by debbugs.gnu.org; 16 Jan 2025 05:05:17 +0000 Received: from localhost ([127.0.0.1]:59568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYI4C-0005DR-FK for submit@debbugs.gnu.org; Thu, 16 Jan 2025 00:05:16 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:59518) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tYI49-00058O-CN for 56197@debbugs.gnu.org; Thu, 16 Jan 2025 00:05:14 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-21675fd60feso9837295ad.2 for <56197@debbugs.gnu.org>; Wed, 15 Jan 2025 21:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737003907; x=1737608707; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gpxZVdNf2njDuqj7oE4CF+nFrESk84Afv0Qk9US2E7Y=; b=ZV97H79XxZehGmob3VIWcODArqVPS4/1MHf9C3TNZ5fpYzhE6ZMjO3U4Rw4H3mXOI+ yaWVF85+BuQUlIGHGvtO0YajCXIvUCjvdFTzA1mG+12XWvuEusxaRA5CcCo9rX+pSfXg 2i5nZ8yITtZPioOnH+Otl20+SSEVagpyv3XNxOImq+8tf42oaZ4wCFhSXJuhuKJsDj08 IGG6TylRGST8H7ctD1gr6XvbqOWjlbORCt28YMjeYaRsCfVbg1ttHOZlgYFLLrcunWZG FJfqv0cbSZGQnppdVQN4l1U17C/SDnoAyEhwMQj4/HcOCaXzFVkE92yRbywsHEkyG86h Ho4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737003907; x=1737608707; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gpxZVdNf2njDuqj7oE4CF+nFrESk84Afv0Qk9US2E7Y=; b=UglaUY1OV5pSTfFFUwBw3ZBltGh6hFTaUr2u05gIOieTfiQNdfSB4fGNcBmz81lk+R tPzMNsxVW1r325fRYHAAOr2/VEyc3T/ADynCm1tRVAPmNNh1wqBRZiCfsGuVvOScHACR Hk2VwN3xNbeK6C6OxZ1Q9KipLMf/iwunZzwHIsGwPWuFqB8y7V2oJqvcs6Mmk2iJxj9y JeGbFMSUu02EKCPIj2jgmMIdczxpKpiK1d0LL7dPXjjPHFs8ZLI6RVnALIcdGVS9L2wp 3lTFBgMR+T9gZ+piRIcToRrRIPd0+3mwShTlfoxajbmSnY5YScSeRQJt0bIYf9nT1SCQ GLlQ== X-Forwarded-Encrypted: i=1; AJvYcCVfwt+77TEbAySOzGmMS7U0eKxKqwn7qCk2wwzAGSQ1dXyO8SEeEV95kYTJWBdlN/dMot3RhA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywtub/NgGSIEc+XHNnpftRJ2a57Iz/3TKdisk/bsfhk5q7Rsbqv N7g9oo67ssKWdfpUJwZyOFQ09HgRX7rdz+14ERhhceEk+JBqpPtF X-Gm-Gg: ASbGncssTATCN5HhU9m9MY7/V+yJXfuycp4BHjPoowlTKgRA0qVZzZBrOdNwuM2Nqvy LM5xg8FauN17Q9vFt+88RKjXJPwE23gd4NnIJb5j/Bo6dcOfKlFpCt4m0ngg8ShJAohjpbUXWnN Qk6adBO76SsBT+P85Ao10L8v9fBBrCZd0WW1tnINAyTqyvUOef3i2mVtQsGnZ0GELofMUz3aYLX Ujr265LfZ6P/42WUJSSv1pqonDlpqynCbruIgEJ1mXx+LPvl6ADPA== X-Google-Smtp-Source: AGHT+IHJGFlYs+2JoT4cJae/G8+rt9TG5gtpDdSXUQPH5TrOrhMkwQfhYJsoB1EsLTMUvdGqjEXaog== X-Received: by 2002:a05:6a20:158a:b0:1e5:dace:693f with SMTP id adf61e73a8af0-1e88d13b50fmr51172988637.4.1737003907207; Wed, 15 Jan 2025 21:05:07 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a3193921675sm10454194a12.40.2025.01.15.21.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 21:05:06 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 In-Reply-To: <86frlyd6d5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jan 2025 16:02:46 +0200") References: <87zgi2xcgm.fsf@gmail.com> <20250104130343.4801-1-maxim.cournoyer@gmail.com> <86frlyd6d5.fsf@gnu.org> Date: Thu, 16 Jan 2025 14:04:55 +0900 Message-ID: <87ikqfcps8.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: >> Cc: Maxim Cournoyer , eliz@gnu.org, >> larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com >> From: Maxim Cournoyer >> Date: Sat, 4 Jan 2025 22:03:43 +0900 >> >> Starting with Emacs 28, filling strings now happens in a narrowed scope, >> and looses the leading indentation and can cause the string to extend >> past the fill-column value. Introduce lisp-fill-paragraph-as-displayed >> as a new option allowing users to easily opt out of this new behavior. > > Thanks. But this is not a user-level problem, so the variable to > control this should IMO be a defvar, not a defcustom. Then Lisp > programs which need to get back old behavior for some reason could > bind the variable around the call. I'm not sure. A user (such as myself) may prefer the old behavior, and customize lisp-fill-paragraph-as-displayed (setting it to t) so that this behavior is now the default everywhere. It also makes it more easily discoverable. So unless you see a strong reason against using defcustom, it seems preferable to me than defvar. > P.S. I don't see your copyright assignment on file, so if you want to > contribute such large changes, let's please start your legal paperwork > of assigning the copyright to the FSF. OK? That's fine; I'm happy to assign my copyright w.r.t. Emacs changes to the FSF; please send the paperwork over! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 03:22:42 2025 Received: (at 56197) by debbugs.gnu.org; 16 Jan 2025 08:22:42 +0000 Received: from localhost ([127.0.0.1]:59918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYL9F-0001Hu-Jv for submit@debbugs.gnu.org; Thu, 16 Jan 2025 03:22:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38120) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYL9C-0001He-4K for 56197@debbugs.gnu.org; Thu, 16 Jan 2025 03:22:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYL95-00038v-P7; Thu, 16 Jan 2025 03:22:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XpJ5xR1dTVGcQPmSI6LojDBks67xxl1Ya9GcCyHXXuU=; b=SPfNwtDv6YlU sBD7QDsNOJO3Rk7wTk1/LfnryZNJe9h7+Yf19YKQ+g09CfHzLqlfI8Hz+iM/UGQn0zWrxJFwuW8g7 Npv7yD3K73DhIa6txW2nfaGb6KWYYFQtGJ/mR6RSS7QabKAhS+fsz9G6Pkc+WWlemB25nBCVOSyZI GI6YQb2E8BcZ3vghJdsRXtv81M49hT1dsEP1FTQZieKvv5JMQdOdvTdWopeWFnCtuopddkxMraojQ UJe1RKU8p67JLIvKGv4Ybm+x6jBOfLQSXxbWa7gf22wOdERwuGFlwYwnyC1eOOkzvzHKUjOOlZ7q5 oGk8QFK2Wl+h3R+cEc/Wbg==; Date: Thu, 16 Jan 2025 10:22:27 +0200 Message-Id: <86ikqfi2ws.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <87ikqfcps8.fsf_-_@gmail.com> (message from Maxim Cournoyer on Thu, 16 Jan 2025 14:04:55 +0900) Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 References: <87zgi2xcgm.fsf@gmail.com> <20250104130343.4801-1-maxim.cournoyer@gmail.com> <86frlyd6d5.fsf@gnu.org> <87ikqfcps8.fsf_-_@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: larsi@gnus.org, felix.lechner@lease-up.com, 56197@debbugs.gnu.org, > stefankangas@gmail.com > Date: Thu, 16 Jan 2025 14:04:55 +0900 > > Eli Zaretskii writes: > > >> Cc: Maxim Cournoyer , eliz@gnu.org, > >> larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com > >> From: Maxim Cournoyer > >> Date: Sat, 4 Jan 2025 22:03:43 +0900 > >> > >> Starting with Emacs 28, filling strings now happens in a narrowed scope, > >> and looses the leading indentation and can cause the string to extend > >> past the fill-column value. Introduce lisp-fill-paragraph-as-displayed > >> as a new option allowing users to easily opt out of this new behavior. > > > > Thanks. But this is not a user-level problem, so the variable to > > control this should IMO be a defvar, not a defcustom. Then Lisp > > programs which need to get back old behavior for some reason could > > bind the variable around the call. > > I'm not sure. A user (such as myself) may prefer the old behavior, and > customize lisp-fill-paragraph-as-displayed (setting it to t) so that > this behavior is now the default everywhere. It also makes it > more easily discoverable. So unless you see a strong reason against > using defcustom, it seems preferable to me than defvar. Users can also set a defvar, if they want this globally. However, the original problem is not a global one, it is specific to some situations in some particular major mode. The important question here is: how common is the situation where a user will prefer to set that globally? I think this could only happen if the user uses a major mode of just one variant of Lisp-like languages, and especially if that one variant is not Emacs Lisp. In addition, making it a defcustom means Lisp programs cannot easily bind it to specific values when they need it (overriding user options is considered unclean in Emacs). So my preference is to introduce a defvar, and only promote it to a user option if we have enough demand in the future. > > P.S. I don't see your copyright assignment on file, so if you want to > > contribute such large changes, let's please start your legal paperwork > > of assigning the copyright to the FSF. OK? > > That's fine; I'm happy to assign my copyright w.r.t. Emacs changes to > the FSF; please send the paperwork over! Will do, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 07:36:05 2025 Received: (at 56197) by debbugs.gnu.org; 19 Jan 2025 12:36:05 +0000 Received: from localhost ([127.0.0.1]:45187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZUX7-0004FL-22 for submit@debbugs.gnu.org; Sun, 19 Jan 2025 07:36:05 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:57622) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tZUX4-0004Em-Bi for 56197@debbugs.gnu.org; Sun, 19 Jan 2025 07:36:02 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2ee9a780de4so4604638a91.3 for <56197@debbugs.gnu.org>; Sun, 19 Jan 2025 04:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737290156; x=1737894956; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ndwAZNQd27uGztU2b6NDkMaJRsxFFYDBoOT1VslKYE8=; b=b5rKTWsW+TJI8NtI9ueh4YZOO20grd0dLRdlw64z/xiUuqW98HlVEJSOatv9nvmrKN lv52M6t97QncyfaMZ3aK35UpCykFRq+CBXxdlSZ5vfArDNBjk9ULXmoRxb6DzCfEKw4R AYtXopeiGCBodyIn2+8N3WBOGmGgnvyS8NpMdhFQ8hKqxDfTEXN6UVI0wcMyIkN5f7M6 dlZNdxhHjrPOKAzjL6w3ygGg6Ud2MtycqfQHEAoKOLi9nO4fvq5XgGaLkgM+h20jPAy7 y92deSPgZe1PO+i+o6BtU2yjZSGXa3DfxYfuco7cMDWsaMXIqHKezHK3Qmgo7/LA11uR RkuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737290156; x=1737894956; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ndwAZNQd27uGztU2b6NDkMaJRsxFFYDBoOT1VslKYE8=; b=jsQinSy0469gKFHdS1Bj7ub/t2i5DQNP6jQKIJkOdDWOOh2pt1Yw4uX5RoMZT+Istf HjIhr6BUaidyhAcaxDD4wFR5N2d6rO2g8JQDyT38R6jE2SKin6SpFyaZf61TPi6X0ceN 3t/Oqh98jo68rv+cHGLzUqMS4MJm2umu6CPrYGfjiFVLhyht0zHt020AEhMDgKSjwg8e ++NQatScMzDVF9ETQkbvN31rjTQCvTvYZXAhH8ixt2hWBisMyrKGf9eIHhIitfoFGD3s yD9JuswDnrKWf5jxXsGSAmd2jML9WVe8JAVw0Zf9sYwvg9O7A1Sc1cCGaxoAN3YNN154 RtzA== X-Forwarded-Encrypted: i=1; AJvYcCVr9U70AYUhnLDz3wU+U2+xgFKbcL/p174oTwFIYSADMzRwNeFuXrWzQewiA9jGdXvXCliLPA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywc2i1aY+rPqT2XIJraHn9wf53WrzE5fo/9lxpkQZNmBAUx8Mgz aUT+0iDncnPL6WELsO9ezWG+K6OfrBrIUcjJJZTXMtGPn/5iY/xF X-Gm-Gg: ASbGncvifSSSmdF5/mldVB3qyb8JaXPscTMgelPjMDp7VDtsFn6r5vcznJE+sFcZa/w W9L117tpYlOm8fjgkymAdUPPcqffaPYOcTZLSFB8JJMFgILFk424GNJwuCV6E2kdRKsMQDGfVpH y/riK4I0NKdoEA9DQkCrwXEUtyLoSqkjm2lbqC3EV3dACOB3BvzlmdQmNAeSOBBjOXGgNVoVaDg S377R16sjisb9W0VmsMzNonOpjkxIyexhmjNeItYYQG/QCI0vecbK8QbNuo476PwV0= X-Google-Smtp-Source: AGHT+IEOl8CJv5xiJ3grgUXpNf1keAWsaW9IYwn4ilDop7HELECX8fObN7FHTkm5VI9R73HPOz46Dw== X-Received: by 2002:a17:90a:c888:b0:2f4:f7f8:fc8a with SMTP id 98e67ed59e1d1-2f782d8cd4emr14618270a91.33.1737290156098; Sun, 19 Jan 2025 04:35:56 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f72c15bf82sm8800033a91.7.2025.01.19.04.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 04:35:55 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: bug#56197: lisp-fill-paragraph behavior changed in Emacs 28 In-Reply-To: <86ikqfi2ws.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Jan 2025 10:22:27 +0200") References: <87zgi2xcgm.fsf@gmail.com> <20250104130343.4801-1-maxim.cournoyer@gmail.com> <86frlyd6d5.fsf@gnu.org> <87ikqfcps8.fsf_-_@gmail.com> <86ikqfi2ws.fsf@gnu.org> Date: Sun, 19 Jan 2025 21:35:44 +0900 Message-ID: <87msfn6kwv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Eli, Eli Zaretskii writes: [...] >> > Thanks. But this is not a user-level problem, so the variable to >> > control this should IMO be a defvar, not a defcustom. Then Lisp >> > programs which need to get back old behavior for some reason could >> > bind the variable around the call. >> >> I'm not sure. A user (such as myself) may prefer the old behavior, and >> customize lisp-fill-paragraph-as-displayed (setting it to t) so that >> this behavior is now the default everywhere. It also makes it >> more easily discoverable. So unless you see a strong reason against >> using defcustom, it seems preferable to me than defvar. > > Users can also set a defvar, if they want this globally. However, the > original problem is not a global one, it is specific to some > situations in some particular major mode. > > The important question here is: how common is the situation where a > user will prefer to set that globally? I think this could only happen > if the user uses a major mode of just one variant of Lisp-like > languages, and especially if that one variant is not Emacs Lisp. Good point. The current behavior is probably useful when editing Emacs Lisp, so I agree that setting this precisely for specific modes (such as scheme-mode) instead probably makes more sense. > In addition, making it a defcustom means Lisp programs cannot easily > bind it to specific values when they need it (overriding user options > is considered unclean in Emacs). > > So my preference is to introduce a defvar, and only promote it to a > user option if we have enough demand in the future. OK! I'll send a reworked version using defvar shortly. Thanks for the thoughtful discussion! -- Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 07:53:17 2025 Received: (at 56197) by debbugs.gnu.org; 19 Jan 2025 12:53:17 +0000 Received: from localhost ([127.0.0.1]:45205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZUnj-0004wV-S2 for submit@debbugs.gnu.org; Sun, 19 Jan 2025 07:53:16 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:43093) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tZUnh-0004wC-Df for 56197@debbugs.gnu.org; Sun, 19 Jan 2025 07:53:14 -0500 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2ee50ffcf14so7314650a91.0 for <56197@debbugs.gnu.org>; Sun, 19 Jan 2025 04:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737291186; x=1737895986; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KkRLvRNoLhtFH6/7GocXPbiv9lWYWjnrBMTvIgSGdVU=; b=NrsE3BepdeDF7erzntV7Azy0lwvUQLb+2xBmUpYDaCXn5RLDUGPFqb0EiAQ+SbGJh+ zk7hKMqI3h1uINXSYdU5hMxbk6T/AvjMPMuSjWmPANRddG5dcNwSaFPevzqelwHNfnZ+ wvLqXErRsHFTzVLhlvJbhiNCh/CJjkMlxdcKlhzKOd/Kc9qHnvBOKFbIePBZFjWuzQfG IOstwBT4OFed9jAfnIhesyVqXNKXH5lz6OPgZxYNt9OStfBUoD7eGEgMLjMvCRjq5a9O AzqcDz6qg8PzFvVgM3kNaYZ6HGPyYGThBuTJUbQdlPRuAJ4T/XsZerFIcVOK7o2lzEr8 6f1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737291186; x=1737895986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KkRLvRNoLhtFH6/7GocXPbiv9lWYWjnrBMTvIgSGdVU=; b=T6hHgJpki5ni36KLEbYaK5GF14FwKXZBOwrawu1CLRWK8t3iq//bcVQ1DataiUmCTS BLK7XjR4Wl2EJqzesen89nFS8//C0HvhvvaEBjaHZlvLMrvXP4J5px45+K4wiqvUQ46G 9PJXUMbxjFw9HptT6CvfMRrvpqCFurj1Pm2Oro3ONW1e1u9bByHQwZ/OyfQcKSKfI8Z7 wOolW5Vt4EhoYfmtB7qgXBVeli1uBUH5BUgJ+2qb4FV4UUHKBYEGSMl/CUhxB11fiqMY Jh/b12QA92R5Z0pRmT3jkP3+t6tcfUXvnQnicFXKCUd8+JmIQq5yPtMvx32HNJDYjHil rXwQ== X-Gm-Message-State: AOJu0Yx9waqL3I3VsfJT4fc69N5KMx5dpZccvRYXn7FLSl7Kd4iJ9aBA xfgXSvf9A1NfG1GmSwA+dwV7JFe8/jQUz/jPfXApb7l/bMT+Fa5ZimFOCh9Ki2M0Gg== X-Gm-Gg: ASbGnctqks0drCv+m50SrMr7nTpfu22FZDsuJSEalMPfEmXjmatIxcBi9pJwmtbstbS LuIXLHp1HEsNgI3OUtKqDFBCNIU4fptwuLzQeqQDwfWB2AdxeDihBc8Hu9C+yRIF6YS1ykQ6L4O jANzUYhT91gBUAUY20cTaeV7FBSQJrKiYvMMyLEeppSqtWwxLuh4Mt0iWNsZarg15T0Pl+vkKw1 6hSIVZEZwuaBpMQ3OMy3sG5BCQd0p065H7AIRwoAYSMi7Hk4ku7yjsJqZHKYYulp1/z2s2MTHCq /r8GVgDeFlY8 X-Google-Smtp-Source: AGHT+IF9GH2yQvUMIqsbCCNsuO8FPLRYlgSk2u3WwWiYMLVRXbafL8x+fK0Tl8sHNk/QwjW6XYhwsA== X-Received: by 2002:a05:6a21:329e:b0:1e4:745c:4965 with SMTP id adf61e73a8af0-1eb216127c9mr12456426637.8.1737291185596; Sun, 19 Jan 2025 04:53:05 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab7f1776sm5061694b3a.7.2025.01.19.04.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 04:53:05 -0800 (PST) From: Maxim Cournoyer To: 56197@debbugs.gnu.org Subject: [PATCH v2] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. Date: Sun, 19 Jan 2025 21:51:56 +0900 Message-ID: <20250119125230.11812-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: eliz@gnu.org, Maxim Cournoyer , larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Starting with Emacs 28, filling strings now happens in a narrowed scope, and looses the leading indentation and can cause the string to extend past the fill-column value. Introduce `lisp-fill-paragraph-as-displayed' as a new variable allowing opting out of this new behavior in specific scenarios (such as when using the Scheme major mode, say). * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph-as-displayed): New variable. (lisp-fill-paragraph): Honor it, by avoiding the logic narrow to strings before applying fill-paragraph. * test/lisp/emacs-lisp/lisp-mode-tests.el (lisp-fill-paragraph-respects-fill-column): Test it. (lisp-fill-paragraph-docstring-boundaries): New test, as a safeguard to avoid regressions. Fixes: bug#56197 --- Changes since v1: Use defvar, not defcustom + light rewordings of some doc/comments lisp/emacs-lisp/lisp-mode.el | 72 ++++++++++++++----------- test/lisp/emacs-lisp/lisp-mode-tests.el | 47 ++++++++++++++++ 2 files changed, 88 insertions(+), 31 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index d0c32d238bc..c55dd3c6528 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1,6 +1,6 @@ ;;; lisp-mode.el --- Lisp mode, and its idiosyncratic commands -*- lexical-binding:t -*- -;; Copyright (C) 1985-1986, 1999-2024 Free Software Foundation, Inc. +;; Copyright (C) 1985-1986, 1999-2025 Free Software Foundation, Inc. ;; Maintainer: emacs-devel@gnu.org ;; Keywords: lisp, languages @@ -1431,6 +1431,14 @@ emacs-lisp-docstring-fill-column :group 'lisp :version "30.1") +(defvar lisp-fill-paragraph-as-displayed nil + "This variable can be set to true to fill paragraphs as displayed in the +buffer, preserving surrounding context such as the leading indentation. +This is useful if respecting `fill-column' is more important than +preventing surrounding code from being filled, and makes +`lisp-fill-paragraph' behave as it used to in Emacs 27 and prior +versions.") + (defun lisp-fill-paragraph (&optional justify) "Like \\[fill-paragraph], but handle Emacs Lisp comments and docstrings. If any of the current line is a comment, fill the comment or the @@ -1480,42 +1488,44 @@ lisp-fill-paragraph (derived-mode-p 'emacs-lisp-mode)) emacs-lisp-docstring-fill-column fill-column))) - (let ((ppss (syntax-ppss)) - (start (point)) - ;; Avoid recursion if we're being called directly with - ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. - (fill-paragraph-function t)) + (let* ((ppss (syntax-ppss)) + (start (point)) + ;; Avoid recursion if we're being called directly with + ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. + (fill-paragraph-function t) + (string-start (ppss-comment-or-string-start ppss))) (save-excursion (save-restriction ;; If we're not inside a string, then do very basic ;; filling. This avoids corrupting embedded strings in ;; code. - (if (not (ppss-comment-or-string-start ppss)) + (if (not string-start) (lisp--fill-line-simple) - ;; If we're in a string, then narrow (roughly) to that - ;; string before filling. This avoids filling Lisp - ;; statements that follow the string. - (when (ppss-string-terminator ppss) - (goto-char (ppss-comment-or-string-start ppss)) - ;; The string may be unterminated -- in that case, don't - ;; narrow. - (when (ignore-errors - (progn - (forward-sexp 1) - t)) - (narrow-to-region (1+ (ppss-comment-or-string-start ppss)) - (1- (point))))) - ;; Move back to where we were. - (goto-char start) - ;; We should fill the first line of a string - ;; separately (since it's usually a doc string). - (if (= (line-number-at-pos) 1) - (narrow-to-region (line-beginning-position) - (line-beginning-position 2)) - (save-excursion - (goto-char (point-min)) - (forward-line 1) - (narrow-to-region (point) (point-max)))) + (unless lisp-fill-paragraph-as-displayed + ;; If we're in a string, then narrow (roughly) to that + ;; string before filling. This avoids filling Lisp + ;; statements that follow the string. + (when (ppss-string-terminator ppss) + (goto-char string-start) + ;; The string may be unterminated -- in that case, don't + ;; narrow. + (when (ignore-errors + (progn + (forward-sexp 1) + t)) + (narrow-to-region (1+ string-start) + (1- (point))))) + ;; Move back to where we were. + (goto-char start) + ;; We should fill the first line of a string + ;; separately (since it's usually a doc string). + (if (= (line-number-at-pos) 1) + (narrow-to-region (line-beginning-position) + (line-beginning-position 2)) + (save-excursion + (goto-char (point-min)) + (forward-line 1) + (narrow-to-region (point) (point-max))))) (fill-paragraph justify))))))) ;; Never return nil. t) diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index da02be65d03..7f5c97ace4d 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -308,6 +308,53 @@ lisp-indent-defun (indent-region (point-min) (point-max)) (should (equal (buffer-string) orig))))) + +;;; Filling + +(ert-deftest lisp-fill-paragraph-docstring-boundaries () + "Test bug#28937, ensuring filling the docstring filled is properly +bounded." + (with-temp-buffer + (insert "\ +(defun test () + \"This is a test docstring. +Here is some more text.\" + 1 + 2 + 3 + 4 + 5)") + (let ((correct (buffer-string))) + (emacs-lisp-mode) + (search-backward "This is a test docstring") + (fill-paragraph) ;function under test + (should (equal (buffer-string) correct))))) + +(ert-deftest lisp-fill-paragraph-as-displayed () + "Test bug#56197 -- more specifically, validate that a leading indentation +for a string is preserved in the filled string." + (let ((lisp-fill-paragraph-as-displayed t) ;variable under test + ;; The following is a contrived example that demonstrates the + ;; fill-column problem when the string to fill is indented. + (source "\ +'(description \"This is a very long string which is indented by a considerable value, causing it to +protrude from the configured `fill-column' since +lisp-fill-paragraph was refactored in version 28.\")")) + (with-temp-buffer + (insert source) + (emacs-lisp-mode) + (search-backward "This is a very long string") + (fill-paragraph) ;function under test + (goto-char (point-min)) + (message "%s" (buffer-substring-no-properties (point-min) (point-max))) + (let ((i 1) + (lines-count (count-lines (point-min) (point-max)))) + (while (< i lines-count) + (beginning-of-line i) + (end-of-line) + (should (<= (current-column) fill-column)) + (setq i (1+ i))))))) + ;;; Fontification -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 08:13:33 2025 Received: (at 56197) by debbugs.gnu.org; 19 Jan 2025 13:13:33 +0000 Received: from localhost ([127.0.0.1]:45254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZV7N-0005t1-1a for submit@debbugs.gnu.org; Sun, 19 Jan 2025 08:13:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49144) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZV7K-0005sg-Nl for 56197@debbugs.gnu.org; Sun, 19 Jan 2025 08:13:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZV7E-0002hf-P5; Sun, 19 Jan 2025 08:13:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=puaxMoPujaKVBsAFd2HFhjJP6qoerrrEHT/92veUltE=; b=aAfXnxIN0WRV oOc5Fk1XwCYzENDI2W8r+xjl0eClBkKEdpwwlavm3r4JKL35sOre8a/28hs/k72pJDYbRiR7kBNIo MFey5+c9gpV7Eq6yVQFc7nmXuXJBqv/aJVc04pghiUfiAk6Q6DqV3pJ8bFZZfsMMyIq8Xwmn8m7HB s+yOmC6QCULXZk2e+Zlc69of0Y7gN0uSJI+EFixSY1D6OGJi4JURo2sAOS1cH7ahz37vAw91ZjW5Y aZDCa4OkjBgKIPRLelgaDW+5kV0wju2YbDa9DdJyVIBxOVWW1mtuK3qDxbERO2MzG8OKNRk3WxQoY oOI4oU8eyx3HWc5Yr7vIXA==; Date: Sun, 19 Jan 2025 15:13:21 +0200 Message-Id: <86r04z6j66.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <20250119125230.11812-1-maxim.cournoyer@gmail.com> (message from Maxim Cournoyer on Sun, 19 Jan 2025 21:51:56 +0900) Subject: Re: [PATCH v2] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250119125230.11812-1-maxim.cournoyer@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, maxim.cournoyer@gmail.com, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: eliz@gnu.org, > larsi@gnus.org, > felix.lechner@lease-up.com, > stefankangas@gmail.com, > Maxim Cournoyer > Date: Sun, 19 Jan 2025 21:51:56 +0900 > > Starting with Emacs 28, filling strings now happens in a narrowed scope, > and looses the leading indentation and can cause the string to extend > past the fill-column value. Introduce `lisp-fill-paragraph-as-displayed' > as a new variable allowing opting out of this new behavior in specific > scenarios (such as when using the Scheme major mode, say). Thanks, a few minor comments below. > * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph-as-displayed): New > variable. > (lisp-fill-paragraph): Honor it, by avoiding the logic narrow to strings > before applying fill-paragraph. > * test/lisp/emacs-lisp/lisp-mode-tests.el > (lisp-fill-paragraph-respects-fill-column): Test it. > (lisp-fill-paragraph-docstring-boundaries): New test, as a safeguard to > avoid regressions. Please format these entries according to our conventions, mostly regarding the line length (it should be at most 69 columns, preferably no more than 64. > -;; Copyright (C) 1985-1986, 1999-2024 Free Software Foundation, Inc. > +;; Copyright (C) 1985-1986, 1999-2025 Free Software Foundation, Inc. Please rebase on the current master branch, where the copyright years were already updated. > +(defvar lisp-fill-paragraph-as-displayed nil > + "This variable can be set to true to fill paragraphs as displayed in the > +buffer, preserving surrounding context such as the leading indentation. > +This is useful if respecting `fill-column' is more important than > +preventing surrounding code from being filled, and makes > +`lisp-fill-paragraph' behave as it used to in Emacs 27 and prior > +versions.") The first line of a doc string should be a single full sentence. (This is because the various apropos commands show only the first line.) More importantly, I think this doc string should describe the main use case for which the default behavior is tuned: filling Emacs Lisp doc strings, with their special treatment of the first line. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 21:43:57 2025 Received: (at 56197) by debbugs.gnu.org; 21 Jan 2025 02:43:57 +0000 Received: from localhost ([127.0.0.1]:52726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta4FB-0008Ky-26 for submit@debbugs.gnu.org; Mon, 20 Jan 2025 21:43:57 -0500 Received: from [2607:f8b0:4864:20::1034] (port=55536 helo=mail-pj1-x1034.google.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta4F6-0008KS-3k for 56197@debbugs.gnu.org; Mon, 20 Jan 2025 21:43:54 -0500 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2ee397a82f6so9144887a91.2 for <56197@debbugs.gnu.org>; Mon, 20 Jan 2025 18:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737427419; x=1738032219; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YeZzgn/ky2ahb9s06jLilrZ9qRWijYCHfKSOkRkjbW0=; b=git5HtJdlE7O4iRJXhNtoqy575DdQgD0tLU5YQMYjyZYuWZaxrELXoYBJcFgHo3k6L LPZuB2ZsgiZeowviijCvnAWMcpZDeUxi2PPDVJSd+UlYpKCfvbRH94cp6s0B1tgEa6uv j9e1NJ6JP8nYKZSQVjTt1mpu0XDCuTfOu/Ax9y3z05kmFr61p0BqaKU08S+eXEcR33a5 5BfGbQDaPgRD8hmdFaqjRuh7I2A5iihBAKZn8gbvCKzId7g7/b9ezBCikPrAEXltceaw NYw8v0oO6+fAAMyUo+11C2nYbxL0MXo6UA5P8WWYwBpZ3+rDqQskVu+BYRAsCd/Y0Ujz rVmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737427419; x=1738032219; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YeZzgn/ky2ahb9s06jLilrZ9qRWijYCHfKSOkRkjbW0=; b=qqx2oj2PiS32M3roIb0qHFM52KECoGwe8NR4/2n6aoJnuQVmw75gfG6O4+cvI24CQ0 8csnjFLMCYz55ndlRSmvM6ygNRp90RA8E3/grGu8o9PSLpQSbeb1nFPL4vOcbbpGKtJO cvd3rpJhUIjNVOzUD0BEnBuzFWPdAXXIeuVNSHIPcOLovKHjESZEc3vl3hUMY+w0mx1g YPxFiVopp4XubKMNotZM/ibRWfefO8BLTOrvWNG+ekZmGprpC9Pnn60EE3Rmd9j0Bi4M xuLcHEsNqfG2DidF5tkzXCSRPQuT3zGsjC90md24JlZ8kNsge82jBDio6nwlo8V2NBuI 51lg== X-Gm-Message-State: AOJu0YyVXvI2Js3JqgLKmb054LWtVO/2YtTq4uoeiF2DS9vKjneBAlZt 3tl5/Zf4sWk0fjmhiZFm5RcF7ROTiDVaXGn1KZIluiCl48oarrqJ X-Gm-Gg: ASbGncuUGuuiuQandFhFt4jy/LgI0U6Da2px3zJgLciU0aI6x7V0Z3k0KnxEigUO5Rt 8/z0QaFVEy1ci9CKznnsxmMISkAtSA7V17gljL9VvB+M/W2OIfCb7UZEBr6zJeB5mVHoiE5QeC3 8CpyV45Un2iDxJ8lsCLtf5cpeoiYYQwV0c0h48iu4O7kpL0PDbvYF57pyDneR5DulGJwOQo38bm tcGFypx1XD6Fx5I3XCwtoEk77VpEUnV80tJ30soYTJ3pDX6Oe1ChnYfOKnrDwjR128= X-Google-Smtp-Source: AGHT+IHL/5FQGHmiN5qRCHrRBRGRUIVOsr0JNJTq2wyk4bklXmP6kpkwSVQEXkMVRnYHkdfFbnaTjQ== X-Received: by 2002:a05:6a00:369a:b0:72a:83ec:b16e with SMTP id d2e1a72fcca58-72dafba301fmr22141717b3a.21.1737427418799; Mon, 20 Jan 2025 18:43:38 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab81753fsm8194109b3a.60.2025.01.20.18.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 18:43:38 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: [PATCH v2] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86r04z6j66.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Jan 2025 15:13:21 +0200") References: <20250119125230.11812-1-maxim.cournoyer@gmail.com> <86r04z6j66.fsf@gnu.org> Date: Tue, 21 Jan 2025 11:43:27 +0900 Message-ID: <87ikq8c2eo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Eli Zaretskii writes: [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1034 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hi, Eli Zaretskii writes: [...] >> * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph-as-displayed): New >> variable. >> (lisp-fill-paragraph): Honor it, by avoiding the logic narrow to strings >> before applying fill-paragraph. >> * test/lisp/emacs-lisp/lisp-mode-tests.el >> (lisp-fill-paragraph-respects-fill-column): Test it. >> (lisp-fill-paragraph-docstring-boundaries): New test, as a safeguard to >> avoid regressions. > > Please format these entries according to our conventions, mostly > regarding the line length (it should be at most 69 columns, preferably > no more than 64. Done. It's odd that when using magit there's no easy way to have this this set by default (it defaults to use the text-mode major mode). I've M-x log-edit-mode in the edit buffer to get the .dir-locals.el preferences applied. >> -;; Copyright (C) 1985-1986, 1999-2024 Free Software Foundation, Inc. >> +;; Copyright (C) 1985-1986, 1999-2025 Free Software Foundation, Inc. > > Please rebase on the current master branch, where the copyright years > were already updated. Done. >> +(defvar lisp-fill-paragraph-as-displayed nil >> + "This variable can be set to true to fill paragraphs as displayed in the >> +buffer, preserving surrounding context such as the leading indentation. >> +This is useful if respecting `fill-column' is more important than >> +preventing surrounding code from being filled, and makes >> +`lisp-fill-paragraph' behave as it used to in Emacs 27 and prior >> +versions.") > > The first line of a doc string should be a single full sentence. > (This is because the various apropos commands show only the first > line.) > > More importantly, I think this doc string should describe the main use > case for which the default behavior is tuned: filling Emacs Lisp doc > strings, with their special treatment of the first line. I expound the docstring to add more information w.r.t. to the default behavior of `lisp-fill-paragraph'. I hope it addresses your comment. I'll send v3 shortly. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 21:52:35 2025 Received: (at 56197) by debbugs.gnu.org; 21 Jan 2025 02:52:35 +0000 Received: from localhost ([127.0.0.1]:52736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta4NW-0003N2-OB for submit@debbugs.gnu.org; Mon, 20 Jan 2025 21:52:35 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:52593) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta4NR-0003MX-TF for 56197@debbugs.gnu.org; Mon, 20 Jan 2025 21:52:33 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-21661be2c2dso89821655ad.1 for <56197@debbugs.gnu.org>; Mon, 20 Jan 2025 18:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737427943; x=1738032743; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6UdALVQg+L1saJ/6C85DwXMpNnuj7Rioebpn6EdaYEo=; b=irC+GNUmlVY1eife5H4pi12qzFAmSWPlRpVxc+U7qEK59pxd0jczckdEOFiseagRTp AcjPgQTPEwsL/pBmQ1arVQeWLfTP4pvujDWHNsOAcBiSRSkMhL4X26mBYfMgDgssZLVX VztecFScOL+820dzWml6DXctenoxeOoKX1zdBA858ny7dRtnyDwThehqW5OQbgWmc26V JPYWlTTjrXJEjt4tHEv/+/fO083N+A5f20J9i/iC0p9KyNeiSny63dPOAd9nq63evSUY WVbSuLZyQBYILOscWTiC6SchJyA2xuXeBHKR8vsCsIA9+qz644YZVS205h8uMUgdRZY9 lxhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737427943; x=1738032743; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6UdALVQg+L1saJ/6C85DwXMpNnuj7Rioebpn6EdaYEo=; b=Cz52+P56jA4mvzJSoc0BsZrw8hwLsKp7eQCHz4O4daoaUFsGJNcDNWB9Oh2AgKoe3L X13/6vhn5ZqEDKW5JnIqLZk5BnbSvG8rbL2OvJld/aw+vOlURuESWiSovkjZNCayB92c RIWW5opbaKhvSLvvcg1+GtY2CBDB1Vz8iPR4JMEYb4ONp0NVsumSGEQX7d+S3jgVC8Ah DSkjNYHtekDHBi8XQkDxaPYSjJBfPZi25LUkZhajl8xFF/Z2M/KgowVIFjP7NaX6PQxv 1/nZOM7wHH4MfR1pni8mch7n3nw0Zimd1HygoWCuXj6tFOTNTXnGOvXJ1blbsa92acEC Bdog== X-Gm-Message-State: AOJu0Yw6Tsplx89qa952yBxQjREjK6qLJ9ONQhxDdAFMukKShdJwv0fc tKD3Em5lWveAozKj1rFrPIN59o+Yfoq3TkNrY/Tic4LHXxe+gO5EcUQz9jfIs2U= X-Gm-Gg: ASbGncvTEQ9SPo1xpdjFzN3ODOkKYhgUrUhh85tZZn3X27UAKNZyNxP9nhH+Q5RCrG3 fMY83xnG8TW3rxBKEwYeDh6qBHj8MQ7cKcZBESc+TrNWkTjIgQVobujC5xD0jTIW8YG2DjIDTjc KFoiDz6n3GgHodJMaJHnSsdDDCP8f3qgS/QBsfnOTukmqKrucLDsFarXV7W8l2X7JYpKA4GPq7m osoiut18VgCUsyUKQEpPs3zvlcgh/5IHJNOeWGnpl4w+zHwuy0sxIrLegunYg06gXjoMe1mP/J8 zn3H9X7HZNrW X-Google-Smtp-Source: AGHT+IHi623Zy5dTjBEYXGJfqqNG2Y40wPnFEkX9YpkIbjkVhq6ja6pQXE2/sRtiSVIbuzFew/PTKA== X-Received: by 2002:a17:903:2291:b0:216:2dc5:2330 with SMTP id d9443c01a7336-21c355b9335mr236701695ad.36.1737427942755; Mon, 20 Jan 2025 18:52:22 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d3dd94asm66930055ad.190.2025.01.20.18.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 18:52:22 -0800 (PST) From: Maxim Cournoyer To: 56197@debbugs.gnu.org Subject: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. Date: Tue, 21 Jan 2025 11:50:44 +0900 Message-ID: <20250121025207.19966-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: eliz@gnu.org, Maxim Cournoyer , larsi@gnus.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Starting with Emacs 28, filling strings now happens in a narrowed scope, and looses the leading indentation and can cause the string to extend past the fill-column value. Introduce `lisp-fill-paragraph-as-displayed' as a new variable allowing opting out of this new behavior in specific scenarios (such as when using the Scheme major mode, say). * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph-as-displayed): New variable. (lisp-fill-paragraph): Honor it, by avoiding the logic narrow to strings before applying fill-paragraph. * test/lisp/emacs-lisp/lisp-mode-tests.el (lisp-fill-paragraph-respects-fill-column): Test it. (lisp-fill-paragraph-docstring-boundaries): New test, as a safeguard to avoid regressions. Fixes: bug#56197 --- lisp/emacs-lisp/lisp-mode.el | 75 +++++++++++++++---------- test/lisp/emacs-lisp/lisp-mode-tests.el | 47 ++++++++++++++++ 2 files changed, 92 insertions(+), 30 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 2b75a5fd038..9e8292b992a 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1431,6 +1431,19 @@ emacs-lisp-docstring-fill-column :group 'lisp :version "30.1") +(defvar lisp-fill-paragraph-as-displayed nil + "Modify the behavior of `lisp-fill-paragraph'. +The default behavior of `lisp-fill-paragraph' is tuned for filling Emacs +Lisp doc strings, with their special treatment for the first line. +Particularly, strings are filled in a narrowed context to avoid filling +surrounding code, which means any leading indent is disregarded, which +can cause the filled string to extend passed the configured +`fill-column' variable value. If you would rather fill the string in +its original context and ensure the `fill-column' value is more strictly +respected, set this variable to true. Doing so makes +`lisp-fill-paragraph' behave as it used to in Emacs 27 and prior +versions.") + (defun lisp-fill-paragraph (&optional justify) "Like \\[fill-paragraph], but handle Emacs Lisp comments and docstrings. If any of the current line is a comment, fill the comment or the @@ -1480,42 +1493,44 @@ lisp-fill-paragraph (derived-mode-p 'emacs-lisp-mode)) emacs-lisp-docstring-fill-column fill-column))) - (let ((ppss (syntax-ppss)) - (start (point)) - ;; Avoid recursion if we're being called directly with - ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. - (fill-paragraph-function t)) + (let* ((ppss (syntax-ppss)) + (start (point)) + ;; Avoid recursion if we're being called directly with + ;; `M-x lisp-fill-paragraph' in an `emacs-lisp-mode' buffer. + (fill-paragraph-function t) + (string-start (ppss-comment-or-string-start ppss))) (save-excursion (save-restriction ;; If we're not inside a string, then do very basic ;; filling. This avoids corrupting embedded strings in ;; code. - (if (not (ppss-comment-or-string-start ppss)) + (if (not string-start) (lisp--fill-line-simple) - ;; If we're in a string, then narrow (roughly) to that - ;; string before filling. This avoids filling Lisp - ;; statements that follow the string. - (when (ppss-string-terminator ppss) - (goto-char (ppss-comment-or-string-start ppss)) - ;; The string may be unterminated -- in that case, don't - ;; narrow. - (when (ignore-errors - (progn - (forward-sexp 1) - t)) - (narrow-to-region (1+ (ppss-comment-or-string-start ppss)) - (1- (point))))) - ;; Move back to where we were. - (goto-char start) - ;; We should fill the first line of a string - ;; separately (since it's usually a doc string). - (if (= (line-number-at-pos) 1) - (narrow-to-region (line-beginning-position) - (line-beginning-position 2)) - (save-excursion - (goto-char (point-min)) - (forward-line 1) - (narrow-to-region (point) (point-max)))) + (unless lisp-fill-paragraph-as-displayed + ;; If we're in a string, then narrow (roughly) to that + ;; string before filling. This avoids filling Lisp + ;; statements that follow the string. + (when (ppss-string-terminator ppss) + (goto-char string-start) + ;; The string may be unterminated -- in that case, don't + ;; narrow. + (when (ignore-errors + (progn + (forward-sexp 1) + t)) + (narrow-to-region (1+ string-start) + (1- (point))))) + ;; Move back to where we were. + (goto-char start) + ;; We should fill the first line of a string + ;; separately (since it's usually a doc string). + (if (= (line-number-at-pos) 1) + (narrow-to-region (line-beginning-position) + (line-beginning-position 2)) + (save-excursion + (goto-char (point-min)) + (forward-line 1) + (narrow-to-region (point) (point-max))))) (fill-paragraph justify))))))) ;; Never return nil. t) diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el index 3a765eab625..96e37114276 100644 --- a/test/lisp/emacs-lisp/lisp-mode-tests.el +++ b/test/lisp/emacs-lisp/lisp-mode-tests.el @@ -308,6 +308,53 @@ lisp-indent-defun (indent-region (point-min) (point-max)) (should (equal (buffer-string) orig))))) + +;;; Filling + +(ert-deftest lisp-fill-paragraph-docstring-boundaries () + "Test bug#28937, ensuring filling the docstring filled is properly +bounded." + (with-temp-buffer + (insert "\ +(defun test () + \"This is a test docstring. +Here is some more text.\" + 1 + 2 + 3 + 4 + 5)") + (let ((correct (buffer-string))) + (emacs-lisp-mode) + (search-backward "This is a test docstring") + (fill-paragraph) ;function under test + (should (equal (buffer-string) correct))))) + +(ert-deftest lisp-fill-paragraph-as-displayed () + "Test bug#56197 -- more specifically, validate that a leading indentation +for a string is preserved in the filled string." + (let ((lisp-fill-paragraph-as-displayed t) ;variable under test + ;; The following is a contrived example that demonstrates the + ;; fill-column problem when the string to fill is indented. + (source "\ +'(description \"This is a very long string which is indented by a considerable value, causing it to +protrude from the configured `fill-column' since +lisp-fill-paragraph was refactored in version 28.\")")) + (with-temp-buffer + (insert source) + (emacs-lisp-mode) + (search-backward "This is a very long string") + (fill-paragraph) ;function under test + (goto-char (point-min)) + (message "%s" (buffer-substring-no-properties (point-min) (point-max))) + (let ((i 1) + (lines-count (count-lines (point-min) (point-max)))) + (while (< i lines-count) + (beginning-of-line i) + (end-of-line) + (should (<= (current-column) fill-column)) + (setq i (1+ i))))))) + ;;; Fontification -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 05:19:10 2025 Received: (at 56197-done) by debbugs.gnu.org; 25 Jan 2025 10:19:10 +0000 Received: from localhost ([127.0.0.1]:48643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbdFu-0003gL-14 for submit@debbugs.gnu.org; Sat, 25 Jan 2025 05:19:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbdFr-0003g3-QJ for 56197-done@debbugs.gnu.org; Sat, 25 Jan 2025 05:19:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbdFm-0006BR-4s; Sat, 25 Jan 2025 05:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EVK7OXbkgKsrQTkACBnpue9VX1pUoYLz0gsT17mulDc=; b=JrXvmBsoUkWP AFeN2fHba3YYvzJnCOhoihqn0659q5aTrkcwimGnDxNfEd3mD33p4bYvADBcvPBeJ2X7Fi69zPGCK 4OMgmMB54KzQelm0AiF4TyhEDN51ulhUfci9ec6YIFUqhrNxIipIBDlNHzjLjtFBnfSwhN9ByK8uI B+kAFr9Hjb7Y1JgWV/Tl/Wea8TfWNi0NbzxgjGwaTBwOWx7LrzparvCCBEE+uAKPF4zWkjZiO7fEb FnvdzmltxJFxFqMWmCGYssfmrKZlrlgTrlE93akjSNdUeaLrIhzaG3RbhrUAqULkMEAc2iAc2owcY onJrPBCkORgj2GgXVblJUQ==; Date: Sat, 25 Jan 2025 12:18:48 +0200 Message-Id: <86plkburg7.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <20250121025207.19966-1-maxim.cournoyer@gmail.com> (message from Maxim Cournoyer on Tue, 21 Jan 2025 11:50:44 +0900) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197-done Cc: larsi@gnus.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com, felix.lechner@lease-up.com, 56197-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: eliz@gnu.org, > larsi@gnus.org, > felix.lechner@lease-up.com, > stefankangas@gmail.com, > Maxim Cournoyer > Date: Tue, 21 Jan 2025 11:50:44 +0900 > > Starting with Emacs 28, filling strings now happens in a > narrowed scope, and looses the leading indentation and can cause > the string to extend past the fill-column value. Introduce > `lisp-fill-paragraph-as-displayed' as a new variable allowing > opting out of this new behavior in specific scenarios (such as > when using the Scheme major mode, say). Thanks, installed on the master branch, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 10:54:27 2025 Received: (at 56197-done) by debbugs.gnu.org; 25 Jan 2025 15:54:27 +0000 Received: from localhost ([127.0.0.1]:52129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbiUN-0007f5-8y for submit@debbugs.gnu.org; Sat, 25 Jan 2025 10:54:27 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:59693) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tbiUK-0007eo-N7 for 56197-done@debbugs.gnu.org; Sat, 25 Jan 2025 10:54:25 -0500 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2166651f752so56606595ad.3 for <56197-done@debbugs.gnu.org>; Sat, 25 Jan 2025 07:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737820458; x=1738425258; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=D2N8h+NxNTXzW2NOkve18kgZTXwN9hxhZcTGI0MdZTw=; b=lgLDgvU7qb+ezentt7SnM+APNdbWG+Mqml4rLS6NQgp5iq3imZVboqThL33xOE96AE 7Hm3ZQWjInO1gV0OfOdPuAvrIpSEfRwMju48Gk16Ql+3S4fTlEAon6KjYDc1q/YTFyc1 TmnfcTskmrB5kkVyKtg8bRxpYb4uoWht16Cbz/KXPEAYWnYniLKvC35KDRmYFFQ0ctRD QvuyRw6fATzVzsuJj2m82N+R/t25uRLF6n+vR11qc0+HP9pz6kjRtoZQE9BMRzKhDsQC B0zuLrGXsAxeQAGffvgrtecIEejNm8GJ96PUqvAFRf0NlH8L+yORMdIdWEgw7sxBDYi2 K/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737820458; x=1738425258; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D2N8h+NxNTXzW2NOkve18kgZTXwN9hxhZcTGI0MdZTw=; b=AdR0a5hhijlxmj5fc2jPV3q0r/bM7wNJlhWMgqMkrceFqLxJwHKSctYGnRizZI+pTJ T5iV2lMawbeL3Ya307i6N56DJM6AQj/OcvFU+iA1UaDkB7TwTZsUbRLFV1H7F28R7zRC zWATVhJz3L10GCfpnu6cdogfZflQrRuXHnB8c7CrDhm1UmvNI3KTJvv6vl20x514lYw2 v3puQk8/GZXevhsDw3AuIHImFWQzy20T+MXT3tJeqOfMMnUHbp+kCsPOA66akAzqTncG YYZg3k+ESoRIR8FHc6OkstnW5H3EzI45t7iF+dRT6M1LIN0bJvaBTcifvSRxC8EW+dvD S3AA== X-Gm-Message-State: AOJu0YwV85adpAWiLByt/y+pi1/EPE/QSTIWVxJV0gRwtrMG+KIgaHyp ge3I5qLz8GdVP7UMCQpK0DL/godSr8/Jpx/mHIQhpYVQkmlfLgV1 X-Gm-Gg: ASbGnctv69t7UljPO7DcjcH9Ke0ojei+BUCblKkotjw+IYPc8NXB17Y1UFrlkr/a7B9 OL6JqIK0wrUZ/c+Bs5FR2sF9LTBXBuIbSP1f0DPywCgMp1WpTawHEV3oD1qDlxFvn5Zq6CPppnx bQibKiM2wGNce2ySFbQ9CRFhEo3it6J0rroylpkfYWuNZbTULxmuUVGbeKcWITISv6bHQkpTVgN YookfyP3QksDe6rFHNd2wrxTXRYEaq82e87H81hB/nqIsItleUyO0Km/bT8QphT5tLLuyUWK8rU CA== X-Google-Smtp-Source: AGHT+IFsb76URgu2Rp9iPcWIBfHcAWxcyZ92bOa5pJw5fF/l5+PbgMnaO+xDyCIOb1p8Tf0ZplyPNA== X-Received: by 2002:a05:6a21:3391:b0:1e5:f930:c710 with SMTP id adf61e73a8af0-1eb214987e8mr54163302637.20.1737820458515; Sat, 25 Jan 2025 07:54:18 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a78f145sm3871725b3a.167.2025.01.25.07.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2025 07:54:17 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86plkburg7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jan 2025 12:18:48 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> Date: Sun, 26 Jan 2025 00:54:06 +0900 Message-ID: <87cyga99ep.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 56197-done Cc: larsi@gnus.org, stefankangas@gmail.com, felix.lechner@lease-up.com, 56197-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli Zaretskii writes: >> From: Maxim Cournoyer >> Cc: eliz@gnu.org, >> larsi@gnus.org, >> felix.lechner@lease-up.com, >> stefankangas@gmail.com, >> Maxim Cournoyer >> Date: Tue, 21 Jan 2025 11:50:44 +0900 >> >> Starting with Emacs 28, filling strings now happens in a >> narrowed scope, and looses the leading indentation and can cause >> the string to extend past the fill-column value. Introduce >> `lisp-fill-paragraph-as-displayed' as a new variable allowing >> opting out of this new behavior in specific scenarios (such as >> when using the Scheme major mode, say). > > Thanks, installed on the master branch, and closing the bug. I appreciate your patience and efforts following this through. Thank you. -- Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 23:24:52 2025 Received: (at 56197) by debbugs.gnu.org; 26 Jan 2025 04:24:52 +0000 Received: from localhost ([127.0.0.1]:53752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbuCZ-0004Do-N0 for submit@debbugs.gnu.org; Sat, 25 Jan 2025 23:24:51 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:45502) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbuCW-0004Dd-CB for 56197@debbugs.gnu.org; Sat, 25 Jan 2025 23:24:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=tMBY+tiN6oSqA/s ya1eT/6Lj0prqBaJBvMMCvi10x5w=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=OwsbJMbnEvzE3WJvr/tgPIu51QLxwFiPE0A3X3nk 6IWjZxfw6zOQga2c748kTwbATC1tYXzQ7XvdRXeV0lR30z6hMdr1zW3IVsWCIeYIVKq2Z6 /7bl5Z1ZRmUyqgb7StjxbdsTvqxBpJF8g2oLeQFf9GOj/QbCCIPRAh6T5LZ9w= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 44f5ff36 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 26 Jan 2025 04:24:43 +0000 (UTC) From: Felix Lechner To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86plkburg7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jan 2025 12:18:48 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sat, 25 Jan 2025 20:24:42 -0800 Message-ID: <87wmei8anp.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, Maxim Cournoyer , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, On Sat, Jan 25 2025, Eli Zaretskii wrote: >> Starting with Emacs 28, filling strings now happens in a >> narrowed scope, and looses the leading indentation and can cause >> the string to extend past the fill-column value. Introduce >> `lisp-fill-paragraph-as-displayed' as a new variable allowing >> opting out of this new behavior in specific scenarios (such as >> when using the Scheme major mode, say). Thanks, but the name is terrible. The name fill-paragraph-as-displayed is the standard behavior. It would be better to invert the logic and call it fill-strings-instead-of-paragraphs. Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 02:22:47 2025 Received: (at 56197) by debbugs.gnu.org; 26 Jan 2025 07:22:47 +0000 Received: from localhost ([127.0.0.1]:54076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbwyl-0005aW-2m for submit@debbugs.gnu.org; Sun, 26 Jan 2025 02:22:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41032) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbwyi-0005aH-1b for 56197@debbugs.gnu.org; Sun, 26 Jan 2025 02:22:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbwyb-0004Ni-AM; Sun, 26 Jan 2025 02:22:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k9p3ROtMvRsAQ4IVVbwF5Pt1z49vsVUUlFSvcA79gKY=; b=CkqGpS7hFby9 dCdIUgV7kxn3qxWvP108Jo62YG87gpdR3eFuxb8kFBaWe4400ZAuhgVhTGFmjeAfpFlzDRieN1O/B KmBzI1HYyxxUE1/Y0+Xztpu7M876n8KyQ/uvVNuhIGViN8eIRsf34q5nbDEb4BrHjWipTjKmRkPPU R2+sx8YbxeGnxnfxIAyQfaLqZjgy2JO2UA4IbDcwaEQDd+K8CQIeiFvLJAewsW/H9kC3WsZlTFIbf maxfJvnlmMwkR1KWEdLuICEXkRid/OKA7RaGP4HfZGmiTFDe1sKXD2N94a011rHOcJWZ/XlQi1ENS vfIK2MZBlaQM1Fisq4Z+dg==; Date: Sun, 26 Jan 2025 09:22:35 +0200 Message-Id: <868qqyt4xw.fsf@gnu.org> From: Eli Zaretskii To: Felix Lechner In-Reply-To: <87wmei8anp.fsf@lease-up.com> (message from Felix Lechner on Sat, 25 Jan 2025 20:24:42 -0800) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Felix Lechner > Cc: Maxim Cournoyer , 56197@debbugs.gnu.org, > larsi@gnus.org, stefankangas@gmail.com > Date: Sat, 25 Jan 2025 20:24:42 -0800 > > On Sat, Jan 25 2025, Eli Zaretskii wrote: > > >> Starting with Emacs 28, filling strings now happens in a > >> narrowed scope, and looses the leading indentation and can cause > >> the string to extend past the fill-column value. Introduce > >> `lisp-fill-paragraph-as-displayed' as a new variable allowing > >> opting out of this new behavior in specific scenarios (such as > >> when using the Scheme major mode, say). > > Thanks, but the name is terrible. The name fill-paragraph-as-displayed > is the standard behavior. It would be better to invert the logic and > call it fill-strings-instead-of-paragraphs. I'm okay with looking for a better name, but fill-strings-instead-of-paragraphs doesn't sound like a better one (and "terrible" is an exaggeration, IMO). How about fill-paragraph-as-doc-string, by default t? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 09:37:59 2025 Received: (at 56197) by debbugs.gnu.org; 26 Jan 2025 14:37:59 +0000 Received: from localhost ([127.0.0.1]:55505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tc3lv-0000ub-8x for submit@debbugs.gnu.org; Sun, 26 Jan 2025 09:37:59 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:54595) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tc3lr-0000uI-IQ for 56197@debbugs.gnu.org; Sun, 26 Jan 2025 09:37:56 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-21670dce0a7so74597705ad.1 for <56197@debbugs.gnu.org>; Sun, 26 Jan 2025 06:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737902269; x=1738507069; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EBlAG4YWqvtwwkzDrjMBaQe+RhHzSpuY/eVn5ErZmio=; b=aEKY7LRGulhcM9FOGG6MLsW0S25tF+mB8AGzdflxW+kHJj+/QedOmAHVh98u9OLTfa e7Bes+9H9aajUSss8gRK3Vf5mRmxCpzqus9NJ8TsM00pkc4lPEENCKnPNvNZxc5EXh50 EnlXt81N+BE78YVMwShtAEJxWILqJTH7QRNWMXZg7W23ETKooMzpCgcDwVb2YbsXrVnv EJ3cmeYE3DQcZUNQ/Sjo45zO3Z8x6YYNt2waqY/xzdeWKA8ABIEy0I1XHCC3FbBdLIWU UoDGGVJtNj/Tis+57lC6o/8QHR62y4M7xGwgEDGxatqGp0HNqk/qRDybyjiZ84WqfEpg id+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737902269; x=1738507069; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EBlAG4YWqvtwwkzDrjMBaQe+RhHzSpuY/eVn5ErZmio=; b=K1jXDWjkdQrY3iycEnwn12urubsChkND8vV/lA2A0GpgvUgcPD/Z7/N4nPBSFhOUOI kKhsjc7vSQtwtHRLLTee49JunohE3lBxWxUx/ttglu0/0kj0mQCdmDovtTgUcayFoCEx Y3N32i329I9ejZ9MQ40louCzHLnaLu0VqHa0xpsU0kaKSR7GzwY+LfM+xRy1JYh4R4vu hY0ChKJrGf9bG0PaPjAZVNfg7+ivNu7SW84OSc2S6lWJrZzfQWIr1U1fpP7rbBdOYIZW qCnYG1nmLAx7OEeg1T6/4jTOF/WHo9skADOdAta4NYts+ApWGJaZCSmmhrU9jvgxdtc6 z3Cg== X-Forwarded-Encrypted: i=1; AJvYcCXPrtr5/Z1o9RZrS3Kv71Br1B9zJ7SfnF27Tpje5/XmYJKd5j90Nui9vsvUQ03nZLKZxZP9ng==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzFf3S4hZBo0rqxrYS9y95yVWHtO/gtt697JXfYnii9R5Cv0a42 PDeTdazfC2/KIvDzHS44e4tmcNQg7YUjnWUmEMxJJk0Z2sqf1fALxQesXmifemw= X-Gm-Gg: ASbGncsR7M2drs4DNal/XyIpEGNgA5mfnkn9PNP0zyPPhoz54AtnfB+6wEngS3E6cK0 6Fu7St27+76BLaA6jvk834ulb/QDRYczJwMv48eqypafWLOclroazleMojwi2GcFYGxK+FceqPe nFMjb6Wu9suW1tIZ7TpOrRgXBoMbWJFirKPt4Ost3J2qmokkDBov/X+48pZjLO3L71Wen2+pgMi 6nrr9a3ZKtNboQecBs90AODq/RL14ItYK6OZAwgLTa276LUrV98LFDXjnXxZ0Looo9s7sXauA5m mg== X-Google-Smtp-Source: AGHT+IF80i6e74oyA02dvuDsjKQYwaTds2PuCeDrm4Cbil+SyB1fttzH1v55Nr8aPt81SEOI1gJV8g== X-Received: by 2002:a17:902:f70d:b0:215:7fad:49ab with SMTP id d9443c01a7336-21c352ddfcemr628366625ad.10.1737902269465; Sun, 26 Jan 2025 06:37:49 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414df02sm46438825ad.182.2025.01.26.06.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 06:37:48 -0800 (PST) From: Maxim Cournoyer To: Felix Lechner Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <87wmei8anp.fsf@lease-up.com> (Felix Lechner's message of "Sat, 25 Jan 2025 20:24:42 -0800") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> Date: Sun, 26 Jan 2025 23:37:38 +0900 Message-ID: <878qqx7ia5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, Eli Zaretskii , 56197@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Felix, Felix Lechner writes: > Hi Eli, > > On Sat, Jan 25 2025, Eli Zaretskii wrote: > >>> Starting with Emacs 28, filling strings now happens in a >>> narrowed scope, and looses the leading indentation and can cause >>> the string to extend past the fill-column value. Introduce >>> `lisp-fill-paragraph-as-displayed' as a new variable allowing >>> opting out of this new behavior in specific scenarios (such as >>> when using the Scheme major mode, say). > > Thanks, but the name is terrible. The name fill-paragraph-as-displayed > is the standard behavior. It would be better to invert the logic and > call it fill-strings-instead-of-paragraphs. Do you mean 'fill-paragraph-as-displayed' (which reverts to past Emacs behavior) *should* be the default standard behavior? Because it currently isn't. About changing the name, I think the current naming captures the effect more generally, not mentioning particularities of docstrings, since the main effect is to avoid narrowing to the string when refilling, not avoiding the docstring special handling like filling the first sentence separately, which still holds when fill-paragraph-as-displayed is t (which I'm also not a big fan but it's a lesser pain point). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 09:40:29 2025 Received: (at 56197) by debbugs.gnu.org; 26 Jan 2025 14:40:29 +0000 Received: from localhost ([127.0.0.1]:55516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tc3oL-00016H-8F for submit@debbugs.gnu.org; Sun, 26 Jan 2025 09:40:29 -0500 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:60754) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tc3oI-00015t-GM for 56197@debbugs.gnu.org; Sun, 26 Jan 2025 09:40:27 -0500 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2ef748105deso4794349a91.1 for <56197@debbugs.gnu.org>; Sun, 26 Jan 2025 06:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737902420; x=1738507220; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GVf+9jlcoKbSQU3VE775tp3RaLb44MVffdeS5XP091A=; b=YzSQmzcc+eL5i4SjOsfeGrAXPQSRniuYHiyRzLqSSBWyGrSEa6n33I/g8rvv6NQq8A knUCeLbzDQEQU5E/7M/3L+MORbVZggRcMcpZKteD1oMQSijgHxOva7iepqRTrdUgAPaF 8pqtNi2NSgDb7TZUSJmb7I3i0t9kj+SeLlRTOHZG1aFtiEHNiJZaYtJw7GY4PVd4jOqD 6DPjnq1c6TPHO6uq1EE8QDVWeW65fnuqdPsrolcnSlJeR9ZYJK7SucYJs1ZEyvItAOp2 fAI5Ey+1Z24uLkajNZCbWo9PfBE2Y62Dehnr5XIY2fbCZZN7z0acL2f7pp3nfhreSMGV 8V3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737902420; x=1738507220; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GVf+9jlcoKbSQU3VE775tp3RaLb44MVffdeS5XP091A=; b=VNu0q+v6vU7zkmH5u8cIeT2uWPwbI9IsigNC9jRXpf2TwGhE4lRwVAq6Z2Cm1az1Kk P6IKsGDszyG8gld64f2qv8uz3C8naY3QwnFup9m8eGrIlVZ1rLDnDxyxpIGXmLcG1p+w pZALWArWEZFBtgscLaUaFRVeSBpHwXRitq3sT0W2miUND0sWD7xwolXe92JOespTkLBC OCGl3GAEfCNFFNyQe70pA0vDUcmJBnHwU6wScNnyusJLV2IR8iuH0qzKKr+muKXreAqT hz/JNxhi4nv15Zq0SHMYd4qr77/5L/FHJ6otJJ3yVka2HZdlWG/Xn5hP/etIT83bnp5z Kewg== X-Forwarded-Encrypted: i=1; AJvYcCWMnbuL/AWemRXE8432g1Zq08+QQGZGkm4JpFrZvvBBqM9YOA+9XKWSm5ioSSGvnPF1UuRbXw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz9C2RwgYhGhApQuXoQMdVkm++lK9pfZ2ogSVN74wsliT6gNVGP pbD1Vnl0h6R0Bf1yY50xX9wuQSILJyIQsclUSDsn6p/6GsO3AUT/ X-Gm-Gg: ASbGncs/N+MIptDOMdcXOfvd46P4DQxCwfrghQ8NJulS3s9anDVfUdP5p5mcY7DX+IU EE8M/TFVOZA45qxX1ihFahIT6d0Rl0e0MP2Y91EOcUDjhdEzeE1Yc+4E1x0ukFVj3Bf5WtkS/n6 KPTkoHYoivVvb7GV1Z/YXJmls3yM6gpvc8YVYEI3yqfoa7PMD7G3pW5etHBCfEphWHEoO5E0KOt zVVs+HVJbvxChQbNXxa3jzTOt7GV1WJpZAFjHbA8dut0+TtF3Q4ThpvTn2RcDs9qy852BRjUmfp Tw== X-Google-Smtp-Source: AGHT+IFdScFJRuV87/1QEAy+eTjwh4gVVfSInHjl4rjKkN/9Jl9hab2lqLjOOG1uhMjWpfnVZj++aw== X-Received: by 2002:a17:90b:258c:b0:2ee:d96a:5816 with SMTP id 98e67ed59e1d1-2f782c6ffaamr56263382a91.10.1737902420399; Sun, 26 Jan 2025 06:40:20 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffaf8b34sm5269806a91.30.2025.01.26.06.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 06:40:18 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <868qqyt4xw.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Jan 2025 09:22:35 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> Date: Sun, 26 Jan 2025 23:40:06 +0900 Message-ID: <874j1l7i61.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, Felix Lechner , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: >> From: Felix Lechner [...] >> Thanks, but the name is terrible. The name fill-paragraph-as-displayed >> is the standard behavior. It would be better to invert the logic and >> call it fill-strings-instead-of-paragraphs. > > I'm okay with looking for a better name, but > fill-strings-instead-of-paragraphs doesn't sound like a better one > (and "terrible" is an exaggeration, IMO). How about > fill-paragraph-as-doc-string, by default t? That's not a bad name, but my code simply avoids narrowing to strings, it preserves the special handling for doc strings such as filling the first sentence separately to the second one, so it wouldn't be accurate in the current version. We could also turn this special handling off (which would also be welcome in my use case), then your suggested naming would make sense. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 10:02:43 2025 Received: (at 56197) by debbugs.gnu.org; 26 Jan 2025 15:02:43 +0000 Received: from localhost ([127.0.0.1]:57473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tc49q-0005hl-Vo for submit@debbugs.gnu.org; Sun, 26 Jan 2025 10:02:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50558) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tc49o-0005hR-Eb for 56197@debbugs.gnu.org; Sun, 26 Jan 2025 10:02:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tc49g-0008Ju-OJ; Sun, 26 Jan 2025 10:02:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3ffCkW3e+411yB75AL2DzatEdv+inbi8pjmYkU182kM=; b=qjYFv6qkbs90 6zTgKi2QKVNpA/UkhAYXNDa2f7SOE6hpmcO3PfDDvKGNhRqwxFt5LPjUZnDYt2GaLCjidFsw+PD2L v70hneGfAuf3FXEv+xpQwDCq3T+mNbAgfBO8COJC7+YrKZqFMLY/7zbEQpXF5VqiERiwcezewzlL5 Y3weYE11KuWFJIk96nu95KAwtmiLIFAuHlItyYztcLCN6gcBlnJ5dlGol6gjz7kpC5outRQvRhZVo VDNF8rE1w0vua5fc8ziirwwLAr+U5apYfIOWs0D0XsU0fSd8EFOHRgWsOsjVTIhS3TGKwmPawmZOy F6vokgizaWw1ib4EdIB38A==; Date: Sun, 26 Jan 2025 17:02:25 +0200 Message-Id: <86wmehr532.fsf@gnu.org> From: Eli Zaretskii To: Maxim Cournoyer In-Reply-To: <874j1l7i61.fsf@gmail.com> (message from Maxim Cournoyer on Sun, 26 Jan 2025 23:40:06 +0900) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maxim Cournoyer > Cc: Felix Lechner , 56197@debbugs.gnu.org, > larsi@gnus.org, stefankangas@gmail.com > Date: Sun, 26 Jan 2025 23:40:06 +0900 > > Hi Eli, > > Eli Zaretskii writes: > > >> From: Felix Lechner > [...] > > >> Thanks, but the name is terrible. The name fill-paragraph-as-displayed > >> is the standard behavior. It would be better to invert the logic and > >> call it fill-strings-instead-of-paragraphs. > > > > I'm okay with looking for a better name, but > > fill-strings-instead-of-paragraphs doesn't sound like a better one > > (and "terrible" is an exaggeration, IMO). How about > > fill-paragraph-as-doc-string, by default t? > > That's not a bad name, but my code simply avoids narrowing to strings, > it preserves the special handling for doc strings such as filling the > first sentence separately to the second one, so it wouldn't be accurate > in the current version. We could also turn this special handling off > (which would also be welcome in my use case), then your suggested naming > would make sense. Sorry, I don't follow. The behavior introduced in Emacs 28 was to fill the paragraph as if it were a doc string, treating the first line specially. Setting the new variable you added disables that. That is why I said the variable should be t by default; disabling the new behavior would then mean resetting it to nil. So what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 08:45:50 2025 Received: (at 56197) by debbugs.gnu.org; 28 Jan 2025 13:45:50 +0000 Received: from localhost ([127.0.0.1]:35999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcluY-0003hg-02 for submit@debbugs.gnu.org; Tue, 28 Jan 2025 08:45:50 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:46255) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tcluV-0003hL-67 for 56197@debbugs.gnu.org; Tue, 28 Jan 2025 08:45:48 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-219f8263ae0so102937955ad.0 for <56197@debbugs.gnu.org>; Tue, 28 Jan 2025 05:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738071941; x=1738676741; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hat8J9QlK2V/0bRvtguwRXw/x2c23An0Pd4olFUTwAk=; b=S1afkNnx8svFC76cMDAZCXqSNgZt/QLZSTfnVzXSXX+Y0xLbxDcTqcRvG2Pe3qy0HB ZqFwiZ0ecZnaBqQgM63il01Q0XBB44FM4dw5YODYDnzBEYAYMAv3oML+6s6ywXOPEC7d qvvVhRp1RR/nt9vRWUeGmd30c9/TUdX4GJs7XxuNB3OGtXPEbviSxpvsuGffv46RZylL on8DuXDahMfOp/dFaYmm9gQ75RrNk47MSLVKM+BCXN2skO+QACuQ85r4zEuVqc3/FRJF 8Mz9JrSCVgpDRvGvG7j1hMjT9lBScMLbnEyxj6n8dxxJ230z7B7TCQa6kOXysHQuZPUw 4vEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738071941; x=1738676741; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hat8J9QlK2V/0bRvtguwRXw/x2c23An0Pd4olFUTwAk=; b=paJujh7OXg0efm23+C3jJRmIBk9SAQlf0ZOCgV9Y0n5xwmHOgUA7lrsueT9AUy2qcb SeJ1NZ7eeszeWJg55KHx9k3/1Mx+UbFmvcR7kiwtWCtj4dq1NuIKFVhGm1hB7M2u6e77 1SKlwaHS6oV9qmybLnj//EvB7U6BT5yJVpNXWrnCjFVgHMgh0uuPklFeMybuJ5iLlYja tKagMWrsa88JxuaAKTDU9BPTXozpuzbTp09fUns8o37NI9loylda37Uo5b30dDtafzUZ QLEuI8gGU4PVX0iHRGxDRSS72Z/fx2CEEvdEqb4q69HQ/bmZ1fTh9hM0QfuJXG0XgXEL RCyQ== X-Forwarded-Encrypted: i=1; AJvYcCWwQFn8z8xI5dnTqEuzPzdwy4mejRoQO32HCaI1RJYGo2tu4o85P4zB4LrU8ZBnxpzhsV6z6w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxW02qaQ2C0aiBOZl4Yz8DDHo2+LSFt6Ofrao3riDFIwZuyk1Vw NvS6TRKuU8ybTftQGHRHd6ZRCh4jbeBOhWvKbxfiDqqONR/CZKV8 X-Gm-Gg: ASbGncsroRScPFnuYec9CwR0V4q4TK2w2//YpJ9eGaHwgNhUzaljRYnJwilMD69wpJO 4zl9yh+3Rr8zK/NdUPXVzEONsAGyxOcoCp+u/vm4TQ0KyVldYInGwyMX7ZC1HeT4kblWga44CDF M/LKYf10WW9POCVQ2eEIPlS7NqmsSKdUG1EsYwLX4dk3Fj0P2jQxvk2ysku8iP/dp3pNdQa8t89 fvsyTXeuns+HRBLwNPlrIsx97KCoA71/1luOExGQiVOQC3dPiSzhTdSAXuf2VqMqBQg4mi2KgCu B2F21XqorVhX X-Google-Smtp-Source: AGHT+IFhEjnHhhSumgTyj8FnoKoLW1anAOY5TyOm85/xdvx7GZOQ9GDNM4QAhmLl283m4CCcyizw4w== X-Received: by 2002:a17:902:c94a:b0:216:2abc:195c with SMTP id d9443c01a7336-21c352dd6ffmr625082165ad.7.1738071940701; Tue, 28 Jan 2025 05:45:40 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da424d59dsm80525485ad.218.2025.01.28.05.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 05:45:40 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86wmehr532.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Jan 2025 17:02:25 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> Date: Tue, 28 Jan 2025 22:45:28 +0900 Message-ID: <87zfjbrr0n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, felix.lechner@lease-up.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: [...] >> > I'm okay with looking for a better name, but >> > fill-strings-instead-of-paragraphs doesn't sound like a better one >> > (and "terrible" is an exaggeration, IMO). How about >> > fill-paragraph-as-doc-string, by default t? >> >> That's not a bad name, but my code simply avoids narrowing to strings, >> it preserves the special handling for doc strings such as filling the >> first sentence separately to the second one, so it wouldn't be accurate >> in the current version. We could also turn this special handling off >> (which would also be welcome in my use case), then your suggested naming >> would make sense. > > Sorry, I don't follow. The behavior introduced in Emacs 28 was to > fill the paragraph as if it were a doc string, treating the first line > specially. Setting the new variable you added disables that. That is > why I said the variable should be t by default; disabling the new > behavior would then mean resetting it to nil. > > So what am I missing? Apologies for the confusion, I re-verified and indeed the special handling of the first line/second line is also disabled by the new 'lisp-fill-paragraph-as-displayed' variable I added (when t). That's one of two things it does, the other one (which was causing the protruding fill-column behavior) is the narrowing to the string being filled. This puts the string alone in a temp buffer and fills it there, which means there's no indentation anymore, which in turns causes the protruding of fill-column. I'm talking about this piece of code: --8<---------------cut here---------------start------------->8--- (when (ppss-string-terminator ppss) (goto-char string-start) ;; The string may be unterminated -- in that case, don't ;; narrow. (when (ignore-errors (prong (forward-sexp 1) t)) (narrow-to-region (1+ string-start) (1- (point))))) --8<---------------cut here---------------end--------------->8--- That's why I chose the name 'as-displayed', meaning preserve surrounding context and do not narrow to the string. With that said, I don't feel strongly about it, so if both Felix and you feel like 'fill-paragraph-as-doc-string' is more accurate/clear, please proceed :-). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 10:15:56 2025 Received: (at 56197) by debbugs.gnu.org; 28 Jan 2025 15:15:56 +0000 Received: from localhost ([127.0.0.1]:38018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcnJk-0000Mu-6n for submit@debbugs.gnu.org; Tue, 28 Jan 2025 10:15:56 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:38496) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tcnJh-0000Mk-4W for 56197@debbugs.gnu.org; Tue, 28 Jan 2025 10:15:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=CPS96TBZ1cZajkg kuz2LajCUlyKSLWRA/kAuNXil1jM=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=e4H/JIiehBqS/sajjatwmm+TU9cAQSyxdF3duvI5 722gYGPaVlhFad6rFYgxgG430fpKS5ZqiJGmlWEP0wiwuqZ1LLtGFD88qvVkNdXXi1QKVW Z1hdlzvjT6+m+WsVrdQOKBLIM5e8x0qMG2Q05ykk5hrKwHElWnvbreur7p0Ic= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 67381c1a (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Tue, 28 Jan 2025 15:15:49 +0000 (UTC) From: Felix Lechner To: Maxim Cournoyer Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <87zfjbrr0n.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 28 Jan 2025 22:45:28 +0900") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 28 Jan 2025 07:15:48 -0800 Message-ID: <87r04n55qz.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, Eli Zaretskii , 56197@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, Jan 28 2025, Maxim Cournoyer wrote: > if both Felix and you feel like 'fill-paragraph-as-doc-string' is more > accurate/clear I would call it 'fill-paragraphs-in-doc-string'. Please also note the plural. Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 05:24:21 2025 Received: (at 56197) by debbugs.gnu.org; 1 Feb 2025 10:24:21 +0000 Received: from localhost ([127.0.0.1]:56483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teAfl-0006Ta-0S for submit@debbugs.gnu.org; Sat, 01 Feb 2025 05:24:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56096) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teAfh-0006TI-Ng for 56197@debbugs.gnu.org; Sat, 01 Feb 2025 05:24:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teAfc-0002pb-04; Sat, 01 Feb 2025 05:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S4n266Ioh5gdrfXZ6g5c/RqZwJelYSfQs7a9bkIacyk=; b=Px0hEJYvyvdf iywZsyCzGnY+mqkoxs15Z6jBRf69FyGJMUZYQ6FwJzbaEZiXYWXNX8h0P2RGZkN0Uf6EnogT50YsC 9e2XjsfsSAgpJQkfPBLpF6bbuKFtJJFdGXyMTMP36KZJCd82Nq3rbe2Nr7ikjJP0rCFptxv700KjX 0s5a421Ary9MSV719eCcz014bHeL+MvSxVtLmtZJ23MwA1erm2Y1OxJ1/s4gQgGaCErhzi1gGjc3G oG6HgNLhvdfDe0CLEh36K0/Qb29G2RL1EVBGkPE/AQ1AOG9z5GEQ/PxSu2CnjfnuBZPIbgvlWfr0X 0adWACWAyaH7Tx89w3bj1A==; Date: Sat, 01 Feb 2025 12:24:07 +0200 Message-Id: <86h65egdyw.fsf@gnu.org> From: Eli Zaretskii To: Felix Lechner In-Reply-To: <87r04n55qz.fsf@lease-up.com> (message from Felix Lechner on Tue, 28 Jan 2025 07:15:48 -0800) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Felix Lechner > Cc: Eli Zaretskii , 56197@debbugs.gnu.org, larsi@gnus.org, > stefankangas@gmail.com > Date: Tue, 28 Jan 2025 07:15:48 -0800 > > Hi, > > On Tue, Jan 28 2025, Maxim Cournoyer wrote: > > > if both Felix and you feel like 'fill-paragraph-as-doc-string' is more > > accurate/clear > > I would call it 'fill-paragraphs-in-doc-string'. Please also note the > plural. Thanks, I renamed the variable. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 10:30:05 2025 Received: (at 56197) by debbugs.gnu.org; 2 Feb 2025 15:30:05 +0000 Received: from localhost ([127.0.0.1]:35882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tebvA-0004HK-PZ for submit@debbugs.gnu.org; Sun, 02 Feb 2025 10:30:05 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:32978) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tebv7-0004GP-Uo for 56197@debbugs.gnu.org; Sun, 02 Feb 2025 10:30:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Ebjv34et4wRHV40 ucBRyWyjV/6gOcTNtBC0reZinYq8=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=cUjJ1VdRnjbXGm484VaaHmIJJ6uIH+AJp5NdeuYU JlOgv+DP1zwJDcxpmya9gSjNub3iDWTag8h9n9vm98tzWQbYjRV6W78YWPBJnLbWh5ij3B ug2Nnm/iGd6hBCux5CFD847goej64uxn9zTV1FdOxXKjB8z3R5lXjw0fiJv+g= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id c277f63d (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 2 Feb 2025 15:29:58 +0000 (UTC) From: Felix Lechner To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86h65egdyw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Feb 2025 12:24:07 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sun, 02 Feb 2025 07:29:58 -0800 Message-ID: <87jza8icuh.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, On Sat, Feb 01 2025, Eli Zaretskii wrote: > Thanks, I renamed the variable. There may have been an oversight. Do you prefer the 'as' preposition over 'in'? [1] It does not sound like standard English to me. Kind regards, Felix [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e067f2763fd52b78342b5c759205032227e82ebe From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 11:23:29 2025 Received: (at 56197) by debbugs.gnu.org; 2 Feb 2025 16:23:29 +0000 Received: from localhost ([127.0.0.1]:35959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teckq-0006kv-OQ for submit@debbugs.gnu.org; Sun, 02 Feb 2025 11:23:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teckn-0006kX-N8 for 56197@debbugs.gnu.org; Sun, 02 Feb 2025 11:23:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teckh-0003rk-U7; Sun, 02 Feb 2025 11:23:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i/q6QLJ3EwohAm3wgTNVEQAxYZMFWvT6DBpWASGHvBM=; b=Trws3saOLugy Q2ISTUoaIp7LMZ7ZE7qjjJWzcdafs30RIsk41i5bJK9DGlo4IH0SFM+S5wo0Gx6ebwIvn+fU0jnMP 9IZc1q8ZtuMrPAFeE3mqDArX3LVSGz65QMILbAmrqgJ0Uvm+4TRL7T869Y4OaXBu7QZq1TCLcVYVo YxpkDGjh4gGIQ0Vls/y9itp89wrF5yWPsVE8NwS4uIFD+96D+ViN8oB0fCiBxbauli5/MdJly0mTN +Q80UZ/TdWSdv2GOK8nC0QCfOMtlr1UaRe7uD5wjtqfXbvY5EjYpc1gnNRqMRhGeF4YTsOnqLSDr6 /p7oeqc5YjKiYdgpp5dN1g==; Date: Sun, 02 Feb 2025 18:23:15 +0200 Message-Id: <86seowco3w.fsf@gnu.org> From: Eli Zaretskii To: Felix Lechner In-Reply-To: <87jza8icuh.fsf@lease-up.com> (message from Felix Lechner on Sun, 02 Feb 2025 07:29:58 -0800) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> <87jza8icuh.fsf@lease-up.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Felix Lechner > Cc: maxim.cournoyer@gmail.com, 56197@debbugs.gnu.org, larsi@gnus.org, > stefankangas@gmail.com > Date: Sun, 02 Feb 2025 07:29:58 -0800 > > Hi Eli, > > On Sat, Feb 01 2025, Eli Zaretskii wrote: > > > Thanks, I renamed the variable. > > There may have been an oversight. Do you prefer the 'as' preposition > over 'in'? [1] It does not sound like standard English to me. This is not about preferences. "As" is correct because we apply the rules of a doc string. "In" would be correct if we were talking about filling doc strings and them only, which is not the case here. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 16:13:20 2025 Received: (at 56197) by debbugs.gnu.org; 2 Feb 2025 21:13:20 +0000 Received: from localhost ([127.0.0.1]:36471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tehHL-0006yN-J2 for submit@debbugs.gnu.org; Sun, 02 Feb 2025 16:13:19 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:53058) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tehHI-0006yC-No for 56197@debbugs.gnu.org; Sun, 02 Feb 2025 16:13:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=fyCWfhXSu/Ld0ut owYVu53h9+leFVy7A2/NBmDifXms=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=d7MUpol2IzPDu+8+V9tCJuSfAd34cJjw/byIdEyE 67pwc4EKJDCB/0Oot8gr19rTt2lTY2jQxYIq/mdUyA1hJy9SRKXh96CG67b5+8idorgZ87 4PlasdqcUD0ng3eESrtsIGG5IW2UjBJLkgAatxk9e+apss+iRMt7Jw5j1sgdM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 7c832f7e (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 2 Feb 2025 21:13:13 +0000 (UTC) From: Felix Lechner To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86seowco3w.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Feb 2025 18:23:15 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> <87jza8icuh.fsf@lease-up.com> <86seowco3w.fsf@gnu.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sun, 02 Feb 2025 13:13:12 -0800 Message-ID: <87cyg0gidz.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, On Sun, Feb 02 2025, Eli Zaretskii wrote: > "In" would be correct if we were talking about filling doc strings and > them only Then I would use 'fill-strings-like-doc-strings' or, if the prefix must match, 'fill-paragraphs-in-strings-like-doc-strings'. Please also note the plural throughout. > "As" is correct because we apply the rules of a doc string. I assume you are referring to the recommendations from the Emacs manual. [1] Kind regards Felix [1] https://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html#Documentation-Tips From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 06:53:12 2025 Received: (at 56197) by debbugs.gnu.org; 3 Feb 2025 11:53:12 +0000 Received: from localhost ([127.0.0.1]:38101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tev0q-00023c-4I for submit@debbugs.gnu.org; Mon, 03 Feb 2025 06:53:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58980) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tev0l-00023M-LQ for 56197@debbugs.gnu.org; Mon, 03 Feb 2025 06:53:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tev0f-0000Ey-JK; Mon, 03 Feb 2025 06:53:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zVkitarNulyyZiaTP6Vf9F05DKuVwPUMVDN6sOL1G9M=; b=GojODVGLheP/ SnDJj/MlJqQQs6/jlYABfpWiwC5h1ALP5v4X2IRb9AcpAtKsNnzhIldDGybWA+V3KqgagueaC0Pg6 kXnCcLMjDiloMVdOgMzrO5j/JE41ScUBIg31AYQ3cxs6IXIKZrj6Gi0SBch+nEiu/066t62HzgFsM 7H/Jrh/PxCKDAOVMElBVlVSC88V8ZgmUp/eAkBXYPe+L2bYSA1f7Tks9Dl1T/2DOTgAtRlOagOdtB Mb3qVpNvaljzs/MeZ0c3f6y78p/sJ9oQW9ondn6F7ph5e/kcOrbM0gwUa5qfP70iu2HV+MDOCcsIT u4zjyrA9FLu47K9oKGUoLA==; Date: Mon, 03 Feb 2025 13:52:51 +0200 Message-Id: <86bjvjckj0.fsf@gnu.org> From: Eli Zaretskii To: Felix Lechner In-Reply-To: <87cyg0gidz.fsf@lease-up.com> (message from Felix Lechner on Sun, 02 Feb 2025 13:13:12 -0800) Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> <87jza8icuh.fsf@lease-up.com> <86seowco3w.fsf@gnu.org> <87cyg0gidz.fsf@lease-up.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Felix Lechner > Cc: maxim.cournoyer@gmail.com, 56197@debbugs.gnu.org, larsi@gnus.org, > stefankangas@gmail.com > Date: Sun, 02 Feb 2025 13:13:12 -0800 > > Hi Eli, > > On Sun, Feb 02 2025, Eli Zaretskii wrote: > > > "In" would be correct if we were talking about filling doc strings and > > them only > > Then I would use 'fill-strings-like-doc-strings' or, if the prefix must > match, 'fill-paragraphs-in-strings-like-doc-strings'. "As" and "like" are synonyms in this case. And using "string" twice in the name sounds like unnecessary tautology to me. "Paragraphs" is better, because we do really fill paragraphs, not strings. So I see nothing wrong with the current name that would justify yet another rename. We are splitting hair, IMO. > > "As" is correct because we apply the rules of a doc string. > > I assume you are referring to the recommendations from the Emacs > manual. [1] I referred to the basics of the English language. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 08:31:28 2025 Received: (at 56197) by debbugs.gnu.org; 3 Feb 2025 13:31:28 +0000 Received: from localhost ([127.0.0.1]:38321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tewXw-0007Ov-7C for submit@debbugs.gnu.org; Mon, 03 Feb 2025 08:31:28 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:56645) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tewXs-0007Of-O1 for 56197@debbugs.gnu.org; Mon, 03 Feb 2025 08:31:26 -0500 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2166360285dso70716695ad.1 for <56197@debbugs.gnu.org>; Mon, 03 Feb 2025 05:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738589478; x=1739194278; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NEpFAYDc81J7hHwpzpA2wW3ga1P2WRWt2SqzycpjOII=; b=mYoR7EL5543Fc4MmW3kU1ZEzYrti0OShUXokRbGiZ0GFiTLYapBNTkWz7YP3iR9X2M +SKubJB9TMqtId51xp/xiTMjYvykuJ5prQLquJrKQblNSw18FWKMLoL/uaVgkmxRrnCV qBpY21ZLnUXVUEQdmPD0NPY55P4laS6Z4cXf9ZUNVmuJzKMUGa9jrMAZN2pS+kh4/qDP UAjvkvABajep8E5yk9/zDfFVxa8AG1VZ+tvCXdNiw3zziE6WGcGrMTCLCpIOCSUAyEky z3Ch6u73VX4tFiSL+xam0AXbB2sTsC69+ic+gQ9wMQF441GwlmU6ClDk/q6V71s+ohOs x4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738589478; x=1739194278; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NEpFAYDc81J7hHwpzpA2wW3ga1P2WRWt2SqzycpjOII=; b=eluTJOJGSygVS5TubYC6ciQsh05NawHDJsP3HXXQxBE9/lchfzVzhP05O3uGvGoyR4 3vT2BhSUNjt7W7SV6993Owb14hFmFeRV6yuf6SVuDRUOSJPV3pHZyU+y9hfhh/0EliIv NDIatRx23KMeScZZYV+659grVZA7UO+k/+ZvrEh9f3VdAMJFtt93am+PRseQOc2ZWBc9 NcJOf5JbrrcHGlI71kOLgpRCUM3O3u+HbLpPF9CrjPYCsKUw9osXbhNrVnt+o5J/udhO wh7cMiDemLGjli/w5+QHvH4ZqkCYX7KiFReDHOFeq1IFqEiMR3yZ0hxJOCzFMJzHPM8U 84hw== X-Forwarded-Encrypted: i=1; AJvYcCXb6Pv0fow4lwCYv1pGL6mghfcCvCHWc/JLFnlgsYlf2AvG4peNi3+I/OU6wkzcahXWd7B/sw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzfP/wieiew63slfYJGb0Et9FVlzrp6WheowKH8ANXJ2YFkFOQs +PtBvLP95JJwNO4zTT7fyBfaR4hStW7aJOtowmjFc6YwIGxntmgs X-Gm-Gg: ASbGncvpxkUHRvfoUAiBJJRITfUrBdznkqxkOl7ZH+aVEC6+tfq4qFx+KttTOvRK0Z+ zN2AL1qOVmWpTOhNXrkubADBhbLO9lYV+oUrFOvEYkrOyES62Qrq4VsXPlQoIxeltYeyTDI36s8 WvHgjWyGiOtslC/pO5MPjnoOUycrXOX0hBlgeCy4rP66+EOBrPgkTX60NR/HwiZdOZJhKEE55Yl PWZVU0SXqeLR2/tEkCUmJ8pxG7ME+HAhobH2XiWwQXO5HBQz46gOEnp9sR8vf67MIyRNDcCbkV0 DzOEP+RCAGNR X-Google-Smtp-Source: AGHT+IGoGmqW+qPAl05Yhn2R9bdRXuI87MZmIZZAfNtKYNeDRwA6kskRLs0x2CxMztxUa3DclnWu7A== X-Received: by 2002:a17:903:1c6:b0:21a:8382:fcbb with SMTP id d9443c01a7336-21dd7d73bd9mr376423365ad.25.1738589478373; Mon, 03 Feb 2025 05:31:18 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de330462bsm75231055ad.204.2025.02.03.05.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 05:31:17 -0800 (PST) From: Maxim Cournoyer To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86bjvjckj0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Feb 2025 13:52:51 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> <87jza8icuh.fsf@lease-up.com> <86seowco3w.fsf@gnu.org> <87cyg0gidz.fsf@lease-up.com> <86bjvjckj0.fsf@gnu.org> Date: Mon, 03 Feb 2025 22:31:04 +0900 Message-ID: <8734gvf947.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, Felix Lechner , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Eli Zaretskii writes: >> From: Felix Lechner >> Cc: maxim.cournoyer@gmail.com, 56197@debbugs.gnu.org, larsi@gnus.org, >> stefankangas@gmail.com >> Date: Sun, 02 Feb 2025 13:13:12 -0800 >> >> Hi Eli, >> >> On Sun, Feb 02 2025, Eli Zaretskii wrote: >> >> > "In" would be correct if we were talking about filling doc strings and >> > them only >> >> Then I would use 'fill-strings-like-doc-strings' or, if the prefix must >> match, 'fill-paragraphs-in-strings-like-doc-strings'. Felix, what is the reason you insist on the 'in-strings' part? Is this to try to express the fact that the code is narrowing down on strings and *then* filling, rather than filling everything at and around the pointer? > "As" and "like" are synonyms in this case. And using "string" twice > in the name sounds like unnecessary tautology to me. "Paragraphs" is > better, because we do really fill paragraphs, not strings. > > So I see nothing wrong with the current name that would justify yet > another rename. We are splitting hair, IMO. It seems to me there is diminishing returns at this point trying to nail the elusive perfect name :-). I'd suggest we move on. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 10:33:13 2025 Received: (at 56197) by debbugs.gnu.org; 3 Feb 2025 15:33:14 +0000 Received: from localhost ([127.0.0.1]:40797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teyRl-0005lO-Gi for submit@debbugs.gnu.org; Mon, 03 Feb 2025 10:33:13 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:53028) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teyRi-0005lD-J0 for 56197@debbugs.gnu.org; Mon, 03 Feb 2025 10:33:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=8Aw8AAdZZS3lO/O 9qhn0ulxz9zoRBTFZdyXwLgbopls=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=V/uQiMTQGIy7hj0kKrrP5d8+eSp8yRUB4VU3sevN PpYloIhrjCSzlYwhrNLoO9FVf91r5Pn45G7wAya5441c7JdLp8iHKS01/VbZ0AajWApXSG FfOS1z05uDqFTZu0QctFTgXbJyNO0SYSVPJFej9mYRS5nZDioIby7NcryyDKM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id f48ce72e (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 3 Feb 2025 15:33:07 +0000 (UTC) From: Felix Lechner To: Eli Zaretskii Subject: Re: [PATCH v3] lisp: Introduce a `lisp-fill-paragraph-as-displayed' variable. In-Reply-To: <86bjvjckj0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Feb 2025 13:52:51 +0200") References: <20250121025207.19966-1-maxim.cournoyer@gmail.com> <86plkburg7.fsf@gnu.org> <87wmei8anp.fsf@lease-up.com> <868qqyt4xw.fsf@gnu.org> <874j1l7i61.fsf@gmail.com> <86wmehr532.fsf@gnu.org> <87zfjbrr0n.fsf@gmail.com> <87r04n55qz.fsf@lease-up.com> <86h65egdyw.fsf@gnu.org> <87jza8icuh.fsf@lease-up.com> <86seowco3w.fsf@gnu.org> <87cyg0gidz.fsf@lease-up.com> <86bjvjckj0.fsf@gnu.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 03 Feb 2025 07:33:06 -0800 Message-ID: <87seovf3gt.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56197 Cc: larsi@gnus.org, 56197@debbugs.gnu.org, maxim.cournoyer@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, On Mon, Feb 03 2025, Eli Zaretskii wrote: > "As" and "like" are synonyms in this case. They are not the same. One is a preposition, and the other is a conjunction. [1][2] [1] https://dictionary.cambridge.org/grammar/british-grammar/as-or-like [2] https://www.grammarly.com/blog/commonly-confused-words/like-vs-as/ > And using "string" twice in the name sounds like unnecessary tautology A tautotology means something that's always true. It's a term from formal logic. Did you mean a pleonasm instead? [3] People often use both words interchangably, but a pleonasm is the right way to describe logically redundant language. My suggestion isn't redundant because docstrings are more specific than strings. For example, there is no redundancy in the statement "the boat looked like a sailboat." Therefore it is also not redundant to "format a string like a docstring". The logical principle of the general vs. the specific has been around for 1,800 years: The Beraita of Rabbi Yishmael says in verse 4 (with my elaboration): "When a general rule is followed by an explicit particular, the rule is limited to the explicit particular." [4][5] [3] https://en.wikipedia.org/wiki/Pleonasm [4] https://www.sefaria.org/Sifra%2C_Baraita_DeRabbi_Yishmael?lang=bi [5] https://outorah.org/p/6480 > "Paragraphs" is better, because we do really fill paragraphs, not > strings. Are we? I think we are formatting strings. > We are splitting hair, IMO. A love of language helps people communicate. For example, I talk to my neighbor in English, and not in Python (even though I think he is a programmer). I think you chose 'as' simply because it is shorter. Of course, you are entitled to your choices. Also, aren't you and I picky the same way? As Maxim noted, you disagree with my preference for "in" but unlike me, you signalled agreement where there was none. You wrote that you changed the name but withheld the details. I had to go look. Ultimately, you can do whatever you like. I am truly grateful for Emacs. Thank you for maintaining it! Kind regards Felix From unknown Sat Jun 21 10:42:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Mar 2025 12:24:19 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator