GNU bug report logs - #56156
29.0.50; Options/Save not saving desktop-save-mode

Previous Next

Package: emacs;

Reported by: Gerd Möllmann <gerd.moellmann <at> gmail.com>

Date: Thu, 23 Jun 2022 09:15:02 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56156 in the body.
You can then email your comments to 56156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#56156; Package emacs. (Thu, 23 Jun 2022 09:15:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Gerd Möllmann <gerd.moellmann <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 23 Jun 2022 09:15:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Options/Save not saving desktop-save-mode
Date: Thu, 23 Jun 2022 11:14:43 +0200

[Message part 1 (text/plain, inline)]
Select Options/Save State Between Sessions, then Options/Save Options.

This does not save the value of desktop-save-mode.  M-x customize-group
shows that it has been changed.

Patch attaches


[0001-Save-desktop-save-mode-when-changed-from-menu.patch (text/x-patch, inline)]
From b505a909a6d761fce303c8ecd7771d7e3e20ff15 Mon Sep 17 00:00:00 2001
From: Gerd Moellmann <gerd.moellmann <at> gmail.com>
Date: Thu, 23 Jun 2022 10:54:05 +0200
Subject: [PATCH] Save desktop-save-mode when changed from menu

* lisp/menu-bar.el (menu-bar-options-save): Save desktop-save-mode.
---
 lisp/menu-bar.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 488bf05f3a..4a943d2528 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -792,6 +792,7 @@ menu-bar-options-save
     (dolist (elt '(scroll-bar-mode
 		   debug-on-quit debug-on-error
 		   ;; Somehow this works, when tool-bar and menu-bar don't.
+                   desktop-save-mode
 		   tooltip-mode window-divider-mode
 		   save-place-mode uniquify-buffer-name-style fringe-mode
 		   indicate-empty-lines indicate-buffer-boundaries
-- 
2.36.1
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56156; Package emacs. (Thu, 23 Jun 2022 12:39:02 GMT) Full text and rfc822 format available.

Message #8 received at 56156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 56156 <at> debbugs.gnu.org
Subject: Re: bug#56156: 29.0.50; Options/Save not saving desktop-save-mode
Date: Thu, 23 Jun 2022 14:38:25 +0200

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> * lisp/menu-bar.el (menu-bar-options-save): Save desktop-save-mode.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to 56156 <at> debbugs.gnu.org and Gerd Möllmann <gerd.moellmann <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 23 Jun 2022 12:39:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 22 Jul 2022 11:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.