GNU bug report logs - #5615
23.1.92; [PATCH] term.el: Calculation of window height is bad

Previous Next

Package: emacs;

Reported by: irieshinsuke <at> yahoo.co.jp

Date: Sun, 21 Feb 2010 06:10:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: larsi <at> gnus.org, irieshinsuke <at> yahoo.co.jp, 5615 <at> debbugs.gnu.org
Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch)
Date: Fri, 11 Aug 2017 09:32:43 +0300

> From: npostavs <at> users.sourceforge.net
> Date: Thu, 10 Aug 2017 20:45:16 -0400
> Cc: IRIE Shinsuke <irieshinsuke <at> yahoo.co.jp>, 5615 <at> debbugs.gnu.org
> 
> Current Emacs still uses the same (1- (window-height)) expression, but I
> can't understand from the description when exactly this gives the wrong
> result.  Furthermore, I don't see any justification which would explain
> why the new proposed significantly more complicated computation is more
> correct.  I think we should just use window-text-height.

I think you are right.  If no one objects in a few days, please push
your change.

Thanks.
This bug report was last modified 7 years and 358 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.