From unknown Mon Sep 08 22:05:16 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad Resent-From: IRIE Shinsuke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2010 06:10:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5615 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: To: 5615@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.126673259527550 (code B ref -1); Sun, 21 Feb 2010 06:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2010 06:09:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nj50t-0007AJ-3O for submit@debbugs.gnu.org; Sun, 21 Feb 2010 01:09:55 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nj4pC-000725-MW for submit@debbugs.gnu.org; Sun, 21 Feb 2010 00:57:51 -0500 Received: from mx10.gnu.org ([199.232.76.166]:40561) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nj4p9-0002Vq-JB for submit@debbugs.gnu.org; Sun, 21 Feb 2010 00:57:47 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nj4p8-0006Ge-MR for submit@debbugs.gnu.org; Sun, 21 Feb 2010 00:57:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,UNPARSEABLE_RELAY autolearn=no version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:60224) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nj4p8-0006GY-B7 for submit@debbugs.gnu.org; Sun, 21 Feb 2010 00:57:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nj4p7-0007Xl-9V for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2010 00:57:45 -0500 Received: from [140.186.70.92] (port=54833 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nj4p5-0007Xd-Uq for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2010 00:57:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nj4p5-0003jN-49 for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2010 00:57:43 -0500 Received: from mail-yx0-f187.google.com ([209.85.210.187]:53890) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nj4p4-0003jI-WA for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2010 00:57:43 -0500 Received: by yxe17 with SMTP id 17so1702360yxe.26 for ; Sat, 20 Feb 2010 21:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:x-enigmail-version :content-type; bh=aU6tTyz7+1qn988oNnA1LOA/nkNqdcPpzBeQhA4J8cQ=; b=iTz2hTO4ndVFELxvHjuSkBSInLz1zjb0MppyHgYhPJXUXWSi+Pa2aJa0Z1IXQg/W+X WzFXCbe5rspUxa1PgC85rRKbV5Ayt+d5mTwoEcooiCxVW8N0ytU7tT0A3VvNjtjVqPne b3a0g558wJQWbjiWouQIRSOtYBAevHyIf3phQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:x-enigmail-version:content-type; b=QCd+WxotIse8KxOxMfnHevEsrNKIZTTQuRwuvmGv4+IEjVpeTzwRvV7MXk3mAc0e39 C5ap7+46a+Vs4B6wPGEFrgLjMS2rNrIFg0nNhpw8JzR5KGVfxuFZO2eahOK8Gj2lMNHE cefR4jkU45Ji1G+OCetpKlpFRc7HeEBjpiEl0= Received: by 10.101.174.12 with SMTP id b12mr8940218anp.120.1266731861813; Sat, 20 Feb 2010 21:57:41 -0800 (PST) Received: from ?114.51.50.45? (EM114-51-50-45.pool.e-mobile.ne.jp [114.51.50.45]) by mx.google.com with ESMTPS id 5sm1015947yxd.71.2010.02.20.21.57.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Feb 2010 21:57:40 -0800 (PST) Message-ID: <4B80CB5A.8080306@yahoo.co.jp> Date: Sun, 21 Feb 2010 14:57:46 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 MIME-Version: 1.0 X-Enigmail-Version: 1.0.1 Content-Type: multipart/mixed; boundary="------------040102090205080206080201" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Mailman-Approved-At: Sun, 21 Feb 2010 01:09:54 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) This is a multi-part message in MIME format. --------------040102090205080206080201 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit When I use term-mode (ansi-term), the bottom row of the terminal often disappears from the window. For example, if I execute Emacs in ansi-term with -nw option, the minibuffer is unusable because it becomes completely hidden. I investigated this problem and found the solution. In term.el, the number of rows of the terminal window is calculated as: (1- (window-height)) This expression, however, doesn't always return exact value from lack of consideration to the header line height and the spacing of each row. So I tested the better expression instead: (if (display-graphic-p) (let ((e (window-inside-pixel-edges)) (s (or line-spacing 0))) (/ (+ (- (nth 3 e) (cadr e)) s) (+ (frame-char-height) s))) (window-text-height)) and it seems to work fine. We can test this expression by evaluating the following code before starting ansi-term: (add-hook 'term-mode-hook (lambda () (fset 'term-window-height #'(lambda () (if (display-graphic-p) (let ((e (window-inside-pixel-edges)) (s (or line-spacing 0))) (/ (+ (- (nth 3 e) (cadr e)) s) (+ (frame-char-height) s))) (window-text-height)))) (fset 'term-check-size #'(lambda (process) (when (or (/= term-height (term-window-height)) (/= term-width (term-window-width))) (term-reset-size (term-window-height) (term-window-width)) (set-process-window-size process term-height term-width)))) (setq term-height (term-window-height)))) or applying the patch I attached. --------------040102090205080206080201 Content-Type: text/x-diff; name="term-window-height.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="term-window-height.patch" === modified file 'lisp/term.el' *** old/lisp/term.el 2010-02-18 01:32:00 +0000 --- new/lisp/term.el 2010-02-20 18:02:48 +0000 *************** *** 942,947 **** --- 942,954 ---- (window-width) (1- (window-width))))) + (defun term-window-height () + (if (display-graphic-p) + (let ((e (window-inside-pixel-edges)) + (s (or line-spacing 0))) + (/ (+ (- (nth 3 e) (cadr e)) s) + (+ (frame-char-height) s))) + (window-text-height))) (put 'term-mode 'mode-class 'special) *************** *** 1039,1045 **** (make-local-variable 'term-height) (make-local-variable 'term-width) (setq term-width (term-window-width)) ! (setq term-height (1- (window-height))) (make-local-variable 'term-terminal-parameter) (make-local-variable 'term-saved-cursor) (make-local-variable 'term-last-input-start) --- 1046,1052 ---- (make-local-variable 'term-height) (make-local-variable 'term-width) (setq term-width (term-window-width)) ! (setq term-height (term-window-height)) (make-local-variable 'term-terminal-parameter) (make-local-variable 'term-saved-cursor) (make-local-variable 'term-last-input-start) *************** *** 1182,1190 **** found)) (defun term-check-size (process) ! (when (or (/= term-height (1- (window-height))) (/= term-width (term-window-width))) ! (term-reset-size (1- (window-height)) (term-window-width)) (set-process-window-size process term-height term-width))) (defun term-send-raw-string (chars) --- 1189,1197 ---- found)) (defun term-check-size (process) ! (when (or (/= term-height (term-window-height)) (/= term-width (term-window-width))) ! (term-reset-size (term-window-height) (term-window-width)) (set-process-window-size process term-height term-width))) (defun term-send-raw-string (chars) --------------040102090205080206080201-- From unknown Mon Sep 08 22:05:16 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) References: <4B80CB5A.8080306@yahoo.co.jp> In-Reply-To: <4B80CB5A.8080306@yahoo.co.jp> Resent-From: IRIE Shinsuke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2010 10:23:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.12689941597863 (code B ref 5615); Fri, 19 Mar 2010 10:23:02 +0000 Received: (at 5615) by debbugs.gnu.org; 19 Mar 2010 10:22:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZLi-00022l-TY for submit@debbugs.gnu.org; Fri, 19 Mar 2010 06:22:39 -0400 Received: from mail-yx0-f176.google.com ([209.85.210.176]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZLg-00022f-NK for 5615@debbugs.gnu.org; Fri, 19 Mar 2010 06:22:37 -0400 Received: by yxe6 with SMTP id 6so505101yxe.0 for <5615@debbugs.gnu.org>; Fri, 19 Mar 2010 03:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:x-enigmail-version :content-type:content-transfer-encoding; bh=sx6ZxUGenGl2hslW1qU2ntot64KyIUWnrx2TjB8mPLY=; b=f3Z3fR1k3M+OIgDMXQ9t0785S4K3DnU+zwiFb0TU3crW/Rbxonn3piW7+XBwqZTm4+ qvMfCtdf+FGGN8ynmSPAXWdg3iwppCPcITGvoSlluHQPndnDNQR4BSKqfI7aYulFIiMn cDHUrSFWNoOs0JZzNc6h3VzRPLiYVTjLiA2Os= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:x-enigmail-version:content-type:content-transfer-encoding; b=n2wvIPJNDfVDf7SteCDJKSkHOFFPmv7tahVMTSdWuU93I1dOKt3SRi3UscKvzDlvH4 n7CBb6qaKKKFHkkHpMQdboE7MCOyx/w3pKh/RlySNQfm48MO5nTzXITblTdqTyHYB+ka Ug8E9nRvuUzU3b9z7ei4kSkBPxOxkadwAgRPM= Received: by 10.100.233.26 with SMTP id f26mr6846498anh.1.1268994153732; Fri, 19 Mar 2010 03:22:33 -0700 (PDT) Received: from [114.51.18.28] (EM114-51-18-28.pool.e-mobile.ne.jp [114.51.18.28]) by mx.google.com with ESMTPS id 16sm605054gxk.5.2010.03.19.03.22.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 03:22:32 -0700 (PDT) Message-ID: <4BA3508D.8030707@yahoo.co.jp> Date: Fri, 19 Mar 2010 19:23:09 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) Sorry, the patch I sent with previous mail is bad, because the previous patch was made without considering `line-spacing' specified by a floating point number or frame-parameter. So I wrote the new patch. Please check it. IRIE Shinsuke From unknown Mon Sep 08 22:05:16 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) References: <4B80CB5A.8080306@yahoo.co.jp> In-Reply-To: <4B80CB5A.8080306@yahoo.co.jp> Resent-From: IRIE Shinsuke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2010 10:25:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.12689942767923 (code B ref 5615); Fri, 19 Mar 2010 10:25:02 +0000 Received: (at 5615) by debbugs.gnu.org; 19 Mar 2010 10:24:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZNc-00023k-44 for submit@debbugs.gnu.org; Fri, 19 Mar 2010 06:24:36 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZNa-00023d-GV for 5615@debbugs.gnu.org; Fri, 19 Mar 2010 06:24:34 -0400 Received: by gyh4 with SMTP id 4so1469045gyh.3 for <5615@debbugs.gnu.org>; Fri, 19 Mar 2010 03:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:x-enigmail-version :content-type; bh=NhH2gwkHm8lUa2I8CsV1Ms3s3C4sqr84P4eOtqNsa+E=; b=VrOSFJKJQFBsrQctgAg4XQL4ESBQu+iQW1Hs3Sx0HN4IV44KJ3xH7Ufi+6NPBIIlL+ OTlVgki3Vu8P25FLlyo6AXJiVM68COxnG1sVKKcL3n2Nh3oVwG65KK2CRh7IuSx9w0yN vw4wmqtq03Loi2z7mh7zCQ1nMK39+VpWtj4gg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:x-enigmail-version:content-type; b=eEzml1En1KN/RAaYwrhbonC4y2s+AyAGjHHa70uH0wtq9Yypw81RaF+Fsi/GEySbOV n2xJMozzuaatME2PCtLtX3KvpioZpuTEGWNESomsfWy8870cTBFxstbIZ+SCe/Bzr1TX AuThsp0nxPQ7H1eVgPNXf0uZQL56YQaDi6/2o= Received: by 10.91.23.19 with SMTP id a19mr302074agj.49.1268994269264; Fri, 19 Mar 2010 03:24:29 -0700 (PDT) Received: from [114.51.18.28] (EM114-51-18-28.pool.e-mobile.ne.jp [114.51.18.28]) by mx.google.com with ESMTPS id 13sm638589gxk.4.2010.03.19.03.24.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 03:24:28 -0700 (PDT) Message-ID: <4BA35102.7050506@yahoo.co.jp> Date: Fri, 19 Mar 2010 19:25:06 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 X-Enigmail-Version: 1.0.1 Content-Type: multipart/mixed; boundary="------------000004020401050906040209" X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format. --------------000004020401050906040209 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sorry, the patch I sent with previous mail is bad, because the previous patch was made without considering `line-spacing' specified by a floating point number or frame-parameter. So I wrote the new patch. Please check it. IRIE Shinsuke --------------000004020401050906040209 Content-Type: text/x-diff; name="term-window-height-newpatch.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="term-window-height-newpatch.patch" === modified file 'lisp/term.el' *** old/lisp/term.el 2010-03-16 14:48:29 +0000 --- new/lisp/term.el 2010-03-19 09:53:36 +0000 *************** *** 942,947 **** --- 942,958 ---- (window-width) (1- (window-width))))) + (defun term-window-height () + (if (display-graphic-p) + (let ((e (window-inside-pixel-edges)) + (s (or (with-current-buffer (window-buffer) line-spacing) + (frame-parameter nil 'line-spacing) + 0))) + (if (floatp s) + (setq s (truncate (* (frame-char-height) s)))) + (/ (+ (- (nth 3 e) (cadr e)) s) + (+ (frame-char-height) s))) + (window-text-height))) (put 'term-mode 'mode-class 'special) *************** *** 1039,1045 **** (make-local-variable 'term-height) (make-local-variable 'term-width) (setq term-width (term-window-width)) ! (setq term-height (1- (window-height))) (make-local-variable 'term-terminal-parameter) (make-local-variable 'term-saved-cursor) (make-local-variable 'term-last-input-start) --- 1050,1056 ---- (make-local-variable 'term-height) (make-local-variable 'term-width) (setq term-width (term-window-width)) ! (setq term-height (term-window-height)) (make-local-variable 'term-terminal-parameter) (make-local-variable 'term-saved-cursor) (make-local-variable 'term-last-input-start) *************** *** 1182,1190 **** found)) (defun term-check-size (process) ! (when (or (/= term-height (1- (window-height))) (/= term-width (term-window-width))) ! (term-reset-size (1- (window-height)) (term-window-width)) (set-process-window-size process term-height term-width))) (defun term-send-raw-string (chars) --- 1193,1201 ---- found)) (defun term-check-size (process) ! (when (or (/= term-height (term-window-height)) (/= term-width (term-window-width))) ! (term-reset-size (term-window-height) (term-window-width)) (set-process-window-size process term-height term-width))) (defun term-send-raw-string (chars) --------------000004020401050906040209-- From unknown Mon Sep 08 22:05:16 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) References: <4B80CB5A.8080306@yahoo.co.jp> In-Reply-To: <4B80CB5A.8080306@yahoo.co.jp> Resent-From: IRIE Shinsuke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2010 10:38:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.12689950568455 (code B ref 5615); Fri, 19 Mar 2010 10:38:02 +0000 Received: (at 5615) by debbugs.gnu.org; 19 Mar 2010 10:37:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZaB-0002CK-R1 for submit@debbugs.gnu.org; Fri, 19 Mar 2010 06:37:36 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsZa9-0002CF-C0 for 5615@debbugs.gnu.org; Fri, 19 Mar 2010 06:37:33 -0400 Received: by gyh4 with SMTP id 4so1472442gyh.3 for <5615@debbugs.gnu.org>; Fri, 19 Mar 2010 03:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:x-enigmail-version :content-type:content-transfer-encoding; bh=gfi8l0VFTrgdZ7gZSiWyI6fcIjQAtYKAyv9Ko7gIVzU=; b=dvTURzdBCmJSjvomjDzFsVIt1EBkZbT8D3kg8VoLkkUN7yQd2AoM/8uXem36ZyiSQA cD7gXcDs3wckcmgriWE+GbKt/MBgWNRTDBr0Oa4ycxNryUlaITNmLuOrSEQLQmqFB8OP N4VWdhXh214+uM5pTJt2TrXHEDkp1UXtcuf7M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:x-enigmail-version:content-type:content-transfer-encoding; b=HfRQ7A08t+K+oOUTwlyHYVMfuF1gn5JFQU4ITLTuAMwb3ibC+vSC4fFTJTrteKFnd1 5TYYeJc4O1d4EKB48FeipWeKPnjvJr9BOInwqZBO1AXsFrGXYTjZU8LKY1KpUJzJmy5b Uta8IcyH92/lzX/zHbw776JCnaUgYjTI4w/AU= Received: by 10.101.176.6 with SMTP id d6mr6822945anp.155.1268995047758; Fri, 19 Mar 2010 03:37:27 -0700 (PDT) Received: from [114.51.18.28] (EM114-51-18-28.pool.e-mobile.ne.jp [114.51.18.28]) by mx.google.com with ESMTPS id 22sm338052ywh.1.2010.03.19.03.37.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 03:37:27 -0700 (PDT) Message-ID: <4BA35409.1080206@yahoo.co.jp> Date: Fri, 19 Mar 2010 19:38:01 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.8 (/) Oops, I missed attaching the patch to the mail... Sorry. IRIE Shinsuke From unknown Mon Sep 08 22:05:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Resent-From: Ken Hori Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 May 2010 05:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: IRIE Shinsuke Cc: 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.127519703432520 (code B ref 5615); Sun, 30 May 2010 05:24:01 +0000 Received: (at 5615) by debbugs.gnu.org; 30 May 2010 05:23:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIb05-0008ST-DH for submit@debbugs.gnu.org; Sun, 30 May 2010 01:23:53 -0400 Received: from mail-pz0-f197.google.com ([209.85.222.197]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIb03-0008SF-Rm for 5615@debbugs.gnu.org; Sun, 30 May 2010 01:23:52 -0400 Received: by pzk35 with SMTP id 35so1138043pzk.0 for <5615@debbugs.gnu.org>; Sat, 29 May 2010 22:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=mfNfclWau49+4JFC9+Uq3xxeWkKDN0KxxfmFUeGGfq0=; b=kNjH+RqAHp/R7LzJ8ay6o2fKBFafjzHvFf0BnlikwDAd+t6Niqr29AU8Gf9ccU2jCf bkMXSUFFf2dF6FzwiOYpVn0E6WjAV4wd9giPxBAOspXOdz4H7789VRSKDwOdRAqFgzSZ 2OwjCfBZ077XdqgxIPlU7j4S8DZEISbyngVbI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=YcleSFNjT9P+XTeJ9sb7GwNiGIrPA445KASwjJGyEJFJ3UVAIMD4QJxFIABY3j8vsU vESrStY+rNcRVroCrvzB5gIDwxxUDMlfGQQebcJuSej99dYhrTCbhsZiw3pY11sqPzRg eJQgQT3FdlGt3IUSvL5JgjZjVXX/xuwHPsm5U= MIME-Version: 1.0 Received: by 10.141.89.17 with SMTP id r17mr1936921rvl.185.1275197027816; Sat, 29 May 2010 22:23:47 -0700 (PDT) Received: by 10.140.166.4 with HTTP; Sat, 29 May 2010 22:23:47 -0700 (PDT) In-Reply-To: <4BA35409.1080206@yahoo.co.jp> References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35409.1080206@yahoo.co.jp> Date: Sat, 29 May 2010 22:23:47 -0700 Message-ID: From: Ken Hori Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Haven't tried yet, but thanks for the patch. I'm sure this "off-by-2-lines" problem has been an annoyance to most forks who use term.el off the bzr head. 2010/3/19 IRIE Shinsuke : > Oops, I missed attaching the patch to the mail... Sorry. > > > IRIE Shinsuke > > > > > > From unknown Mon Sep 08 22:05:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Feb 2016 06:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: IRIE Shinsuke Cc: 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.14566396496205 (code B ref 5615); Sun, 28 Feb 2016 06:08:01 +0000 Received: (at 5615) by debbugs.gnu.org; 28 Feb 2016 06:07:29 +0000 Received: from localhost ([127.0.0.1]:49378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZuVt-0001c1-0N for submit@debbugs.gnu.org; Sun, 28 Feb 2016 01:07:29 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50779) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZuVr-0001bn-9B for 5615@debbugs.gnu.org; Sun, 28 Feb 2016 01:07:27 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZuVS-0003uI-5E; Sun, 28 Feb 2016 07:07:02 +0100 From: Lars Ingebrigtsen References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> Date: Sun, 28 Feb 2016 17:06:57 +1100 In-Reply-To: <4BA35102.7050506@yahoo.co.jp> (IRIE Shinsuke's message of "Fri, 19 Mar 2010 19:25:06 +0900") Message-ID: <87oab1tlku.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZuVS-0003uI-5E X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457244423.09179@8AfS0IvEr5FFavrPrqntbw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) IRIE Shinsuke writes: > Sorry, the patch I sent with previous mail is bad, because the previous > patch was made without considering `line-spacing' specified by a > floating point number or frame-parameter. > > So I wrote the new patch. Please check it. [...] Is this still a problem in the current Emacs? > + (defun term-window-height () > + (if (display-graphic-p) > + (let ((e (window-inside-pixel-edges)) > + (s (or (with-current-buffer (window-buffer) line-spacing) > + (frame-parameter nil 'line-spacing) > + 0))) > + (if (floatp s) > + (setq s (truncate (* (frame-char-height) s)))) > + (/ (+ (- (nth 3 e) (cadr e)) s) > + (+ (frame-char-height) s))) > + (window-text-height))) > > (put 'term-mode 'mode-class 'special) [...] > (defun term-check-size (process) > ! (when (or (/= term-height (1- (window-height))) > (/= term-width (term-window-width))) > ! (term-reset-size (1- (window-height)) (term-window-width)) > (set-process-window-size process term-height term-width))) > > (defun term-send-raw-string (chars) > --- 1193,1201 ---- > found)) > > (defun term-check-size (process) > ! (when (or (/= term-height (term-window-height)) > (/= term-width (term-window-width))) > ! (term-reset-size (term-window-height) (term-window-width)) > (set-process-window-size process term-height term-width))) > > (defun term-send-raw-string (chars) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Sep 08 22:05:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: IRIE Shinsuke , 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.15024122409091 (code B ref 5615); Fri, 11 Aug 2017 00:44:02 +0000 Received: (at 5615) by debbugs.gnu.org; 11 Aug 2017 00:44:00 +0000 Received: from localhost ([127.0.0.1]:54892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfy3Q-0002MO-QR for submit@debbugs.gnu.org; Thu, 10 Aug 2017 20:44:00 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:37901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfy3F-0002Lw-Ts; Thu, 10 Aug 2017 20:43:51 -0400 Received: by mail-it0-f42.google.com with SMTP id m34so20777823iti.1; Thu, 10 Aug 2017 17:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/HM9+0GSdbBD1hPLzRokP4MCPgTlf7HHccOHnOxIUJA=; b=CVYOEAEzmE5wplRPwCxE2CHY496Dg/T6dWV94RUuVTrVh4JpbToqY8kDnI7hmKXBh0 NhmkphtrJujMjPeMgW7xWz5+WZyZzXMGthBH79oN6XlKbjoNmBNe93aNkX18uaR1h0tg ubLvaudS3Al/xUhABUzmZ8oSXv4GscgbCV5yv5QvhQryn77TNZsiPKSzbK+zAVgWSGLW BaSJgOaB3JepvYhcSJMhIZjs8lgBeHAb270EduZQFHRVoPOKbOLzIuWcD4DZ+wPfrAx8 oxiQsaAP3GHsoUcNZkLepS+pgUnAiDSeUXKTIrdz+ylpSchup4jkzAMLmyVJWgNdHOpz RM0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/HM9+0GSdbBD1hPLzRokP4MCPgTlf7HHccOHnOxIUJA=; b=I6W9NqrmjtpnjVJNLyRwdzcVgR7dVcJaNqlKh5k6nSAjrxBbxezvjFDxH4BKpStYTT 7u1zytr2fLRb3EvDa4fUPgDth8EGtxqCORcALmnWwmWOf0pM4z6k3MvshRyIxS4ohvYr +SfklUIGMophrvbI8QK1S4jHKdc8vUmQaCG0MQ3yMrxLhzuTf1pAKE/RGf3JgNnRWesY LbwJJ4Gk094PgknlLwBDaUJonP5XxM4mOAY5muF7dVJMlLbbP7x0ZnuvVnnZWMOverK4 JQcSz9HHRA8rViPWF6i69e3xKUfugl3fe9g5VaA3S9cmeXo80X95+UKPrLTFtpl8EprI tvtg== X-Gm-Message-State: AIVw113KoUdjmDC55pB6ikQ5T6a/t7sWknZ53MOzwsFn5yftGmihjJow tfBZ9uzWTX9vLzY5 X-Received: by 10.36.243.13 with SMTP id t13mr5674207ith.68.1502412220170; Thu, 10 Aug 2017 17:43:40 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id 80sm3824389itk.11.2017.08.10.17.43.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Aug 2017 17:43:38 -0700 (PDT) From: npostavs@users.sourceforge.net References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> Date: Thu, 10 Aug 2017 20:45:16 -0400 In-Reply-To: <87oab1tlku.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2016 17:06:57 +1100") Message-ID: <87bmnn2aqr.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain tags 5615 + patch quit Lars Ingebrigtsen writes: > IRIE Shinsuke writes: > >> Sorry, the patch I sent with previous mail is bad, because the previous >> patch was made without considering `line-spacing' specified by a >> floating point number or frame-parameter. >> >> So I wrote the new patch. Please check it. > > [...] > > Is this still a problem in the current Emacs? Current Emacs still uses the same (1- (window-height)) expression, but I can't understand from the description when exactly this gives the wrong result. Furthermore, I don't see any justification which would explain why the new proposed significantly more complicated computation is more correct. I think we should just use window-text-height. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-lisp-term.el-term-mode-Use-window-text-height-Bug.patch Content-Description: patch >From b22407f5fedea77f34ca1efb5469e368164f9084 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 10 Aug 2017 20:43:13 -0400 Subject: [PATCH v2] * lisp/term.el (term-mode): Use `window-text-height' (Bug#5615). --- lisp/term.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/term.el b/lisp/term.el index 5eb7b3e8ed..12a37cafbe 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -1007,7 +1007,7 @@ term-mode (setq indent-tabs-mode nil) (setq buffer-display-table term-display-table) (set (make-local-variable 'term-home-marker) (copy-marker 0)) - (set (make-local-variable 'term-height) (1- (window-height))) + (set (make-local-variable 'term-height) (window-text-height)) (set (make-local-variable 'term-width) (window-max-chars-per-line)) (set (make-local-variable 'term-last-input-start) (make-marker)) (set (make-local-variable 'term-last-input-end) (make-marker)) -- 2.11.1 --=-=-=-- From unknown Mon Sep 08 22:05:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 06:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: larsi@gnus.org, irieshinsuke@yahoo.co.jp, 5615@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.150243318912933 (code B ref 5615); Fri, 11 Aug 2017 06:34:01 +0000 Received: (at 5615) by debbugs.gnu.org; 11 Aug 2017 06:33:09 +0000 Received: from localhost ([127.0.0.1]:55044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg3VM-0003MW-70 for submit@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg3VK-0003Lx-3X for 5615@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dg3V9-00059A-RG for 5615@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg3V9-000596-Nw; Fri, 11 Aug 2017 02:32:55 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4138 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dg3V8-0004sM-Vd; Fri, 11 Aug 2017 02:32:55 -0400 Date: Fri, 11 Aug 2017 09:32:43 +0300 Message-Id: <834ltesjg4.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87bmnn2aqr.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> <87bmnn2aqr.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Date: Thu, 10 Aug 2017 20:45:16 -0400 > Cc: IRIE Shinsuke , 5615@debbugs.gnu.org > > Current Emacs still uses the same (1- (window-height)) expression, but I > can't understand from the description when exactly this gives the wrong > result. Furthermore, I don't see any justification which would explain > why the new proposed significantly more complicated computation is more > correct. I think we should just use window-text-height. I think you are right. If no one objects in a few days, please push your change. Thanks. From unknown Mon Sep 08 22:05:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2017 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: larsi@gnus.org, irieshinsuke@yahoo.co.jp, 5615@debbugs.gnu.org Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.150319997715634 (code B ref 5615); Sun, 20 Aug 2017 03:33:01 +0000 Received: (at 5615) by debbugs.gnu.org; 20 Aug 2017 03:32:57 +0000 Received: from localhost ([127.0.0.1]:45996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djGyu-000440-Ce for submit@debbugs.gnu.org; Sat, 19 Aug 2017 23:32:56 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:38380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djGys-00043i-AR; Sat, 19 Aug 2017 23:32:54 -0400 Received: by mail-it0-f66.google.com with SMTP id w204so247931ita.5; Sat, 19 Aug 2017 20:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Y2SBvPTI1q5InWJICYm6xweiUx98jJn3VWriomS77lY=; b=AlqBSBC4mVxDKYJTC7M3gTcIUJC0udFPX6xCqCW9zJfuIlo2+0OGIbZkkoLugj918Y ttV89m/7h2lwVoh8D1gK4cNV0bcrO5aYwoVa/hjqoNorCD7T14ER852R6htk5c1Ewk9Z fDRnqHqcNr/tPbqe3mw355j4d55BI6/nn2XpWtgXLboljGAh9hpmYVQRQNdKRPyXNxu4 Jr8sGLuRVqNwPs8W4+cAv52CQeIHNiN5U33E133b4bK6YLBkqM18Ci0+vyPeBYF87l46 UYdq3StBQ16q3qW1bjwjxzB9cbUoo/9ku6YukVOqNBRtA0mH2zZrSNfidIjdJY+0pcn9 KSwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Y2SBvPTI1q5InWJICYm6xweiUx98jJn3VWriomS77lY=; b=tL31Mh1XTnwrnHif/gNKu06ni4npo+4IGc6HJUINk0+5pNEzZDSsKhSToqRb9v/X5L G3z7tOHuhXYpenRww3l1j4fLHZJtTOvJdDC8tIGuw8dkuiSww2A9rmvFYwZg/l33itlL uzIukeIIS211Dvl2IPTz19/zeuxRlMSDWUexH0wR76AC2A6Uy3sCG6DIPta1eD2WfIpQ HXhzAwZW/BJH5/aN0fN8fpTITHCpQtoiXF4A2ZJaU0fNrhHCnN9dgaTv82jZO8f2QBlR Lv3KUlqb6BUaxz7O8h+kUR7XAGfu+Bzmhqr1fCEF/+CAySNJ3fq7MMUJzU0sE+avs03n Q9Zw== X-Gm-Message-State: AHYfb5hFhvqXoXVYPZPqO2/t7MvjGl9WTh0rjAG+/MTdbaurwuwMsNAM gXaJCLJuMkR8QRnk X-Received: by 10.36.77.136 with SMTP id l130mr2435600itb.67.1503199968605; Sat, 19 Aug 2017 20:32:48 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id z139sm2493089itb.41.2017.08.19.20.32.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Aug 2017 20:32:47 -0700 (PDT) From: npostavs@users.sourceforge.net References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> <87bmnn2aqr.fsf@users.sourceforge.net> <834ltesjg4.fsf@gnu.org> Date: Sat, 19 Aug 2017 23:34:24 -0400 In-Reply-To: <834ltesjg4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2017 09:32:43 +0300") Message-ID: <87lgmeyksf.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 5615 fixed close 5615 26.1 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Date: Thu, 10 Aug 2017 20:45:16 -0400 >> Cc: IRIE Shinsuke , 5615@debbugs.gnu.org >> >> Current Emacs still uses the same (1- (window-height)) expression, but I >> can't understand from the description when exactly this gives the wrong >> result. Furthermore, I don't see any justification which would explain >> why the new proposed significantly more complicated computation is more >> correct. I think we should just use window-text-height. > > I think you are right. If no one objects in a few days, please push > your change. Pushed to master. [1: dbd3a17cb0]: 2017-08-19 23:29:28 -0400 * lisp/term.el (term-mode): Use `window-text-height' (Bug#5615). http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=dbd3a17cb068148bd49e288eb0b44ca7eb4a4e3c