Subject: Re: [PATCH] gnu: Add some gnome extensions

From: Liliana Marie Prikler <[email-masked]>
Date: Tue, 21 Jun 2022 21:52:14 +0200

Am Dienstag, dem 21.06.2022 um 18:59 +0000 schrieb Sughosha:
> From aa21788fe28ff0b271ccab8b49e3602c783604fc Mon Sep 17 00:00:00
> 2001
> From: Sughosha <[email-masked]>
> Date: Tue, 21 Jun 2022 20:41:12 +0200
> Subject: [PATCH] gnu: Add some gnome extensions
> 
Missing ChangeLog.
> ---
>  gnu/packages/gnome-xyz.scm | 113
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 113 insertions(+)
> 
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index 465f81b..a96fe8b 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -985,6 +985,119 @@ animation of closing windowed applications.")
>  GNOME Shell, including the top panel, dash and overview.")
>      (license license:gpl3)))
>  
> +(define-public gnome-shell-extension-activities-icons
> +  (let ((revision "12")
> +        (commit "651179d1727d5ed80866f2319d5e4793b28631ae"))
> +    (package
> +      (name "gnome-shell-extension-activities-icons")
> +      (version (git-version "0" revision commit))
If possible, use an actual version, e.g. one advertised at
extensions.gnome.org
> +      (source
> +        (origin
> +          (method git-fetch)
> +          (uri
> +            (git-reference
> +              (url "https://github.com/fawtytoo/activities-icons")
> +              (commit commit)))
> +          (sha256
> +            (base32
> "0c77f77knchzdg1mmyn6ahb3lgfd54ym30wnyrh20y4zbwn8ri2w"))))
> +      (build-system copy-build-system)
> +      (arguments
> +       `(#:install-plan
> +         `(("."
> "/share/gnome-shell/extensions/activities_icons@fawtytoo"))))
> +     (home-page "https://github.com/fawtytoo/activities-icons")
> +     (synopsis "Gnome Shell extension that replaces the Activities
> button with 2 icons for selecting between Applications and
> Workspaces")
Synopses should be short.
> +     (description "The Activities button becomes 2 icons for
> selecting either Applications or Workspaces in the overview.
> Selecting the same view again will hide the overview.
> +
> +Scrolling on the icons allows switching windows on a workspace or
> cycling through the Workspaces.")
No need to break this into multiple lines.
> +     (license license:gpl3))))
> +
Split into a separate commit here.

> +(define-public gnome-shell-extension-radio
> +  (package
> +    (name "gnome-shell-extension-radio")
> +    (version "19")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri
> +          (git-reference 
> +            (url
> "https://github.com/hslbck/gnome-shell-extension-radio")
> +            (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> "1qsi6c57hxh4jqdw18knm06601lhag6jdbvzg0r79aa9572zy8a0"))))
> +    (build-system copy-build-system)
> +    (arguments
> +     `(#:install-plan
> +        `(("[email-masked]" "/share/gnome-
> shell/extensions/"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'glib-compile-schemas
> +           (lambda _
> +             (invoke "glib-compile-schemas"
> "[email-masked]/schemas"))))))
> +    (native-inputs
> +     `(("glib:bin" ,glib "bin")))
> +    (home-page
> "https://github.com/hslbck/gnome-shell-extension-radio")
> +    (synopsis "Gnome shell extension for listening to internet radio
> streams")
> +    (description "This extension is for listening to internet radio
> streams.")
> +    (license license:gpl3+)))
Synopsis and description could possibly use some work.  Split into
another commit here.

> +(define-public gnome-shell-extension-sound-output-device-chooser
> +  (package
> +    (name "gnome-shell-extension-sound-output-device-chooser")
> +    (version "43")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri
> +          (git-reference
> +            (url
> "https://github.com/kgshank/gse-sound-output-device-chooser")
> +            (commit version)))
> +        (sha256
> +          (base32
> "1qk6ypyqbv8zwwlky6cgk9hgp1zh32jmzw4wza200g4v94ifkwm9"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f
> +       #:phases
> +        (modify-phases %standard-phases
> +          (add-after 'unpack 'fix-hardcoded-path
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (substitute* "Makefile"
> +                (("INSTALL_DIR=~/.local/share/gnome-
> shell/extensions")
You can match this as INSTALL_DIR=.*
> (string-append "INSTALL_DIR=" (assoc-ref outputs "out")
> "/share/gnome-shell/extensions")))))
> +          (delete 'configure))))
> +    (native-inputs
> +     `(("gettext" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin")))
> +    (inputs
> +      (list python))
> +    (home-page
> "https://extensions.gnome.org/extension/906/sound-output-device-chooser
> ")
> +    (synopsis "simple selector to enabled selection of sound source
> and sink based on Gnome Control Center")
Avoid marketing words like "simple", also synopses ought to be short.
> +    (description "This extension shows a list of sound output and
> input devices (similar to gnome sound settings) in the status menu
> below the volume slider. Various active ports like HDMI , Speakers
> etc. of the same device are also displayed for selection.")
> +    (license license:gpl3)))
Split.

> +(define-public gnome-shell-extension-transparent-window
> +  (let ((revision "45")
> +        (commit "cc9bc70c192dd565fa6f1d1b28d9a20f99684f2a"))
> +    (package
> +      (name "gnome-shell-extension-transparent-window")
> +      (version (git-version "0" revision commit))
Same version problem as for the first package.
 
> +      (source
> +        (origin
> +          (method git-fetch)
> +          (uri
> +            (git-reference 
> +              (url
> "https://github.com/pbxqdown/gnome-shell-extension-transparent-window
> ")
> +              (commit commit)))
> +          (sha256
> +            (base32
> "1f9iqqjpmmylqz0ws8cy5rs475bwzi7jy44q9ip44ig2acz2wxzp"))))
> +      (build-system copy-build-system)
> +      (arguments
> +       `(#:install-plan
> +         `(("."
> "/share/gnome-shell/extensions/[email-masked]
> "))))
> +      (home-page
> "https://github.com/pbxqdown/gnome-shell-extension-transparent-window
> ")
> +      (synopsis "Gnome shell extension which changes the opacity of
> window through mouse operation")
Synopses should be short.
> +      (description "The extension will change the opacity of window
> through simple mouse/keyboard operation.")
> +      (license license:expat))))
> +

Cheers