GNU bug report logs - #56115
[PATCH] python-build-system: Fix typo in module-level comment paragraph.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: jgart <jgart <at> dismail.de>
Subject: bug#56115: closed (Re: bug#56115: [PATCH] python-build-system:
 Fix typo in module-level comment paragraph.)
Date: Wed, 22 Jun 2022 18:41:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56115: [PATCH] python-build-system: Fix typo in module-level comment paragraph.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56115 <at> debbugs.gnu.org.

-- 
56115: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56115
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 56115-done <at> debbugs.gnu.org
Subject: Re: bug#56115: [PATCH] python-build-system: Fix typo in
 module-level comment paragraph.
Date: Wed, 22 Jun 2022 14:40:22 -0400

Hi,

jgart <jgart <at> dismail.de> writes:

> * guix/build/python-build-system.scm: Fix typo in comment paragraph.
> ---
>  guix/build/python-build-system.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 08871f60cd..28041e90a3 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -68,7 +68,7 @@ (define-module (guix build python-build-system)
>  ;; downloading the package source from PyPI (the Python Package Index).  Both
>  ;; of them import setuptools and execute the "setup.py" file under their
>  ;; control.  Thus the "setup.py" behaves as if the developer had imported
> -;; setuptools within setup.py - even is still using only distutils.
> +;; setuptools within setup.py - even if it is still using only distutils.
>  ;;
>  ;; Setuptools' "install" command (to be more precise: the "easy_install"
>  ;; command which is called by "install") will put the path of the currently

Thanks.  Unfortunately this simply typo fix causes a world rebuild.  I'd
suggest flagging such patches with the 'core-updates PATCH' prefix, as
hinted in info '(guix) Submitting Patches' to avoid committers from
unintentionally pushing these to master.

Applied to core-updates.

Closing!

Maxim

[Message part 3 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] python-build-system: Fix typo in module-level comment
 paragraph.
Date: Mon, 20 Jun 2022 16:17:33 -0500

* guix/build/python-build-system.scm: Fix typo in comment paragraph.
---
 guix/build/python-build-system.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 08871f60cd..28041e90a3 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -68,7 +68,7 @@ (define-module (guix build python-build-system)
 ;; downloading the package source from PyPI (the Python Package Index).  Both
 ;; of them import setuptools and execute the "setup.py" file under their
 ;; control.  Thus the "setup.py" behaves as if the developer had imported
-;; setuptools within setup.py - even is still using only distutils.
+;; setuptools within setup.py - even if it is still using only distutils.
 ;;
 ;; Setuptools' "install" command (to be more precise: the "easy_install"
 ;; command which is called by "install") will put the path of the currently
-- 
2.36.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.