From unknown Wed Jun 18 23:13:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56087 <56087@debbugs.gnu.org> To: bug#56087 <56087@debbugs.gnu.org> Subject: Status: [PATCH] gnu: suckless: add farbfeld and propagate input to sent Reply-To: bug#56087 <56087@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:38 +0000 retitle 56087 [PATCH] gnu: suckless: add farbfeld and propagate input to se= nt reassign 56087 guix-patches submitter 56087 Gabriel Wicki severity 56087 normal tag 56087 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 08:23:57 2022 Received: (at submit) by debbugs.gnu.org; 19 Jun 2022 12:23:57 +0000 Received: from localhost ([127.0.0.1]:50788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2ty9-0005wl-IH for submit@debbugs.gnu.org; Sun, 19 Jun 2022 08:23:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:39250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2ty5-0005wb-H3 for submit@debbugs.gnu.org; Sun, 19 Jun 2022 08:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2ty5-0001hT-BS for guix-patches@gnu.org; Sun, 19 Jun 2022 08:23:53 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:35717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2ty2-000237-On for guix-patches@gnu.org; Sun, 19 Jun 2022 08:23:52 -0400 Received: from silvi (unknown [85.195.207.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id 3CD3E401C8 for ; Sun, 19 Jun 2022 14:23:27 +0200 (CEST) Date: Sun, 19 Jun 2022 14:23:17 +0200 From: Gabriel Wicki To: guix-patches@gnu.org Subject: [PATCH] gnu: suckless: add farbfeld and propagate input to sent Message-ID: <20220619115925.bcrcjpd7yse2n25t@silvi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=129.132.2.15; envelope-from=gabriel@erlikon.ch; helo=chimborazo.ee.ethz.ch X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello Stumbling over the tools in suckless.scm i tried out sent. Unfortunately just installing sent and giving the example from their source-repo a try only produced a (somewhat strange) error. Apparently sent (and probably other suckless tools) rely on suckless' farbfeld package to handle images and the like, so i packaged it and propagated the input farbfeld to sent. This fixes the issue; now presentations with images work. I hope my patches are fine. Best regards Gabriel >From 55a563f53334c3eaac9cbae79fe33936679ab291 Mon Sep 17 00:00:00 2001 From: Gabriel Wicki Date: Sat, 18 Jun 2022 17:00:16 +0200 Subject: [PATCH 1/2] gnu: Add farbfeld. * gnu/packages/suckless.scm (farbfeld): New variable. --- gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 5aa37657b9..fb3af9ad6c 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -1084,3 +1084,35 @@ (define-public sfeed various other formats. There are also some programs and scripts included to import and export OPML and to fetch, filter, merge and order feed items.") (license license:isc))) + +(define-public farbfeld + (let ((commit "ab5e3df") (revision "0")) + (package + (name "farbfeld") + (version (git-version "4" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "git://git.suckless.org/farbfeld") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pkmkvv5ggpzqwqdchd19442x8gh152xy5z1z13ipfznhspsf870")))) + (build-system gnu-build-system) + (inputs (list libpng libjpeg-turbo)) + (arguments + `(#:make-flags (list "PREFIX=" + (string-append "DESTDIR=" %output) + (string-append "CC=" + ,(cc-for-target))) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (delete 'check)))) + (synopsis "Image format and conversion tools") + (description + "farbfeld is a lossless image format which is easy to parse, +pipe and compress.") + (home-page "https://git.suckless.org/farbfeld/") + (license license:isc)))) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 08:37:05 2022 Received: (at 56087) by debbugs.gnu.org; 19 Jun 2022 12:37:05 +0000 Received: from localhost ([127.0.0.1]:50824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uAr-0008Tg-7N for submit@debbugs.gnu.org; Sun, 19 Jun 2022 08:37:05 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:32849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uAp-0008TC-MN for 56087@debbugs.gnu.org; Sun, 19 Jun 2022 08:37:04 -0400 Received: from silvi (unknown [85.195.207.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id E9BD4401C8 for <56087@debbugs.gnu.org>; Sun, 19 Jun 2022 14:36:56 +0200 (CEST) Date: Sun, 19 Jun 2022 14:36:52 +0200 From: Gabriel Wicki To: 56087@debbugs.gnu.org Subject: Re: bug#56087: Acknowledgement ([PATCH] gnu: suckless: add farbfeld and propagate input to sent) Message-ID: <20220619123652.xyx3pmkgueqh5pfa@silvi> References: <20220619115925.bcrcjpd7yse2n25t@silvi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56087 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >From d729f8e2b69a9b36436f6c6d7918ffbe524c5aad Mon Sep 17 00:00:00 2001 From: Gabriel Wicki Date: Sat, 18 Jun 2022 17:04:12 +0200 Subject: [PATCH 2/2] gnu: sent: Add farbfeld to propagated-inputs. * gnu/packages/suckless.scm (sent)[propagated-inputs]: Add it. --- gnu/packages/suckless.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index fb3af9ad6c..d3fdee72e5 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -532,6 +532,8 @@ (define-public sent (string-append "LIBS=" (pkg-config "--libs") " -lm"))))) (native-inputs (list pkg-config)) + (propagated-inputs + (list farbfeld)) (inputs `(("libpng" ,libpng) ("libx11" ,libx11) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 09:12:27 2022 Received: (at 56087) by debbugs.gnu.org; 19 Jun 2022 13:12:27 +0000 Received: from localhost ([127.0.0.1]:50858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uj5-00035e-GL for submit@debbugs.gnu.org; Sun, 19 Jun 2022 09:12:27 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:39342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uj2-00035U-Mi for 56087@debbugs.gnu.org; Sun, 19 Jun 2022 09:12:26 -0400 Received: from [172.20.10.9] ([188.189.158.25]) by laurent.telenet-ops.be with bizsmtp id l1CK2700B0Z9yEL011CNSf; Sun, 19 Jun 2022 15:12:22 +0200 Message-ID: <9d1b5098ed70984ca2f41602454c06f80ad58f50.camel@telenet.be> Subject: Re: [bug#56087] Acknowledgement ([PATCH] gnu: suckless: add farbfeld and propagate input to sent) From: Maxime Devos To: Gabriel Wicki , 56087@debbugs.gnu.org Date: Sun, 19 Jun 2022 15:12:15 +0200 In-Reply-To: <20220619123652.xyx3pmkgueqh5pfa@silvi> References: <20220619115925.bcrcjpd7yse2n25t@silvi> <20220619123652.xyx3pmkgueqh5pfa@silvi> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-XDV8VzkUoSKL1rY0PrfV" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655644342; bh=G96XsIohTbzZ3ZXJ8AEZaajpxvuzIQtULTVnib3KhD4=; h=Subject:From:To:Date:In-Reply-To:References; b=nC3/MSdIgYL8dDox9n/Q8sLHHuSc2yFogcw5heM9kpi4ZMne/9fte9vfRJFNpyykS GtUe8CB+rNhZb8m6fRmqEn4XEsKTaM04oAnFMFgIa7e36KbyLLB/U20kQy5vjIQEeK LHbv/9A/8VL4S8m5Swwimb6yaOfwk2CwCE6M8WrlKyq6uyXuQTAPfwVWn+sYh2KzTQ 1LimxrrI032Ers9PXPew5wINAgDw+qyfoq5RE7A2g58//w7BqNCqRfWdgARDYTlnKv 1IyyvNO30F3M+97+HXGU57fkJfzPDn5nP29MvDTzedi5cAoDdPP0e8UppeocC6Wr87 micco/v93NozQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56087 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-XDV8VzkUoSKL1rY0PrfV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gabriel Wicki schreef op zo 19-06-2022 om 14:36 [+0200]: > +=C2=A0=C2=A0=C2=A0 (propagated-inputs > +=C2=A0=C2=A0=C2=A0=C2=A0 (list farbfeld)) Propagation (*) can be avoided by looking in the source code of 'sent' to see where farbfeld is started and replacing "farbfeld" by "/gnu/store/.../bin/farbfeld" (using 'substitute*' & search-input- file). (*) Propagation is fragile in some uses (e.g. running directly from the store) and hence not recommended when it can be avoided. Greetings, Maxime. --=-XDV8VzkUoSKL1rY0PrfV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq8grxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7unoAP9W0x5kHK/Fo7zL4+/RUggmYV64 WbfpCqstrqaWDDLS/AD+LR0Ujv8rmo5jPYqTXUsX0M1qT+BGBZWNieN+35CqOQM= =+epT -----END PGP SIGNATURE----- --=-XDV8VzkUoSKL1rY0PrfV-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 09:18:28 2022 Received: (at 56087) by debbugs.gnu.org; 19 Jun 2022 13:18:28 +0000 Received: from localhost ([127.0.0.1]:50873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uou-0005PF-Gv for submit@debbugs.gnu.org; Sun, 19 Jun 2022 09:18:28 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:45422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2uot-0005P7-Ks for 56087@debbugs.gnu.org; Sun, 19 Jun 2022 09:18:28 -0400 Received: from [172.20.10.9] ([188.189.158.25]) by laurent.telenet-ops.be with bizsmtp id l1JS270060Z9yEL011JSw5; Sun, 19 Jun 2022 15:18:26 +0200 Message-ID: <66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be> Subject: Re: [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent From: Maxime Devos To: Gabriel Wicki , 56087@debbugs.gnu.org Date: Sun, 19 Jun 2022 15:17:54 +0200 In-Reply-To: <20220619115925.bcrcjpd7yse2n25t@silvi> References: <20220619115925.bcrcjpd7yse2n25t@silvi> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-af+eZ95SrwE5MO5N+hMu" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655644706; bh=6ijrP3IRoH5CiKfT5IUoyYf1MXhqQ/LxB5f4iCVC8+k=; h=Subject:From:To:Date:In-Reply-To:References; b=jgJ5DJB1mfoacOBx1rR4a7H1P22za6owsKSQAwwHBgSzzclLRsAsO7eWEtxkTxfKu p8sECkd2abdR06WoJ1tA3BQvtsmUnULWCvaxEsn/pmUvCC/aeYzkk4VnNBflr31/9n egSnaaKeZXtKnKY7Rx4i9owitT4FMiOhwt973mVZHdDR8N2y1qj9hduRel+joKOWnG 0GdjqkQqV4Xe4DfNN6codQslu941XDoxYVSv2WIXcIcaM63aC052YmBl+4aEOI00Je 6XAkHbR1maA6E3azKiT5xTK4SuQzNyhVV0Jb/QUcTU8j/hyL9Xoze3ZJSI/qMsWYal yNcd3cCd8j6Lg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56087 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-af+eZ95SrwE5MO5N+hMu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gabriel Wicki schreef op zo 19-06-2022 om 14:23 [+0200]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 `(#:make-flags (list "PREFIX=3D" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (string-append "DESTDIR=3D" %output) Guix does not do staged installation (that's what DESTDIR is for!), so don't set DESTDIR, instead set PREFIX to #$output instead of DESTDIR (the difference matters when the compiled program embeds a reference to its own installation location). Also, G-exps, because %output isn't documented IIRC whereas #$output is: (arguments (list #:make-flags #~(list (string-append "PREFIX=3D" #$output) (string-append "CC=3D" #$(cc-for-target))) #:phases #~(modify-phases %standard-phases (delete 'configure) (delete 'check)))) Also, always add a comment about why tests are skipped (maybe someone knows how to fix them or the bug they noticed!). Greetings, Maxime --=-af+eZ95SrwE5MO5N+hMu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq8iAhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7m8bAQD55TPBeyM1lDVOrUHdox3j5p1P 6d5tdVhze0YClqEqKwEA0ciFtNGL8B2tT/5khqrY6fIir0Fv7I201v2/sg8H+wc= =c0am -----END PGP SIGNATURE----- --=-af+eZ95SrwE5MO5N+hMu-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 09:18:56 2022 Received: (at 56087) by debbugs.gnu.org; 19 Jun 2022 13:18:57 +0000 Received: from localhost ([127.0.0.1]:50877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2upM-0005Pv-QF for submit@debbugs.gnu.org; Sun, 19 Jun 2022 09:18:56 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:33704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2upL-0005Pn-C9 for 56087@debbugs.gnu.org; Sun, 19 Jun 2022 09:18:55 -0400 Received: from [172.20.10.9] ([188.189.158.25]) by michel.telenet-ops.be with bizsmtp id l1Jt270090Z9yEL061Jt3P; Sun, 19 Jun 2022 15:18:54 +0200 Message-ID: Subject: Re: [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent From: Maxime Devos To: Gabriel Wicki , 56087@debbugs.gnu.org Date: Sun, 19 Jun 2022 15:18:53 +0200 In-Reply-To: <20220619115925.bcrcjpd7yse2n25t@silvi> References: <20220619115925.bcrcjpd7yse2n25t@silvi> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0WJup97Tal1PX1Rd1tz9" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655644734; bh=aEurXgblSG4gs53ZKT8VETooPSYVhHKjy6tXGsHHMzM=; h=Subject:From:To:Date:In-Reply-To:References; b=K4yfSBuN1qzsCnax0APvnaR9Sc5N+CyahkjQjqZwP51wTOlkpOGEyKE5eRg1+dVTC AW9zTV2blUD3i6DEkDM1GMR9WVuvxBK3WfA5SPdj8wBQTWCzwNoC9y/zea9Mj6nIDb r9QAcjHBBBpnjF6J/ayV1Az9+b16Ad2+ZwND+1G5wvBuSvT7/9zvUpaT7p+yaD4sNW xm0zsFzrdA4093t4DNIFQeDuVkJ41mzZkM/p14hS+MTAtXPE5syfeZoMdTtcbb1s6Q bcfk9g3tFpcTkTVxFr6ipgITyArwKU/TRCr24F56YI9Df6l2E6VTLwMPBJ6YJEvgTg 4KmzjymmhWa5Q== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56087 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-0WJup97Tal1PX1Rd1tz9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gabriel Wicki schreef op zo 19-06-2022 om 14:23 [+0200]: > +=C2=A0 (let ((commit "ab5e3df") (revision "0")) To avoid collisions, don't abbreviate commits. Greetings, Maxime. --=-0WJup97Tal1PX1Rd1tz9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq8iPRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ncJAQDp0p+IjetHOINUi4xcLOYL0ybk VcQmi6ZnjrlhcBKvowEA++Nt0n4/Z24LRYtO/kFDQtKiOGQtwpMBlQJA08Pr9QQ= =FEa1 -----END PGP SIGNATURE----- --=-0WJup97Tal1PX1Rd1tz9-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 20:51:11 2022 Received: (at 56087) by debbugs.gnu.org; 21 Jun 2022 00:51:11 +0000 Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3S6p-0003kB-5j for submit@debbugs.gnu.org; Mon, 20 Jun 2022 20:51:11 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:51119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3S6m-0003je-5s for 56087@debbugs.gnu.org; Mon, 20 Jun 2022 20:51:09 -0400 Received: from silvi (unknown [85.195.207.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id 35886401C8; Tue, 21 Jun 2022 02:50:58 +0200 (CEST) Date: Tue, 21 Jun 2022 02:50:47 +0200 From: Gabriel Wicki To: Maxime Devos Subject: Re: [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent Message-ID: <20220621005047.ajgnk3ob22t37wsc@silvi> References: <20220619115925.bcrcjpd7yse2n25t@silvi> <66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56087 Cc: 56087@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxime Thanks for your quick reply! Here is the revised patchset. I've added a patch to use `guix style`'s output. Greetings, gabriel >From 15e88ce3cb4ab51d6fe9ad9ae3ab15a435fb4db8 Mon Sep 17 00:00:00 2001 From: Gabriel Wicki Date: Sat, 18 Jun 2022 17:00:16 +0200 Subject: [PATCH 1/3] gnu: Add farbfeld. * gnu/packages/suckless.scm (farbfeld): New variable. [use-modules]: Add (gnu packages imagemagick) --- gnu/packages/suckless.scm | 41 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 5aa37657b9..895fc4161b 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -39,6 +39,7 @@ (define-module (gnu packages suckless) #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages image) + #:use-module (gnu packages imagemagick) #:use-module (gnu packages libbsd) #:use-module (gnu packages linux) #:use-module (gnu packages mpd) @@ -1084,3 +1085,43 @@ (define-public sfeed various other formats. There are also some programs and scripts included to import and export OPML and to fetch, filter, merge and order feed items.") (license license:isc))) + +(define-public farbfeld + (let ((commit "ab5e3dfc9cdb476218538c6687df9f44826d8f11") (revision "0")) + (package + (name "farbfeld") + (version (git-version "4" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "git://git.suckless.org/farbfeld") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pkmkvv5ggpzqwqdchd19442x8gh152xy5z1z13ipfznhspsf870")))) + (build-system gnu-build-system) + (inputs (list libpng libjpeg-turbo imagemagick)) + (arguments + (list #:tests? + #f ;no check target + #:make-flags + #~(list (string-append "PREFIX=" + #$output) + (string-append "CC=" + #$(cc-for-target))) + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'patch-2ff + (lambda* (#:key inputs outputs #:allow-other-keys) + (substitute* "2ff" + (("png2ff") (string-append #$output "/bin/png2ff")) + (("jpg2ff") (string-append #$output "/bin/jpg2ff")) + (("convert") (search-input-file inputs "/bin/convert"))))) + (delete 'configure)))) + (synopsis "Image format and conversion tools") + (description + "farbfeld is a lossless image format which is easy to parse, +pipe and compress.") + (home-page "https://git.suckless.org/farbfeld/") + (license license:isc)))) -- 2.34.0 >From 1c5a9ff89bc4525b9e1a07b6b96b017ad58a81fe Mon Sep 17 00:00:00 2001 From: Gabriel Wicki Date: Sat, 18 Jun 2022 17:04:12 +0200 Subject: [PATCH 2/3] gnu: sent: Add farbfeld to propagated-inputs. * gnu/packages/suckless.scm (sent)[propagated-inputs]: Add it. [phases]{patch-farbfeld}: New phase. [inputs]: Add farbfeld. [home-page]: Add trailing slash to fix linter warning. --- gnu/packages/suckless.scm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 895fc4161b..837977d51b 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -520,7 +520,11 @@ (define-public sent (build-system gnu-build-system) (arguments `(#:phases (modify-phases %standard-phases - (delete 'configure)) ; no configuration + (delete 'configure) ; no configuration + (add-before 'build 'patch-farbfeld + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "config.def.h" + (("2ff") (search-input-file inputs "/bin/2ff")))))) #:tests? #f ; no test suite #:make-flags (let ((pkg-config (lambda (flag) @@ -534,7 +538,8 @@ (define-public sent (native-inputs (list pkg-config)) (inputs - `(("libpng" ,libpng) + `(("farbfeld" ,farbfeld) + ("libpng" ,libpng) ("libx11" ,libx11) ("libxft" ,libxft) ("fontconfig" ,fontconfig))) @@ -544,7 +549,7 @@ (define-public sent Especially for presentations using the Takahashi method this is very nice and allows you to write down the presentation for a quick lightning talk within a few minutes.") - (home-page "https://tools.suckless.org/sent") + (home-page "https://tools.suckless.org/sent/") (license license:x11))) (define-public wmname -- 2.34.0 >From 6fb7a48822e51625de8ca1026260faac80adbe17 Mon Sep 17 00:00:00 2001 From: Gabriel Wicki Date: Tue, 21 Jun 2022 02:38:40 +0200 Subject: [PATCH 3/3] gnu: sent: Apply guix style * gnu/packages/suckless.scm (sent): Apply `guix style`. --- gnu/packages/suckless.scm | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 837977d51b..ac3ee7df10 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -520,31 +520,32 @@ (define-public sent (build-system gnu-build-system) (arguments `(#:phases (modify-phases %standard-phases - (delete 'configure) ; no configuration + (delete 'configure) ;no configuration (add-before 'build 'patch-farbfeld (lambda* (#:key inputs #:allow-other-keys) (substitute* "config.def.h" (("2ff") (search-input-file inputs "/bin/2ff")))))) - #:tests? #f ; no test suite + #:tests? + #f ;no test suite #:make-flags (let ((pkg-config (lambda (flag) - (string-append - "$(shell pkg-config " flag " " - "xft fontconfig x11 libpng)")))) - (list (string-append "CC=" ,(cc-for-target)) + (string-append "$(shell pkg-config " flag " " + "xft fontconfig x11 libpng)")))) + (list (string-append "CC=" + ,(cc-for-target)) (string-append "PREFIX=" %output) - (string-append "INCS=-I. " (pkg-config "--cflags")) - (string-append "LIBS=" (pkg-config "--libs") " -lm"))))) - (native-inputs - (list pkg-config)) - (inputs - `(("farbfeld" ,farbfeld) - ("libpng" ,libpng) - ("libx11" ,libx11) - ("libxft" ,libxft) - ("fontconfig" ,fontconfig))) + (string-append "INCS=-I. " + (pkg-config "--cflags")) + (string-append "LIBS=" + (pkg-config "--libs") " -lm"))))) + (native-inputs (list pkg-config)) + (inputs `(("farbfeld" ,farbfeld) ("libpng" ,libpng) + ("libx11" ,libx11) + ("libxft" ,libxft) + ("fontconfig" ,fontconfig))) (synopsis "Plain-text presentation tool") - (description "Sent uses plain-text files and PNG images to create slideshow + (description + "Sent uses plain-text files and PNG images to create slideshow presentations. Each paragraph represents a slide in the presentation. Especially for presentations using the Takahashi method this is very nice and allows you to write down the presentation for a quick lightning talk within a -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 17:15:04 2022 Received: (at 56087-done) by debbugs.gnu.org; 22 Jun 2022 21:15:04 +0000 Received: from localhost ([127.0.0.1]:36746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o47gm-0000lq-Jm for submit@debbugs.gnu.org; Wed, 22 Jun 2022 17:15:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o47gj-0000ks-Lr for 56087-done@debbugs.gnu.org; Wed, 22 Jun 2022 17:15:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52448) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o47gc-0008Mt-BK; Wed, 22 Jun 2022 17:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+AMlbr3lXRM2RAbzSA9w2e+aAWoFuSx6lplNG8WY3sY=; b=oo8AnmP0BzN+XPPhDGfc 05HfCJOYdGkH58ZuUXSj/e5ACfs5Ik2deQ2IDcW3t10q1fdbtbZ+wgYyOS5+wi7ilGA26sh7kgACl OIxWN1yVTPKqLD4dSfy10GaznH73GD/mEVOKHoSG2ixvCZVYmbu9NEtcl+XGVE1DdGvEkzBXXS3Sd LhSiYZ6MFZEW2hqKnpySwRUfffpfSLUZuVxXcCr4QI3NeO98rVSCHoTk0AfwK3WXu1AXOsUafdE2H 0S6KTV37e2PeIuqmhMFvKaeLLCB1oTktKcTbvc1NixVL0O0smfx7VumLGra0VIIb8d4OYhIS7RKOQ 9N+Xq306h1Lfdw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50211 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o47gb-0003Or-Ty; Wed, 22 Jun 2022 17:14:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Gabriel Wicki Subject: Re: bug#56087: [PATCH] gnu: suckless: add farbfeld and propagate input to sent References: <20220619115925.bcrcjpd7yse2n25t@silvi> <66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be> <20220621005047.ajgnk3ob22t37wsc@silvi> Date: Wed, 22 Jun 2022 23:14:51 +0200 In-Reply-To: <20220621005047.ajgnk3ob22t37wsc@silvi> (Gabriel Wicki's message of "Tue, 21 Jun 2022 02:50:47 +0200") Message-ID: <87mte41juc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56087-done Cc: Maxime Devos , 56087-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Gabriel, Gabriel Wicki skribis: >>>From 15e88ce3cb4ab51d6fe9ad9ae3ab15a435fb4db8 Mon Sep 17 00:00:00 2001 > From: Gabriel Wicki > Date: Sat, 18 Jun 2022 17:00:16 +0200 > Subject: [PATCH 1/3] gnu: Add farbfeld. > > * gnu/packages/suckless.scm (farbfeld): New variable. > [use-modules]: Add (gnu packages imagemagick) [...] >>>From 1c5a9ff89bc4525b9e1a07b6b96b017ad58a81fe Mon Sep 17 00:00:00 2001 > From: Gabriel Wicki > Date: Sat, 18 Jun 2022 17:04:12 +0200 > Subject: [PATCH 2/3] gnu: sent: Add farbfeld to propagated-inputs. > > * gnu/packages/suckless.scm (sent)[propagated-inputs]: Add it. > [phases]{patch-farbfeld}: New phase. > [inputs]: Add farbfeld. > [home-page]: Add trailing slash to fix linter warning. [...] >>>From 6fb7a48822e51625de8ca1026260faac80adbe17 Mon Sep 17 00:00:00 2001 > From: Gabriel Wicki > Date: Tue, 21 Jun 2022 02:38:40 +0200 > Subject: [PATCH 3/3] gnu: sent: Apply guix style > > * gnu/packages/suckless.scm (sent): Apply `guix style`. Applied, thank you & thanks Maxime! I followed up with: guix style -S inputs sent --input-simplification=3Dalways The effect is to remove input labels. Ludo=E2=80=99. From unknown Wed Jun 18 23:13:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Jul 2022 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator