From unknown Thu Jun 19 14:03:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56049 <56049@debbugs.gnu.org> To: bug#56049 <56049@debbugs.gnu.org> Subject: Status: [PATCH] Fix invalid defcustom :group when :predicate is used Reply-To: bug#56049 <56049@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:17 +0000 retitle 56049 [PATCH] Fix invalid defcustom :group when :predicate is used reassign 56049 emacs submitter 56049 Richard Hansen severity 56049 normal tag 56049 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 01:10:21 2022 Received: (at submit) by debbugs.gnu.org; 18 Jun 2022 05:10:21 +0000 Received: from localhost ([127.0.0.1]:47369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Qiy-0006ZQ-KW for submit@debbugs.gnu.org; Sat, 18 Jun 2022 01:10:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:54388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Qiv-0006ZH-Le for submit@debbugs.gnu.org; Sat, 18 Jun 2022 01:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Qit-0003CQ-PK for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2022 01:10:16 -0400 Received: from spork.scientician.org ([66.228.35.160]:54676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Qir-0002MA-UJ for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2022 01:10:15 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 9F3E84810F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655529012; bh=7ZyD49Srwq6X+/XIXTF70UDuqwZMmke/XhRfvSPjbKY=; h=Date:To:From:Subject:From; b=GZGYEhV5NnWOkx9Bg36NcGHAqjQ45hDaFWsbe8KpSEPuKU76PIgbHQ1ALQOBbXVEf Omn/t+47TvS3GVCflX0EdBdtoElGvU0u8aULpWei0086DZ8aamBq1/FnMAkzuWP0nq 83G/7ysqpwCb2xqBzo6jythRm8tdgHfbRMdGF0L4= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 1F2742009D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655529011; bh=7ZyD49Srwq6X+/XIXTF70UDuqwZMmke/XhRfvSPjbKY=; h=Date:To:From:Subject:From; b=CPr9eNYNTiaOr+I4OzOte51Z6FgXcR4tbMLW0BhGQJQAHsvQvIpPctQdAEH9CQjey NAnlTyxAFOdHGjP+BQDX7QzlmMgSzpYg9YSlaJTyrlQk5smR5ZMURtDXG4vFjO8Yn4 JGmgh77LQ/KfTqplLrz1pnNNrDCkmR9N9Vf7CG2U= Message-ID: <319c0a6e-3179-2b81-6df3-3940f3367d99@rhansen.org> Date: Sat, 18 Jun 2022 01:10:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Richard Hansen Subject: [PATCH] Fix invalid defcustom :group when :predicate is used Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9tU3njHv4zZs1nlbJSdRQtVj" Received-SPF: pass client-ip=66.228.35.160; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9tU3njHv4zZs1nlbJSdRQtVj Content-Type: multipart/mixed; boundary="------------e696BjeSHk03G0xHW4T6BA42"; protected-headers="v1" From: Richard Hansen To: bug-gnu-emacs@gnu.org Message-ID: <319c0a6e-3179-2b81-6df3-3940f3367d99@rhansen.org> Subject: [PATCH] Fix invalid defcustom :group when :predicate is used --------------e696BjeSHk03G0xHW4T6BA42 Content-Type: multipart/mixed; boundary="------------aK58xP8FSSAyvxqfHMu2TNDQ" --------------aK58xP8FSSAyvxqfHMu2TNDQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 WC1EZWJidWdzLUNDOiBsYXJzaUBnbnVzLm9yZw0KDQpUaGUgYXR0YWNoZWQgcGF0Y2ggZml4 ZXMgYSBidWcgaW4gRW1hY3MgMjg6DQoNCiAgICAgRml4IGludmFsaWQgZGVmY3VzdG9tIDpn cm91cCB3aGVuIDpwcmVkaWNhdGUgaXMgdXNlZA0KDQogICAgICogbGlzcC9lbWFjcy1saXNw L2Vhc3ktbW1vZGUuZWwgKGRlZmluZS1nbG9iYWxpemVkLW1pbm9yLW1vZGUpOiBGaXgNCiAg ICAgaW52YWxpZCBgOmdyb3VwJyBhcmd1bWVudCBmb3IgdGhlIGAtbW9kZXMnIGRlZmN1c3Rv bSB0aGF0IGlzIGNyZWF0ZWQNCiAgICAgd2hlbiBgOnByZWRpY2F0ZScgaXMgdXNlZC4NCg== --------------aK58xP8FSSAyvxqfHMu2TNDQ Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-invalid-defcustom-group-when-predicate-is-used.patch" Content-Disposition: attachment; filename*0="0001-Fix-invalid-defcustom-group-when-predicate-is-used.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBmYmIxYWQzZDE0M2FhMzM1NTM0NTI3MTE4ZGIzMTE1MzgzYmU5ZmIzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU2F0LCAxOCBKdW4gMjAyMiAwMDo0MTowNCAtMDQwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBpbnZhbGlkIGRlZmN1c3RvbSA6Z3JvdXAgd2hlbiA6cHJlZGljYXRlIGlz IHVzZWQKCiogbGlzcC9lbWFjcy1saXNwL2Vhc3ktbW1vZGUuZWwgKGRlZmluZS1nbG9iYWxp emVkLW1pbm9yLW1vZGUpOiBGaXgKaW52YWxpZCBgOmdyb3VwJyBhcmd1bWVudCBmb3IgdGhl IGAtbW9kZXMnIGRlZmN1c3RvbSB0aGF0IGlzIGNyZWF0ZWQKd2hlbiBgOnByZWRpY2F0ZScg aXMgdXNlZC4KLS0tCiBsaXNwL2VtYWNzLWxpc3AvZWFzeS1tbW9kZS5lbCB8IDIgKy0KIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3AvZW1hY3MtbGlzcC9lYXN5LW1tb2RlLmVsIGIvbGlzcC9lbWFjcy1saXNwL2Vh c3ktbW1vZGUuZWwKaW5kZXggMWQ5M2ZlNDgwMS4uZGYzNzkwMzUwMyAxMDA2NDQKLS0tIGEv bGlzcC9lbWFjcy1saXNwL2Vhc3ktbW1vZGUuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2Vh c3ktbW1vZGUuZWwKQEAgLTU1NSw3ICs1NTUsNyBAQCBkZWZpbmUtZ2xvYmFsaXplZC1taW5v ci1tb2RlCiBsaXN0LiIKICAgICAgICAgICAgICAgICAgICAgICBtb2RlKQogICAgICAgICAg ICAgIDp0eXBlICcocmVwZWF0IHNleHApCi0gICAgICAgICAgICAgOmdyb3VwICxncm91cCkp CisgICAgICAgICAgICAgLEBncm91cCkpCiAKICAgICAgICA7OyBBdXRvbG9hZGluZyBkZWZp bmUtZ2xvYmFsaXplZC1taW5vci1tb2RlIGF1dG9sb2FkcyBldmVyeXRoaW5nCiAgICAgICAg OzsgdXAtdG8taGVyZS4KLS0gCjIuMzYuMQoK --------------aK58xP8FSSAyvxqfHMu2TNDQ-- --------------e696BjeSHk03G0xHW4T6BA42-- --------------9tU3njHv4zZs1nlbJSdRQtVj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKtXi4ACgkQ0GvrRa1X 4hR4lg//entNQP1Nu6l6vbFdtiw000aY+aXs13tsoMZvXti0oS5oUqqQiED3s3oT eu+rvUyqlqbb+dKg5F44xobNafTGxsnGLquWO4DTNPhBXJG0a1pKIYzNf9l7OkRy iudNoDxz/WA+WAlOPVMgsKY2QXAW/cUH9woRsc24c3xUkWsWMfJr2oJtdl+xSkmZ rQnuB7WsBybgcAa/93eM4kCxr5X3sFaIx+ZLlXpQgJdJm31DDf0j7QtvaptYfiyy aM9ZzbaeHSd3ZnXvavcRD0W5CN1ENyVtbzdedTbodz5URbQr2OlhPyqVUXkBeZal IMtQv9G9Wc4VcXjiAIAvMhmHNFGCga8JPvJi2sqMtBeQmJfYppAtSTLaBlHEDCzI XkBXhhNlALBG+XdiMeDSnA6en7ruoJ/l0L48nulfzbqcHR/F9/nt7KITHYwNsdY9 zCT0bgQ7Al3r679NskaSXN1AHFoeCpJpzIDtd0WG49PGPJS7Ld1w1ZbXJOHQ2CH8 O2guosAVrMV1W48ukUWNaDZuyTpvFtNq2QIm2wVr+HHJYKvDZjdg5/1FVISmITCv D6FWkgjjFf3HAzO05MJbZgDpDu76EUTtXLo1FFoaFVtsqu6HjCL7DueSKMAmVrj+ 7l0ZNTlKV0RIXmjW3N1CGaKSVUuO9/au//zXw2Y9RDzrdzKtNn4= =VQFp -----END PGP SIGNATURE----- --------------9tU3njHv4zZs1nlbJSdRQtVj-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 08:11:29 2022 Received: (at 56049) by debbugs.gnu.org; 18 Jun 2022 12:11:29 +0000 Received: from localhost ([127.0.0.1]:47748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2XIW-0002Sf-Pz for submit@debbugs.gnu.org; Sat, 18 Jun 2022 08:11:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2XIV-0002SJ-5S for 56049@debbugs.gnu.org; Sat, 18 Jun 2022 08:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nizaB+vNOv71Jn1ztiDWa6kXsxoRvS7bFITsLtfq3+0=; b=VmpjCE4RhwtfihsmtSHcurwr/Y db0AMfhmnxH8dTnq1sWJCkvBWxWCFSgmTmuMnvuLjFQ52DoF2FmFibJNyUANjccKmL6JRfxWWLm8k HBAnl/c+AAK+Yv98cixdVixaC5PVtmPM0Tqb9D7pgC6Mvji8HimQ5r5d0jTuYr+5OLNw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2XIK-0005ac-UW; Sat, 18 Jun 2022 14:11:19 +0200 From: Lars Ingebrigtsen To: Richard Hansen Subject: Re: bug#56049: [PATCH] Fix invalid defcustom :group when :predicate is used References: <319c0a6e-3179-2b81-6df3-3940f3367d99@rhansen.org> X-Now-Playing: Alfa Mist's _Blue Note Re:imagined (1)_: "Galaxy" Date: Sat, 18 Jun 2022 14:11:15 +0200 In-Reply-To: <319c0a6e-3179-2b81-6df3-3940f3367d99@rhansen.org> (Richard Hansen's message of "Sat, 18 Jun 2022 01:10:06 -0400") Message-ID: <87o7yq189o.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Richard Hansen writes: > The attached patch fixes a bug in Emacs 28: > > Fix invalid defcustom :group when :predicate is used > > * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix > invalid `:group' argume [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56049 Cc: 56049@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Richard Hansen writes: > The attached patch fixes a bug in Emacs 28: > > Fix invalid defcustom :group when :predicate is used > > * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix > invalid `:group' argument for the `-modes' defcustom that is created > when `:predicate' is used. Thanks; pushed to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 08:11:37 2022 Received: (at control) by debbugs.gnu.org; 18 Jun 2022 12:11:37 +0000 Received: from localhost ([127.0.0.1]:47751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2XIf-0002T1-1T for submit@debbugs.gnu.org; Sat, 18 Jun 2022 08:11:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2XIe-0002So-18 for control@debbugs.gnu.org; Sat, 18 Jun 2022 08:11:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YdJDKyGg/vaYjSE6y/GN9QUBJFHDv4C6LDus6AlzTgI=; b=LS1w3EtRaxdP+n4I0F/75UuMn9 lKxfCmhVNoNrLOGFLxGvKlvaVhaOfyIqaDBeJkjV6M8G7AkkgLHzYY8t4u6DfQk1dfTf4UjNU38U7 ODvCR6hF8pxr9UzHy9cqpKE3QOvUQBitbXDBwm0GGoP5rhbWA57YXE2Pw+Yqd5OVPHF8=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2XIV-0005b7-T5 for control@debbugs.gnu.org; Sat, 18 Jun 2022 14:11:29 +0200 Date: Sat, 18 Jun 2022 14:11:27 +0200 Message-Id: <87mtea189c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56049 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56049 28.2 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56049 28.2 quit From unknown Thu Jun 19 14:03:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Jul 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator