GNU bug report logs - #56048
[PATCH] bindat (strz): Null terminate fixed-length strings if there is room

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Richard Hansen <rhansen <at> rhansen.org>
Subject: bug#56048: closed (Re: bug#56048: [PATCH] bindat (strz): Null
 terminate fixed-length strings if there is room)
Date: Wed, 22 Jun 2022 13:58:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56048 <at> debbugs.gnu.org.

-- 
56048: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56048
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 56048-done <at> debbugs.gnu.org, rhansen <at> rhansen.org
Subject: Re: bug#56048: [PATCH] bindat (strz): Null terminate fixed-length
 strings if there is room
Date: Wed, 22 Jun 2022 16:57:19 +0300

> Cc: 56048 <at> debbugs.gnu.org
> Date: Tue, 21 Jun 2022 16:44:06 -0400
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Thanks, Richard.  Looks good to me.

Installed on master.

[Message part 3 (message/rfc822, inline)]

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] bindat (strz): Null terminate fixed-length strings if there
 is room
Date: Fri, 17 Jun 2022 18:52:51 -0400

[Message part 4 (text/plain, inline)]

X-Debbugs-CC: monnier <at> iro.umontreal.ca

Two patches attached:

Patch 1:

    ; bindat (strz): Move all pack logic to pack function

Patch 2:

    bindat (strz): Null terminate fixed-length strings if there is room

    * lisp/emacs-lisp/bindat.el (bindat--pack-strz): For fixed-length strz
    fields, explicitly write a null terminator after the packed string if
    there is room.
    * doc/lispref/processes.texi (Bindat Types): Update documentation.
    * test/lisp/emacs-lisp/bindat-tests.el (bindat-test--str-strz-prealloc):
    Update tests.

[0001-bindat-strz-Move-all-pack-logic-to-pack-function.patch (text/x-patch, attachment)]

[0002-bindat-strz-Null-terminate-fixed-length-strings-if-t.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.