From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 18:53:08 2022 Received: (at submit) by debbugs.gnu.org; 17 Jun 2022 22:53:08 +0000 Received: from localhost ([127.0.0.1]:47199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Kpv-0005sB-V8 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 18:53:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:53428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Kpq-0005ri-07 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 18:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Kpo-0004L4-SG for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2022 18:53:00 -0400 Received: from spork.scientician.org ([66.228.35.160]:40930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Kpm-0001HK-Gv for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2022 18:53:00 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 1AA124810E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655506376; bh=l7O9bddFJsD50Gw6cLQ18gQYktlX9Dx1oKMHhZq7stY=; h=Date:From:Subject:To:From; b=CNJ3dAgBrhx3qAS6Sk0+5Z5j+8mgeMrC0nItoeMLHS+ki/f8JrNFJtM8Jtm1Cxhry eogNVo3Zs+R7YaM+xpiFgkk2TMEbe1UIhA0zsytGCOwuPFkJOZQ6GNSH7jH61Q5Cbe 4w3freQmrHLkdJ3Mk0nBfGNdFL5AWiuD6f098KSM= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id A953C2009D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655506374; bh=l7O9bddFJsD50Gw6cLQ18gQYktlX9Dx1oKMHhZq7stY=; h=Date:From:Subject:To:From; b=qh4cK1u7A81DXWOeTc5qGqPvR2tIMX9vYeIYiW2xEl+Nno8ZVvNQghYiHgMQSvRao +iP9kRPDbAZlhFI/XdMqx1BbHxQhrJtY8zzozeuLXPBDeRMhSGKOKh8LX6RDd7bm40 RipCggkrjqHhZiUK5T3mIlocS6uEeKdnhFQ0JfTI= Message-ID: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> Date: Fri, 17 Jun 2022 18:52:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US From: Richard Hansen Subject: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room To: bug-gnu-emacs@gnu.org Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------bfrbeslM6Up3oLts3bIJS0FR" Received-SPF: pass client-ip=66.228.35.160; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------bfrbeslM6Up3oLts3bIJS0FR Content-Type: multipart/mixed; boundary="------------qVHWELqXzHWtQVXbZCY8PGKv"; protected-headers="v1" From: Richard Hansen To: bug-gnu-emacs@gnu.org Message-ID: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> Subject: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room --------------qVHWELqXzHWtQVXbZCY8PGKv Content-Type: multipart/mixed; boundary="------------C2gfd03TqkvekvenM61GSXwc" --------------C2gfd03TqkvekvenM61GSXwc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 WC1EZWJidWdzLUNDOiBtb25uaWVyQGlyby51bW9udHJlYWwuY2ENCg0KVHdvIHBhdGNoZXMg YXR0YWNoZWQ6DQoNClBhdGNoIDE6DQoNCiAgICAgOyBiaW5kYXQgKHN0cnopOiBNb3ZlIGFs bCBwYWNrIGxvZ2ljIHRvIHBhY2sgZnVuY3Rpb24NCg0KUGF0Y2ggMjoNCg0KICAgICBiaW5k YXQgKHN0cnopOiBOdWxsIHRlcm1pbmF0ZSBmaXhlZC1sZW5ndGggc3RyaW5ncyBpZiB0aGVy ZSBpcyByb29tDQoNCiAgICAgKiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIChiaW5kYXQt LXBhY2stc3Ryeik6IEZvciBmaXhlZC1sZW5ndGggc3Ryeg0KICAgICBmaWVsZHMsIGV4cGxp Y2l0bHkgd3JpdGUgYSBudWxsIHRlcm1pbmF0b3IgYWZ0ZXIgdGhlIHBhY2tlZCBzdHJpbmcg aWYNCiAgICAgdGhlcmUgaXMgcm9vbS4NCiAgICAgKiBkb2MvbGlzcHJlZi9wcm9jZXNzZXMu dGV4aSAoQmluZGF0IFR5cGVzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uDQogICAgICogdGVz dC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChiaW5kYXQtdGVzdC0tc3RyLXN0 cnotcHJlYWxsb2MpOg0KICAgICBVcGRhdGUgdGVzdHMuDQo= --------------C2gfd03TqkvekvenM61GSXwc Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-strz-Move-all-pack-logic-to-pack-function.patch" Content-Disposition: attachment; filename*0="0001-bindat-strz-Move-all-pack-logic-to-pack-function.patch" Content-Transfer-Encoding: base64 RnJvbSAwNjJkZTZhYWUyZTM3MTEwYWMzNzU1NzA1OGQxNzM4ZDAwOWNkZDc3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCAyOSBNYXkgMjAyMiAyMToyMzo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggMS8yXSA7IGJpbmRhdCAoc3Ryeik6IE1vdmUgYWxsIHBhY2sgbG9naWMgdG8gcGFj ayBmdW5jdGlvbgoKLS0tCiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIHwgNDggKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjIg aW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFj cy1saXNwL2JpbmRhdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwKaW5kZXggNDZl MmE0OTAxYy4uZjdmNTQwZjVmZCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2JpbmRh dC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCkBAIC00NDAsMjAgKzQ0MCwy NiBAQCBiaW5kYXQtLXBhY2stc3RyCiAgICAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRh dC1pZHggaSkgKGFyZWYgdiBpKSkpCiAgICAgKHNldHEgYmluZGF0LWlkeCAoKyBiaW5kYXQt aWR4IGxlbikpKSkKIAotKGRlZnVuIGJpbmRhdC0tcGFjay1zdHJ6ICh2KQorKGRlZnVuIGJp bmRhdC0tcGFjay1zdHJ6IChsZW4gdikKICAgKGxldCogKCh2IChzdHJpbmctdG8tdW5pYnl0 ZSB2KSkKLSAgICAgICAgIChsZW4gKGxlbmd0aCB2KSkpCi0gICAgKGRvdGltZXMgKGkgbGVu KQotICAgICAgKHdoZW4gKD0gKGFyZWYgdiBpKSAwKQotICAgICAgICA7OyBBbHRlcm5hdGl2 ZWx5IHdlIGNvdWxkIHByZXRlbmQgdGhhdCB0aGlzIHdhcyB0aGUgZW5kIG9mCi0gICAgICAg IDs7IHRoZSBzdHJpbmcgYW5kIHN0b3AgcGFja2luZywgYnV0IHRoZW4gYmluZGF0LWxlbmd0 aCB3b3VsZAotICAgICAgICA7OyBuZWVkIHRvIHNjYW4gdGhlIGlucHV0IHN0cmluZyBsb29r aW5nIGZvciBhIG51bGwgYnl0ZS4KLSAgICAgICAgKGVycm9yICJOdWxsIGJ5dGUgZW5jb3Vu dGVyZWQgaW4gaW5wdXQgc3RyeiBzdHJpbmciKSkKLSAgICAgIChhc2V0IGJpbmRhdC1yYXcg KCsgYmluZGF0LWlkeCBpKSAoYXJlZiB2IGkpKSkKLSAgICA7OyBFeHBsaWNpdGx5IHdyaXRl IGEgbnVsbCB0ZXJtaW5hdG9yIGluIGNhc2UgdGhlIHVzZXIgcHJvdmlkZWQgYQotICAgIDs7 IHByZS1hbGxvY2F0ZWQgc3RyaW5nIHRvIGJpbmRhdC1wYWNrIHRoYXQgd2Fzbid0IHplcm9l ZCBmaXJzdC4KLSAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggbGVuKSAwKQot ICAgIChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0LWlkeCBsZW4gMSkpKSkKKyAgICAgICAg ICh2bGVuIChsZW5ndGggdikpKQorICAgIChpZiBsZW4KKyAgICAgICAgOzsgV2hlbiBsZW4g aXMgc3BlY2lmaWVkLCBiZWhhdmUgdGhlIHNhbWUgYXMgdGhlIHN0ciB0eXBlIHNpbmNlIHdl IGRvbid0CisgICAgICAgIDs7IGFjdHVhbGx5IGFkZCB0aGUgdGVybWluYXRpbmcgemVybyBh bnl3YXkgKGJlY2F1c2Ugd2UgcmVseSBvbiB0aGUgZmFjdAorICAgICAgICA7OyB0aGF0IGBi aW5kYXQtcmF3JyB3YXMgcHJlc3VtYWJseSBpbml0aWFsaXplZCB3aXRoIGFsbC16ZXJvZXMg YmVmb3JlCisgICAgICAgIDs7IHdlIHN0YXJ0ZWQpLgorICAgICAgICAoYmluZGF0LS1wYWNr LXN0ciBsZW4gdikKKyAgICAgIChkb3RpbWVzIChpIHZsZW4pCisgICAgICAgICh3aGVuICg9 IChhcmVmIHYgaSkgMCkKKyAgICAgICAgICA7OyBBbHRlcm5hdGl2ZWx5IHdlIGNvdWxkIHBy ZXRlbmQgdGhhdCB0aGlzIHdhcyB0aGUgZW5kIG9mCisgICAgICAgICAgOzsgdGhlIHN0cmlu ZyBhbmQgc3RvcCBwYWNraW5nLCBidXQgdGhlbiBiaW5kYXQtbGVuZ3RoIHdvdWxkCisgICAg ICAgICAgOzsgbmVlZCB0byBzY2FuIHRoZSBpbnB1dCBzdHJpbmcgbG9va2luZyBmb3IgYSBu dWxsIGJ5dGUuCisgICAgICAgICAgKGVycm9yICJOdWxsIGJ5dGUgZW5jb3VudGVyZWQgaW4g aW5wdXQgc3RyeiBzdHJpbmciKSkKKyAgICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5k YXQtaWR4IGkpIChhcmVmIHYgaSkpKQorICAgICAgOzsgRXhwbGljaXRseSB3cml0ZSBhIG51 bGwgdGVybWluYXRvciBpbiBjYXNlIHRoZSB1c2VyIHByb3ZpZGVkIGEKKyAgICAgIDs7IHBy ZS1hbGxvY2F0ZWQgc3RyaW5nIHRvIGJpbmRhdC1wYWNrIHRoYXQgd2Fzbid0IHplcm9lZCBm aXJzdC4KKyAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmluZGF0LWlkeCB2bGVuKSAwKQor ICAgICAgKHNldHEgYmluZGF0LWlkeCAoKyBiaW5kYXQtaWR4IHZsZW4gMSkpKSkpCiAKIChk ZWZ1biBiaW5kYXQtLXBhY2stYml0cyAobGVuIHYpCiAgIChsZXQgKChibnVtICgxLSAoKiA4 IGxlbikpKSBqIG0pCkBAIC00ODIsNyArNDg4LDggQEAgYmluZGF0LS1wYWNrLWl0ZW0KICAg ICgndTI0ciAoYmluZGF0LS1wYWNrLXUyNHIgdikpCiAgICAoJ3UzMnIgKGJpbmRhdC0tcGFj ay11MzJyIHYpKQogICAgKCdiaXRzIChiaW5kYXQtLXBhY2stYml0cyBsZW4gdikpCi0gICAo KG9yICdzdHIgJ3N0cnopIChiaW5kYXQtLXBhY2stc3RyIGxlbiB2KSkKKyAgICgnc3RyIChi aW5kYXQtLXBhY2stc3RyIGxlbiB2KSkKKyAgICgnc3RyeiAoYmluZGF0LS1wYWNrLXN0cnog bGVuIHYpKQogICAgKCd2ZWMKICAgICAobGV0ICgobCAobGVuZ3RoIHYpKSAodmxlbiAxKSkK ICAgICAgIChpZiAoY29uc3AgdmVjdHlwZSkKQEAgLTY5OSwxOCArNzA2LDcgQEAgYmluZGF0 LS10eXBlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChudW1iZXJwIGxlbikgbGVu KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IEdlbmVyYWwgZXhwcmVzc2lvbiBz dXBwb3J0LgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0IGAob3IgLGxlbiAoMSsg KGxlbmd0aCAsdmFsKSkpKSkpKQotICAgIChgKHBhY2sgLiAsYXJncykKLSAgICAgOzsgV2hl biBsZW4gaXMgc3BlY2lmaWVkLCBiZWhhdmUgdGhlIHNhbWUgYXMgdGhlIHN0ciB0eXBlIHNp bmNlIHdlIGRvbid0Ci0gICAgIDs7IGFjdHVhbGx5IGFkZCB0aGUgdGVybWluYXRpbmcgemVy byBhbnl3YXkgKGJlY2F1c2Ugd2UgcmVseSBvbiB0aGUgZmFjdAotICAgICA7OyB0aGF0IGBi aW5kYXQtcmF3JyB3YXMgcHJlc3VtYWJseSBpbml0aWFsaXplZCB3aXRoIGFsbC16ZXJvZXMg YmVmb3JlIHdlCi0gICAgIDs7IHN0YXJ0ZWQpLgotICAgICAoY29uZCA7IFNhbWUgb3B0aW1p emF0aW9ucyBhcyAnbGVuZ3RoIGFib3ZlLgotICAgICAgKChudWxsIGxlbikgYChiaW5kYXQt LXBhY2stc3RyeiAuICxhcmdzKSkKLSAgICAgICgobnVtYmVycCBsZW4pIGAoYmluZGF0LS1w YWNrLXN0ciAsbGVuIC4gLGFyZ3MpKQotICAgICAgKHQgKG1hY3JvZXhwLWxldDIgbmlsIGxl biBsZW4KLSAgICAgICAgICAgYChpZiAsbGVuCi0gICAgICAgICAgICAgICAgKGJpbmRhdC0t cGFjay1zdHIgLGxlbiAuICxhcmdzKQotICAgICAgICAgICAgICAoYmluZGF0LS1wYWNrLXN0 cnogLiAsYXJncykpKSkpKSkpCisgICAgKGAocGFjayAuICxhcmdzKSBgKGJpbmRhdC0tcGFj ay1zdHJ6ICxsZW4gLiAsYXJncykpKSkKIAogKGNsLWRlZm1ldGhvZCBiaW5kYXQtLXR5cGUg KG9wIChfIChlcWwgJ2JpdHMpKSAgbGVuKQogICAoYmluZGF0LS1wY2FzZSBvcAotLSAKMi4z Ni4xCgo= --------------C2gfd03TqkvekvenM61GSXwc Content-Type: text/x-patch; charset=UTF-8; name="0002-bindat-strz-Null-terminate-fixed-length-strings-if-t.patch" Content-Disposition: attachment; filename*0="0002-bindat-strz-Null-terminate-fixed-length-strings-if-t.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzMjUxMDBjZDdkYTMyZTlhMTNiYzk0YTU0NDg5NmI2OTgyNGFhMTJlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAxNiBKdW4gMjAyMiAxNToyMTo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBiaW5kYXQgKHN0cnopOiBOdWxsIHRlcm1pbmF0ZSBmaXhlZC1sZW5ndGgg c3RyaW5ncyBpZgogdGhlcmUgaXMgcm9vbQoKKiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0LmVs IChiaW5kYXQtLXBhY2stc3Ryeik6IEZvciBmaXhlZC1sZW5ndGggc3RyegpmaWVsZHMsIGV4 cGxpY2l0bHkgd3JpdGUgYSBudWxsIHRlcm1pbmF0b3IgYWZ0ZXIgdGhlIHBhY2tlZCBzdHJp bmcgaWYKdGhlcmUgaXMgcm9vbS4KKiBkb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSAoQmlu ZGF0IFR5cGVzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uCiogdGVzdC9saXNwL2VtYWNzLWxp c3AvYmluZGF0LXRlc3RzLmVsIChiaW5kYXQtdGVzdC0tc3RyLXN0cnotcHJlYWxsb2MpOgpV cGRhdGUgdGVzdHMuCi0tLQogZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkgICAgICAgICAg IHwgMzAgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQogbGlzcC9lbWFjcy1saXNwL2Jp bmRhdC5lbCAgICAgICAgICAgIHwgMTQgKysrKysrLS0tLS0tLQogdGVzdC9saXNwL2VtYWNz LWxpc3AvYmluZGF0LXRlc3RzLmVsIHwgMTIgKysrKystLS0tLS0KIDMgZmlsZXMgY2hhbmdl ZCwgMjggaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j L2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkgYi9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aQpp bmRleCBiOTIwMGFlZGRlLi5kMDM4ZDUyZDQ0IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9w cm9jZXNzZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aQpAQCAtMzUw OSwyMyArMzUwOSwyMyBAQCBCaW5kYXQgVHlwZXMKIChidXQgZXhjbHVkaW5nKSB0aGUgbnVs bCBieXRlIHRoYXQgdGVybWluYXRlZCB0aGUgaW5wdXQgc3RyaW5nLgogCiBJZiBAdmFye2xl bn0gaXMgcHJvdmlkZWQsIEBjb2Rle3N0cnp9IGJlaGF2ZXMgdGhlIHNhbWUgYXMgQGNvZGV7 c3RyfSwKLWJ1dCB3aXRoIG9uZSBkaWZmZXJlbmNlOiB3aGVuIHVucGFja2luZywgdGhlIGZp cnN0IG51bGwgYnl0ZQotZW5jb3VudGVyZWQgaW4gdGhlIHBhY2tlZCBzdHJpbmcgaXMgaW50 ZXJwcmV0ZWQgYXMgdGhlIHRlcm1pbmF0aW5nCi1ieXRlLCBhbmQgaXQgYW5kIGFsbCBzdWJz ZXF1ZW50IGJ5dGVzIGFyZSBleGNsdWRlZCBmcm9tIHRoZSByZXN1bHQgb2YKLXRoZSB1bnBh Y2tpbmcuCitidXQgd2l0aCBhIGNvdXBsZSBvZiBkaWZmZXJlbmNlczoKKworQGl0ZW1pemUg QGJ1bGxldAorQGl0ZW0KK1doZW4gcGFja2luZywgYSBudWxsIHRlcm1pbmF0b3IgaXMgd3Jp dHRlbiBhZnRlciB0aGUgcGFja2VkIHN0cmluZyBpZgordGhlIGxlbmd0aCBvZiB0aGUgaW5w dXQgc3RyaW5nIGlzIGxlc3MgdGhhbiBAdmFye2xlbn0uCisKK0BpdGVtCitXaGVuIHVucGFj a2luZywgdGhlIGZpcnN0IG51bGwgYnl0ZSBlbmNvdW50ZXJlZCBpbiB0aGUgcGFja2VkIHN0 cmluZworaXMgaW50ZXJwcmV0ZWQgYXMgdGhlIHRlcm1pbmF0aW5nIGJ5dGUsIGFuZCBpdCBh bmQgYWxsIHN1YnNlcXVlbnQKK2J5dGVzIGFyZSBleGNsdWRlZCBmcm9tIHRoZSByZXN1bHQg b2YgdGhlIHVucGFja2luZy4KK0BlbmQgaXRlbWl6ZQogCiBAcXVvdGF0aW9uIENhdXRpb24K LVRoZSBwYWNrZWQgb3V0cHV0IHdpbGwgbm90IGJlIG51bGwtdGVybWluYXRlZCB1bmxlc3Mg b25lIG9mIHRoZQotZm9sbG93aW5nIGlzIHRydWU6Ci1AaXRlbWl6ZQotQGl0ZW0KLVRoZSBp bnB1dCBzdHJpbmcgaXMgc2hvcnRlciB0aGFuIEB2YXJ7bGVufSBieXRlcyBhbmQgZWl0aGVy IG5vIHByZS1hbGxvY2F0ZWQKLXN0cmluZyB3YXMgcHJvdmlkZWQgdG8gQGNvZGV7YmluZGF0 LXBhY2t9IG9yIHRoZSBhcHByb3ByaWF0ZSBieXRlIGluCi10aGUgcHJlLWFsbG9jYXRlZCBz dHJpbmcgd2FzIGFscmVhZHkgbnVsbC4KLUBpdGVtCi1UaGUgaW5wdXQgc3RyaW5nIGNvbnRh aW5zIGEgbnVsbCBieXRlIHdpdGhpbiB0aGUgZmlyc3QgQHZhcntsZW59Ci1ieXRlcy4KLUBl bmQgaXRlbWl6ZQorVGhlIHBhY2tlZCBvdXRwdXQgd2lsbCBub3QgYmUgbnVsbC10ZXJtaW5h dGVkIHVubGVzcyB0aGUgaW5wdXQgc3RyaW5nCitpcyBzaG9ydGVyIHRoYW4gQHZhcntsZW59 IGJ5dGVzIG9yIGl0IGNvbnRhaW5zIGEgbnVsbCBieXRlIHdpdGhpbiB0aGUKK2ZpcnN0IEB2 YXJ7bGVufSBieXRlcy4KIEBlbmQgcXVvdGF0aW9uCiAKIEBpdGVtIHZlYyBAdmFye2xlbn0g W0B2YXJ7dHlwZX1dCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIGIv bGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbAppbmRleCBmN2Y1NDBmNWZkLi42NDI4YjBlOTY1 IDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCisrKyBiL2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQuZWwKQEAgLTQ0MywxMSArNDQzLDE0IEBAIGJpbmRhdC0tcGFjay1z dHIKIChkZWZ1biBiaW5kYXQtLXBhY2stc3RyeiAobGVuIHYpCiAgIChsZXQqICgodiAoc3Ry aW5nLXRvLXVuaWJ5dGUgdikpCiAgICAgICAgICAodmxlbiAobGVuZ3RoIHYpKSkKKyAgICA7 OyBFeHBsaWNpdGx5IHdyaXRlIGEgbnVsbCB0ZXJtaW5hdG9yIChpZiB0aGVyZSdzIHJvb20p IGluIGNhc2UgdGhlIHVzZXIKKyAgICA7OyBwcm92aWRlZCBhIHByZS1hbGxvY2F0ZWQgc3Ry aW5nIHRvIGBiaW5kYXQtcGFjaycgdGhhdCB3YXNuJ3QgYWxyZWFkeQorICAgIDs7IHplcm9l ZC4KKyAgICAod2hlbiAob3IgKG51bGwgbGVuKSAoPCB2bGVuIGxlbikpCisgICAgICAoYXNl dCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggdmxlbikgMCkpCiAgICAgKGlmIGxlbgotICAg ICAgICA7OyBXaGVuIGxlbiBpcyBzcGVjaWZpZWQsIGJlaGF2ZSB0aGUgc2FtZSBhcyB0aGUg c3RyIHR5cGUgc2luY2Ugd2UgZG9uJ3QKLSAgICAgICAgOzsgYWN0dWFsbHkgYWRkIHRoZSB0 ZXJtaW5hdGluZyB6ZXJvIGFueXdheSAoYmVjYXVzZSB3ZSByZWx5IG9uIHRoZSBmYWN0Ci0g ICAgICAgIDs7IHRoYXQgYGJpbmRhdC1yYXcnIHdhcyBwcmVzdW1hYmx5IGluaXRpYWxpemVk IHdpdGggYWxsLXplcm9lcyBiZWZvcmUKLSAgICAgICAgOzsgd2Ugc3RhcnRlZCkuCisgICAg ICAgIDs7IFdoZW4gbGVuIGlzIHNwZWNpZmllZCwgYmVoYXZlIHRoZSBzYW1lIGFzIHRoZSBz dHIgdHlwZSAoZXhjZXB0IGZvcgorICAgICAgICA7OyB0aGUgbnVsbCB0ZXJtaW5hdG9yIHBv c3NpYmx5IHdyaXR0ZW4gYWJvdmUpLgogICAgICAgICAoYmluZGF0LS1wYWNrLXN0ciBsZW4g dikKICAgICAgIChkb3RpbWVzIChpIHZsZW4pCiAgICAgICAgICh3aGVuICg9IChhcmVmIHYg aSkgMCkKQEAgLTQ1Niw5ICs0NTksNiBAQCBiaW5kYXQtLXBhY2stc3RyegogICAgICAgICAg IDs7IG5lZWQgdG8gc2NhbiB0aGUgaW5wdXQgc3RyaW5nIGxvb2tpbmcgZm9yIGEgbnVsbCBi eXRlLgogICAgICAgICAgIChlcnJvciAiTnVsbCBieXRlIGVuY291bnRlcmVkIGluIGlucHV0 IHN0cnogc3RyaW5nIikpCiAgICAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmluZGF0LWlk eCBpKSAoYXJlZiB2IGkpKSkKLSAgICAgIDs7IEV4cGxpY2l0bHkgd3JpdGUgYSBudWxsIHRl cm1pbmF0b3IgaW4gY2FzZSB0aGUgdXNlciBwcm92aWRlZCBhCi0gICAgICA7OyBwcmUtYWxs b2NhdGVkIHN0cmluZyB0byBiaW5kYXQtcGFjayB0aGF0IHdhc24ndCB6ZXJvZWQgZmlyc3Qu Ci0gICAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggdmxlbikgMCkKICAgICAg IChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0LWlkeCB2bGVuIDEpKSkpKQogCiAoZGVmdW4g YmluZGF0LS1wYWNrLWJpdHMgKGxlbiB2KQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNz LWxpc3AvYmluZGF0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRl c3RzLmVsCmluZGV4IGNjMjIzYWQxNGUuLjBjMDNjNTFlMmUgMTAwNjQ0Ci0tLSBhL3Rlc3Qv bGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZW1hY3Mt bGlzcC9iaW5kYXQtdGVzdHMuZWwKQEAgLTE3MiwxNCArMTcyLDE0IEBAIGJpbmRhdC10ZXN0 LS1zdHItc3Ryei1wcmVhbGxvYwogICAgICAgICAgICAgICAgICgoKCh4IHN0ciAyKSkgKCh4 IC4gImEiKSkpIC4gImF4IikKICAgICAgICAgICAgICAgICAoKCgoeCBzdHIgMikpICgoeCAu ICJhYiIpKSkgLiAiYWIiKQogICAgICAgICAgICAgICAgICgoKCh4IHN0ciAyKSkgKCh4IC4g ImFiYyIpKSkgLiAiYWIiKQotICAgICAgICAgICAgICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6 IDEpICIiKSAuICJ4eCIpCi0gICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnog MikgIiIpIC4gInh4IikKLSAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAy KSAiYSIpIC4gImF4IikKKyAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAx KSAiIikgLiAiXDB4IikKKyAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAy KSAiIikgLiAiXDB4IikKKyAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAy KSAiYSIpIC4gImFcMCIpCiAgICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnog MikgImFiIikgLiAiYWIiKQogICAgICAgICAgICAgICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6 IDIpICJhYmMiKSAuICJhYiIpCi0gICAgICAgICAgICAgICAgKCgoKHggc3RyeiAxKSkgKCh4 IC4gIiIpKSkgLiAieHgiKQotICAgICAgICAgICAgICAgICgoKCh4IHN0cnogMikpICgoeCAu ICIiKSkpIC4gInh4IikKLSAgICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDIpKSAoKHggLiAi YSIpKSkgLiAiYXgiKQorICAgICAgICAgICAgICAgICgoKCh4IHN0cnogMSkpICgoeCAuICIi KSkpIC4gIlwweCIpCisgICAgICAgICAgICAgICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gIiIp KSkgLiAiXDB4IikKKyAgICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDIpKSAoKHggLiAiYSIp KSkgLiAiYVwwIikKICAgICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDIpKSAoKHggLiAiYWIi KSkpIC4gImFiIikKICAgICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDIpKSAoKHggLiAiYWJj IikpKSAuICJhYiIpCiAgICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnopICIi KSAuICJcMHgiKQotLSAKMi4zNi4xCgo= --------------C2gfd03TqkvekvenM61GSXwc-- --------------qVHWELqXzHWtQVXbZCY8PGKv-- --------------bfrbeslM6Up3oLts3bIJS0FR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKtBcQACgkQ0GvrRa1X 4hTFng/+NC3hOBP+gAd8g1i7YpGdP1Cn1gR9woBrCAFDP9eErDmCHlHVULeMQ7g4 utVjrXjrd8PD/dChHyDgk6ActG/ezxhJ4h62hiJaf4USjKn1bNBDd3Vp9WXVVqLz Ga6PGJxkK785umNnBwaKZ0ciLlq/xz5KrbMJZK5uvc/IA2wNWj+ImBm70gUv0T8+ Lmv2hgahWtUROnKzgQMKl2ivJGYl5U1REDZ7Y7FvwDJFAoH9bwiPLUZnzJknTDvA NHqHxpDwa5uWAH0MzACjfJgzi4mXIe+6z/pA5FbN7x7YlTbjr6kJJsejYPEwAP7k gXdTrDJZKIZ0t/OGE3tDPU4iagO1Y5RBS65UsXFuBAjA8s4KZGi2bCEidaM7OeMX 1rKvlS9TJ9vUl616iEYZA0z7cHxUeg23QwqB7YS3+iEvOqd5IjUxifW1GAWYDNfG a8QcRyppp7ed8fxtAeRHS/tmk2g9Rof6fp19+sCYc/2gX/OZDwD8Heh22FyfrRvU fGDIIZnXLwNTX/pJeL2XNcvCqk9MpLaLXB43cyBNJKkOkn0x6Cmk0YATGCavyY/w 3UeGY6fJwCkwy3VA2FPyKRXWdwsYJxgxuPmWRaCfO2YPa672VxcdO/QPX7q2OLIF 5nkBt2GFzUzca+NyiNzwR1jus512rAAL1cubHmxno957W9Bkzfs= =U6b9 -----END PGP SIGNATURE----- --------------bfrbeslM6Up3oLts3bIJS0FR-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 23:03:10 2022 Received: (at 56048) by debbugs.gnu.org; 18 Jun 2022 03:03:11 +0000 Received: from localhost ([127.0.0.1]:47323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Oju-0003Ni-B7 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 23:03:10 -0400 Received: from spork.scientician.org ([66.228.35.160]:41348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Ojm-0003NG-Gr for 56048@debbugs.gnu.org; Fri, 17 Jun 2022 23:03:09 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id D41754810F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655521381; bh=mccMmdzkokWh7oJzhrLxgwAEH4X/0G+JE1iRHsYe/RA=; h=Date:Subject:From:References:To:Cc:In-Reply-To:From; b=O/mOov2orxek5lGRnD/WXUyC/37cfD3fKn4M4I0C7nmM5n6ETdnNJSdA+Xp+hPZbp S+aligqan4/SD7QiKxMhxp+dxYeFIDS3momAx8aMt9nq2qTUCWKJq8CKT8tI3vNRWv +4UJ2nua52Kn99ZUjwfZAhKUxaBr7sj6fdQag/uw= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 6FAFA2009D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655521379; bh=mccMmdzkokWh7oJzhrLxgwAEH4X/0G+JE1iRHsYe/RA=; h=Date:Subject:From:References:To:Cc:In-Reply-To:From; b=PuNvrVUYVD37V28vIZXcwoMU6TVY0Fv/p/er+Mhaa7O4Cg6qriSr4qrofu2GvU4p1 Idw7H5kSXi7q0wiyWjQOnNw7+KFSzdXN18jPoDnd0vHq7LPvh8fMMszULlmIbfh1jD 4MXlWQqzI7uq77z1emT8cqUtmL/38aldUYP1Y6JE= Message-ID: Date: Fri, 17 Jun 2022 23:02:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room Content-Language: en-US From: Richard Hansen References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> To: 56048@debbugs.gnu.org In-Reply-To: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0cGwk6IiMMMcX1LeGIXhodm0" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56048 Cc: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0cGwk6IiMMMcX1LeGIXhodm0 Content-Type: multipart/mixed; boundary="------------MVj6CU0xKkj55kOvp4UZ0xeB"; protected-headers="v1" From: Richard Hansen To: 56048@debbugs.gnu.org Cc: monnier@iro.umontreal.ca Message-ID: Subject: Re: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> In-Reply-To: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> --------------MVj6CU0xKkj55kOvp4UZ0xeB Content-Type: multipart/mixed; boundary="------------BnM1JU0lYe9cEWBhXeqtXSp4" --------------BnM1JU0lYe9cEWBhXeqtXSp4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 QXR0YWNoZWQgYXJlIG5ldyByZXZpc2lvbnMgb2YgdGhlIHBhdGNoZXMuIFRoZSBvbmx5IGRp ZmZlcmVuY2VzIGFyZSB0aGUgY29tbWVudHMgd2VyZSBmaWxsZWQgYXQgY29sdW1uIDcwIGlu c3RlYWQgb2YgODAsIGFuZCB0aGUgY29tbWl0IG1lc3NhZ2UgbWVudGlvbnMgdGhlIGJ1ZyBu dW1iZXIuDQo= --------------BnM1JU0lYe9cEWBhXeqtXSp4 Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-bindat-strz-Move-all-pack-logic-to-pack-function.patch" Content-Disposition: attachment; filename*0="v2-0001-bindat-strz-Move-all-pack-logic-to-pack-function.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA2MDk2YmM4YmNlYWRhODdhNWM1NGU0ZWI1MDA4MTJhMGI3MmZmZDQ0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCAyOSBNYXkgMjAyMiAyMToyMzo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggdjIgMS8yXSA7IGJpbmRhdCAoc3Ryeik6IE1vdmUgYWxsIHBhY2sgbG9naWMgdG8g cGFjayBmdW5jdGlvbgoKLS0tCiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIHwgNDkgKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg MjMgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9l bWFjcy1saXNwL2JpbmRhdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwKaW5kZXgg NDZlMmE0OTAxYy4uNGE2NDJiYjljNSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2Jp bmRhdC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCkBAIC00NDAsMjAgKzQ0 MCwyNyBAQCBiaW5kYXQtLXBhY2stc3RyCiAgICAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJp bmRhdC1pZHggaSkgKGFyZWYgdiBpKSkpCiAgICAgKHNldHEgYmluZGF0LWlkeCAoKyBiaW5k YXQtaWR4IGxlbikpKSkKIAotKGRlZnVuIGJpbmRhdC0tcGFjay1zdHJ6ICh2KQorKGRlZnVu IGJpbmRhdC0tcGFjay1zdHJ6IChsZW4gdikKICAgKGxldCogKCh2IChzdHJpbmctdG8tdW5p Ynl0ZSB2KSkKLSAgICAgICAgIChsZW4gKGxlbmd0aCB2KSkpCi0gICAgKGRvdGltZXMgKGkg bGVuKQotICAgICAgKHdoZW4gKD0gKGFyZWYgdiBpKSAwKQotICAgICAgICA7OyBBbHRlcm5h dGl2ZWx5IHdlIGNvdWxkIHByZXRlbmQgdGhhdCB0aGlzIHdhcyB0aGUgZW5kIG9mCi0gICAg ICAgIDs7IHRoZSBzdHJpbmcgYW5kIHN0b3AgcGFja2luZywgYnV0IHRoZW4gYmluZGF0LWxl bmd0aCB3b3VsZAotICAgICAgICA7OyBuZWVkIHRvIHNjYW4gdGhlIGlucHV0IHN0cmluZyBs b29raW5nIGZvciBhIG51bGwgYnl0ZS4KLSAgICAgICAgKGVycm9yICJOdWxsIGJ5dGUgZW5j b3VudGVyZWQgaW4gaW5wdXQgc3RyeiBzdHJpbmciKSkKLSAgICAgIChhc2V0IGJpbmRhdC1y YXcgKCsgYmluZGF0LWlkeCBpKSAoYXJlZiB2IGkpKSkKLSAgICA7OyBFeHBsaWNpdGx5IHdy aXRlIGEgbnVsbCB0ZXJtaW5hdG9yIGluIGNhc2UgdGhlIHVzZXIgcHJvdmlkZWQgYQotICAg IDs7IHByZS1hbGxvY2F0ZWQgc3RyaW5nIHRvIGJpbmRhdC1wYWNrIHRoYXQgd2Fzbid0IHpl cm9lZCBmaXJzdC4KLSAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggbGVuKSAw KQotICAgIChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0LWlkeCBsZW4gMSkpKSkKKyAgICAg ICAgICh2bGVuIChsZW5ndGggdikpKQorICAgIChpZiBsZW4KKyAgICAgICAgOzsgV2hlbiBs ZW4gaXMgc3BlY2lmaWVkLCBiZWhhdmUgdGhlIHNhbWUgYXMgdGhlIHN0ciB0eXBlCisgICAg ICAgIDs7IHNpbmNlIHdlIGRvbid0IGFjdHVhbGx5IGFkZCB0aGUgdGVybWluYXRpbmcgemVy byBhbnl3YXkKKyAgICAgICAgOzsgKGJlY2F1c2Ugd2UgcmVseSBvbiB0aGUgZmFjdCB0aGF0 IGBiaW5kYXQtcmF3JyB3YXMKKyAgICAgICAgOzsgcHJlc3VtYWJseSBpbml0aWFsaXplZCB3 aXRoIGFsbC16ZXJvZXMgYmVmb3JlIHdlIHN0YXJ0ZWQpLgorICAgICAgICAoYmluZGF0LS1w YWNrLXN0ciBsZW4gdikKKyAgICAgIChkb3RpbWVzIChpIHZsZW4pCisgICAgICAgICh3aGVu ICg9IChhcmVmIHYgaSkgMCkKKyAgICAgICAgICA7OyBBbHRlcm5hdGl2ZWx5IHdlIGNvdWxk IHByZXRlbmQgdGhhdCB0aGlzIHdhcyB0aGUgZW5kIG9mCisgICAgICAgICAgOzsgdGhlIHN0 cmluZyBhbmQgc3RvcCBwYWNraW5nLCBidXQgdGhlbiBiaW5kYXQtbGVuZ3RoIHdvdWxkCisg ICAgICAgICAgOzsgbmVlZCB0byBzY2FuIHRoZSBpbnB1dCBzdHJpbmcgbG9va2luZyBmb3Ig YSBudWxsIGJ5dGUuCisgICAgICAgICAgKGVycm9yICJOdWxsIGJ5dGUgZW5jb3VudGVyZWQg aW4gaW5wdXQgc3RyeiBzdHJpbmciKSkKKyAgICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBi aW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQorICAgICAgOzsgRXhwbGljaXRseSB3cml0ZSBh IG51bGwgdGVybWluYXRvciBpbiBjYXNlIHRoZSB1c2VyIHByb3ZpZGVkCisgICAgICA7OyBh IHByZS1hbGxvY2F0ZWQgc3RyaW5nIHRvIGBiaW5kYXQtcGFjaycgdGhhdCB3YXNuJ3QgYWxy ZWFkeQorICAgICAgOzsgemVyb2VkLgorICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5k YXQtaWR4IHZsZW4pIDApCisgICAgICAoc2V0cSBiaW5kYXQtaWR4ICgrIGJpbmRhdC1pZHgg dmxlbiAxKSkpKSkKIAogKGRlZnVuIGJpbmRhdC0tcGFjay1iaXRzIChsZW4gdikKICAgKGxl dCAoKGJudW0gKDEtICgqIDggbGVuKSkpIGogbSkKQEAgLTQ4Miw3ICs0ODksOCBAQCBiaW5k YXQtLXBhY2staXRlbQogICAgKCd1MjRyIChiaW5kYXQtLXBhY2stdTI0ciB2KSkKICAgICgn dTMyciAoYmluZGF0LS1wYWNrLXUzMnIgdikpCiAgICAoJ2JpdHMgKGJpbmRhdC0tcGFjay1i aXRzIGxlbiB2KSkKLSAgICgob3IgJ3N0ciAnc3RyeikgKGJpbmRhdC0tcGFjay1zdHIgbGVu IHYpKQorICAgKCdzdHIgKGJpbmRhdC0tcGFjay1zdHIgbGVuIHYpKQorICAgKCdzdHJ6IChi aW5kYXQtLXBhY2stc3RyeiBsZW4gdikpCiAgICAoJ3ZlYwogICAgIChsZXQgKChsIChsZW5n dGggdikpICh2bGVuIDEpKQogICAgICAgKGlmIChjb25zcCB2ZWN0eXBlKQpAQCAtNjk5LDE4 ICs3MDcsNyBAQCBiaW5kYXQtLXR5cGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo KG51bWJlcnAgbGVuKSBsZW4pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgR2Vu ZXJhbCBleHByZXNzaW9uIHN1cHBvcnQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KHQgYChvciAsbGVuICgxKyAobGVuZ3RoICx2YWwpKSkpKSkpCi0gICAgKGAocGFjayAuICxh cmdzKQotICAgICA7OyBXaGVuIGxlbiBpcyBzcGVjaWZpZWQsIGJlaGF2ZSB0aGUgc2FtZSBh cyB0aGUgc3RyIHR5cGUgc2luY2Ugd2UgZG9uJ3QKLSAgICAgOzsgYWN0dWFsbHkgYWRkIHRo ZSB0ZXJtaW5hdGluZyB6ZXJvIGFueXdheSAoYmVjYXVzZSB3ZSByZWx5IG9uIHRoZSBmYWN0 Ci0gICAgIDs7IHRoYXQgYGJpbmRhdC1yYXcnIHdhcyBwcmVzdW1hYmx5IGluaXRpYWxpemVk IHdpdGggYWxsLXplcm9lcyBiZWZvcmUgd2UKLSAgICAgOzsgc3RhcnRlZCkuCi0gICAgIChj b25kIDsgU2FtZSBvcHRpbWl6YXRpb25zIGFzICdsZW5ndGggYWJvdmUuCi0gICAgICAoKG51 bGwgbGVuKSBgKGJpbmRhdC0tcGFjay1zdHJ6IC4gLGFyZ3MpKQotICAgICAgKChudW1iZXJw IGxlbikgYChiaW5kYXQtLXBhY2stc3RyICxsZW4gLiAsYXJncykpCi0gICAgICAodCAobWFj cm9leHAtbGV0MiBuaWwgbGVuIGxlbgotICAgICAgICAgICBgKGlmICxsZW4KLSAgICAgICAg ICAgICAgICAoYmluZGF0LS1wYWNrLXN0ciAsbGVuIC4gLGFyZ3MpCi0gICAgICAgICAgICAg IChiaW5kYXQtLXBhY2stc3RyeiAuICxhcmdzKSkpKSkpKSkKKyAgICAoYChwYWNrIC4gLGFy Z3MpIGAoYmluZGF0LS1wYWNrLXN0cnogLGxlbiAuICxhcmdzKSkpKQogCiAoY2wtZGVmbWV0 aG9kIGJpbmRhdC0tdHlwZSAob3AgKF8gKGVxbCAnYml0cykpICBsZW4pCiAgIChiaW5kYXQt LXBjYXNlIG9wCi0tIAoyLjM2LjEKCg== --------------BnM1JU0lYe9cEWBhXeqtXSp4 Content-Type: text/x-patch; charset=UTF-8; name="v2-0002-bindat-strz-Null-terminate-fixed-length-strings-i.patch" Content-Disposition: attachment; filename*0="v2-0002-bindat-strz-Null-terminate-fixed-length-strings-i.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5ZWJkYTY4MjY0YWRjYTZmNjBmNzgwZDQ0OTk1YzQyMTNkMmMxMmMyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAxNiBKdW4gMjAyMiAxNToyMTo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggdjIgMi8yXSBiaW5kYXQgKHN0cnopOiBOdWxsIHRlcm1pbmF0ZSBmaXhlZC1sZW5n dGggc3RyaW5ncyBpZgogdGhlcmUgaXMgcm9vbQoKKiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0 LmVsIChiaW5kYXQtLXBhY2stc3Ryeik6IEZvciBmaXhlZC1sZW5ndGggc3RyegpmaWVsZHMs IGV4cGxpY2l0bHkgd3JpdGUgYSBudWxsIHRlcm1pbmF0b3IgYWZ0ZXIgdGhlIHBhY2tlZCBz dHJpbmcgaWYKdGhlcmUgaXMgcm9vbSAoYnVnIzU2MDQ4KS4KKiBkb2MvbGlzcHJlZi9wcm9j ZXNzZXMudGV4aSAoQmluZGF0IFR5cGVzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uCiogdGVz dC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChiaW5kYXQtdGVzdC0tc3RyLXN0 cnotcHJlYWxsb2MpOgpVcGRhdGUgdGVzdHMuCi0tLQogZG9jL2xpc3ByZWYvcHJvY2Vzc2Vz LnRleGkgICAgICAgICAgIHwgMzAgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQogbGlz cC9lbWFjcy1saXNwL2JpbmRhdC5lbCAgICAgICAgICAgIHwgMTMgKysrKysrLS0tLS0tCiB0 ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgfCAxMiArKysrKy0tLS0tLQog MyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSBiL2RvYy9saXNwcmVmL3By b2Nlc3Nlcy50ZXhpCmluZGV4IGI5MjAwYWVkZGUuLmQwMzhkNTJkNDQgMTAwNjQ0Ci0tLSBh L2RvYy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL3Byb2Nlc3Nl cy50ZXhpCkBAIC0zNTA5LDIzICszNTA5LDIzIEBAIEJpbmRhdCBUeXBlcwogKGJ1dCBleGNs dWRpbmcpIHRoZSBudWxsIGJ5dGUgdGhhdCB0ZXJtaW5hdGVkIHRoZSBpbnB1dCBzdHJpbmcu CiAKIElmIEB2YXJ7bGVufSBpcyBwcm92aWRlZCwgQGNvZGV7c3Ryen0gYmVoYXZlcyB0aGUg c2FtZSBhcyBAY29kZXtzdHJ9LAotYnV0IHdpdGggb25lIGRpZmZlcmVuY2U6IHdoZW4gdW5w YWNraW5nLCB0aGUgZmlyc3QgbnVsbCBieXRlCi1lbmNvdW50ZXJlZCBpbiB0aGUgcGFja2Vk IHN0cmluZyBpcyBpbnRlcnByZXRlZCBhcyB0aGUgdGVybWluYXRpbmcKLWJ5dGUsIGFuZCBp dCBhbmQgYWxsIHN1YnNlcXVlbnQgYnl0ZXMgYXJlIGV4Y2x1ZGVkIGZyb20gdGhlIHJlc3Vs dCBvZgotdGhlIHVucGFja2luZy4KK2J1dCB3aXRoIGEgY291cGxlIG9mIGRpZmZlcmVuY2Vz OgorCitAaXRlbWl6ZSBAYnVsbGV0CitAaXRlbQorV2hlbiBwYWNraW5nLCBhIG51bGwgdGVy bWluYXRvciBpcyB3cml0dGVuIGFmdGVyIHRoZSBwYWNrZWQgc3RyaW5nIGlmCit0aGUgbGVu Z3RoIG9mIHRoZSBpbnB1dCBzdHJpbmcgaXMgbGVzcyB0aGFuIEB2YXJ7bGVufS4KKworQGl0 ZW0KK1doZW4gdW5wYWNraW5nLCB0aGUgZmlyc3QgbnVsbCBieXRlIGVuY291bnRlcmVkIGlu IHRoZSBwYWNrZWQgc3RyaW5nCitpcyBpbnRlcnByZXRlZCBhcyB0aGUgdGVybWluYXRpbmcg Ynl0ZSwgYW5kIGl0IGFuZCBhbGwgc3Vic2VxdWVudAorYnl0ZXMgYXJlIGV4Y2x1ZGVkIGZy b20gdGhlIHJlc3VsdCBvZiB0aGUgdW5wYWNraW5nLgorQGVuZCBpdGVtaXplCiAKIEBxdW90 YXRpb24gQ2F1dGlvbgotVGhlIHBhY2tlZCBvdXRwdXQgd2lsbCBub3QgYmUgbnVsbC10ZXJt aW5hdGVkIHVubGVzcyBvbmUgb2YgdGhlCi1mb2xsb3dpbmcgaXMgdHJ1ZToKLUBpdGVtaXpl Ci1AaXRlbQotVGhlIGlucHV0IHN0cmluZyBpcyBzaG9ydGVyIHRoYW4gQHZhcntsZW59IGJ5 dGVzIGFuZCBlaXRoZXIgbm8gcHJlLWFsbG9jYXRlZAotc3RyaW5nIHdhcyBwcm92aWRlZCB0 byBAY29kZXtiaW5kYXQtcGFja30gb3IgdGhlIGFwcHJvcHJpYXRlIGJ5dGUgaW4KLXRoZSBw cmUtYWxsb2NhdGVkIHN0cmluZyB3YXMgYWxyZWFkeSBudWxsLgotQGl0ZW0KLVRoZSBpbnB1 dCBzdHJpbmcgY29udGFpbnMgYSBudWxsIGJ5dGUgd2l0aGluIHRoZSBmaXJzdCBAdmFye2xl bn0KLWJ5dGVzLgotQGVuZCBpdGVtaXplCitUaGUgcGFja2VkIG91dHB1dCB3aWxsIG5vdCBi ZSBudWxsLXRlcm1pbmF0ZWQgdW5sZXNzIHRoZSBpbnB1dCBzdHJpbmcKK2lzIHNob3J0ZXIg dGhhbiBAdmFye2xlbn0gYnl0ZXMgb3IgaXQgY29udGFpbnMgYSBudWxsIGJ5dGUgd2l0aGlu IHRoZQorZmlyc3QgQHZhcntsZW59IGJ5dGVzLgogQGVuZCBxdW90YXRpb24KIAogQGl0ZW0g dmVjIEB2YXJ7bGVufSBbQHZhcnt0eXBlfV0KZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlz cC9iaW5kYXQuZWwgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCmluZGV4IDRhNjQyYmI5 YzUuLjBlY2FjM2Q1MmEgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwK KysrIGIvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbApAQCAtNDQzLDExICs0NDMsMTQgQEAg YmluZGF0LS1wYWNrLXN0cgogKGRlZnVuIGJpbmRhdC0tcGFjay1zdHJ6IChsZW4gdikKICAg KGxldCogKCh2IChzdHJpbmctdG8tdW5pYnl0ZSB2KSkKICAgICAgICAgICh2bGVuIChsZW5n dGggdikpKQorICAgIDs7IEV4cGxpY2l0bHkgd3JpdGUgYSBudWxsIHRlcm1pbmF0b3IgKGlm IHRoZXJlJ3Mgcm9vbSkgaW4gY2FzZQorICAgIDs7IHRoZSB1c2VyIHByb3ZpZGVkIGEgcHJl LWFsbG9jYXRlZCBzdHJpbmcgdG8gYGJpbmRhdC1wYWNrJyB0aGF0CisgICAgOzsgd2Fzbid0 IGFscmVhZHkgemVyb2VkLgorICAgICh3aGVuIChvciAobnVsbCBsZW4pICg8IHZsZW4gbGVu KSkKKyAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmluZGF0LWlkeCB2bGVuKSAwKSkKICAg ICAoaWYgbGVuCiAgICAgICAgIDs7IFdoZW4gbGVuIGlzIHNwZWNpZmllZCwgYmVoYXZlIHRo ZSBzYW1lIGFzIHRoZSBzdHIgdHlwZQotICAgICAgICA7OyBzaW5jZSB3ZSBkb24ndCBhY3R1 YWxseSBhZGQgdGhlIHRlcm1pbmF0aW5nIHplcm8gYW55d2F5Ci0gICAgICAgIDs7IChiZWNh dXNlIHdlIHJlbHkgb24gdGhlIGZhY3QgdGhhdCBgYmluZGF0LXJhdycgd2FzCi0gICAgICAg IDs7IHByZXN1bWFibHkgaW5pdGlhbGl6ZWQgd2l0aCBhbGwtemVyb2VzIGJlZm9yZSB3ZSBz dGFydGVkKS4KKyAgICAgICAgOzsgKGV4Y2VwdCBmb3IgdGhlIG51bGwgdGVybWluYXRvciBw b3NzaWJseSB3cml0dGVuIGFib3ZlKS4KICAgICAgICAgKGJpbmRhdC0tcGFjay1zdHIgbGVu IHYpCiAgICAgICAoZG90aW1lcyAoaSB2bGVuKQogICAgICAgICAod2hlbiAoPSAoYXJlZiB2 IGkpIDApCkBAIC00NTYsMTAgKzQ1OSw2IEBAIGJpbmRhdC0tcGFjay1zdHJ6CiAgICAgICAg ICAgOzsgbmVlZCB0byBzY2FuIHRoZSBpbnB1dCBzdHJpbmcgbG9va2luZyBmb3IgYSBudWxs IGJ5dGUuCiAgICAgICAgICAgKGVycm9yICJOdWxsIGJ5dGUgZW5jb3VudGVyZWQgaW4gaW5w dXQgc3RyeiBzdHJpbmciKSkKICAgICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5kYXQt aWR4IGkpIChhcmVmIHYgaSkpKQotICAgICAgOzsgRXhwbGljaXRseSB3cml0ZSBhIG51bGwg dGVybWluYXRvciBpbiBjYXNlIHRoZSB1c2VyIHByb3ZpZGVkCi0gICAgICA7OyBhIHByZS1h bGxvY2F0ZWQgc3RyaW5nIHRvIGBiaW5kYXQtcGFjaycgdGhhdCB3YXNuJ3QgYWxyZWFkeQot ICAgICAgOzsgemVyb2VkLgotICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5kYXQtaWR4 IHZsZW4pIDApCiAgICAgICAoc2V0cSBiaW5kYXQtaWR4ICgrIGJpbmRhdC1pZHggdmxlbiAx KSkpKSkKIAogKGRlZnVuIGJpbmRhdC0tcGFjay1iaXRzIChsZW4gdikKZGlmZiAtLWdpdCBh L3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFj cy1saXNwL2JpbmRhdC10ZXN0cy5lbAppbmRleCBjYzIyM2FkMTRlLi4wYzAzYzUxZTJlIDEw MDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwKKysrIGIv dGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsCkBAIC0xNzIsMTQgKzE3Miwx NCBAQCBiaW5kYXQtdGVzdC0tc3RyLXN0cnotcHJlYWxsb2MKICAgICAgICAgICAgICAgICAo KCgoeCBzdHIgMikpICgoeCAuICJhIikpKSAuICJheCIpCiAgICAgICAgICAgICAgICAgKCgo KHggc3RyIDIpKSAoKHggLiAiYWIiKSkpIC4gImFiIikKICAgICAgICAgICAgICAgICAoKCgo eCBzdHIgMikpICgoeCAuICJhYmMiKSkpIC4gImFiIikKLSAgICAgICAgICAgICAgICAoKCwo YmluZGF0LXR5cGUgc3RyeiAxKSAiIikgLiAieHgiKQotICAgICAgICAgICAgICAgICgoLChi aW5kYXQtdHlwZSBzdHJ6IDIpICIiKSAuICJ4eCIpCi0gICAgICAgICAgICAgICAgKCgsKGJp bmRhdC10eXBlIHN0cnogMikgImEiKSAuICJheCIpCisgICAgICAgICAgICAgICAgKCgsKGJp bmRhdC10eXBlIHN0cnogMSkgIiIpIC4gIlwweCIpCisgICAgICAgICAgICAgICAgKCgsKGJp bmRhdC10eXBlIHN0cnogMikgIiIpIC4gIlwweCIpCisgICAgICAgICAgICAgICAgKCgsKGJp bmRhdC10eXBlIHN0cnogMikgImEiKSAuICJhXDAiKQogICAgICAgICAgICAgICAgICgoLChi aW5kYXQtdHlwZSBzdHJ6IDIpICJhYiIpIC4gImFiIikKICAgICAgICAgICAgICAgICAoKCwo YmluZGF0LXR5cGUgc3RyeiAyKSAiYWJjIikgLiAiYWIiKQotICAgICAgICAgICAgICAgICgo KCh4IHN0cnogMSkpICgoeCAuICIiKSkpIC4gInh4IikKLSAgICAgICAgICAgICAgICAoKCgo eCBzdHJ6IDIpKSAoKHggLiAiIikpKSAuICJ4eCIpCi0gICAgICAgICAgICAgICAgKCgoKHgg c3RyeiAyKSkgKCh4IC4gImEiKSkpIC4gImF4IikKKyAgICAgICAgICAgICAgICAoKCgoeCBz dHJ6IDEpKSAoKHggLiAiIikpKSAuICJcMHgiKQorICAgICAgICAgICAgICAgICgoKCh4IHN0 cnogMikpICgoeCAuICIiKSkpIC4gIlwweCIpCisgICAgICAgICAgICAgICAgKCgoKHggc3Ry eiAyKSkgKCh4IC4gImEiKSkpIC4gImFcMCIpCiAgICAgICAgICAgICAgICAgKCgoKHggc3Ry eiAyKSkgKCh4IC4gImFiIikpKSAuICJhYiIpCiAgICAgICAgICAgICAgICAgKCgoKHggc3Ry eiAyKSkgKCh4IC4gImFiYyIpKSkgLiAiYWIiKQogICAgICAgICAgICAgICAgICgoLChiaW5k YXQtdHlwZSBzdHJ6KSAiIikgLiAiXDB4IikKLS0gCjIuMzYuMQoK --------------BnM1JU0lYe9cEWBhXeqtXSp4-- --------------MVj6CU0xKkj55kOvp4UZ0xeB-- --------------0cGwk6IiMMMcX1LeGIXhodm0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKtQGIACgkQ0GvrRa1X 4hRvYw/+Ifk81RlwurN3gIQlPV8IdD/BROARjqIZBst0xUB7xyZocG/jLHnoB3nT 0aWgObh4U1adddRxzbaY7X7AmiHplTkQeLmklpLGRuFtavq0+CIK+YSUvH4IX92R 9MGVGzhddaxLnXW8iIXZ0hIpVazFAPKTRGI7yvfC5ykTe8+SzjuXg4FaDA83Na1S NXCz4pp+CBf7oDMN5SjHN+3xe4UScVUbp+s0iGXhcXJ4MHa6FCXazKFKCH5ETCFA /CcW/eBJ1yL/2/lgk81NSsyqXtTlM4UpBfRtCVuMnvD4KxoiDWzr/d8BbPCUXRrB WDUv5JPMOcOBZ1z7ZBS7jPardE5pQBBObyWugcXYktiZHimNtbrwnzjZoQtrWVtV QS/T0cFiSQQV7KftFSBhPImKVa5ZW8eFa7+haW5mRGocFGhORIMcYuNc7ERMoFAg hdjOZPfCqUsIJuiL3zREhMccvvpMJJdtZs0OTc5dtBwCtfUT5AymbyajHv7IOGfk v8MUdmIHKI+tcMN1lG/ICZlwngALFv33EqT6+GYJdXpEviDFDlpeLVlpto62JTW6 PaBoXlW085iiiqLDMATl568Nqw4g+FjnHjqlBAQFD8Wp/KylAMKlw57iQcJ1SF5+ NKxzOduO6KL2lL7KFXn9JZvniLZhh+DhA0sq95HoinmIK0RkWmY= =Jdl4 -----END PGP SIGNATURE----- --------------0cGwk6IiMMMcX1LeGIXhodm0-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 02:33:02 2022 Received: (at 56048) by debbugs.gnu.org; 18 Jun 2022 06:33:02 +0000 Received: from localhost ([127.0.0.1]:47413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2S10-0000GV-93 for submit@debbugs.gnu.org; Sat, 18 Jun 2022 02:33:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2S0y-0000G9-38 for 56048@debbugs.gnu.org; Sat, 18 Jun 2022 02:33:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2S0s-0000Y8-6A; Sat, 18 Jun 2022 02:32:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/U/716SW2BVaXW8Ezch/FdeYBdhesKvOaP0KYVkWURU=; b=o5wenmAAi2n+ UIElHDf2hqJOZz2ZXmvSIVpHz90rhVCSKr1UdtvdtFnxYkm/wudWBPs+j4zfAbJlAA2m7TmWGqA9v 38ZZ5E9qKEDAzwIWsL2ZZiXxhR9rhB7rYcBdENP06LlJv4TkQMUDWNaQ1XMOkE0Si9GvUZlgWEmWo cd/Hc8o8hm+432V14yXjfZfOt99BkRsjS/zzRrJPOnqIe8uZ63/sHwcQG7ubjFH7P45cTgc3+BZF9 QD0+7ncfgkpDmoLXO93HZmP4WQaOZg4tJoByLKcGcu2M5JFyUKfYUNdwQvD1vPxNarUhQd379vmyu NeYO4PQVXFmcFViH4z4ayw==; Received: from [87.69.77.57] (port=4694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2S0r-0003bG-Lc; Sat, 18 Jun 2022 02:32:53 -0400 Date: Sat, 18 Jun 2022 09:32:51 +0300 Message-Id: <83r13mo50s.fsf@gnu.org> From: Eli Zaretskii To: Richard Hansen In-Reply-To: (message from Richard Hansen on Fri, 17 Jun 2022 23:02:57 -0400) Subject: Re: bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56048 Cc: 56048@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: monnier@iro.umontreal.ca > Date: Fri, 17 Jun 2022 23:02:57 -0400 > From: Richard Hansen > > Attached are new revisions of the patches. The only differences are the comments were filled at column 70 instead of 80, and the commit message mentions the bug number. While waiting for Stefan to tell whether he has any comments, a couple of nits: > Subject: [PATCH v2 1/2] ; bindat (strz): Move all pack logic to pack function What is the motivation/rationale for this refactoring? > +When packing, a null terminator is written after the packed string if > +the length of the input string is less than @var{len}. Since "length of a string" is highly ambiguous in Emacs, please always make a point of saying "@var{len} bytes" explicitly. Byte length is something rarely seen or used in Emacs, so people must be informed about that each time. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 18:57:35 2022 Received: (at 56048) by debbugs.gnu.org; 18 Jun 2022 22:57:35 +0000 Received: from localhost ([127.0.0.1]:50339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2hNm-0006RQ-F1 for submit@debbugs.gnu.org; Sat, 18 Jun 2022 18:57:35 -0400 Received: from spork.scientician.org ([66.228.35.160]:56742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2hNh-0006RE-4P for 56048@debbugs.gnu.org; Sat, 18 Jun 2022 18:57:33 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 684D54810E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655593048; bh=bVbhoyoH0NYIqgWb+2IYb9Q7zInVycA7LAa1ZJf0aCo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jmSDVEp3IXQIctyi91iWCL1BlHZFy3Vd4BE2TfsVgbNjErLIbsxbLmEu7OHZrvGtl B9qpT9Dz+S0g6wyL+Y56zMVLqyqs1PJ1qCB1qoTR8Y4g+ITeuwWKOjXWJhtV+cw8dw N9EBEnmi2gGTAaY68i9C3dblGFTOVkFq9SVTcpgc= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id D9DB42009D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655593046; bh=bVbhoyoH0NYIqgWb+2IYb9Q7zInVycA7LAa1ZJf0aCo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Zg8PZ/LVxbiJSgLY4t2/Q5KrLZH921p2iz1hv7xEiZOIQUuYPFtQU5ZNgRKBrhjHY 6GS5eOd0GH2Hnb1XKW7AT6h0KUEk6zRSnMwOtCMtiWjNU8pFeToFWi6v93gtWQ9nbj ncYop8wLnYr/ao0bYt8KbXxKnLV025l65FGcW/ko= Message-ID: Date: Sat, 18 Jun 2022 18:57:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room Content-Language: en-US To: Eli Zaretskii References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> <83r13mo50s.fsf@gnu.org> From: Richard Hansen In-Reply-To: <83r13mo50s.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------M00DSVwR8j3fvy5Aict0CzKk" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56048 Cc: 56048@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------M00DSVwR8j3fvy5Aict0CzKk Content-Type: multipart/mixed; boundary="------------Zsy9faO80hZH5fZ8jtUWxHlm"; protected-headers="v1" From: Richard Hansen To: Eli Zaretskii Cc: 56048@debbugs.gnu.org, monnier@iro.umontreal.ca Message-ID: Subject: Re: bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> <83r13mo50s.fsf@gnu.org> In-Reply-To: <83r13mo50s.fsf@gnu.org> --------------Zsy9faO80hZH5fZ8jtUWxHlm Content-Type: multipart/mixed; boundary="------------3Rq713V8eY8cyFk6syS0jHGt" --------------3Rq713V8eY8cyFk6syS0jHGt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAyMi0wNi0xOCAwMjozMiwgRWxpIFphcmV0c2tpaSB3cm90ZToNCj4+IFN1YmplY3Q6 IFtQQVRDSCB2MiAxLzJdIDsgYmluZGF0IChzdHJ6KTogTW92ZSBhbGwgcGFjayBsb2dpYyB0 byBwYWNrIGZ1bmN0aW9uDQo+IA0KPiBXaGF0IGlzIHRoZSBtb3RpdmF0aW9uL3JhdGlvbmFs ZSBmb3IgdGhpcyByZWZhY3RvcmluZz8NCg0KVGhlIGF0dGFjaGVkIHJldmlzaW9uIHVwZGF0 ZXMgdGhlIGNvbW1pdCBtZXNzYWdlIHRvIGV4cGxhaW46DQoNCiAgICAgOyBiaW5kYXQgKHN0 cnopOiBNb3ZlIGFsbCBwYWNrIGxvZ2ljIHRvIHBhY2sgZnVuY3Rpb24NCg0KICAgICBNb3Rp dmF0aW9uL3JhdGlvbmFsZToNCiAgICAgICAqIEltcHJvdmUgY29kZSByZWFkYWJpbGl0eS4g IE5vdyBgYmluZGF0LS1wYWNrLXN0cnpgIGlzIHVzZWQgZm9yIGFsbA0KICAgICAgICAgYHN0 cnpgIHBhY2tpbmcsIG5vdCBqdXN0IHZhcmlhYmxlLWxlbmd0aCBgc3RyemAgcGFja2luZy4N CiAgICAgICAqIE1ha2UgaXQgZWFzaWVyIHRvIGNoYW5nZSB0aGUgYmVoYXZpb3Igb2YgZml4 ZWQtbGVuZ3RoIGBzdHJ6YA0KICAgICAgICAgcGFja2luZyB3aXRob3V0IGFsc28gYWZmZWN0 aW5nIHRoZSBiZWhhdmlvciBvZiBgc3RyYCBwYWNraW5nLiAgKEENCiAgICAgICAgIGZ1dHVy ZSBjb21taXQgd2lsbCBtb2RpZnkgYHN0cnpgIHRvIHdyaXRlIGEgbnVsbCB0ZXJtaW5hdG9y IGlmDQogICAgICAgICB0aGVyZSBpcyByb29tLikNCg0KPiANCj4+ICtXaGVuIHBhY2tpbmcs IGEgbnVsbCB0ZXJtaW5hdG9yIGlzIHdyaXR0ZW4gYWZ0ZXIgdGhlIHBhY2tlZCBzdHJpbmcg aWYNCj4+ICt0aGUgbGVuZ3RoIG9mIHRoZSBpbnB1dCBzdHJpbmcgaXMgbGVzcyB0aGFuIEB2 YXJ7bGVufS4NCj4gDQo+IFNpbmNlICJsZW5ndGggb2YgYSBzdHJpbmciIGlzIGhpZ2hseSBh bWJpZ3VvdXMgaW4gRW1hY3MsIHBsZWFzZSBhbHdheXMNCj4gbWFrZSBhIHBvaW50IG9mIHNh eWluZyAiQHZhcntsZW59IGJ5dGVzIiBleHBsaWNpdGx5LiAgQnl0ZSBsZW5ndGggaXMNCj4g c29tZXRoaW5nIHJhcmVseSBzZWVuIG9yIHVzZWQgaW4gRW1hY3MsIHNvIHBlb3BsZSBtdXN0 IGJlIGluZm9ybWVkDQo+IGFib3V0IHRoYXQgZWFjaCB0aW1lLg0KDQpEb25lOyBzZWUgYXR0 YWNoZWQgcmV2aXNpb24uDQoNClRoYW5rcywNClJpY2hhcmQNCg== --------------3Rq713V8eY8cyFk6syS0jHGt Content-Type: text/x-patch; charset=UTF-8; name="v3-0001-bindat-strz-Move-all-pack-logic-to-pack-function.patch" Content-Disposition: attachment; filename*0="v3-0001-bindat-strz-Move-all-pack-logic-to-pack-function.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSBjYmQxMzg2NzFjMzcxZTk5MTlhMmVkMzQ1ZDM1NzlhOGExNjNhYmM4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCAyOSBNYXkgMjAyMiAyMToyMzo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggdjMgMS8yXSA7IGJpbmRhdCAoc3Ryeik6IE1vdmUgYWxsIHBhY2sgbG9naWMgdG8g cGFjayBmdW5jdGlvbgoKTW90aXZhdGlvbi9yYXRpb25hbGU6CiAgKiBJbXByb3ZlIGNvZGUg cmVhZGFiaWxpdHkuICBOb3cgYGJpbmRhdC0tcGFjay1zdHJ6YCBpcyB1c2VkIGZvciBhbGwK ICAgIGBzdHJ6YCBwYWNraW5nLCBub3QganVzdCB2YXJpYWJsZS1sZW5ndGggYHN0cnpgIHBh Y2tpbmcuCiAgKiBNYWtlIGl0IGVhc2llciB0byBjaGFuZ2UgdGhlIGJlaGF2aW9yIG9mIGZp eGVkLWxlbmd0aCBgc3RyemAKICAgIHBhY2tpbmcgd2l0aG91dCBhbHNvIGFmZmVjdGluZyB0 aGUgYmVoYXZpb3Igb2YgYHN0cmAgcGFja2luZy4gIChBCiAgICBmdXR1cmUgY29tbWl0IHdp bGwgbW9kaWZ5IGBzdHJ6YCB0byB3cml0ZSBhIG51bGwgdGVybWluYXRvciBpZgogICAgdGhl cmUgaXMgcm9vbS4pCi0tLQogbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCB8IDQ5ICsrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIz IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQuZWwgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCmluZGV4IDQ2 ZTJhNDkwMWMuLjRhNjQyYmI5YzUgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9iaW5k YXQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbApAQCAtNDQwLDIwICs0NDAs MjcgQEAgYmluZGF0LS1wYWNrLXN0cgogICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5k YXQtaWR4IGkpIChhcmVmIHYgaSkpKQogICAgIChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0 LWlkeCBsZW4pKSkpCiAKLShkZWZ1biBiaW5kYXQtLXBhY2stc3RyeiAodikKKyhkZWZ1biBi aW5kYXQtLXBhY2stc3RyeiAobGVuIHYpCiAgIChsZXQqICgodiAoc3RyaW5nLXRvLXVuaWJ5 dGUgdikpCi0gICAgICAgICAobGVuIChsZW5ndGggdikpKQotICAgIChkb3RpbWVzIChpIGxl bikKLSAgICAgICh3aGVuICg9IChhcmVmIHYgaSkgMCkKLSAgICAgICAgOzsgQWx0ZXJuYXRp dmVseSB3ZSBjb3VsZCBwcmV0ZW5kIHRoYXQgdGhpcyB3YXMgdGhlIGVuZCBvZgotICAgICAg ICA7OyB0aGUgc3RyaW5nIGFuZCBzdG9wIHBhY2tpbmcsIGJ1dCB0aGVuIGJpbmRhdC1sZW5n dGggd291bGQKLSAgICAgICAgOzsgbmVlZCB0byBzY2FuIHRoZSBpbnB1dCBzdHJpbmcgbG9v a2luZyBmb3IgYSBudWxsIGJ5dGUuCi0gICAgICAgIChlcnJvciAiTnVsbCBieXRlIGVuY291 bnRlcmVkIGluIGlucHV0IHN0cnogc3RyaW5nIikpCi0gICAgICAoYXNldCBiaW5kYXQtcmF3 ICgrIGJpbmRhdC1pZHggaSkgKGFyZWYgdiBpKSkpCi0gICAgOzsgRXhwbGljaXRseSB3cml0 ZSBhIG51bGwgdGVybWluYXRvciBpbiBjYXNlIHRoZSB1c2VyIHByb3ZpZGVkIGEKLSAgICA7 OyBwcmUtYWxsb2NhdGVkIHN0cmluZyB0byBiaW5kYXQtcGFjayB0aGF0IHdhc24ndCB6ZXJv ZWQgZmlyc3QuCi0gICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5kYXQtaWR4IGxlbikgMCkK LSAgICAoc2V0cSBiaW5kYXQtaWR4ICgrIGJpbmRhdC1pZHggbGVuIDEpKSkpCisgICAgICAg ICAodmxlbiAobGVuZ3RoIHYpKSkKKyAgICAoaWYgbGVuCisgICAgICAgIDs7IFdoZW4gbGVu IGlzIHNwZWNpZmllZCwgYmVoYXZlIHRoZSBzYW1lIGFzIHRoZSBzdHIgdHlwZQorICAgICAg ICA7OyBzaW5jZSB3ZSBkb24ndCBhY3R1YWxseSBhZGQgdGhlIHRlcm1pbmF0aW5nIHplcm8g YW55d2F5CisgICAgICAgIDs7IChiZWNhdXNlIHdlIHJlbHkgb24gdGhlIGZhY3QgdGhhdCBg YmluZGF0LXJhdycgd2FzCisgICAgICAgIDs7IHByZXN1bWFibHkgaW5pdGlhbGl6ZWQgd2l0 aCBhbGwtemVyb2VzIGJlZm9yZSB3ZSBzdGFydGVkKS4KKyAgICAgICAgKGJpbmRhdC0tcGFj ay1zdHIgbGVuIHYpCisgICAgICAoZG90aW1lcyAoaSB2bGVuKQorICAgICAgICAod2hlbiAo PSAoYXJlZiB2IGkpIDApCisgICAgICAgICAgOzsgQWx0ZXJuYXRpdmVseSB3ZSBjb3VsZCBw cmV0ZW5kIHRoYXQgdGhpcyB3YXMgdGhlIGVuZCBvZgorICAgICAgICAgIDs7IHRoZSBzdHJp bmcgYW5kIHN0b3AgcGFja2luZywgYnV0IHRoZW4gYmluZGF0LWxlbmd0aCB3b3VsZAorICAg ICAgICAgIDs7IG5lZWQgdG8gc2NhbiB0aGUgaW5wdXQgc3RyaW5nIGxvb2tpbmcgZm9yIGEg bnVsbCBieXRlLgorICAgICAgICAgIChlcnJvciAiTnVsbCBieXRlIGVuY291bnRlcmVkIGlu IGlucHV0IHN0cnogc3RyaW5nIikpCisgICAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmlu ZGF0LWlkeCBpKSAoYXJlZiB2IGkpKSkKKyAgICAgIDs7IEV4cGxpY2l0bHkgd3JpdGUgYSBu dWxsIHRlcm1pbmF0b3IgaW4gY2FzZSB0aGUgdXNlciBwcm92aWRlZAorICAgICAgOzsgYSBw cmUtYWxsb2NhdGVkIHN0cmluZyB0byBgYmluZGF0LXBhY2snIHRoYXQgd2Fzbid0IGFscmVh ZHkKKyAgICAgIDs7IHplcm9lZC4KKyAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmluZGF0 LWlkeCB2bGVuKSAwKQorICAgICAgKHNldHEgYmluZGF0LWlkeCAoKyBiaW5kYXQtaWR4IHZs ZW4gMSkpKSkpCiAKIChkZWZ1biBiaW5kYXQtLXBhY2stYml0cyAobGVuIHYpCiAgIChsZXQg KChibnVtICgxLSAoKiA4IGxlbikpKSBqIG0pCkBAIC00ODIsNyArNDg5LDggQEAgYmluZGF0 LS1wYWNrLWl0ZW0KICAgICgndTI0ciAoYmluZGF0LS1wYWNrLXUyNHIgdikpCiAgICAoJ3Uz MnIgKGJpbmRhdC0tcGFjay11MzJyIHYpKQogICAgKCdiaXRzIChiaW5kYXQtLXBhY2stYml0 cyBsZW4gdikpCi0gICAoKG9yICdzdHIgJ3N0cnopIChiaW5kYXQtLXBhY2stc3RyIGxlbiB2 KSkKKyAgICgnc3RyIChiaW5kYXQtLXBhY2stc3RyIGxlbiB2KSkKKyAgICgnc3RyeiAoYmlu ZGF0LS1wYWNrLXN0cnogbGVuIHYpKQogICAgKCd2ZWMKICAgICAobGV0ICgobCAobGVuZ3Ro IHYpKSAodmxlbiAxKSkKICAgICAgIChpZiAoY29uc3AgdmVjdHlwZSkKQEAgLTY5OSwxOCAr NzA3LDcgQEAgYmluZGF0LS10eXBlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChu dW1iZXJwIGxlbikgbGVuKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IEdlbmVy YWwgZXhwcmVzc2lvbiBzdXBwb3J0LgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0 IGAob3IgLGxlbiAoMSsgKGxlbmd0aCAsdmFsKSkpKSkpKQotICAgIChgKHBhY2sgLiAsYXJn cykKLSAgICAgOzsgV2hlbiBsZW4gaXMgc3BlY2lmaWVkLCBiZWhhdmUgdGhlIHNhbWUgYXMg dGhlIHN0ciB0eXBlIHNpbmNlIHdlIGRvbid0Ci0gICAgIDs7IGFjdHVhbGx5IGFkZCB0aGUg dGVybWluYXRpbmcgemVybyBhbnl3YXkgKGJlY2F1c2Ugd2UgcmVseSBvbiB0aGUgZmFjdAot ICAgICA7OyB0aGF0IGBiaW5kYXQtcmF3JyB3YXMgcHJlc3VtYWJseSBpbml0aWFsaXplZCB3 aXRoIGFsbC16ZXJvZXMgYmVmb3JlIHdlCi0gICAgIDs7IHN0YXJ0ZWQpLgotICAgICAoY29u ZCA7IFNhbWUgb3B0aW1pemF0aW9ucyBhcyAnbGVuZ3RoIGFib3ZlLgotICAgICAgKChudWxs IGxlbikgYChiaW5kYXQtLXBhY2stc3RyeiAuICxhcmdzKSkKLSAgICAgICgobnVtYmVycCBs ZW4pIGAoYmluZGF0LS1wYWNrLXN0ciAsbGVuIC4gLGFyZ3MpKQotICAgICAgKHQgKG1hY3Jv ZXhwLWxldDIgbmlsIGxlbiBsZW4KLSAgICAgICAgICAgYChpZiAsbGVuCi0gICAgICAgICAg ICAgICAgKGJpbmRhdC0tcGFjay1zdHIgLGxlbiAuICxhcmdzKQotICAgICAgICAgICAgICAo YmluZGF0LS1wYWNrLXN0cnogLiAsYXJncykpKSkpKSkpCisgICAgKGAocGFjayAuICxhcmdz KSBgKGJpbmRhdC0tcGFjay1zdHJ6ICxsZW4gLiAsYXJncykpKSkKIAogKGNsLWRlZm1ldGhv ZCBiaW5kYXQtLXR5cGUgKG9wIChfIChlcWwgJ2JpdHMpKSAgbGVuKQogICAoYmluZGF0LS1w Y2FzZSBvcAotLSAKMi4zNi4xCgo= --------------3Rq713V8eY8cyFk6syS0jHGt Content-Type: text/x-patch; charset=UTF-8; name="v3-0002-bindat-strz-Null-terminate-fixed-length-strings-i.patch" Content-Disposition: attachment; filename*0="v3-0002-bindat-strz-Null-terminate-fixed-length-strings-i.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBjZjY1YjU2ZTUzN2ZiN2JhYjJiODc3NmRmYTg3NmZhNTZmMTgzOWJjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAxNiBKdW4gMjAyMiAxNToyMTo1NyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggdjMgMi8yXSBiaW5kYXQgKHN0cnopOiBOdWxsIHRlcm1pbmF0ZSBmaXhlZC1sZW5n dGggc3RyaW5ncyBpZgogdGhlcmUgaXMgcm9vbQoKKiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0 LmVsIChiaW5kYXQtLXBhY2stc3Ryeik6IEZvciBmaXhlZC1sZW5ndGggc3RyegpmaWVsZHMs IGV4cGxpY2l0bHkgd3JpdGUgYSBudWxsIHRlcm1pbmF0b3IgYWZ0ZXIgdGhlIHBhY2tlZCBz dHJpbmcgaWYKdGhlcmUgaXMgcm9vbSAoYnVnIzU2MDQ4KS4KKiBkb2MvbGlzcHJlZi9wcm9j ZXNzZXMudGV4aSAoQmluZGF0IFR5cGVzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uCiogdGVz dC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChiaW5kYXQtdGVzdC0tc3RyLXN0 cnotcHJlYWxsb2MpOgpVcGRhdGUgdGVzdHMuCi0tLQogZG9jL2xpc3ByZWYvcHJvY2Vzc2Vz LnRleGkgICAgICAgICAgIHwgMzEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQogbGlz cC9lbWFjcy1saXNwL2JpbmRhdC5lbCAgICAgICAgICAgIHwgMTMgKysrKysrLS0tLS0tCiB0 ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgfCAxMiArKysrKy0tLS0tLQog MyBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSBiL2RvYy9saXNwcmVmL3By b2Nlc3Nlcy50ZXhpCmluZGV4IGI5MjAwYWVkZGUuLjllMGJkOThhNTQgMTAwNjQ0Ci0tLSBh L2RvYy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL3Byb2Nlc3Nl cy50ZXhpCkBAIC0zNTA5LDIzICszNTA5LDI0IEBAIEJpbmRhdCBUeXBlcwogKGJ1dCBleGNs dWRpbmcpIHRoZSBudWxsIGJ5dGUgdGhhdCB0ZXJtaW5hdGVkIHRoZSBpbnB1dCBzdHJpbmcu CiAKIElmIEB2YXJ7bGVufSBpcyBwcm92aWRlZCwgQGNvZGV7c3Ryen0gYmVoYXZlcyB0aGUg c2FtZSBhcyBAY29kZXtzdHJ9LAotYnV0IHdpdGggb25lIGRpZmZlcmVuY2U6IHdoZW4gdW5w YWNraW5nLCB0aGUgZmlyc3QgbnVsbCBieXRlCi1lbmNvdW50ZXJlZCBpbiB0aGUgcGFja2Vk IHN0cmluZyBpcyBpbnRlcnByZXRlZCBhcyB0aGUgdGVybWluYXRpbmcKLWJ5dGUsIGFuZCBp dCBhbmQgYWxsIHN1YnNlcXVlbnQgYnl0ZXMgYXJlIGV4Y2x1ZGVkIGZyb20gdGhlIHJlc3Vs dCBvZgotdGhlIHVucGFja2luZy4KK2J1dCB3aXRoIGEgY291cGxlIG9mIGRpZmZlcmVuY2Vz OgorCitAaXRlbWl6ZSBAYnVsbGV0CitAaXRlbQorV2hlbiBwYWNraW5nLCBhIG51bGwgdGVy bWluYXRvciBpcyB3cml0dGVuIGFmdGVyIHRoZSBwYWNrZWQgaW5wdXQKK3N0cmluZyBpZiB0 aGUgbnVtYmVyIG9mIGNoYXJhY3RlcnMgaW4gdGhlIGlucHV0IHN0cmluZyBpcyBsZXNzIHRo YW4KK0B2YXJ7bGVufS4KKworQGl0ZW0KK1doZW4gdW5wYWNraW5nLCB0aGUgZmlyc3QgbnVs bCBieXRlIGVuY291bnRlcmVkIGluIHRoZSBwYWNrZWQgc3RyaW5nCitpcyBpbnRlcnByZXRl ZCBhcyB0aGUgdGVybWluYXRpbmcgYnl0ZSwgYW5kIGl0IGFuZCBhbGwgc3Vic2VxdWVudAor Ynl0ZXMgYXJlIGV4Y2x1ZGVkIGZyb20gdGhlIHJlc3VsdCBvZiB0aGUgdW5wYWNraW5nLgor QGVuZCBpdGVtaXplCiAKIEBxdW90YXRpb24gQ2F1dGlvbgotVGhlIHBhY2tlZCBvdXRwdXQg d2lsbCBub3QgYmUgbnVsbC10ZXJtaW5hdGVkIHVubGVzcyBvbmUgb2YgdGhlCi1mb2xsb3dp bmcgaXMgdHJ1ZToKLUBpdGVtaXplCi1AaXRlbQotVGhlIGlucHV0IHN0cmluZyBpcyBzaG9y dGVyIHRoYW4gQHZhcntsZW59IGJ5dGVzIGFuZCBlaXRoZXIgbm8gcHJlLWFsbG9jYXRlZAot c3RyaW5nIHdhcyBwcm92aWRlZCB0byBAY29kZXtiaW5kYXQtcGFja30gb3IgdGhlIGFwcHJv cHJpYXRlIGJ5dGUgaW4KLXRoZSBwcmUtYWxsb2NhdGVkIHN0cmluZyB3YXMgYWxyZWFkeSBu dWxsLgotQGl0ZW0KLVRoZSBpbnB1dCBzdHJpbmcgY29udGFpbnMgYSBudWxsIGJ5dGUgd2l0 aGluIHRoZSBmaXJzdCBAdmFye2xlbn0KLWJ5dGVzLgotQGVuZCBpdGVtaXplCitUaGUgcGFj a2VkIG91dHB1dCB3aWxsIG5vdCBiZSBudWxsLXRlcm1pbmF0ZWQgdW5sZXNzIHRoZSBpbnB1 dCBzdHJpbmcKK2lzIHNob3J0ZXIgdGhhbiBAdmFye2xlbn0gYnl0ZXMgb3IgaXQgY29udGFp bnMgYSBudWxsIGJ5dGUgd2l0aGluIHRoZQorZmlyc3QgQHZhcntsZW59IGJ5dGVzLgogQGVu ZCBxdW90YXRpb24KIAogQGl0ZW0gdmVjIEB2YXJ7bGVufSBbQHZhcnt0eXBlfV0KZGlmZiAt LWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgYi9saXNwL2VtYWNzLWxpc3AvYmlu ZGF0LmVsCmluZGV4IDRhNjQyYmI5YzUuLjBlY2FjM2Q1MmEgMTAwNjQ0Ci0tLSBhL2xpc3Av ZW1hY3MtbGlzcC9iaW5kYXQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbApA QCAtNDQzLDExICs0NDMsMTQgQEAgYmluZGF0LS1wYWNrLXN0cgogKGRlZnVuIGJpbmRhdC0t cGFjay1zdHJ6IChsZW4gdikKICAgKGxldCogKCh2IChzdHJpbmctdG8tdW5pYnl0ZSB2KSkK ICAgICAgICAgICh2bGVuIChsZW5ndGggdikpKQorICAgIDs7IEV4cGxpY2l0bHkgd3JpdGUg YSBudWxsIHRlcm1pbmF0b3IgKGlmIHRoZXJlJ3Mgcm9vbSkgaW4gY2FzZQorICAgIDs7IHRo ZSB1c2VyIHByb3ZpZGVkIGEgcHJlLWFsbG9jYXRlZCBzdHJpbmcgdG8gYGJpbmRhdC1wYWNr JyB0aGF0CisgICAgOzsgd2Fzbid0IGFscmVhZHkgemVyb2VkLgorICAgICh3aGVuIChvciAo bnVsbCBsZW4pICg8IHZsZW4gbGVuKSkKKyAgICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmlu ZGF0LWlkeCB2bGVuKSAwKSkKICAgICAoaWYgbGVuCiAgICAgICAgIDs7IFdoZW4gbGVuIGlz IHNwZWNpZmllZCwgYmVoYXZlIHRoZSBzYW1lIGFzIHRoZSBzdHIgdHlwZQotICAgICAgICA7 OyBzaW5jZSB3ZSBkb24ndCBhY3R1YWxseSBhZGQgdGhlIHRlcm1pbmF0aW5nIHplcm8gYW55 d2F5Ci0gICAgICAgIDs7IChiZWNhdXNlIHdlIHJlbHkgb24gdGhlIGZhY3QgdGhhdCBgYmlu ZGF0LXJhdycgd2FzCi0gICAgICAgIDs7IHByZXN1bWFibHkgaW5pdGlhbGl6ZWQgd2l0aCBh bGwtemVyb2VzIGJlZm9yZSB3ZSBzdGFydGVkKS4KKyAgICAgICAgOzsgKGV4Y2VwdCBmb3Ig dGhlIG51bGwgdGVybWluYXRvciBwb3NzaWJseSB3cml0dGVuIGFib3ZlKS4KICAgICAgICAg KGJpbmRhdC0tcGFjay1zdHIgbGVuIHYpCiAgICAgICAoZG90aW1lcyAoaSB2bGVuKQogICAg ICAgICAod2hlbiAoPSAoYXJlZiB2IGkpIDApCkBAIC00NTYsMTAgKzQ1OSw2IEBAIGJpbmRh dC0tcGFjay1zdHJ6CiAgICAgICAgICAgOzsgbmVlZCB0byBzY2FuIHRoZSBpbnB1dCBzdHJp bmcgbG9va2luZyBmb3IgYSBudWxsIGJ5dGUuCiAgICAgICAgICAgKGVycm9yICJOdWxsIGJ5 dGUgZW5jb3VudGVyZWQgaW4gaW5wdXQgc3RyeiBzdHJpbmciKSkKICAgICAgICAgKGFzZXQg YmluZGF0LXJhdyAoKyBiaW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQotICAgICAgOzsgRXhw bGljaXRseSB3cml0ZSBhIG51bGwgdGVybWluYXRvciBpbiBjYXNlIHRoZSB1c2VyIHByb3Zp ZGVkCi0gICAgICA7OyBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nIHRvIGBiaW5kYXQtcGFjaycg dGhhdCB3YXNuJ3QgYWxyZWFkeQotICAgICAgOzsgemVyb2VkLgotICAgICAgKGFzZXQgYmlu ZGF0LXJhdyAoKyBiaW5kYXQtaWR4IHZsZW4pIDApCiAgICAgICAoc2V0cSBiaW5kYXQtaWR4 ICgrIGJpbmRhdC1pZHggdmxlbiAxKSkpKSkKIAogKGRlZnVuIGJpbmRhdC0tcGFjay1iaXRz IChsZW4gdikKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0 cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbAppbmRleCBjYzIy M2FkMTRlLi4wYzAzYzUxZTJlIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9i aW5kYXQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3Rz LmVsCkBAIC0xNzIsMTQgKzE3MiwxNCBAQCBiaW5kYXQtdGVzdC0tc3RyLXN0cnotcHJlYWxs b2MKICAgICAgICAgICAgICAgICAoKCgoeCBzdHIgMikpICgoeCAuICJhIikpKSAuICJheCIp CiAgICAgICAgICAgICAgICAgKCgoKHggc3RyIDIpKSAoKHggLiAiYWIiKSkpIC4gImFiIikK ICAgICAgICAgICAgICAgICAoKCgoeCBzdHIgMikpICgoeCAuICJhYmMiKSkpIC4gImFiIikK LSAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAxKSAiIikgLiAieHgiKQot ICAgICAgICAgICAgICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6IDIpICIiKSAuICJ4eCIpCi0g ICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnogMikgImEiKSAuICJheCIpCisg ICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnogMSkgIiIpIC4gIlwweCIpCisg ICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnogMikgIiIpIC4gIlwweCIpCisg ICAgICAgICAgICAgICAgKCgsKGJpbmRhdC10eXBlIHN0cnogMikgImEiKSAuICJhXDAiKQog ICAgICAgICAgICAgICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6IDIpICJhYiIpIC4gImFiIikK ICAgICAgICAgICAgICAgICAoKCwoYmluZGF0LXR5cGUgc3RyeiAyKSAiYWJjIikgLiAiYWIi KQotICAgICAgICAgICAgICAgICgoKCh4IHN0cnogMSkpICgoeCAuICIiKSkpIC4gInh4IikK LSAgICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDIpKSAoKHggLiAiIikpKSAuICJ4eCIpCi0g ICAgICAgICAgICAgICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImEiKSkpIC4gImF4IikKKyAg ICAgICAgICAgICAgICAoKCgoeCBzdHJ6IDEpKSAoKHggLiAiIikpKSAuICJcMHgiKQorICAg ICAgICAgICAgICAgICgoKCh4IHN0cnogMikpICgoeCAuICIiKSkpIC4gIlwweCIpCisgICAg ICAgICAgICAgICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImEiKSkpIC4gImFcMCIpCiAgICAg ICAgICAgICAgICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImFiIikpKSAuICJhYiIpCiAgICAg ICAgICAgICAgICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImFiYyIpKSkgLiAiYWIiKQogICAg ICAgICAgICAgICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6KSAiIikgLiAiXDB4IikKLS0gCjIu MzYuMQoK --------------3Rq713V8eY8cyFk6syS0jHGt-- --------------Zsy9faO80hZH5fZ8jtUWxHlm-- --------------M00DSVwR8j3fvy5Aict0CzKk Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKuWFQACgkQ0GvrRa1X 4hSuNQ//biH8fT0B6zrjkBFSs/mGz1ibyvOkbwD6sEbmO08LF6Rj/fpJrnzVKlzn 5g0HzGPAuKx+ZwvsvLVqHS2r4ErcXbMffZTNo3cC3xzeERnR8FsQnXc7pUj5iKGj koZKDXPX6gogkUWdyWekTP+zuCRQ1239hQA80KQq3QfdfWm+UmvI1Pz1/MSQeI1w 0THAZ8hFHTxwwINj4KYmHKZKGI58fubLYguHrQwvDFM2Ji/nhhhy7ct3Nvv6I1jb Z7wL8xB34pR9Q9/xmV6Wpmc9UHdmEx32h/eV+46q+2i94Bbm4Bp/qcIsw17Qsc70 liVakrOij2e8eTb3uiMiP7bGbzSCHQXn97bGDwLvyH2NxJQ+70VtqtfqKSVASwkS qezwlRFoPZsYGDv2avJ5fywwJ3+yygpWq/egEYm2b+GCi6o+DKkKltKd7U+/Tbue VKjhe4hsasrqcL+/rIi046zeP7ArQ0QMrbPeV8pSfFiqRnqDP3WzLahV7ZePeAk2 V37K0vXBYfTF0XAZKqIjhmdKWH6+AKx2LSpmM1TIaAztE2u/dVctxxtURQVR4LyA G58nlveTRNKQnkceVcGfLZ5D4gk7br7LNNk6N20izFFCBnFJ6zWW/9u4srWfu8VP tFM4Nfl4E8g8F5RVTqboi167VtH4YgdLThXsnOCXvdPKihjwIA4= =PF3P -----END PGP SIGNATURE----- --------------M00DSVwR8j3fvy5Aict0CzKk-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 09:53:22 2022 Received: (at control) by debbugs.gnu.org; 19 Jun 2022 13:53:22 +0000 Received: from localhost ([127.0.0.1]:50972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2vMg-00004q-8m for submit@debbugs.gnu.org; Sun, 19 Jun 2022 09:53:22 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:41527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2vMd-0008W1-DI for control@debbugs.gnu.org; Sun, 19 Jun 2022 09:53:19 -0400 Received: by mail-pf1-f175.google.com with SMTP id i64so8070082pfc.8 for ; Sun, 19 Jun 2022 06:53:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=ATRHveBwUe70sb7+JwRQffYyZswaX8gDHjBt72Sc3j8=; b=nk+BPxOX3QB2etbGZBP1HptQRiQNxmALvNlMV3gL67LVvlz5wr3XWig6Fi6lLYhGK+ K3ozW99CGHihDghoautCVZWXlHHdBXRrsu5MC7RxoamoyFfr0ORCFxdQAHwVkD9TEQGJ 93d0cuN9yjxu3OrxwxOqOHrILod+2NP81OmQ4/1jk5e68vyQ7yKUIrx5nI6CNCwJGxoi w340CfNjbFEHgKDnxp1Fj/XnKyyD/Hd4IiAfw16UUm2Clpw+kFSUfbcvy9iPgOIFIyFz IezTxKbWhngEQilf2B3WwOGqdWhzFzKsbzcBtjCZ69JmAO66n0ONVZISQiMN9fIl7CiX e1/g== X-Gm-Message-State: AJIora/s7Utq9z9FonY8i/aoFfLiLG+GJd2K/tG3gCaiKPLs/3o+xZex vrsX8+5CWi6S7SUN9VC9jj5MBtazl8J1gFVPtDWUrrPP X-Google-Smtp-Source: AGRyM1unGNZVU7Ycqx+FiJZxa1wgZOlbf8PnvmTSyW3r6dach8dJ4qOI4pB6Gl+reIlaYAZwe1J030cdB+RFxKsqMTs= X-Received: by 2002:a63:dd56:0:b0:405:34ac:9bc9 with SMTP id g22-20020a63dd56000000b0040534ac9bc9mr17615449pgj.324.1655646793584; Sun, 19 Jun 2022 06:53:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Jun 2022 06:53:13 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 19 Jun 2022 06:53:13 -0700 Message-ID: Subject: control message for bug #56048 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 56048 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 16:44:19 2022 Received: (at 56048) by debbugs.gnu.org; 21 Jun 2022 20:44:19 +0000 Received: from localhost ([127.0.0.1]:33435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3kjS-0004kS-UE for submit@debbugs.gnu.org; Tue, 21 Jun 2022 16:44:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3kjR-0004kD-9s for 56048@debbugs.gnu.org; Tue, 21 Jun 2022 16:44:17 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CAEAB441828; Tue, 21 Jun 2022 16:44:11 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F05A744181B; Tue, 21 Jun 2022 16:44:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655844248; bh=PAG5fK/1yHBnJhrL0j3h3+ivlYcbWIaX2DBddgHb2sQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aXRBvm0nKN2wNLwAt/pwSVRBKCR/2ELwphAZVUx976nuDBLoqyagCe6V9uW+OYSS4 1fP2roVJtxKytZIR3OcVseLE9fO20/DomZ1kPtsFbRWsFCiGT3KO0vK5A0aWqdfSs9 N+DNJdkMWdpHfEtROo/4vKHm4ukj8lHwoivyiGjphzjOatDirnXnb6O5SWsL+xJnVL 2Y1Hi/q7F2Sj+IPGbTiNFRBDwePqdJimpDqjmMIm3iLztg2zmzHLFE45cBRhZN/pd4 LMeeY33CuD7A8kLwHWZLgdl+zPb1/23CItR6dvMxF+CzwWNWpwZRdzenrxfiRe3BDD 1O27nR/pJTcpA== Received: from alfajor (unknown [80.82.234.185]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5D2DF120403; Tue, 21 Jun 2022 16:44:08 -0400 (EDT) From: Stefan Monnier To: Richard Hansen Subject: Re: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room Message-ID: References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> Date: Tue, 21 Jun 2022 16:44:06 -0400 In-Reply-To: (Richard Hansen's message of "Fri, 17 Jun 2022 23:02:57 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.238 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56048 Cc: 56048@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks, Richard. Looks good to me. Stefan Richard Hansen [2022-06-17 23:02:57] wrote: > Attached are new revisions of the patches. The only differences are the > comments were filled at column 70 instead of 80, and the commit message > mentions the bug number. > > From 6096bc8bceada87a5c54e4eb500812a0b72ffd44 Mon Sep 17 00:00:00 2001 > From: Richard Hansen > Date: Sun, 29 May 2022 21:23:57 -0400 > Subject: [PATCH v2 1/2] ; bindat (strz): Move all pack logic to pack function > > --- > lisp/emacs-lisp/bindat.el | 49 ++++++++++++++++++--------------------- > 1 file changed, 23 insertions(+), 26 deletions(-) > > diff --git a/lisp/emacs-lisp/bindat.el b/lisp/emacs-lisp/bindat.el > index 46e2a4901c..4a642bb9c5 100644 > --- a/lisp/emacs-lisp/bindat.el > +++ b/lisp/emacs-lisp/bindat.el > @@ -440,20 +440,27 @@ bindat--pack-str > (aset bindat-raw (+ bindat-idx i) (aref v i))) > (setq bindat-idx (+ bindat-idx len)))) > > -(defun bindat--pack-strz (v) > +(defun bindat--pack-strz (len v) > (let* ((v (string-to-unibyte v)) > - (len (length v))) > - (dotimes (i len) > - (when (= (aref v i) 0) > - ;; Alternatively we could pretend that this was the end of > - ;; the string and stop packing, but then bindat-length would > - ;; need to scan the input string looking for a null byte. > - (error "Null byte encountered in input strz string")) > - (aset bindat-raw (+ bindat-idx i) (aref v i))) > - ;; Explicitly write a null terminator in case the user provided a > - ;; pre-allocated string to bindat-pack that wasn't zeroed first. > - (aset bindat-raw (+ bindat-idx len) 0) > - (setq bindat-idx (+ bindat-idx len 1)))) > + (vlen (length v))) > + (if len > + ;; When len is specified, behave the same as the str type > + ;; since we don't actually add the terminating zero anyway > + ;; (because we rely on the fact that `bindat-raw' was > + ;; presumably initialized with all-zeroes before we started). > + (bindat--pack-str len v) > + (dotimes (i vlen) > + (when (= (aref v i) 0) > + ;; Alternatively we could pretend that this was the end of > + ;; the string and stop packing, but then bindat-length would > + ;; need to scan the input string looking for a null byte. > + (error "Null byte encountered in input strz string")) > + (aset bindat-raw (+ bindat-idx i) (aref v i))) > + ;; Explicitly write a null terminator in case the user provided > + ;; a pre-allocated string to `bindat-pack' that wasn't already > + ;; zeroed. > + (aset bindat-raw (+ bindat-idx vlen) 0) > + (setq bindat-idx (+ bindat-idx vlen 1))))) > > (defun bindat--pack-bits (len v) > (let ((bnum (1- (* 8 len))) j m) > @@ -482,7 +489,8 @@ bindat--pack-item > ('u24r (bindat--pack-u24r v)) > ('u32r (bindat--pack-u32r v)) > ('bits (bindat--pack-bits len v)) > - ((or 'str 'strz) (bindat--pack-str len v)) > + ('str (bindat--pack-str len v)) > + ('strz (bindat--pack-strz len v)) > ('vec > (let ((l (length v)) (vlen 1)) > (if (consp vectype) > @@ -699,18 +707,7 @@ bindat--type > ((numberp len) len) > ;; General expression support. > (t `(or ,len (1+ (length ,val))))))) > - (`(pack . ,args) > - ;; When len is specified, behave the same as the str type since we don't > - ;; actually add the terminating zero anyway (because we rely on the fact > - ;; that `bindat-raw' was presumably initialized with all-zeroes before we > - ;; started). > - (cond ; Same optimizations as 'length above. > - ((null len) `(bindat--pack-strz . ,args)) > - ((numberp len) `(bindat--pack-str ,len . ,args)) > - (t (macroexp-let2 nil len len > - `(if ,len > - (bindat--pack-str ,len . ,args) > - (bindat--pack-strz . ,args)))))))) > + (`(pack . ,args) `(bindat--pack-strz ,len . ,args)))) > > (cl-defmethod bindat--type (op (_ (eql 'bits)) len) > (bindat--pcase op > -- > 2.36.1 > > > From 9ebda68264adca6f60f780d44995c4213d2c12c2 Mon Sep 17 00:00:00 2001 > From: Richard Hansen > Date: Thu, 16 Jun 2022 15:21:57 -0400 > Subject: [PATCH v2 2/2] bindat (strz): Null terminate fixed-length strings if > there is room > > * lisp/emacs-lisp/bindat.el (bindat--pack-strz): For fixed-length strz > fields, explicitly write a null terminator after the packed string if > there is room (bug#56048). > * doc/lispref/processes.texi (Bindat Types): Update documentation. > * test/lisp/emacs-lisp/bindat-tests.el (bindat-test--str-strz-prealloc): > Update tests. > --- > doc/lispref/processes.texi | 30 ++++++++++++++-------------- > lisp/emacs-lisp/bindat.el | 13 ++++++------ > test/lisp/emacs-lisp/bindat-tests.el | 12 +++++------ > 3 files changed, 27 insertions(+), 28 deletions(-) > > diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi > index b9200aedde..d038d52d44 100644 > --- a/doc/lispref/processes.texi > +++ b/doc/lispref/processes.texi > @@ -3509,23 +3509,23 @@ Bindat Types > (but excluding) the null byte that terminated the input string. > > If @var{len} is provided, @code{strz} behaves the same as @code{str}, > -but with one difference: when unpacking, the first null byte > -encountered in the packed string is interpreted as the terminating > -byte, and it and all subsequent bytes are excluded from the result of > -the unpacking. > +but with a couple of differences: > + > +@itemize @bullet > +@item > +When packing, a null terminator is written after the packed string if > +the length of the input string is less than @var{len}. > + > +@item > +When unpacking, the first null byte encountered in the packed string > +is interpreted as the terminating byte, and it and all subsequent > +bytes are excluded from the result of the unpacking. > +@end itemize > > @quotation Caution > -The packed output will not be null-terminated unless one of the > -following is true: > -@itemize > -@item > -The input string is shorter than @var{len} bytes and either no pre-allocated > -string was provided to @code{bindat-pack} or the appropriate byte in > -the pre-allocated string was already null. > -@item > -The input string contains a null byte within the first @var{len} > -bytes. > -@end itemize > +The packed output will not be null-terminated unless the input string > +is shorter than @var{len} bytes or it contains a null byte within the > +first @var{len} bytes. > @end quotation > > @item vec @var{len} [@var{type}] > diff --git a/lisp/emacs-lisp/bindat.el b/lisp/emacs-lisp/bindat.el > index 4a642bb9c5..0ecac3d52a 100644 > --- a/lisp/emacs-lisp/bindat.el > +++ b/lisp/emacs-lisp/bindat.el > @@ -443,11 +443,14 @@ bindat--pack-str > (defun bindat--pack-strz (len v) > (let* ((v (string-to-unibyte v)) > (vlen (length v))) > + ;; Explicitly write a null terminator (if there's room) in case > + ;; the user provided a pre-allocated string to `bindat-pack' that > + ;; wasn't already zeroed. > + (when (or (null len) (< vlen len)) > + (aset bindat-raw (+ bindat-idx vlen) 0)) > (if len > ;; When len is specified, behave the same as the str type > - ;; since we don't actually add the terminating zero anyway > - ;; (because we rely on the fact that `bindat-raw' was > - ;; presumably initialized with all-zeroes before we started). > + ;; (except for the null terminator possibly written above). > (bindat--pack-str len v) > (dotimes (i vlen) > (when (= (aref v i) 0) > @@ -456,10 +459,6 @@ bindat--pack-strz > ;; need to scan the input string looking for a null byte. > (error "Null byte encountered in input strz string")) > (aset bindat-raw (+ bindat-idx i) (aref v i))) > - ;; Explicitly write a null terminator in case the user provided > - ;; a pre-allocated string to `bindat-pack' that wasn't already > - ;; zeroed. > - (aset bindat-raw (+ bindat-idx vlen) 0) > (setq bindat-idx (+ bindat-idx vlen 1))))) > > (defun bindat--pack-bits (len v) > diff --git a/test/lisp/emacs-lisp/bindat-tests.el b/test/lisp/emacs-lisp/bindat-tests.el > index cc223ad14e..0c03c51e2e 100644 > --- a/test/lisp/emacs-lisp/bindat-tests.el > +++ b/test/lisp/emacs-lisp/bindat-tests.el > @@ -172,14 +172,14 @@ bindat-test--str-strz-prealloc > ((((x str 2)) ((x . "a"))) . "ax") > ((((x str 2)) ((x . "ab"))) . "ab") > ((((x str 2)) ((x . "abc"))) . "ab") > - ((,(bindat-type strz 1) "") . "xx") > - ((,(bindat-type strz 2) "") . "xx") > - ((,(bindat-type strz 2) "a") . "ax") > + ((,(bindat-type strz 1) "") . "\0x") > + ((,(bindat-type strz 2) "") . "\0x") > + ((,(bindat-type strz 2) "a") . "a\0") > ((,(bindat-type strz 2) "ab") . "ab") > ((,(bindat-type strz 2) "abc") . "ab") > - ((((x strz 1)) ((x . ""))) . "xx") > - ((((x strz 2)) ((x . ""))) . "xx") > - ((((x strz 2)) ((x . "a"))) . "ax") > + ((((x strz 1)) ((x . ""))) . "\0x") > + ((((x strz 2)) ((x . ""))) . "\0x") > + ((((x strz 2)) ((x . "a"))) . "a\0") > ((((x strz 2)) ((x . "ab"))) . "ab") > ((((x strz 2)) ((x . "abc"))) . "ab") > ((,(bindat-type strz) "") . "\0x") From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 09:57:47 2022 Received: (at 56048-done) by debbugs.gnu.org; 22 Jun 2022 13:57:47 +0000 Received: from localhost ([127.0.0.1]:36172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o40rR-0001vt-8T for submit@debbugs.gnu.org; Wed, 22 Jun 2022 09:57:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o40rQ-0001vg-74 for 56048-done@debbugs.gnu.org; Wed, 22 Jun 2022 09:57:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o40rK-0000i2-6m; Wed, 22 Jun 2022 09:57:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZZGNyBKFXybg+RIEc4OkG6RrRJmqlnwwDW1tTqIT6xE=; b=ABl/tlTCawdq xPwc1AcBqkMNzsEABBg3mMoBW3mxPdiWPtaHB9C0Wwoa5hwBIJ+QVSxR7oU6vAc5O36BP1Ie90eVz nptThmSLy2fdFfIWYI53jB4dwFaOCpbPfu3ocWs+IZB41jC7De+QqnirFKm2kX3AiDSfW3tdLOo6V OlacA3BhYreT3d4pq7CsUNaHb2bsNYwiAzsucvEmhENz6EF7sUtZpIqAAqMtyauL+wYGAKxJ36UQK bG0UMJ2iJhV0WHhwgQtOpotDhPn84Z71zD75aQSiSkrlte57thIXRi64jCMLZu38ateOQSkkHbWSa +fPLYJ/hYGJH4OkPmivDcA==; Received: from [87.69.77.57] (port=3768 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o40rI-0005wu-Nj; Wed, 22 Jun 2022 09:57:29 -0400 Date: Wed, 22 Jun 2022 16:57:19 +0300 Message-Id: <835ykskdhc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room References: <8b471c36-abbe-819c-96d8-8f0d7b671afb@rhansen.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56048-done Cc: 56048-done@debbugs.gnu.org, rhansen@rhansen.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 56048@debbugs.gnu.org > Date: Tue, 21 Jun 2022 16:44:06 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Thanks, Richard. Looks good to me. Installed on master. From unknown Sun Aug 10 16:49:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Jul 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator