GNU bug report logs - #56043
[PATCH] gnu: grip: Update to 4.6.1 and use gexps.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
Subject: bug#56043: closed (Re: [bug#56043] [PATCH v2] gnu: grip: Update
 to 4.6.1 and use gexps.)
Date: Fri, 01 Jul 2022 08:49:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56043: [PATCH] gnu: grip: Update to 4.6.1 and use gexps.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56043 <at> debbugs.gnu.org.

-- 
56043: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56043
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
Cc: 56043-done <at> debbugs.gnu.org
Subject: Re: [bug#56043] [PATCH v2] gnu: grip: Update to 4.6.1 and use gexps.
Date: Fri, 01 Jul 2022 09:47:52 +0100

[Message part 3 (text/plain, inline)]

Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com> writes:

> * gnu/packages/python-web.scm (grip): Update to 4.6.1 and use gexps.
> ---
> I had forgot to add a copyright line in the previous version 😓.
>  gnu/packages/python-web.scm | 77 ++++++++++++++++++-------------------
>  1 file changed, 37 insertions(+), 40 deletions(-)

Thanks Luis, I've pushed this as b5c6062bcec9530a9c4044a1bd1091fdebf9bc74.

Chris

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
Subject: [PATCH] gnu: grip: Update to 4.6.1 and use gexps.
Date: Fri, 17 Jun 2022 17:33:34 -0300

* gnu/packages/python-web.scm (grip): Update to 4.6.1 and use gexps.
---
Hi guix,

this patch fixes the build of the grip package by updating it and also rewrites its arguments using gexps.

 gnu/packages/python-web.scm | 76 ++++++++++++++++++-------------------
 1 file changed, 36 insertions(+), 40 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b4500c6d2f..7b07cb72d6 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -5176,50 +5176,46 @@ (define-public python-path-and-address
     (license license:expat)))
 
 (define-public grip
-  ;; No release by upstream for quite some time, some bugs fixed since. See:
-  ;; https://github.com/joeyespo/grip/issues/304
-  (let ((commit "27a4d6d87ea1d0ea7f7f120de55baabee3de73e3"))
-    (package
-      (name "grip")
-      (version (git-version "4.5.2" "1" commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/joeyespo/grip")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "0kx5hgb3q19i4l18a4vqdq9af390xgpk88lp2ay75qi96k0dc68w"))))
-      (build-system python-build-system)
-      (propagated-inputs
-       (list python-docopt
-             python-flask
-             python-markdown
-             python-path-and-address
-             python-pygments
-             python-requests))
-      (native-inputs
-       (list python-pytest python-responses))
-      (arguments
-       `(#:phases
-         (modify-phases %standard-phases
-           (replace 'check
-             (lambda* (#:key inputs outputs #:allow-other-keys)
-               (add-installed-pythonpath inputs outputs)
-               (setenv "PATH" (string-append
-                                (getenv "PATH") ":"
-                                (assoc-ref %outputs "out") "/bin"))
-               (invoke "py.test" "-m" "not assumption"))))))
-      (home-page "https://github.com/joeyespo/grip")
-      (synopsis "Preview Markdown files using the GitHub API")
-      (description "Grip is a command-line server application written in Python
+  (package
+    (name "grip")
+    (version "4.6.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/joeyespo/grip")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0vhimd99zw7s1fihwr6yfij6ywahv9gdrfcf5qljvzh75mvzcwh8"))))
+    (build-system python-build-system)
+    (propagated-inputs (list python-docopt
+                             python-flask
+                             python-markdown
+                             python-path-and-address
+                             python-pygments
+                             python-requests))
+    (native-inputs (list python-pytest python-responses))
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (replace 'check
+                 (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+                   (when tests?
+                     (add-installed-pythonpath inputs outputs)
+                     (setenv "PATH"
+                             (string-append (getenv "PATH") ":"
+                                            #$output "/bin"))
+                     (invoke "py.test" "-m" "not assumption")))))))
+    (home-page "https://github.com/joeyespo/grip")
+    (synopsis "Preview Markdown files using the GitHub API")
+    (description
+     "Grip is a command-line server application written in Python
 that uses the GitHub Markdown API to render a local Markdown file.  The styles
 and rendering come directly from GitHub, so you'll know exactly how it will
 appear.  Changes you make to the file will be instantly reflected in the browser
 without requiring a page refresh.")
-      (license license:expat))))
+    (license license:expat)))
 
 (define-public python-port-for
   (package
-- 
2.36.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.