GNU bug report logs - #56041
[PATCH] gnu: Add vkmark.

Previous Next

Full log

Message #8 received at 56041 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Tomasz Jeneralczyk" <tj <at> schwi.pl>, <56041 <at> debbugs.gnu.org>
Subject: Re: [bug#56041] [PATCH] gnu: Add vkmark.
Date: Fri, 17 Jun 2022 20:10:15 +0100

Hi! :D This package seems good to me: passes all lints, builds, and
style looks okay.

On Fri Jun 17, 2022 at 4:24 PM BST, Tomasz Jeneralczyk wrote:
> +(define-public vkmark
> +  (let ((commit "d872846e2e7c47010c11227eb713d00ccfdd35c6")
> +        (revision "1"))

I think it's common to include an explanation of why tags aren't used :)

> +                (file-name (git-file-name name version))
> +                (uri (git-reference
> +                      (url "https://github.com/vkmark/vkmark")
> +                      (commit commit)))

Nitpick: file-name usually comes after uri in most of the packages I've
seen. Maybe run guix style, if you haven't already.

> +      (native-inputs (list pkg-config cmake))

Why include cmake? It seems to compile without it :)

> +      (synopsis "Benchmark for Vulkan")

Maybe expand this to "Extensible benchmarking suite for Vulkan" or
something? I'd say this synopsis is a bit too short.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.