GNU bug report logs - #56041
[PATCH] gnu: Add vkmark.

Previous Next

Package: guix-patches;

Reported by: Tomasz Jeneralczyk <tj <at> schwi.pl>

Date: Fri, 17 Jun 2022 16:09:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 56041 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Tomasz Jeneralczyk" <tj <at> schwi.pl>, <56041 <at> debbugs.gnu.org>
Subject: Re: [bug#56041] [PATCH v4] gnu: Add vkmark.
Date: Sun, 06 Nov 2022 09:40:14 +0000

Heya,

On Mon Jun 27, 2022 at 5:02 PM BST, Tomasz Jeneralczyk wrote:
> * gnu/packages/benchmark.scm (vkmark): Add variable.

"New variable.", not "Add variable."

> --- a/gnu/packages/benchmark.scm
> +++ b/gnu/packages/benchmark.scm

> @@ -645,3 +652,44 @@ (define-public sysbench

> +        (revision "1"))

Use ``(revision "0")'' for the first version currently in Guix.

> +      (inputs (list vulkan-loader
> +                    vulkan-headers
> +                    glm
> +                    assimp
> +                    libxcb
> +                    xcb-util-wm
> +                    wayland-protocols
> +                    wayland))

There should be a newline between ``inputs'' and ``(list ...)''.

> +      (home-page "https://github.com/vkmark/vkmark")

home-page goes before synopsis.

    -- (
This bug report was last modified 2 years and 137 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.