Subject: bug#56028: closed (Re: bug#56028: [PATCH] gnu: Add python-pydantic-cli.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 07 Jul 2022 21:13:02 +0000

Your bug report

#56028: [PATCH] gnu: Add python-pydantic-cli.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
56028: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56028
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#56028: [PATCH] gnu: Add python-pydantic-cli.
From: Maxim Cournoyer <[email-masked]>
To: jgart <[email-masked]>
Cc: [email-masked]
Date: Thu, 07 Jul 2022 17:12:02 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

jgart <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-pydantic-cli): New variable.
> ---
>  gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 63a3eb2a80..394c54a986 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -5018,6 +5018,30 @@ (define-public python-pydantic
>  errors when data is invalid.")
>      (license license:expat)))
>  
> +(define-public python-pydantic-cli
> +  (package
> +    (name "python-pydantic-cli")
> +    (version "4.3.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pydantic_cli" version))
> +        (sha256
> +          (base32 "1068zki5fvdm2lhqfqhjf325kmr8v5qiwadcl5b5dy84xzhs8hvf"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +      (list python-pydantic))
> +    (native-inputs
> +      (list python-black
> +            python-mypy
> +            python-pytest))
> +    (home-page "http://github.com/mpkocher/pydantic-cli")
> +    (synopsis "Turn Pydantic defined Data Models into CLI Tools")
> +    (description
> +"Turn @code{python-pydantic} defined data models into CLI Tools and
> +enable loading values from JSON files.")
> +    (license license:expat)))
> +
>  (define-public python-pydocstyle
>    (package
>      (name "python-pydocstyle")

I've reworked the description a bit and fixed the indentation via W-q in
Emacs, like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/python-xyz.scm
@@ -5112,23 +5112,23 @@ (define-public python-pydantic-cli
     (name "python-pydantic-cli")
     (version "4.3.0")
     (source
-      (origin
-        (method url-fetch)
-        (uri (pypi-uri "pydantic_cli" version))
-        (sha256
-          (base32 "1068zki5fvdm2lhqfqhjf325kmr8v5qiwadcl5b5dy84xzhs8hvf"))))
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pydantic_cli" version))
+       (sha256
+        (base32 "1068zki5fvdm2lhqfqhjf325kmr8v5qiwadcl5b5dy84xzhs8hvf"))))
     (build-system python-build-system)
     (propagated-inputs
-      (list python-pydantic))
+     (list python-pydantic))
     (native-inputs
-      (list python-black
-            python-mypy
-            python-pytest))
+     (list python-black
+           python-mypy
+           python-pytest))
     (home-page "http://github.com/mpkocher/pydantic-cli")
-    (synopsis "Turn Pydantic defined Data Models into CLI Tools")
+    (synopsis "Turn Pydantic defined data models into CLI tools")
     (description
-"Turn @code{python-pydantic} defined data models into CLI Tools and
-enable loading values from JSON files.")
+     "@code{python-pydantic} enables specifying @acronym{CLI, Command Line
+Interfaces} via data models provided in the JSON format.")
     (license license:expat)))
 
 (define-public python-pydocstyle
--8<---------------cut here---------------end--------------->8---

Upon building it, I noticed that there appear to be no tests run,
despite providing pytest as a native input.

So I've fetched from git instead (with a comment explaining why), and
saw: Ran 35 tests in 0.094s; good!

I've also adjusted the home page URL to use HTTPS instead of HTTP.

Pushed as 08efb331d0.

Thanks!

Maxim

Subject: [PATCH] gnu: Add python-pydantic-cli.
From: jgart <[email-masked]>
To: [email-masked]
Cc: jgart <[email-masked]>
Date: Thu, 16 Jun 2022 16:43:19 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pydantic-cli): New variable.
---
 gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 63a3eb2a80..394c54a986 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5018,6 +5018,30 @@ (define-public python-pydantic
 errors when data is invalid.")
     (license license:expat)))
 
+(define-public python-pydantic-cli
+  (package
+    (name "python-pydantic-cli")
+    (version "4.3.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pydantic_cli" version))
+        (sha256
+          (base32 "1068zki5fvdm2lhqfqhjf325kmr8v5qiwadcl5b5dy84xzhs8hvf"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      (list python-pydantic))
+    (native-inputs
+      (list python-black
+            python-mypy
+            python-pytest))
+    (home-page "http://github.com/mpkocher/pydantic-cli")
+    (synopsis "Turn Pydantic defined Data Models into CLI Tools")
+    (description
+"Turn @code{python-pydantic} defined data models into CLI Tools and
+enable loading values from JSON files.")
+    (license license:expat)))
+
 (define-public python-pydocstyle
   (package
     (name "python-pydocstyle")
-- 
2.36.1