GNU bug report logs - #5601
23.1; etags Scheme_functions past \0 terminator

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Fri, 19 Feb 2010 00:15:02 UTC

Severity: normal

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Francesco Potortì <pot <at> gnu.org>
Cc: Kevin Ryde <user42 <at> zip.com.au>, 5601 <at> debbugs.gnu.org
Subject: bug#5601: 23.1; etags Scheme_functions past \0 terminator
Date: Sat, 20 Feb 2010 09:12:26 -0500

> >In etags.c Scheme_functions, I think the loop
> >
> >    while (notinname (*bp))
> >      bp++;
> >
> >will take bp past the '\0' string terminator, because '\0' is a
> >notinname().
>
> Yes, it appears so.  This is a long-standing bug.  Thanks for spotting
> it.
>
> >(Another helper skip_notinname() to try to be clearer
> >than a double-negative loop :-)
>
> I don't think a helper function is granted here.  There is a single use
> of this construct in the file, and a lot of different constructs: we
> have not a helper function for each of them.

I've checked in the patch, without the helper function.  Thanks.
This bug report was last modified 15 years and 95 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.