GNU bug report logs - #56004
[PATCH] gnu: Add snafu.

Previous Next

Full log

Message #8 received at 56004 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 56004 <at> debbugs.gnu.org
Subject: Re: bug#56004: [PATCH] gnu: Add snafu.
Date: Thu, 07 Jul 2022 16:52:57 -0400

Hello,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/suckless.scm (snafu): New variable.
> ---
>  gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 5aa37657b9..e05ae022df 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -12,6 +12,7 @@
>  ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
>  ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
>  ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages compression)
> +  #:use-module (gnu packages crates-io)
>    #:use-module (gnu packages cups)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages fontutils)
> @@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages webkit)
>    #:use-module (gnu packages xorg)
> +  #:use-module (guix build-system cargo)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix download)
> @@ -189,6 +192,35 @@ (define-public slstatus
>  @end itemize")
>        (license license:isc))))
>  
> +(define-public snafu
> +  (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
> +        (revision "0"))
> +    (package
> +      (name "snafu")
> +      (version commit)

You'd need write a proper monotonically increasing version via
'git-version', as hinted in info '(guix) Version Numbers'.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/jsbmg/snafu")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
> +          (arguments
> +            `(#:cargo-inputs
> +              (("rust-chrono" ,rust-chrono-0.4))
> +              #:tests? #f)) ; There are no tests.
> +      (build-system cargo-build-system)
> +      (home-page "https://github.com/jsbmg/snafu")
> +      (synopsis "Status text for dwm window manager")

Fully capitalize DWM.

> +      (description
> +"@code{snafu} provides status text for dwm's builtin bar on Linux.  It

Remove "on Linux", extraneous information on GNU Guix.

> +shows battery status, battery capacity, current WIFI connection, and

The proper "acronym" capitalization is WiFi.

Could you send a revised patch?

Thanks,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.