From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 08:53:40 2022 Received: (at submit) by debbugs.gnu.org; 15 Jun 2022 12:53:40 +0000 Received: from localhost ([127.0.0.1]:36901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1SWh-0004Zf-Lb for submit@debbugs.gnu.org; Wed, 15 Jun 2022 08:53:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:33410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1STg-0004Ub-Mw for submit@debbugs.gnu.org; Wed, 15 Jun 2022 08:50:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1STg-0007Xq-FL for bug-coreutils@gnu.org; Wed, 15 Jun 2022 08:50:32 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:53015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1STc-0006S6-Me for bug-coreutils@gnu.org; Wed, 15 Jun 2022 08:50:32 -0400 Received: by mail-wm1-x32b.google.com with SMTP id q15so6254253wmj.2 for ; Wed, 15 Jun 2022 05:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=+I6Q9amhRmN8/QIa8f1QOy7inuGR48FR2gchTYs1t2A=; b=NjTDQG3TtICqzVaS/xg0AJp81Iygwmh2T4jJu4X56W4ye2/6Yw42f+Rmmwso4O2ICE XJhNRmg50JGZi1H9ffE4WHaKuIj+6b8UsobOY8iQ9A3by5JIsbIczbcSzsSsKBbRwGPA +y7UHqEUvkNvYDIe5q6JerIqaLxARMvzx/MVOOlrKWjsFHSD8RCpDYHQoV9n4+BZA0aC Pls7M42HNEy6Izo1kgPpcH4jxSFMlRZ3cKgoeAkKRr5IswmQ5XpCeMoM4K8gWiKKWQRh 8Z9dfx7phKUdZHZD0gjxn5lz6Ryi9926BZj6e+6aH4ousp+Rwm654GNcEt1LlejJcTmL it6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+I6Q9amhRmN8/QIa8f1QOy7inuGR48FR2gchTYs1t2A=; b=Owpow+HvYRDhfTJWpJB9kN2dopLDptlo5CXF8n7PanbUR+J5jZeKKgyKWaM8dWnihk 3zcv9GfVFyNX2IiVnP6pEeLtaj0qPNR47KyBhhhXTHxoc7ID4AC4KsdjGTVCaBPhX/fu IuyrJYL/+Gybe6HugOXK+juegid+abC2eBpktV5v+tV1w1ns3ohTBPYyoa4MxczK7eze DbWOddx1kKZrM3veW6zCsp/C3OwrF9dq3O2+F00sBuiNXqdNTw98woLASatmlOXiDxLg nAyXOfiyYmlRatSU9v7N5V6srji6POLJUOS7j9h6/TumBrpTHcxPFMz5wFVlxC64QtBl wakA== X-Gm-Message-State: AOAM531nAy5Vgyr8yxfOa3Gy7KdF33hdSQJMMof1JnahUGYYMC695y/W HHlkZrNLcdifTjAA4DIamTAwBZs2EeqUxrwfxvVmzjfXry0= X-Google-Smtp-Source: ABdhPJzvDuC8Jm9ZJ95Lz0M5pJ6ulSdL/Gxd5eaJpWWsbFaIQmC6szK1plEPXdTYNeRo6WtXYk1NCy1XLU7Jt4NqlyU= X-Received: by 2002:a05:600c:19d4:b0:39c:7ec6:c7cc with SMTP id u20-20020a05600c19d400b0039c7ec6c7ccmr9717370wmq.141.1655297426521; Wed, 15 Jun 2022 05:50:26 -0700 (PDT) MIME-Version: 1.0 From: Jan Scheer Date: Wed, 15 Jun 2022 14:50:15 +0200 Message-ID: Subject: [PATCH] tests: run overlay-headers.sh with inotify enabled To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary="0000000000001b039205e17bf78c" Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=jhscheer@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 15 Jun 2022 08:53:38 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000001b039205e17bf78c Content-Type: text/plain; charset="UTF-8" This test intends to check `tail` for: "redundant headers for overlapping inotify events while it was suspended". However, it then runs `tail ---dis` which disables inotify events. This test should either test both (`for mode in '' '---disable-inotify'; do`) like what the other tests do, or only run the test with inotify enabled `tail`. Since it looks like the intention here was the latter, removing the `fastpoll` option should suffice. --- tests/tail-2/overlay-headers.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/tail-2/overlay-headers.sh b/tests/tail-2/overlay-headers.sh index ddd7d6a49..1cf231a7c 100755 --- a/tests/tail-2/overlay-headers.sh +++ b/tests/tail-2/overlay-headers.sh @@ -37,9 +37,6 @@ wait4lines_ () [ "$(countlines_)" -ge "$elc" ] || { sleep $delay; return 1; } } -# Speedup the non inotify case -fastpoll='---dis -s.1 --max-unchanged-stats=1' - # Terminate any background tail process cleanup_() { kill $pid 2>/dev/null && wait $pid; @@ -52,7 +49,7 @@ echo start > file2 || framework_failure_ # Use this as a way to gracefully terminate tail env sleep 20 & sleep=$! -tail $fastpoll --pid=$sleep -f file1 file2 > out & pid=$! +tail --pid=$sleep -f file1 file2 > out & pid=$! kill -0 $pid || fail=1 -- 2.35.3 --0000000000001b039205e17bf78c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This test intends to check `tail` for:
"redundant = headers for overlapping inotify events while it was
suspended". How= ever, it then runs `tail ---dis` which disables
inotify events. This tes= t should either test both
(`for mode in '' '---disable-inoti= fy'; do`) like what the other
tests do, or only run the test with in= otify enabled `tail`.
Since it looks like the intention here was the lat= ter, removing
the `fastpoll` option should suffice.
---
=C2=A0test= s/tail-2/overlay-headers.sh | 5 +----
=C2=A01 file changed, 1 insertion(= +), 4 deletions(-)

diff --git a/tests/tail-2/overlay-headers.sh b/te= sts/tail-2/overlay-headers.sh
index ddd7d6a49..1cf231a7c 100755
--- a= /tests/tail-2/overlay-headers.sh
+++ b/tests/tail-2/overlay-headers.sh@@ -37,9 +37,6 @@ wait4lines_ ()
=C2=A0 =C2=A0[ "$(countlines_)&q= uot; -ge "$elc" ] || { sleep $delay; return 1; }
=C2=A0}
= =C2=A0
-# Speedup the non inotify case
-fastpoll=3D'---dis -s.1 -= -max-unchanged-stats=3D1'
-
=C2=A0# Terminate any background tail= process
=C2=A0cleanup_() {
=C2=A0 =C2=A0kill $pid 2>/dev/null &am= p;& wait $pid;
@@ -52,7 +49,7 @@ echo start > file2 || framework_= failure_
=C2=A0# Use this as a way to gracefully terminate tail
=C2= =A0env sleep 20 & sleep=3D$!
=C2=A0
-tail $fastpoll --pid=3D$slee= p -f file1 file2 > out & pid=3D$!
+tail --pid=3D$sleep -f file1 f= ile2 > out & pid=3D$!
=C2=A0
=C2=A0kill -0 $pid || fail=3D1=C2=A0
--
2.35.3
--0000000000001b039205e17bf78c--