GNU bug report logs - #55984
26.3; Doc string of `chmod' / `set-file-modes'

Previous Next

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55984 <at> debbugs.gnu.org, drew.adams <at> oracle.com
Subject: bug#55984: 26.3; Doc string of `chmod' / `set-file-modes'
Date: Wed, 15 Jun 2022 15:19:31 +0200

>>>>> On Wed, 15 Jun 2022 16:08:38 +0300, Eli Zaretskii <eliz <at> gnu.org> said:

    >> Cc: 55984 <at> debbugs.gnu.org
    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Date: Wed, 15 Jun 2022 11:03:32 +0200
    >> 
    >> Passive voice as well. How about the following for emacs-28
    >> 
    >> 
    >> diff --git a/src/fileio.c b/src/fileio.c
    >> index 7d392e0de7..a240216dea 100644
    >> --- a/src/fileio.c
    >> +++ b/src/fileio.c
    >> @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3,
    >> Only the 12 low bits of MODE are used.  If optional FLAG is `nofollow',
    >> do not follow FILENAME if it is a symbolic link.
    >> 
    >> -Interactively, mode bits are read by `read-file-modes', which accepts
    >> -symbolic notation, like the `chmod' command from GNU Coreutils.  */)
    >> +Interactively, prompts for FILENAME, and reads MODE with
    >> +`read-file-modes', which accepts symbolic notation, like the `chmod'
    >> +command from GNU Coreutils.  */)

    Eli> "prompt" and "read", please, to be consistent with our preferred
    Eli> style.

I said "prompts" because itʼs describing what it does, but OK, fixed.

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.