From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 13:28:07 2022 Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 17:28:07 +0000 Received: from localhost ([127.0.0.1]:35656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1AKl-00034F-5U for submit@debbugs.gnu.org; Tue, 14 Jun 2022 13:28:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:35656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1AKg-000342-K9 for submit@debbugs.gnu.org; Tue, 14 Jun 2022 13:28:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AKg-0007vK-Cq for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 13:28:02 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:35633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1AKe-0008Gj-OA for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 13:28:02 -0400 Received: by mail-pj1-x1041.google.com with SMTP id v17-20020a17090a899100b001ead067eaf9so832629pjn.0 for ; Tue, 14 Jun 2022 10:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=sNCwN32+qkSTTBG9MP8CPmLODmBWulKj1GivN09nTl4=; b=i62bGHjUJFcI7ldvItpU4HTtXWcFV5dIJV1S98H7mgTtj7aw7sRRDPF/8xL5PgQwI7 187AyaMAfD4lIcFO1vQ6lUxh9UOjUHxYbXRpI0gIoubcWQyytBO+qLhzF5iI84+lTtKh r+l9RV5I0cNOY+T6zxbtrKeaJp8hp1g8onKGiXph+7NeAcxMd78QhMiI1zXzekhafUpw O41o5jw8DtrVuwvtSPduKAOco0bpWvrJzHM06fhgSNyURTbMj3kx1tqtWwiaAifGBrJQ sGnAn+wufL5ZLaA69U6LbPraOo/5fzFsGH5od4I7/ayo/OGT0s4Xosoqr87MYhiBM8Iq 6R5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=sNCwN32+qkSTTBG9MP8CPmLODmBWulKj1GivN09nTl4=; b=436mU4j6IWLMXOjy7faFOOBIIEf2XluAit+AmD+hGTC/j6Svx9fyHt+6Hf0s0gm5bh kEsnqlv8j3aiiOd+o6oLXYbNfaC/JPupBPSdNUNmhUvzfbSlI3tyBeH0xMDIQLNLJ+Bo /OQVA7osChOZXpQbMa3vXS6E0aaW/buWY+S4QwdjyNb454hzloool03BjGBY1vxDVe8q uAt3puCcKcwWdroJMvTQ7HzaLCsO/UC1fXvDjh05YrXlmxj1DMcOTAwNkGVGBLyBt/L8 URGE5EJSJ4gJt5xT0JkVQ1xq/VYS99KpYmPxNDH1Sq4JkAstQqoML1OnmFJBESabBmA9 v35w== X-Gm-Message-State: AJIora/ebOyyAMOYLY+my3aO5uh3HbwISppgVSv27I6AOMPAsyyQbYmS 1fuqLsjDjBZg3cJXzG2XKXCvneYCbLo= X-Google-Smtp-Source: AGRyM1v652hdRWNRgl0V2uM2cJssKAmah9JGE6tSou4GUd2pBfzuxEu7eGG2NwFALteZC1aakKrLTw== X-Received: by 2002:a17:902:f541:b0:163:f64a:6127 with SMTP id h1-20020a170902f54100b00163f64a6127mr5344087plf.134.1655227678210; Tue, 14 Jun 2022 10:27:58 -0700 (PDT) Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id d190-20020a6368c7000000b003fd4bd3befesm8150248pgc.55.2022.06.14.10.27.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:27:57 -0700 (PDT) From: Visuwesh To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Tue, 14 Jun 2022 22:57:48 +0530 Message-ID: <87fsk72m0b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=visuweshm@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tags: patch repeat-mode echoes unset keys in the help message since it doesn't check for non-nil value of command bound to key; will attach patch once I get the bug number. In GNU Emacs 29.0.50 (build 16, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2022-06-14 built on astatine Repository revision: 9fb80aee176f6d5dc8fd33b63880b11a99a19657 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-modules --with-sound=alsa --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf --without-libsystemd --with-x --without-cairo' Configured features: ACL DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XFT XIM XINPUT2 XPM LUCID ZLIB From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 13:31:13 2022 Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 17:31:14 +0000 Received: from localhost ([127.0.0.1]:35662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ANl-0003An-MV for submit@debbugs.gnu.org; Tue, 14 Jun 2022 13:31:13 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:39728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ANi-0003AW-5b for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 13:31:12 -0400 Received: by mail-pj1-f65.google.com with SMTP id q12-20020a17090a304c00b001e2d4fb0eb4so12412795pjl.4 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 10:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=OTLQ1/G+Ve/3+R5aJh2F4f3gg1HfrhxwcInP6J++Nl4=; b=KJBzHxiw6QY+AFSvn9wB2WsS94HzGXo2MvDnSuqvgJyBIdIwghateE1YOAy1sZKUDC JRESmBU3ODgPGiKfh3nZXOzUrleH/aD/YiJFf/q1QysAWu20RR43+IDxtYwjoBGuNaVl r7F9y03ihjzfnfHjA6FWfoPJDgSPfTbaljBllzwG3ZQqaIsx3ZBYPtgqIaOKXslLxiW0 aUJAga2b8+ccY9mkunq0QRV+05M4I0z0bziRVqzPUONrt1BZ7pIlLqy88OZb4S9jB69q Te2czm3rg/EESmg1YUTkWgGcdASGsuYE0lx3TmB3IVVJ0qKhfuKIwJ+1SDjeHSV827WA ac7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=OTLQ1/G+Ve/3+R5aJh2F4f3gg1HfrhxwcInP6J++Nl4=; b=PqvfGGwVgsxC39lDFHn4i+6dAdHzA/7h/RgYIqYiQCgsoJjqE3dzeohKlCubldLOFw 209C9pWQvJUpMFikO0CWYNwkOA+f7exbFEleCs3m6PJEncC2tBhYAph7aBtiZ2qI51wr G+hZzChlIg77B01urfAiZDd+wgdG3/kdY8pNB6ZqkDA5Ynz6LyZJ4G1dSRsagD1khRoE K4qaFAXwiRh0GShRy9E1XamkD/Il+2s0VTUUCK/YqGrkKFoVzDhl5IqQioGYhyuhVegL kmUZyarFOm3BfOp0zv83kYrshxEXCnFQE46SDkGBNo9sY7b7chr1tUXcocSYaHFxYlCP YE1w== X-Gm-Message-State: AJIora9yKqOzCxjiCLBOkp14mjw45cxTSVy6zrN4f2IXLUXG0IYZLD1N Inc5rEyq9TrKQDVaveJ5fEZdu4DbZ90CwQ== X-Google-Smtp-Source: AGRyM1vA6IohXTmgUEFXj1ScGTIA4hl+K3ibc1n2JU9caUJTALU3Lw4sv4monUxDZVmAbeacvENnNA== X-Received: by 2002:a17:902:ee8d:b0:164:7dd:6cc6 with SMTP id a13-20020a170902ee8d00b0016407dd6cc6mr5865208pld.84.1655227862684; Tue, 14 Jun 2022 10:31:02 -0700 (PDT) Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id g11-20020a17090a708b00b001eabcc229e5sm3138642pjk.51.2022.06.14.10.31.01 for <55977@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:31:01 -0700 (PDT) From: Visuwesh To: 55977@debbugs.gnu.org Subject: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Tue, 14 Jun 2022 23:00:59 +0530 Message-ID: <87bkuv2lv0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55977 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-repeat-mode-Don-t-echo-unset-keys-in-help-message.patch >From 245b353ca178c633c8fffaf0375a9bba99ba1917 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Tue, 14 Jun 2022 22:59:47 +0530 Subject: [PATCH] repeat-mode: Don't echo unset keys in help message * repeat.el (repeat-echo-message-string): Check if the key is set. (bug#55977) --- lisp/repeat.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index ea4e3d0bd8..94ea9f7ac1 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -500,7 +500,7 @@ repeat-post-hook (defun repeat-echo-message-string (keymap) "Return a string with a list of repeating keys." (let (keys) - (map-keymap (lambda (key _) (push key keys)) keymap) + (map-keymap (lambda (key cmd) (and cmd (push key keys))) keymap) (format-message "Repeat with %s%s" (mapconcat (lambda (key) (key-description (vector key))) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 13:41:16 2022 Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 17:41:16 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1AXF-0003Pw-Ll for submit@debbugs.gnu.org; Tue, 14 Jun 2022 13:41:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1AX1-0003PR-FO for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 13:41:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AWv-00021m-S5; Tue, 14 Jun 2022 13:40:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RP//dzq+2tzBKcPYVMD/1yg67p1Iy5d0JpUVrC4QnM0=; b=c86BLZqlkT7h AW4W/sJKVFw0O8j4/EIpIWgQtyFXAFweEGGDlsGWTBXJRZy8e3E+KjHMO7rK/zrXiCWKBO7vfYt7V fhMukZ5HHFM1yGK+rzfCtKEsyokFvSIap4qrNO5kJFnUBd7WsYuadD4uUImaq6Fyz7p3et+1KiJHe DRu65Cr9q59hr+z1v16zwK0PuPj7dinLvH+p4YuhIO3TDJrnJpobNHWk8qxw+rMK88ESGAzEawkMn mDwDH9jcGYm8OfODVOLI1aS2+5VD6fBLLVknIKn61WnKkJX98Xi21tXUyUxcBIuzIbXqlwDvZRIeX vlRSMlu4ERhg9YRqIMPo6A==; Received: from [87.69.77.57] (port=2580 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AWv-0007IU-7w; Tue, 14 Jun 2022 13:40:41 -0400 Date: Tue, 14 Jun 2022 20:40:29 +0300 Message-Id: <83y1xzrvn6.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87fsk72m0b.fsf@gmail.com> (message from Visuwesh on Tue, 14 Jun 2022 22:57:48 +0530) Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message References: <87fsk72m0b.fsf@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55977 Cc: 55977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Visuwesh > Date: Tue, 14 Jun 2022 22:57:48 +0530 > > repeat-mode echoes unset keys in the help message since it doesn't check > for non-nil value of command bound to key; will attach patch once I get > the bug number. Thanks, but can you please show a recipe from "emacs -Q", to understand better what problem are you trying to fix? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 14:02:32 2022 Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 18:02:32 +0000 Received: from localhost ([127.0.0.1]:35707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1As3-00042L-Un for submit@debbugs.gnu.org; Tue, 14 Jun 2022 14:02:32 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Arz-000425-Bh for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 14:02:30 -0400 Received: by mail-pg1-f193.google.com with SMTP id 129so9201404pgc.2 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 11:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7mYcXiectHbYUmOx304Hi1VuhW/h7OEGGXuBSaXEjKM=; b=jvEsJ2ZTpAuJng8r4rOQZJeIGNPV3+33uwiH045XBJeaH7Z1PmNIdVA4WFYDp2p6tt 1e8Hmx2JAX1yQAADZuZMX8TwOjgdz0CTMPs9JMvx6QqSYzu+zX/fjiHGQL/CrglipJXL v5F3HepcbubbVS8qeU9ImJ6WElPW8lYv+zJuP9eG0RijfWkqKbV20UUAGrSFHQRxMyY/ 0xW4EwkpVNWsr/1254ugzSNgSdRlb/mqjavOaSinYOvs9af93NxU3ynNfknSkxfPv8Fz +QbXNwH0933L2tJv6NxCMZGOBiNPS9A3hPJtpESlyxkIaqRkfZtFIC8ikAKxdX4P/J9k +0Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7mYcXiectHbYUmOx304Hi1VuhW/h7OEGGXuBSaXEjKM=; b=svI7NIFw0xd5MRHROd5OA7nvQ5aOcKGvAJEKDjA/ewbuDTSr+IyIwx7ihX2yPdHGn9 bmPFHfFMeCuImTngog/P1LqOwP5B3Kb651DUXdfD9qIEyJ+Dl3UzvSwb7K24kR87kFx9 elFJBVYpWAuvdaDNcIWORuBLuKW0LbACK54dFfmJakCUpGlpm1ZG9PsqwT6NsBRmHR8t RTPGP0G4Dbnpegg9+IfQfA6dZulaLyUFPrZ7RyH9XgPX9YP7RNsAWPtaXRtpuYkwCpmI J907y9+f4l3mCMuP0+2ahXQVrQSKPRUY/iIKvpGmbGF/l5xrM9qCJKhajuUO6ok/V3jZ PBow== X-Gm-Message-State: AOAM532NcYAh/1PFq7Tulo99F2xE69t5ZsvyF2qoy+MOPaSY0V2kc5uV f+7wiv9ZctgZLycAy0x9NUA= X-Google-Smtp-Source: ABdhPJxyExQRVUeigRGZcTXi4Jl4dOvHktRjYAGhNkvI3dUlXQaQTfqAWRyIkga1gc6iWpdG4vbk4Q== X-Received: by 2002:a65:5385:0:b0:3fa:52e3:6468 with SMTP id x5-20020a655385000000b003fa52e36468mr5507508pgq.366.1655229741545; Tue, 14 Jun 2022 11:02:21 -0700 (PDT) Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id e3-20020a170903240300b00168e83eda56sm2772813plo.3.2022.06.14.11.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 11:02:20 -0700 (PDT) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> Date: Tue, 14 Jun 2022 23:32:17 +0530 In-Reply-To: <83y1xzrvn6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Jun 2022 20:40:29 +0300") Message-ID: <877d5j2keu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55977 Cc: 55977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 20:40] Eli Zaretskii wrote: >> From: Visuwesh >> Date: Tue, 14 Jun 2022 22:57:48 +0530 >>=20 >> repeat-mode echoes unset keys in the help message since it doesn't check >> for non-nil value of command bound to key; will attach patch once I get >> the bug number. > > Thanks, but can you please show a recipe from "emacs -Q", to > understand better what problem are you trying to fix? Sure. 1. M-x repeat-mode RET. 2. C-h n. 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). 4. C-c @ C-n. Notice how the help message still says C-n despite being unbound, and when you type C-n the repeat map exits contrary to what the message says. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 14:09:51 2022 Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 18:09:51 +0000 Received: from localhost ([127.0.0.1]:35711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Az7-0004CO-MS for submit@debbugs.gnu.org; Tue, 14 Jun 2022 14:09:51 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:35500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Az2-0004C7-5M for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 14:09:48 -0400 Received: by mail-pj1-f65.google.com with SMTP id v17-20020a17090a899100b001ead067eaf9so945644pjn.0 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 11:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3pUDC4TgOh2+0hHTChmyNYvcZZ4xxS1qcNLAmaaEjm0=; b=eo1vMbq1eLKdA7rVutwdM0DG1ohDzXVKekbwkT5uBhgYE+4jqy6T5ByL2dA8lQZZhY l7JcQkIp5NzhUFmYVlEGOKlfL3g/vNA7imWfw9Gd+jqWvKZM8rRxhBhUcZHo1KQDJHk4 8ayrJpGpBBHhCheFHQ39HAtGBPMpmbwCblF8QoBPWQibu5A0wgF3rGCCE6oP1zNORrfT bfw8smOMHfWo8d0dbzVkO3ccbzqUjapvN+z/EcCwL3jwpuJWB4r1YtRmw7QdShyZ4etg IMZ/yizTC8YSqeWPMTPtd6+91rDirP3baYscz9dmSN38ztC9NlTrVo7OvWw4pYMu/Y6L nHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3pUDC4TgOh2+0hHTChmyNYvcZZ4xxS1qcNLAmaaEjm0=; b=auNRjNlN1qaXGUdOwu1GFYCr401WIt+C/Ynk05aB8A8MDf4XxSoHHOP4QkmrKXjNMW fZZHTi42ESiQzgSL02hBZ1Z0F4QAkdNSa1sFlnVCLxL8H+8CbsnRp4rjAiF3zRtrTJsX FpgFpVbb0312EwF8XgwdvuNHU4kvISva4LPPVxSbXpwCTSi/SesaBvxZb9bJUQPZneA8 PILm9FwogiYNbOC1blljuFrtTkIJ3aDFKPOQK+UkqfU7KZUMBW5glHBl/55oXV+dywLZ EF0w0sPMUGHM7CqpHOzostOLBHtsF2pEqJZqWvHaDBlXdrJP7xq8aGrmWJgDR4UAdBhA yoOg== X-Gm-Message-State: AJIora8Ez+s9SrvhcqybLS9SgmwpF0e8pbDEeHnSopWqdCYtJDq5BFbr XgGmdKHom0N9K2sCuJgk+RVYuYDhmQ2PTw== X-Google-Smtp-Source: AGRyM1vRRvVO9yyWpr+j//+seUd/eEylLWK29Svk5Q3GxL9YYID5qTGqng6ZLSiY8F5eyU7rMbxpow== X-Received: by 2002:a17:90a:c7d7:b0:1e8:3d2d:dd67 with SMTP id gf23-20020a17090ac7d700b001e83d2ddd67mr5827993pjb.89.1655230178122; Tue, 14 Jun 2022 11:09:38 -0700 (PDT) Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id r9-20020a170902ea4900b0015e8da1fb07sm7587811plg.127.2022.06.14.11.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 11:09:37 -0700 (PDT) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> Date: Tue, 14 Jun 2022 23:39:34 +0530 In-Reply-To: <877d5j2keu.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:32:17 +0530") Message-ID: <87zgif15i9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55977 Cc: 55977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 23:32] Visuwesh wrote: > [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D= =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 20:40] Eli Zaretskii wrote: > >>> From: Visuwesh >>> Date: Tue, 14 Jun 2022 22:57:48 +0530 >>>=20 >>> repeat-mode echoes unset keys in the help message since it doesn't check >>> for non-nil value of command bound to key; will attach patch once I get >>> the bug number. >> >> Thanks, but can you please show a recipe from "emacs -Q", to >> understand better what problem are you trying to fix? > > Sure. > > 1. M-x repeat-mode RET. > 2. C-h n. > 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). > 4. C-c @ C-n. Notice how the help message still says C-n despite > being unbound, and when you type C-n the repeat map exits > contrary to what the message says. Oh, looks like if I give `define-key' a non-nil REMOVE argument, then C-n is no longer displayed in the help message. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 03:26:07 2022 Received: (at 55977) by debbugs.gnu.org; 15 Jun 2022 07:26:07 +0000 Received: from localhost ([127.0.0.1]:36336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NPi-0001ib-S8 for submit@debbugs.gnu.org; Wed, 15 Jun 2022 03:26:07 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NPf-0001ho-1R; Wed, 15 Jun 2022 03:26:05 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8E8001BF20E; Wed, 15 Jun 2022 07:25:55 +0000 (UTC) From: Juri Linkov To: Visuwesh Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Organization: LINKOV.NET References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> <87zgif15i9.fsf@gmail.com> Date: Wed, 15 Jun 2022 10:25:03 +0300 In-Reply-To: <87zgif15i9.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:39:34 +0530") Message-ID: <86k09i5qy8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55977 Cc: Eli Zaretskii , 55977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 55977 29.0.50 thanks >>>> repeat-mode echoes unset keys in the help message since it doesn't check >>>> for non-nil value of command bound to key; will attach patch once I get >>>> the bug number. >>> >>> Thanks, but can you please show a recipe from "emacs -Q", to >>> understand better what problem are you trying to fix? >> >> Sure. >> >> 1. M-x repeat-mode RET. >> 2. C-h n. >> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). >> 4. C-c @ C-n. Notice how the help message still says C-n despite >> being unbound, and when you type C-n the repeat map exits >> contrary to what the message says. > > Oh, looks like if I give `define-key' a non-nil REMOVE argument, then > C-n is no longer displayed in the help message. Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key, so now your patch is pushed to master, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 03:37:00 2022 Received: (at 55977) by debbugs.gnu.org; 15 Jun 2022 07:37:00 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NaF-0004BC-QH for submit@debbugs.gnu.org; Wed, 15 Jun 2022 03:36:59 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:53841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NaB-0004Av-2f for 55977@debbugs.gnu.org; Wed, 15 Jun 2022 03:36:58 -0400 Received: by mail-pj1-f68.google.com with SMTP id a10so10491877pju.3 for <55977@debbugs.gnu.org>; Wed, 15 Jun 2022 00:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WHh/hCcidYHw1qK42uqmG5zeNnTXKY+A2qrro1wkGxE=; b=kPblg9ipurToCYxw1URpGxrqZ3SU/oc22jOTzQzcRUl4VE+GXFFNe1ocvwNIgUmv6B K3186I93KVnZB/F69lhsy9uiFJKNkoXGqChYEiPxwZn8M/Pu/k8IpuiR7iE8dvrWSANO MYXu3M8pUBALoalYSW5JRalocuX4qgpW/YWKN/a/JEN2c8RsV7MrDDDd8eSJgcOlVSdp CP/fuRrP548NhPAtkXS26FbhVBlQ2MfB7iuqjWS7oVL2g3XPaoDsPmFJXNUkijLnF0XE PyeK4ZjbfNseUq9SNVRXjNKcWJ/ud0jHNziZOFAXAN6+FHUrep5IFIvHtdOpStPK3hfK qMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WHh/hCcidYHw1qK42uqmG5zeNnTXKY+A2qrro1wkGxE=; b=mJHd18/aTnZc8oRWyyutw/hDv+T+qh8AQeCOSoItltrXzOnh5ULx8MGeXB0lRORfzM OhnUyUZybDT+zCrtd+TRgzqjAIiCdYJTPVB30w/M4I+fuS9YyWenAZ2/qKSjj1NvzLSv OVSp/cQNh8OQwNyO+cWOiKVLl7dWuGqdc4d4CtU2ufuIhrdERggWOOvgpYZ9DAA7ivzO 1tmohzVrsIKvpsFklHGmaAsRJRU/hJIVysqIHG6KpZfZJ7Zq2SaV7UuwX0xLWDfXaLjv /LqGm47IcksyWTsqiGWyzcfgwacVrCewhvVmECFa3m3cTY77kqUhsKfmwYfPyQr6wAt3 rLUg== X-Gm-Message-State: AJIora8HVwIBwwYtwucev7oK7yyRsvpx3kaGoT/figrJZjR0ew6x8/XI qLg8YbtPgT5+hDfAV8xtO0k= X-Google-Smtp-Source: AGRyM1tU2ZdCWPO8Jq1w9e8x+/WjYbKsjjRfux6rKDn3ir2LBD2gBrEA0t8sFqFqu4p2KraBxJSf9Q== X-Received: by 2002:a17:902:ba81:b0:168:cca6:1b2f with SMTP id k1-20020a170902ba8100b00168cca61b2fmr7949573pls.84.1655278609134; Wed, 15 Jun 2022 00:36:49 -0700 (PDT) Received: from localhost ([49.204.134.215]) by smtp.gmail.com with ESMTPSA id z10-20020aa785ca000000b0051b95c76752sm8952910pfn.153.2022.06.15.00.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 00:36:48 -0700 (PDT) From: Visuwesh To: Juri Linkov Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> <87zgif15i9.fsf@gmail.com> <86k09i5qy8.fsf@mail.linkov.net> Date: Wed, 15 Jun 2022 13:06:45 +0530 In-Reply-To: <86k09i5qy8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 15 Jun 2022 10:25:03 +0300") Message-ID: <877d5iidiq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55977 Cc: Eli Zaretskii , 55977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=9C=E0=AF=82=E0=AE=A9= =E0=AF=8D 15, 2022 10:25] Juri Linkov wrote: > close 55977 29.0.50 > thanks > >>>>> repeat-mode echoes unset keys in the help message since it doesn't ch= eck >>>>> for non-nil value of command bound to key; will attach patch once I g= et >>>>> the bug number. >>>> >>>> Thanks, but can you please show a recipe from "emacs -Q", to >>>> understand better what problem are you trying to fix? >>> >>> Sure. >>> >>> 1. M-x repeat-mode RET. >>> 2. C-h n. >>> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). >>> 4. C-c @ C-n. Notice how the help message still says C-n despite >>> being unbound, and when you type C-n the repeat map exits >>> contrary to what the message says. >> >> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then >> C-n is no longer displayed in the help message. > > Indeed, the REMOVE removes a key, but nil is also a valid way to undefine= a key, > so now your patch is pushed to master, thanks. Great, thanks! From unknown Tue Jun 17 01:27:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jul 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator