Subject: bug#55964: closed (Re: Updated series)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 20 Jul 2022 15:18:04 +0000

Your bug report

#55966: [PATCH 2/9] gnu: Add node-yazl.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55966
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: Updated series
From: Marius Bakke <[email-masked]>
To: Nicolas Graves <[email-masked]>, [email-masked]
Cc: [email-masked]
Date: Wed, 20 Jul 2022 17:16:48 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Nicolas Graves <[email-masked]> skriver:

> Hi Marius,
>
> Sorry for the time it took me, here's the updated series.

No worries, thanks a lot for this work.

> Everything has been checked with guix lint. I use emacs, but couldn't get guix
> style to work the way you counselled, hope it's ok.

What was the issue?  :-)

I ran 'guix style' for each since I had to edit the commits anyway to
get the author right (for some reason it showed up as "Nicolas Graves
via Guix-patches <[email-masked]>" -- NYF!).

> Also thanks for your advice! 

:-)

Some more advice for future pull requests, please first send a message
to [email-masked]' to get a bug ID assigned (can be anything,
although often a 'git format-patch --cover-letter').  Then send the
patch series to [email-masked], otherwise the patches will
be scattered across different issues and difficult to track.

Also, use "-n" with send-email/format-patch so that the ordering is
preserved.  It was lacking in the second series, but I used the
information from the first round to get it right.

Anyway, great work, pushed as c8f33b613e..cda3de3b7d!

Subject: [PATCH 2/9] gnu: Add node-yazl.
From: Nicolas Graves <[email-masked]>
To: [email-masked]
Cc: Nicolas Graves <[email-masked]>
Date: Tue, 14 Jun 2022 11:49:47 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/node-xyz.scm (node-yazl): New variable.
---
 gnu/packages/node-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index be37d627cf..af3745f601 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -1335,3 +1335,36 @@ (define-public node-serialport
 accessing serial ports.  This package is the recommended entry point for most
 projects.  It combines a high-level Node.js stream interface with a useful
 default set of parsers and bindings.")))
+
+(define-public node-yazl
+  (package
+    (name "node-yazl")
+    (version "2.5.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/thejoshwolfe/yazl")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+          (base32
+           "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (replace 'configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
+                     "--offline" "--ignore-scripts" "install" "--production")
+             #t)))))
+    (inputs (list node-buffer-crc32))
+    (home-page "https://github.com/thejoshwolfe/yazl")
+    (synopsis "Yet another zip library for node")
+    (description "This package provides a zip library for Node. It follows the following principles:
+Don't block the JavaScript thread. Use and provide async APIs.
+Keep memory usage under control. Don't attempt to buffer entire files in RAM at once.
+Prefer to open input files one at a time than all at once. ")
+    (license license:expat)))
-- 
2.36.1