From unknown Sat Sep 06 08:35:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Jun 2022 09:51:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55966@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165520025411116 (code B ref -1); Tue, 14 Jun 2022 09:51:06 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:54 +0000 Received: from localhost ([127.0.0.1]:32979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13CI-0002tE-GS for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:53534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C8-0002sI-VF for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C7-0008QR-Kv for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:44 -0400 Received: from 9.mo575.mail-out.ovh.net ([46.105.78.111]:58327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C5-00021P-OI for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:43 -0400 Received: from player746.ha.ovh.net (unknown [10.109.156.194]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 7F02524A41 for ; Tue, 14 Jun 2022 09:50:40 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 2901D1E2E0CC0; Tue, 14 Jun 2022 09:50:38 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003777eda67-933b-491e-8fb4-95f9b9b01f17, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves Date: Tue, 14 Jun 2022 11:49:54 +0200 Message-Id: <20220614094954.15197-9-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6480679867763385058 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepleffjeetueethfefkeffffefvddukeejkefgleduiedthfekvefhiedvhfffgeegnecukfhppedtrddtrddtrddtpddujeeirdduieeirdduheelrdejjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeegiedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheejhe Received-SPF: pass client-ip=46.105.78.111; envelope-from=ngraves@ngraves.fr; helo=9.mo575.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --- gnu/build/chromium-extension.scm | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extension.scm index 8ca5251957..8d52153751 100644 --- a/gnu/build/chromium-extension.scm +++ b/gnu/build/chromium-extension.scm @@ -19,10 +19,9 @@ (define-module (gnu build chromium-extension) #:use-module (guix gexp) #:use-module (guix packages) - #:use-module (gnu packages chromium) #:use-module (gnu packages gnupg) #:use-module (gnu packages tls) - #:use-module (gnu packages xorg) + #:use-module (gnu packages node-xyz) #:use-module (guix build-system trivial) #:export (make-chromium-extension)) @@ -69,24 +68,14 @@ (define version (package-version package)) (string-append name "-" version ".crx") (with-imported-modules '((guix build utils)) #~(begin - ;; This is not great. We pull Xorg and Chromium just to Zip and - ;; sign an extension. This should be implemented with something - ;; lighter. (TODO: where is the CRXv3 documentation..?) (use-modules (guix build utils)) - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium")) - (xvfb #$(file-append xorg-server "/bin/Xvfb")) + (let ((crx3 #$(file-append node-crx3 "/bin/crx3")) (packdir (string-append (getcwd) "/extension"))) (mkdir packdir) (copy-recursively (ungexp package package-output) packdir ;; Ensure consistent file modification times. #:keep-mtime? #t) - (system (string-append xvfb " :1 &")) - (setenv "DISPLAY" ":1") - (sleep 2) ;give Xorg some time to initialize... - (invoke chromium - "--user-data-dir=chromium-profile" - (string-append "--pack-extension=" packdir) - (string-append "--pack-extension-key=" #$signing-key)) + (invoke crx3 "--keyPath" #$signing-key packdir) (copy-file (string-append packdir ".crx") #$output)))) #:local-build? #t)) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 05:21:16 2022 Received: (at control) by debbugs.gnu.org; 15 Jun 2022 09:21:16 +0000 Received: from localhost ([127.0.0.1]:36543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1PDA-0006wM-Fb for submit@debbugs.gnu.org; Wed, 15 Jun 2022 05:21:16 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:44815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1PD8-0006wE-I1 for control@debbugs.gnu.org; Wed, 15 Jun 2022 05:21:14 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LNKYN6rMhz1LZWS for ; Wed, 15 Jun 2022 11:21:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LNKYN6rMhz1LZWS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1655284873; bh=DbixW9/N1FL9uQx4nl8mGj/fr+jmDHL4b8hlnpDE8DU=; h=Subject:From:To:Date:From; b=syJWrXq8i39djGklsXvAgSUkPpF1rPH5p8FvQ7Mwxf+fBMdOT9JD/IdSlUAO0sd2H euaM5ZQS6o5lsQe0WV5GSMe3C108ig+kfqeSn0rkzfjmN/WG1d9QOWOWrVaSu+EIxF sohBUpR7BNtH6Z7hiuWYtukQxqcZpgifSI4oueS8= Message-ID: Subject: From: Liliana Marie Prikler To: control@debbugs.gnu.org Date: Wed, 15 Jun 2022 11:21:11 +0200 Content-Type: text/plain User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 55958 55959 55960 55961 55962 55963 55964 55965 55966 thanks Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [129.27.2.202 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [129.27.2.202 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.7 BODY_EMPTY No body text in message X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) merge 55958 55959 55960 55961 55962 55963 55964 55965 55966 thanks From unknown Sat Sep 06 08:35:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55966@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55966@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165601926328838 (code B ref -1); Thu, 23 Jun 2022 21:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 21:21:03 +0000 Received: from localhost ([127.0.0.1]:40143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4UG6-0007Uu-KD for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:21:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:34692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4UG5-0007U4-2O for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG4-0001rQ-Pf for guix-patches@gnu.org; Thu, 23 Jun 2022 17:21:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG4-0004Y5-6k; Thu, 23 Jun 2022 17:21:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=z8OaRJUnslCFZtQgPwOldeqlYFUlB0/yeswTO6qAVLs=; b=IPwPH46+xs6gXUNr62M6 fwRKJZLkDADSxhlv8l3uYwZieV4HX5yuWc0R336Hc3bHuP0GvywMD+QhMTBGti5h5ZF8VhKRn+3iH NK/yT8lXe62R+oyddrHOoEAQw2HZNOgGg/q2Kb16aJL0nmyHnE8malA+WLtAZA4zEydB/KXrpoDXg ReTpE4rw84rzBX0W2O6z8Ypk3tPBCFHpC2GIIttJA5KJbS706Ea6AVAQ5ERMHc710KXnktnV7uZo5 5vtLLoug22llIUbbcslcL30ms13/Ma3aYMSkZ9udIDNMecU2zOXRttApaQs/lUsbHLwjKskI07IyR J8k6HZQNFTCimw==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:38588 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG3-0007Hd-Ol; Thu, 23 Jun 2022 17:20:59 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-9-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 23:20:57 +0200 Message-ID: <87r13fqdom.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > --- > gnu/build/chromium-extension.scm | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) This commit lacks a message describing the changed variable. The commit title could also be more descriptive. ;-) > diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extens= ion.scm > index 8ca5251957..8d52153751 100644 > --- a/gnu/build/chromium-extension.scm > +++ b/gnu/build/chromium-extension.scm > @@ -19,10 +19,9 @@ > (define-module (gnu build chromium-extension) > #:use-module (guix gexp) > #:use-module (guix packages) > - #:use-module (gnu packages chromium) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages tls) > - #:use-module (gnu packages xorg) > + #:use-module (gnu packages node-xyz) > #:use-module (guix build-system trivial) > #:export (make-chromium-extension)) >=20=20 > @@ -69,24 +68,14 @@ (define version (package-version package)) > (string-append name "-" version ".crx") > (with-imported-modules '((guix build utils)) > #~(begin > - ;; This is not great. We pull Xorg and Chromium just to Zip and > - ;; sign an extension. This should be implemented with something > - ;; lighter. (TODO: where is the CRXv3 documentation..?) Wohoo. :-) > (use-modules (guix build utils)) > - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromiu= m")) > - (xvfb #$(file-append xorg-server "/bin/Xvfb")) > + (let ((crx3 #$(file-append node-crx3 "/bin/crx3")) > (packdir (string-append (getcwd) "/extension"))) > (mkdir packdir) > (copy-recursively (ungexp package package-output) packdir > ;; Ensure consistent file modification time= s. > #:keep-mtime? #t) > - (system (string-append xvfb " :1 &")) > - (setenv "DISPLAY" ":1") > - (sleep 2) ;give Xorg some time to initiali= ze... > - (invoke chromium > - "--user-data-dir=3Dchromium-profile" > - (string-append "--pack-extension=3D" packdir) > - (string-append "--pack-extension-key=3D" #$signing-ke= y)) > + (invoke crx3 "--keyPath" #$signing-key packdir) LGTM! Feel free to add your copyright here too. Can you send an updated series? Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTZOQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcmwQD8CMK+pxlSWKSUz/ZS4n6M37C/yTwXqJn4qeGC hws+52wBAIw/6zFLo4RX6PFqyK9JZQaT/A5uCqEB4F62aO+AFJYB =NJqd -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:35:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves , 55966@debbugs.gnu.org Received: via spool by 55966-submit@debbugs.gnu.org id=B55966.16560233002977 (code B ref 55966); Thu, 23 Jun 2022 22:29:02 +0000 Received: (at 55966) by debbugs.gnu.org; 23 Jun 2022 22:28:20 +0000 Received: from localhost ([127.0.0.1]:40272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4VJE-0000lx-Lx for submit@debbugs.gnu.org; Thu, 23 Jun 2022 18:28:20 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:51986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4VJC-0000ln-2d for 55966@debbugs.gnu.org; Thu, 23 Jun 2022 18:28:18 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id mmUG270064UW6Th01mUGHF; Fri, 24 Jun 2022 00:28:17 +0200 Message-ID: From: Maxime Devos Date: Fri, 24 Jun 2022 00:28:16 +0200 In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-9-ngraves@ngraves.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-O5I67RtjUez/SaWtLtIT" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656023297; bh=4cKithEbUlC4uuS7rXsoGCd2NQwLQhNHJf2eGZWRH0w=; h=Subject:From:To:Date:In-Reply-To:References; b=nyIumaegoHpM/D+HFrsNIcoTiJ22kXmh0QVAFPcrbpM9bvQ2eWW1d5459w6uxf5DC yhVClyEh0zKSzf931qCVxDhGo9gfMcj5recpGq0oinktvx5/mnM3+9fB7YLZ2mYQYj NE6g/iP++oFfKqbNDjJO8RPoVOO+tUSnQCCFCFxeej8cH5gwIaFkdm5JBtp+lBXHH0 GOTeO4RdOv2WcTu0WVVjNzlGUV6gpULJ7tXG5UhPp4PJEaT1DHlJ+OUc6xue7d0VZ5 5yPFKyYih8QqlwWyo7YFf6jRj5u1JgC+FSQYIb/S+CrBWF8HDs96C5inhBCLaWrvc4 LlXLlRDRSAIcQ== X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-O5I67RtjUez/SaWtLtIT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via schreef op di 14-06-2022 om 11:49 [+0200]: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let ((chromium #$(file= -append ungoogled-chromium "/bin/chromium")) > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (xvfb #$(file-append xorg-server "/bin/Xvfb")) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let ((crx3 #$(file-app= end node-crx3 "/bin/crx3")) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (packdir (string-append (getcwd) "/extension"))) You're invoking crx3 below, so it shouldn't be cross-compiled even if the extension is cross-compiled, hence the #$(file-append node-crx3 ...) should probably be #+(file-append node-crx ...) instead. (Also was an issue in the old code that used chromium and xorg-server ..., and probably the chromium build system doesn't implement cross- compilation yet ...) Greetings, Maxime. --=-O5I67RtjUez/SaWtLtIT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrTpABccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7shaAQDKfsSTPYKqGefXZWBP7/lTOdnN xdneYKiEfwFrdeLmEAEA3g1gmk8AmQgQQl8rj5hJnKG7UxqzArFus+JZpEjQ/Q4= =elet -----END PGP SIGNATURE----- --=-O5I67RtjUez/SaWtLtIT-- From unknown Sat Sep 06 08:35:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] [PATCH] gnu: modifying make-chromium-extension to rely on node-crx3. References: <20220614094954.15197-9-ngraves@ngraves.fr> In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Jul 2022 10:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55966@debbugs.gnu.org Cc: ngraves@ngraves.fr Received: via spool by 55966-submit@debbugs.gnu.org id=B55966.1658313583983 (code B ref 55966); Wed, 20 Jul 2022 10:40:02 +0000 Received: (at 55966) by debbugs.gnu.org; 20 Jul 2022 10:39:43 +0000 Received: from localhost ([127.0.0.1]:55931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE77G-0000Fn-MB for submit@debbugs.gnu.org; Wed, 20 Jul 2022 06:39:43 -0400 Received: from 9.mo584.mail-out.ovh.net ([46.105.40.176]:43429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE77D-0000Fb-MZ for 55966@debbugs.gnu.org; Wed, 20 Jul 2022 06:39:41 -0400 Received: from player728.ha.ovh.net (unknown [10.111.172.211]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id 0B064248AF for <55966@debbugs.gnu.org>; Wed, 20 Jul 2022 10:39:38 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player728.ha.ovh.net (Postfix) with ESMTPSA id 82FAC2CBC3404; Wed, 20 Jul 2022 10:39:36 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-108S002221651bb-2e7a-4523-b9ff-3df1960b386b, 129C31CF0BB9A5A41165496B287D5FC7981061FF) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves Date: Wed, 20 Jul 2022 12:39:34 +0200 Message-Id: <20220720103934.17768-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 15810167968178823906 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelvddgfedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffogggtgfesthekredtredtreenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeefjeffledugfetgffhtdevfeelheeihfevhefgkeektdfhkeejheegvdehjeetheenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejvdekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepheehleeiieesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekge X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/build/chromium-extension.scm (make-crx): Lift Xorg and Chromium dependencies, rely on node-crx3 instead. --- gnu/build/chromium-extension.scm | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extension.scm index 8ca5251957..28449a1e1d 100644 --- a/gnu/build/chromium-extension.scm +++ b/gnu/build/chromium-extension.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020, 2021 Marius Bakke +;;; Copyright © 2022 Nicolas Graves ;;; ;;; This file is part of GNU Guix. ;;; @@ -19,10 +20,9 @@ (define-module (gnu build chromium-extension) #:use-module (guix gexp) #:use-module (guix packages) - #:use-module (gnu packages chromium) #:use-module (gnu packages gnupg) #:use-module (gnu packages tls) - #:use-module (gnu packages xorg) + #:use-module (gnu packages node-xyz) #:use-module (guix build-system trivial) #:export (make-chromium-extension)) @@ -69,24 +69,14 @@ (define version (package-version package)) (string-append name "-" version ".crx") (with-imported-modules '((guix build utils)) #~(begin - ;; This is not great. We pull Xorg and Chromium just to Zip and - ;; sign an extension. This should be implemented with something - ;; lighter. (TODO: where is the CRXv3 documentation..?) (use-modules (guix build utils)) - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium")) - (xvfb #$(file-append xorg-server "/bin/Xvfb")) + (let ((crx3 #+(file-append node-crx3 "/bin/crx3")) (packdir (string-append (getcwd) "/extension"))) (mkdir packdir) (copy-recursively (ungexp package package-output) packdir ;; Ensure consistent file modification times. #:keep-mtime? #t) - (system (string-append xvfb " :1 &")) - (setenv "DISPLAY" ":1") - (sleep 2) ;give Xorg some time to initialize... - (invoke chromium - "--user-data-dir=chromium-profile" - (string-append "--pack-extension=" packdir) - (string-append "--pack-extension-key=" #$signing-key)) + (invoke crx3 "--keyPath" #$signing-key packdir) (copy-file (string-append packdir ".crx") #$output)))) #:local-build? #t)) -- 2.37.0 From unknown Sat Sep 06 08:35:59 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] Updated series References: <20220614094954.15197-9-ngraves@ngraves.fr> In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Jul 2022 10:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55966@debbugs.gnu.org Cc: ngraves@ngraves.fr, marius@gnu.org Received: via spool by 55966-submit@debbugs.gnu.org id=B55966.16583140021905 (code B ref 55966); Wed, 20 Jul 2022 10:47:01 +0000 Received: (at 55966) by debbugs.gnu.org; 20 Jul 2022 10:46:42 +0000 Received: from localhost ([127.0.0.1]:55942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE7E2-0000Uf-91 for submit@debbugs.gnu.org; Wed, 20 Jul 2022 06:46:42 -0400 Received: from 11.mo581.mail-out.ovh.net ([87.98.173.157]:33847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE7Dz-0000UV-Is for 55966@debbugs.gnu.org; Wed, 20 Jul 2022 06:46:40 -0400 Received: from player694.ha.ovh.net (unknown [10.109.143.24]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id AA6EC24878 for <55966@debbugs.gnu.org>; Wed, 20 Jul 2022 10:46:37 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player694.ha.ovh.net (Postfix) with ESMTPSA id 697C22CB7EE7F; Wed, 20 Jul 2022 10:46:34 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-102R004252aec0d-97d6-48d9-98c3-f1d14a420dc5, 129C31CF0BB9A5A41165496B287D5FC7981061FF) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves Date: Wed, 20 Jul 2022 12:46:33 +0200 Message-ID: <875yjsawom.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 15928387460420657890 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelvddgfeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeugefgtdekvdeujefhfeeggfevjeehfffgjedvteeuheffheegueffhfdttdehheenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileegrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepheehleeiieesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekud X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Marius, Sorry for the time it took me, here's the updated series. Everything has been checked with guix lint. I use emacs, but couldn't get guix style to work the way you counselled, hope it's ok. Also thanks for your advice! -- Best regards, Nicolas Graves From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55966: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-9-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55966 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55966@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330282-17719-1" This is a multi-part message in MIME format... ------------=_1658330282-17719-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 9/9] gnu: chromium extensions lighter make-crx. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55966@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330282-17719-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330282-17719-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:54 +0000 Received: from localhost ([127.0.0.1]:32979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13CI-0002tE-GS for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:53534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C8-0002sI-VF for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C7-0008QR-Kv for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:44 -0400 Received: from 9.mo575.mail-out.ovh.net ([46.105.78.111]:58327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C5-00021P-OI for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:43 -0400 Received: from player746.ha.ovh.net (unknown [10.109.156.194]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 7F02524A41 for ; Tue, 14 Jun 2022 09:50:40 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 2901D1E2E0CC0; Tue, 14 Jun 2022 09:50:38 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003777eda67-933b-491e-8fb4-95f9b9b01f17, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 9/9] gnu: chromium extensions lighter make-crx. Date: Tue, 14 Jun 2022 11:49:54 +0200 Message-Id: <20220614094954.15197-9-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6480679867763385058 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepleffjeetueethfefkeffffefvddukeejkefgleduiedthfekvefhiedvhfffgeegnecukfhppedtrddtrddtrddtpddujeeirdduieeirdduheelrdejjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeegiedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheejhe Received-SPF: pass client-ip=46.105.78.111; envelope-from=ngraves@ngraves.fr; helo=9.mo575.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --- gnu/build/chromium-extension.scm | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extension.scm index 8ca5251957..8d52153751 100644 --- a/gnu/build/chromium-extension.scm +++ b/gnu/build/chromium-extension.scm @@ -19,10 +19,9 @@ (define-module (gnu build chromium-extension) #:use-module (guix gexp) #:use-module (guix packages) - #:use-module (gnu packages chromium) #:use-module (gnu packages gnupg) #:use-module (gnu packages tls) - #:use-module (gnu packages xorg) + #:use-module (gnu packages node-xyz) #:use-module (guix build-system trivial) #:export (make-chromium-extension)) @@ -69,24 +68,14 @@ (define version (package-version package)) (string-append name "-" version ".crx") (with-imported-modules '((guix build utils)) #~(begin - ;; This is not great. We pull Xorg and Chromium just to Zip and - ;; sign an extension. This should be implemented with something - ;; lighter. (TODO: where is the CRXv3 documentation..?) (use-modules (guix build utils)) - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium")) - (xvfb #$(file-append xorg-server "/bin/Xvfb")) + (let ((crx3 #$(file-append node-crx3 "/bin/crx3")) (packdir (string-append (getcwd) "/extension"))) (mkdir packdir) (copy-recursively (ungexp package package-output) packdir ;; Ensure consistent file modification times. #:keep-mtime? #t) - (system (string-append xvfb " :1 &")) - (setenv "DISPLAY" ":1") - (sleep 2) ;give Xorg some time to initialize... - (invoke chromium - "--user-data-dir=chromium-profile" - (string-append "--pack-extension=" packdir) - (string-append "--pack-extension-key=" #$signing-key)) + (invoke crx3 "--keyPath" #$signing-key packdir) (copy-file (string-append packdir ".crx") #$output)))) #:local-build? #t)) -- 2.36.1 ------------=_1658330282-17719-1-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55958: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-1-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55958 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55958@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330282-17719-3" This is a multi-part message in MIME format... ------------=_1658330282-17719-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 1/9] gnu: Add node-buffer-crc32. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55958@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330282-17719-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330282-17719-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:42 +0000 Received: from localhost ([127.0.0.1]:32961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C4-0002rS-6V for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C2-0002r8-6p for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C0-0008G7-6D for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:37 -0400 Received: from 3.mo584.mail-out.ovh.net ([46.105.57.129]:39705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13Bx-0001yk-UR for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:35 -0400 Received: from player746.ha.ovh.net (unknown [10.108.1.59]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id 513F324DFE for ; Tue, 14 Jun 2022 09:50:21 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id AACCB1E2E0AB1; Tue, 14 Jun 2022 09:50:19 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S00372c27a0e-e5d0-4148-8107-efc56fba409f, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 1/9] gnu: Add node-buffer-crc32. Date: Tue, 14 Jun 2022 11:49:46 +0200 Message-Id: <20220614094954.15197-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6475050366315520738 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepteeffefhfffhjeevleeuvdehgffgveekheeuhfekhfehuefgheffhedugfegleeinecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeeg Received-SPF: pass client-ip=46.105.57.129; envelope-from=ngraves@ngraves.fr; helo=3.mo584.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-buffer-crc32): New variable. --- gnu/packages/node-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index 9dcb5c3d16..be37d627cf 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -56,6 +56,38 @@ (define-public node-acorn architecture supporting plugins.") (license license:expat))) +(define-public node-buffer-crc32 + (package + (name "node-buffer-crc32") + (version "0.2.13") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/brianloveswords/buffer-crc32") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "09qx2mnd898190m50mc0rhyvbm7d677sxz9bn09qmqkz6fnsddgf")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (home-page "https://github.com/brianloveswords/buffer-crc32") + (synopsis "crc32 that works with binary data and fancy character sets, +outputs buffer, signed or unsigned data and has tests.") + (description "This package provides crc32 that works with binary data and +fancy character sets, outputs buffer, signed or unsigned data and has tests, for +Node.") + (license license:expat))) + (define-public node-color-name (package (name "node-color-name") -- 2.36.1 ------------=_1658330282-17719-3-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55959: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-4-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55959 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55959@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330283-17719-5" This is a multi-part message in MIME format... ------------=_1658330283-17719-5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 4/9] gnu: Add node-resolve-protobuf-schema. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55959@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330283-17719-5 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330283-17719-5 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:42 +0000 Received: from localhost ([127.0.0.1]:32963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C5-0002ru-Nh for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:53316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C2-0002r9-6v for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C0-0008G3-4P for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:37 -0400 Received: from 10.mo575.mail-out.ovh.net ([46.105.79.203]:42281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13Bx-0001zZ-UA for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:35 -0400 Received: from player746.ha.ovh.net (unknown [10.111.208.252]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 71C1624A41 for ; Tue, 14 Jun 2022 09:50:28 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id EEF2C1E2E0BC3; Tue, 14 Jun 2022 09:50:25 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S0037010d535-3da1-4c98-b751-e8b3761b80d1, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 4/9] gnu: Add node-resolve-protobuf-schema. Date: Tue, 14 Jun 2022 11:49:49 +0200 Message-Id: <20220614094954.15197-4-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6477302164365435618 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehjeeh Received-SPF: pass client-ip=46.105.79.203; envelope-from=ngraves@ngraves.fr; helo=10.mo575.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-resolve-protobuf-schema): New variable. --- gnu/packages/node-xyz.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index 3f49955e29..8f3288f219 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -263,6 +263,37 @@ (define-public node-protocol-buffers-schema in Javascript.") (license license:expat))) +(define-public node-resolve-protobuf-schema + (package + (name "node-resolve-protobuf-schema") + (version "2.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mafintosh/resolve-protobuf-schema") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0zxavr0b2yz9xzp6zlsg5g09i0a6zqb24j12rdvfgph6wd4mzk40")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (inputs (list node-protocol-buffers-schema)) + (home-page "https://github.com/mafintosh/resolve-protobuf-schema") + (synopsis "Read a protobuf schema from the disk, parse it and resolve all imports") + (description "This package allows to read a protobuf schema from the disk, +parse it and resolve all imports.") + (license license:expat))) + (define-public node-stack-trace ;; There have been improvements since the last release. (let ((commit "4fd379ee78965ce7ce8820b436f1b1b590d5dbcf") -- 2.36.1 ------------=_1658330283-17719-5-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55960: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-5-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55960 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55960@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330283-17719-7" This is a multi-part message in MIME format... ------------=_1658330283-17719-7 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 5/9] gnu: Add node-ieee754. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55960@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330283-17719-7 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330283-17719-7 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:45 +0000 Received: from localhost ([127.0.0.1]:32967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C9-0002sO-8q for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:53312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C2-0002r7-6i for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C1-0008G9-Lt for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:37 -0400 Received: from 8.mo582.mail-out.ovh.net ([178.33.42.204]:44435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13Bx-0001zu-Uq for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:37 -0400 Received: from player746.ha.ovh.net (unknown [10.109.143.209]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 0C90323BC9 for ; Tue, 14 Jun 2022 09:50:30 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 6F5BA1E2E0BE4; Tue, 14 Jun 2022 09:50:28 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003ea1bd569-4ace-455e-8da2-0be56ae7670c, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 5/9] gnu: Add node-ieee754. Date: Tue, 14 Jun 2022 11:49:50 +0200 Message-Id: <20220614094954.15197-5-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6477865115675845346 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkedv Received-SPF: pass client-ip=178.33.42.204; envelope-from=ngraves@ngraves.fr; helo=8.mo582.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-ieee754): New variable. --- gnu/packages/node-xyz.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index 8f3288f219..3d945871cd 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -458,6 +458,37 @@ (define-public node-once if desired.") (license license:isc))) +(define-public node-ieee754 + (package + (name "node-ieee754") + (version "1.2.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/feross/ieee754") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "19rlg59lavnwsvbblhvrqwinz2wzqlxhddqpwrc3cyqkscjgza7i")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (home-page "https://github.com/feross/ieee754") + (synopsis "Read/write IEEE754 floating point numbers from/to a Buffer or +array-like object") + (description "This package allows to read/write IEEE754 floating point +numbers from/to a Buffer or array-like object in Javascript.") + (license license:bsd-3))) + (define-public node-inherits (package (name "node-inherits") -- 2.36.1 ------------=_1658330283-17719-7-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55961: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-3-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55961 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55961@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330283-17719-9" This is a multi-part message in MIME format... ------------=_1658330283-17719-9 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 3/9] gnu: Add node-protocol-buffers-schema. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55961@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330283-17719-9 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330283-17719-9 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:46 +0000 Received: from localhost ([127.0.0.1]:32969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C9-0002sR-Iv for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:53336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C4-0002rP-2R for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C3-0008H3-JA for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from 7.mo560.mail-out.ovh.net ([188.165.48.182]:41299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C1-0001z7-BI for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from player746.ha.ovh.net (unknown [10.108.4.183]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 2694C249DA for ; Tue, 14 Jun 2022 09:50:25 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 8B4EB1E2E0B8C; Tue, 14 Jun 2022 09:50:23 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003061250fa-3eab-4c1a-8575-e24155d54bff, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 3/9] gnu: Add node-protocol-buffers-schema. Date: Tue, 14 Jun 2022 11:49:48 +0200 Message-Id: <20220614094954.15197-3-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6476457741602054882 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedt Received-SPF: pass client-ip=188.165.48.182; envelope-from=ngraves@ngraves.fr; helo=7.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-protocol-buffers-schema): New variable. --- gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index af3745f601..3f49955e29 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -233,6 +233,36 @@ (define-public node-oop while being as light-weight and simple as possible.") (license license:expat)))) +(define-public node-protocol-buffers-schema + (package + (name "node-protocol-buffers-schema") + (version "3.6.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mafintosh/protocol-buffers-schema") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0lnckxj14jzsnfxdd5kmlwrac43c214bv8i2g5rdldymlpxzrz1v")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (home-page "https://github.com/mafintosh/protocol-buffers-schema") + (synopsis "No nonsense protocol buffers schema parser written in Javascript") + (description "This package provides a protocol buffers schema parser written +in Javascript.") + (license license:expat))) + (define-public node-stack-trace ;; There have been improvements since the last release. (let ((commit "4fd379ee78965ce7ce8820b436f1b1b590d5dbcf") -- 2.36.1 ------------=_1658330283-17719-9-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55962: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-6-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55962 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55962@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330283-17719-11" This is a multi-part message in MIME format... ------------=_1658330283-17719-11 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 6/9] gnu: Add node-pbf. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55962@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330283-17719-11 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330283-17719-11 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:46 +0000 Received: from localhost ([127.0.0.1]:32971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C9-0002sY-Vl for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:53334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C4-0002rO-1O for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C2-0008Gq-8W for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from 8.mo575.mail-out.ovh.net ([46.105.74.219]:51625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13Bz-000207-5B for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:37 -0400 Received: from player746.ha.ovh.net (unknown [10.108.4.136]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 5881024B0C for ; Tue, 14 Jun 2022 09:50:33 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id E29431E2E0C17; Tue, 14 Jun 2022 09:50:30 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S0032d747a16-0847-4ce8-8a7b-e38e88468fd8, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 6/9] gnu: Add node-pbf. Date: Tue, 14 Jun 2022 11:49:51 +0200 Message-Id: <20220614094954.15197-6-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6478709541728412386 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehjeeh Received-SPF: pass client-ip=46.105.74.219; envelope-from=ngraves@ngraves.fr; helo=8.mo575.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-pbf): New variable. --- gnu/packages/node-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index 3d945871cd..aa838108ad 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -233,6 +233,41 @@ (define-public node-oop while being as light-weight and simple as possible.") (license license:expat)))) +(define-public node-pbf + (package + (name "node-pbf") + (version "3.2.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mapbox/pbf") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1r8xs787ix79yr0vrwrizdml9h7cmxjrzhvnhkj784ac5f8nv5j7")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (inputs (list node-ieee754 node-resolve-protobuf-schema)) + (home-page "https://github.com/mapbox/pbf") + (synopsis "Low-level library for decoding and encodingprotocol buffers in +Javascript") + (description "This package is a low-level, fast, ultra-lightweight (3KB +gzipped) JavaScript library for decoding and encoding protocol buffers, a +compact binary format for structured data serialization. Works both in Node and +the browser. Supports lazy decoding and detailed customization of the +reading/writing code.") + (license license:bsd-3))) + (define-public node-protocol-buffers-schema (package (name "node-protocol-buffers-schema") -- 2.36.1 ------------=_1658330283-17719-11-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55963: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-7-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55963 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55963@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330284-17719-13" This is a multi-part message in MIME format... ------------=_1658330284-17719-13 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 7/9] gnu: Add node-minimist. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55963@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330284-17719-13 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330284-17719-13 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:46 +0000 Received: from localhost ([127.0.0.1]:32973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13CA-0002sf-Bw for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:53340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C4-0002rQ-3A for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C3-0008H4-N3 for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from 1.mo560.mail-out.ovh.net ([46.105.63.121]:35255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C1-00020G-BT for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from player746.ha.ovh.net (unknown [10.109.143.175]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id A224622D0F for ; Tue, 14 Jun 2022 09:50:35 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 51C061E2E0C39; Tue, 14 Jun 2022 09:50:33 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S0030a31c601-ae5f-43f0-99f6-5c230d6da360, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 7/9] gnu: Add node-minimist. Date: Tue, 14 Jun 2022 11:49:52 +0200 Message-Id: <20220614094954.15197-7-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6479272492321792738 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedt Received-SPF: pass client-ip=46.105.63.121; envelope-from=ngraves@ngraves.fr; helo=1.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-minimist): New variable. --- gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index aa838108ad..8ec014eee8 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -208,6 +208,36 @@ (define-public node-mersenne random number generator.") (license license:bsd-3))) +(define-public node-minimist + (package + (name "node-minimist") + (version "1.2.6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/substack/minimist") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0mxj40mygbiy530wskc8l28wxb6fv3f8vrhpwjgprymhpgbaac7d")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (home-page "https://github.com/substack/minimist") + (synopsis "Quickly scan for CLI flags and arguments in Javascript") + (description "This package allows to Quickly scan for CLI flags and +arguments in Javascript.") + (license license:expat))) + (define-public node-oop ;; No releases, last commit was February 2013. (let ((commit "f9d87cda0958886955c14a0a716e57021ed295dc") -- 2.36.1 ------------=_1658330284-17719-13-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55964: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-2-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55964 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55964@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330284-17719-15" This is a multi-part message in MIME format... ------------=_1658330284-17719-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 2/9] gnu: Add node-yazl. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55964@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330284-17719-15 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330284-17719-15 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:47 +0000 Received: from localhost ([127.0.0.1]:32975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13CA-0002sn-Lw for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:53342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C4-0002rR-3U for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C2-0008Gz-BR for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:39 -0400 Received: from 9.mo575.mail-out.ovh.net ([46.105.78.111]:40247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13Bx-0001yy-Ui for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:38 -0400 Received: from player746.ha.ovh.net (unknown [10.109.156.39]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 97AE624B02 for ; Tue, 14 Jun 2022 09:50:23 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id 22D9A1E2E0B46; Tue, 14 Jun 2022 09:50:21 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003610081d2-df22-4625-b83c-c0d42a5eda62, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 2/9] gnu: Add node-yazl. Date: Tue, 14 Jun 2022 11:49:47 +0200 Message-Id: <20220614094954.15197-2-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6475894790966797026 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehjeeh Received-SPF: pass client-ip=46.105.78.111; envelope-from=ngraves@ngraves.fr; helo=9.mo575.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-yazl): New variable. --- gnu/packages/node-xyz.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index be37d627cf..af3745f601 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -1335,3 +1335,36 @@ (define-public node-serialport accessing serial ports. This package is the recommended entry point for most projects. It combines a high-level Node.js stream interface with a useful default set of parsers and bindings."))) + +(define-public node-yazl + (package + (name "node-yazl") + (version "2.5.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/thejoshwolfe/yazl") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (inputs (list node-buffer-crc32)) + (home-page "https://github.com/thejoshwolfe/yazl") + (synopsis "Yet another zip library for node") + (description "This package provides a zip library for Node. It follows the following principles: +Don't block the JavaScript thread. Use and provide async APIs. +Keep memory usage under control. Don't attempt to buffer entire files in RAM at once. +Prefer to open input files one at a time than all at once. ") + (license license:expat))) -- 2.36.1 ------------=_1658330284-17719-15-- From unknown Sat Sep 06 08:35:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#55965: closed (Re: Updated series) Message-ID: References: <87zgh3n7a7.fsf@gnu.org> <20220614094954.15197-8-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 55965 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55965@debbugs.gnu.org Date: Wed, 20 Jul 2022 15:18:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1658330284-17719-17" This is a multi-part message in MIME format... ------------=_1658330284-17719-17 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55966: [PATCH 8/9] gnu: Add node-crx3. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55965@debbugs.gnu.org. --=20 55966: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55966 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1658330284-17719-17 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55966-done) by debbugs.gnu.org; 20 Jul 2022 15:17:07 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRd-0004ZR-8Q for submit@debbugs.gnu.org; Wed, 20 Jul 2022 11:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEBRa-0004Z8-DD for 55966-done@debbugs.gnu.org; Wed, 20 Jul 2022 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0003mt-Ur; Wed, 20 Jul 2022 11:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/or2by+wRHt+ScwOz6oiKzFn1YuS7D2rDFsPS75ZIm0=; b=YaZDLM5tj4v+vkJxGgbT +dplunuy4hLPfkDzPA2xJxdBtbldF0xGsLxx+tA641ELJNBQ4RSdIJlPjzRYYIueZHvP6EUFWch1c +UQePqqD/1dZ7cgZuFRbk2J7J0YqFfc11nWzITYa0ubq83M4iVF9JMOyiJt8mv73jH+2ewe4LIviI N1r8MIIJDTgndwmcpCIAlXQryuW4wRQhptr9SKalVie/o5k+GmHnzZiFBY7vw2X365W2JWokyEIik YRuvnpAT1PlhPuG9KUDKZ1oDC9X9rIu9hQ2+66d1aEQ+K0cdqdHHbAq0KQM5TyF6Lvnye0P+b4aiq hne6OODKvFkgQg==; Received: from [2001:4652:9717:0:52eb:71ff:fe49:3a13] (port=52830 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBRT-0002KQ-F2; Wed, 20 Jul 2022 11:16:51 -0400 From: Marius Bakke To: Nicolas Graves , 55966-done@debbugs.gnu.org Subject: Re: Updated series In-Reply-To: <875yjsawom.fsf@ngraves.fr> References: <875yjsawom.fsf@ngraves.fr> Date: Wed, 20 Jul 2022 17:16:48 +0200 Message-ID: <87zgh3n7a7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55966-done Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves skriver: > Hi Marius, > > Sorry for the time it took me, here's the updated series. No worries, thanks a lot for this work. > Everything has been checked with guix lint. I use emacs, but couldn't get= guix > style to work the way you counselled, hope it's ok. What was the issue? :-) I ran 'guix style' for each since I had to edit the commits anyway to get the author right (for some reason it showed up as "Nicolas Graves via Guix-patches " -- NYF!). > Also thanks for your advice!=20 :-) Some more advice for future pull requests, please first send a message to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything, although often a 'git format-patch --cover-letter'). Then send the patch series to NNNNN@debbugs.gnu.org, otherwise the patches will be scattered across different issues and difficult to track. Also, use "-n" with send-email/format-patch so that the ordering is preserved. It was lacking in the second series, but I used the information from the first round to get it right. Anyway, great work, pushed as c8f33b613e..cda3de3b7d! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYtgcYA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfkhQEApnu+gvniJodoVSEGCvOCqohHxhsuWyKo2eD9 OdQtYuQA/jzNb4PjbOq1gn1JJlq6yFQziUr9i3Vy2W7CIKloCBcG =YG2K -----END PGP SIGNATURE----- --=-=-=-- ------------=_1658330284-17719-17 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2022 09:50:47 +0000 Received: from localhost ([127.0.0.1]:32977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13CB-0002su-2d for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:53458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o13C6-0002sA-LB for submit@debbugs.gnu.org; Tue, 14 Jun 2022 05:50:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C6-0008NY-BV for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:42 -0400 Received: from 3.mo560.mail-out.ovh.net ([46.105.58.226]:58849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o13C3-00020y-MH for guix-patches@gnu.org; Tue, 14 Jun 2022 05:50:42 -0400 Received: from player746.ha.ovh.net (unknown [10.110.208.120]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 19FA224961 for ; Tue, 14 Jun 2022 09:50:38 +0000 (UTC) Received: from ngraves.fr (unknown [176.166.159.77]) (Authenticated sender: ngraves@ngraves.fr) by player746.ha.ovh.net (Postfix) with ESMTPSA id B00F31E2E0C78; Tue, 14 Jun 2022 09:50:35 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-109S003c01fc50b-f414-4fe4-8234-6cb4d53ae47c, F2255CAF11B24C4280F910282C1ED9962B83CC59) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.166.159.77 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH 8/9] gnu: Add node-crx3. Date: Tue, 14 Jun 2022 11:49:53 +0200 Message-Id: <20220614094954.15197-8-ngraves@ngraves.fr> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6480116916077781730 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudduledgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpudejiedrudeiiedrudehledrjeejnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejgeeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedt Received-SPF: pass client-ip=46.105.58.226; envelope-from=ngraves@ngraves.fr; helo=3.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/node-xyz.scm (node-crx3): New variable. --- gnu/packages/node-xyz.scm | 40 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm index 8ec014eee8..79594856f1 100644 --- a/gnu/packages/node-xyz.scm +++ b/gnu/packages/node-xyz.scm @@ -109,6 +109,46 @@ (define-public node-color-name "This package provides a JSON list with color names and their values.") (license license:expat))) +(define-public node-crx3 + (package + (name "node-crx3") + (version "1.1.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ahwayakchih/crx3") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1snqyw8c3s9p2clhqh1172z0rs1was36sfxkk6acgpar32c2rwzw")))) + (build-system node-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'check) + (add-after 'unpack 'replace-mri-by-minimist + (lambda _ + (substitute* "package.json" + (("\"mri\": \"\\^1.1.6\",") "\"minimist\": \"^1.2.6\",")) + (substitute* "lib/configuration.js" + (("mri") "minimist")) + #t)) + (replace 'configure + (lambda* (#:key inputs #:allow-other-keys) + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") + "--offline" "--ignore-scripts" "install" "--production") + #t))))) + (inputs (list node-minimist node-pbf node-yazl)) + (home-page "https://github.com/ahwayakchih/crx3") + (synopsis "Create web extension files for Chromium and all other browsers +supporting the file format and API") + (description "This package creates web extension files (CRXv3) for Chromium +versions 64.0.3242 and above and all other browsers supporting the file format +and API.") + (license license:bsd-3))) + (define-public node-env-variable (package (name "node-env-variable") -- 2.36.1 ------------=_1658330284-17719-17--