From unknown Mon Jun 23 18:31:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55938: [PATCH] bindat (strz): Error on null byte if packing variable-length string Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 05:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 55938@debbugs.gnu.org Cc: monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Received: via spool by submit@debbugs.gnu.org id=B.165509930923753 (code B ref -1); Mon, 13 Jun 2022 05:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2022 05:48:29 +0000 Received: from localhost ([127.0.0.1]:56917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0cw9-0006B3-4B for submit@debbugs.gnu.org; Mon, 13 Jun 2022 01:48:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:44698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0cw6-0006Au-LH for submit@debbugs.gnu.org; Mon, 13 Jun 2022 01:48:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0cw5-0006M3-OV for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 01:48:26 -0400 Received: from spork.scientician.org ([66.228.35.160]:57036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0cw3-00017n-P2 for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 01:48:25 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 8205248524 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655099301; bh=cehboZnqunnf3mtXtfmIrRLeAg9ULdDj7x0Dqect6zM=; h=Date:To:From:Subject:From; b=shipdWwvVCVHmDTt7McBMHICNT8U99IiNrNXh1PZCcwO0GefUp9ulvuMAvF4F0tm4 ZyshSpLEcqbLv/zkcblRT5v/t+o37DBKwi/IPiHqMIIJ2nWnGWAmxU1fuTwjPrpY6a RDPfeq69c6X/iSh8wlE/ODOHuXSB6/qAgmDuxc7s= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 7E37D201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655099297; bh=cehboZnqunnf3mtXtfmIrRLeAg9ULdDj7x0Dqect6zM=; h=Date:To:From:Subject:From; b=tsSrj2rNyBrM0Wa3QW+m/Fa1HY8o1PdpdUAcdcw65aM2X0Y6hm5lqPlzgBM637aLT Wr9gj96q67e1nD31CXEmXNpb84k2i0QZav6qtkcu77y+RVnD0oUXQzkCxHJ4GKVi7C dH+C6fTI/gzb5/axrJz/DTdx5PVZLPDEXUKjISyM= Message-ID: Date: Mon, 13 Jun 2022 01:48:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US From: Richard Hansen Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------C0SqGwOw2mtuIe58fkp62hRV" Received-SPF: pass client-ip=66.228.35.160; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------C0SqGwOw2mtuIe58fkp62hRV Content-Type: multipart/mixed; boundary="------------0R7mrR9iXsgoNpAAykoS1G1Y"; protected-headers="v1" From: Richard Hansen To: bug-gnu-emacs@gnu.org Message-ID: Subject: [PATCH] bindat (strz): Error on null byte if packing variable-length string --------------0R7mrR9iXsgoNpAAykoS1G1Y Content-Type: multipart/mixed; boundary="------------9Y9lhGxKTmA4kjhLVP86yxYY" --------------9Y9lhGxKTmA4kjhLVP86yxYY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 WC1EZWJidWdzLUNDOiBtb25uaWVyQGlyby51bW9udHJlYWwuY2ENCg0KQXR0YWNoZWQgcGF0 Y2g6DQoNCiogbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCAoc3Ryeik6IFNpZ25hbCBhbiBl cnJvciBpZiBhIG51bGwgYnl0ZSBpcw0KZW5jb3VudGVyZWQgd2hpbGUgcGFja2luZyBhIHN0 cmluZyB0byBhIHZhcmlhYmxlLWxlbmd0aCBzdHJ6IGZpZWxkLg0KKiB0ZXN0L2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgKHN0cnopOiBBZGQgdGVzdHMuDQo= --------------9Y9lhGxKTmA4kjhLVP86yxYY Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-strz-Error-on-null-byte-if-packing-variable-l.patch" Content-Disposition: attachment; filename*0="0001-bindat-strz-Error-on-null-byte-if-packing-variable-l.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmOWY5MzE4MzUwMGFlYzNhMmJmMzFiYTEyNjgzODYxZDcyOTVkNWIyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogTW9uLCA2IEp1biAyMDIyIDAwOjUyOjIxIC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gYmluZGF0IChzdHJ6KTogRXJyb3Igb24gbnVsbCBieXRlIGlmIHBhY2tpbmcgdmFy aWFibGUtbGVuZ3RoCiBzdHJpbmcKCiogbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCAoc3Ry eik6IFNpZ25hbCBhbiBlcnJvciBpZiBhIG51bGwgYnl0ZSBpcwplbmNvdW50ZXJlZCB3aGls ZSBwYWNraW5nIGEgc3RyaW5nIHRvIGEgdmFyaWFibGUtbGVuZ3RoIHN0cnogZmllbGQuCiog dGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChzdHJ6KTogQWRkIHRlc3Rz LgotLS0KIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgICAgICAgICAgICB8IDUgKysrKysK IHRlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbCB8IDcgKysrKysrLQogMiBm aWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9iaW5k YXQuZWwKaW5kZXggMmQ2NTg5YjUyZC4uZTY3NDBjYjZlOCAxMDA2NDQKLS0tIGEvbGlzcC9l bWFjcy1saXNwL2JpbmRhdC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCkBA IC00NDQsNiArNDQ0LDExIEBAIGJpbmRhdC0tcGFjay1zdHJ6CiAgIChsZXQqICgodiAoc3Ry aW5nLXRvLXVuaWJ5dGUgdikpCiAgICAgICAgICAobGVuIChsZW5ndGggdikpKQogICAgIChk b3RpbWVzIChpIGxlbikKKyAgICAgIChpZiAoPSAoYXJlZiB2IGkpIDApCisgICAgICAgICAg OzsgQWx0ZXJuYXRpdmVseSB3ZSBjb3VsZCBwcmV0ZW5kIHRoYXQgdGhpcyB3YXMgdGhlIGVu ZCBvZgorICAgICAgICAgIDs7IHRoZSBzdHJpbmcgYW5kIHN0b3AgcGFja2luZywgYnV0IHRo ZW4gYmluZGF0LWxlbmd0aCB3b3VsZAorICAgICAgICAgIDs7IG5lZWQgdG8gc2NhbiB0aGUg aW5wdXQgc3RyaW5nIGxvb2tpbmcgZm9yIGEgbnVsbCBieXRlLgorICAgICAgICAgIChlcnJv ciAiTnVsbCBieXRlIGVuY291bnRlcmVkIGluIGlucHV0IHN0cnogc3RyaW5nIikpCiAgICAg ICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggaSkgKGFyZWYgdiBpKSkpCiAgICAg KHNldHEgYmluZGF0LWlkeCAoKyBiaW5kYXQtaWR4IGxlbiAxKSkpKQogCmRpZmYgLS1naXQg YS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwKaW5kZXggOGJiM2JhYTQ4NS4uN2QxMjMzZGVkNyAx MDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbApAQCAtMjQwLDcgKzI0MCwx MiBAQCBiaW5kYXQtdGVzdC0tc3RyLXN0cnotbXVsdGlieXRlCiAKICAgKGVydC1kZWZ0ZXN0 IGJpbmRhdC10ZXN0LS1zdHJ6LXZhcmxlbi1wYWNrICgpCiAgICAgKHNob3VsZCAoZXF1YWwg KGJpbmRhdC1wYWNrIHNwZWMgIiIpICJcMCIpKQotICAgIChzaG91bGQgKGVxdWFsIChiaW5k YXQtcGFjayBzcGVjICJhYmMiKSAiYWJjXDAiKSkpCisgICAgKHNob3VsZCAoZXF1YWwgKGJp bmRhdC1wYWNrIHNwZWMgImFiYyIpICJhYmNcMCIpKQorICAgIDs7IE51bGwgYnl0ZXMgaW4g dGhlIGlucHV0IHN0cmluZyBicmVhayB1bnBhY2tpbmcuCisgICAgKHNob3VsZC1lcnJvciAo YmluZGF0LXBhY2sgc3BlYyAiXDAiKSkKKyAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFj ayBzcGVjICJcMHgiKSkKKyAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFjayBzcGVjICJ4 XDAiKSkKKyAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFjayBzcGVjICJ4XDB5IikpKQog CiAgIChlcnQtZGVmdGVzdCBiaW5kYXQtdGVzdC0tc3Ryei12YXJsZW4tdW5wYWNrICgpCiAg ICAgKHNob3VsZCAoZXF1YWwgKGJpbmRhdC11bnBhY2sgc3BlYyAiXDAiKSAiIikpCi0tIAoy LjM2LjEKCg== --------------9Y9lhGxKTmA4kjhLVP86yxYY-- --------------0R7mrR9iXsgoNpAAykoS1G1Y-- --------------C0SqGwOw2mtuIe58fkp62hRV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKmz5wACgkQ0GvrRa1X 4hQUZRAAhIJDvEk+JZ8ecLzjb1enPI/78YH4irtkPeJ04ph8J84zLhjCWkfNW92X mBHNoqoCfUK2oYNSXzMD6n6IzQB2LSmr0yAUpZmM74kzc8AfdBaCXDbVr8FrzKmY Hb/i62Zd6DUDT2/jM2a46oPVwbPSLwVV7UfBTAxkG2pwh1P/cwo5s0B4K8THwIjY w9BHrvZFdQBeoA1HtB99SOcU7D+UNF1RoHqi/N2dXUyffTa0v+bZrKZVyzfelNAy AZvj5U/GPS62D4tq7DEhsQx24POq9mKSXMultQG8cKGXm4ljM7u4xHQI0Ta3PVlE /9gsGqO/zzhNveeyTyUo9utQgiyP4Vtfk8D9GGz9ERVMN0WmvwKlqY99elZO170H wlslM71tT8gU9fjMtfpUDGWy7y/57CY7Zb4LOvFrLAp2Ooal8CYk7/btFJD3jORo b1+/Jcna4VjoihkahQcXW2rcVeeX0mJb+4RAw6CHdLtzLPQvKCnNJOptmgYKKZY2 160G9CLAGeVCiX8nzA9vCOeoSoKSAd4XVNP3JHEhjmhj1J39AaQy7cSx9ISXKCay WzsVs1oeEoI+EeyReC186toMEmxVs4RD61HZMXFOXKeDYFfMq88fGh8ivj2CLpZL iz138G874uzfsLxSfx9b2HPC9AR4zJSLZ2oRf3GYRyt9Jsf/tFE= =WWZY -----END PGP SIGNATURE----- --------------C0SqGwOw2mtuIe58fkp62hRV-- From unknown Mon Jun 23 18:31:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55938: [PATCH] bindat (strz): Error on null byte if packing variable-length string Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Richard Hansen Cc: 55938@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 55938-submit@debbugs.gnu.org id=B55938.165512356326421 (code B ref 55938); Mon, 13 Jun 2022 12:33:02 +0000 Received: (at 55938) by debbugs.gnu.org; 13 Jun 2022 12:32:43 +0000 Received: from localhost ([127.0.0.1]:57506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jFK-0006s4-OS for submit@debbugs.gnu.org; Mon, 13 Jun 2022 08:32:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jFH-0006rj-4T for 55938@debbugs.gnu.org; Mon, 13 Jun 2022 08:32:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c5MtZlpyyDs25+Ca3IxJtYwk3LYqpIbKMT9eWwOnuvE=; b=LyIO331xb7kzXXizMqFdqOpATa J7WdyATQzpvAxuhM6llDJWHF4L+6wMB+MsbZ3dEeNi2HKFpCx2nL3lAIjmfk40o6pP2H+K0QoR0Dp repQ8Ril5RZxSx1y3r3iRCUOaEvOGYfPc2IisWC4IfKcABGil1y50SEzQ9sjzOmfyado=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0jF6-0008GV-D3; Mon, 13 Jun 2022 14:32:30 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Marsheaux - Ghost's _Ni d'eve, ni d'adam_: "Hammer" Date: Mon, 13 Jun 2022 14:32:27 +0200 In-Reply-To: (Richard Hansen's message of "Mon, 13 Jun 2022 01:48:11 -0400") Message-ID: <87sfo8n3qc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Richard Hansen writes: > * lisp/emacs-lisp/bindat.el (strz): Signal an error if a null byte is > encountered while packing a string to a variable-length strz field. > * test/lisp/emacs-lisp/bindat-tests.el (strz): Add tests [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Richard Hansen writes: > * lisp/emacs-lisp/bindat.el (strz): Signal an error if a null byte is > encountered while packing a string to a variable-length strz field. > * test/lisp/emacs-lisp/bindat-tests.el (strz): Add tests. Thanks; pushed to Emacs 29. (But I changed the `if' to a `when'.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 08:32:46 2022 Received: (at control) by debbugs.gnu.org; 13 Jun 2022 12:32:46 +0000 Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jFN-0006sL-W0 for submit@debbugs.gnu.org; Mon, 13 Jun 2022 08:32:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jFK-0006ro-OX for control@debbugs.gnu.org; Mon, 13 Jun 2022 08:32:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5o9DMWjcbOHn8anjLcRZpFn4ABi8Lsuc+zodg0a7Xhc=; b=Pk4Mhnj9IG6HAvXDfNYpz/k3KI /f2ou2ftEAKbqXwvhWOeQl07b7Ys9eh/zGdO8I0l2igMwvaVNJ+cD5+dmljWxpzbFWX3FM9NCubFb VspZN6tYdmQwByZZB24h2FC5FRUssD4oqZcier9hiV64zUP7vQlk+WcSSIW+6Ci5TL8A=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0jFC-0008Gc-P3 for control@debbugs.gnu.org; Mon, 13 Jun 2022 14:32:36 +0200 Date: Mon, 13 Jun 2022 14:32:33 +0200 Message-Id: <87r13sn3q6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #55938 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 55938 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 55938 29.1 quit From unknown Mon Jun 23 18:31:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55938: [PATCH] bindat (strz): Error on null byte if packing variable-length string Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Richard Hansen Cc: 55938@debbugs.gnu.org Received: via spool by 55938-submit@debbugs.gnu.org id=B55938.165512595415040 (code B ref 55938); Mon, 13 Jun 2022 13:13:02 +0000 Received: (at 55938) by debbugs.gnu.org; 13 Jun 2022 13:12:34 +0000 Received: from localhost ([127.0.0.1]:57600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jrt-0003uW-Ul for submit@debbugs.gnu.org; Mon, 13 Jun 2022 09:12:34 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jrt-0003uJ-1o for 55938@debbugs.gnu.org; Mon, 13 Jun 2022 09:12:33 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4BA4B8079A; Mon, 13 Jun 2022 09:12:27 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4FC028035A; Mon, 13 Jun 2022 09:12:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655125945; bh=sHhPU3IjmtMl56BHbpfe9i+Ub/mp/GIx+wjw6ueceps=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=W+fNdJHRf0L5H69stBLyBG+VcbNpa49tOWDM3uEcLYTz6b6raKC2h6oIp33/FKrTB n2k7HE3qAzTn29CUYB0BCxl6WBTtjmySohO3n37nCRvvZzxGRf1kWfOlN1m2mo6My6 xtFtuRvsJJGn6NU2YwWZA1uG0h88N4zTRdlcudf3LI+5TsevCWLpg6LtkDz7LSpedJ zvaO6rnN6CrNDzo+CLmBcsAVFuu4PbDtb4Vo29l65MpoERRchbSJvcqVnEkcY5t7py 2MkYY8GVwSOyzuNOsD62x4PMl95Dwi12C8m+BlJGB9TlCHVchY71Sdy2qocCPRDCta s475E+9Ll20kQ== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C50171204D7; Mon, 13 Jun 2022 09:12:24 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Mon, 13 Jun 2022 09:12:20 -0400 In-Reply-To: (Richard Hansen's message of "Mon, 13 Jun 2022 01:48:11 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (let* ((v (string-to-unibyte v)) > (len (length v))) > (dotimes (i len) > + (if (= (aref v i) 0) > + ;; Alternatively we could pretend that this was the end of > + ;; the string and stop packing, but then bindat-length would > + ;; need to scan the input string looking for a null byte. > + (error "Null byte encountered in input strz string")) I suspect a `string-match` looking for NUL would be faster. Stefan