GNU bug report logs - #55938
[PATCH] bindat (strz): Error on null byte if packing variable-length string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55938 in the body.
You can then email your comments to 55938 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] bindat (strz): Error on null byte if packing variable-length
 string
Date: Mon, 13 Jun 2022 01:48:11 -0400

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: monnier <at> iro.umontreal.ca

Attached patch:

* lisp/emacs-lisp/bindat.el (strz): Signal an error if a null byte is
encountered while packing a string to a variable-length strz field.
* test/lisp/emacs-lisp/bindat-tests.el (strz): Add tests.

[0001-bindat-strz-Error-on-null-byte-if-packing-variable-l.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 55938 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 55938 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#55938: [PATCH] bindat (strz): Error on null byte if packing
 variable-length string
Date: Mon, 13 Jun 2022 14:32:27 +0200

Richard Hansen <rhansen <at> rhansen.org> writes:

> * lisp/emacs-lisp/bindat.el (strz): Signal an error if a null byte is
> encountered while packing a string to a variable-length strz field.
> * test/lisp/emacs-lisp/bindat-tests.el (strz): Add tests.

Thanks; pushed to Emacs 29.  (But I changed the `if' to a `when'.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 55938 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 55938 <at> debbugs.gnu.org
Subject: Re: bug#55938: [PATCH] bindat (strz): Error on null byte if packing
 variable-length string
Date: Mon, 13 Jun 2022 09:12:20 -0400

>    (let* ((v (string-to-unibyte v))
>           (len (length v)))
>      (dotimes (i len)
> +      (if (= (aref v i) 0)
> +          ;; Alternatively we could pretend that this was the end of
> +          ;; the string and stop packing, but then bindat-length would
> +          ;; need to scan the input string looking for a null byte.
> +          (error "Null byte encountered in input strz string"))

I suspect a `string-match` looking for NUL would be faster.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.