From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 20:21:37 2022 Received: (at submit) by debbugs.gnu.org; 13 Jun 2022 00:21:37 +0000 Received: from localhost ([127.0.0.1]:56711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Xpo-0001yY-Gs for submit@debbugs.gnu.org; Sun, 12 Jun 2022 20:21:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:38600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0WWs-0008Q7-Og for submit@debbugs.gnu.org; Sun, 12 Jun 2022 18:58:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0WWq-0006pA-K2 for bug-guix@gnu.org; Sun, 12 Jun 2022 18:57:58 -0400 Received: from qs51p00im-qukt01080102.me.com ([17.57.155.19]:57203) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0WWo-0000N8-Bs for bug-guix@gnu.org; Sun, 12 Jun 2022 18:57:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=laratel.li; s=sig1; t=1655074671; bh=rDNk1CyUmhOM04z+uz9o3Kd3zTj8V+hutFo4UDAOD5M=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=hGAS3WdTi4vsMzbeMnu0ZWmEAhXsSImeRQ9QUAPB8LZ6bqaBhUx/+e5JraRx4Yif5 tOasrupYj4zX0Av4jl1EpIxT91OKOx+yx75MT2+Cx/Jp4ROtRh47uxFh12vU55ubK5 LqPykPmL3N49oTUEG6NmaM8Z8R0wpJWs3tV3PoieWXC/mhUd7NwEZ25GBfiq8lHCJa kEJVN4OLT5xGDTOjXj2uA3mEcEO6V6x60qYPWD78kfU8cszLGu+M63Q9rPIco+V2Nb X9VyyWjfArQvLlW3JqZUg4lDMMhRS9we2aNOKKgX+NIUk5QvhA3ICAKA/JCFdM+gJO N3G2g1s/s5QXg== Received: from localhost (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01080102.me.com (Postfix) with ESMTPSA id 006311CC0118 for ; Sun, 12 Jun 2022 22:57:49 +0000 (UTC) From: Luciano Laratelli To: bug-guix@gnu.org Subject: dockerd fails to start on boot Date: Sun, 12 Jun 2022 18:56:38 -0400 User-agent: mu4e 1.6.11; emacs 28.1.50 Message-ID: <87h74pa3rp.fsf@kong.network> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-=-=" X-Proofpoint-ORIG-GUID: g8HBIKMeMDjT0tJslj7xaKuoitFCxLQR X-Proofpoint-GUID: g8HBIKMeMDjT0tJslj7xaKuoitFCxLQR X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.790,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-12=5F02:2020-02-14=5F02,2022-01-12=5F02,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=593 bulkscore=0 clxscore=1030 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2206120109 Received-SPF: pass client-ip=17.57.155.19; envelope-from=luciano@laratel.li; helo=qs51p00im-qukt01080102.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 12 Jun 2022 20:21:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, hope you are doing well. I=E2=80=99m running Guix System and am seeing that `dockerd' fails to start= on boot due to not being able to find `containerd': $ sudo tail /var/log/docker.log 2022-06-12 18:25:29 time=3D=E2=80=9C2022-06-12T18:25:29.969005384-04:00=E2= =80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic oper= ation, key modified) deleting object [endpoint 062e6856b7776daf35f1d570dc7e= 055d3c0f3eefc0f58c5e279eba20035c8e9e eb10082295c7a53d882e36d93a8b5eb20e980a= 5950c4a67fa03444274448b232], retrying=E2=80=A6.=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.068910364-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CRemoving stale sandbox e35667a7ef1441bce= d213cf035efc9d6c71a0dce7f8941e3fbb63f5a27265bca (91314e5594f72585f9df121ba1= 6cc8d67c4e1fcb91fc3c7b9b0660aed1b3054a)=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.080685302-04:00=E2= =80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic oper= ation, key modified) deleting object [endpoint 062e6856b7776daf35f1d570dc7e= 055d3c0f3eefc0f58c5e279eba20035c8e9e 825f4a6f68b1b81b24b2edc0b382deca116e72= a75e6207036f24e18ba6434c81], retrying=E2=80=A6.=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.143624227-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDefault bridge (docker0) is assigned wit= h an IP address 172.17.0.0/16. Daemon option =E2=80=93bip can be used to se= t a preferred IP address=E2=80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.400700443-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CLoading containers: done.=E2=80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.689183684-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDocker daemon=E2=80=9D commit=3Dv19.03.1= 5 graphdriver(s)=3Doverlay2 version=3D19.03.15-ce 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.691171101-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDaemon has completed initialization=E2= =80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.961049886-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CAPI listen on /var/run/docker.sock=E2=80= =9D 2022-06-12 18:43:43 time=3D=E2=80=9C2022-06-12T18:43:43.503118343-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CStarting up=E2=80=9D 2022-06-12 18:43:43 failed to start containerd: exec: =E2=80=9Ccontainerd= =E2=80=9D: executable file not found in $PATH $ sudo docker ps Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the = docker daemon running? $ sudo herd status dockerd Status of dockerd: It is stopped. It is enabled. Provides (dockerd). Requires (containerd dbus-system elogind file-system-/sys/fs/cgroup/blkio= file-system-/sys/fs/cgroup/cpu file-system-/sys/fs/cgroup/cpuset file-syst= em-/sys/fs/cgroup/devices file-system-/sys/fs/cgroup/memory file-system-/sy= s/fs/cgroup/pids networking udev). Conflicts with (). Will be respawned. I can start it myself, though: $ sudo herd start dockerd Service dockerd has been started. I found a [past issue] on this list with someone experiencing a similar pro= blem, but adding `kmod' as suggested did not resolve the issue on my end.. Here=E2=80=99s my config.scm - I=E2=80=99ve redcated my host name and file-= system/swap-devices blocks, but everything else is verbatim what the machine is running. (use-modules (gnu) (nongnu packages linux) (nongnu system linux-initrd)) (use-service-modules desktop networking ssh xorg docker) (operating-system (kernel linux) (firmware (list linux-firmware)) (initrd microcode-initrd) (locale =E2=80=9Cen_US.utf8=E2=80=9D) (timezone =E2=80=9CAmerica/New_York=E2=80=9D) (keyboard-layout (keyboard-layout =E2=80=9Cus=E2=80=9D)) (users (cons* (user-account (name =E2=80=9Cluciano=E2=80=9D) (comment =E2=80=9CLuciano Laratelli=E2=80=9D) (group =E2=80=9Cusers=E2=80=9D) (home-directory =E2=80=9C/home/luciano=E2=80=9D) (supplementary-groups =E2=80=99(=E2=80=9Cwheel=E2=80=9D =E2=80=9Cnetdev=E2=80=9D = =E2=80=9Caudio=E2=80=9D =E2=80=9Cvideo=E2=80=9D))) %base-user-accounts)) (packages (append (list (specification->package =E2=80=9Cst=E2=80=9D) (specification->package =E2=80=9Cnss-certs=E2=80=9D) (specification->package =E2=80=9Cdocker=E2=80=9D) (specification->package =E2=80=9Cdocker-compose=E2=80=9D) (specification->package =E2=80=9Ccontainerd=E2=80=9D) (specification->package =E2=80=9Ckmod=E2=80=9D) (specification->package =E2=80=9Cvim=E2=80=9D) (specification->package =E2=80=9Cemacs-no-x-toolkit=E2=80=9D) (specification->package =E2=80=9Cparted=E2=80=9D)) %base-packages)) (services (append (list (service openssh-service-type (openssh-configuration (password-authentication? #f))) (service network-manager-service-type) (service wpa-supplicant-service-type) (service docker-service-type) (elogind-service) (set-xorg-configuration (xorg-configuration (keyboard-layout keyboard-layout)))) (modify-services %base-services (guix-service-type config =3D> (guix-configuration (inherit config) (substitute-urls (append (list "=E2=80=9D) %default-substitute-urls)) (authorized-keys (append (list (plain-file =E2=80=9Csigning-key.pub=E2=80=9D =E2=80=9C (public-key (ecc (curve Ed25519) (q #C1FD53E5D4CE971933EC50C9F307AE2171A2D3B52C804642A7= A35F84F3A4EA98#) ) )=E2=80=9D)) %default-authorized-guix-keys))))))) (bootloader (bootloader-configuration (bootloader grub-efi-bootloader) (targets =E2=80=99(=E2=80=9C/boot/efi=E2=80=9D)) (keyboard-layout keyboard-layout)))) I=E2=80=99m not sure how to debug this issue any further and would apprecia= te some pointers there. Thank you, Luciano [past issue] --=-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable

Hi, hope you are doing well.

I=E2=80=99m running Guix System and am seeing that docke= rd fails to start on boot due to not being able to find containerd:

$ sudo tail /var/log/docker.log 2022-06-12 18:25:29 time=3D=E2=80=9C2022-06-12T18:25:29.969005384-04:00=E2= =80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic oper= ation, key modified) deleting object [endpoint 062e6856b7776daf35f1d570dc7e= 055d3c0f3eefc0f58c5e279eba20035c8e9e eb10082295c7a53d882e36d93a8b5eb20e980a= 5950c4a67fa03444274448b232], retrying=E2=80=A6.=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.068910364-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CRemoving stale sandbox e35667a7ef1441bce= d213cf035efc9d6c71a0dce7f8941e3fbb63f5a27265bca (91314e5594f72585f9df121ba1= 6cc8d67c4e1fcb91fc3c7b9b0660aed1b3054a)=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.080685302-04:00=E2= =80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic oper= ation, key modified) deleting object [endpoint 062e6856b7776daf35f1d570dc7e= 055d3c0f3eefc0f58c5e279eba20035c8e9e 825f4a6f68b1b81b24b2edc0b382deca116e72= a75e6207036f24e18ba6434c81], retrying=E2=80=A6.=E2=80=9D 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.143624227-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDefault bridge (docker0) is assigned wit= h an IP address 172.17.0.0/16. Daemon option =E2=80=93bip can be used to se= t a preferred IP address=E2=80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.400700443-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CLoading containers: done.=E2=80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.689183684-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDocker daemon=E2=80=9D commit=3Dv19.03.1= 5 graphdriver(s)=3Doverlay2 version=3D19.03.15-ce 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.691171101-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CDaemon has completed initialization=E2= =80=9D 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.961049886-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CAPI listen on /var/run/docker.sock=E2=80= =9D 2022-06-12 18:43:43 time=3D=E2=80=9C2022-06-12T18:43:43.503118343-04:00=E2= =80=9D level=3Dinfo msg=3D=E2=80=9CStarting up=E2=80=9D 2022-06-12 18:43:43 failed to start containerd: exec: =E2=80=9Ccontainerd= =E2=80=9D: executable file not found in $PATH

$ sudo docker ps Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the = docker daemon running?

$ sudo herd status dockerd Status of dockerd: It is stopped. It is enabled. Provides (dockerd). Requires (containerd dbus-system elogind file-system-/sys/fs/cgroup/blkio= file-system-/sys/fs/cgroup/cpu file-system-/sys/fs/cgroup/cpuset file-syst= em-/sys/fs/cgroup/devices file-system-/sys/fs/cgroup/memory file-system-/sy= s/fs/cgroup/pids networking udev). Conflicts with (). Will be respawned.

I can start it myself, though:

$ sudo herd start dockerd Service dockerd has been started.

I found a past issue on this list with someone experiencing a similar= problem, but adding kmod as suggested did not resolve the = issue on my end..

Here=E2=80=99s my config.scm - I=E2=80=99ve redcated my host name and file-= system/swap-devices blocks, but everything else is verbatim what the machine is running.

(use-modules (gnu) (nongnu packages linux) (nongnu system linux-initrd))

(use-service-modules desktop networking ssh xorg docker)

(operating-system (kernel linux) (firmware (list linux-firmware)) (initrd microcode-initrd) (locale =E2=80=9Cen_US.utf8=E2=80=9D) (timezone =E2=80=9CAmerica/New_York=E2=80=9D) (keyboard-layout (keyboard-layout =E2=80=9Cus=E2=80=9D))

(users (cons* (user-account (name =E2=80=9Cluciano=E2=80=9D) (comment =E2=80=9CLuciano Laratelli=E2=80=9D) (group =E2=80=9Cusers=E2=80=9D) (home-directory =E2=80=9C/home/luciano=E2=80=9D) (supplementary-groups =E2=80=99(=E2=80=9Cwheel=E2=80=9D =E2=80=9Cnetdev=E2=80=9D = =E2=80=9Caudio=E2=80=9D =E2=80=9Cvideo=E2=80=9D))) %base-user-accounts)) (packages (append (list (specification->package =E2=80=9Cst=E2=80=9D) (specification->package =E2=80=9Cnss-certs=E2=80=9D) (specification->package =E2=80=9Cdocker=E2=80=9D) (specification->package =E2=80=9Cdocker-compose=E2=80=9D) (specification->package =E2=80=9Ccontainerd=E2=80=9D) (specification->package =E2=80=9Ckmod=E2=80=9D) (specification->package =E2=80=9Cvim=E2=80=9D) (specification->package =E2=80=9Cemacs-no-x-toolkit=E2=80=9D) (specification->package =E2=80=9Cparted=E2=80=9D)) %base-packages)) (services (append (list (service openssh-service-type (openssh-configuration (password-authentication? #f)))

(service network-manager-service-type) (service wpa-supplicant-service-type) (service docker-service-type) (elogind-service) (set-xorg-configuration (xorg-configuration (keyboard-layout keyboard-layout)))) (modify-services %base-services (guix-service-type config =3D> (guix-configuration (inherit config) (substitute-urls (append (list "https://substitutes.nonguix.org=E2=80=9D) %default-substitute-urls)) (authorized-keys (append (list (plain-file =E2=80=9Csigning-key.pub=E2=80=9D =E2=80=9C (public-key (ecc (curve Ed25519) (q #C1FD53E5D4CE971933EC50C9F307AE2171A2D3B52C804642A7= A35F84F3A4EA98#) ) )=E2=80=9D)) %default-authorized-guix-keys))))))) (bootloader (bootloader-configuration (bootloader grub-efi-bootloader) (targets =E2=80=99(=E2=80=9C/boot/efi=E2=80=9D)) (keyboard-layout keyboard-layout))))

I=E2=80=99m not sure how to debug this issue any further and would apprecia= te some pointers there.

Thank you,

Luciano

--=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 24 01:08:47 2022 Received: (at control) by debbugs.gnu.org; 24 Jun 2022 05:08:47 +0000 Received: from localhost ([127.0.0.1]:40520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4bYl-0002Ng-3P for submit@debbugs.gnu.org; Fri, 24 Jun 2022 01:08:47 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:40612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4bYj-0002NS-Re for control@debbugs.gnu.org; Fri, 24 Jun 2022 01:08:46 -0400 Received: by mail-qk1-f182.google.com with SMTP id p21so1172783qki.7 for ; Thu, 23 Jun 2022 22:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:from:subject; bh=OtPXFQQwBawxlAqX8C8RKi+04iMM+cJ3SIB0l9Vxmx0=; b=hXAX5R9QQoZ6ccxw/I83gYwnVYArQNsPw7rm7tqpv+BccC5yxVvMhwOSKYKWnKdSbu 6zCfWJ6HmVTBq3Yh0lqZtKSFop47dfTEMhhp+HvWr7cRbJVnws8vkhfw12GhqcyMRcXW rnSz7KctfDXb1XdraP7B8+O5n8Xw8ArgiVupV3OedWjj2SOIITBBKFElfF5YQydZARjC aS4lrkEae/0x5+3tHIRGYdBonT9oj8VNj9IR0zT9+c36RcBuv/eCGhMfCgF2ra1+5Gra onD59BoHyoQ4ebQB61kMVNz8yY+w0rTQNVol6fULE8FoeTlwl1IIoLP01aOI0jHVU6+o cJcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:from:subject; bh=OtPXFQQwBawxlAqX8C8RKi+04iMM+cJ3SIB0l9Vxmx0=; b=0mKeg4/fXp8sGkGlutDLpE+PLFbZdfhQBLY0VLJD0kYKPfYHRtBGEYhTnMfujRpiwl bloBLXefW5RrYuBNxxNerrlpA3EAFpzSiGRGBJK6iIOJDoQEOAITMwqFrekBSOGsNHRr k6oPXeDxMbWdUz+ab3/TNo6nwIpT698mtmt/DT83WEtRZVwBa/Qj7FgQr4cQU5Coyk3f icrKtnsEkuwnhiiMcRYlBUiNqXAGip8B3BXWTq3ftWIo1PABAcdekOkfsGlkOq+lFu6N YqYWlfCFQFuJPH4NMONF7AFWYEFQj5Q8wFoYx8CVGoDTB4cQJrBqXMEwWv0P4HL+ZR0q uriw== X-Gm-Message-State: AJIora+6aT/9YpUAIbA0Byim6VPssTt8lfYdmig/IRYJdk9oO3CjIPRs 3zaRUwT8EaSAWtiZHBpWlkOyfKCqtP//xJ+1Qiw= X-Google-Smtp-Source: AGRyM1vg6x9mKgu8+aeuCq6w1QXFeRGD2IwZ95YyW8oWqaGUIdHnWShriKJHCEqSBtZE/Tc02TB7dg== X-Received: by 2002:a05:620a:13d6:b0:6ae:e7f9:3ccd with SMTP id g22-20020a05620a13d600b006aee7f93ccdmr8131212qkl.783.1656047320223; Thu, 23 Jun 2022 22:08:40 -0700 (PDT) Received: from hurd (dsl-158-129.b2b2c.ca. [66.158.158.129]) by smtp.gmail.com with ESMTPSA id o30-20020a05620a0d5e00b006aee8a5fa4bsm1149050qkl.43.2022.06.23.22.08.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 22:08:39 -0700 (PDT) Date: Fri, 24 Jun 2022 01:08:39 -0400 Message-Id: <87wnd6zm08.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #55936 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 55936 38432 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 24 01:12:08 2022 Received: (at 55936) by debbugs.gnu.org; 24 Jun 2022 05:12:08 +0000 Received: from localhost ([127.0.0.1]:40529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4bc0-0002Vj-Gf for submit@debbugs.gnu.org; Fri, 24 Jun 2022 01:12:08 -0400 Received: from mail-qv1-f52.google.com ([209.85.219.52]:34696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4bbw-0002VD-OC for 55936@debbugs.gnu.org; Fri, 24 Jun 2022 01:12:06 -0400 Received: by mail-qv1-f52.google.com with SMTP id t16so3187005qvh.1 for <55936@debbugs.gnu.org>; Thu, 23 Jun 2022 22:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=nNDZtLM2Fk8lvIX5rrRlUgDvAmwUHvc0swANaNnOfTQ=; b=TtFKR3vjFTqTSks2xtTqFIQFrUHfWdqnERO4QekLY8PgiM7x/+i4uxKjzqZhIaHp+V L/uZLK8LyvE2rW7uxJt9GjPwpRgG7jFjIQSGHS9mJGqnIhT+wBB5sQX5FSDd457yYVqb NGQ9SEIMt2WBbEOV0vGcqNfvNnp6u8rj27KrJREzCqica/KtZp0WtbvBDJqr6JNgsk+O BMPEKuk7zDrvf+alRZj99Ew5L1d8+tnDR5wGrTqtIor5NhVBL3Rt9NoeHgv5gr8i1/s0 4aWKcm6KaRUumb2kjMDmH5wUBj3wGbnQIF4hmC0i8jx23+U7cjX5KD96ZoQYzn/8b0WP NtqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=nNDZtLM2Fk8lvIX5rrRlUgDvAmwUHvc0swANaNnOfTQ=; b=InGK2ibQhqYApCOhUdanysldDFKIuKa3Pa6CxdOnV/zzHh07P0uvC6ZilpH4wvAvB/ Ptxd9SsKsZpAKGWfnAMie5Cjlsu4S5xgbUI+72aOmBqGN8XQAX+sOPULsaYaBx7vhQUz d6PzNcxxfl0TjgzbMRIRzMpQ+eM2nL0DHROZYgORNgeY0CWbS0ccIv22DMLqbqB3G1TP SE6IoM5hf7iG+beMz2TjQGwOaH5yNOJLchQBsUhirrTFy377j9nOWIKP1QZdsq0eKHcS +tmggpVPcHvAJFptToPioP+18a8yKB1/blAJfsmtmAGINb0jw7CDsbnbBGVgg3yzns0c svdA== X-Gm-Message-State: AJIora8UMUtIiXjwhSiVgfr7kUS+tc6iSifGRYWVuMWsuScK0PG7E+c9 aXyPinES+p4n3D3vX5GDkrw2Q5cTbr4j49fVOyE= X-Google-Smtp-Source: AGRyM1t4imdtZF5ewzvr09BP4xcQHjPFoJJw4NjfDWOWg3buK9HtPP5eUYGUtBmAAaS5UT+5D1upgQ== X-Received: by 2002:a05:622a:118f:b0:317:cb6c:8027 with SMTP id m15-20020a05622a118f00b00317cb6c8027mr150012qtk.305.1656047519078; Thu, 23 Jun 2022 22:11:59 -0700 (PDT) Received: from hurd (dsl-158-129.b2b2c.ca. [66.158.158.129]) by smtp.gmail.com with ESMTPSA id f3-20020a05622a1a0300b003173c448126sm801320qtb.57.2022.06.23.22.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 22:11:58 -0700 (PDT) From: Maxim Cournoyer To: Luciano Laratelli Subject: Re: bug#55936: dockerd fails to start on boot References: <87h74pa3rp.fsf@kong.network> Date: Fri, 24 Jun 2022 01:11:57 -0400 In-Reply-To: <87h74pa3rp.fsf@kong.network> (Luciano Laratelli's message of "Sun, 12 Jun 2022 18:56:38 -0400") Message-ID: <87sfnuzluq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55936 Cc: 55936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Luciano Laratelli writes: > Hi, hope you are doing well. > > I=E2=80=99m running Guix System and am seeing that `dockerd' fails to sta= rt on boot due to not being able to find `containerd': > > $ sudo tail /var/log/docker.log > 2022-06-12 18:25:29 time=3D=E2=80=9C2022-06-12T18:25:29.969005384-04:00= =E2=80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic o= peration, key modified) deleting object [endpoint 062e6856b7776daf35f1d570d= c7e055d3c0f3eefc0f58c5e279eba20035c8e9e eb10082295c7a53d882e36d93a8b5eb20e9= 80a5950c4a67fa03444274448b232], retrying=E2=80=A6.=E2=80=9D > 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.068910364-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CRemoving stale sandbox e35667a7ef1441= bced213cf035efc9d6c71a0dce7f8941e3fbb63f5a27265bca (91314e5594f72585f9df121= ba16cc8d67c4e1fcb91fc3c7b9b0660aed1b3054a)=E2=80=9D > 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.080685302-04:00= =E2=80=9D level=3Dwarning msg=3D=E2=80=9CError (Unable to complete atomic o= peration, key modified) deleting object [endpoint 062e6856b7776daf35f1d570d= c7e055d3c0f3eefc0f58c5e279eba20035c8e9e 825f4a6f68b1b81b24b2edc0b382deca116= e72a75e6207036f24e18ba6434c81], retrying=E2=80=A6.=E2=80=9D > 2022-06-12 18:25:30 time=3D=E2=80=9C2022-06-12T18:25:30.143624227-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CDefault bridge (docker0) is assigned = with an IP address 172.17.0.0/16. Daemon option =E2=80=93bip can be used to= set a preferred IP address=E2=80=9D > 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.400700443-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CLoading containers: done.=E2=80=9D > 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.689183684-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CDocker daemon=E2=80=9D commit=3Dv19.0= 3.15 graphdriver(s)=3Doverlay2 version=3D19.03.15-ce > 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.691171101-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CDaemon has completed initialization= =E2=80=9D > 2022-06-12 18:25:31 time=3D=E2=80=9C2022-06-12T18:25:31.961049886-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CAPI listen on /var/run/docker.sock=E2= =80=9D > 2022-06-12 18:43:43 time=3D=E2=80=9C2022-06-12T18:43:43.503118343-04:00= =E2=80=9D level=3Dinfo msg=3D=E2=80=9CStarting up=E2=80=9D > 2022-06-12 18:43:43 failed to start containerd: exec: =E2=80=9Ccontainerd= =E2=80=9D: executable file not found in $PATH It seems there's a race condition between containerd and docker (the later starts before the former is done launching and it fails to see it, aborting, if I understand). We should see if we can migrate the dockerd-service-type to use the newly introduced systemd-style constructor. Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 06:41:58 2022 Received: (at 55936) by debbugs.gnu.org; 2 Jul 2022 10:41:58 +0000 Received: from localhost ([127.0.0.1]:39890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7aZU-00047T-Qv for submit@debbugs.gnu.org; Sat, 02 Jul 2022 06:41:58 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:33751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7aZP-00046y-KR for 55936@debbugs.gnu.org; Sat, 02 Jul 2022 06:41:51 -0400 Received: by mail-lf1-f47.google.com with SMTP id a4so7840336lfm.0 for <55936@debbugs.gnu.org>; Sat, 02 Jul 2022 03:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5JClVHoelTo6PMzA+fXakvSdP+EfzOEB9jGT5rtSAzY=; b=bCLFWNWxlTAHsuL9Ry3p7iMSUMZ6Gd8utA1Wq68X4ubCFRwXryPkRQQAyyRVBjUB5h +FL8PLJYWfnv8l3bG1Uo7gMFH8oDL93qe7qn5TJe21Kpus/WejaL0eakN0HLy3bG2S4c sH6kMcrEZjvHRvZIEzygf4drpJ08KHvNY3y12NfuYL4KdY2jvrXtjpFeNWmW2CUAcROV Fq1aVTkPKr1ZoTGC/76qbjWQfgkR5DCvh20zxpCOzLFn6Ch+ugmbJ07kxT52VhQkHXtW vAn7F3k15qqoMoaVNrM36dsxfxHY1epPntHQpUwKw2HnBe5GHthrz3buDS55nRMiLwDR VrCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5JClVHoelTo6PMzA+fXakvSdP+EfzOEB9jGT5rtSAzY=; b=DNkyGL2XbUS71G1uzob3tsxImkjPnXX/H+LqsB30CVvzbNX2xRYDwf+WPPypl8+D82 WCUWLqoS5Xf42F5kCCD6LZFrpMe572CZyYaGbQ6d+NHBaAJ2kE4XIrreIsOcxnQvLbDI rtFdd6mMYPQxmurf+jLcrPM520m/aaOPwtmlfbAt2cNoXraKgDS8y+rO4pDpsOosEeKi SX/s5mhoAABzkaWilN9zvAvHgPa5rLguoDWzTuES0WcwryBFZKTCjjWLrkqoO93j3exY vZkhRxQ+6awVMHzs1oo2z5By3/Dz9g08CxaTAsGkdFcprlP4m+euejApzM0B9P4unLAO JDCw== X-Gm-Message-State: AJIora/lVCHW55RRE3y6X+TfQLmATJl+dbAjiFqIy/q2F+kVXSo2tw5f emtkk5KfLNyRJfyT+VMCnC6GRZ3hPn8= X-Google-Smtp-Source: AGRyM1veA4xflM69zsriMJ4Uo/K6HuKV7Df0dUBeLNxH4EwSUcIud6iZYqYNrOz5EKEqcI7UzAqKiQ== X-Received: by 2002:a05:6512:3b9d:b0:47f:7712:3ece with SMTP id g29-20020a0565123b9d00b0047f77123ecemr11532812lfv.127.1656758500968; Sat, 02 Jul 2022 03:41:40 -0700 (PDT) Received: from guixsd.wugi.info ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id q185-20020a2e5cc2000000b0025a891f7b8dsm3614374ljb.32.2022.07.02.03.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 03:41:40 -0700 (PDT) From: Oleg Pykhalov To: 55936@debbugs.gnu.org Subject: [PATCH] services: docker: Fix race condition. Date: Sat, 2 Jul 2022 13:41:06 +0300 Message-Id: <20220702104106.16997-1-go.wigust@gmail.com> X-Mailer: git-send-email 2.36.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55936 Cc: Oleg Pykhalov , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . * gnu/packages/patches/containerd-create-pid-file.patch: New file. * gnu/local.mk (dist_patch_DATA): Add this. * gnu/packages/docker.scm (containerd)[source]: Add this patch. * gnu/services/docker.scm (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. --- gnu/local.mk | 3 +- gnu/packages/docker.scm | 6 ++-- .../patches/containerd-create-pid-file.patch | 31 +++++++++++++++++++ gnu/services/docker.scm | 5 ++- 4 files changed, 41 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/patches/containerd-create-pid-file.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3a56ad371d..5cd235286c 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -17,7 +17,7 @@ # Copyright © 2017, 2020 Mathieu Othacehe # Copyright © 2017, 2018, 2019 Gábor Boskovits # Copyright © 2018 Amirouche Boubekki -# Copyright © 2018, 2019, 2020, 2021 Oleg Pykhalov +# Copyright © 2018, 2019, 2020, 2021, 2022 Oleg Pykhalov # Copyright © 2018 Stefan Stefanović # Copyright © 2018, 2020, 2021, 2022 Maxim Cournoyer # Copyright © 2019, 2020, 2021, 2022 Guillaume Le Vaillant @@ -965,6 +965,7 @@ dist_patch_DATA = \ %D%/packages/patches/cmh-support-fplll.patch \ %D%/packages/patches/coda-use-system-libs.patch \ %D%/packages/patches/collectd-5.11.0-noinstallvar.patch \ + %D%/packages/patches/containerd-create-pid-file.patch \ %D%/packages/patches/combinatorial-blas-awpm.patch \ %D%/packages/patches/combinatorial-blas-io-fix.patch \ %D%/packages/patches/cool-retro-term-wctype.patch \ diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm index ae4ee419af..184280b38f 100644 --- a/gnu/packages/docker.scm +++ b/gnu/packages/docker.scm @@ -6,7 +6,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2020 Katherine Cox-Buday ;;; Copyright © 2020 Jesse Dowell -;;; Copyright © 2021 Oleg Pykhalov +;;; Copyright © 2021, 2022 Oleg Pykhalov ;;; Copyright © 2022 Pierre Langlois ;;; ;;; This file is part of GNU Guix. @@ -184,7 +184,9 @@ (define-public containerd (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1vsl747i3wyy68j4lp4nprwxadbyga8qxlrk892afcd2990zp5mr")))) + (base32 "1vsl747i3wyy68j4lp4nprwxadbyga8qxlrk892afcd2990zp5mr")) + (patches + (search-patches "containerd-create-pid-file.patch")))) (build-system go-build-system) (arguments (let ((make-flags #~(list (string-append "VERSION=" #$version) diff --git a/gnu/packages/patches/containerd-create-pid-file.patch b/gnu/packages/patches/containerd-create-pid-file.patch new file mode 100644 index 0000000000..668ffcd9e9 --- /dev/null +++ b/gnu/packages/patches/containerd-create-pid-file.patch @@ -0,0 +1,31 @@ +Copyright © 2022 Oleg Pykhalov + +Create a PID file after containerd is ready to serve requests. + +Fixes . + +--- a/cmd/containerd/command/notify_linux.go 1970-01-01 03:00:01.000000000 +0300 ++++ b/cmd/containerd/command/notify_linux.go 2022-07-02 04:42:35.553753495 +0300 +@@ -22,15 +22,22 @@ + sd "github.com/coreos/go-systemd/v22/daemon" + + "github.com/containerd/containerd/log" ++ ++ "os" ++ "strconv" + ) + + // notifyReady notifies systemd that the daemon is ready to serve requests + func notifyReady(ctx context.Context) error { ++ pidFile, _ := os.Create("/run/containerd/containerd.pid") ++ defer pidFile.Close() ++ pidFile.WriteString(strconv.FormatInt(int64(os.Getpid()), 10)) + return sdNotify(ctx, sd.SdNotifyReady) + } + + // notifyStopping notifies systemd that the daemon is about to be stopped + func notifyStopping(ctx context.Context) error { ++ os.Remove("/run/containerd/containerd.pid") + return sdNotify(ctx, sd.SdNotifyStopping) + } + diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm index 846ebe8334..741bab5a8c 100644 --- a/gnu/services/docker.scm +++ b/gnu/services/docker.scm @@ -98,6 +98,8 @@ (define (containerd-shepherd-service config) ;; For finding containerd-shim binary. #:environment-variables (list (string-append "PATH=" #$containerd "/bin")) + #:pid-file "/run/containerd/containerd.pid" + #:pid-file-timeout 300 #:log-file "/var/log/containerd.log")) (stop #~(make-kill-destructor))))) @@ -135,7 +137,8 @@ (define (docker-shepherd-service config) '("--userland-proxy=false")) (if #$enable-iptables? "--iptables" - "--iptables=false")) + "--iptables=false") + "--containerd" "/run/containerd/containerd.sock") #:environment-variables (list #$@environment-variables) #:pid-file "/var/run/docker.pid" -- 2.36.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 07:40:09 2022 Received: (at control) by debbugs.gnu.org; 2 Jul 2022 11:40:09 +0000 Received: from localhost ([127.0.0.1]:39995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bTt-0001a8-Kk for submit@debbugs.gnu.org; Sat, 02 Jul 2022 07:40:09 -0400 Received: from mail-lj1-f174.google.com ([209.85.208.174]:42965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7bTq-0001Z4-Rb for control@debbugs.gnu.org; Sat, 02 Jul 2022 07:40:07 -0400 Received: by mail-lj1-f174.google.com with SMTP id r9so5442979ljp.9 for ; Sat, 02 Jul 2022 04:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:to:from:subject; bh=OtPXFQQwBawxlAqX8C8RKi+04iMM+cJ3SIB0l9Vxmx0=; b=lZiXa+3AaJCsS/6nq5Hv7MJT8Nk+QX/m8RkEegStwfBP0Oj24kHP167llFlCrcbwEl odJhgodevCYprQbCHjcGEFxB4p95U+gJE3VhsvpX1TQmOnleytwaEkFrI2MpIghB/jo/ 9MuUVQU4VUCVA45A/qT/o+NBTAcdYlUigWauTSYeyXpvnXfFOQgzQ2raQ6Xv+OCjPu6R /iKHGBjQcmV32YuyLsMQTU7YXGG7BBKvrzWXSVKTIOCky1SPZXmNIBF5nOaIyP1Mf0eq 2NZlk48g7mpHExv2FqjcUCPOYiBmziD8WDy9Q3d4VyTQ5k1J/LcMJ+2FgipM23jrxqJX KheA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:to:from:subject; bh=OtPXFQQwBawxlAqX8C8RKi+04iMM+cJ3SIB0l9Vxmx0=; b=7LkEmVni/0Ag2OS9QUXsGjsCNdJgjXJBfM1SKBLDVI8JwGzlDTLHYtrajEQuknJKSf abn3O7eA09kf3mPmklkI3cKuLXFmgW21SImpwktbRQVDs8UbmM7leE6fZa5GDfYh40U1 Ka8dRztr3S/+m/9OgS+ibpZLBlM96t4uACuDY480SyAy82XOCTJk3b7OnilGJmSUh9mf QZXQvtPOqZSNT7R72xAC+Ek1jLeq6tzAL4wMztMSPDlK6BvK5xnMX3ym//IWTTGrYQH9 AEIMb9OY6GodzjhXegyBZFyNe6yz4hqaFmDD2bnEpoZLK/7ssLdfzrZ9REC72n/JPtK5 owVw== X-Gm-Message-State: AJIora+uA/5AED/fmder9H6DreamV9yiJr0d2ux+UadCAGODoCFLHfAp KTvpauNBUMrX6KrV9BoBBOUFg0+B0dQ= X-Google-Smtp-Source: AGRyM1vITJVxqVPGSimhKoyWqje8MjhHOt9jY0Ug1aOeRytYillKaT0dkKJXkPmbbUlDjRtC7JB+tA== X-Received: by 2002:a05:651c:244:b0:253:ecad:a4ee with SMTP id x4-20020a05651c024400b00253ecada4eemr10425289ljn.21.1656762000441; Sat, 02 Jul 2022 04:40:00 -0700 (PDT) Received: from localhost ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id c17-20020a056512075100b004795d64f37dsm4051012lfs.105.2022.07.02.04.39.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 04:39:59 -0700 (PDT) Message-ID: <62c02e8f.1c69fb81.cca20.7706@mx.google.com> Date: Sat, 02 Jul 2022 14:39:58 +0300 To: control@debbugs.gnu.org From: Oleg Pykhalov Subject: control message for bug #55936 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 55936 38432 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 01:10:46 2022 Received: (at 55936) by debbugs.gnu.org; 10 Jul 2022 05:10:47 +0000 Received: from localhost ([127.0.0.1]:36153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAPDS-0005CS-M7 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 01:10:46 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:40485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAPDQ-0005CE-MX for 55936@debbugs.gnu.org; Sun, 10 Jul 2022 01:10:45 -0400 Received: by mail-qk1-f172.google.com with SMTP id y22so692008qki.7 for <55936@debbugs.gnu.org>; Sat, 09 Jul 2022 22:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NGwVSoPP9E7JR+lnurOQwFSron90E4Gttq5jRRrwncQ=; b=DP12/AU6WQy04gQqmewKdbgwZi65LRKF3DFGcFFmWJnTRrLebe9mClzdXBx82OBa72 D7hFI91MaGabxaSZ7H5yKhCMiNcmq29mI41BMliEHBQkv3CGPxmpYJvj+Tw15SfZEp2P 7raUDUtUJ/jYlXqxme9i7eq50kdmg7Y71NEq4NdNmYv7MvPGuY1ZyLneDpAzBbMvTF+O pdnnAjqGgnIZF8rc729rJlOTEJCI1blXGSA4OPOrxERAUJt3MGnITEhieOzlX4wgYZLP lCh9Azo94SbM9Jv/tRKQdkVoofWMn+7MwvOgxQsMGmqXBeL9okl2bMbs3YtRPLEBuSqB Fn3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NGwVSoPP9E7JR+lnurOQwFSron90E4Gttq5jRRrwncQ=; b=1sG/z0m8AGdL28ZdNdKnGYrxXNe9doW7LEPsje52Qie2U0MHl4DXuZvrvPZruIAsvB ZvW8DI7BKdr4jtqyzXykksB65NUGSJnyS4MX3/2xdOkiIPQzkEh0SwD5ya4o3CyBRN85 CTk/jE9ayOqDNPPnvVXz6wNwunkBuyAlcaeE9JVAlDo8voB9IgNoZS8Aeao2XDnd4gyb bFBvnK6/eLyq4N5Ibob6J+O/URqfym5hhXSbUyTKlrMyBKigkqTnKStgqQH58GqkHhJR NeFEk1oO5l5hTvV7ZW+GMCNdsi0ApuUwmbJ7FJWaAXVyWVjfKXeqbMBc3btcmkF9OT+X f2Ew== X-Gm-Message-State: AJIora9a2R+hH7IXEw2Yiv5CI6No6w0I0M3sITCCJaSBhh04sARlmCTk kdVW05ES4R/S0kUiHk+Ed6CWNvxP1FgtPQ== X-Google-Smtp-Source: AGRyM1uRvrLE9i/jk5J/I4a1+4dpdebk78uaeMXuVK8ep+LgV8jPtCmwrTdEP/0ZRTqSTB31W/zpGw== X-Received: by 2002:a37:64a:0:b0:6b5:652f:10ac with SMTP id 71-20020a37064a000000b006b5652f10acmr6769698qkg.241.1657429838966; Sat, 09 Jul 2022 22:10:38 -0700 (PDT) Received: from hurd (dsl-10-135-142.b2b2c.ca. [72.10.135.142]) by smtp.gmail.com with ESMTPSA id o21-20020a05622a009500b0031d4044c464sm2889657qtw.46.2022.07.09.22.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 22:10:38 -0700 (PDT) From: Maxim Cournoyer To: Oleg Pykhalov Subject: Re: [PATCH] services: docker: Fix race condition. References: <20220702104106.16997-1-go.wigust@gmail.com> Date: Sun, 10 Jul 2022 01:10:37 -0400 In-Reply-To: <20220702104106.16997-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 2 Jul 2022 13:41:06 +0300") Message-ID: <878rp1ft82.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55936 Cc: 55936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Oleg, Oleg Pykhalov writes: > Fixes . > > * gnu/packages/patches/containerd-create-pid-file.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add this. > * gnu/packages/docker.scm (containerd)[source]: Add this patch. > * gnu/services/docker.scm > (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. > * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. Thanks for this, it looks promising! Before we go forward though, had you consider using a 'make-systemd-constructor' as now available in Shepherd 0.9+ ? I remember Docker supports systemd socket activation for synchronizing its services; it could be a simpler, no-code solution. Would you like to give it a try? Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 17:07:06 2022 Received: (at 55936) by debbugs.gnu.org; 13 Jul 2022 21:07:06 +0000 Received: from localhost ([127.0.0.1]:47856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBjZZ-0008Oa-PG for submit@debbugs.gnu.org; Wed, 13 Jul 2022 17:07:05 -0400 Received: from mail-qv1-f46.google.com ([209.85.219.46]:35782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBjZY-0008O2-67 for 55936@debbugs.gnu.org; Wed, 13 Jul 2022 17:07:04 -0400 Received: by mail-qv1-f46.google.com with SMTP id l2so73784qvt.2 for <55936@debbugs.gnu.org>; Wed, 13 Jul 2022 14:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sOU5oM3/OUDVJatmwPplLhdNCs+qJbibJ8r/hGew/qs=; b=Q0hVHPNa5bCgjzUz7JhIT/Tdg/DBwp0FN1Y3YMFhMr7Q/HDmwtAgrAr7Pn3Xk/YVYC ZQ5U3p1BoarQ6ixCe++WRHa3HuvXLovHZ2iSAh+PyoZb+45uk1IzVi7OfbZu6e6/y+DW hDlA4XxoPI6wO9giMaQxreMxUB9MK20MOW7DW9jtAULcpddw0OHP3/7bJuME/Kur8ZDd eo7ZzPMgs/JbhX4UsdU+pZwejd8gO3mqCg6UZz3ErAI0q/eY+V6pFn1s0ZlQ9nWUT1G1 uej2+CVMPbI0buEOP0bM/paMEJ9mT2Hb5MJ8Eu8Nccb15vVhUEfCNSivLNgDEeICylxx GKoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sOU5oM3/OUDVJatmwPplLhdNCs+qJbibJ8r/hGew/qs=; b=bT0RESad900ra1otPb7KO4f1fCgJ85rJ8EtLFFEaD3/V3xrUfEzNtEn+ZTTZ4Vpbig EIP3xOQeHA0vBtiCYuuNdQl89Ts0Ht5MkD5rtVoWe3aIIIvyF705bQ6Fpz3G/94THzMY JfAlkAXfjrQvrGtgPN4L03OAUJGX2sgkw67vxgcp9RywYXkfOZk1kdlCAA5i6xN7ySHn BDXcvTK7gRShmc6jSNXx1yAqJ/DdzjI/qhK/3Kshhzk+oIUgmSDNjdRg0zCCraV/Fkb3 nS5+DPFwQrJ7tJfl+AA55qRAiCdXmVnR8cx2jJfhxdptDMB/DmxqPUExaWAAv3IKj8zK jnUQ== X-Gm-Message-State: AJIora/QLSvT43Fipe/dAT1NPRHFoY7JTzEy1sIZPU9bvgDDhlNFx8GJ nflAB/dY9j2gYfvGHijuT3FaVJGsQka492aV X-Google-Smtp-Source: AGRyM1svEMW3MbcYlmxT5/tMgeyRIEbALqKUUPa3d4P9jXvq+Ccv6PQeF8d+P7gOCl6CkdtSqtcTTA== X-Received: by 2002:a05:6214:2308:b0:432:e69f:5d71 with SMTP id gc8-20020a056214230800b00432e69f5d71mr4972272qvb.19.1657746418039; Wed, 13 Jul 2022 14:06:58 -0700 (PDT) Received: from hurd (dsl-10-133-49.b2b2c.ca. [72.10.133.49]) by smtp.gmail.com with ESMTPSA id k18-20020a05620a415200b006b58fce19dasm8156417qko.20.2022.07.13.14.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 14:06:57 -0700 (PDT) From: Maxim Cournoyer To: Oleg Pykhalov Subject: Re: bug#55936: dockerd fails to start on boot References: <20220702104106.16997-1-go.wigust@gmail.com> <878rp1ft82.fsf@gmail.com> Date: Wed, 13 Jul 2022 17:06:56 -0400 In-Reply-To: <878rp1ft82.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 10 Jul 2022 01:10:37 -0400") Message-ID: <87wncgyb67.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55936 Cc: 55936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxim Cournoyer writes: > Hi Oleg, > > Oleg Pykhalov writes: > >> Fixes . >> >> * gnu/packages/patches/containerd-create-pid-file.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add this. >> * gnu/packages/docker.scm (containerd)[source]: Add this patch. >> * gnu/services/docker.scm >> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. >> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. > > Thanks for this, it looks promising! > > Before we go forward though, had you consider using a > 'make-systemd-constructor' as now available in Shepherd 0.9+ ? I > remember Docker supports systemd socket activation for synchronizing its > services; it could be a simpler, no-code solution. I've researched more on the topic, and it appears what I had on mind is rather systemd's socket *notification* (what they call 'sdNotify') rather than activation. Activation is just to lazy start things... it probably wouldn't help here, rather it seems it'd be a bad idea, as realized elsewhere [0]. [0] https://github.com/containerd/containerd/issues/164#issuecomment-657536515 All that to say that I shall be reviewing your patches shortly :-). Thank you, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 21:41:16 2022 Received: (at 55936-done) by debbugs.gnu.org; 14 Jul 2022 01:41:16 +0000 Received: from localhost ([127.0.0.1]:48051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBnqs-0007kx-Qj for submit@debbugs.gnu.org; Wed, 13 Jul 2022 21:41:16 -0400 Received: from mail-qv1-f41.google.com ([209.85.219.41]:34775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBnqf-0007k7-4M for 55936-done@debbugs.gnu.org; Wed, 13 Jul 2022 21:41:13 -0400 Received: by mail-qv1-f41.google.com with SMTP id mi10so473383qvb.1 for <55936-done@debbugs.gnu.org>; Wed, 13 Jul 2022 18:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HOxU/X+T6JXv9XSt9Rl34d+x67J20tZ0jFiu1OnOCT8=; b=n7iHC1brATf48gM8WU0Srz2viRx7PcZlLSzWTJ8PgpFSNsHL93yw1HUMU5se31zqBI Y+kZX4dcAuNqfPNMOx1x38GT8Y5n7uAwl0ilj5tLsyGwGjaw/Xugmau5+6/S9DWZ5WHn Vy0QAlf3nx0BYwHUMA1Rxo9JlPfOu+DeQeuKWPzXxPaC9bI7FzP5iTKQCQj8FftMZhGI 7oXKHRdXeKMu+azf3Ak+x5OKqP25DAmR3Tb057kAypLXaQlkzTVzyESssu0djeUV8Cik gYzgECdsW+Btkkbxex4DdS+btO54149sz/nBszIgl6OAdbk1N2xzjAe1AG7WQIdkm8Mx eAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HOxU/X+T6JXv9XSt9Rl34d+x67J20tZ0jFiu1OnOCT8=; b=dwfZSz3cyQk2jHRiAAVV50BsUowPHsZ6rbBZq+ro1pMUfjmznBL/hM+cKp1/sjuiRb 4K/Yel9l4HwvtmTXw2rXwlJ4/GzND/1qD63CDP5D/RSZlq5cigrEkHSerV+zhXVNTod8 ZBdxOanuK42iuYrR7fQMzN3KKdPBErPNS/+xmNdpikO8cp6+YqmlxT6feyVMseLaRAIx /5D/0sFcPnRCugqVYVQWX+z4WWVX9x7cyS+/cQV+pSwN/s7ljHXZKnEuWSs5wDlwLxFS WcYDfuNDyb5L9piNx0zm0+KunNDyTO5d/jIM4hd+P/PhIEQbFCD6V4oJePNgVNSNfBwN trcQ== X-Gm-Message-State: AJIora8QurWB4xiwia0Ne9zSt66Yb9Oso0ou6IUh0mtDelcqKVpzDBhj 9BW7dbFh50rbUiypBR+D61UEJRtWmG8pcmjl X-Google-Smtp-Source: AGRyM1uanvZ+f/grpaWv7CHMRSNGwADRr356F6ydYOKoVP07p77mgXw4pBbP2+/8/eQ7ShgN2aEkSQ== X-Received: by 2002:a05:6214:d81:b0:45a:e07e:6bcb with SMTP id e1-20020a0562140d8100b0045ae07e6bcbmr5787176qve.29.1657762855244; Wed, 13 Jul 2022 18:40:55 -0700 (PDT) Received: from hurd (dsl-10-133-49.b2b2c.ca. [72.10.133.49]) by smtp.gmail.com with ESMTPSA id ez12-20020a05622a4c8c00b0031eb0bb5c3csm374001qtb.28.2022.07.13.18.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 18:40:54 -0700 (PDT) From: Maxim Cournoyer To: Oleg Pykhalov Subject: Re: bug#55936: dockerd fails to start on boot References: <20220702104106.16997-1-go.wigust@gmail.com> <878rp1ft82.fsf@gmail.com> <87wncgyb67.fsf_-_@gmail.com> Date: Wed, 13 Jul 2022 21:40:53 -0400 In-Reply-To: <87wncgyb67.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Jul 2022 17:06:56 -0400") Message-ID: <877d4g1nfe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55936-done Cc: 55936-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Oleg, Maxim Cournoyer writes: > Hi, > > Maxim Cournoyer writes: > >> Hi Oleg, >> >> Oleg Pykhalov writes: >> >>> Fixes . >>> >>> * gnu/packages/patches/containerd-create-pid-file.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add this. >>> * gnu/packages/docker.scm (containerd)[source]: Add this patch. >>> * gnu/services/docker.scm >>> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. >>> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. >> >> Thanks for this, it looks promising! [...] > All that to say that I shall be reviewing your patches shortly :-). Now done; it all looks good to me! I've run the docker system test, and installed it on my machine, rebooted, confirmed it was up, restarted containerd a couple times and checked the PID content matched its actual PID, and it seems to behave as expected! Pushed as b33e1a183f6756514e6b6a3b84054a232dbddad4. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 06:20:56 2022 Received: (at 55936) by debbugs.gnu.org; 15 Jul 2022 10:20:56 +0000 Received: from localhost ([127.0.0.1]:39525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIRM-0005s4-6K for submit@debbugs.gnu.org; Fri, 15 Jul 2022 06:20:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIRK-0005rm-KA for 55936@debbugs.gnu.org; Fri, 15 Jul 2022 06:20:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCIRE-0002cc-VU; Fri, 15 Jul 2022 06:20:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=TurSYbweSM0RKYTM60AsUSxkupbnVBeBto55LYC14QU=; b=LBbOUYzkJCe9b+LuzmFM 41dX40Lc+8+UjHm7TB7kSlTXkRypO9j63SKbWLSGf1wmhPLDvo+36n8HVZkZD1AGHp9iA6Ft5yRxA RyaUA0YQJviv+wtP2912/I5+xSvu+vEpKkT02aHYfkMWImmkyF9qIwXs7lRcQkg1/831EsfMJe4vZ sR70fEngUM3r7LzXDWlL8vrv3kBNripgGVHnJFd5vxjSsJvj+C9Rz6hhKJ3OQhre6DViRBR4w6JcS e9ReZjmTckLCZGsz/SCntRwKJSm8sSPqR1xWF2QUDm2fv2L/5ejbfg1dXr17FhOxcLhqkXievEIJj 5QtCmsP7azNkhg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:49236 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCIRE-0003kW-J0; Fri, 15 Jul 2022 06:20:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#55936: dockerd fails to start on boot References: <20220702104106.16997-1-go.wigust@gmail.com> <878rp1ft82.fsf@gmail.com> <87wncgyb67.fsf_-_@gmail.com> Date: Fri, 15 Jul 2022 12:20:46 +0200 In-Reply-To: <87wncgyb67.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Jul 2022 17:06:56 -0400") Message-ID: <87k08e8yo1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55936 Cc: Oleg Pykhalov , 55936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > I've researched more on the topic, and it appears what I had on mind is > rather systemd's socket *notification* (what they call 'sdNotify') > rather than activation. Activation is just to lazy start things... it > probably wouldn't help here, rather it seems it'd be a bad idea, as > realized elsewhere [0]. > > [0] https://github.com/containerd/containerd/issues/164#issuecomment-657= 536515 Currently the Shepherd implements activation as lazy start, but we should add an option for =E2=80=9Ceager socket activation=E2=80=9D where th= e daemon is started right away. Such activation is still useful as a synchronization mechanism: you can tell the service is ready to serve requests as soon as the socket has been created. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 21:55:18 2022 Received: (at 55936) by debbugs.gnu.org; 16 Jul 2022 01:55:18 +0000 Received: from localhost ([127.0.0.1]:42549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCX1a-0002q3-3d for submit@debbugs.gnu.org; Fri, 15 Jul 2022 21:55:18 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:46701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCX1X-0002pl-Q3 for 55936@debbugs.gnu.org; Fri, 15 Jul 2022 21:55:16 -0400 Received: by mail-qt1-f179.google.com with SMTP id cf13so5035130qtb.13 for <55936@debbugs.gnu.org>; Fri, 15 Jul 2022 18:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rSX7sUrdbEFAT+HfJzAB1UkpjHWks2avVaMWqeCQf90=; b=aC9s402iqJ0KtJAeQKM0fNvlQ5OmVssHfhFflA4tTZmbYUQ3fcuNfrMOX+aCeh8lol ysNfbA6v05gPibt1uLRR0DcjpRZVspI/LsrGjZD4uL4NCy5lrwgmxviuYbOPGMiWIxaS ufudQ8+dx/1V4WDKHCYfPuTLf+SNu53oisMkB4mprUuGOAdjit+lMZjFlR16fM8Sa+/Q Nitn2V5hJv0TTZuU6HhuA5GH06kBxEpkatEyJV1yBfWGu09n3oScikMmDt94zT/xrCi7 GaRvB0qv1OC9/CHI7tHghrtcn73TyPVGGo27nD9DKE/cG/xqM+m3GaR/tXU49nXUsnRq s9eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rSX7sUrdbEFAT+HfJzAB1UkpjHWks2avVaMWqeCQf90=; b=YC2MdKqCMZof3YzvCG90rELaDjCXUYLwdDLI4HVGbuV+UODHLk5nEF0KKZXD3jgzUI Y/TJMVxb473BK/jhN4Pq87zc96RuVsx7vInwqv0Bn0bCRAxa7mDoy6rPfYqfcCgml6h1 E9CC/5fMLOhGhJCOCEqPUeASr0MynjJzLnu0TB/PtuYNrgNDKnqiUiBQezadS9qYWgTf FHgKAkubY3Ff0ObeuQzGU6IFbdeUgp/5TTUYcfIE4jP2n1jZBZ5SErBLqkHlnIoB+lVl RggieoBvVFMJ2F0gZfsqjy6JITe9qFANnWc24/Tgi3KmM9wjRe2a7wnE+usYuO48mhDF XlhQ== X-Gm-Message-State: AJIora9CZEFFG8qhQPndKsaWMkXq8WqpVkFl2G6Mk4P+DllC6BUNFcwE SpPdWF796mtS00NovAt1415QZTcTNhB/bRXz X-Google-Smtp-Source: AGRyM1vOg0Oom31+g7QcozvJsyQIy6MPiSabkQVqHtj/xO40zTiHuiJzr45eHMWmkofvQSwow1nZhA== X-Received: by 2002:a05:622a:15c4:b0:31e:d3ad:e847 with SMTP id d4-20020a05622a15c400b0031ed3ade847mr7900727qty.109.1657936510099; Fri, 15 Jul 2022 18:55:10 -0700 (PDT) Received: from hurd (dsl-205-233-125-176.b2b2c.ca. [205.233.125.176]) by smtp.gmail.com with ESMTPSA id u5-20020a05620a430500b006b5bf5d45casm5901852qko.27.2022.07.15.18.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 18:55:09 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#55936: dockerd fails to start on boot References: <20220702104106.16997-1-go.wigust@gmail.com> <878rp1ft82.fsf@gmail.com> <87wncgyb67.fsf_-_@gmail.com> <87k08e8yo1.fsf@gnu.org> Date: Fri, 15 Jul 2022 21:55:08 -0400 In-Reply-To: <87k08e8yo1.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 15 Jul 2022 12:20:46 +0200") Message-ID: <87pmi5stxf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55936 Cc: Oleg Pykhalov , 55936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> I've researched more on the topic, and it appears what I had on mind is >> rather systemd's socket *notification* (what they call 'sdNotify') >> rather than activation. Activation is just to lazy start things... it >> probably wouldn't help here, rather it seems it'd be a bad idea, as >> realized elsewhere [0]. >> >> [0] https://github.com/containerd/containerd/issues/164#issuecomment-65= 7536515 > > Currently the Shepherd implements activation as lazy start, but we > should add an option for =E2=80=9Ceager socket activation=E2=80=9D where = the daemon is > started right away. > > Such activation is still useful as a synchronization mechanism: you can > tell the service is ready to serve requests as soon as the socket has > been created. But this relies on the application behaving that way (e.g., waiting for the socket to be opened, rather than expecting things to be ready and failing), right? If I understand correctly, the sdNotify mechanism in systemd is a means that let the application notify systemd when it is ready, so that systemd itself can ensure the ordering relationships. So on systemd containerd would be marked as 'starting' by systemd until it notifies it that it's good via sdNotify, and docker.service would be waiting on it until after containerd has started since it is ordered to start after it [0] [0] https://github.com/moby/moby/blob/master/contrib/init/systemd/docker.s= ervice#L4 Thanks, Maxim From unknown Mon Jun 23 09:39:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Aug 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator