From unknown Sat Aug 09 04:57:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55920 <55920@debbugs.gnu.org> To: bug#55920 <55920@debbugs.gnu.org> Subject: Status: [PATCH] build-system: chicken: Added insert-missing-version phase Reply-To: bug#55920 <55920@debbugs.gnu.org> Date: Sat, 09 Aug 2025 11:57:22 +0000 retitle 55920 [PATCH] build-system: chicken: Added insert-missing-version p= hase reassign 55920 guix-patches submitter 55920 Michal Atlas severity 55920 normal tag 55920 patch moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 03:54:11 2022 Received: (at submit) by debbugs.gnu.org; 12 Jun 2022 07:54:11 +0000 Received: from localhost ([127.0.0.1]:54611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0IQB-0003Ul-W7 for submit@debbugs.gnu.org; Sun, 12 Jun 2022 03:54:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:40766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0BlA-0000d2-W9 for submit@debbugs.gnu.org; Sat, 11 Jun 2022 20:47:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0BlA-00009K-Fz for guix-patches@gnu.org; Sat, 11 Jun 2022 20:47:20 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Bl8-0007vR-DE for guix-patches@gnu.org; Sat, 11 Jun 2022 20:47:20 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0022F240026 for ; Sun, 12 Jun 2022 02:47:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1654994835; bh=iZMZIe7mrPQNr9pljDgH4PoOr34UUO5J036wV0Z9cW8=; h=From:To:Cc:Subject:Date:From; b=j9sF/86Cz0ONfuCL7r8N16J0bd7bPny7kigR7TIJXuha/6P0PGjiZaA289COR9lbF FcVH105wO9ez2RLd3JbS6WGCRFTihujbik11p2If8NHhODs40veaNYT7HtTQRsVbCN c3dwRlRIGrKoLAlPiYIIrO1L3QNosEMw6qFhF12giDK9DH1WzDh+iGDPojK8oVt6hf OFr85nwrb/meju91y97JScQIj0JlVYmyFuPlIYk+yNT/P6UuH7A1pzfBFnxGrHot98 TTrGsjeQEiXTpPD/pWdHHSS7ACg9knkasrnYOb+yGBhZ3Y/dK5+z47YRfO/0Opj105 oQulyoBJj47BQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LLGHk2klnz6tmT; Sun, 12 Jun 2022 02:47:14 +0200 (CEST) From: Michal Atlas To: guix-patches@gnu.org Subject: [PATCH] build-system: chicken: Added insert-missing-version phase Date: Sun, 12 Jun 2022 00:45:20 +0000 Message-Id: <20220612004520.6107-1-michal_atlas@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=michal_atlas@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 12 Jun 2022 03:54:07 -0400 Cc: Michal Atlas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Many .egg files don't contain version information, this causes `chicken-install` to label them {unknown}, which makes it fail compilations whenever a dependency is tagged with a minimum-version. I am unaware of a way to force this check to not-happen and the version information should be included anyway, so this patch should fix the problem. --- guix/build/chicken-build-system.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/guix/build/chicken-build-system.scm b/guix/build/chicken-build-system.scm index 5db9906acf..341ab64a0f 100644 --- a/guix/build/chicken-build-system.scm +++ b/guix/build/chicken-build-system.scm @@ -112,6 +112,17 @@ (define* (check #:key egg-name tests? #:allow-other-keys) (when tests? (invoke "chicken-install" "-cached" "-test" "-no-install" egg-name))) +(define* (insert-missing-version #:key egg-name name #:allow-other-keys) + "Inserts version information into the .egg file if it isn't contained already" + (let* ([filename (string-append egg-name "/" egg-name ".egg")] + [egg-info (call-with-input-file filename read)] + [ver? (find (λ (i) (eqv? (car i) 'version)) egg-info)] + [ver (substring name (1+ (string-rindex name #\-)))]) + (when (not ver?) + (make-file-writable filename) + (call-with-output-file filename + (λ (f) (write (cons `(version ,ver) egg-info) f)))))) + ;; It doesn't look like Chicken generates any unnecessary references. ;; So we don't have to remove them either. Nice. @@ -122,6 +133,7 @@ (define %standard-phases (delete 'configure) (delete 'patch-generated-file-shebangs) (add-before 'unpack 'setup-chicken-environment setup-chicken-environment) + (add-before 'build 'insert-missing-version insert-missing-version) (replace 'build build) (delete 'check) (replace 'install install) base-commit: 1643402950b2d2384ec74fb69e059cc6a4c4ebed -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 07:26:37 2022 Received: (at 55920) by debbugs.gnu.org; 15 Jun 2022 11:26:37 +0000 Received: from localhost ([127.0.0.1]:36644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RAS-00044c-UV for submit@debbugs.gnu.org; Wed, 15 Jun 2022 07:26:37 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:16803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RAN-00044Q-OQ for 55920@debbugs.gnu.org; Wed, 15 Jun 2022 07:26:35 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LNNKw4SSgz1LZWB; Wed, 15 Jun 2022 13:26:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LNNKw4SSgz1LZWB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1655292388; bh=a8rOx7Vadg/SFJi9pnBV4W0hK780NjNNRTetSkBQ0q8=; h=Subject:From:To:Date:In-Reply-To:References:From; b=oQ6U18sHXr+if4MIk3YLZlwXHz9iuXCE/m8bTqdkfZvtNH4+osmic3d0Q0WXxwoV/ xkIyeE6K0xMPN865G0Oh3huyKkJIlnTv+gjJjNqSI+uOWfI1jiUDPAlPQfhzon5HG/ 3jw1H6MMUDsvqcpArLMljYs0UAL1gQUmdcqeMZmg= Message-ID: Subject: Re: [PATCH] build-system: chicken: Added insert-missing-version phase From: Liliana Marie Prikler To: Michal Atlas , 55920@debbugs.gnu.org Date: Wed, 15 Jun 2022 13:26:27 +0200 In-Reply-To: <20220612004520.6107-1-michal_atlas@posteo.net> References: <20220612004520.6107-1-michal_atlas@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55920 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Sonntag, dem 12.06.2022 um 00:45 +0000 schrieb Michal Atlas: > Many .egg files don't contain version information, > this causes `chicken-install` to label them {unknown}, > which makes it fail compilations whenever a > dependency is tagged with a minimum-version. > > I am unaware of a way to force this check to not-happen > and the version information should be included anyway, > so this patch should fix the problem. > --- Put the blurb below this line, add a ChangeLog above. >  guix/build/chicken-build-system.scm | 12 ++++++++++++ >  1 file changed, 12 insertions(+) > > diff --git a/guix/build/chicken-build-system.scm > b/guix/build/chicken-build-system.scm > index 5db9906acf..341ab64a0f 100644 > --- a/guix/build/chicken-build-system.scm > +++ b/guix/build/chicken-build-system.scm > @@ -112,6 +112,17 @@ (define* (check #:key egg-name tests? #:allow- > other-keys) >    (when tests? >      (invoke "chicken-install" "-cached" "-test" "-no-install" egg- > name))) >   > +(define* (insert-missing-version #:key egg-name name #:allow-other- > keys) I find "stamp-egg-version" funnier. > +  "Inserts version information into the .egg file if it isn't > contained already" > +  (let* ([filename (string-append egg-name "/" egg-name ".egg")] > +         [egg-info (call-with-input-file filename read)] > +         [ver? (find (λ (i) (eqv? (car i) 'version)) egg-info)] > +         [ver (substring name (1+ (string-rindex name #\-)))]) We don't do square brackets in Guile. Also, using λ rather than spelling out "lambda" results in a syntax error. > +    (when (not ver?) > +      (make-file-writable filename) > +      (call-with-output-file filename > +       (λ (f) (write (cons `(version ,ver) egg-info) f)))))) "lambda". >  ;; It doesn't look like Chicken generates any unnecessary > references. >  ;; So we don't have to remove them either. Nice. >   > @@ -122,6 +133,7 @@ (define %standard-phases >      (delete 'configure) >      (delete 'patch-generated-file-shebangs) >      (add-before 'unpack 'setup-chicken-environment setup-chicken- > environment) > +    (add-before 'build 'insert-missing-version insert-missing- > version) Note that 'insert-missing-version will always be logged even if the version is not actually missing. >      (replace 'build build) >      (delete 'check) >      (replace 'install install) Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 07:29:18 2022 Received: (at 55920) by debbugs.gnu.org; 15 Jun 2022 11:29:18 +0000 Received: from localhost ([127.0.0.1]:36650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RD4-00048b-E9 for submit@debbugs.gnu.org; Wed, 15 Jun 2022 07:29:18 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:46490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RD2-00048T-G8 for 55920@debbugs.gnu.org; Wed, 15 Jun 2022 07:29:17 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id jPVE2700E4UW6Th01PVEM8; Wed, 15 Jun 2022 13:29:15 +0200 Message-ID: Subject: Re: [bug#55920] [PATCH] build-system: chicken: Added insert-missing-version phase From: Maxime Devos To: Liliana Marie Prikler , Michal Atlas , 55920@debbugs.gnu.org Date: Wed, 15 Jun 2022 13:29:09 +0200 In-Reply-To: References: <20220612004520.6107-1-michal_atlas@posteo.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-B0P9MvB2Ij1LaMZdsZgG" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655292555; bh=hHzKlqyrpcOFkFOd50otjcIxswMPICVpXIw06SCA2E4=; h=Subject:From:To:Date:In-Reply-To:References; b=FJE+Cf29+W+37lhJMj7oEsg+t1VNsIxKuraOfc/dwNvTMdD2oyjzxQkm0iBo7RHsh ot9rLoVCS22DIumQnS0SZlYNX585kHFA4uJ0MA0SySu/pi1LJA5mtK6/NMjQVJDFh4 HHF6Bq7qeM05WYzW7qBzlmwZTmiAv2pTz8l6Ofr6Vt2j+0M5CklaO43ZeS/i+O7eTD UdZPgXv/a7kU+16dZ0Pmp95TK6ZuaM3Bf2OCoQvNMyXFESsfXeJODn0Mh3npKpRW9y htSy/Mpeor+oRlaafpwbxEhySsF3YEYgMMRrssnU8I3uJkpI2eGtRJaIo7+YGoJBGg j6MJJLJHORoCQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55920 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-B0P9MvB2Ij1LaMZdsZgG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op wo 15-06-2022 om 13:26 [+0200]: > We don't do square brackets in Guile.=C2=A0 Also, using =CE=BB rather tha= n > spelling out "lambda" results in a syntax error. This construct seems to work fine for me: > (let ((id (=CE=BB (x) x))) (id 0)) $2 =3D 0 Greetings, Maxime. --=-B0P9MvB2Ij1LaMZdsZgG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqnChRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p5EAP4twGLABhqvSvd0rgcSUJHRe1fK C2YKCST2OGqwzshaaAEAuuCtfjXsagO8Rf1Yd4J/+flJSLcxv4JfddfNIteW8ww= =QPlX -----END PGP SIGNATURE----- --=-B0P9MvB2Ij1LaMZdsZgG-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 07:32:15 2022 Received: (at 55920) by debbugs.gnu.org; 15 Jun 2022 11:32:15 +0000 Received: from localhost ([127.0.0.1]:36654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RFu-0006C8-QI for submit@debbugs.gnu.org; Wed, 15 Jun 2022 07:32:15 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:50231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1RFt-00069g-5v for 55920@debbugs.gnu.org; Wed, 15 Jun 2022 07:32:13 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LNNSM3XZxz3wV3; Wed, 15 Jun 2022 13:32:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1655292723; bh=TqAxdvUN43Jo2RKLwclnkJXQ2gB+Cy0CKGFKrVM5FGg=; h=Subject:From:To:Date:In-Reply-To:References; b=hvT5bD8EQSBstYENBsSuspgHrHACZcUuLGUAjXGkLI7veAJ1jtFkJ07Fp+1Au4l+C EL4xx7AuJAz/AKB6Pm5Yy08vCMHnmsNljb/nQzRynB9DfHjccjLUhfTWvCezZctDOb jlWEfEG9qLLGc0RQimZbQO+MmXdn8qgtfFLqJVY0= Message-ID: <467006424789ce3b88afa95de2d170783eeda5cd.camel@ist.tugraz.at> Subject: Re: [bug#55920] [PATCH] build-system: chicken: Added insert-missing-version phase From: Liliana Marie Prikler To: Maxime Devos , Michal Atlas , 55920@debbugs.gnu.org Date: Wed, 15 Jun 2022 13:32:02 +0200 In-Reply-To: References: <20220612004520.6107-1-michal_atlas@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55920 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, dem 15.06.2022 um 13:29 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op wo 15-06-2022 om 13:26 [+0200]: > > We don't do square brackets in Guile.  Also, using λ rather than > > spelling out "lambda" results in a syntax error. > > This construct seems to work fine for me: > > > (let ((id (λ (x) x))) (id 0)) > $2 = 0 > > Greetings, > Maxime. My bad, I only typed the letter λ into a repl and brain-grepped for syntax error. Still, the long form ought to be used in my opinion, because that's the one that editors are more likely to look out for. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 07:41:37 2022 Received: (at submit) by debbugs.gnu.org; 15 Jun 2022 11:41:37 +0000 Received: from localhost ([127.0.0.1]:36663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ROz-0006bS-0H for submit@debbugs.gnu.org; Wed, 15 Jun 2022 07:41:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:47554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ROu-0006bA-BC for submit@debbugs.gnu.org; Wed, 15 Jun 2022 07:41:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1ROu-0002wH-0K for guix-patches@gnu.org; Wed, 15 Jun 2022 07:41:32 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:45050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1ROr-0003jT-CM for guix-patches@gnu.org; Wed, 15 Jun 2022 07:41:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=0nR+abX+Ldguz vjv9CuE/qf54hMOfBGsg04ikPay9+4=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=XhbITvrYWJ9O3LBFD2zs4eEKuRImycJ9UqdblF D1SIPEvJVFpJNg1uQ3r/mBkRtYEbDzudHqI7BjCbVOR4Gg1k0NI0xozMTaqNPYUmPlLU5O +8eUr8Iko18Tul0KeDoQ4jB7M1M3nJi/o0OJvS/RfFiIPT3fqtJ2MoFDh3Qlgn2pdpsQ88 I/mv8HTGZO4F93gucYWFfogftz03Rle7x2jaFCfsSWIFqyMIPrGopZ+jsj2D7kCvLwjn8+ 3PlPoYcrhRtbN2rzETEYSGrbOvvsKoXQD4eSx7OfzsAHRR2HtpJZ+aeiwL8Sul9MbECSOu 1feT1azBIcnJ9zBTPPMut0tA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 93e84188 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 15 Jun 2022 11:41:25 +0000 (UTC) References: <20220612004520.6107-1-michal_atlas@posteo.net> From: Tobias Geerinckx-Rice To: Liliana Marie Prikler Subject: Re: [bug#55920] [PATCH] build-system: chicken: Added insert-missing-version phase Date: Wed, 15 Jun 2022 13:40:23 +0200 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkuurw63@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: 55920@debbugs.gnu.org, guix-patches@gnu.org, Michal Atlas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler =E5=86=99=E9=81=93=EF=BC=9A >Also, using =CE=BB rather than spelling out "lambda" results in a=20 >syntax error. Not true, but we conventionally don't use =CE=BB in Guix code. There=20 are a good few counterexamples that snuck in over the years,=20 though. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYqnFZA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15Ko0BAOZ0iZzOd5Lokn9ZVSfHy92PF9vZD1AyZev6uDmV 1awwAQCap9j4WmXl8o9NqVInMvB7xkQiHS9MyAi0HYdb0r54Dw== =GSWb -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 05:12:25 2022 Received: (at control) by debbugs.gnu.org; 16 Jun 2022 09:12:26 +0000 Received: from localhost ([127.0.0.1]:40740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1lY9-0008JX-OP for submit@debbugs.gnu.org; Thu, 16 Jun 2022 05:12:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1lY8-0008JH-6x for control@debbugs.gnu.org; Thu, 16 Jun 2022 05:12:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1lY2-0007C7-Vr for control@debbugs.gnu.org; Thu, 16 Jun 2022 05:12:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=NzUJlqRKfUCNdwPQLkPXb0DrJuhQngcG78NfG3L7FtE=; b=cNORJzDh8DMbxX f4QS/JkU+zI7BffyFxTiGEhgiXrkrbSS/xbd7hgwYpUuX1Op+KySmW55TBta3bYL2ROMxHSmF0a7s oEW5vd1ilLOvLcGz90/R4M9CpBhZcrvJWoqG9zyFYoAQPfvMa1fK9afba4yf2tNJfetRWaXwrHmvy bK0Yfit4OAm3n91PBpi63XiQDIzEl0Ck1EvSGm81/Va0ef9R7NMbFeqnewA4lLg/8ucG0JeuAgFfm 0eRAUO+Elw8YvAhv0uiDEH/v5Q9kJIk48k0JrXw5U5tscwXlFDEZf472Bc4NVas/YPYT3fRZH/89m uQRiP5EZZNJe4le0QhTQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59004 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1lY2-0008Mz-Ef for control@debbugs.gnu.org; Thu, 16 Jun 2022 05:12:18 -0400 Date: Thu, 16 Jun 2022 11:12:16 +0200 Message-Id: <87r13pm0pb.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55920 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 55920 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 19:28:41 2022 Received: (at 55920) by debbugs.gnu.org; 19 Jun 2022 23:28:41 +0000 Received: from localhost ([127.0.0.1]:53434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o34LP-00012B-CQ for submit@debbugs.gnu.org; Sun, 19 Jun 2022 19:28:41 -0400 Received: from mout02.posteo.de ([185.67.36.66]:35209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o32Xc-0002KK-Gs for 55920@debbugs.gnu.org; Sun, 19 Jun 2022 17:33:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3A9CD240108 for <55920@debbugs.gnu.org>; Sun, 19 Jun 2022 23:33:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1655674382; bh=3eof8fMg8Lar//ZQ1VN5CX6JecBSOAzGT2CK8lw81bM=; h=From:To:Cc:Subject:Date:From; b=lpfbh5Gttm6u3E1gY25DG2FxQiTm2eYblom51vDicChFoZJPCUHNvNzcMLEflic6c H1rk2R1jEXHSyYrvpfiSoVv1FqPQHmKGHxeS66xzdfS7I6C0AztToaTuElnCJ9sfVT 1tz+gh23tglmZh/DJ+zIiYPtDBEACInZ+0WW/rBYvorOwiOtlblByoel4YR1DIqQaf kaR8b/m4khTEwirRh1/grH+o5GVIQPaxs0OIZ031d8L9dR+easyNPYVONzxYUGTga+ zm2DMQ4KsymQJ1/4H6l+Nkk7OQGxjubCZJg1RTxykYt5gfGFyVifogpj/NqUPH+S1X Y3nD/St/PMUXw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LR5bx3blQz6tnw; Sun, 19 Jun 2022 23:33:01 +0200 (CEST) From: Michal Atlas To: 55920@debbugs.gnu.org Subject: [PATCH] build-system: chicken: Added stamp-egg-version phase Date: Sun, 19 Jun 2022 20:36:03 +0000 Message-Id: <20220619203602.10903-1-michal_atlas@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55920 X-Mailman-Approved-At: Sun, 19 Jun 2022 19:28:38 -0400 Cc: Michal Atlas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/build/chicken-build-system.scm (stamp-egg-version): New phase Compiled eggs will now always contain some version, falling back to the guix package version if none is provided by the egg. (%standard-phases): Inserted the new phase --- Many .egg files don't contain version information, this causes `chicken-install` to label them as "unknown", which causes it to fail compilations whenever a dependency is tagged with a minimum-version. I am unaware of a way to disable the version check and the version information should be included anyway, so this patch should fix the problem. --- guix/build/chicken-build-system.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/guix/build/chicken-build-system.scm b/guix/build/chicken-build-system.scm index 5db9906acf..c0a4986032 100644 --- a/guix/build/chicken-build-system.scm +++ b/guix/build/chicken-build-system.scm @@ -112,6 +112,17 @@ (define* (check #:key egg-name tests? #:allow-other-keys) (when tests? (invoke "chicken-install" "-cached" "-test" "-no-install" egg-name))) +(define* (stamp-egg-version #:key egg-name name #:allow-other-keys) + "Inserts version information into the .egg file if it isn't contained already" + (let* ((filename (string-append egg-name "/" egg-name ".egg")) + (egg-info (call-with-input-file filename read)) + (ver? (find (lambda (i) (eqv? (car i) 'version)) egg-info)) + (ver (substring name (1+ (string-rindex name #\-))))) + (when (not ver?) + (make-file-writable filename) + (call-with-output-file filename + (lambda (f) (write (cons `(version ,ver) egg-info) f)))))) + ;; It doesn't look like Chicken generates any unnecessary references. ;; So we don't have to remove them either. Nice. @@ -122,6 +133,7 @@ (define %standard-phases (delete 'configure) (delete 'patch-generated-file-shebangs) (add-before 'unpack 'setup-chicken-environment setup-chicken-environment) + (add-before 'build 'stamp-egg-version stamp-egg-version) (replace 'build build) (delete 'check) (replace 'install install) -- 2.36.1 --- Hopefully I understood your comments well. > Note that 'insert-missing-version will always be logged I was aware of that but didn't find anything about making a phase optional, good thing it has a more sensible name now. Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 15:44:13 2022 Received: (at 55920-done) by debbugs.gnu.org; 21 Jun 2022 19:44:13 +0000 Received: from localhost ([127.0.0.1]:33377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3jnJ-0000yT-8l for submit@debbugs.gnu.org; Tue, 21 Jun 2022 15:44:13 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3jnH-0000yF-2M for 55920-done@debbugs.gnu.org; Tue, 21 Jun 2022 15:44:12 -0400 Received: by mail-ed1-f66.google.com with SMTP id eq6so13460271edb.6 for <55920-done@debbugs.gnu.org>; Tue, 21 Jun 2022 12:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=bz1HUhex6BjEOXZ4J5GvixqaAOf3NI+lpO7MLoIIz9U=; b=bzVnbtkMRZxfCZpaFqnpfwBXHPZzqCgQzunc4ll2ZF3054unfp8ZKbhJTtPvNSeYc3 IAagkLDSHb6D56o/3fjD9AvD1u3KveSQjBLOXgPW8glF2aOzs3qGQyIsiYwPYMs2mctK EOdflUAXXX5L1JjSLBUr8bWyqrt3G07YdAFOiUS0eBDHdwuY0R0GOO2VcBSiOrKnk7hz 2k7PHBGJY4nacjZ9UHjYmA/Ez154sAtVmu8DwCHQE7AKk0D1++z9k/hyKOfIEZQYTwO2 24SFUyQPUJhIgNXHRT7Ka7xyOq/rjV4DA82UHFfF1NvVhFxR5KVmy8FwIlpCk+mrbY2l 56Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bz1HUhex6BjEOXZ4J5GvixqaAOf3NI+lpO7MLoIIz9U=; b=qrFkMdzvWq7MrQyXAKggXO20Z0Y6eIT2/CqMhx1AvkpkWHk+g1M3SwCAZbJxDf/xaJ fLwc3JI8AADSv9v8VhinehBRlFZ5018HgFxCJtOWFSZxdrLARtw2w55ZFVrVvdiGzG19 D4jJ4XfnhmoH7y13TNQjEr0l4IXpOs+fwGSe/shZDO4MWhV2iVKP2Yv97dPlz+ANdHJz zuF3MqkngO+c9z38zZmUPyZhscqbn/sEzGPoisSwkKySJDUwPHMfhRIQx1miRutpVK7B gYAVMiDDVOY7GXdqc+ts76IucuvPtYTHS1QctfwZWnEnlKwhNujpXj7dljYQUJTVgT8U xP7A== X-Gm-Message-State: AJIora+P8tj0618IiwE4I3WKq/SeyOjhZuJzBQwKKqrmW/FznEE8JQZZ vWYwiFj5ic7/iPbZFRwQryw= X-Google-Smtp-Source: AGRyM1vDWSluyE6TjfG9E5Pn8pgBsdrJ7pk3omOt+WjCOm7iQSK5pcOvM75foPTVjyH80qcQo/dmkQ== X-Received: by 2002:a05:6402:4144:b0:431:6ef0:bef7 with SMTP id x4-20020a056402414400b004316ef0bef7mr38167377eda.151.1655840645212; Tue, 21 Jun 2022 12:44:05 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g4-20020a170906394400b00722e50e259asm1545604eje.102.2022.06.21.12.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 12:44:04 -0700 (PDT) Message-ID: <580d9e32db0bc3036ad0d7e7a8be910281312693.camel@gmail.com> Subject: Re: [PATCH] build-system: chicken: Added stamp-egg-version phase From: Liliana Marie Prikler To: Michal Atlas , 55920-done@debbugs.gnu.org Date: Tue, 21 Jun 2022 21:44:02 +0200 In-Reply-To: <20220619203602.10903-1-michal_atlas@posteo.net> References: <20220619203602.10903-1-michal_atlas@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55920-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 19.06.2022 um 20:36 +0000 schrieb Michal Atlas: > * guix/build/chicken-build-system.scm (stamp-egg-version): New phase > Compiled eggs will now always contain some version, > falling back to the guix package version if none is provided by the > egg. > (%standard-phases): Inserted the new phase Pushed with some wording fixes. Cheers From unknown Sat Aug 09 04:57:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Jul 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator