GNU bug report logs - #55912
[PATCH] home: Add OpenSSH service.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, 55912 <at> debbugs.gnu.org
Subject: [bug#55912] [PATCH v2] home: Add OpenSSH service.
Date: Wed, 15 Jun 2022 22:47:07 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op wo 15-06-2022 om 22:29 [+0200]:
> +  (computed-file name
> +                 (with-imported-modules '((guix build utils))
> +                   #~(begin
> +                       (use-modules (guix build utils))
> +
> +                       ;; Support non-ASCII file names.
> +                       (setenv "GUIX_LOCPATH"
> +                               #+(file-append glibc-utf8-locales
> +                                              "/lib/locale"))
> +                       (setlocale LC_ALL "en_US.utf8")

For robustness, I think it would be best to move this locale
initialisation code to the implementation of 'computed-file' itself, to
eliminate this potential pitfall entirely.

Except for 'racket' and package transformations, this does not seem to
used by any package definition (except via meson when cross-compiling),
so it doesn't seem like this would entail a world-rebuild
(unverified!).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.