GNU bug report logs - #55906
[PATCH] Make directory line in find-dired clickable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55906 in the body.
You can then email your comments to 55906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make directory line in find-dired clickable
Date: Sat, 11 Jun 2022 19:01:47 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

Attached patch makes find-dired respect the
`dired-make-directory-clickable' user option.



In GNU Emacs 29.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-06-10 built on astatine
Repository revision: 53139e53b75aa37cc808c1c8b3e3be367ae09fb3
Repository branch: add-mksh-imenu
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-modules --without-cairo --with-sound=alsa
 --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf
 --without-systemd --with-x'

[0001-lisp-find-dired.el-find-dired-Make-directory-clickab.patch (text/patch, attachment)]

Message #8 received at 55906 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55906 <at> debbugs.gnu.org
Subject: Re: bug#55906: [PATCH] Make directory line in find-dired clickable
Date: Sat, 11 Jun 2022 16:40:31 +0300

> From: Visuwesh <visuweshm <at> gmail.com>
> Date: Sat, 11 Jun 2022 19:01:47 +0530
> 
> diff --git a/lisp/find-dired.el b/lisp/find-dired.el
> index c04545e44e..8c1e684b7e 100644
> --- a/lisp/find-dired.el
> +++ b/lisp/find-dired.el
> @@ -241,6 +241,8 @@ find-dired
>      ;; Subdir headlerline must come first because the first marker in
>      ;; subdir-alist points there.
>      (insert "  " dir ":\n")
> +    (when dired-make-directory-clickable
> +      (dired--make-directory-clickable))

Won't we need to make that function be public for this, and rename it
to dired-make-directory-clickable?

Thanks.

Message #11 received at 55906 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55906 <at> debbugs.gnu.org
Subject: Re: bug#55906: [PATCH] Make directory line in find-dired clickable
Date: Sat, 11 Jun 2022 19:27:17 +0530

[சனி ஜூன் 11, 2022] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm <at> gmail.com>
>> Date: Sat, 11 Jun 2022 19:01:47 +0530
>> 
>> diff --git a/lisp/find-dired.el b/lisp/find-dired.el
>> index c04545e44e..8c1e684b7e 100644
>> --- a/lisp/find-dired.el
>> +++ b/lisp/find-dired.el
>> @@ -241,6 +241,8 @@ find-dired
>>      ;; Subdir headlerline must come first because the first marker in
>>      ;; subdir-alist points there.
>>      (insert "  " dir ":\n")
>> +    (when dired-make-directory-clickable
>> +      (dired--make-directory-clickable))
>
> Won't we need to make that function be public for this, and rename it
> to dired-make-directory-clickable?
>
> Thanks.

AFAICT, dired--make-directory-clickable is specific to dired buffers,
and since find-dired is "dired-compatible" I don't see a need to make
the function public.

Message #14 received at 55906 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55906 <at> debbugs.gnu.org
Subject: Re: bug#55906: [PATCH] Make directory line in find-dired clickable
Date: Sun, 12 Jun 2022 12:35:17 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> Attached patch makes find-dired respect the
> `dired-make-directory-clickable' user option.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.