GNU bug report logs - #55903
[PATCHSET] Adding aerc

Previous Next

Package: guix-patches;

Reported by: "(" <paren <at> disroot.org>

Date: Sat, 11 Jun 2022 09:07:01 UTC

Severity: normal

Tags: patch

Done: Raghav Gururajan <rg <at> raghavgururajan.name>

Bug is archived. No further changes may be made.

Full log


Message #245 received at 55903 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Maxime Devos" <maximedevos <at> telenet.be>, <55903 <at> debbugs.gnu.org>
Subject: Re: [bug#55903] [PATCH 02/41] gnu: Add go-github-com-creack-pty.
Date: Sun, 12 Jun 2022 13:33:22 +0100
On Sat Jun 11, 2022 at 11:38 PM BST, Maxime Devos wrote:
> In the previous patch series, ‘go-git-sr-ht-sircmpwn-pty’ was used

Presumably sircmpwn-pty was a temporary fork done for one reason or
another. The go.mod now uses creack-pty.

> Likewise, why the change from sircmpwn/aerc to ~rjarry/aerc?

Drew DeVault stopped maintaining aerc, so rjarry forked it -.o.-

> Likewise, why has the 'wrap-program' been dropped in aerc?

Not sure why that wrap-program was there in the first place. Maybe
aerc invoked some ncurses program at one point? Strange thing to do.
Anyway, the PATH change isn't required anymore, so the wrap-program
isn't either. aerc *does* invoke colordiff for displaying some
messages, but I'm pretty sure that invoked programs shouldn't 

> Please mention such things in the cover letter.

This patchset was actually done from scratch; I didn't include any
of the original code, and I hadn't actually looked at it, since aerc
has changed quite a lot.




This bug report was last modified 2 years and 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.