GNU bug report logs - #55901
[PATCH WIP] gnu: Add lis.

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Sat, 11 Jun 2022 07:52:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 55901 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 55901 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Eric Bavier <bavier <at> posteo.net>
Subject: Re: [PATCH v2] gnu: Add lis.
Date: Wed, 26 Mar 2025 14:44:32 +0100
[Message part 1 (text/plain, inline)]
Am Wed, Mar 26, 2025 at 02:08:38PM +0100 schrieb Liliana Marie Prikler:
> > The patch looks good, I have made a small modification to avoid the
> > assoc-ref, see attached. Please feel free to push.
> Did you send the right file?  It lools like the assoc-ref is still
> there.  I know we could use #$output, but I don't feel too strongly
> about it.  WDYT?

Ah, sorry, I had probably forgotten to commit the local changes. Here it is.
I would say that #$output goes together with all the "modernising" changes
to packaging such as gexps, not using assoc-ref, not ending a phase with #t,
so I would prefer it.

Andreas

[0001-gnu-Add-lis.patch (text/plain, attachment)]

This bug report was last modified 53 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.