GNU bug report logs - #55897
[PATCH] bindat (str, strz): Convert to unibyte when packing

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55897: closed ([PATCH] bindat (str, strz): Convert to unibyte
 when packing)
Date: Sun, 12 Jun 2022 07:02:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 12 Jun 2022 10:00:42 +0300
with message-id <83h74qwelh.fsf <at> gnu.org>
and subject line Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when packing
has caused the debbugs.gnu.org bug report #55897,
regarding [PATCH] bindat (str, strz): Convert to unibyte when packing
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55897: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55897
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] bindat (str, strz): Convert to unibyte when packing
Date: Sat, 11 Jun 2022 00:38:00 -0400

[Message part 3 (text/plain, inline)]

X-Debbugs-CC: monnier <at> iro.umontreal.ca

Two patches attached:

Patch 1:

    bindat (str, strz): Reject multibyte input strings

    * lisp/emacs-lisp/bindat.el (str) (strz): Signal an error if the user
    attempts to pack a multibyte string.
    * test/lisp/emacs-lisp/bindat-tests.el (str) (strz): Add tests.

Patch 2:

    bindat (str, strz): Convert to unibyte when packing

    * lisp/emacs-lisp/bindat.el (str) (strz): Allow callers to pack a
    multibyte string if it only contains ASCII and `eight-bit' characters.
    * doc/lispref/processes.texi (Bindat Types): Update documentation.
    * test/lisp/emacs-lisp/bindat-tests.el (str) (strz): Update tests.

[0001-bindat-str-strz-Reject-multibyte-input-strings.patch (text/x-patch, attachment)]

[0002-bindat-str-strz-Convert-to-unibyte-when-packing.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

[Message part 7 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 55897-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when
 packing
Date: Sun, 12 Jun 2022 10:00:42 +0300

> Date: Sun, 12 Jun 2022 01:23:17 -0400
> Cc: 55897 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> > Please instead make a single change which incorporates both.
> 
> Done; see attached.
> 
> > P.S. Please also mention the bug number in the log message of the next
> > version of the patch, since the number is now known.
> 
> Done.

Thanks, installed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.